Re: [Xen-devel] [Qemu-devel] [PATCH v5 06/10] qobject: Use simpler QDict/QList scalar insertion macros

2017-05-09 Thread Markus Armbruster
Alberto Garcia writes: > On Fri 28 Apr 2017 10:33:36 AM CEST, Markus Armbruster wrote: >>> v5: rebase to master (Coccinelle found a couple new spots), squash 3 >>> patches into 1, adjust R-b to only list Markus (while there were other >>> reviews on the pre-squashed patches,

Re: [Xen-devel] [Qemu-devel] [PATCH v5 06/10] qobject: Use simpler QDict/QList scalar insertion macros

2017-05-08 Thread Alberto Garcia
On Fri 28 Apr 2017 10:33:36 AM CEST, Markus Armbruster wrote: >> v5: rebase to master (Coccinelle found a couple new spots), squash 3 >> patches into 1, adjust R-b to only list Markus (while there were other >> reviews on the pre-squashed patches, Markus was the only one on all 3) > > The block:

Re: [Xen-devel] [Qemu-devel] [PATCH v5 06/10] qobject: Use simpler QDict/QList scalar insertion macros

2017-05-02 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Fri, Apr 28, 2017 at 10:33:36AM +0200, Markus Armbruster wrote: >> Eric Blake writes: >> >> > We now have macros in place to make it less verbose to add a scalar >> > to QDict and QList, so use them. To make this patch

Re: [Xen-devel] [Qemu-devel] [PATCH v5 06/10] qobject: Use simpler QDict/QList scalar insertion macros

2017-05-02 Thread Stefan Hajnoczi
On Fri, Apr 28, 2017 at 10:33:36AM +0200, Markus Armbruster wrote: > Eric Blake writes: > > > We now have macros in place to make it less verbose to add a scalar > > to QDict and QList, so use them. To make this patch smaller to > > review, a couple of subdirectories were

Re: [Xen-devel] [Qemu-devel] [PATCH v5 06/10] qobject: Use simpler QDict/QList scalar insertion macros

2017-04-28 Thread Markus Armbruster
Eric Blake writes: > We now have macros in place to make it less verbose to add a scalar > to QDict and QList, so use them. To make this patch smaller to > review, a couple of subdirectories were done in earlier patches. Scratch the last sentence. Can do on commit. > Patch