Chen, Tiejun tiejun.c...@intel.com 05/14/15 7:48 AM
On 2015/5/11 18:57, Jan Beulich wrote:
Yeah, the constant name probably shouldn't refer to PCI, but simply
to pass-through.
What about XEN_DOMCTL_DEV_RDM_XXX? I mean this may be specific to
device, right?
Fine with me.
Jan
Hi Chen,
On 14/05/15 06:47, Chen, Tiejun wrote:
This assign_device callback deals with the latter. So from the name the
value doesn't look right.
What about XEN_DOMCTL_DEV_RDM_XXX?
That would be better naming.
I would also add a XEN_DOMCTL_DEV_NO_RDM that would be use for non-PCI
On 2015/5/11 17:51, Julien Grall wrote:
Hi,
On 11/05/15 09:42, Chen, Tiejun wrote:
diff --git a/xen/drivers/passthrough/arm/smmu.c
b/xen/drivers/passthrough/arm/smmu.c
index 8a9b58b..a3e6383 100644
--- a/xen/drivers/passthrough/arm/smmu.c
+++ b/xen/drivers/passthrough/arm/smmu.c
@@ -2599,7
On 2015/5/11 18:57, Jan Beulich wrote:
On 11.05.15 at 11:51, julien.gr...@citrix.com wrote:
Hi,
On 11/05/15 09:42, Chen, Tiejun wrote:
diff --git a/xen/drivers/passthrough/arm/smmu.c
b/xen/drivers/passthrough/arm/smmu.c
index 8a9b58b..a3e6383 100644
--- a/xen/drivers/passthrough/arm/smmu.c
On 2015/5/9 0:07, Julien Grall wrote:
Hi,
On 10/04/15 10:21, Tiejun Chen wrote:
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index ca0e51e..e5ba7cb 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -493,6 +493,10 @@
On 11.05.15 at 11:51, julien.gr...@citrix.com wrote:
Hi,
On 11/05/15 09:42, Chen, Tiejun wrote:
diff --git a/xen/drivers/passthrough/arm/smmu.c
b/xen/drivers/passthrough/arm/smmu.c
index 8a9b58b..a3e6383 100644
--- a/xen/drivers/passthrough/arm/smmu.c
+++
Sorry for this delay response.
On 2015/4/20 21:36, Jan Beulich wrote:
On 10.04.15 at 11:21, tiejun.c...@intel.com wrote:
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -1793,8 +1793,14 @@ static void iommu_set_pgd(struct domain *d)
Hi,
On 11/05/15 09:42, Chen, Tiejun wrote:
diff --git a/xen/drivers/passthrough/arm/smmu.c
b/xen/drivers/passthrough/arm/smmu.c
index 8a9b58b..a3e6383 100644
--- a/xen/drivers/passthrough/arm/smmu.c
+++ b/xen/drivers/passthrough/arm/smmu.c
@@ -2599,7 +2599,7 @@ static void
Hi,
On 10/04/15 10:21, Tiejun Chen wrote:
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index ca0e51e..e5ba7cb 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -493,6 +493,10 @@ DEFINE_XEN_GUEST_HANDLE(xen_domctl_sendtrigger_t);
/*
From: Jan Beulich [mailto:jbeul...@suse.com]
Sent: Thursday, April 23, 2015 10:00 PM
On 23.04.15 at 14:32, tiejun.c...@intel.com wrote:
On 2015/4/16 23:40, Tim Deegan wrote:
At 17:21 +0800 on 10 Apr (1428686518), Tiejun Chen wrote:
@@ -1851,7 +1857,14 @@ static int
At 14:59 +0100 on 23 Apr (1429801184), Jan Beulich wrote:
On 23.04.15 at 14:32, tiejun.c...@intel.com wrote:
On 2015/4/16 23:40, Tim Deegan wrote:
At 17:21 +0800 on 10 Apr (1428686518), Tiejun Chen wrote:
@@ -1851,7 +1857,14 @@ static int rmrr_identity_mapping(struct domain *d,
bool_t
On 23.04.15 at 14:32, tiejun.c...@intel.com wrote:
On 2015/4/16 23:40, Tim Deegan wrote:
At 17:21 +0800 on 10 Apr (1428686518), Tiejun Chen wrote:
@@ -1851,7 +1857,14 @@ static int rmrr_identity_mapping(struct domain *d,
bool_t map,
if ( !is_hardware_domain(d) )
{
At 20:32 +0800 on 23 Apr (1429821151), Chen, Tiejun wrote:
+if ( flag == XEN_DOMCTL_PCIDEV_RDM_TRY )
+{
+printk(XENLOG_G_WARNING Some devices may work failed
.\n);
This is a bit cryptic. How about:
RMRR map failed. Device
On 2015/4/16 23:40, Tim Deegan wrote:
Hi,
At 17:21 +0800 on 10 Apr (1428686518), Tiejun Chen wrote:
+/*
+ * In some cases, e.g. add a device to hwdomain, and remove a device from
+ * user domain, 'try' is fine enough since this is always safe to hwdomain.
+ */
+#define
On 10.04.15 at 11:21, tiejun.c...@intel.com wrote:
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -1793,8 +1793,14 @@ static void iommu_set_pgd(struct domain *d)
hd-arch.pgd_maddr = pagetable_get_paddr(pagetable_from_mfn(pgd_mfn));
}
+/*
+ *
Hi,
At 17:21 +0800 on 10 Apr (1428686518), Tiejun Chen wrote:
+/*
+ * In some cases, e.g. add a device to hwdomain, and remove a device from
+ * user domain, 'try' is fine enough since this is always safe to hwdomain.
+ */
+#define XEN_DOMCTL_PCIDEV_RDM_DEFAULT XEN_DOMCTL_PCIDEV_RDM_TRY
Do
16 matches
Mail list logo
