Re: [Xen-devel] [RFC PATCH 03/19] xen/arm: its: Port ITS driver to xen

2015-03-16 Thread Julien Grall
On 16/03/15 16:03, Vijay Kilari wrote: Those 2 functions seems useful for me. Why did you drop them? >>> >>> These are callbacks registered for msi_chip in linux, Since we have removed >>> msi_chip from its_node structure, these functions are supposed to be >>> removed. >> >> How do you regis

Re: [Xen-devel] [RFC PATCH 03/19] xen/arm: its: Port ITS driver to xen

2015-03-16 Thread Vijay Kilari
On Mon, Mar 16, 2015 at 7:50 PM, Julien Grall wrote: > On 16/03/15 14:06, Vijay Kilari wrote: @@ -343,17 +357,23 @@ static int its_queue_full(struct its_node *its) static struct its_cmd_block *its_allocate_entry(struct its_node *its) { struct its_cmd_block *cmd;

Re: [Xen-devel] [RFC PATCH 03/19] xen/arm: its: Port ITS driver to xen

2015-03-16 Thread Julien Grall
On 16/03/15 14:06, Vijay Kilari wrote: >>> @@ -343,17 +357,23 @@ static int its_queue_full(struct its_node *its) >>> static struct its_cmd_block *its_allocate_entry(struct its_node *its) >>> { >>> struct its_cmd_block *cmd; >>> -u32 count = 100;/* 1s! */ >>> +bool_t timeou

Re: [Xen-devel] [RFC PATCH 03/19] xen/arm: its: Port ITS driver to xen

2015-03-16 Thread Vijay Kilari
Hi Julien, On Fri, Mar 13, 2015 at 5:16 PM, Julien Grall wrote: > Hello Vijay, > > On 02/03/2015 12:30, vijay.kil...@gmail.com wrote: >> >> @@ -228,10 +242,10 @@ static struct its_collection >> *its_build_mapd_cmd(struct its_cmd_block *cmd, >>st

Re: [Xen-devel] [RFC PATCH 03/19] xen/arm: its: Port ITS driver to xen

2015-03-13 Thread Julien Grall
Hello Vijay, On 02/03/2015 12:30, vijay.kil...@gmail.com wrote: @@ -228,10 +242,10 @@ static struct its_collection *its_build_mapd_cmd(struct its_cmd_block *cmd, struct its_cmd_desc *desc) { unsigned long itt_addr; -u8 size = max(or

[Xen-devel] [RFC PATCH 03/19] xen/arm: its: Port ITS driver to xen

2015-03-02 Thread vijay . kilari
From: Vijaya Kumar K This patch just makes ITS driver taken from linux compiles in xen environment. The following changes are done - memory allocation apis are changed - raw spin lock api's changed to normal spin lock api's - debug prints changed to xen debug prints - remove msi chip functio