Re: [Xen-devel] [RFC PATCH v3 05/18] xen/arm: ITS: Port ITS driver to xen

2015-06-29 Thread Ian Campbell
On Mon, 2015-06-29 at 21:17 +0530, Vijay Kilari wrote: > On Mon, Jun 29, 2015 at 9:13 PM, Vijay Kilari wrote: > > On Mon, Jun 29, 2015 at 5:09 PM, Ian Campbell > > wrote: > >> On Mon, 2015-06-22 at 17:31 +0530, vijay.kil...@gmail.com wrote: > >> [...] > >>> +/* > >>> + * ITS command descriptors

Re: [Xen-devel] [RFC PATCH v3 05/18] xen/arm: ITS: Port ITS driver to xen

2015-06-29 Thread Vijay Kilari
On Mon, Jun 29, 2015 at 9:13 PM, Vijay Kilari wrote: > On Mon, Jun 29, 2015 at 5:09 PM, Ian Campbell wrote: >> On Mon, 2015-06-22 at 17:31 +0530, vijay.kil...@gmail.com wrote: >> [...] >>> +/* >>> + * ITS command descriptors - parameters to be encoded in a command >>> + * block. >>> + */ >>> +str

Re: [Xen-devel] [RFC PATCH v3 05/18] xen/arm: ITS: Port ITS driver to xen

2015-06-29 Thread Vijay Kilari
On Mon, Jun 29, 2015 at 5:09 PM, Ian Campbell wrote: > On Mon, 2015-06-22 at 17:31 +0530, vijay.kil...@gmail.com wrote: > [...] >> +/* >> + * ITS command descriptors - parameters to be encoded in a command >> + * block. >> + */ >> +struct its_cmd_desc { >> +union { >> +struct { >> +

Re: [Xen-devel] [RFC PATCH v3 05/18] xen/arm: ITS: Port ITS driver to xen

2015-06-29 Thread Ian Campbell
On Mon, 2015-06-22 at 17:31 +0530, vijay.kil...@gmail.com wrote: [...] > +/* > + * ITS command descriptors - parameters to be encoded in a command > + * block. > + */ > +struct its_cmd_desc { > +union { > +struct { > +struct its_collection *col; > +u32 event_id;

Re: [Xen-devel] [RFC PATCH v3 05/18] xen/arm: ITS: Port ITS driver to xen

2015-06-26 Thread Julien Grall
On 26/06/2015 11:19, Vijay Kilari wrote: Hi Julien, Hi Vijay, On Mon, Jun 22, 2015 at 10:46 PM, Julien Grall wrote: Hi, +cmd->mapd.cmd = GITS_CMD_MAPD; +cmd->mapd.devid = desc->its_mapd_cmd.dev->device_id; +cmd->mapd.size = size - 1; +cmd->mapd.itt = itt_addr >> 8; I

Re: [Xen-devel] [RFC PATCH v3 05/18] xen/arm: ITS: Port ITS driver to xen

2015-06-26 Thread Vijay Kilari
Hi Julien, On Mon, Jun 22, 2015 at 10:46 PM, Julien Grall wrote: > Hi, >> +cmd->mapd.cmd = GITS_CMD_MAPD; >> +cmd->mapd.devid = desc->its_mapd_cmd.dev->device_id; >> +cmd->mapd.size = size - 1; >> +cmd->mapd.itt = itt_addr >> 8; > > I think the code is more difficult to read with

Re: [Xen-devel] [RFC PATCH v3 05/18] xen/arm: ITS: Port ITS driver to xen

2015-06-22 Thread Julien Grall
Hi, On 22/06/15 13:01, vijay.kil...@gmail.com wrote: > From: Vijaya Kumar K > > Only required changes from Linux ITS driver is ported > and compiled Can you list the changes you took from Linux? The coding style is not the same so it's hard to know what is the difference. It would also have be

[Xen-devel] [RFC PATCH v3 05/18] xen/arm: ITS: Port ITS driver to xen

2015-06-22 Thread vijay . kilari
From: Vijaya Kumar K Only required changes from Linux ITS driver is ported and compiled Signed-off-by: Vijaya Kumar K --- v3: - Only required changes from Linux ITS driver is ported - Xen coding style is followed. --- xen/arch/arm/Makefile |1 + xen/arch/arm/gic-v3-its.c