Re: [Xen-devel] [V2 PATCH 7/9] x86/hvm: pkeys, add pkeys support for guest_walk_tables

On Tue, 2015-12-01 at 20:30 +, Andrew Cooper wrote: > > +#include > > I can see why you need xstate.h, but I why do you need i387.h ? Use vcpu_save_fpu functions. > > + > > if ( pse2M ) > > { > > /* Special case: this guest VA is in a PSE superpage, so > > there's > > @@

Re: [Xen-devel] [V2 PATCH 7/9] x86/hvm: pkeys, add pkeys support for guest_walk_tables

>>> On 27.11.15 at 10:52, wrote: > @@ -90,6 +92,53 @@ static uint32_t set_ad_bits(void *guest_p, void *walk_p, > int set_dirty) > return 0; > } > > +#if GUEST_PAGING_LEVELS >= 4 > +uint32_t leaf_pte_pkeys_check(struct vcpu *vcpu, uint32_t pfec, > +

Re: [Xen-devel] [V2 PATCH 7/9] x86/hvm: pkeys, add pkeys support for guest_walk_tables

>>> On 27.11.15 at 10:52, wrote: > @@ -90,6 +92,53 @@ static uint32_t set_ad_bits(void *guest_p, void *walk_p, > int set_dirty) > return 0; > } > > +#if GUEST_PAGING_LEVELS >= 4 > +uint32_t leaf_pte_pkeys_check(struct vcpu *vcpu, uint32_t pfec, > +

Re: [Xen-devel] [V2 PATCH 7/9] x86/hvm: pkeys, add pkeys support for guest_walk_tables

>>> On 02.12.15 at 09:23, wrote: > On Tue, 2015-12-01 at 20:30 +, Andrew Cooper wrote: >> > +#include >> >> I can see why you need xstate.h, but I why do you need i387.h ? > Use vcpu_save_fpu functions. Which is bogus by itself: That function isn't meant to be used

Re: [Xen-devel] [V2 PATCH 7/9] x86/hvm: pkeys, add pkeys support for guest_walk_tables

On 27/11/15 09:52, Huaitong Han wrote: > This patch adds pkeys support for guest_walk_tables. > > Signed-off-by: Huaitong Han You must CC the appropriate maintainer for this patch, which includes the x86 MM maintainer. > --- > xen/arch/x86/mm/guest_walk.c | 65 >

[Xen-devel] [V2 PATCH 7/9] x86/hvm: pkeys, add pkeys support for guest_walk_tables

This patch adds pkeys support for guest_walk_tables. Signed-off-by: Huaitong Han --- xen/arch/x86/mm/guest_walk.c | 65 +++ xen/include/asm-x86/hvm/hvm.h | 2 ++ 2 files changed, 67 insertions(+) diff --git