Re: [Xen-devel] [V4] x86/cpuidle: get accurate C0 value with xenpm tool

2015-05-12 Thread Jan Beulich
>>> On 11.05.15 at 16:12, wrote: > On Mon, 2015-05-11 at 12:10 +0100, Jan Beulich wrote: >> >>> On 11.05.15 at 11:34, wrote: >> > @@ -1203,16 +1226,18 @@ int pmstat_get_cx_stat(uint32_t cpuid, struct >> > pm_cx_stat *stat) >> > >> > stat->nr = power->count; >> > >> > +spin_l

Re: [Xen-devel] [V4] x86/cpuidle: get accurate C0 value with xenpm tool

2015-05-11 Thread Han, Huaitong
On Mon, 2015-05-11 at 12:10 +0100, Jan Beulich wrote: > >>> On 11.05.15 at 11:34, wrote: > > --- > > ChangeLog: > > V4: > > delete pointless initializers and hard tabs. > > Thanks, but ... > > > V3: > > 1.Don't use tick_to_ns inside lock in print_acpi_power. > > ... note that this also was not

Re: [Xen-devel] [V4] x86/cpuidle: get accurate C0 value with xenpm tool

2015-05-11 Thread Jan Beulich
>>> On 11.05.15 at 11:34, wrote: > --- > ChangeLog: > V4: > delete pointless initializers and hard tabs. Thanks, but ... > V3: > 1.Don't use tick_to_ns inside lock in print_acpi_power. ... note that this also was not fully done: > --- a/xen/arch/x86/acpi/cpu_idle.c > +++ b/xen/arch/x86/acpi/cp

[Xen-devel] [V4] x86/cpuidle: get accurate C0 value with xenpm tool

2015-05-11 Thread Huaitong Han
When checking the ACPI funciton of C-status, after 100 seconds sleep, the sampling value of C0 status from the xenpm tool decreases. Because C0=NOW()-C1-C2-C3-C4, when NOW() value is during idle time, NOW() value is bigger than last C-status update time, and C0 value is also bigger than ture value.