Re: [Xen-devel] [XTF PATCH v2] xtf-runner: support two modes for getting output

2016-08-15 Thread Wei Liu
On Fri, Aug 12, 2016 at 10:51:37AM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [XTF PATCH v2] xtf-runner: support two modes for getting > output"): > > On Thu, Aug 11, 2016 at 07:29:00PM +0100, Ian Jackson wrote: > > > We don't care when xenconsoled closes the logfile. We care about when > >

Re: [Xen-devel] [XTF PATCH v2] xtf-runner: support two modes for getting output

2016-08-12 Thread Wei Liu
On Fri, Aug 12, 2016 at 10:51:37AM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [XTF PATCH v2] xtf-runner: support two modes for getting > output"): > > On Thu, Aug 11, 2016 at 07:29:00PM +0100, Ian Jackson wrote: > > > We don't care when xenconsoled closes the logfile. We care about when > >

Re: [Xen-devel] [XTF PATCH v2] xtf-runner: support two modes for getting output

2016-08-12 Thread Ian Jackson
Wei Liu writes ("Re: [XTF PATCH v2] xtf-runner: support two modes for getting output"): > On Thu, Aug 11, 2016 at 07:29:00PM +0100, Ian Jackson wrote: > > We don't care when xenconsoled closes the logfile. We care about when > > it last calls write() (with a nonempty buffer). > > In logfile mode

Re: [Xen-devel] [XTF PATCH v2] xtf-runner: support two modes for getting output

2016-08-12 Thread Wei Liu
On Thu, Aug 11, 2016 at 07:29:00PM +0100, Ian Jackson wrote: > Andrew Cooper writes ("Re: [XTF PATCH v2] xtf-runner: support two modes for > getting output"): > > On 11/08/16 18:51, Wei Liu wrote: > > > I'm pretty out of idea here. > > > > Because of XTF's behaviour (waiting for xenconsoled to ca

Re: [Xen-devel] [XTF PATCH v2] xtf-runner: support two modes for getting output

2016-08-11 Thread Ian Jackson
Andrew Cooper writes ("Re: [XTF PATCH v2] xtf-runner: support two modes for getting output"): > On 11/08/16 18:51, Wei Liu wrote: > > I'm pretty out of idea here. > > Because of XTF's behaviour (waiting for xenconsoled to catch up), you > know for certain that once `xl create` has finished, nothi

Re: [Xen-devel] [XTF PATCH v2] xtf-runner: support two modes for getting output

2016-08-11 Thread Andrew Cooper
On 11/08/16 18:51, Wei Liu wrote: > On Thu, Aug 11, 2016 at 06:17:31PM +0100, Ian Jackson wrote: >> Wei Liu writes ("Re: [XTF PATCH v2] xtf-runner: support two modes for >> getting output"): >>> On Thu, Aug 11, 2016 at 05:27:56PM +0100, Ian Jackson wrote: This is perverse. Why not just open

Re: [Xen-devel] [XTF PATCH v2] xtf-runner: support two modes for getting output

2016-08-11 Thread Wei Liu
On Thu, Aug 11, 2016 at 06:17:31PM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [XTF PATCH v2] xtf-runner: support two modes for getting > output"): > > On Thu, Aug 11, 2016 at 05:27:56PM +0100, Ian Jackson wrote: > > > This is perverse. Why not just open it O_CREAT|O_RDONLY ? If Python > >

Re: [Xen-devel] [XTF PATCH v2] xtf-runner: support two modes for getting output

2016-08-11 Thread Wei Liu
On Thu, Aug 11, 2016 at 06:21:55PM +0100, Andrew Cooper wrote: > On 11/08/16 18:17, Ian Jackson wrote: > > Wei Liu writes ("Re: [XTF PATCH v2] xtf-runner: support two modes for > > getting output"): > >> On Thu, Aug 11, 2016 at 05:27:56PM +0100, Ian Jackson wrote: > >>> This is perverse. Why not

Re: [Xen-devel] [XTF PATCH v2] xtf-runner: support two modes for getting output

2016-08-11 Thread Andrew Cooper
On 11/08/16 18:17, Ian Jackson wrote: > Wei Liu writes ("Re: [XTF PATCH v2] xtf-runner: support two modes for getting > output"): >> On Thu, Aug 11, 2016 at 05:27:56PM +0100, Ian Jackson wrote: >>> This is perverse. Why not just open it O_CREAT|O_RDONLY ? If Python >>> can't do that then uncondi

Re: [Xen-devel] [XTF PATCH v2] xtf-runner: support two modes for getting output

2016-08-11 Thread Ian Jackson
Wei Liu writes ("Re: [XTF PATCH v2] xtf-runner: support two modes for getting output"): > On Thu, Aug 11, 2016 at 05:27:56PM +0100, Ian Jackson wrote: > > This is perverse. Why not just open it O_CREAT|O_RDONLY ? If Python > > can't do that then unconditionally opening it O_CREAT|O_RDWR would do

Re: [Xen-devel] [XTF PATCH v2] xtf-runner: support two modes for getting output

2016-08-11 Thread Wei Liu
On Thu, Aug 11, 2016 at 05:27:56PM +0100, Ian Jackson wrote: > Wei Liu writes ("[XTF PATCH v2] xtf-runner: support two modes for getting > output"): > > We need two modes for getting output: > ... > > +logfile = open(fn, "rb") > > +except IOError as e: > > +# Create file if it

Re: [Xen-devel] [XTF PATCH v2] xtf-runner: support two modes for getting output

2016-08-11 Thread Ian Jackson
Wei Liu writes ("[XTF PATCH v2] xtf-runner: support two modes for getting output"): > We need two modes for getting output: ... > +logfile = open(fn, "rb") > +except IOError as e: > +# Create file if it doesn't exist > +if e.errno == 2: > +logfile = open(fn,

[Xen-devel] [XTF PATCH v2] xtf-runner: support two modes for getting output

2016-08-11 Thread Wei Liu
We need two modes for getting output: 1. Use console directly with newer (>=4.8) Xen 2. Use log files for older Xen This patch implements both. The default behaviour is to use the console mode. Signed-off-by: Wei Liu --- v2: delete auto selection mode, squash all patches into one. --- xtf-runn