Re: [Xen-devel] [for-4.7 1/2] xen/arm: p2m: apply_p2m_changes: Do not undo more than necessary

2016-05-17 Thread Stefano Stabellini
On Mon, 16 May 2016, Julien Grall wrote: > Since commit 4b25423a "arch/arm: unmap partially-mapped memory regions", > Xen has been undoing the P2M mappings when an error occurred during > insertion or memory allocation. > > The function apply_p2m_changes can work with region not-aligned to a > blo

Re: [Xen-devel] [for-4.7 1/2] xen/arm: p2m: apply_p2m_changes: Do not undo more than necessary

2016-05-17 Thread Julien Grall
On 17/05/2016 07:40, Wei Chen wrote: Hi Julien, Hi Wei, Please avoid top-posting on the mailing list. This code looks good to me. Thank you for the review. Reviewed-by: Wei Chen Regards, -- Julien Grall ___ Xen-devel mailing list Xen-dev

Re: [Xen-devel] [for-4.7 1/2] xen/arm: p2m: apply_p2m_changes: Do not undo more than necessary

2016-05-16 Thread Wei Chen
Hi Julien, This code looks good to me. Reviewed-by: Wei Chen On 2016/5/16 22:08, Julien Grall wrote: Since commit 4b25423a "arch/arm: unmap partially-mapped memory regions", Xen has been undoing the P2M mappings when an error occurred during insertion or memory allocation. The function apply

[Xen-devel] [for-4.7 1/2] xen/arm: p2m: apply_p2m_changes: Do not undo more than necessary

2016-05-16 Thread Julien Grall
Since commit 4b25423a "arch/arm: unmap partially-mapped memory regions", Xen has been undoing the P2M mappings when an error occurred during insertion or memory allocation. The function apply_p2m_changes can work with region not-aligned to a block size (2MB, 1G) or page size (4K). The mapping will