Re: [Xen-devel] [v2 01/11] vmx: add new boot parameter to control PML enabling

2015-04-15 Thread Jan Beulich
>>> On 15.04.15 at 15:20, wrote: > On Wed, Apr 15, 2015 at 8:20 PM, Jan Beulich wrote: > On 15.04.15 at 09:03, wrote: >>> +static void __init parse_ept_param(char *s) >>> +{ >>> +char *ss; >>> +int val; >> >> bool_t, and would better move ... >> >>> + >>> +do { >>> +val =

Re: [Xen-devel] [v2 01/11] vmx: add new boot parameter to control PML enabling

2015-04-15 Thread Kai Huang
On Wed, Apr 15, 2015 at 8:20 PM, Jan Beulich wrote: On 15.04.15 at 09:03, wrote: >> +static void __init parse_ept_param(char *s) >> +{ >> +char *ss; >> +int val; > > bool_t, and would better move ... > >> + >> +do { >> +val = !!strncmp(s, "no-", 3); > > ... here (making t

Re: [Xen-devel] [v2 01/11] vmx: add new boot parameter to control PML enabling

2015-04-15 Thread Jan Beulich
>>> On 15.04.15 at 09:03, wrote: > +static void __init parse_ept_param(char *s) > +{ > +char *ss; > +int val; bool_t, and would better move ... > + > +do { > +val = !!strncmp(s, "no-", 3); ... here (making the right side expression its intializer). Jan ___

Re: [Xen-devel] [v2 01/11] vmx: add new boot parameter to control PML enabling

2015-04-15 Thread Andrew Cooper
On 15/04/15 08:03, Kai Huang wrote: > A top level EPT parameter "ept=" and a sub boolean "opt_pml_enabled" > are added to control PML. Other booleans can be further added for any other > EPT > related features. > > Signed-off-by: Kai Huang Reviewed-by: Andrew Cooper > --- > xen/arch/x86/hvm/v

[Xen-devel] [v2 01/11] vmx: add new boot parameter to control PML enabling

2015-04-15 Thread Kai Huang
A top level EPT parameter "ept=" and a sub boolean "opt_pml_enabled" are added to control PML. Other booleans can be further added for any other EPT related features. Signed-off-by: Kai Huang --- xen/arch/x86/hvm/vmx/vmcs.c | 31 +++ 1 file changed, 31 insertions(+)