Re: [Xen-devel] [v3 10/15] vt-d: Add API to update IRTE when VT-d PI is used

2015-07-15 Thread Jan Beulich
On 15.07.15 at 10:38, feng...@intel.com wrote: -Original Message- From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Wednesday, July 15, 2015 4:25 PM To: Wu, Feng Cc: andrew.coop...@citrix.com; george.dun...@eu.citrix.com; Tian, Kevin; Zhang, Yang Z; xen-devel@lists.xen.org;

Re: [Xen-devel] [v3 10/15] vt-d: Add API to update IRTE when VT-d PI is used

2015-07-15 Thread Jan Beulich
On 15.07.15 at 10:55, feng...@intel.com wrote: From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Wednesday, July 15, 2015 4:46 PM On 15.07.15 at 10:38, feng...@intel.com wrote: From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Wednesday, July 15, 2015 4:25 PM On 15.07.15 at 08:04,

Re: [Xen-devel] [v3 10/15] vt-d: Add API to update IRTE when VT-d PI is used

2015-07-15 Thread Wu, Feng
-Original Message- From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Wednesday, July 15, 2015 4:25 PM To: Wu, Feng Cc: andrew.coop...@citrix.com; george.dun...@eu.citrix.com; Tian, Kevin; Zhang, Yang Z; xen-devel@lists.xen.org; k...@xen.org Subject: RE: [v3 10/15] vt-d: Add API

Re: [Xen-devel] [v3 10/15] vt-d: Add API to update IRTE when VT-d PI is used

2015-07-15 Thread Wu, Feng
-Original Message- From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Wednesday, July 15, 2015 4:46 PM To: Wu, Feng Cc: andrew.coop...@citrix.com; george.dun...@eu.citrix.com; Tian, Kevin; Zhang, Yang Z; xen-devel@lists.xen.org; k...@xen.org Subject: RE: [v3 10/15] vt-d: Add API

Re: [Xen-devel] [v3 10/15] vt-d: Add API to update IRTE when VT-d PI is used

2015-07-15 Thread Jan Beulich
On 15.07.15 at 08:04, feng...@intel.com wrote: From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Friday, July 10, 2015 10:02 PM I'm particularly worried by the call to acpi_find_matched_drhd_unit() - is it maybe worth storing the iommu pointer in struct msi_desc? I think it worth, Like

Re: [Xen-devel] [v3 10/15] vt-d: Add API to update IRTE when VT-d PI is used

2015-07-15 Thread Wu, Feng
-Original Message- From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Friday, July 10, 2015 10:02 PM To: Wu, Feng Cc: andrew.coop...@citrix.com; george.dun...@eu.citrix.com; Tian, Kevin; Zhang, Yang Z; xen-devel@lists.xen.org; k...@xen.org Subject: Re: [v3 10/15] vt-d: Add API to

Re: [Xen-devel] [v3 10/15] vt-d: Add API to update IRTE when VT-d PI is used

2015-07-10 Thread Jan Beulich
On 24.06.15 at 07:18, feng...@intel.com wrote: This patch adds an API which is used to update the IRTE for posted-interrupt when guest changes MSI/MSI-X information. This is again an example where adding a dead function complicates review: How will I know here why this statement is correct,

Re: [Xen-devel] [v3 10/15] vt-d: Add API to update IRTE when VT-d PI is used

2015-07-08 Thread Tian, Kevin
From: Wu, Feng Sent: Wednesday, June 24, 2015 1:18 PM This patch adds an API which is used to update the IRTE for posted-interrupt when guest changes MSI/MSI-X information. Signed-off-by: Feng Wu feng...@intel.com Acked-by: Kevin Tian kevin.t...@intel.com, with one small comment: +int

Re: [Xen-devel] [v3 10/15] vt-d: Add API to update IRTE when VT-d PI is used

2015-07-08 Thread Wu, Feng
-Original Message- From: Tian, Kevin Sent: Wednesday, July 08, 2015 6:00 PM To: Wu, Feng; xen-devel@lists.xen.org Cc: k...@xen.org; jbeul...@suse.com; andrew.coop...@citrix.com; Zhang, Yang Z; george.dun...@eu.citrix.com Subject: RE: [v3 10/15] vt-d: Add API to update IRTE when

Re: [Xen-devel] [v3 10/15] vt-d: Add API to update IRTE when VT-d PI is used

2015-06-29 Thread Andrew Cooper
On 24/06/15 06:18, Feng Wu wrote: This patch adds an API which is used to update the IRTE for posted-interrupt when guest changes MSI/MSI-X information. Signed-off-by: Feng Wu feng...@intel.com --- v3: - Remove adding PDA_MASK() when updating 'pda_l' and 'pda_h' for IRTE. - Change the

[Xen-devel] [v3 10/15] vt-d: Add API to update IRTE when VT-d PI is used

2015-06-23 Thread Feng Wu
This patch adds an API which is used to update the IRTE for posted-interrupt when guest changes MSI/MSI-X information. Signed-off-by: Feng Wu feng...@intel.com --- v3: - Remove adding PDA_MASK() when updating 'pda_l' and 'pda_h' for IRTE. - Change the return type of pi_update_irte() to int. -