[Xen-devel] [v3 10/15] vt-d: Add API to update IRTE when VT-d PI is used

2015-06-23 Thread Feng Wu
This patch adds an API which is used to update the IRTE for posted-interrupt when guest changes MSI/MSI-X information. Signed-off-by: Feng Wu --- v3: - Remove "adding PDA_MASK()" when updating 'pda_l' and 'pda_h' for IRTE. - Change the return type of pi_update_irte() to int. - Remove some pointle

Re: [Xen-devel] [v3 10/15] vt-d: Add API to update IRTE when VT-d PI is used

2015-06-29 Thread Andrew Cooper
On 24/06/15 06:18, Feng Wu wrote: > This patch adds an API which is used to update the IRTE > for posted-interrupt when guest changes MSI/MSI-X information. > > Signed-off-by: Feng Wu > --- > v3: > - Remove "adding PDA_MASK()" when updating 'pda_l' and 'pda_h' for IRTE. > - Change the return type

Re: [Xen-devel] [v3 10/15] vt-d: Add API to update IRTE when VT-d PI is used

2015-07-08 Thread Tian, Kevin
> From: Wu, Feng > Sent: Wednesday, June 24, 2015 1:18 PM > > This patch adds an API which is used to update the IRTE > for posted-interrupt when guest changes MSI/MSI-X information. > > Signed-off-by: Feng Wu Acked-by: Kevin Tian , with one small comment: > +int pi_update_irte(struct vcpu *v,

Re: [Xen-devel] [v3 10/15] vt-d: Add API to update IRTE when VT-d PI is used

2015-07-08 Thread Wu, Feng
> -Original Message- > From: Tian, Kevin > Sent: Wednesday, July 08, 2015 6:00 PM > To: Wu, Feng; xen-devel@lists.xen.org > Cc: k...@xen.org; jbeul...@suse.com; andrew.coop...@citrix.com; Zhang, > Yang Z; george.dun...@eu.citrix.com > Subject: RE: [v3 10/15] vt-d: Add API to update IRTE w

Re: [Xen-devel] [v3 10/15] vt-d: Add API to update IRTE when VT-d PI is used

2015-07-10 Thread Jan Beulich
>>> On 24.06.15 at 07:18, wrote: > This patch adds an API which is used to update the IRTE > for posted-interrupt when guest changes MSI/MSI-X information. This is again an example where adding a dead function complicates review: How will I know here why this statement is correct, namely why MSI/

Re: [Xen-devel] [v3 10/15] vt-d: Add API to update IRTE when VT-d PI is used

2015-07-14 Thread Wu, Feng
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Friday, July 10, 2015 10:02 PM > To: Wu, Feng > Cc: andrew.coop...@citrix.com; george.dun...@eu.citrix.com; Tian, Kevin; > Zhang, Yang Z; xen-devel@lists.xen.org; k...@xen.org > Subject: Re: [v3 10/15] vt-d: Add A

Re: [Xen-devel] [v3 10/15] vt-d: Add API to update IRTE when VT-d PI is used

2015-07-15 Thread Jan Beulich
>>> On 15.07.15 at 08:04, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Friday, July 10, 2015 10:02 PM >> I'm particularly worried by the call to acpi_find_matched_drhd_unit() >> - is it maybe worth storing the iommu pointer in struct msi_desc? > > I think it worth, Like Andrew

Re: [Xen-devel] [v3 10/15] vt-d: Add API to update IRTE when VT-d PI is used

2015-07-15 Thread Wu, Feng
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Wednesday, July 15, 2015 4:25 PM > To: Wu, Feng > Cc: andrew.coop...@citrix.com; george.dun...@eu.citrix.com; Tian, Kevin; > Zhang, Yang Z; xen-devel@lists.xen.org; k...@xen.org > Subject: RE: [v3 10/15] vt-d: Add

Re: [Xen-devel] [v3 10/15] vt-d: Add API to update IRTE when VT-d PI is used

2015-07-15 Thread Jan Beulich
>>> On 15.07.15 at 10:38, wrote: > >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Wednesday, July 15, 2015 4:25 PM >> To: Wu, Feng >> Cc: andrew.coop...@citrix.com; george.dun...@eu.citrix.com; Tian, Kevin; >> Zhang, Yang Z; xen-devel@lists.xen.org; k...@x

Re: [Xen-devel] [v3 10/15] vt-d: Add API to update IRTE when VT-d PI is used

2015-07-15 Thread Wu, Feng
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Wednesday, July 15, 2015 4:46 PM > To: Wu, Feng > Cc: andrew.coop...@citrix.com; george.dun...@eu.citrix.com; Tian, Kevin; > Zhang, Yang Z; xen-devel@lists.xen.org; k...@xen.org > Subject: RE: [v3 10/15] vt-d: Add

Re: [Xen-devel] [v3 10/15] vt-d: Add API to update IRTE when VT-d PI is used

2015-07-15 Thread Jan Beulich
>>> On 15.07.15 at 10:55, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Wednesday, July 15, 2015 4:46 PM >> >>> On 15.07.15 at 10:38, wrote: >> >> From: Jan Beulich [mailto:jbeul...@suse.com] >> >> Sent: Wednesday, July 15, 2015 4:25 PM >> >> >>> On 15.07.15 at 08:04, wrote: >>