Re: [Xen-devel] question about xl migrate

2016-05-17 Thread Zhang, Chunyu
hi Andrew > 2. line 125 in hvm mode,would not be a balloon page. gfn would not be INVALID_MFN. mfn would be INVALID_MFN. right? >>> I don't understand what you asking here. >> i think those code should delete: 125 /* Likely a ballooned page. */ >> if page is ba

Re: [Xen-devel] question about xl migrate

2016-05-17 Thread Andrew Cooper
>>> 2. line 125 >>> in hvm mode,would not be a balloon page. >>> gfn would not be INVALID_MFN. >>> mfn would be INVALID_MFN. >>> right? >> I don't understand what you asking here. > i think those code should delete: >>> 125 /* Likely a ballooned page. */ > if page is ballooed, gfns is not

Re: [Xen-devel] question about xl migrate

2016-05-17 Thread Zhang, Chunyu
hi Andrew >On 17/05/16 10:01, Zhang, Chunyu wrote: >> hi all >> >> i have two question about xl migrate >> >> write_batch >> 120 for ( i = 0; i < nr_pfns; ++i ) >> 121 { >> 122 types[i] = mfns[i] = ctx->save.ops.pfn_to_gfn(ctx, >> 123

Re: [Xen-devel] question about xl migrate

2016-05-17 Thread Andrew Cooper
On 17/05/16 10:01, Zhang, Chunyu wrote: > hi all > > i have two question about xl migrate > > write_batch > 120 for ( i = 0; i < nr_pfns; ++i ) > 121 { > 122 types[i] = mfns[i] = ctx->save.ops.pfn_to_gfn(ctx, > 123 > ctx->save.b

[Xen-devel] question about xl migrate

2016-05-17 Thread Zhang, Chunyu
hi all i have two question about xl migrate write_batch 120 for ( i = 0; i < nr_pfns; ++i ) 121 { 122 types[i] = mfns[i] = ctx->save.ops.pfn_to_gfn(ctx, 123 ctx->save.batch_pfns[i]); 124 125 /* Likely a ballooned page