Re: [Xen-devel] xen/x86: Question about alloc_domheap_page in pod code

2015-10-22 Thread Andrew Cooper
On 22/10/15 16:04, Julien Grall wrote: > Hi, > > I was looking to the pod code (arch/x86/mm/p2m-pod.c) and noticed that > the calls to alloc_domheap_page{s,} seems to take wrong parameter: > > page = alloc_domheap_pages(d, order, PAGE_ORDER_4K); > > p = alloc_domheap_page(d, PAGE_ORDER_4K); > > AFA

Re: [Xen-devel] xen/x86: Question about alloc_domheap_page in pod code

2015-10-22 Thread George Dunlap
On 22/10/15 16:10, Andrew Cooper wrote: > On 22/10/15 16:04, Julien Grall wrote: >> Hi, >> >> I was looking to the pod code (arch/x86/mm/p2m-pod.c) and noticed that >> the calls to alloc_domheap_page{s,} seems to take wrong parameter: >> >> page = alloc_domheap_pages(d, order, PAGE_ORDER_4K); >> >>

[Xen-devel] xen/x86: Question about alloc_domheap_page in pod code

2015-10-22 Thread Julien Grall
Hi, I was looking to the pod code (arch/x86/mm/p2m-pod.c) and noticed that the calls to alloc_domheap_page{s,} seems to take wrong parameter: page = alloc_domheap_pages(d, order, PAGE_ORDER_4K); p = alloc_domheap_page(d, PAGE_ORDER_4K); AFAICT the last parameter is the memory flags and not the