Re: [Xen-devel] [PATCH] x86/EPT: defer enabling of A/D maintenance until PML get enabled

>>> On 15.10.15 at 08:42, wrote: > Thanks for your comments Jan. Actually I am not happy with combining > with EPT A/D bit update with PML enabling to single function. After > thinking again, how about adding a separate vmx function (ex, > vmx_domain_update_eptp) to

Re: [Xen-devel] [PATCH] x86/EPT: defer enabling of A/D maintenance until PML get enabled

On 10/15/2015 03:35 PM, Kai Huang wrote: On 10/15/2015 03:11 PM, Jan Beulich wrote: On 15.10.15 at 08:42, wrote: Thanks for your comments Jan. Actually I am not happy with combining with EPT A/D bit update with PML enabling to single function. After thinking

Re: [Xen-devel] [PATCH] x86/EPT: defer enabling of A/D maintenance until PML get enabled

On 10/14/2015 05:26 PM, Jan Beulich wrote: On 14.10.15 at 11:08, wrote: After some thinking, just set/clear p2m->ept.ept_ad is not enough -- we also need to __vmwrite it to VMCS's EPTP, and then call ept_sync_domain. Ah, yes, this makes sense of course. I have

Re: [Xen-devel] [PATCH] x86/EPT: defer enabling of A/D maintenance until PML get enabled

>>> On 15.10.15 at 09:35, wrote: > On 10/15/2015 03:11 PM, Jan Beulich wrote: > On 15.10.15 at 08:42, wrote: >>> * ept_p2m_type_to_flags will do the check, and write protection >>> will be >>> * used if PML is not

Re: [Xen-devel] [PATCH] x86/EPT: defer enabling of A/D maintenance until PML get enabled

On 10/15/2015 03:11 PM, Jan Beulich wrote: On 15.10.15 at 08:42, wrote: Thanks for your comments Jan. Actually I am not happy with combining with EPT A/D bit update with PML enabling to single function. After thinking again, how about adding a separate vmx function

Re: [Xen-devel] [PATCH] x86/EPT: defer enabling of A/D maintenance until PML get enabled

Hi Jan, After some thinking, just set/clear p2m->ept.ept_ad is not enough -- we also need to __vmwrite it to VMCS's EPTP, and then call ept_sync_domain. I have verified attached patch can work. Which implementation would you prefer, existing code or with attached patch? If you prefer the

Re: [Xen-devel] [PATCH] x86/EPT: defer enabling of A/D maintenance until PML get enabled

>>> On 14.10.15 at 11:08, wrote: > After some thinking, just set/clear p2m->ept.ept_ad is not enough -- we > also need to __vmwrite it to VMCS's EPTP, and then call ept_sync_domain. Ah, yes, this makes sense of course. > I have verified attached patch can work.

Re: [Xen-devel] [PATCH] x86/EPT: defer enabling of A/D maintenance until PML get enabled

Hi Jan, Our QA tested this patch but this patch broke PML. Neither GUI display (video ram tracking also uses PML) nor live migration works. I'll investigate what's wrong and get back to you. Thanks, -Kai On 09/30/2015 08:45 PM, Kai Huang wrote: On Wed, Sep 30, 2015 at 5:54 PM, Jan Beulich

Re: [Xen-devel] [PATCH] x86/EPT: defer enabling of A/D maintenance until PML get enabled

>>> On 30.09.15 at 10:58, wrote: > Good to me, if you have tested it. Sorry I cannot test it as I am > taking vacation until Oct.8. Note how I asked for help with testing ... > On Mon, Sep 28, 2015 at 10:42 PM, Jan Beulich wrote: >> There's no point in

Re: [Xen-devel] [PATCH] x86/EPT: defer enabling of A/D maintenance until PML get enabled

Good to me, if you have tested it. Sorry I cannot test it as I am taking vacation until Oct.8. Thanks, -Kai On Mon, Sep 28, 2015 at 10:42 PM, Jan Beulich wrote: > There's no point in enabling the extra feature for every domain when > we're not meaning to use it (yet). Just

Re: [Xen-devel] [PATCH] x86/EPT: defer enabling of A/D maintenance until PML get enabled

On Wed, Sep 30, 2015 at 5:54 PM, Jan Beulich wrote: On 30.09.15 at 10:58, wrote: >> Good to me, if you have tested it. Sorry I cannot test it as I am >> taking vacation until Oct.8. > > Note how I asked for help with testing ... > >> On Mon, Sep 28,

Re: [Xen-devel] [PATCH] x86/EPT: defer enabling of A/D maintenance until PML get enabled

On 28/09/15 15:42, Jan Beulich wrote: > There's no point in enabling the extra feature for every domain when > we're not meaning to use it (yet). Just setting the flag should be > sufficient - the domain is required to be paused for PML enabling > anyway, i.e. hardware will pick up the new setting

Re: [Xen-devel] [PATCH] x86/EPT: defer enabling of A/D maintenance until PML get enabled

On Mon, Sep 28, 2015 at 3:42 PM, Jan Beulich wrote: > There's no point in enabling the extra feature for every domain when > we're not meaning to use it (yet). Just setting the flag should be > sufficient - the domain is required to be paused for PML enabling > anyway, i.e.