Re: [Xen-devel] [PATCH v4 1/9] livepatch: Clear .bss when payload is reverted

>>> On 09.09.16 at 15:50, wrote: > On Fri, Sep 09, 2016 at 02:33:18PM +0100, Ross Lagerwall wrote: >> On 08/24/2016 03:22 AM, Konrad Rzeszutek Wilk wrote: >> > So that when we apply the patch again the .bss is cleared. >> > Otherwise we may find some variables containing

Re: [Xen-devel] [PATCH v4 1/9] livepatch: Clear .bss when payload is reverted

On 09/09/2016 02:50 PM, Konrad Rzeszutek Wilk wrote: On Fri, Sep 09, 2016 at 02:33:18PM +0100, Ross Lagerwall wrote: On 08/24/2016 03:22 AM, Konrad Rzeszutek Wilk wrote: So that when we apply the patch again the .bss is cleared. Otherwise we may find some variables containing old values. The

Re: [Xen-devel] [PATCH v4 1/9] livepatch: Clear .bss when payload is reverted

On Fri, Sep 09, 2016 at 02:33:18PM +0100, Ross Lagerwall wrote: > On 08/24/2016 03:22 AM, Konrad Rzeszutek Wilk wrote: > > So that when we apply the patch again the .bss is cleared. > > Otherwise we may find some variables containing old values. > > > > The payloads may contain various .bss -

Re: [Xen-devel] [PATCH v4 1/9] livepatch: Clear .bss when payload is reverted

On 08/24/2016 03:22 AM, Konrad Rzeszutek Wilk wrote: So that when we apply the patch again the .bss is cleared. Otherwise we may find some variables containing old values. The payloads may contain various .bss - especially if -fdata-sections is used which can create .bss. sections. After

Re: [Xen-devel] [PATCH v4 1/9] livepatch: Clear .bss when payload is reverted

On Wed, Sep 07, 2016 at 02:02:44AM -0600, Jan Beulich wrote: > >>> On 06.09.16 at 18:47, wrote: > > On Wed, Aug 24, 2016 at 02:55:21AM -0600, Jan Beulich wrote: > >> >>> On 24.08.16 at 04:22, wrote: > >> > --- a/xen/common/livepatch.c > >> > +++

Re: [Xen-devel] [PATCH v4 1/9] livepatch: Clear .bss when payload is reverted

>>> On 06.09.16 at 18:51, wrote: > --- a/xen/common/livepatch_elf.c > +++ b/xen/common/livepatch_elf.c > @@ -86,7 +86,16 @@ static int elf_resolve_sections(struct livepatch_elf *elf, > const void *data) > delta < sizeof(Elf_Ehdr) ? "at ELF header" :

Re: [Xen-devel] [PATCH v4 1/9] livepatch: Clear .bss when payload is reverted

>>> On 06.09.16 at 18:47, wrote: > On Wed, Aug 24, 2016 at 02:55:21AM -0600, Jan Beulich wrote: >> >>> On 24.08.16 at 04:22, wrote: >> > --- a/xen/common/livepatch.c >> > +++ b/xen/common/livepatch.c >> > @@ -70,6 +70,9 @@ struct payload { >> >

Re: [Xen-devel] [PATCH v4 1/9] livepatch: Clear .bss when payload is reverted

On Thu, Aug 25, 2016 at 05:08:16PM +0100, Andrew Cooper wrote: > On 24/08/16 09:55, Jan Beulich wrote: > > > > > On 24.08.16 at 04:22, wrote: > > > --- a/xen/common/livepatch.c > > > +++ b/xen/common/livepatch.c > > > @@ -70,6 +70,9 @@ struct payload { > > > unsigned

Re: [Xen-devel] [PATCH v4 1/9] livepatch: Clear .bss when payload is reverted

On Wed, Aug 24, 2016 at 02:55:21AM -0600, Jan Beulich wrote: > >>> On 24.08.16 at 04:22, wrote: > > --- a/xen/common/livepatch.c > > +++ b/xen/common/livepatch.c > > @@ -70,6 +70,9 @@ struct payload { > > unsigned int nsyms; /* Nr of entries in

Re: [Xen-devel] [PATCH v4 1/9] livepatch: Clear .bss when payload is reverted

On 24/08/16 09:55, Jan Beulich wrote: On 24.08.16 at 04:22, wrote: --- a/xen/common/livepatch.c +++ b/xen/common/livepatch.c @@ -70,6 +70,9 @@ struct payload { unsigned int nsyms; /* Nr of entries in .strtab and symbols. */ struct

Re: [Xen-devel] [PATCH v4 1/9] livepatch: Clear .bss when payload is reverted

>>> On 24.08.16 at 04:22, wrote: > --- a/xen/common/livepatch.c > +++ b/xen/common/livepatch.c > @@ -70,6 +70,9 @@ struct payload { > unsigned int nsyms; /* Nr of entries in .strtab and > symbols. */ > struct livepatch_build_id id;/*