Re: [Xen-devel] [PATCH] xen: avoid deadlock in xenbus driver

2017-06-08 Thread Juergen Gross
On 07/06/17 18:24, Juergen Gross wrote: > There has been a report about a deadlock in the xenbus driver: > > [ 247.979498] == > [ 247.985688] WARNING: possible circular locking dependency detected > [ 247.991882] 4.12.0-rc4-00022-gc4b25c0 #575

Re: [Xen-devel] [PATCH 16/44] arm64: remove DMA_ERROR_CODE

2017-06-08 Thread Robin Murphy
On 08/06/17 14:25, Christoph Hellwig wrote: > The dma alloc interface returns an error by return NULL, and the > mapping interfaces rely on the mapping_error method, which the dummy > ops already implement correctly. > > Thus remove the DMA_ERROR_CODE define. Reviewed-by: Robin Murphy > Signed-

[Xen-devel] [PATCH v2] xen: avoid deadlock in xenbus driver

2017-06-08 Thread Juergen Gross
There has been a report about a deadlock in the xenbus driver: [ 247.979498] == [ 247.985688] WARNING: possible circular locking dependency detected [ 247.991882] 4.12.0-rc4-00022-gc4b25c0 #575 Not tainted [ 247.997040] --

Re: [Xen-devel] [PATCH] xen: avoid deadlock in xenbus driver

2017-06-08 Thread Andre Przywara
Hi Jürgen, On 08/06/17 15:00, Juergen Gross wrote: > On 07/06/17 18:24, Juergen Gross wrote: >> There has been a report about a deadlock in the xenbus driver: >> >> [ 247.979498] == >> [ 247.985688] WARNING: possible circular locking dependency

Re: [Xen-devel] [PATCH 2/3] x86/altp2m: Add a hvmop for setting the suppress #VE bit

2017-06-08 Thread Jan Beulich
>>> On 08.06.17 at 15:49, wrote: > On Tue, Jun 06, 2017 at 07:08:43AM -0600, Jan Beulich wrote: >> >>> On 06.06.17 at 15:00, wrote: >> > On Mon, May 29, 2017 at 08:38:33AM -0600, Jan Beulich wrote: >> >> >>> On 18.05.17 at 17:07, wrote: >> >> > + >> >> > +if ( !cpu_has_vmx ) >> >> > +

Re: [Xen-devel] [PATCH 01/15] xen: in do_softirq() sample smp_processor_id() once and for all.

2017-06-08 Thread George Dunlap
On 07/06/17 15:38, Jan Beulich wrote: On 01.06.17 at 19:33, wrote: >> In fact, right now, we read it at every iteration of the loop. >> The reason it's done like this is how context switch was handled >> on IA64 (see commit ae9bfcdc, "[XEN] Various softirq cleanups" [1]). >> >> However: >> 1)

Re: [Xen-devel] [PATCH 02/44] ibmveth: properly unwind on init errors

2017-06-08 Thread David Miller
From: Christoph Hellwig Date: Thu, 8 Jun 2017 15:25:27 +0200 > That way the driver doesn't have to rely on DMA_ERROR_CODE, which > is not a public API and going away. > > Signed-off-by: Christoph Hellwig Acked-by: David S. Miller ___ Xen-devel mai

Re: [Xen-devel] clean up and modularize arch dma_mapping interface

2017-06-08 Thread David Miller
From: Christoph Hellwig Date: Thu, 8 Jun 2017 15:25:25 +0200 > for a while we have a generic implementation of the dma mapping routines > that call into per-arch or per-device operations. But right now there > still are various bits in the interfaces where don't clearly operate > on these ops.

Re: [Xen-devel] [PATCH 27/44] sparc: remove leon_dma_ops

2017-06-08 Thread David Miller
From: Christoph Hellwig Date: Thu, 8 Jun 2017 15:25:52 +0200 > We can just use pci32_dma_ops. > > Btw, given that leon is 32-bit and appears to be PCI based, do even need > the special case for it in get_arch_dma_ops at all? I would need to defer to the LEON developers on that, but they haven'

Re: [Xen-devel] [PATCH 28/44] sparc: remove arch specific dma_supported implementations

2017-06-08 Thread Julian Calaby
Hi Christoph, On Thu, Jun 8, 2017 at 11:25 PM, Christoph Hellwig wrote: > Usually dma_supported decisions are done by the dma_map_ops instance. > Switch sparc to that model by providing a ->dma_supported instance for > sbus that always returns false, and implementations tailored to the sun4u > an

[Xen-devel] [xen-4.9-testing test] 110095: regressions - FAIL

2017-06-08 Thread osstest service owner
flight 110095 xen-4.9-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/110095/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-xtf-amd64-amd64-2 74 xtf/test-pv64-xsa-188fail REGR. vs. 110063 test-amd64-amd6

Re: [Xen-devel] [PATCH 28/44] sparc: remove arch specific dma_supported implementations

2017-06-08 Thread David Miller
From: Christoph Hellwig Date: Thu, 8 Jun 2017 15:25:53 +0200 > Usually dma_supported decisions are done by the dma_map_ops instance. > Switch sparc to that model by providing a ->dma_supported instance for > sbus that always returns false, and implementations tailored to the sun4u > and sun4v ca

Re: [Xen-devel] [PATCH 20/44] sparc: implement ->mapping_error

2017-06-08 Thread David Miller
From: Christoph Hellwig Date: Thu, 8 Jun 2017 15:25:45 +0200 > DMA_ERROR_CODE is going to go away, so don't rely on it. > > Signed-off-by: Christoph Hellwig Acked-by: David S. Miller ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists

Re: [Xen-devel] [PATCH 01/15] xen: in do_softirq() sample smp_processor_id() once and for all.

2017-06-08 Thread George Dunlap
On 01/06/17 18:33, Dario Faggioli wrote: > In fact, right now, we read it at every iteration of the loop. > The reason it's done like this is how context switch was handled > on IA64 (see commit ae9bfcdc, "[XEN] Various softirq cleanups" [1]). > > However: > 1) we don't have IA64 any longer, and a

Re: [Xen-devel] [PATCH for-next v3 06/22] x86/traps: move PV hypercall handlers to pv/traps.c

2017-06-08 Thread Wei Liu
On Thu, Jun 08, 2017 at 12:30:02PM +0100, Andrew Cooper wrote: > I'd prefer not to have individual files for individual functions; that > is going too far IMO. I'd also prefer not to mix misc hypercalls into > this file. > > pv/misc-hypercalls.c ? > Sure this is fine by me. I will move the *_d

Re: [Xen-devel] [PATCH 02/15] xen: tracing: avoid checking tb_init_done multiple times.

2017-06-08 Thread George Dunlap
On 07/06/17 17:06, Jan Beulich wrote: On 07.06.17 at 17:55, wrote: >> On Wed, 2017-06-07 at 08:46 -0600, Jan Beulich wrote: >> On 01.06.17 at 19:33, wrote: In fact, when calling __trace_var() directly, we can assume that tb_init_done has been checked to be true, and t

Re: [Xen-devel] [PATCH 02/15] xen: tracing: avoid checking tb_init_done multiple times.

2017-06-08 Thread George Dunlap
On 01/06/17 18:33, Dario Faggioli wrote: > In fact, when calling __trace_var() directly, we can > assume that tb_init_done has been checked to be true, > and the if is hence redundant. You probably want to adjust the comment before the smp_rmb() that mentions tb_init_done as well. Other than that

Re: [Xen-devel] [PATCH 01/15] xen: in do_softirq() sample smp_processor_id() once and for all.

2017-06-08 Thread Jan Beulich
>>> On 08.06.17 at 16:20, wrote: > On 01/06/17 18:33, Dario Faggioli wrote: >> In fact, right now, we read it at every iteration of the loop. >> The reason it's done like this is how context switch was handled >> on IA64 (see commit ae9bfcdc, "[XEN] Various softirq cleanups" [1]). >> >> However:

Re: [Xen-devel] [PATCH 25/44] arm: implement ->mapping_error

2017-06-08 Thread Russell King - ARM Linux
BOn Thu, Jun 08, 2017 at 03:25:50PM +0200, Christoph Hellwig wrote: > +static int dmabounce_mapping_error(struct device *dev, dma_addr_t dma_addr) > +{ > + if (dev->archdata.dmabounce) > + return 0; I'm not convinced that we need this check here: dev->archdata.dmabounce =

Re: [Xen-devel] [PATCH 03/15] xen/tools: tracing: several improvements on IRQs tracing

2017-06-08 Thread George Dunlap
On 07/06/17 16:58, Jan Beulich wrote: On 07.06.17 at 17:45, wrote: >> On Wed, 2017-06-07 at 09:05 -0600, Jan Beulich wrote: >> On 01.06.17 at 19:33, wrote: @@ -884,9 +919,13 @@ void do_IRQ(struct cpu_user_regs *regs) desc->rl_quantum_start = now; } >>

Re: [Xen-devel] [PATCH 03/15] xen/tools: tracing: several improvements on IRQs tracing

2017-06-08 Thread George Dunlap
On 01/06/17 18:33, Dario Faggioli wrote: > More specifically: > - the handling of the TRC_HW_IRQ_HANDLED is fixed, both in >xentrace_format and in xenalyze; > - simple events for recording when we enter and exit the >do_IRQ function, as well as when we deal with a guest >IRQ, are adde

Re: [Xen-devel] [PATCH 04/15] tools: xenalyze: fix dumping of PM_IDLE events.

2017-06-08 Thread George Dunlap
On Thu, Jun 1, 2017 at 6:34 PM, Dario Faggioli wrote: > In fact, not all the information present in the trace > record were used and printed. > > Signed-off-by: Dario Faggioli Reviewed-by: George Dunlap ___ Xen-devel mailing list Xen-devel@lists.xen.

Re: [Xen-devel] [PATCH 05/15] xen: make it possible to disable tracing in Kconfig.

2017-06-08 Thread George Dunlap
On 07/06/17 16:14, Jan Beulich wrote: On 01.06.17 at 19:34, wrote: >> --- a/xen/Kconfig.debug >> +++ b/xen/Kconfig.debug >> @@ -98,6 +98,14 @@ config PERF_ARRAYS >> ---help--- >>Enables software performance counter array histograms. >> >> +config TRACING >> +bool "Tracing"

Re: [Xen-devel] [PATCH 05/15] xen: make it possible to disable tracing in Kconfig.

2017-06-08 Thread George Dunlap
On 01/06/17 18:34, Dario Faggioli wrote: > And compile it out of the hypervisor entirely. > > Code and other sections' sizes change as follows. > > Output of `size`: > vanilla patched-Y patched-N > text 192900719290071902783 > data 337784 337784 337688 > bss 1310464

[Xen-devel] [PATCH] public: there's no MMUEXT_SET_FOREIGNDOM

2017-06-08 Thread Jan Beulich
Correct respective comments. Signed-off-by: Jan Beulich --- MMUEXT_{CLEAR,COPY}_PAGE in fact also allow to be invoked on DOMID_IO owned pages at present. I've intentionally not added this to the text, as I'm not sure we really mean to allow this. If we do, I think the operation should also be all

[Xen-devel] [PATCH] x86: get_page_from_gfn() should not return misleading type

2017-06-08 Thread Jan Beulich
It is not impossible that the page owner is dom_io. While no current caller cares about this case, let's nevertheless return an appropriate type even in that case. Signed-off-by: Jan Beulich --- a/xen/include/asm-x86/p2m.h +++ b/xen/include/asm-x86/p2m.h @@ -479,9 +479,9 @@ static inline struct

[Xen-devel] [PATCH] x86/mm: drop further relics of translated PV domains

2017-06-08 Thread Jan Beulich
For PV domains paging_mode_{refcounts,translate}() are always false as of commits 4045953527 ("x86/paging: Enforce PG_external == PG_translate == PG_refcounts") and 92942fd3d4 ("x86/mm: drop guest_{map,get_eff}_l1e() hooks"). Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/

Re: [Xen-devel] [PATCH 03/15] xen/tools: tracing: several improvements on IRQs tracing

2017-06-08 Thread Jan Beulich
>>> On 08.06.17 at 16:53, wrote: > On 07/06/17 16:58, Jan Beulich wrote: > On 07.06.17 at 17:45, wrote: >>> On Wed, 2017-06-07 at 09:05 -0600, Jan Beulich wrote: >>> On 01.06.17 at 19:33, wrote: > @@ -884,9 +919,13 @@ void do_IRQ(struct cpu_user_regs *regs) > desc->r

Re: [Xen-devel] [PATCH 05/15] xen: make it possible to disable tracing in Kconfig.

2017-06-08 Thread Jan Beulich
>>> On 08.06.17 at 17:16, wrote: > On 07/06/17 16:14, Jan Beulich wrote: > On 01.06.17 at 19:34, wrote: >>> --- a/xen/Kconfig.debug >>> +++ b/xen/Kconfig.debug >>> @@ -98,6 +98,14 @@ config PERF_ARRAYS >>> ---help--- >>> Enables software performance counter array histograms. >>> >

Re: [Xen-devel] [PATCH 05/15] xen: make it possible to disable tracing in Kconfig.

2017-06-08 Thread George Dunlap
On 08/06/17 16:35, Jan Beulich wrote: On 08.06.17 at 17:16, wrote: >> On 07/06/17 16:14, Jan Beulich wrote: >> On 01.06.17 at 19:34, wrote: --- a/xen/Kconfig.debug +++ b/xen/Kconfig.debug @@ -98,6 +98,14 @@ config PERF_ARRAYS ---help--- Enables software p

Re: [Xen-devel] [PATCH 05/15] xen: make it possible to disable tracing in Kconfig.

2017-06-08 Thread Jan Beulich
>>> On 08.06.17 at 17:37, wrote: > On 08/06/17 16:35, Jan Beulich wrote: > On 08.06.17 at 17:16, wrote: >>> On 07/06/17 16:14, Jan Beulich wrote: >>> On 01.06.17 at 19:34, wrote: > --- a/xen/Kconfig.debug > +++ b/xen/Kconfig.debug > @@ -98,6 +98,14 @@ config PERF_ARRAYS >

[Xen-devel] [PATCH] x86emul: minor cleanup

2017-06-08 Thread Jan Beulich
Drop a redundant input constraint, correct a comment, and (re)move fix.insn_bytes adjustments (these aren't needed for custom stub invocations when the instruction placed in the stub can't raise #XF) plus a corresponding check_xmm_exn() invocation. Signed-off-by: Jan Beulich --- a/xen/arch/x86/x

Re: [Xen-devel] [PATCH 06/15] xen: trace IRQ enabling/disabling

2017-06-08 Thread George Dunlap
On 02/06/17 00:42, Dario Faggioli wrote: > On Thu, 2017-06-01 at 20:08 +0100, Andrew Cooper wrote: >> On 01/06/17 18:34, Dario Faggioli wrote: >>> diff --git a/xen/common/spinlock.c b/xen/common/spinlock.c >>> index 2a06406..33b903e 100644 >>> --- a/xen/common/spinlock.c >>> +++ b/xen/common/spinlo

Re: [Xen-devel] [Resend][PATCH 01/17] rb_tree: reorganize code in rb_erase() for additional changes

2017-06-08 Thread Jan Beulich
>>> On 31.05.17 at 23:20, wrote: > First, move some code around in order to make the next change more obvious. > > commit 16c047add3ceaf0ab882e3e094d1ec904d02312d from linux tree > > Signed-off-by: Praveen Kumar You've completely lost all original authorship - this is a no-go. You'll need to i

Re: [Xen-devel] [PATCH 06/15] xen: trace IRQ enabling/disabling

2017-06-08 Thread George Dunlap
On 01/06/17 18:34, Dario Faggioli wrote: > Trace when interrupts are disabled and (re)enabled. > Basically, we replace the IRQ disabling and enabling > functions with helpers that does the same, but also > output the proper trace record. > > For putting in the record something that will let > us i

Re: [Xen-devel] [PATCH 06/15] xen: trace IRQ enabling/disabling

2017-06-08 Thread Jan Beulich
>>> On 02.06.17 at 01:42, wrote: > On Thu, 2017-06-01 at 20:08 +0100, Andrew Cooper wrote: >> By writing the trace record while interrupts are disabled, you do >> prevent nesting in the general case (but not in NMIs/MCEs or the >> irqsave() variants), >> > Forgive the ignorance, what's special ab

Re: [Xen-devel] [PATCH 06/15] xen: trace IRQ enabling/disabling

2017-06-08 Thread Dario Faggioli
On Thu, 2017-06-08 at 17:01 +0100, George Dunlap wrote: > On 01/06/17 18:34, Dario Faggioli wrote: > > diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug > > index 374c1c0..81910c9 100644 > > --- a/xen/Kconfig.debug > > +++ b/xen/Kconfig.debug > > @@ -98,7 +98,7 @@ config PERF_ARRAYS > >   ---hel

Re: [Xen-devel] [PATCH 00/15] xen/tools: add tracing to various Xen subsystems

2017-06-08 Thread Dario Faggioli
On Wed, 2017-06-07 at 10:13 -0400, Konrad Rzeszutek Wilk wrote: > On Thu, Jun 01, 2017 at 07:33:33PM +0200, Dario Faggioli wrote: > > > > Patch 5 deserves special mention. In fact, now that we have > > Kconfig, I thought > > it could be a nice thing to make it possible to select, at build > > conf

Re: [Xen-devel] [PATCH 19/44] s390: implement ->mapping_error

2017-06-08 Thread Gerald Schaefer
On Thu, 8 Jun 2017 15:25:44 +0200 Christoph Hellwig wrote: > s390 can also use noop_dma_ops, and while that currently does not return > errors it will so in the future. Implementing the mapping_error method > is the proper way to have per-ops error conditions. > > Signed-off-by: Christoph Hell

Re: [Xen-devel] [PATCH 03/44] dmaengine: ioat: don't use DMA_ERROR_CODE

2017-06-08 Thread Dave Jiang
On 06/08/2017 06:25 AM, Christoph Hellwig wrote: > DMA_ERROR_CODE is not a public API and will go away. Instead properly > unwind based on the loop counter. > > Signed-off-by: Christoph Hellwig Acked-by: Dave Jiang > --- > drivers/dma/ioat/init.c | 24 +++- > 1 file chang

Re: [Xen-devel] Deployment usage and performance of a network domain

2017-06-08 Thread Dario Faggioli
On Thu, 2017-06-08 at 14:32 +0200, Kashyap Thimmaraju wrote: > Hi, > > I'm Kashyap Thimmaraju, a second year PhD student at TU Berlin in > Germany. This is my first post here, and I'm a Xen newbie. > > I saw George Dunlap's presentation "Securing Your Xen-Based Cloud" at > the LinuxCon on youtube

[Xen-devel] [PATCH v4 03/27] x86: move PV gate op emulation code

2017-06-08 Thread Wei Liu
Move the code to pv/emul-gate-op.c. Prefix emulate_gate_op with pv_ and export it via pv/traps.h. Pure code motion except for the rename. Signed-off-by: Wei Liu --- xen/arch/x86/pv/Makefile | 1 + xen/arch/x86/pv/emul-gate-op.c | 440 + xen/arch/x

[Xen-devel] [PATCH v4 06/27] x86: clean up PV emulation code

2017-06-08 Thread Wei Liu
Replace bool_t with bool. Fix coding style issues. Add spaces around binary ops. Use 1U for shifting. Eliminate TOGGLE_MODE. Signed-off-by: Wei Liu Signed-off-by: Andrew Cooper --- xen/arch/x86/pv/emul-gate-op.c | 5 ++- xen/arch/x86/pv/emul-priv-op.c | 82 ++---

[Xen-devel] [PATCH v4 05/27] x86/traps: remove now unused inclusion of emulate.h

2017-06-08 Thread Wei Liu
Signed-off-by: Wei Liu --- Can be squashed into previous patch. Kept separated in case further code churn is required. --- xen/arch/x86/traps.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index ff25f679f5..b5642b0f9a 100644 --- a/xen/arch/x86/t

[Xen-devel] [PATCH v4 09/27] x86/traps: move pv_inject_event to pv/traps.c

2017-06-08 Thread Wei Liu
Take the opportunity to rename "v" to "curr". No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/pv/traps.c | 73 + xen/arch/x86/traps.c| 69 -- 2 files changed, 73 insertions(+), 69 delet

[Xen-devel] [PATCH v4 01/27] x86: factor out common PV emulation code

2017-06-08 Thread Wei Liu
We're going to split PV emulation code into several files. This patch extracts the functions needed by them into a dedicated file. The functions are now prefixed with "pv_emul_" and exported via a local header file. While at it, change bool_t to bool. Signed-off-by: Wei Liu --- xen/arch/x86/pv

[Xen-devel] [PATCH v4 00/27] x86: refactor trap handling code

2017-06-08 Thread Wei Liu
V4 of this series, rebased on top of staging. git://xenbits.xen.org/people/liuw/xen.git wip.move-traps-v4 Wei Liu (27): x86: factor out common PV emulation code x86: move PV privileged instruction emulation code x86: move PV gate op emulation code x86: move PV invalid op emulation code

[Xen-devel] [PATCH v4 08/27] x86: move some misc PV hypercalls to misc-hypercalls.c

2017-06-08 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/pv/Makefile | 1 + xen/arch/x86/pv/misc-hypercalls.c | 78 +++ xen/arch/x86/traps.c | 44 -- 3 files changed, 79 insertions(+), 44 deletions(-) create mode 100644 xen/arch/x86/p

[Xen-devel] [PATCH v4 07/27] x86: move do_set_trap_table to pv/traps.c

2017-06-08 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/pv/traps.c | 52 + xen/arch/x86/traps.c| 49 -- 2 files changed, 52 insertions(+), 49 deletions(-) diff --git a/xen/arch/x86/pv/traps.c b/xen/arch/x86/pv/traps.

[Xen-devel] [PATCH v4 04/27] x86: move PV invalid op emulation code

2017-06-08 Thread Wei Liu
Move the code to pv/emul-inv-op.c. Prefix emulate_* functions with pv_ and export them via pv/traps.h. Pure code motion except for the rename. Signed-off-by: Wei Liu --- xen/arch/x86/pv/Makefile | 1 + xen/arch/x86/pv/emul-inv-op.c | 123 + xen/a

[Xen-devel] [PATCH v4 02/27] x86: move PV privileged instruction emulation code

2017-06-08 Thread Wei Liu
Move the code to pv/emul-priv-op.c. Prefix emulate_privileged_op with pv_ and export it via pv/traps.h. Also move gpr_switch.S since it is used by the privileged instruction emulation code only. Code motion only except for the rename. Cleanup etc will come later. Signed-off-by: Wei Liu --- xen

[Xen-devel] [PATCH v4 13/27] x86: move toggle_guest_mode to pv/domain.c

2017-06-08 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/pv/domain.c| 30 ++ xen/arch/x86/x86_64/traps.c | 30 -- 2 files changed, 30 insertions(+), 30 deletions(-) diff --git a/xen/arch/x86/pv/domain.c b/xen/arch/x86/pv/domain.c index 1c0c040ca0..0f3f0

[Xen-devel] [PATCH v4 15/27] x86: move callback_op code to pv/callback.c

2017-06-08 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/pv/Makefile| 1 + xen/arch/x86/pv/callback.c | 157 xen/arch/x86/x86_64/traps.c | 148 - 3 files changed, 158 insertions(+), 148 deletions(-) create mode 100644 xen

[Xen-devel] [PATCH v4 19/27] x86: move hypercall_page_initialise_ring3_kernel to pv/hypercall.c

2017-06-08 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/pv/hypercall.c | 36 xen/arch/x86/x86_64/traps.c | 36 xen/include/asm-x86/hypercall.h | 1 + 3 files changed, 37 insertions(+), 36 deletions(-) diff --git a/xen/arch/x86/pv

[Xen-devel] [PATCH v4 18/27] x86/traps: move init_int80_direct_trap to pv/traps.c

2017-06-08 Thread Wei Liu
Signed-off-by: Wei Liu Acked-by: Jan Beulich --- xen/arch/x86/pv/traps.c | 14 ++ xen/arch/x86/x86_64/traps.c | 14 -- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/xen/arch/x86/pv/traps.c b/xen/arch/x86/pv/traps.c index 0c1600d886..f2556c7e4a 10064

[Xen-devel] [PATCH v4 16/27] x86/traps: factor out pv_trap_init

2017-06-08 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/traps.c | 22 ++ xen/include/asm-x86/pv/traps.h | 4 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index 8861dfd332..29a83994bd 100644 --- a/xen/arch/x86/traps

[Xen-devel] [PATCH v4 21/27] x86: move compat_set_trap_table along side the non-compat variant

2017-06-08 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/pv/traps.c| 45 ++ xen/arch/x86/x86_64/compat/traps.c | 45 -- 2 files changed, 45 insertions(+), 45 deletions(-) diff --git a/xen/arch/x86/pv/traps.c b/xen/arch/x86/pv/tra

[Xen-devel] [PATCH v4 11/27] x86:/traps: move {un, }register_guest_nmi_callback

2017-06-08 Thread Wei Liu
Take the opportunity to rename "v" to "curr". Signed-off-by: Wei Liu --- xen/arch/x86/pv/traps.c | 36 xen/arch/x86/traps.c| 36 2 files changed, 36 insertions(+), 36 deletions(-) diff --git a/xen/arch/x86/pv/traps.c

[Xen-devel] [PATCH v4 17/27] x86/traps: move some PV specific functions and struct to pv/traps.c

2017-06-08 Thread Wei Liu
Those functions need to be moved at the same time. Also move softirq_trap because it is only used in that one place. Fix some coding style issues while moving. Signed-off-by: Wei Liu --- xen/arch/x86/pv/traps.c | 105 xen/arch/x86/traps.c

[Xen-devel] [PATCH v4 10/27] x86/traps: move set_guest_{machine, nmi}_trapbounce

2017-06-08 Thread Wei Liu
Take the opportunity to change their return type to bool. And rename "v" to "curr". Signed-off-by: Wei Liu --- xen/arch/x86/pv/traps.c | 27 +++ xen/arch/x86/traps.c| 27 --- 2 files changed, 27 insertions(+), 27 deletions(-) diff --git a/xen/

[Xen-devel] [PATCH v4 26/27] x86: fix coding a style issue in asm-x86/traps.h

2017-06-08 Thread Wei Liu
And add an emacs block. Signed-off-by: Wei Liu --- xen/include/asm-x86/traps.h | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/xen/include/asm-x86/traps.h b/xen/include/asm-x86/traps.h index 8cf6105d8d..1ac6718257 100644 --- a/xen/include/asm-x86/traps.h +++ b/xe

[Xen-devel] [PATCH v4 12/27] x86/traps: move guest_has_trap_callback to pv/traps.c

2017-06-08 Thread Wei Liu
Take the chance to constify pointers, replace uint16_t with unsigned int etc. Signed-off-by: Wei Liu --- xen/arch/x86/pv/traps.c | 18 ++ xen/arch/x86/traps.c| 18 -- xen/include/asm-x86/traps.h | 6 +++--- 3 files changed, 21 insertions(+), 21 deleti

[Xen-devel] [PATCH v4 25/27] x86: remove the now empty x86_64/compat/traps.c

2017-06-08 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/x86_64/compat/traps.c | 14 -- xen/arch/x86/x86_64/traps.c| 2 -- 2 files changed, 16 deletions(-) delete mode 100644 xen/arch/x86/x86_64/compat/traps.c diff --git a/xen/arch/x86/x86_64/compat/traps.c b/xen/arch/x86/x86_64/compat/tra

[Xen-devel] [PATCH v4 23/27] x86: move the compat callback ops next to the non-compat variant

2017-06-08 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/pv/callback.c | 142 xen/arch/x86/x86_64/compat/traps.c | 143 - 2 files changed, 142 insertions(+), 143 deletions(-) diff --git a/xen/arch/x86/pv/callback.c b/xen/arch/x86/pv

[Xen-devel] [PATCH v4 14/27] x86: move do_iret to pv/iret.c

2017-06-08 Thread Wei Liu
Signed-off-by: Wei Liu --- There is no copyright header in the original file. Use the default one? --- xen/arch/x86/pv/Makefile| 1 + xen/arch/x86/pv/iret.c | 72 + xen/arch/x86/x86_64/traps.c | 56 --- 3 files

[Xen-devel] [PATCH v4 20/27] x86: move hypercall_page_initialise_ring1_kernel

2017-06-08 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/pv/hypercall.c| 31 +++ xen/arch/x86/x86_64/compat/traps.c | 31 --- xen/include/asm-x86/hypercall.h| 1 + 3 files changed, 32 insertions(+), 31 deletions(-) diff --git a/xen/arch/x86/pv/

[Xen-devel] [PATCH v4 24/27] x86: move compat_show_guest_statck near its non-compat variant

2017-06-08 Thread Wei Liu
And make it static, remove the declaration in header. Signed-off-by: Wei Liu --- xen/arch/x86/traps.c | 64 ++ xen/arch/x86/x86_64/compat/traps.c | 63 - xen/include/asm-x86/processor.h| 3 -- 3 files chan

[Xen-devel] [PATCH v4 27/27] x86: clean up traps.c

2017-06-08 Thread Wei Liu
Replace bool_t with bool. Delete trailing white spaces. Fix some coding style issues. Signed-off-by: Wei Liu Acked-by: Jan Beulich --- xen/arch/x86/traps.c | 77 +++- 1 file changed, 40 insertions(+), 37 deletions(-) diff --git a/xen/arch/x86/tra

[Xen-devel] [PATCH v4 22/27] x86: move compat_iret along side its non-compat variant

2017-06-08 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/pv/iret.c | 120 + xen/arch/x86/x86_64/compat/traps.c | 120 - 2 files changed, 120 insertions(+), 120 deletions(-) diff --git a/xen/arch/x86/pv/iret.c b/xen/arch/x86/pv/ir

Re: [Xen-devel] [PATCH v2] xen: fix HYPERVISOR_dm_op() prototype

2017-06-08 Thread Juergen Gross
On 07/06/17 09:20, Sergey Dyasli wrote: > Change the third parameter to be the required struct xen_dm_op_buf * > instead of a generic void * (which blindly accepts any pointer). > > Signed-off-by: Sergey Dyasli Committed to xen/tip.git for-linus-4.13 Thanks, Juergen _

[Xen-devel] [libvirt test] 110107: tolerable all pass - PUSHED

2017-06-08 Thread osstest service owner
flight 110107 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/110107/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 13 saverestore-support-checkfail like 110065 test-armhf-armhf-libvirt-xsm 13 saveresto

Re: [Xen-devel] [for-4.9] Re: HVM guest performance regression

2017-06-08 Thread Stefano Stabellini
On Thu, 8 Jun 2017, Juergen Gross wrote: > On 07/06/17 20:19, Stefano Stabellini wrote: > > On Wed, 7 Jun 2017, Juergen Gross wrote: > >> On 06/06/17 21:08, Stefano Stabellini wrote: > >>> On Tue, 6 Jun 2017, Juergen Gross wrote: > On 06/06/17 18:39, Stefano Stabellini wrote: > > On Tue, 6

Re: [Xen-devel] [PATCH v2] xen: avoid type warning in xchg_xen_ulong

2017-06-08 Thread Stefano Stabellini
On Thu, 8 Jun 2017, Arnd Bergmann wrote: > The improved type-checking version of container_of() triggers a warning for > xchg_xen_ulong, pointing out that 'xen_ulong_t' is unsigned, but atomic64_t > contains a signed value: > > drivers/xen/events/events_2l.c: In function 'evtchn_2l_handle_events':

Re: [Xen-devel] [for-4.9] Re: HVM guest performance regression

2017-06-08 Thread Juergen Gross
On 08/06/17 20:09, Stefano Stabellini wrote: > On Thu, 8 Jun 2017, Juergen Gross wrote: >> On 07/06/17 20:19, Stefano Stabellini wrote: >>> On Wed, 7 Jun 2017, Juergen Gross wrote: On 06/06/17 21:08, Stefano Stabellini wrote: > On Tue, 6 Jun 2017, Juergen Gross wrote: >> On 06/06/17 18

[Xen-devel] [PATCH v2 0/1] xl.cfg man page cleanup and fixes

2017-06-08 Thread Armando Vega
Hey everyone, so I'm respinning the patch after Dario confirmed the NUMA example is correct now. Armando Vega (1): xl.cfg man page cleanup and fixes docs/man/xl.cfg.pod.5.in | 1107 -- 1 file changed, 588 insertions(+), 519 deletions(-) -- 2.11.0

[Xen-devel] [PATCH v2 1/1] xl.cfg man page cleanup and fixes

2017-06-08 Thread Armando Vega
- fixed some minor numbering and syntax issues in the CPU allocation examples for the 'cpus' option - semantic fixes to make explanations more clear throughout - fixed all the typo's I could see - general styling and makeup fixes to make everything look more consistent Signed-off-by: Armando Veg

[Xen-devel] [xen-unstable test] 110102: regressions - FAIL

2017-06-08 Thread osstest service owner
flight 110102 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/110102/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 15 guest-localmigrate/x10 fail REGR. vs. 110071 test-amd64-a

[Xen-devel] [RFC 0/6] IORT support and introduce fwspec

2017-06-08 Thread Sameer Goel
This changelist is in preparation for porting the latest SMMUv3 driver from Linux kernel 4.11 release. Scope of the changes: - Introduce the iommu_fwspec implementation * This implementation is a direct port from Linux. The code that is not needed for Xen is removed. - IORT port from Li

[Xen-devel] [RFC 3/6] Introduce _xrealloc

2017-06-08 Thread Sameer Goel
Introduce a memory realloc function. Signed-off-by: Sameer Goel --- xen/common/xmalloc_tlsf.c | 13 + xen/include/xen/xmalloc.h | 1 + 2 files changed, 14 insertions(+) diff --git a/xen/common/xmalloc_tlsf.c b/xen/common/xmalloc_tlsf.c index b256dc5..52385a8 100644 --- a/xen/common

[Xen-devel] [RFC 2/6] arm64: Add definitions for fwnode_handle

2017-06-08 Thread Sameer Goel
This will be used as a device property to match the DMA capable devices with the associated SMMU. The header file is a port from linux. Linux ChangeId:ce793486e23e: driver core / ACPI: Represent ACPI companions using fwnode_handle Signed-off-by: Sameer Goel --- xen/include/asm-arm/device.h | 2

[Xen-devel] [RFC 6/6] acpi:arm64: Add support for parsing IORT table

2017-06-08 Thread Sameer Goel
Add limited support for parsing IORT table to initialize SMMU devices. Signed-off-by: Sameer Goel --- xen/arch/arm/setup.c| 3 + xen/drivers/acpi/Makefile | 1 + xen/drivers/acpi/arm/Makefile | 1 + xen/drivers/acpi/arm/iort.c | 232 +

[Xen-devel] [RFC 5/6] ACPI: arm: Support for IORT

2017-06-08 Thread Sameer Goel
Verbatim files from Linux kernel. iort.c: commit ca78d3173cff:Merge tag 'arm64-upstream' acpi_iort.h: commit 18b709beb503:ACPI/IORT: Make dma masks set-up IORT specific Signed-off-by: Sameer Goel --- xen/drivers/acpi/arm/iort.c | 961 +++ xen/include/acpi

[Xen-devel] [RFC 1/6] passthrough/arm: Modify SMMU driver to use generic device definition

2017-06-08 Thread Sameer Goel
Modify the SMMU code to use generic device instead of dt_device_node for functions that can be used for ACPI based systems too. Signed-off-by: Sameer Goel --- xen/drivers/passthrough/arm/smmu.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/xen/drivers/passthrou

[Xen-devel] [RFC 4/6] xen/passthrough/arm: Introduce iommu_fwspec

2017-06-08 Thread Sameer Goel
Introduce a common structure to hold the fw (ACPI or DT) defined configuration for SMMU hw. The current use case is for arm SMMUs. So, making this architecture specific. Based on Linux kernel commit 57f98d2f61e1: iommu: Introduce iommu_fwspec Signed-off-by: Sameer Goel --- xen/drivers/passthroug

Re: [Xen-devel] [RFC 2/6] arm64: Add definitions for fwnode_handle

2017-06-08 Thread Julien Grall
Hi, Please CC all the relevant maintainers on this patch. On 08/06/2017 20:30, Sameer Goel wrote: This will be used as a device property to match the DMA capable devices with the associated SMMU. The header file is a port from linux. Linux ChangeId:ce793486e23e: driver core / ACPI: Represent A

Re: [Xen-devel] [RFC 3/6] Introduce _xrealloc

2017-06-08 Thread Julien Grall
CC the REST maintainers On 08/06/2017 20:30, Sameer Goel wrote: Introduce a memory realloc function. Signed-off-by: Sameer Goel --- xen/common/xmalloc_tlsf.c | 13 + xen/include/xen/xmalloc.h | 1 + 2 files changed, 14 insertions(+) diff --git a/xen/common/xmalloc_tlsf.c b/xen/c

[Xen-devel] [ovmf test] 110117: regressions - FAIL

2017-06-08 Thread osstest service owner
flight 110117 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/110117/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 5 xen-buildfail REGR. vs. 110078 build-amd64

Re: [Xen-devel] [RFC 2/6] arm64: Add definitions for fwnode_handle

2017-06-08 Thread Julien Grall
On 08/06/2017 20:30, Sameer Goel wrote: This will be used as a device property to match the DMA capable devices with the associated SMMU. The header file is a port from linux. Linux ChangeId:ce793486e23e: driver core / ACPI: Represent ACPI companions using fwnode_handle Signed-off-by: Sameer

Re: [Xen-devel] [RFC 4/6] xen/passthrough/arm: Introduce iommu_fwspec

2017-06-08 Thread Julien Grall
Hi, On 08/06/2017 20:30, Sameer Goel wrote: Introduce a common structure to hold the fw (ACPI or DT) defined configuration for SMMU hw. The current use case is for arm SMMUs. So, making this architecture specific. Based on Linux kernel commit 57f98d2f61e1: iommu: Introduce iommu_fwspec Signed-o

[Xen-devel] [linux-3.18 test] 110109: regressions - trouble: blocked/broken/fail/pass

2017-06-08 Thread osstest service owner
flight 110109 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/110109/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-win7-amd64 15 guest-localmigrate/x10 fail REGR. vs. 109754 Tests which ar

Re: [Xen-devel] [PATCH v6 10/34] x86, x86/mm, x86/xen, olpc: Use __va() against just the physical address in cr3

2017-06-08 Thread Boris Ostrovsky
> >> What may be needed is making sure X86_FEATURE_SME is not set for PV >> guests. > > And that may be something that Xen will need to control through either > CPUID or MSR support for the PV guests. Only on newer versions of Xen. On earlier versions (2-3 years old) leaf 0x8007 is passed to

Re: [Xen-devel] [for-4.9] Re: HVM guest performance regression

2017-06-08 Thread Dario Faggioli
Bringing in Konrad because... On Thu, 2017-06-08 at 11:37 +0200, Juergen Gross wrote: > On 07/06/17 20:19, Stefano Stabellini wrote: > > On Wed, 7 Jun 2017, Juergen Gross wrote: > > > On 06/06/17 21:08, Stefano Stabellini wrote: > > > > > > > > 2) PV suspend/resume > > > > 3) vector callback > >

Re: [Xen-devel] [PATCH v6 10/34] x86, x86/mm, x86/xen, olpc: Use __va() against just the physical address in cr3

2017-06-08 Thread Tom Lendacky
On 6/8/2017 3:51 PM, Boris Ostrovsky wrote: What may be needed is making sure X86_FEATURE_SME is not set for PV guests. And that may be something that Xen will need to control through either CPUID or MSR support for the PV guests. Only on newer versions of Xen. On earlier versions (2-3 y

Re: [Xen-devel] [PATCH v6 10/34] x86, x86/mm, x86/xen, olpc: Use __va() against just the physical address in cr3

2017-06-08 Thread Boris Ostrovsky
On 06/08/2017 05:02 PM, Tom Lendacky wrote: > On 6/8/2017 3:51 PM, Boris Ostrovsky wrote: >> >>> What may be needed is making sure X86_FEATURE_SME is not set for PV guests. >>> >>> And that may be something that Xen will need to control through either >>> CPUID or MSR support for the PV g

Re: [Xen-devel] [RFC 2/6] arm64: Add definitions for fwnode_handle

2017-06-08 Thread Goel, Sameer
On 6/8/2017 1:59 PM, Julien Grall wrote: > > > On 08/06/2017 20:30, Sameer Goel wrote: >> This will be used as a device property to match the DMA capable devices >> with the associated SMMU. The header file is a port from linux. >> >> Linux ChangeId:ce793486e23e: driver core / ACPI: Represent ACP

Re: [Xen-devel] [RFC 3/6] Introduce _xrealloc

2017-06-08 Thread Stefano Stabellini
On Thu, 8 Jun 2017, Sameer Goel wrote: > Introduce a memory realloc function. > > Signed-off-by: Sameer Goel > --- > xen/common/xmalloc_tlsf.c | 13 + > xen/include/xen/xmalloc.h | 1 + > 2 files changed, 14 insertions(+) > > diff --git a/xen/common/xmalloc_tlsf.c b/xen/common/xmal

Re: [Xen-devel] [RFC 2/6] arm64: Add definitions for fwnode_handle

2017-06-08 Thread Stefano Stabellini
On Thu, 8 Jun 2017, Goel, Sameer wrote: > >> diff --git a/xen/include/xen/fwnode.h b/xen/include/xen/fwnode.h > >> new file mode 100644 > >> index 000..db65b15 > >> --- /dev/null > >> +++ b/xen/include/xen/fwnode.h > >> @@ -0,0 +1,35 @@ > >> +/* > >> + * fwnode.h - Firmware device node object h

[Xen-devel] linux-next: bad commit in the xen-tip tree

2017-06-08 Thread Stephen Rothwell
Hi all, The current top commit of the xen-tip tree 9e925824eccd ("xen: avoid type warning in xchg_xen_ulong") has no Signed-off-by for its committer. -- Cheers, Stephen Rothwell ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.

Re: [Xen-devel] [PATCH v6 10/34] x86, x86/mm, x86/xen, olpc: Use __va() against just the physical address in cr3

2017-06-08 Thread Andrew Cooper
On 08/06/2017 22:17, Boris Ostrovsky wrote: > On 06/08/2017 05:02 PM, Tom Lendacky wrote: >> On 6/8/2017 3:51 PM, Boris Ostrovsky wrote: > What may be needed is making sure X86_FEATURE_SME is not set for PV > guests. And that may be something that Xen will need to control through eithe

Re: [Xen-devel] linux-next: bad commit in the xen-tip tree

2017-06-08 Thread Stefano Stabellini
On Fri, 9 Jun 2017, Stephen Rothwell wrote: > Hi all, > > The current top commit of the xen-tip tree > > 9e925824eccd ("xen: avoid type warning in xchg_xen_ulong") > > has no Signed-off-by for its committer. Fixed, thanks for pointing it out. ___ X

<    1   2   3   >