[Xen-devel] XPTI patches for 4.10 don't apply

2018-01-18 Thread Andy Smith
Hi, Maybe this is a silly question but which tag are the 4.10 XPTI commits from https://xenbits.xen.org/xsa/xsa254/README.pti against? They don't apply to RELEASE-4.10.0. Cheers, Andy ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

[Xen-devel] [xen-4.9-testing test] 118167: regressions - FAIL

2018-01-18 Thread osstest service owner
flight 118167 xen-4.9-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/118167/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt-raw 7 xen-boot fail REGR. vs. 117931

Re: [Xen-devel] [RFC 02/11] acpi: arm: API to query estimated size of hardware domain's IORT

2018-01-18 Thread Manish Jaggi
On 01/17/2018 12:22 AM, Julien Grall wrote: Hi Manish, Hi Julien, Thanks for reviewing this patch. On 02/01/18 09:28, manish.ja...@linaro.org wrote: From: Manish Jaggi   Code to query estimated IORT size for hardware domain. Please avoid indenting the commit

Re: [Xen-devel] [RFC 01/11] acpi: arm: Public API for populating and query based on requesterid

2018-01-18 Thread Manish Jaggi
On 01/17/2018 12:01 AM, Julien Grall wrote: Hi Manish, Hi Julien, Thanks for reviewing the patch. I sent the previous e-mail too soon. On 02/01/18 09:27, manish.ja...@linaro.org wrote: From: Manish Jaggi   Public API to populate and query map between requester

[Xen-devel] [xen-4.7-testing test] 118171: regressions - trouble: broken/fail/pass

2018-01-18 Thread osstest service owner
flight 118171 xen-4.7-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/118171/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64broken

[Xen-devel] [xen-unstable-smoke test] 118219: tolerable all pass - PUSHED

2018-01-18 Thread osstest service owner
flight 118219 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/118219/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-armhf-armhf-xl

[Xen-devel] [xen-4.10-testing test] 118165: regressions - FAIL

2018-01-18 Thread osstest service owner
flight 118165 xen-4.10-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/118165/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-ws16-amd64 16 guest-localmigrate/x10 fail REGR. vs. 117870 Tests

Re: [Xen-devel] [PATCH] fix potential null dereference

2018-01-18 Thread Stefano Stabellini
On Thu, 18 Jan 2018, Andrew Cooper wrote: > On 18/01/2018 22:11, Stefano Stabellini wrote: > > On Tue, 16 Jan 2018, Jan Beulich wrote: > > On 15.01.18 at 19:51, wrote: > >>> On Mon, 15 Jan 2018, Jan Beulich wrote: > >>> On 13.01.18 at 07:21,

Re: [Xen-devel] [PATCH] fix potential null dereference

2018-01-18 Thread Andrew Cooper
On 18/01/2018 22:11, Stefano Stabellini wrote: > On Tue, 16 Jan 2018, Jan Beulich wrote: > On 15.01.18 at 19:51, wrote: >>> On Mon, 15 Jan 2018, Jan Beulich wrote: >>> On 13.01.18 at 07:21, wrote: > On 01/12/2018 11:40 PM, Stefano

Re: [Xen-devel] [PATCH] fix potential null dereference

2018-01-18 Thread Stefano Stabellini
On Tue, 16 Jan 2018, Jan Beulich wrote: > >>> On 15.01.18 at 19:51, wrote: > > On Mon, 15 Jan 2018, Jan Beulich wrote: > >> >>> On 13.01.18 at 07:21, wrote: > >> > On 01/12/2018 11:40 PM, Stefano Stabellini wrote: > >> >> handles can theoretically

Re: [Xen-devel] [PATCH] remove dead code in allocate_memory

2018-01-18 Thread Stefano Stabellini
On Mon, 15 Jan 2018, Julien Grall wrote: > Hi Stefano, > > On 01/13/2018 12:29 AM, Stefano Stabellini wrote: > > lowmem is unchanged until after this loop, there is no point in testing > > for its value. Moreover, Coverity complains about dead code. > > > > Remove the lowmem test in the first

[Xen-devel] [PATCH v2] don't pass r12 as reference

2018-01-18 Thread Stefano Stabellini
r12 and x16 are of different sizes; when passing r12 as a reference to do_trap_hypercall on arm64, we end up dereferencing it as a pointer to a 64bit value, but actually it isn't. Instead, use a temporary variable to pass r12, and write back the result after the call to do_trap_hypercall. CID:

Re: [Xen-devel] XSA-254 SP2 for ARM (was Re: [PATCH 1/5] xen/arm: Introduce enable callback to enable a capabilities on each online CPU)

2018-01-18 Thread Stefano Stabellini
On Thu, 18 Jan 2018, Julien Grall wrote: > (+ Security team) > > Hi Stefano, > > On 17/01/18 21:47, Stefano Stabellini wrote: > > On Wed, 17 Jan 2018, Stefano Stabellini wrote: > > > On Wed, 17 Jan 2018, Lars Kurth wrote: > > > >Regarding README.source, this is covering file and contain

[Xen-devel] [qemu-mainline test] 118159: tolerable FAIL - PUSHED

2018-01-18 Thread osstest service owner
flight 118159 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/118159/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 14 saverestore-support-checkfail like 117930

Re: [Xen-devel] [RFC 11/11] Add to_pci_dev macro

2018-01-18 Thread Julien Grall
Hi Manish, Again please use scripts/get_maintainers.pl. On 02/01/18 09:28, manish.ja...@linaro.org wrote: From: Manish Jaggi This patch adds to_pci_dev macro Why? Who is going to use it? If it is a patch in your series, then likely this patch should be before you

Re: [Xen-devel] [RFC 09/11] Xen IORT Changes

2018-01-18 Thread Julien Grall
Hi Manish, On 02/01/18 09:28, manish.ja...@linaro.org wrote: From: Manish Jaggi This patch adds xen specific changes to iort.c When I see the diff below, it is not changed but fully rewrite. The original file contains 1279 lines, but you remove 978 lines and add

Re: [Xen-devel] AMD / SVM vm_event support

2018-01-18 Thread Tamas K Lengyel
On Thu, Jan 18, 2018 at 6:19 AM, Razvan Cojocaru wrote: > Hello, > > We're looking at potentially working with vm_event on SVM hosts. To that > end, we've removed a few cpu_has_vmx tests and saw that some things just > work. > > That is, unfortunately, not the case for

Re: [Xen-devel] [RFC 08/11] Add ACPI_IORT config

2018-01-18 Thread Julien Grall
Hi Manish, The usual scripts/get_maintainers.pl. On 02/01/18 09:28, manish.ja...@linaro.org wrote: From: Manish Jaggi Add ACPI_IORT config Singed-off-by: Manish Jaggi --- xen/arch/arm/Kconfig | 5 + xen/drivers/acpi/Kconfig | 3

Re: [Xen-devel] [RFC 07/11] Add kernel helper functions

2018-01-18 Thread Julien Grall
Hi Manish, Please use scripts/get_maitainers.pl to CC relevant maintainers. On 02/01/18 09:28, manish.ja...@linaro.org wrote: From: Manish Jaggi Add kalloc kfree functions from linux kernel. This does not description all the functions you added. But I am really

Re: [Xen-devel] [RFC 03/11] acpi: arm: Code to generate Hardware Domains IORT

2018-01-18 Thread Julien Grall
Hi, On 02/01/18 09:28, manish.ja...@linaro.org wrote: From: Manish Jaggi First of all, I would expect a commit message explaining roughly the logic. I am only going to skim through this patch and will wait a proper description to fully read it. A general

Re: [Xen-devel] [PATCH 1/9] Update shim.config

2018-01-18 Thread Andrew Cooper
On 18/01/18 18:28, Wei Liu wrote: > On Thu, Jan 18, 2018 at 06:26:02PM +, Andrew Cooper wrote: >> On 18/01/18 18:16, Wei Liu wrote: >>> To avoid having it changed every time the shim is built. >>> >>> Signed-off-by: Wei Liu >> One downside of having a this config in-tree

Re: [Xen-devel] [PATCH 1/9] Update shim.config

2018-01-18 Thread Wei Liu
On Thu, Jan 18, 2018 at 06:26:02PM +, Andrew Cooper wrote: > On 18/01/18 18:16, Wei Liu wrote: > > To avoid having it changed every time the shim is built. > > > > Signed-off-by: Wei Liu > > One downside of having a this config in-tree is that it needs > regenerating

Re: [Xen-devel] [PATCH 4/9] Remove sched=null from shim cmdline and doc

2018-01-18 Thread Andrew Cooper
On 18/01/18 18:16, Wei Liu wrote: > We use the default scheduler (credit1 as of writing). The NULL > scheduler still has bugs to fix. > > Signed-off-by: Wei Liu Reviewed-by: Andrew Cooper ___ Xen-devel

Re: [Xen-devel] [PATCH 3/9] x86/guest: clean up guest/xen.h

2018-01-18 Thread Andrew Cooper
On 18/01/18 18:16, Wei Liu wrote: > Remove extraneous semicolon. Add blank lines. > > Signed-off-by: Wei Liu Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

Re: [Xen-devel] [PATCH 1/9] Update shim.config

2018-01-18 Thread Andrew Cooper
On 18/01/18 18:16, Wei Liu wrote: > To avoid having it changed every time the shim is built. > > Signed-off-by: Wei Liu One downside of having a this config in-tree is that it needs regenerating every time the Kconfig logic changes. OTOH, I did deliberately wire up all the

[Xen-devel] [PATCH 5/9] x86: relocate pvh_info

2018-01-18 Thread Wei Liu
Modify early boot code to relocate pvh info as well, so that we can be sure __va in __start_xen works. Signed-off-by: Wei Liu --- Cc: Jan Beulich Cc: Andrew Cooper --- xen/arch/x86/boot/Makefile | 7 +-

[Xen-devel] [PATCH 6/9] Revert "x86/boot: Map more than the first 16MB"

2018-01-18 Thread Wei Liu
This reverts commit 7d6f958d9d18c54017f5ef6e299a08037f035747. Now we have PVH info relocation support, this change is no longer needed. Signed-off-by: Wei Liu --- Cc: Jan Beulich Cc: Andrew Cooper ---

[Xen-devel] [PATCH 9/9] x86/shim: pass through vcpu runstate to L0 Xen

2018-01-18 Thread Wei Liu
So that we can have accurate stolen time accounting. Idea taken from Vixen work from Amazon. Signed-off-by: Wei Liu --- Cc: Roger Pau Monné Cc: Anthony Liguori Cc: Jan Beulich Cc: Andrew Cooper

[Xen-devel] [PATCH 2/9] libxl: remove whitespaces introduced in 62982da926

2018-01-18 Thread Wei Liu
Signed-off-by: Wei Liu --- Cc: Ian Jackson --- tools/libxl/libxl_dom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c index b03386409f..e1a3e747fc 100644 ---

[Xen-devel] [PATCH 8/9] xen/consoled: discard NUL from guest

2018-01-18 Thread Wei Liu
According to [0], some program sends NUL for padding purpose. We can discard them. https://www.gnu.org/software/termutils/manual/termcap-1.3/html_mono/termcap.html#SEC7 Reported-by: Sarah Newman Signed-off-by: Wei Liu --- Cc: Sarah Newman

[Xen-devel] [PATCH 7/9] libxl: lower shim related message to level info

2018-01-18 Thread Wei Liu
Signed-off-by: Wei Liu --- Cc: Ian Jackson --- tools/libxl/libxl_dom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c index e1a3e747fc..b880341d7e 100644 ---

[Xen-devel] [PATCH 0/9] Fix and improvements to pvshim

2018-01-18 Thread Wei Liu
First batch of patches to fix problems I know of. Wei Liu (9): Update shim.config libxl: remove whitespaces introduced in 62982da926 x86/guest: clean up guest/xen.h Remove sched=null from shim cmdline and doc x86: relocate pvh_info Revert "x86/boot: Map more than the first 16MB"

[Xen-devel] [PATCH 1/9] Update shim.config

2018-01-18 Thread Wei Liu
To avoid having it changed every time the shim is built. Signed-off-by: Wei Liu --- Cc: Jan Beulich Cc: Andrew Cooper --- tools/firmware/xen-dir/shim.config | 1 - 1 file changed, 1 deletion(-) diff --git

[Xen-devel] [PATCH 3/9] x86/guest: clean up guest/xen.h

2018-01-18 Thread Wei Liu
Remove extraneous semicolon. Add blank lines. Signed-off-by: Wei Liu --- Cc: Jan Beulich Cc: Andrew Cooper --- xen/include/asm-x86/guest/xen.h | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git

Re: [Xen-devel] [PATCH v9 05/11] x86/hvm: Permit guests direct access to MSR_{SPEC_CTRL, PRED_CMD}

2018-01-18 Thread Boris Ostrovsky
On 01/18/2018 10:46 AM, Andrew Cooper wrote: > For performance reasons, HVM guests should have direct access to these MSRs > when possible. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Jun Nakajima > CC:

[Xen-devel] [linux-linus test] 118154: trouble: broken/fail/pass

2018-01-18 Thread osstest service owner
flight 118154 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/118154/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt-raw broken

Re: [Xen-devel] [PATCH] xen: append EXTRA_CFLAGS to CFLAGS for expert builds

2018-01-18 Thread Andrew Cooper
On 18/01/18 17:04, Doug Goldstein wrote: > Allow a user to supply extra CFLAGS via the EXTRA_CFLAGS environment > variable. This is not a configuration that is supported but is only > aimed to help support testing and troubleshooting when you need to make > changes. > > Signed-off-by: Doug

Re: [Xen-devel] [RFC PATCH] arm64: vgic-v3: Add ITS doorbell region in Dom0 stage-2

2018-01-18 Thread Julien Grall
Hi, On 18/01/18 17:25, Manish Jaggi wrote: On 01/18/2018 10:22 PM, Julien Grall wrote: Hi Manish, Hi Julien, On 18/01/18 06:15, mja...@caviumnetworks.com wrote: From: Manish Jaggi This patch introduces a function vgic_map_translation_space for mapping ITS 64K

Re: [Xen-devel] [RFC PATCH] arm64: vgic-v3: Add ITS doorbell region in Dom0 stage-2

2018-01-18 Thread Manish Jaggi
On 01/18/2018 10:22 PM, Julien Grall wrote: Hi Manish, Hi Julien, On 18/01/18 06:15, mja...@caviumnetworks.com wrote: From: Manish Jaggi This patch introduces a function vgic_map_translation_space for mapping ITS 64K translater space for doorbells in dom0

[Xen-devel] [xen-4.6-testing test] 118166: tolerable FAIL - PUSHED

2018-01-18 Thread osstest service owner
flight 118166 xen-4.6-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/118166/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-xsm 14 saverestore-support-checkfail like 117116 test-armhf-armhf-libvirt-raw 13

Re: [Xen-devel] [PATCH] xen: append EXTRA_CFLAGS to CFLAGS for expert builds

2018-01-18 Thread Ian Jackson
Doug Goldstein writes ("[PATCH] xen: append EXTRA_CFLAGS to CFLAGS for expert builds"): > Allow a user to supply extra CFLAGS via the EXTRA_CFLAGS environment > variable. This is not a configuration that is supported but is only > aimed to help support testing and troubleshooting when you need

[Xen-devel] [PATCH] xen: append EXTRA_CFLAGS to CFLAGS for expert builds

2018-01-18 Thread Doug Goldstein
Allow a user to supply extra CFLAGS via the EXTRA_CFLAGS environment variable. This is not a configuration that is supported but is only aimed to help support testing and troubleshooting when you need to make changes. Signed-off-by: Doug Goldstein --- CC: Andrew Cooper

Re: [Xen-devel] [RFC PATCH] arm64: vgic-v3: Add ITS doorbell region in Dom0 stage-2

2018-01-18 Thread Julien Grall
Hi Manish, On 18/01/18 06:15, mja...@caviumnetworks.com wrote: From: Manish Jaggi This patch introduces a function vgic_map_translation_space for mapping ITS 64K translater space for doorbells in dom0 stage-2. It is required as dom0 PCI devices behined SMMU wont be

Re: [Xen-devel] Ping: [PATCH v2 1/2] x86/PoD: correctly handle non-order-0 decrease-reservation requests

2018-01-18 Thread Julien Grall
Hi Jan, On 18/01/18 15:59, Jan Beulich wrote: On 20.12.17 at 10:34, wrote: p2m_pod_decrease_reservation() at the moment only returns a boolean value: true for "nothing more to do", false for "something more to do". If it returns false, decrease_reservation() will loop over

[Xen-devel] [PATCH v3] x86/hvm: re-work viridian APIC assist code

2018-01-18 Thread Paul Durrant
It appears there is a case where Windows enables the APIC assist enlightenment[1] but does not use it. This scenario is perfectly valid according to the documentation, but causes the state machine in Xen to become confused leading to a domain_crash() such as the following: (XEN) d4: VIRIDIAN

Re: [Xen-devel] [PATCH v2] x86/hvm: re-work viridian APIC assist code

2018-01-18 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 18 January 2018 16:21 > To: Paul Durrant > Cc: Andrew Cooper ; xen- > de...@lists.xenproject.org > Subject: Re: [PATCH v2] x86/hvm: re-work viridian APIC assist

Re: [Xen-devel] [PATCH v2] x86/hvm: re-work viridian APIC assist code

2018-01-18 Thread Jan Beulich
>>> On 18.01.18 at 16:10, wrote: > -int viridian_complete_apic_assist(struct vcpu *v) > +bool viridian_apic_assist_completed(struct vcpu *v) > { > uint32_t *va = v->arch.hvm_vcpu.viridian.vp_assist.va; > -int vector; > > if ( !va ) > -return 0; >

Re: [Xen-devel] [PATCH v2] x86/efi: fix build with linkers that support both coff-x86-64 and pe-x86-64

2018-01-18 Thread Doug Goldstein
On 1/17/18 6:56 AM, Roger Pau Monne wrote: > When using a linker that supports both formats the following error > will be triggered: > > efi/buildid.o: file not recognized: File format is ambiguous > efi/buildid.o: matching formats: coff-x86-64 pe-x86-64 > > Solve this by specifying the

Re: [Xen-devel] [PATCH v9 01/11] x86/thunk: Fix GEN_INDIRECT_THUNK comment

2018-01-18 Thread Jan Beulich
>>> On 18.01.18 at 16:46, wrote: > This is a rebasing error in c/s 858cba0d4c6b "x86: Introduce alternative > indirect thunks" hidden by other changes in the same sentence. > > The name with dots rather than underscores was the prerelease GCC ABI. > > Signed-off-by:

[Xen-devel] Ping: [PATCH v2 1/2] x86/PoD: correctly handle non-order-0 decrease-reservation requests

2018-01-18 Thread Jan Beulich
>>> On 20.12.17 at 10:34, wrote: > p2m_pod_decrease_reservation() at the moment only returns a boolean > value: true for "nothing more to do", false for "something more to do". > If it returns false, decrease_reservation() will loop over the entire > range, calling

[Xen-devel] [PATCH v9 10/11] x86/cpuid: Offer Indirect Branch Controls to guests

2018-01-18 Thread Andrew Cooper
With all infrastructure in place, it is now safe to let guests see and use these features. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Acked-by: Wei Liu --- v9: * Split patch in half with the libxc hunk moving earlier,

[Xen-devel] [PATCH v9 04/11] x86/migrate: Move MSR_SPEC_CTRL on migrate

2018-01-18 Thread Andrew Cooper
Signed-off-by: Andrew Cooper Reviewed-by: Wei Liu Reviewed-by: Jan Beulich --- xen/arch/x86/domctl.c | 2 ++ xen/arch/x86/hvm/hvm.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/xen/arch/x86/domctl.c

[Xen-devel] [PATCH v9 06/11] x86/entry: Organise the use of MSR_SPEC_CTRL at each entry/exit point

2018-01-18 Thread Andrew Cooper
We need to be able to either set or clear IBRS in Xen context, as well as restore appropriate guest values in guest context. See the documentation in asm-x86/spec_ctrl_asm.h for details. Writes to %cr3 are slower when SPEC_CTRL.IBRS is set, so the SPEC_CTRL_{ENTRY/EXIT}* positioning is

[Xen-devel] [PATCH v9 05/11] x86/hvm: Permit guests direct access to MSR_{SPEC_CTRL, PRED_CMD}

2018-01-18 Thread Andrew Cooper
For performance reasons, HVM guests should have direct access to these MSRs when possible. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Jun Nakajima CC: Kevin Tian CC: Boris Ostrovsky

[Xen-devel] [PATCH v9 07/11] x86/boot: Calculate the most appropriate BTI mitigation to use

2018-01-18 Thread Andrew Cooper
Signed-off-by: Andrew Cooper --- CC: Jan Beulich v7: * static, and tweak comment --- docs/misc/xen-command-line.markdown | 6 ++- xen/arch/x86/spec_ctrl.c| 104 ++-- 2 files changed, 105 insertions(+),

[Xen-devel] [PATCH v9 01/11] x86/thunk: Fix GEN_INDIRECT_THUNK comment

2018-01-18 Thread Andrew Cooper
This is a rebasing error in c/s 858cba0d4c6b "x86: Introduce alternative indirect thunks" hidden by other changes in the same sentence. The name with dots rather than underscores was the prerelease GCC ABI. Signed-off-by: Andrew Cooper --- CC: Jan Beulich

[Xen-devel] [PATCH v9 03/11] x86/msr: Emulation of MSR_{SPEC_CTRL, PRED_CMD} for guests

2018-01-18 Thread Andrew Cooper
As per the spec currently available here: https://software.intel.com/sites/default/files/managed/c5/63/336996-Speculative-Execution-Side-Channel-Mitigations.pdf MSR_ARCH_CAPABILITIES will only come into existence on new hardware, but is implemented as a straight #GP for now to avoid being leaky

[Xen-devel] [PATCH v9 00/11] x86: Mitigations for SP2/CVE-2017-5715/Branch Target Injection

2018-01-18 Thread Andrew Cooper
This series is availabe in git form from: http://xenbits.xen.org/gitweb/?p=people/andrewcoop/xen.git;a=shortlog;h=refs/heads/sp2-mitigations-v9 A copy of Intel's spec for IBRS/IBPB can be found here:

[Xen-devel] [PATCH] x86: slightly reduce Meltdown band-aid overhead

2018-01-18 Thread Jan Beulich
I'm not sure why I didn't do this right away: By avoiding to make any of the cloned directmap PTEs global, there's no need to fiddle with CR4.PGE on any of the entry paths. Only the exit paths need to flush global mappings. The reduced flushing, however, implies that we now need to have

[Xen-devel] [PATCH v2] x86/hvm: re-work viridian APIC assist code

2018-01-18 Thread Paul Durrant
It appears there is a case where Windows enables the APIC assist enlightenment[1] but does not use it. This scenario is perfectly valid according to the documentation, but causes the state machine in Xen to become confused leading to a domain_crash() such as the following: (XEN) d4: VIRIDIAN

Re: [Xen-devel] [PATCH v2 07/13] iommu: Make decision about needing IOMMU for hardware domains in advance

2018-01-18 Thread Oleksandr Tyshchenko
Hi, Roger On Thu, Jan 18, 2018 at 2:09 PM, Roger Pau Monné wrote: > Sorry for the delay in the reply. No problem. > > On Tue, Jul 25, 2017 at 08:26:49PM +0300, Oleksandr Tyshchenko wrote: >> From: Oleksandr Tyshchenko >> >> The hardware

Re: [Xen-devel] [PATCH v4 2/4] x86emul: Support vpclmulqdq

2018-01-18 Thread Jan Beulich
>>> On 03.01.18 at 09:26, wrote: > The previous vpclmulqdq only support AVX128. > Icelake added AVX256 support. And 512-bit support as well; you only don't add support for the EVEX encoding forms in your patch. The patch itself looks fine, but please clarify its testing

[Xen-devel] [xen-unstable-smoke test] 118210: tolerable all pass - PUSHED

2018-01-18 Thread osstest service owner
flight 118210 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/118210/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-armhf-armhf-xl

[Xen-devel] AMD / SVM vm_event support

2018-01-18 Thread Razvan Cojocaru
Hello, We're looking at potentially working with vm_event on SVM hosts. To that end, we've removed a few cpu_has_vmx tests and saw that some things just work. That is, unfortunately, not the case for EPT events. There's this old thread about NPT support: https://lists.gt.net/xen/devel/339571

Re: [Xen-devel] [PATCH v2 07/13] iommu: Make decision about needing IOMMU for hardware domains in advance

2018-01-18 Thread Roger Pau Monné
Sorry for the delay in the reply. On Tue, Jul 25, 2017 at 08:26:49PM +0300, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > The hardware domains require IOMMU to be used in the most cases and > a decision to use it is made at hardware domain

Re: [Xen-devel] [PATCH v4] kexec-tools: Perform run-time linking of libxenctrl.so

2018-01-18 Thread Daniel Kiper
On Wed, Jan 17, 2018 at 10:39:01AM -0600, Eric DeVolder wrote: > When kexec is utilized in a Xen environment, it has an explicit > run-time dependency on libxenctrl.so. This dependency occurs > during the configure stage and when building kexec-tools. [...] As I saw Simon applied the patch.

Re: [Xen-devel] [PATCH 4/5] xen/arm64: Add skeleton to harden the branch predictor aliasing attacks

2018-01-18 Thread Julien Grall
Hi Stefano, On 17/01/18 18:26, Stefano Stabellini wrote: On Tue, 16 Jan 2018, Julien Grall wrote: diff --git a/xen/include/asm-arm/cpuerrata.h b/xen/include/asm-arm/cpuerrata.h index 7de68361ff..23ebf367ea 100644 --- a/xen/include/asm-arm/cpuerrata.h +++ b/xen/include/asm-arm/cpuerrata.h @@

[Xen-devel] [xen-unstable-smoke test] 118206: regressions - FAIL

2018-01-18 Thread osstest service owner
flight 118206 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/118206/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf 6 xen-buildfail REGR. vs. 118105 Tests which

Re: [Xen-devel] [PATCH v10 00/11] Enable Memory Bandwidth Allocation in Xen

2018-01-18 Thread Wei Liu
On Thu, Jan 18, 2018 at 11:31:51AM +, Wei Liu wrote: > On Thu, Jan 18, 2018 at 11:10:50AM +, Wei Liu wrote: > > On Tue, Jan 09, 2018 at 08:31:52AM +0800, Yi Sun wrote: > > > On 18-01-08 12:25:02, Wei Liu wrote: > > > > On Mon, Jan 08, 2018 at 12:28:58PM +0800, Yi Sun wrote: > > > > > On

Re: [Xen-devel] [PATCH 4/5] x86/pv: Drop support for paging out the LDT

2018-01-18 Thread Jan Beulich
>>> On 18.01.18 at 12:00, wrote: > On 18/01/18 10:57, Andrew Cooper wrote: >> On 18/01/18 10:38, George Dunlap wrote: >>> On Thu, Jan 18, 2018 at 7:59 AM, Jan Beulich wrote: >>> On 12.01.18 at 19:37, wrote: > ---

Re: [Xen-devel] [PATCH v10 00/11] Enable Memory Bandwidth Allocation in Xen

2018-01-18 Thread Wei Liu
On Thu, Jan 18, 2018 at 11:10:50AM +, Wei Liu wrote: > On Tue, Jan 09, 2018 at 08:31:52AM +0800, Yi Sun wrote: > > On 18-01-08 12:25:02, Wei Liu wrote: > > > On Mon, Jan 08, 2018 at 12:28:58PM +0800, Yi Sun wrote: > > > > On 17-12-20 02:11:32, Jan Beulich wrote: > > > > > >>> On 19.12.17 at

Re: [Xen-devel] [PATCH v2 3/6] xen/pvshim: identity pin shim vCPUs to pCPUs

2018-01-18 Thread Roger Pau Monné
On Thu, Jan 18, 2018 at 04:22:11AM -0700, Jan Beulich wrote: > >>> On 18.01.18 at 12:11, wrote: > > Jan Beulich writes ("Re: [PATCH v2 3/6] xen/pvshim: identity pin shim vCPUs > > to pCPUs"): > >> On 17.01.18 at 17:29, wrote: > >> > Since

Re: [Xen-devel] [PATCH] x86/hvm: more sure APIC assist is aborted if guest EOIs APIC

2018-01-18 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Paul Durrant > Sent: 18 January 2018 10:37 > To: 'Jan Beulich' > Cc: Andrew Cooper ; xen- > de...@lists.xenproject.org > Subject: Re:

Re: [Xen-devel] [PATCH 5/5] xen/arm64: Implement branch predictor hardening for affected Cortex-A CPUs

2018-01-18 Thread Julien Grall
Hi, On 17/01/18 17:11, Stefano Stabellini wrote: On Wed, 17 Jan 2018, Julien Grall wrote: Hi Stefano, On 17/01/18 00:42, Stefano Stabellini wrote: On Tue, 16 Jan 2018, Julien Grall wrote: #define MIDR_RANGE(model, min, max) \ @@ -205,6 +232,28 @@ static const struct

Re: [Xen-devel] [PATCH v3 6/7] firmware/shim: fix build process to use POSIX find options

2018-01-18 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH v3 6/7] firmware/shim: fix build process to use POSIX find options"): > The -printf find option is not POSIX compatible, so replace it with > another rune. Acked-by: Ian Jackson ___ Xen-devel

Re: [Xen-devel] [PATCH v3 7/7] xen/pvshim: switch shim.c to use typesafe mfn_to_page and virt_to_mfn

2018-01-18 Thread Wei Liu
On Thu, Jan 18, 2018 at 11:02:52AM +, Roger Pau Monne wrote: > No functional change intended. > > Signed-off-by: Roger Pau Monné > Requested-by: Andrew Cooper Reviewed-by: Wei Liu

Re: [Xen-devel] [PATCH v2 3/6] xen/pvshim: identity pin shim vCPUs to pCPUs

2018-01-18 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH v2 3/6] xen/pvshim: identity pin shim vCPUs to pCPUs"): > On 17.01.18 at 17:29, wrote: > > Since VCPUOP_{up/down} already identity maps vCPU hotplug to pCPU > > hotplug also identity pin the vCPUs to the pCPUs in the scheduler. > > This

Re: [Xen-devel] [PATCH 6/6] firmware/shim: fix build process to use POSIX find options

2018-01-18 Thread Ian Jackson
Roger Pau Monné writes ("Re: [Xen-devel] [PATCH 6/6] firmware/shim: fix build process to use POSIX find options"): > What about using: > > find $(XEN_ROOT)/$(d)/ -type d | sed 's,^$(XEN_ROOT)/$(d)/,,g' | xargs mkdir > -p > > This AFAICT works fine, and should be the one involving less forks >

Re: [Xen-devel] [PATCH v10 00/11] Enable Memory Bandwidth Allocation in Xen

2018-01-18 Thread Wei Liu
On Tue, Jan 09, 2018 at 08:31:52AM +0800, Yi Sun wrote: > On 18-01-08 12:25:02, Wei Liu wrote: > > On Mon, Jan 08, 2018 at 12:28:58PM +0800, Yi Sun wrote: > > > On 17-12-20 02:11:32, Jan Beulich wrote: > > > > >>> On 19.12.17 at 01:42, wrote: > > > > > We plan to bring a

Re: [Xen-devel] [PATCH] ocaml: fix arm build

2018-01-18 Thread Wei Liu
On Thu, Jan 18, 2018 at 10:44:58AM +, Wei Liu wrote: > On Wed, Jan 17, 2018 at 04:43:54PM +, Wei Liu wrote: > > ARM doesn't have emulation_flags in the arch_domainconfig. > > > > Signed-off-by: Wei Liu > > --- > > Cc: Ian Jackson > > Cc:

[Xen-devel] [PATCH v3 4/7] xen/pvshim: re-order replace_va_mapping code

2018-01-18 Thread Roger Pau Monne
No functional change. Signed-off-by: Roger Pau Monné Reviewed-by: Wei Liu Acked-by: Jan Beulich --- Cc: Jan Beulich Cc: Andrew Cooper --- Changes since v1: - Fix double ; and space.

Re: [Xen-devel] [PATCH v3 7/7] xen/pvshim: switch shim.c to use typesafe mfn_to_page and virt_to_mfn

2018-01-18 Thread Andrew Cooper
On 18/01/18 11:02, Roger Pau Monne wrote: > No functional change intended. > > Signed-off-by: Roger Pau Monné > Requested-by: Andrew Cooper > --- > Cc: Jan Beulich > Cc: Andrew Cooper > Cc: Wei Liu

[Xen-devel] [PATCH v3 5/7] xen/pvshim: fix coding style issues

2018-01-18 Thread Roger Pau Monne
Fix a couple of coding style issues. No code or functional change. Signed-off-by: Roger Pau Monné Reviewed-by: Wei Liu Acked-by: Jan Beulich --- Cc: Jan Beulich Cc: Andrew Cooper ---

[Xen-devel] [PATCH v3 3/7] xen/pvshim: identity pin shim vCPUs to pCPUs

2018-01-18 Thread Roger Pau Monne
Since VCPUOP_{up/down} already identity maps vCPU hotplug to pCPU hotplug also identity pin the vCPUs to the pCPUs in the scheduler. This prevents vCPU migration and should improve performance. While there also use __cpumask_set_cpu instead of cpumask_set_cpu, there's no need to use the locked

[Xen-devel] [PATCH v3 7/7] xen/pvshim: switch shim.c to use typesafe mfn_to_page and virt_to_mfn

2018-01-18 Thread Roger Pau Monne
No functional change intended. Signed-off-by: Roger Pau Monné Requested-by: Andrew Cooper --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Wei Liu --- xen/arch/x86/pv/shim.c | 26

[Xen-devel] [PATCH v3 6/7] firmware/shim: fix build process to use POSIX find options

2018-01-18 Thread Roger Pau Monne
The -printf find option is not POSIX compatible, so replace it with another rune. Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson Cc: Wei Liu --- Changes since v1: - Drop the exec rune and instead process the whole

[Xen-devel] [PATCH v3 2/7] xen/pvh: place the trampoline starting at MFN 1

2018-01-18 Thread Roger Pau Monne
Since PVH guest jump straight into trampoline_setup trampoline_phys is not initialized, thus the trampoline is relocated to address 0. This works, but has the undesirable effect of having VA 0 mapped to MFN 0, which means NULL pointed dereferences no longer trigger a page fault. In order to

[Xen-devel] [PATCH v3 1/7] xen/pvshim: map vcpu_info earlier for APs

2018-01-18 Thread Roger Pau Monne
Or else init_percpu_time is going to dereference a NULL pointer when trying to access vcpu_info. Signed-off-by: Roger Pau Monné Reviewed-by: Wei Liu Acked-by: Jan Beulich --- Cc: Jan Beulich Cc: Andrew Cooper

[Xen-devel] [PATCH v3 0/7] xen/pvshim: fixes for staging

2018-01-18 Thread Roger Pau Monne
Hello, The following series contain some code and style fixes for the pvshim (comet) code that has been merged into staging. IMHO patches 1-3 should be backported to the stable comet branch. A branch with the series is also available at: git://xenbits.xen.org/people/royger/xen.git

Re: [Xen-devel] [PATCH 4/5] x86/pv: Drop support for paging out the LDT

2018-01-18 Thread Andrew Cooper
On 18/01/18 10:57, Andrew Cooper wrote: > On 18/01/18 10:38, George Dunlap wrote: >> On Thu, Jan 18, 2018 at 7:59 AM, Jan Beulich wrote: >> On 12.01.18 at 19:37, wrote: Windows is the only OS which pages out kernel datastructures, so chances

Re: [Xen-devel] [PATCH 4/5] x86/pv: Drop support for paging out the LDT

2018-01-18 Thread Andrew Cooper
On 18/01/18 10:38, George Dunlap wrote: > On Thu, Jan 18, 2018 at 7:59 AM, Jan Beulich wrote: > On 12.01.18 at 19:37, wrote: >>> Windows is the only OS which pages out kernel datastructures, so chances are >>> good that this is a vestigial

Re: [Xen-devel] [PATCH 4/5] x86/pv: Drop support for paging out the LDT

2018-01-18 Thread Jan Beulich
>>> On 18.01.18 at 11:38, wrote: > On Thu, Jan 18, 2018 at 7:59 AM, Jan Beulich wrote: > On 12.01.18 at 19:37, wrote: >>> --- a/xen/arch/x86/domain.c >>> +++ b/xen/arch/x86/domain.c >>> @@ -1942,11 +1942,8 @@ int

Re: [Xen-devel] [PATCH 1/5] xen/arm: Introduce enable callback to enable a capabilities on each online CPU

2018-01-18 Thread Julien Grall
On 17/01/18 14:31, Lars Kurth wrote: Hi Julien, Hi Lars, On 17 Jan 2018, at 12:31, Julien Grall > wrote: If you took the code from Linux, you need to add the original Signed-off-by from the Linux commit. Aside from that: There

Re: [Xen-devel] [PATCH] ocaml: fix arm build

2018-01-18 Thread Wei Liu
On Wed, Jan 17, 2018 at 04:43:54PM +, Wei Liu wrote: > ARM doesn't have emulation_flags in the arch_domainconfig. > > Signed-off-by: Wei Liu > --- > Cc: Ian Jackson > Cc: Julien Grall > Cc: Andrew Cooper

Re: [Xen-devel] [PATCH 4/5] x86/pv: Drop support for paging out the LDT

2018-01-18 Thread George Dunlap
On Thu, Jan 18, 2018 at 7:59 AM, Jan Beulich wrote: On 12.01.18 at 19:37, wrote: >> Windows is the only OS which pages out kernel datastructures, so chances are >> good that this is a vestigial remnant of the PV Windows XP experiment. > > This

Re: [Xen-devel] [PATCH] x86/hvm: more sure APIC assist is aborted if guest EOIs APIC

2018-01-18 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 18 January 2018 10:17 > To: Paul Durrant > Cc: Andrew Cooper ; xen- > de...@lists.xenproject.org > Subject: RE: [PATCH] x86/hvm: more sure APIC assist is aborted

Re: [Xen-devel] [PATCH v2] libxl: put RSDP for PVH guest near 4GB

2018-01-18 Thread Wei Liu
On Thu, Jan 18, 2018 at 11:31:32AM +0100, Juergen Gross wrote: > Wei, > > On 01/12/17 15:14, Juergen Gross wrote: > > Instead of locating the RSDP table below 1MB put it just below 4GB > > like the rest of the ACPI tables in case of PVH guests. This will > > avoid punching more holes than

Re: [Xen-devel] [PATCH v2] libxl: put RSDP for PVH guest near 4GB

2018-01-18 Thread Juergen Gross
Wei, On 01/12/17 15:14, Juergen Gross wrote: > Instead of locating the RSDP table below 1MB put it just below 4GB > like the rest of the ACPI tables in case of PVH guests. This will > avoid punching more holes than necessary into the memory map. > > Signed-off-by: Juergen Gross

Re: [Xen-devel] [PATCH] x86/hvm: more sure APIC assist is aborted if guest EOIs APIC

2018-01-18 Thread Jan Beulich
>>> On 18.01.18 at 10:55, wrote: > Ok. I'll re-work it so that abort is passed a vector and warns on mismatch. You mean on the new path only, I suppose? The old path should not trigger warnings (aiui it would always do so). Jan

Re: [Xen-devel] [PATCH 6/6] firmware/shim: fix build process to use POSIX find options

2018-01-18 Thread Roger Pau Monné
On Wed, Jan 17, 2018 at 05:58:43PM +, Andrew Cooper wrote: > On 17/01/18 17:32, Roger Pau Monné wrote: > > On Wed, Jan 17, 2018 at 04:24:27PM +, Ian Jackson wrote: > >> Roger Pau Monne writes ("[PATCH 6/6] firmware/shim: fix build process to > >> use POSIX find options"): > >>> The

  1   2   >