Re: [Xen-devel] [PATCH] x86: slightly reduce Meltdown band-aid overhead

2018-01-29 Thread Jan Beulich
>>> On 29.01.18 at 19:55, wrote: > On 18/01/18 15:39, Jan Beulich wrote: >> I'm not sure why I didn't do this right away: By avoiding to make any >> of the cloned directmap PTEs global, there's no need to fiddle with > > "avoiding to make" is a very odd way of phrasing

Re: [Xen-devel] [PATCH] x86/asm: Drop __GET_CURRENT()

2018-01-29 Thread Jan Beulich
>>> On 29.01.18 at 19:12, wrote: > __GET_CURRENT() is very dangerous to use, as is easy to confuse with I wouldn't say "very", but for the change as a whole - well, yes, why not. > GET_CURRENT(), but strictly depends on the regster parameter already having > the

[Xen-devel] [linux-next test] 118435: regressions - FAIL

2018-01-29 Thread osstest service owner
flight 118435 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/118435/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-examine 8 reboot fail REGR. vs. 118401

[Xen-devel] [qemu-mainline test] 118436: regressions - FAIL

2018-01-29 Thread osstest service owner
flight 118436 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/118436/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ws16-amd64 16 guest-localmigrate/x10 fail REGR. vs. 118411

[Xen-devel] [seabios test] 118440: regressions - FAIL

2018-01-29 Thread osstest service owner
flight 118440 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/118440/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail REGR. vs. 115539 Tests which did not

Re: [Xen-devel] [bug]xen 4.10 + dom0 4.15 couldn't boot up

2018-01-29 Thread Zhang, Xiong Y
The message is really short. Dom0 error happens before the first kernel message: ▒ Xen 4.11-unstable (XEN) Xen version 4.11-unstable (test@) (gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609) debug=n Tue Jan 30 02:38:14 CST 2018 (XEN) Latest ChangeSet: Wed Jan 24 12:01:55 2018 +

Re: [Xen-devel] GPU passthrough on ARM

2018-01-29 Thread Martin Kelly
On 01/29/2018 08:31 AM, Oleksandr Tyshchenko wrote: Hi On Sat, Jan 27, 2018 at 2:41 AM, Martin Kelly wrote: On 01/26/2018 10:13 AM, Oleksandr Tyshchenko wrote: Hi, Martin On Fri, Jan 26, 2018 at 8:05 PM, Oleksandr Tyshchenko wrote: On Fri, Jan 26,

[Xen-devel] [xen-4.8-testing test] 118431: regressions - FAIL

2018-01-29 Thread osstest service owner
flight 118431 xen-4.8-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/118431/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-win7-amd64 broken in 118369 test-amd64-i386-livepatch

[Xen-devel] [PATCH V2] tests/xen-access: disable CR4 write events on application exit

2018-01-29 Thread Razvan Cojocaru
On exit, xen-access did not unsubscribe from CR4 write vm_events, potentially leaving the guest stuck. Signed-off-by: Razvan Cojocaru --- Changes since V1: - Made all the ignored parameters of xc_monitor_write_ctrlreg() zeroes. ---

[Xen-devel] [linux-linus test] 118428: regressions - FAIL

2018-01-29 Thread osstest service owner
flight 118428 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/118428/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-amd64 16 guest-localmigrate/x10 fail REGR. vs. 118324 Tests

Re: [Xen-devel] [PATCH] tests/xen-access: disable CR4 write events on application exit

2018-01-29 Thread Tamas K Lengyel
On Mon, Jan 29, 2018 at 11:03 AM, Razvan Cojocaru wrote: > On 01/29/2018 07:58 PM, Tamas K Lengyel wrote: >> On Mon, Jan 29, 2018 at 10:10 AM, Razvan Cojocaru >> wrote: >>> On exit, xen-access did not unsubscribe from CR4 write vm_events, >>>

Re: [Xen-devel] [PATCH 2/5] xen/alternatives: Plumb a 'live' parameter through apply_alternatives()

2018-01-29 Thread Stefano Stabellini
On Mon, 29 Jan 2018, Andrew Cooper wrote: > On x86, we would like to alter how we patch based on whether there is any > chance of the code being patched being concurrently executed. > > prepare_payload() passes false (as the livepatch definitely isn't live at this > point), whereas the boot-time

Re: [Xen-devel] [PATCH 1/5] arm/alternatives: Fix apply_alternatives() API

2018-01-29 Thread Stefano Stabellini
On Mon, 29 Jan 2018, Andrew Cooper wrote: > The !HAS_ALTERNATIVE case has bit-rotten and won't even compile. > > The x86 side of apply_alternatives() is void, while the ARM side returns int. > However, the functions can't fail and no return values are checked. Switch > the ARM side to be void as

Re: [Xen-devel] Supported hardware

2018-01-29 Thread Stefano Stabellini
On Mon, 29 Jan 2018, Julien Grall wrote: > Hello, > > On 28/01/18 11:10, Pieter Dewachter wrote: > > Dear developers, > > Hi Pieter, > > Thank you for your interest on Xen. > > > > > > > ​I'm doing my master thesis this year and I will be using the Xen hypervisor > > for it. The domain for

[Xen-devel] [PATCH 4.9 01/66] x86/asm/32: Make sync_core() handle missing CPUID on all 32-bit kernels

2018-01-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Andy Lutomirski commit 1c52d859cb2d417e7216d3e56bb7fea88444cec9 upstream. We support various non-Intel CPUs that don't have the CPUID instruction, so the M486 test was wrong.

[Xen-devel] [PATCH 4.4 01/74] x86/asm/32: Make sync_core() handle missing CPUID on all 32-bit kernels

2018-01-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Andy Lutomirski commit 1c52d859cb2d417e7216d3e56bb7fea88444cec9 upstream. We support various non-Intel CPUs that don't have the CPUID instruction, so the M486 test was wrong.

[Xen-devel] [xen-unstable-smoke test] 118442: tolerable all pass - PUSHED

2018-01-29 Thread osstest service owner
flight 118442 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/118442/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] [PATCH] x86: slightly reduce Meltdown band-aid overhead

2018-01-29 Thread Andrew Cooper
On 29/01/18 18:55, Andrew Cooper wrote: > On 18/01/18 15:39, Jan Beulich wrote: >> Along those lines the "sync" IPI after L4 entry updates now needs to become a >> real (and global) flush IPI, so that inside Xen we'll also pick up such >> changes. > The entry paths don't tick the TLB clock, so we

Re: [Xen-devel] [PATCH] x86: slightly reduce Meltdown band-aid overhead

2018-01-29 Thread Andrew Cooper
On 18/01/18 15:39, Jan Beulich wrote: > I'm not sure why I didn't do this right away: By avoiding to make any > of the cloned directmap PTEs global, there's no need to fiddle with "avoiding to make" is a very odd way of phrasing this.  Something like "By avoiding the use of global PTEs in the

Re: [Xen-devel] [PATCH v3 5/5] x86: remove usage of .skip with non-absolute expressions

2018-01-29 Thread Andrew Cooper
On 29/01/18 16:50, Jan Beulich wrote: On 29.01.18 at 13:26, wrote: >> Clang assembler doesn't support using .skip with non-absolute >> expressions: >> >> entry.S:109:15: error: expected absolute expression >> .skip .Lcr4_alt_end - .Lcr4_alt, 0x90 >>

[Xen-devel] [PATCH] x86/asm: Drop __GET_CURRENT()

2018-01-29 Thread Andrew Cooper
__GET_CURRENT() is very dangerous to use, as is easy to confuse with GET_CURRENT(), but strictly depends on the regster parameter already having the STACK_END value in it. Also, there is no reason to special case accesses of current_vcpu differently to other cpuinfo fields. Expand

Re: [Xen-devel] [PATCH] tests/xen-access: disable CR4 write events on application exit

2018-01-29 Thread Razvan Cojocaru
On 01/29/2018 07:58 PM, Tamas K Lengyel wrote: > On Mon, Jan 29, 2018 at 10:10 AM, Razvan Cojocaru > wrote: >> On exit, xen-access did not unsubscribe from CR4 write vm_events, >> potentially leaving the guest stuck. >> >> Signed-off-by: Razvan Cojocaru

Re: [Xen-devel] [PATCH] tests/xen-access: disable CR4 write events on application exit

2018-01-29 Thread Tamas K Lengyel
On Mon, Jan 29, 2018 at 10:10 AM, Razvan Cojocaru wrote: > On exit, xen-access did not unsubscribe from CR4 write vm_events, > potentially leaving the guest stuck. > > Signed-off-by: Razvan Cojocaru > --- >

[Xen-devel] [OSSTEST PATCH 1/2] mg-force-push: unshift . onto @INC

2018-01-29 Thread Ian Jackson
This script seems to have missed out on the bulk commit fixing this problem. Signed-off-by: Ian Jackson --- mg-force-push | 1 + 1 file changed, 1 insertion(+) diff --git a/mg-force-push b/mg-force-push index 4a8f0a2..09c1894 100755 --- a/mg-force-push +++

[Xen-devel] [OSSTEST PATCH] daily-cron-email-*: Replace lists.xensource.com with lists.xenproject.org

2018-01-29 Thread Ian Jackson
The .xensource.com domain is quite deprecated now. Reported-by: Doug Goldstein Reported-by: Andrew Cooper Signed-off-by: Ian Jackson --- daily-cron-email-real | 2 +-

[Xen-devel] [OSSTEST PATCH 2/2] mg-hosts: Call db_readonly_report inside, not outside, db_retry

2018-01-29 Thread Ian Jackson
Newer postgresql prints: WARNING: SET TRANSACTION can only be used in transaction blocks and it is right. Signed-off-by: Ian Jackson --- mg-force-push | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mg-force-push b/mg-force-push index

[Xen-devel] [PATCH] tests/xen-access: disable CR4 write events on application exit

2018-01-29 Thread Razvan Cojocaru
On exit, xen-access did not unsubscribe from CR4 write vm_events, potentially leaving the guest stuck. Signed-off-by: Razvan Cojocaru --- tools/tests/xen-access/xen-access.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/tests/xen-access/xen-access.c

Re: [Xen-devel] [PATCH RFC v2 07/12] x86: allow per-domain mappings without NX bit or with specific mfn

2018-01-29 Thread Jan Beulich
>>> On 22.01.18 at 13:32, wrote: > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -1568,7 +1568,7 @@ void init_xen_l4_slots(l4_pgentry_t *l4t, mfn_t l4mfn, > > /* Slot 260: Per-domain mappings (if applicable). */ > l4t[l4_table_offset(PERDOMAIN_VIRT_START)] =

Re: [Xen-devel] [PATCH v3 3/5] x86: fix indirect thunk usage of CONFIG_INDIRECT_THUNK

2018-01-29 Thread Roger Pau Monné
On Mon, Jan 29, 2018 at 09:45:35AM -0700, Jan Beulich wrote: > >>> On 29.01.18 at 13:26, wrote: > > --- a/xen/include/asm-x86/asm_defns.h > > +++ b/xen/include/asm-x86/asm_defns.h > > @@ -14,6 +14,9 @@ > > #include > > > > #ifdef __ASSEMBLY__ > > +# ifndef

Re: [Xen-devel] [PATCH] x86: reduce Meltdown band-aid IPI overhead

2018-01-29 Thread Jan Beulich
>>> On 29.01.18 at 17:33, wrote: > On 26/01/18 12:07, Jan Beulich wrote: >> In case we can detect single-threaded guest processes (by checking >> whether we can account for all root page table uses locally on the vCPU >> that's running), there's no point in issuing a

Re: [Xen-devel] [PATCH v3 4/5] x86: move declaration of the exception_table to C

2018-01-29 Thread Jan Beulich
>>> On 29.01.18 at 13:26, wrote: > This makes the code cleaner because there's no need to declare the > exception_table in assembly, and also fixes the following error when > using clang's integrated assembler: > > entry.S:834:15: error: unexpected token in '.rept'

Re: [Xen-devel] [PATCH v3 3/5] x86: fix indirect thunk usage of CONFIG_INDIRECT_THUNK

2018-01-29 Thread Jan Beulich
>>> On 29.01.18 at 13:26, wrote: > --- a/xen/include/asm-x86/asm_defns.h > +++ b/xen/include/asm-x86/asm_defns.h > @@ -14,6 +14,9 @@ > #include > > #ifdef __ASSEMBLY__ > +# ifndef CONFIG_INDIRECT_THUNK > +# define CONFIG_INDIRECT_THUNK 0 > +# endif Why not an

Re: [Xen-devel] [PATCH v3 2/5] x86/clang: fix build with indirect thunks

2018-01-29 Thread Jan Beulich
>>> On 29.01.18 at 13:26, wrote: > --- a/Config.mk > +++ b/Config.mk > @@ -157,17 +157,16 @@ ifndef XEN_HAS_CHECKPOLICY > endif > > # as-insn: Check whether assembler supports an instruction. > -# Usage: cflags-y += $(call as-insn "insn",option-yes,option-no) > +# Usage:

Re: [Xen-devel] [PATCH] x86: reduce Meltdown band-aid IPI overhead

2018-01-29 Thread Andrew Cooper
On 26/01/18 12:07, Jan Beulich wrote: > In case we can detect single-threaded guest processes (by checking > whether we can account for all root page table uses locally on the vCPU > that's running), there's no point in issuing a sync IPI upon an L4 entry > update, as no other vCPU of the guest

Re: [Xen-devel] GPU passthrough on ARM

2018-01-29 Thread Oleksandr Tyshchenko
Hi On Sat, Jan 27, 2018 at 2:41 AM, Martin Kelly wrote: > On 01/26/2018 10:13 AM, Oleksandr Tyshchenko wrote: >> >> Hi, Martin >> >> On Fri, Jan 26, 2018 at 8:05 PM, Oleksandr Tyshchenko >> wrote: >>> >>> On Fri, Jan 26, 2018 at 3:49 PM, Julien Grall

Re: [Xen-devel] [PATCH] x86/hvm: Drop hvm_set_mode() and associated vmx hooks

2018-01-29 Thread Roger Pau Monné
On Mon, Jan 29, 2018 at 04:10:32PM +, Andrew Cooper wrote: > This is more vestigial rementants of PVHv1. > > Signed-off-by: Andrew Cooper Oh, thanks! It's amazing how many leftovers we are still finding from PVHv1. Reviewed-by: Roger Pau Monné

Re: [Xen-devel] [PATCH] x86/hvm: Drop hvm_set_mode() and associated vmx hooks

2018-01-29 Thread Jan Beulich
>>> On 29.01.18 at 17:10, wrote: > This is more vestigial rementants of PVHv1. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Jun Nakajima > CC: Kevin Tian >

[Xen-devel] [PATCH] xen/evtchn: Cleanup for virq_is_global() infrastructure

2018-01-29 Thread Andrew Cooper
Switch it, and the arch infrastructure, to return bool. Drop the unnecessary rc parameter, and remove a redundant assertion from send_global_virq(). No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Stefano Stabellini

[Xen-devel] [PATCH] x86/hvm: Drop hvm_set_mode() and associated vmx hooks

2018-01-29 Thread Andrew Cooper
This is more vestigial rementants of PVHv1. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Jun Nakajima CC: Kevin Tian --- xen/arch/x86/hvm/hvm.c| 23 ---

[Xen-devel] [xen-unstable-smoke test] 118439: regressions - FAIL

2018-01-29 Thread osstest service owner
flight 118439 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/118439/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 118363 Tests which

[Xen-devel] [PATCH 1/5] arm/alternatives: Fix apply_alternatives() API

2018-01-29 Thread Andrew Cooper
The !HAS_ALTERNATIVE case has bit-rotten and won't even compile. The x86 side of apply_alternatives() is void, while the ARM side returns int. However, the functions can't fail and no return values are checked. Switch the ARM side to be void as well. One observation is that

[Xen-devel] [PATCH 4/5] x86/alternative: Implement NMI/#MC-safe patching

2018-01-29 Thread Andrew Cooper
Patching code which is being executed is problematic, because it impossible to arrange an atomic update of the instruction stream outside of a few corner cases. Furthermore, we have no feasible way to prevent execution of the NMI and #MC exception handlers, but have patch points in them. Use a

[Xen-devel] [PATCH 3/5] x86/livepatch: Use text_poke() and plumb a live parameter through

2018-01-29 Thread Andrew Cooper
Update text_poke() to return void (rather than void *), take a live parameter, and export it for arch_livepatch_apply() to use. arch_livepatch_apply() can therefore lose its noinline for i-cache safey, as text_poke() is doing the heavy lifting. Signed-off-by: Andrew Cooper

[Xen-devel] [PATCH 0/5] x86: Implement interrupt-safe livepatching

2018-01-29 Thread Andrew Cooper
So it turns out that this is quite a lot easier than I feared. Only compile-tested on ARM, but functionally tested on x86. Andrew Cooper (5): arm/alternatives: Fix apply_alternatives() API xen/alternatives: Plumb a 'live' parameter through apply_alternatives() x86/livepatch: Use

[Xen-devel] [PATCH 5/5] DO-NOT-APPLY - Demonstrates an NMI hitting an in-progress patch

2018-01-29 Thread Andrew Cooper
--- xen/arch/x86/alternative.c | 15 +++ xen/arch/x86/x86_64/entry.S | 4 2 files changed, 19 insertions(+) diff --git a/xen/arch/x86/alternative.c b/xen/arch/x86/alternative.c index 40bfaad..10e423c 100644 --- a/xen/arch/x86/alternative.c +++ b/xen/arch/x86/alternative.c @@

Re: [Xen-devel] [PATCH] xen: Fix XSM build after dropping XEN_DOMCTL_getmemlist

2018-01-29 Thread Daniel De Graaf
On 01/26/2018 02:34 PM, Andrew Cooper wrote: c/s 94450e36bfbb removed XEN_DOMCTL_getmemlist entirely, but missed adjusting the XSM side of things. As far as I can tell, 'pagelist' wasn't even offered to dom0 in default policy. Also, drop the stale struct xen_domctl_getmemlist which was missed

Re: [Xen-devel] [PATCH] tools/libxl: Fix assertion failure when trying to build a nested-virt PVH domain

2018-01-29 Thread Ian Jackson
Roger Pau Monné writes ("Re: [Xen-devel] [PATCH] tools/libxl: Fix assertion failure when trying to build a nested-virt PVH domain"): > On Fri, Jan 26, 2018 at 07:23:52PM +, Andrew Cooper wrote: ... > > I'm not the check is overly old to begin with.  We should probably fix > > it in the

Re: [Xen-devel] [PATCH v3 1/5] build: filter out command line assembler arguments

2018-01-29 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH v3 1/5] build: filter out command line assembler arguments"): > If the assembler is not used. This happens when using cc -E or cc -S > for example. GCC will just ignore the -Wa,... when the assembler is > not called, but clang will complain loudly and fail. ... >

Re: [Xen-devel] [PATCH v8 07/11] vpci/bars: add handlers to map the BARs

2018-01-29 Thread Roger Pau Monné
On Tue, Jan 23, 2018 at 03:07:31PM +, Roger Pau Monne wrote: > +static void bar_write(const struct pci_dev *pdev, unsigned int reg, > + uint32_t val, void *data) > +{ > +struct vpci_bar *bar = data; > +uint8_t slot = PCI_SLOT(pdev->devfn), func =

Re: [Xen-devel] [xen-unstable test] 118393: regressions - FAIL

2018-01-29 Thread Andrew Cooper
On 28/01/18 16:06, osstest service owner wrote: > flight 118393 xen-unstable real [real] > http://logs.test-lab.xenproject.org/osstest/logs/118393/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-armhf-armhf-xl-credit2 16

Re: [Xen-devel] [PATCH v3 5/5] x86: remove usage of .skip with non-absolute expressions

2018-01-29 Thread Jan Beulich
>>> On 29.01.18 at 14:05, wrote: > On 29/01/18 13:02, Jan Beulich wrote: > On 29.01.18 at 13:43, wrote: >>> On Mon, Jan 29, 2018 at 12:26:43PM +, Roger Pau Monne wrote: Clang assembler doesn't support using .skip with non-absolute

[Xen-devel] [xen-unstable-smoke test] 118437: regressions - FAIL

2018-01-29 Thread osstest service owner
flight 118437 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/118437/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 118363 Tests which

Re: [Xen-devel] Access I2C bus from guest/DomU on ARM board

2018-01-29 Thread Saumya Rajesh
On Thu, Jan 18, 2018 at 1:20 PM, Saumya Rajesh wrote: > On Wed, Jan 17, 2018 at 9:06 PM, Andrii Anisov > wrote: >> >> Rajesh, >> >> On 17.01.18 16:03, Saumya Rajesh wrote: >>> >>> Just out of curiosity, is it possible to split the Driver for the

Re: [Xen-devel] [PATCH v3 5/5] x86: remove usage of .skip with non-absolute expressions

2018-01-29 Thread Andrew Cooper
On 29/01/18 13:02, Jan Beulich wrote: On 29.01.18 at 13:43, wrote: >> On Mon, Jan 29, 2018 at 12:26:43PM +, Roger Pau Monne wrote: >>> Clang assembler doesn't support using .skip with non-absolute >>> expressions: >>> >> But so is GNU as. From its manual for .skip:

Re: [Xen-devel] [PATCH] x86/hvm: fix domain crash when CR3 has the noflush bit set

2018-01-29 Thread Razvan Cojocaru
On 01/29/2018 02:58 PM, Jan Beulich wrote: On 29.01.18 at 13:44, wrote: >> On 01/26/2018 12:27 PM, Jan Beulich wrote: >> On 26.01.18 at 10:39, wrote: --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -2324,6

Re: [Xen-devel] [PATCH v3 5/5] x86: remove usage of .skip with non-absolute expressions

2018-01-29 Thread Jan Beulich
>>> On 29.01.18 at 13:43, wrote: > On Mon, Jan 29, 2018 at 12:26:43PM +, Roger Pau Monne wrote: >> Clang assembler doesn't support using .skip with non-absolute >> expressions: >> > > But so is GNU as. From its manual for .skip: > > "This directive emits size bytes,

Re: [Xen-devel] [PATCH] x86/hvm: fix domain crash when CR3 has the noflush bit set

2018-01-29 Thread Jan Beulich
>>> On 29.01.18 at 13:44, wrote: > On 01/26/2018 12:27 PM, Jan Beulich wrote: > On 26.01.18 at 10:39, wrote: >>> --- a/xen/arch/x86/hvm/hvm.c >>> +++ b/xen/arch/x86/hvm/hvm.c >>> @@ -2324,6 +2324,9 @@ int hvm_set_cr3(unsigned long value,

Re: [Xen-devel] [PATCH] x86/hvm: fix domain crash when CR3 has the noflush bit set

2018-01-29 Thread Razvan Cojocaru
On 01/26/2018 12:27 PM, Jan Beulich wrote: On 26.01.18 at 10:39, wrote: >> --- a/xen/arch/x86/hvm/hvm.c >> +++ b/xen/arch/x86/hvm/hvm.c >> @@ -2324,6 +2324,9 @@ int hvm_set_cr3(unsigned long value, bool_t may_defer) >> } >> } >> >> +if (

Re: [Xen-devel] [PATCH v3 5/5] x86: remove usage of .skip with non-absolute expressions

2018-01-29 Thread Wei Liu
On Mon, Jan 29, 2018 at 12:26:43PM +, Roger Pau Monne wrote: > Clang assembler doesn't support using .skip with non-absolute > expressions: > But so is GNU as. From its manual for .skip: "This directive emits size bytes, each of value fill. Both size and fill are absolute expressions." >

[Xen-devel] [PATCH v3 5/5] x86: remove usage of .skip with non-absolute expressions

2018-01-29 Thread Roger Pau Monne
Clang assembler doesn't support using .skip with non-absolute expressions: entry.S:109:15: error: expected absolute expression .skip .Lcr4_alt_end - .Lcr4_alt, 0x90 ^ This usage of .skip was to fill code sections with NOPs in order for them to be patched at run time if

[Xen-devel] [PATCH v3 4/5] x86: move declaration of the exception_table to C

2018-01-29 Thread Roger Pau Monne
This makes the code cleaner because there's no need to declare the exception_table in assembly, and also fixes the following error when using clang's integrated assembler: entry.S:834:15: error: unexpected token in '.rept' directive .rept 32 - ((. - exception_table) / 8) ^

[Xen-devel] [PATCH v3 2/5] x86/clang: fix build with indirect thunks

2018-01-29 Thread Roger Pau Monne
The build with clang is currently broken because clang integrated assembler requires asm macros to be declared inside the same inline asm declaration where they are used. In order to fix this always include indirect_thunk_asm.h in the same asm declaration where it's being used. This has been

[Xen-devel] [PATCH v3 3/5] x86: fix indirect thunk usage of CONFIG_INDIRECT_THUNK

2018-01-29 Thread Roger Pau Monne
When indirect_thunk_asm.h is instantiated directly into assembly files CONFIG_INDIRECT_THUNK might not be defined, and thus using .if against it is wrong. Add a check to define CONFIG_INDIRECT_THUNK to 0 if not defined, so that using .if CONFIG_INDIRECT_THUNK is always correct. This suppresses

[Xen-devel] [PATCH v3 1/5] build: filter out command line assembler arguments

2018-01-29 Thread Roger Pau Monne
If the assembler is not used. This happens when using cc -E or cc -S for example. GCC will just ignore the -Wa,... when the assembler is not called, but clang will complain loudly and fail. This is a preparatory change in order to pass assembler arguments when using clang. Signed-off-by: Roger

[Xen-devel] [PATCH v3 0/5] clang fixes

2018-01-29 Thread Roger Pau Monne
Hello, The first 3 patches in this series restore the usage of -no-integrated-as with clang only for assembly files unless it's strictly needed. Then patches 4 and 5 allow to get rid of -no-integrated-as even for assembly files when using clang, thus being able to fully compile Xen using clang's

Re: [Xen-devel] [PATCH 0/8] xen: add pvh guest support

2018-01-29 Thread Daniel Kiper
On Thu, Dec 14, 2017 at 12:44:36PM +0100, Juergen Gross wrote: > On 14/12/17 12:32, Daniel Kiper wrote: > > On Thu, Dec 14, 2017 at 12:26:02PM +0100, Juergen Gross wrote: > >> On 14/12/17 12:19, Daniel Kiper wrote: > >>> On Fri, Dec 01, 2017 at 12:12:50PM +0100, Daniel Kiper wrote: > On Fri,

Re: [Xen-devel] firmware/shim: fix build process to use POSIX find options

2018-01-29 Thread Roger Pau Monné
On Fri, Jan 26, 2018 at 01:54:30PM -0600, Michael Glasgow wrote: > This recent patch can be simplified a bit. (The patch below is > untested, just a suggestion.) > Thanks, this LGTM, but it needs your Signed-off-by tag in order to be applied. Also remember to Cc the maintainers when resending,

Re: [Xen-devel] [PATCH] x86/ioemul: Misc improvements to ioport_emulate.c

2018-01-29 Thread Andrew Cooper
On 29/01/18 11:23, Jan Beulich wrote: On 26.01.18 at 15:48, wrote: >> Put the opcode into an array and use memcpy. This allows the compiled code >> to >> be written with two movs, rather than 10 mov $imm8's. Also, drop trailing >> whitespace in the file. >> >>

Re: [Xen-devel] [PATCH] x86/ioemul: Misc improvements to ioport_emulate.c

2018-01-29 Thread Jan Beulich
>>> On 26.01.18 at 15:48, wrote: > Put the opcode into an array and use memcpy. This allows the compiled code to > be written with two movs, rather than 10 mov $imm8's. Also, drop trailing > whitespace in the file. > > Signed-off-by: Andrew Cooper

Re: [Xen-devel] [PATCH 3/3] x86/emul: Improvements to internal users of decode_register()

2018-01-29 Thread Jan Beulich
>>> On 26.01.18 at 14:16, wrote: > --- a/xen/arch/x86/x86_emulate/x86_emulate.c > +++ b/xen/arch/x86/x86_emulate/x86_emulate.c > @@ -1980,9 +1980,8 @@ load_seg( > return rc; > } > > -void * > -decode_register( > -uint8_t modrm_reg, struct cpu_user_regs

Re: [Xen-devel] [PATCH 1/3] x86/emul: Optimise decode_register() somewhat

2018-01-29 Thread Andrew Cooper
On 29/01/18 11:05, Jan Beulich wrote: On 26.01.18 at 14:16, wrote: >> --- a/xen/arch/x86/x86_emulate/x86_emulate.c >> +++ b/xen/arch/x86/x86_emulate/x86_emulate.c >> @@ -396,6 +396,51 @@ static const struct { >> /* Shift values between src and dst sizes of

Re: [Xen-devel] Supported hardware

2018-01-29 Thread Julien Grall
Hello, On 28/01/18 11:10, Pieter Dewachter wrote: Dear developers, Hi Pieter, Thank you for your interest on Xen. ​I'm doing my master thesis this year and I will be using the Xen hypervisor for it. The domain for my thesis is more about the automotive sector, but unfortunately the

Re: [Xen-devel] [PATCH 2/3] x86/hvm: Improvements to external users of decode_register()

2018-01-29 Thread Jan Beulich
>>> On 26.01.18 at 14:16, wrote: > * Rename to decode_gpr() to be more specific as to its purpose > * Drop the highbyte encoding handling, as users care, and it unlikely that "... as users don't care, and it's ..." or "... as no users care, and it's ..."? > @@ -601,14

Re: [Xen-devel] [PATCH v2] x86: move declaration of the exception_table to C

2018-01-29 Thread Roger Pau Monné
On Mon, Jan 29, 2018 at 03:31:17AM -0700, Jan Beulich wrote: > >>> On 28.01.18 at 15:09, wrote: > > --- a/xen/arch/x86/traps.c > > +++ b/xen/arch/x86/traps.c > > @@ -119,6 +119,26 @@ boolean_param("ler", opt_ler); > > #define stack_words_per_line 4 > > #define

Re: [Xen-devel] [PATCH 1/3] x86/emul: Optimise decode_register() somewhat

2018-01-29 Thread Jan Beulich
>>> On 26.01.18 at 14:16, wrote: > --- a/xen/arch/x86/x86_emulate/x86_emulate.c > +++ b/xen/arch/x86/x86_emulate/x86_emulate.c > @@ -396,6 +396,51 @@ static const struct { > /* Shift values between src and dst sizes of pmov{s,z}x{b,w,d}{w,d,q}. */ > static const

[Xen-devel] [xen-4.9-testing test] 118416: regressions - FAIL

2018-01-29 Thread osstest service owner
flight 118416 xen-4.9-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/118416/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 17 guest-stop fail in 118387 REGR. vs. 118167 Tests

[Xen-devel] [xen-unstable-smoke test] 118434: regressions - FAIL

2018-01-29 Thread osstest service owner
flight 118434 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/118434/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 118363 Tests which

Re: [Xen-devel] [PATCH v2] x86: move declaration of the exception_table to C

2018-01-29 Thread Jan Beulich
>>> On 28.01.18 at 15:09, wrote: > --- a/xen/arch/x86/traps.c > +++ b/xen/arch/x86/traps.c > @@ -119,6 +119,26 @@ boolean_param("ler", opt_ler); > #define stack_words_per_line 4 > #define ESP_BEFORE_EXCEPTION(regs) ((unsigned long *)regs->rsp) > > +void (* const

Re: [Xen-devel] [bug]xen 4.10 + dom0 4.15 couldn't boot up

2018-01-29 Thread Juergen Gross
On 29/01/18 06:28, Zhang, Xiong Y wrote: > Today I found xen 4.10 (or staging branch) with dom0 4.15 kernel, dom0 > couldn’t boot up and it print the following error, is it a known issue ? Please post more information. Please add the following to the hypervisor boot parameters: loglvl=all

Re: [Xen-devel] [PATCH v10 09/11] x86/ctxt: Issue a speculation barrier between vcpu contexts

2018-01-29 Thread Jan Beulich
>>> On 27.01.18 at 02:27, wrote: >> On 25/01/18 16:09, Andrew Cooper wrote: >> > On 25/01/18 15:57, Jan Beulich wrote: >> > > > > > >> > > For the record, the overwhelming majority of calls to >> > > __sync_local_execstate() being responsible for the behavior >> > > come

Re: [Xen-devel] [PATCHv3] xen: Add EFI_LOAD_OPTION support

2018-01-29 Thread Jan Beulich
>>> On 26.01.18 at 18:35, wrote: > On Fri, Jan 26, 2018 at 5:46 AM, Jan Beulich wrote: > On 23.01.18 at 01:21, wrote: >>> @@ -375,12 +385,39 @@ static void __init PrintErrMesg(const CHAR16 *mesg, >>> EFI_STATUS ErrCode) >>> >>>

[Xen-devel] [xen-unstable-smoke test] 118433: regressions - FAIL

2018-01-29 Thread osstest service owner
flight 118433 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/118433/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 118363 Tests which