Re: [Xen-devel] Crash with your meltdown patches

>>> On 01.03.18 at 19:23, wrote: > --- a/xen/arch/x86/smpboot.c > +++ b/xen/arch/x86/smpboot.c > @@ -747,10 +747,9 @@ static int clone_mapping(const void *ptr,root_pgentry_t > *rpt) > if ( l1e_get_flags(*pl1e) & _PAGE_PRESENT ) > { > ASSERT(l1e_get_pfn(*pl1e)

Re: [Xen-devel] [PATCH v2 4/7] x86: NOP out most XPTI entry/exit code when it's not in use

>>> On 01.03.18 at 20:42, wrote: > On 07/02/18 16:13, Jan Beulich wrote: >> --- a/xen/arch/x86/x86_64/compat/entry.S >> +++ b/xen/arch/x86/x86_64/compat/entry.S >> @@ -199,7 +199,7 @@ ENTRY(compat_post_handle_exception) >> >> /* See lstar_enter for entry register

Re: [Xen-devel] [PATCH v2 3/7] x86: introduce altinstruction_nop assembler macro

>>> On 01.03.18 at 20:25, wrote: > On 07/02/18 16:13, Jan Beulich wrote: >> This allows shortening (and making more obvious what they do) some >> altinstruction_entry uses. >> >> Signed-off-by: Jan Beulich > > In principle, Reviewed-by: Andrew

Re: [Xen-devel] [PATCH v2 7/7] x86/build: Use new .nop directive when available

>>> On 01.03.18 at 17:58, wrote: > On 01/03/18 10:54, Jan Beulich wrote: > On 01.03.18 at 11:36, wrote: >>> On Thu, Mar 01, 2018 at 12:28:27AM -0700, Jan Beulich wrote: >>> Andrew Cooper 02/28/18 7:20 PM >>>

[Xen-devel] [xen-4.7-testing test] 120094: regressions - FAIL

flight 120094 xen-4.7-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/120094/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-xtf-amd64-amd64-2 50 xtf/test-hvm64-lbr-tsx-vmentry fail REGR. vs. 119780

Re: [Xen-devel] [PATCH 2/2] sndif: add explicit back and front synchronization

On 03/02/2018 12:11 AM, Konrad Rzeszutek Wilk wrote: * +++++ * | gref_directory | 24 * +++++ - * |

[Xen-devel] [linux-linus test] 120092: regressions - FAIL

flight 120092 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/120092/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt 7 xen-boot fail REGR. vs. 118324

[Xen-devel] [xen-unstable-smoke test] 120134: tolerable all pass - PUSHED

flight 120134 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/120134/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[Xen-devel] [PATCH] xen/arm: Read the cacheline size from CTR register

See the corresponding Linux commit as reference: commit f91e2c3bd427239c198351f44814dd39db91afe0 Author: Catalin Marinas Date: Tue Dec 7 16:52:04 2010 +0100 ARM: 6527/1: Use CTR instead of CCSIDR for the D-cache line size on ARMv7 The current

[Xen-devel] [PATCH v3 5/6] xen/arm: update the docs about heterogeneous computing

Introduce a new document about big.LITTLE and update the documentation of hmp-unsafe. Also update the warning messages to point users to the docs. Signed-off-by: Stefano Stabellini CC: jbeul...@suse.com CC: konrad.w...@oracle.com CC: t...@xen.org CC: wei.l...@citrix.com

[Xen-devel] [PATCH v3 4/6] xen/arm: set VPIDR based on the MIDR value of the underlying pCPU

On big.LITTLE systems not all cores have the same MIDR. Instead of storing only one VPIDR per domain, initialize it to the value of the MIDR of the pCPU where the vCPU will run. This way, assuming that the vCPU has been created with the right pCPU affinity, the guest will be able to read the

[Xen-devel] [PATCH v3 1/6] xen/arm: Park CPUs with a MIDR different from the boot CPU.

From: Julien Grall From: Julien Grall Xen does not properly support big.LITTLE platform. All vCPUs of a guest will always have the MIDR of the boot CPU (see arch_domain_create). At best the guest may see unreliable performance (vCPU switching between

[Xen-devel] [PATCH v3 3/6] xen/arm: read ACTLR on the pcpu where the vcpu will run

On big.LITTLE systems not all cores have the same ACTLR. Instead of reading ACTLR and setting v->arch.actlr in vcpu_initialise, do it later on the same pcpu where the vcpu will run. This way, assuming that the vcpu has been created with the right pcpu affinity, the guest will be able to read the

[Xen-devel] [PATCH v3 2/6] xen/arm: make processor a per cpu variable

There can be processors of different kinds on a single system. Make processor a per_cpu variable pointing to the right processor type for each core. Suggested-by: Julien Grall Signed-off-by: Stefano Stabellini Reviewed-by: Julien Grall

[Xen-devel] [PATCH v3 6/6] xen/arm: disable CPUs with different cacheline sizes

Even different cpus in big.LITTLE systems are expected to have the same cacheline size. Unless the minimum of all cacheline sizes is used across all cpu cores, cache coherency protocols can go wrong. Instead, for now, just disable any cpu with a different cacheline size. This check is not covered

[Xen-devel] [PATCH v3 0/6] unsafe big.LITTLE support

Hi all, This series changes the initialization of two virtual registers to make sure they match the value of the underlying physical cpu. It also disables cpus different from the boot cpu, unless a newly introduced command line option is specified. In that case, it explains how to setup the

[Xen-devel] [linux-4.9 test] 120091: regressions - FAIL

flight 120091 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/120091/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 5 host-ping-check-native fail REGR. vs. 120047 Tests which did not

Re: [Xen-devel] [PATCH 1/2] sndif: introduce protocol version

On Mon, Feb 05, 2018 at 10:24:59AM +0200, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > Protocol version was referenced in the protocol description, > but missed its definition. Fix this by adding a constant > for current protocol version. >

Re: [Xen-devel] [PATCH 2/2] sndif: add explicit back and front synchronization

> * +++++ > * | gref_directory | 24 > * +++++ > - * | reserved

Re: [Xen-devel] [PATCH] Please Welcome Julien, our new Committer

On 01/03/2018 20:03, Konrad Rzeszutek Wilk wrote: > On Thu, Mar 01, 2018 at 11:17:13AM -0800, Stefano Stabellini wrote: >> In recognition of his expertise and commitment to Xen Project, please >> join me in welcoming Julien among the Committers and REST Maintainers. >> >> Signed-off-by: Stefano

[Xen-devel] [xen-unstable-smoke test] 120130: tolerable all pass - PUSHED

flight 120130 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/120130/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] [PATCH] Please Welcome Julien, our new Committer

On Thu, Mar 01, 2018 at 11:17:13AM -0800, Stefano Stabellini wrote: > In recognition of his expertise and commitment to Xen Project, please > join me in welcoming Julien among the Committers and REST Maintainers. > > Signed-off-by: Stefano Stabellini Acked-by: Konrad

[Xen-devel] [linux-3.18 test] 120090: regressions - FAIL

flight 120090 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/120090/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt-raw 11 guest-start fail REGR. vs. 120043 Tests which did not

[Xen-devel] [PULL 29/30] Fix up dangling references to qmp-commands.* in comment and doc

From: Markus Armbruster Fix up the reference to qmp-commands.hx in qmp.c. Missed in commit 5032a16d1d. Fix up the reference to qmp-commands.txt in docs/xen-save-devices-state.txt. Missed in commit 4d8bb958fa. Signed-off-by: Markus Armbruster Message-Id:

Re: [Xen-devel] [PATCH v2 4/7] x86: NOP out most XPTI entry/exit code when it's not in use

On 07/02/18 16:13, Jan Beulich wrote: > --- a/xen/arch/x86/x86_64/compat/entry.S > +++ b/xen/arch/x86/x86_64/compat/entry.S > @@ -199,7 +199,7 @@ ENTRY(compat_post_handle_exception) > > /* See lstar_enter for entry register state. */ > ENTRY(cstar_enter) > -/* sti could live here when

Re: [Xen-devel] [PATCH v2 3/7] x86: introduce altinstruction_nop assembler macro

On 07/02/18 16:13, Jan Beulich wrote: > This allows shortening (and making more obvious what they do) some > altinstruction_entry uses. > > Signed-off-by: Jan Beulich In principle, Reviewed-by: Andrew Cooper , but I'd prefer if you held it back until

Re: [Xen-devel] [PATCH v2 2/7] x86: remove CR reads from exit-to-guest path

On 07/02/18 16:12, Jan Beulich wrote: > CR3 is - during normal operation - only ever loaded from v->arch.cr3, > so there's no need to read the actual control register. For CR4 we can > generally use the cached value on all synchronous entry end exit paths. > Drop the write_cr3 macro, as the two

Re: [Xen-devel] [PATCH v2 1/7] x86: slightly reduce Meltdown band-aid overhead

On 08/02/18 09:20, Jan Beulich wrote: On 07.02.18 at 20:35, wrote: >> On 07/02/18 16:12, Jan Beulich wrote: >>> I'm not sure why I didn't do this right away: By avoiding the use of >>> global PTEs in the cloned directmap, there's no need to fiddle with >>> CR4.PGE

[Xen-devel] [PATCH] Please Welcome Julien, our new Committer

In recognition of his expertise and commitment to Xen Project, please join me in welcoming Julien among the Committers and REST Maintainers. Signed-off-by: Stefano Stabellini diff --git a/MAINTAINERS b/MAINTAINERS index e4070ff..a5b3e95 100644 --- a/MAINTAINERS +++

[Xen-devel] [linux-next test] 120088: regressions - FAIL

flight 120088 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/120088/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 7 xen-boot fail REGR. vs. 120055 test-arm64-arm64-xl

Re: [Xen-devel] Crash with your meltdown patches

On 01/03/18 19:26, Andrew Cooper wrote: > On 01/03/18 18:23, Juergen Gross wrote: >> On 01/03/18 18:48, Andrew Cooper wrote: >>> On 01/03/18 17:05, Juergen Gross wrote: Jan, I just rebased my patch series for speeding up XPTI to current staging. This included your pending

[Xen-devel] [PATCH v2] x86/link: Don't merge .init.text and .init.data

c/s 1308f0170c merged .init.text and .init.data, because EFI might properly write-protect r/o sections. However, that change makes xen-syms unusable for disassembly analysis. In particular, searching for indirect branches as part of the SP2/Spectre mitigation series. As the merging isn't

Re: [Xen-devel] Crash with your meltdown patches

On 01/03/18 18:23, Juergen Gross wrote: > On 01/03/18 18:48, Andrew Cooper wrote: >> On 01/03/18 17:05, Juergen Gross wrote: >>> Jan, >>> >>> I just rebased my patch series for speeding up XPTI to current >>> staging. This included your pending speedup series. I'm now seeing >>> a crash with the

Re: [Xen-devel] Crash with your meltdown patches

On 01/03/18 18:48, Andrew Cooper wrote: > On 01/03/18 17:05, Juergen Gross wrote: >> Jan, >> >> I just rebased my patch series for speeding up XPTI to current >> staging. This included your pending speedup series. I'm now seeing >> a crash with the first patch of yours: >> >> (XEN) Intel VT-d

Re: [Xen-devel] [PATCH] public: correct GNTTABOP_set_version comment

On 28/02/18 08:38, Jan Beulich wrote: > Version changes are allowed any number of times. Simply re-use the > comment XTF has (thanks Andrew). > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper ___

[Xen-devel] [xen-unstable-smoke test] 120126: regressions - FAIL

flight 120126 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/120126/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 7 xen-boot fail REGR. vs. 120107 Tests which

Re: [Xen-devel] [RFC PATCH v4 4/7] xen/pvh: Move Xen specific PVH VM initialization out of common code

On 3/1/2018 8:05 AM, Boris Ostrovsky wrote: On 02/28/2018 01:28 PM, Maran Wilson wrote: We need to refactor PVH entry code so that support for other hypervisors like Qemu/KVM can be added more easily. This patch moves the small block of code used for initializing Xen PVH virtual machines into

Re: [Xen-devel] Crash with your meltdown patches

On 01/03/18 17:05, Juergen Gross wrote: > Jan, > > I just rebased my patch series for speeding up XPTI to current > staging. This included your pending speedup series. I'm now seeing > a crash with the first patch of yours: > > (XEN) Intel VT-d Queued Invalidation enabled. > (XEN) Intel VT-d

Re: [Xen-devel] [RFC PATCH v4 1/7] xen/pvh: Split CONFIG_XEN_PVH into CONFIG_PVH and CONFIG_XEN_PVH

On 3/1/2018 7:17 AM, Paolo Bonzini wrote: On 01/03/2018 16:02, Boris Ostrovsky wrote: On 02/28/2018 01:27 PM, Maran Wilson wrote: diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index eb7f43f23521..fa7cd0305125 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -791,6 +791,14 @@ config

Re: [Xen-devel] [RFC PATCH v4 2/7] xen/pvh: Move PVH entry code out of Xen specific tree

On 2/28/2018 1:35 PM, Paolo Bonzini wrote: On 28/02/2018 22:08, Konrad Rzeszutek Wilk wrote: +obj-$(CONFIG_XEN_PVH) += pvh.o +obj-$(CONFIG_XEN_PVH) += pvh-head.o + Probably a better place for these would be arch/x86/platform/pvh/{enlighten.c,head.S}. (Just because there are no .c or .S files

Re: [Xen-devel] [RFC PATCH v4 6/7] xen/pvh: Add memory map pointer to hvm_start_info struct

On 2/28/2018 11:41 PM, Jan Beulich wrote: Juergen Gross 03/01/18 8:29 AM >>> On 28/02/18 19:28, Maran Wilson wrote: The start info structure that is defined as part of the x86/HVM direct boot ABI and used for starting Xen PVH guests would be more versatile if it also included

Re: [Xen-devel] [PATCH] xl: remove apic option for PVH guests

On Thu, Mar 01, 2018 at 04:01:23PM +, Wei Liu wrote: > On Thu, Mar 01, 2018 at 03:57:18PM +, Andrew Cooper wrote: > > On 01/03/18 12:22, Wei Liu wrote: > > > On Wed, Feb 28, 2018 at 10:20:53AM +, Roger Pau Monne wrote: > > >> XSA-256 forces the local APIC to always be enabled for PVH

Re: [Xen-devel] [PATCH v2 7/7] x86/build: Use new .nop directive when available

On 01/03/18 10:54, Jan Beulich wrote: On 01.03.18 at 11:36, wrote: >> On Thu, Mar 01, 2018 at 12:28:27AM -0700, Jan Beulich wrote: >> Andrew Cooper 02/28/18 7:20 PM >>> On 28/02/18 16:22, Jan Beulich wrote: On 26.02.18 at

[Xen-devel] Crash with your meltdown patches

Jan, I just rebased my patch series for speeding up XPTI to current staging. This included your pending speedup series. I'm now seeing a crash with the first patch of yours: (XEN) Intel VT-d Queued Invalidation enabled. (XEN) Intel VT-d Interrupt Remapping enabled. (XEN) Intel VT-d Posted

Re: [Xen-devel] [PATCH 1/2] x86: improve MSR_SHADOW_GS accesses

>>> On 01.03.18 at 16:47, wrote: > On 07/12/17 10:45, Jan Beulich wrote: > On 06.12.17 at 20:34, wrote: >>> On 06/12/17 16:37, Jan Beulich wrote: @@ -196,6 +215,19 @@ static inline void wrgsbase(unsigned lon

Re: [Xen-devel] [PATCH v2] tools: drop stale references to curl/xml2-config

Am Thu, 1 Mar 2018 15:32:05 + schrieb Wei Liu : > If you don't object I can replace the commit message. Yes, please. Olaf pgp_rL2Id687A.pgp Description: Digitale Signatur von OpenPGP ___ Xen-devel mailing list

[Xen-devel] [PATCH] vvmx: fixes after CR4 trapping optimizations

Commit 406817 doesn't update nested VMX code in order to take into account L1 CR4 host mask when nested guest (L2) writes to CR4, and thus the mask written to CR4_GUEST_HOST_MASK is likely not as restrictive as it should be. Also the VVMCS GUEST_CR4 value should be updated to match the underlying

Re: [Xen-devel] [RFC PATCH v4 2/7] xen/pvh: Move PVH entry code out of Xen specific tree

On 03/01/2018 03:46 AM, Paolo Bonzini wrote: > On 01/03/2018 07:11, Juergen Gross wrote: >>> Probably a better place for these would be >>> arch/x86/platform/pvh/{enlighten.c,head.S}. (Just because there are no >>> .c or .S files in arch/x86). >> Right. >> >>> Maybe Xen ought to be moved under

Re: [Xen-devel] get_page_from_gfn() for foreign pages

> -Original Message- [snip] > >> And then you didn't really answer my question. > > > > Well, you can't revoke a grant whist a backend has it mapped... that's been > > a limitation forever. Also, I think it's reasonable that granting to a > > domain > > A allows domain A *and* any other

Re: [Xen-devel] [RFC PATCH v4 4/7] xen/pvh: Move Xen specific PVH VM initialization out of common code

On 02/28/2018 01:28 PM, Maran Wilson wrote: > We need to refactor PVH entry code so that support for other hypervisors > like Qemu/KVM can be added more easily. > > This patch moves the small block of code used for initializing Xen PVH > virtual machines into the Xen specific file. This

Re: [Xen-devel] [PATCH] xl: remove apic option for PVH guests

On Thu, Mar 01, 2018 at 03:57:18PM +, Andrew Cooper wrote: > On 01/03/18 12:22, Wei Liu wrote: > > On Wed, Feb 28, 2018 at 10:20:53AM +, Roger Pau Monne wrote: > >> XSA-256 forces the local APIC to always be enabled for PVH guests, so > >> ignore any apic option for PVH guests. Update the

Re: [Xen-devel] [PATCH] xl: remove apic option for PVH guests

On 01/03/18 12:22, Wei Liu wrote: > On Wed, Feb 28, 2018 at 10:20:53AM +, Roger Pau Monne wrote: >> XSA-256 forces the local APIC to always be enabled for PVH guests, so >> ignore any apic option for PVH guests. Update the documentation >> accordingly. > I think how I will approach this is to

Re: [Xen-devel] get_page_from_gfn() for foreign pages

>>> On 01.03.18 at 15:49, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 01 March 2018 14:32 >> >>> On 01.03.18 at 15:17, wrote: >> > Yes, it's the PV case I'm hitting, i.e: >> > >> > page =

Re: [Xen-devel] [PATCH 1/2] x86: improve MSR_SHADOW_GS accesses

On 07/12/17 10:45, Jan Beulich wrote: On 06.12.17 at 20:34, wrote: >> On 06/12/17 16:37, Jan Beulich wrote: >>> @@ -172,6 +173,24 @@ static inline unsigned long rdgsbase(voi >>> return base; >>> } >>> >>> +static inline unsigned long rdgsshadow(void) >>> +{

[Xen-devel] [linux-linus bisection] complete test-amd64-i386-qemuu-rhel6hvm-intel

branch xen-unstable xenbranch xen-unstable job test-amd64-i386-qemuu-rhel6hvm-intel testid xen-boot Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu

Re: [Xen-devel] [PATCH 5/7] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

>>> On 01.03.18 at 15:33, wrote: > What Sameer has been doing for SMMUv3 is following the word we did on > the ARM SMMUv2 driver. The header is a suggestion for consolidating the > macros over the files here. In which case - why isn't the patch introducing this compat

Re: [Xen-devel] [PATCH v2] tools: drop stale references to curl/xml2-config

On Thu, Mar 01, 2018 at 03:26:32PM +0100, Olaf Hering wrote: > Fixes commit 185bb58be3 ("tools: drop libxen") > It would be nice to write something more specific like: Curl and xml2 are not required anymore since commit XXX (xxx) removed their only user. ? If you don't object I can

Re: [Xen-devel] [BUG] unable to shutdown (page fault in mwait_idle()/do_dbs_timer()/__find_next_bit()) (fwd)

>>> On 09.01.18 at 23:51, wrote: > Hello. I'm sorry for taking so long to get back to this. > On Tue, 9 Jan 2018, Jan Beulich wrote: > On 08.01.18 at 17:07, wrote: >>> On Mon, 8 Jan 2018, Jan Beulich wrote: >>> On 07.01.18 at 13:34,

Re: [Xen-devel] [RFC PATCH v4 6/7] xen/pvh: Add memory map pointer to hvm_start_info struct

On Wed, Feb 28, 2018 at 10:28:02AM -0800, Maran Wilson wrote: > The start info structure that is defined as part of the x86/HVM direct boot > ABI and used for starting Xen PVH guests would be more versatile if it also > included a way to pass information about the memory map to the guest. This >

Re: [Xen-devel] [RFC PATCH v4 1/7] xen/pvh: Split CONFIG_XEN_PVH into CONFIG_PVH and CONFIG_XEN_PVH

On 01/03/2018 16:02, Boris Ostrovsky wrote: > On 02/28/2018 01:27 PM, Maran Wilson wrote: >> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig >> index eb7f43f23521..fa7cd0305125 100644 >> --- a/arch/x86/Kconfig >> +++ b/arch/x86/Kconfig >> @@ -791,6 +791,14 @@ config KVM_GUEST >>underlying

Re: [Xen-devel] [RFC PATCH v4 1/7] xen/pvh: Split CONFIG_XEN_PVH into CONFIG_PVH and CONFIG_XEN_PVH

On 02/28/2018 01:27 PM, Maran Wilson wrote: > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index eb7f43f23521..fa7cd0305125 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -791,6 +791,14 @@ config KVM_GUEST > underlying device model, the host provides the guest with >

Re: [Xen-devel] get_page_from_gfn() for foreign pages

> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 01 March 2018 14:32 > To: Paul Durrant > Cc: xen-devel (xen-devel@lists.xenproject.org) de...@lists.xenproject.org> > Subject: RE: [Xen-devel] get_page_from_gfn() for foreign pages > >

Re: [Xen-devel] [PATCH 0/7] SMMUv3 driver

Hi, On 09/02/18 03:10, Sameer Goel wrote: This patch set adds support for the SMMUv3 driver. This is a continuation on a RFCv4.[1] The IORT support came from [2]. This RFC has some conflicting defines that have to be addressed by introducing the linux_compat.h header in IORT patch set. In any

Re: [Xen-devel] [PATCH 5/7] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

Hi Jan, On 01/03/18 14:21, Jan Beulich wrote: On 01.03.18 at 15:07, wrote: On 09/02/18 03:10, Sameer Goel wrote: This driver follows an approach similar to smmu driver. The intent here is to reuse as much Linux code as possible. - Glue code has been introduced to bridge

Re: [Xen-devel] get_page_from_gfn() for foreign pages

>>> On 01.03.18 at 15:17, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 01 March 2018 14:00 >> To: Paul Durrant >> Cc: xen-devel (xen-devel@lists.xenproject.org) > de...@lists.xenproject.org> >>

[Xen-devel] [PATCH v2] tools: drop stale references to curl/xml2-config

Fixes commit 185bb58be3 ("tools: drop libxen") Signed-off-by: Olaf Hering --- config/Tools.mk.in | 2 -- tools/configure.ac | 2 -- 2 files changed, 4 deletions(-) diff --git a/config/Tools.mk.in b/config/Tools.mk.in index 0f79f4e0c2..2d6c440324 100644 --- a/config/Tools.mk.in

Re: [Xen-devel] [PATCH] tools: drop stale references to xml2-config

Am Thu, 1 Mar 2018 15:22:21 +0100 schrieb Olaf Hering : > Fixes commit 185bb58be3 ("tools: drop libxen") > CURL_CONFIG := @CURL@ > AC_ARG_VAR([CURL], [Path to curl-config tool]) These are stale as well. Somehow I overlooked that, will send v2. Olaf

Re: [Xen-devel] [PATCH 6/7] drivers/passthrough/arm: Refactor code for arm smmu drivers

Hi, On 09/02/18 03:10, Sameer Goel wrote: Pull common defines for SMMU drives in a local header. s/drivers/ Signed-off-by: Sameer Goel --- xen/drivers/passthrough/arm/arm_smmu.h | 125 + xen/drivers/passthrough/arm/smmu-v3.c |

[Xen-devel] [PATCH] tools: drop stale references to xml2-config

Fixes commit 185bb58be3 ("tools: drop libxen") Signed-off-by: Olaf Hering --- config/Tools.mk.in | 1 - tools/configure.ac | 1 - 2 files changed, 2 deletions(-) diff --git a/config/Tools.mk.in b/config/Tools.mk.in index 0f79f4e0c2..7831159257 100644 --- a/config/Tools.mk.in

Re: [Xen-devel] [PATCH 5/7] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

>>> On 01.03.18 at 15:07, wrote: > On 09/02/18 03:10, Sameer Goel wrote: >> This driver follows an approach similar to smmu driver. The intent here >> is to reuse as much Linux code as possible. >> - Glue code has been introduced to bridge the API calls. >> - Called Linux

Re: [Xen-devel] get_page_from_gfn() for foreign pages

> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 01 March 2018 14:00 > To: Paul Durrant > Cc: xen-devel (xen-devel@lists.xenproject.org) de...@lists.xenproject.org> > Subject: Re: [Xen-devel] get_page_from_gfn() for foreign pages > >

Re: [Xen-devel] [PATCH 5/7] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

Hi, On 09/02/18 03:10, Sameer Goel wrote: This driver follows an approach similar to smmu driver. The intent here is to reuse as much Linux code as possible. - Glue code has been introduced to bridge the API calls. - Called Linux functions from the Xen IOMMU function calls. - Xen modifications

Re: [Xen-devel] get_page_from_gfn() for foreign pages

>>> On 01.03.18 at 12:39, wrote: > Whilst debugging my PV-IOMMU code I ran into an issue with > get_page_from_gfn(): It is failing when the gfn in question is actually a > grant map from another domain, and the reason for this is that get_page(page, > domain)

Re: [Xen-devel] [PATCH 5/6] xen/domain: Call sched_destroy_domain() in the domain_create() error path

On Wed, 2018-02-28 at 14:14 +, Andrew Cooper wrote: > If domain_create() fails, complete_domain_destroy() doesn't get > called, > meaning that sched_destroy_domain() is missed. In practice, this can > only > fail because of exceptional late_hwdom_init() issues at the moment. > > Make

Re: [Xen-devel] [PATCH 5/6] xen/domain: Call sched_destroy_domain() in the domain_create() error path

On Wed, 2018-02-28 at 14:14 +, Andrew Cooper wrote: > If domain_create() fails, complete_domain_destroy() doesn't get > called, > meaning that sched_destroy_domain() is missed. In practice, this can > only > fail because of exceptional late_hwdom_init() issues at the moment. > > Make

[Xen-devel] Xen Security Advisory 256 (CVE-2018-7542) - x86 PVH guest without LAPIC may DoS the host

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2018-7542 / XSA-256 version 3 x86 PVH guest without LAPIC may DoS the host UPDATES IN VERSION 3 CVE assigned. ISSUE DESCRIPTION

[Xen-devel] Xen Security Advisory 255 (CVE-2018-7541) - grant table v2 -> v1 transition may crash Xen

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2018-7541 / XSA-255 version 4 grant table v2 -> v1 transition may crash Xen UPDATES IN VERSION 4 CVE assigned. ISSUE DESCRIPTION

[Xen-devel] Xen Security Advisory 252 (CVE-2018-7540) - DoS via non-preemptable L3/L4 pagetable freeing

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2018-7540 / XSA-252 version 3 DoS via non-preemptable L3/L4 pagetable freeing UPDATES IN VERSION 3 CVE assigned. ISSUE DESCRIPTION

Re: [Xen-devel] [PATCH] libxc: really tolerate empty PV records

On Tue, Feb 27, 2018 at 07:51:22AM -0700, Jan Beulich wrote: > Commit 119ee4d773 ("tools/libxc: Tolerate specific zero-content records > in migration v2 streams") meant tolerate those, but failed to set rc > accordingly. > > Signed-off-by: Jan Beulich Reviewed-by: Wei Liu

Re: [Xen-devel] [PATCH RFC 3/3] xtf: add minimal HPET functionality test

>>> On 01.03.18 at 12:46, wrote: > On 23/02/18 13:27, Roger Pau Monne wrote: >> Add a basic HPET functionality test, note that this test requires the >> HPET to support level triggered interrupts. >> >> Further improvements should add support for interrupt delivery, and

Re: [Xen-devel] [PATCH V2] libxl: set channel devid when not provided by application

On Mon, Feb 26, 2018 at 11:28:39AM -0700, Jim Fehlig wrote: > Applications like libvirt may not populate a device devid field, > delegating that to libxl. If needed, the application can later > retrieve the libxl-produced devid. Indeed most devices are handled > this way in libvirt, channel

Re: [Xen-devel] [PATCH 2/6] x86/hvm: Handle viridian MSRs via the new guest_{rd, wr}msr() infrastructure

>>> On 01.03.18 at 13:29, wrote: > On 01/03/18 09:58, Jan Beulich wrote: >> > @@ -173,11 +175,26 @@ int guest_rdmsr(const struct vcpu *v, uint32_t msr, > > uint64_t *val) > _MSR_MISC_FEATURES_CPUID_FAULTING; > break; >

Re: [Xen-devel] [PATCH v2 3/7] x86/alt: Clean up the assembly used to generate alternatives

On Mon, Feb 26, 2018 at 11:35:00AM +, Andrew Cooper wrote: > * On the C side, switch to using local lables rather than hardcoded numbers. > * Rename parameters and lables to be consistent with alt_instr names, and >consistent between the the C and asm versions. > * On the asm side,

Re: [Xen-devel] [PATCH] tools/misc: Tweak reserved bit handling for xen-cpuid

On Tue, Feb 27, 2018 at 04:28:30PM +, Andrew Cooper wrote: > Instead of printing REZ, use NULL pointers to indicate missing information, > and have dump_leaf() print out the bit which is unknown. > > E.g. > > > Dynamic sets: > Raw >

Re: [Xen-devel] [PATCH 2/6] x86/hvm: Handle viridian MSRs via the new guest_{rd, wr}msr() infrastructure

On 01/03/18 09:58, Jan Beulich wrote: > @@ -173,11 +175,26 @@ int guest_rdmsr(const struct vcpu *v, uint32_t msr, uint64_t *val) _MSR_MISC_FEATURES_CPUID_FAULTING; break; +case 0x4000 ... 0x41ff: >>> As was already suggested,

[Xen-devel] [seabios test] 120079: regressions - FAIL

flight 120079 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/120079/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail REGR. vs. 115539 Tests which did not

Re: [Xen-devel] [PATCH] xl: remove apic option for PVH guests

On Wed, Feb 28, 2018 at 10:20:53AM +, Roger Pau Monne wrote: > XSA-256 forces the local APIC to always be enabled for PVH guests, so > ignore any apic option for PVH guests. Update the documentation > accordingly. I think how I will approach this is to dictate that PVH always has LAPIC in our

Re: [Xen-devel] [PATCH v2 1/2] firmware/shim: better filtering of dependency files during Xen tree setup

On Wed, Feb 28, 2018 at 04:34:58AM -0700, Jan Beulich wrote: > I have no idea what *.d1 is supposed to refer to - we only have .*.d > and .*.d2 files (note also the leading dot). Also switch to passing > -name instead of -path to find - that's a requirement for .*.d et al to > work, but would

Re: [Xen-devel] [PATCH RFC 3/3] xtf: add minimal HPET functionality test

On 23/02/18 13:27, Roger Pau Monne wrote: > Add a basic HPET functionality test, note that this test requires the > HPET to support level triggered interrupts. > > Further improvements should add support for interrupt delivery, and > testing all the available timers. > > Signed-off-by: Roger Pau

[Xen-devel] get_page_from_gfn() for foreign pages

Whilst debugging my PV-IOMMU code I ran into an issue with get_page_from_gfn(): It is failing when the gfn in question is actually a grant map from another domain, and the reason for this is that get_page(page, domain) explicitly fails if the page owner is not the domain specified to the call.

[Xen-devel] [libvirt test] 120084: tolerable all pass - PUSHED

flight 120084 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/120084/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 14 saverestore-support-checkfail like 120053 test-armhf-armhf-libvirt-xsm 14

Re: [Xen-devel] [PATCH v4 06/16] xen/x86: Remove unused override of page_to_mfn/mfn_to_page

On 02/21/2018 02:02 PM, Julien Grall wrote: > A few files override page_to_mfn/mfn_to_page but actually never use > those macros. So drop them. > > Signed-off-by: Julien Grall Acked-by: George Dunlap

Re: [Xen-devel] [PATCH 2/6] x86/hvm: Handle viridian MSRs via the new guest_{rd, wr}msr() infrastructure

> -Original Message- > From: Andrew Cooper > Sent: 28 February 2018 18:22 > To: Paul Durrant ; Xen-devel de...@lists.xen.org> > Cc: Jan Beulich ; Jun Nakajima > ; Kevin Tian ; Boris > Ostrovsky

Re: [Xen-devel] [PATCH 4/6] xen/sched: Remove {init, destroy}_domain() interfaces

On Wed, 2018-02-28 at 16:33 +, Andrew Cooper wrote: > On 28/02/18 16:22, George Dunlap wrote: > > > > I kind of feel like there was a reason for the init / alloc > > difference; > > but as you say, at the moment all the schedulers are basically > > identical. In the unlikely event that we

Re: [Xen-devel] [PATCH 6/6] x86/msr: Blacklist various MSRs which guests definitely shouldn't be using

>>> On 26.02.18 at 18:35, wrote: > @@ -183,6 +187,15 @@ int guest_rdmsr(const struct vcpu *v, uint32_t msr, > uint64_t *val) > ret = guest_rdmsr_x2apic(v, msr, val); > goto out; > > +case 0xc80: > +/* Silicon Debug Inferface not

Re: [Xen-devel] [PATCH V6] x86/hvm: fix domain crash when CR3 has the noflush bit set

On 03/01/2018 10:58 AM, Jan Beulich wrote: On 28.02.18 at 11:38, wrote: >> In hardware, when PCID support is enabled and the NOFLUSH bit is set >> when writing a CR3 value, the hardware will clear that that bit and >> change the CR3 without flushing the TLB.

Re: [Xen-devel] [PATCH 4/6] xen/sched: Remove {init, destroy}_domain() interfaces

On Wed, 2018-02-28 at 14:14 +, Andrew Cooper wrote: > These hooks have one single caller (sched_{init,destroy}_domain() > respectively) and are all identical (when implemented). > > Previous changes have ensured that only real domains reach these > functions, so > ASSERT() that system domains

Re: [Xen-devel] [PATCH V6] x86/hvm: fix domain crash when CR3 has the noflush bit set

>>> On 28.02.18 at 11:38, wrote: > In hardware, when PCID support is enabled and the NOFLUSH bit is set > when writing a CR3 value, the hardware will clear that that bit and > change the CR3 without flushing the TLB. hvm_set_cr3(), however, was > ignoring this bit; the

Re: [Xen-devel] [PATCH v2 7/7] x86/build: Use new .nop directive when available

>>> On 01.03.18 at 11:36, wrote: > On Thu, Mar 01, 2018 at 12:28:27AM -0700, Jan Beulich wrote: >> >>> Andrew Cooper 02/28/18 7:20 PM >>> >> >On 28/02/18 16:22, Jan Beulich wrote: >> > On 26.02.18 at 12:35, wrote:

Re: [Xen-devel] [PATCH v3] x86/mm: Suppresses vm_events caused by page-walks

On 03/01/2018 12:09 PM, Jan Beulich wrote: On 01.03.18 at 11:00, wrote: >> On 02/28/2018 03:56 PM, Jan Beulich wrote: >> On 28.02.18 at 14:41, wrote: >>> On 28.02.18 at 14:25, wrote: > ---

  1   2   >