[Xen-devel] [linux-next test] 120297: regressions - trouble: broken/fail/pass

2018-03-08 Thread osstest service owner
flight 120297 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/120297/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-intel broken test-amd64-i386-freebsd10-amd64

Re: [Xen-devel] [PATCH v2 4/6] xen/x86: disable global pages for domains with XPTI active

2018-03-08 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Thursday, March 8, 2018 9:39 PM > > > --- a/xen/include/asm-x86/domain.h > > +++ b/xen/include/asm-x86/domain.h > > @@ -622,7 +622,8 @@ unsigned long pv_guest_cr4_fixup(const struct > vcpu *, unsigned long guest_cr4); > > X86_CR4_

Re: [Xen-devel] [PATCH v2 4/6] xen/x86: disable global pages for domains with XPTI active

2018-03-08 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Thursday, March 8, 2018 9:39 PM > > > --- a/xen/include/asm-x86/domain.h > > +++ b/xen/include/asm-x86/domain.h > > @@ -622,7 +622,8 @@ unsigned long pv_guest_cr4_fixup(const struct > vcpu *, unsigned long guest_cr4); > > X86_CR4_

Re: [Xen-devel] [PATCH v2] x86: improve MSR_SHADOW_GS accesses

2018-03-08 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Thursday, March 8, 2018 7:16 PM > > Instead of using RDMSR/WRMSR, on fsgsbase-capable systems use a > double > SWAPGS combined with RDGSBASE/WRGSBASE. This halves execution time > for > a shadow GS update alone on my Haswell (and we have indic

Re: [Xen-devel] [PATCH v2] xen/acpi: upload _PSD info for non Dom0 CPUs too

2018-03-08 Thread Boris Ostrovsky
On 03/08/2018 05:57 AM, Joao Martins wrote: @@ -372,6 +376,15 @@ read_acpi_id(acpi_handle handle, u32 lvl, void *context, void **rv) pr_debug("ACPI CPU%u w/ PBLK:0x%lx\n", acpi_id, (unsigned long)pblk); + /* It has P-state dependencies */ + if (!acpi_processor_get_psd(handle,

[Xen-devel] [xen-unstable test] 120287: regressions - FAIL

2018-03-08 Thread osstest service owner
flight 120287 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/120287/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-migrupgrade 11 xen-boot/dst_hostfail REGR. vs. 120037 test-amd64-i386-li

Re: [Xen-devel] [Qemu-devel] [PATCH v6 00/11] xen: xen-domid-restrict improvements

2018-03-08 Thread no-reply
Hi, This series failed build test on ppcle host. Please find the details below. Message-id: 1520530757-4477-1-git-send-email-ian.jack...@eu.citrix.com Subject: [Qemu-devel] [PATCH v6 00/11] xen: xen-domid-restrict improvements Type: series === TEST SCRIPT BEGIN === #!/bin/bash # Testing script w

[Xen-devel] [xen-unstable-smoke test] 120354: tolerable all pass - PUSHED

2018-03-08 Thread osstest service owner
flight 120354 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/120354/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post

2018-03-08 Thread Eduardo Habkost
On Thu, Mar 08, 2018 at 05:39:09PM +, Ian Jackson wrote: [...] > diff --git a/vl.c b/vl.c > index dae986b..e6e8e1e 100644 > --- a/vl.c > +++ b/vl.c > @@ -4719,6 +4719,7 @@ int main(int argc, char **argv, char **envp) > vm_start(); > } > > +xen_setup_post(); I don't think we

Re: [Xen-devel] [Qemu-devel] [PATCH v6 00/11] xen: xen-domid-restrict improvements

2018-03-08 Thread no-reply
Hi, This series failed build test on ppcbe host. Please find the details below. Type: series Message-id: 1520530757-4477-1-git-send-email-ian.jack...@eu.citrix.com Subject: [Qemu-devel] [PATCH v6 00/11] xen: xen-domid-restrict improvements === TEST SCRIPT BEGIN === #!/bin/bash # Testing script w

[Xen-devel] [xtf test] 120303: all pass - PUSHED

2018-03-08 Thread osstest service owner
flight 120303 xtf real [real] http://logs.test-lab.xenproject.org/osstest/logs/120303/ Perfect :-) All tests in this flight passed as required version targeted for testing: xtf 067488fa25621c6a566e2f555fcb5a1088f7abb7 baseline version: xtf 979977ebe198ee9228a44e

Re: [Xen-devel] tools/libacpi printf output to logging instead of console/stdout ?

2018-03-08 Thread Andrew Cooper
On 08/03/18 19:23, Sander Eikelenboom wrote: > On 08/03/18 10:09, Jan Beulich wrote: > On 07.03.18 at 21:52, wrote: >>> When starting a guest with the 'xl create' command (non-verbose) i get >>> this extra output on PVH guest types only: >>> >>> S3 disabled >>> S4 disabled >>> CONV disabled >>

Re: [Xen-devel] tools/libacpi printf output to logging instead of console/stdout ?

2018-03-08 Thread Sander Eikelenboom
On 08/03/18 10:09, Jan Beulich wrote: On 07.03.18 at 21:52, wrote: >> When starting a guest with the 'xl create' command (non-verbose) i get >> this extra output on PVH guest types only: >> >> S3 disabled >> S4 disabled >> CONV disabled >> >> >> It seems libacpi/* only contains normal printf'

[Xen-devel] [PATCH 12/12] scripts/get_maintainer.pl: Print proper error message for missing $file

2018-03-08 Thread Ian Jackson
If you pass scripts/get_maintainer.pl the name of a FIFO or other exciting object (/dev/stdin, for example), it would falsely print "file not found". Instead: stat the object rather than using -f so that we do not mind if the object is not a file; and print the errno value in the error message. S

[Xen-devel] [PATCH 09/12] configure: do_compiler: Dump some extra info under bash

2018-03-08 Thread Ian Jackson
This makes it much easier to find a particular thing in config.log. The information may be lacking in other shells, resulting in harmless empty output. (This is why we don't use the proper ${FUNCNAME[*]} array syntax - other shells will choke on that.) The extra output is only printed if configu

[Xen-devel] [PATCH 10/12] xen: Use newly added dmops for mapping VGA memory

2018-03-08 Thread Ian Jackson
From: Ross Lagerwall Xen unstable (to be in 4.11) has two new dmops, relocate_memory and pin_memory_cacheattr. Use these to set up the VGA memory, replacing the previous calls to libxc. This allows the VGA console to work properly when QEMU is running restricted (-xen-domid-restrict). Wrapper fu

[Xen-devel] [PATCH 08/12] os-posix: Provide new -runas : facility

2018-03-08 Thread Ian Jackson
This allows the caller to specify a uid and gid to use, even if there is no corresponding password entry. This will be useful in certain Xen configurations. We don't support just -runas because: (i) deprivileging without calling setgroups would be ineffective (ii) given only a uid we don't know

Re: [Xen-devel] [PATCH v6.1 00/11] xen: xen-domid-restrict improvements

2018-03-08 Thread Ian Jackson
This just-amended series provides necessary support for running qemu as a Xen device model without power equivalent to root. In particular, it makes -xen-domid-restrict effective. Compared to v6, it fixes some minor checkpatch, style and portability issues. Sorry for the earlier troubled submiss

[Xen-devel] [PATCH 04/12] xen: defer call to xen_restrict until just before os_setup_post

2018-03-08 Thread Ian Jackson
We need to restrict *all* the control fds that qemu opens. Looking in /proc/PID/fd shows there are many; their allocation seems scattered throughout Xen support code in qemu. We must postpone the restrict call until roughly the same time as qemu changes its uid, chroots (if applicable), and so on

[Xen-devel] [PATCH 06/12] xen: move xc_interface compatibility fallback further up the file

2018-03-08 Thread Ian Jackson
We are going to want to use the dummy xendevicemodel_handle type in new stub functions in the CONFIG_XEN_CTRL_INTERFACE_VERSION < 41000 section. So we need to provide that definition, or (as applicable) include the appropriate header, earlier in the file. (Ideally the newer compatibility layers w

[Xen-devel] [PATCH 11/12] xen: Expect xenstore write to fail when restricted

2018-03-08 Thread Ian Jackson
From: Ross Lagerwall Saving the current state to xenstore may fail when running restricted (in particular, after a migration). Therefore, don't report the error or exit when running restricted. Toolstacks that want to allow running QEMU restricted should instead make use of QMP events to listen

[Xen-devel] [PATCH 07/12] xen: destroy_hvm_domain: Try xendevicemodel_shutdown

2018-03-08 Thread Ian Jackson
xc_interface_open etc. is not going to work if we have dropped privilege, but xendevicemodel_shutdown will if everything is new enough. xendevicemodel_shutdown is only availabe in Xen 4.10 and later, so provide a stub for earlier versions. Signed-off-by: Ian Jackson Reviewed-by: Anthony PERARD

[Xen-devel] [PATCH 03/12] xen: restrict: use xentoolcore_restrict_all

2018-03-08 Thread Ian Jackson
And insist that it works. Drop individual use of xendevicemodel_restrict and xenforeignmemory_restrict. These are not actually effective in this version of qemu, because qemu has a large number of fds open onto various Xen control devices. The restriction arrangements are still not right, becaus

[Xen-devel] [PATCH 02/12] xen: link against xentoolcore

2018-03-08 Thread Ian Jackson
From: Anthony PERARD Xen libraries in 4.10 include a new xentoolcore library. This contains the xentoolcore_restrict_all function which we are about to want to use. Signed-off-by: Ian Jackson Acked-by: Stefano Stabellini --- v5: More truthful commit message. --- configure | 8 +--- 1 fil

[Xen-devel] [PATCH 05/12] xen: destroy_hvm_domain: Move reason into a variable

2018-03-08 Thread Ian Jackson
We are going to want to reuse this. No functional change. Signed-off-by: Ian Jackson Reviewed-by: Anthony PERARD Acked-by: Stefano Stabellini --- hw/i386/xen/xen-hvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index

[Xen-devel] [PATCH 01/12] checkpatch: Add xendevicemodel_handle to the list of types

2018-03-08 Thread Ian Jackson
This avoids checkpatch misparsing (as statements) long function definitions or declarations, which sometimes start with constructs like this: static inline int xendevicemodel_relocate_memory( xendevicemodel_handle *dmod, domid_t domid, ... CC: Eric Blake CC: Paolo Bonzini CC: Daniel P.

Re: [Xen-devel] [PATCH] sched/rt: Fix build after c/s c3715dd8fb766

2018-03-08 Thread Meng Xu
On Thu, Mar 8, 2018 at 6:12 AM, Andrew Cooper wrote: > > Travis reports: > > sched_rt.c:241:30: error: unused function 'rt_dom' > [-Werror,-Wunused-function] > static inline struct rt_dom *rt_dom(const struct domain *dom) >^ > 1 error generated. > > when comp

Re: [Xen-devel] [Qemu-devel] [PATCH v6 00/11] xen: xen-domid-restrict improvements

2018-03-08 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 1520530757-4477-1-git-send-email-ian.jack...@eu.citrix.com Subject: [Qemu-devel] [PATCH v6 00/11] xen: xen-domid-restrict improvements === TEST SCRIPT BEGIN === #!/bin/bash # Testing script w

Re: [Xen-devel] [PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md

2018-03-08 Thread Lars Kurth
On 08/03/2018, 18:44, "Ian Jackson" wrote: Lars Kurth writes ("[PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md"): > x86/Emulated platform devices (QEMU): > - Aded PCI host bridge (as in xen.git:docs/misc/qemu-xen-security) > New: x86/Emulated Storage I

Re: [Xen-devel] [Qemu-devel] [PATCH v6 00/11] xen: xen-domid-restrict improvements

2018-03-08 Thread Ian Jackson
no-re...@patchew.org writes ("Re: [Qemu-devel] [PATCH v6 00/11] xen: xen-domid-restrict improvements"): > This series seems to have some coding style problems. See output below for > more information: Obviously I should have run checkpatch myself. I will send a v6.1. Ian. _

Re: [Xen-devel] [Qemu-devel] [PATCH v6 00/11] xen: xen-domid-restrict improvements

2018-03-08 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1520530757-4477-1-git-send-email-ian.jack...@eu.citrix.com Subject: [Qemu-devel] [PATCH v6 00/11] xen: xen-domid-restrict improvements === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Xen-devel] [PATCH v6 00/11] xen: xen-domid-restrict improvements

2018-03-08 Thread Ian Jackson
For reasons I still don't quite understand, this cover letter was not sent to the whole CC list so I am doing that by hand now. Ian Jackson writes ("[PATCH v6 00/11] xen: xen-domid-restrict improvements"): > This series provides necessary support for running qemu as a Xen > device model without po

Re: [Xen-devel] [PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md

2018-03-08 Thread Ian Jackson
Lars Kurth writes ("[PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md"): > x86/Emulated platform devices (QEMU): > - Aded PCI host bridge (as in xen.git:docs/misc/qemu-xen-security) > New: x86/Emulated Storage Image Formats > - Added raw, qcow, qcow2, vhd (as in xen.git:doc

[Xen-devel] [PATCH 06/11] xen: destroy_hvm_domain: Try xendevicemodel_shutdown

2018-03-08 Thread Ian Jackson
xc_interface_open etc. is not going to work if we have dropped privilege, but xendevicemodel_shutdown will if everything is new enough. xendevicemodel_shutdown is only availabe in Xen 4.10 and later, so provide a stub for earlier versions. Signed-off-by: Ian Jackson Reviewed-by: Anthony PERARD

[Xen-devel] [PATCH 05/11] xen: move xc_interface compatibility fallback further up the file

2018-03-08 Thread Ian Jackson
We are going to want to use the dummy xendevicemodel_handle type in new stub functions in the CONFIG_XEN_CTRL_INTERFACE_VERSION < 41000 section. So we need to provide that definition, or (as applicable) include the appropriate header, earlier in the file. (Ideally the newer compatibility layers w

[Xen-devel] [PATCH 04/11] xen: destroy_hvm_domain: Move reason into a variable

2018-03-08 Thread Ian Jackson
We are going to want to reuse this. No functional change. Signed-off-by: Ian Jackson Reviewed-by: Anthony PERARD Acked-by: Stefano Stabellini --- hw/i386/xen/xen-hvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index

[Xen-devel] [PATCH 08/11] configure: do_compiler: Dump some extra info under bash

2018-03-08 Thread Ian Jackson
This makes it much easier to find a particular thing in config.log. The information may be lacking in other shells, resulting in harmless empty output. (This is why we don't use the proper ${FUNCNAME[*]} array syntax - other shells will choke on that.) The extra output is only printed if configu

[Xen-devel] [PATCH 07/11] os-posix: Provide new -runas : facility

2018-03-08 Thread Ian Jackson
This allows the caller to specify a uid and gid to use, even if there is no corresponding password entry. This will be useful in certain Xen configurations. We don't support just -runas because: (i) deprivileging without calling setgroups would be ineffective (ii) given only a uid we don't know

[Xen-devel] [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post

2018-03-08 Thread Ian Jackson
We need to restrict *all* the control fds that qemu opens. Looking in /proc/PID/fd shows there are many; their allocation seems scattered throughout Xen support code in qemu. We must postpone the restrict call until roughly the same time as qemu changes its uid, chroots (if applicable), and so on

[Xen-devel] [PATCH 11/11] scripts/get_maintainer.pl: Print proper error message for missing $file

2018-03-08 Thread Ian Jackson
If you pass scripts/get_maintainer.pl the name of a FIFO or other exciting object (/dev/stdin, for example), it would falsely print "file not found". Instead: stat the object rather than using -f so that we do not mind if the object is not a file; and print the errno value in the error message. S

[Xen-devel] [PATCH 09/11] xen: Use newly added dmops for mapping VGA memory

2018-03-08 Thread Ian Jackson
From: Ross Lagerwall Xen unstable (to be in 4.11) has two new dmops, relocate_memory and pin_memory_cacheattr. Use these to set up the VGA memory, replacing the previous calls to libxc. This allows the VGA console to work properly when QEMU is running restricted (-xen-domid-restrict). Wrapper fu

[Xen-devel] [PATCH 01/11] xen: link against xentoolcore

2018-03-08 Thread Ian Jackson
From: Anthony PERARD Xen libraries in 4.10 include a new xentoolcore library. This contains the xentoolcore_restrict_all function which we are about to want to use. Signed-off-by: Ian Jackson Acked-by: Stefano Stabellini --- v5: More truthful commit message. --- configure | 8 +--- 1 fil

[Xen-devel] [PATCH v6 00/11] xen: xen-domid-restrict improvements

2018-03-08 Thread Ian Jackson
This series provides necessary support for running qemu as a Xen device model without power equivalent to root. In particular, it makes -xen-domid-restrict effective. I have taken into account all the comments from v5 (from October!) and there are also two new patches from Ross Lagerwall. m a

[Xen-devel] [PATCH 02/11] xen: restrict: use xentoolcore_restrict_all

2018-03-08 Thread Ian Jackson
And insist that it works. Drop individual use of xendevicemodel_restrict and xenforeignmemory_restrict. These are not actually effective in this version of qemu, because qemu has a large number of fds open onto various Xen control devices. The restriction arrangements are still not right, becaus

[Xen-devel] [PATCH 10/11] xen: Expect xenstore write to fail when restricted

2018-03-08 Thread Ian Jackson
From: Ross Lagerwall Saving the current state to xenstore may fail when running restricted (in particular, after a migration). Therefore, don't report the error or exit when running restricted. Toolstacks that want to allow running QEMU restricted should instead make use of QMP events to listen

[Xen-devel] [PATCH] Move missing items from docs/misc/qemu-xen-security to SUPPORT.md

2018-03-08 Thread Lars Kurth
x86/Emulated platform devices (QEMU): - Aded PCI host bridge (as in xen.git:docs/misc/qemu-xen-security) New: x86/Emulated Storage Image Formats - Added raw, qcow, qcow2, vhd (as in xen.git:docs/misc/qemu-xen-security) x86/Emulated graphics (QEMU) - Fixed typo (stdvga) - Added xenfb (as in xen.git:

Re: [Xen-devel] [PATCH v6 1/9] x86/mm: add pv prefix to {alloc, free}_page_type

2018-03-08 Thread Jan Beulich
>>> On 13.02.18 at 21:04, wrote: > The two functions are only used by PV code paths because: > > 1. To allocate a PGT_l*_page_table type page, a DomU must explicitly >request such types via PV MMU hypercall. > 2. PV Dom0 builder explicitly asks for PGT_l*_page_table type pages, >but it is

Re: [Xen-devel] [PATCH v6 1/9] x86/mm: add pv prefix to {alloc, free}_page_type

2018-03-08 Thread Jan Beulich
>>> On 13.02.18 at 21:04, wrote: > The two functions are only used by PV code paths because: > > 1. To allocate a PGT_l*_page_table type page, a DomU must explicitly >request such types via PV MMU hypercall. > 2. PV Dom0 builder explicitly asks for PGT_l*_page_table type pages, >but it is

Re: [Xen-devel] [PATCH 21/57] ARM: GICv2: extend LR read/write functions to cover EOI and source

2018-03-08 Thread Julien Grall
On 03/08/2018 04:41 PM, Julien Grall wrote: Hi, On 08/03/18 16:25, Andre Przywara wrote: On 06/03/18 16:06, Julien Grall wrote: On 05/03/18 16:03, Andre Przywara wrote: diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h index 8fab458d7f..89a07ae6b4 100644 --- a/xen/include/a

Re: [Xen-devel] [PATCH] sched/rt: Fix build after c/s c3715dd8fb766

2018-03-08 Thread George Dunlap
On 03/08/2018 11:12 AM, Andrew Cooper wrote: > Travis reports: > > sched_rt.c:241:30: error: unused function 'rt_dom' > [-Werror,-Wunused-function] > static inline struct rt_dom *rt_dom(const struct domain *dom) >^ > 1 error generated. > > when compiling wit

Re: [Xen-devel] [PATCH v3 7/7] x86/build: Use new .nops directive when available

2018-03-08 Thread Jan Beulich
>>> On 08.03.18 at 17:48, wrote: > On 08/03/18 15:53, Jan Beulich wrote: > On 07.03.18 at 16:51, wrote: >>> --- a/xen/arch/x86/Rules.mk >>> +++ b/xen/arch/x86/Rules.mk >>> @@ -29,6 +29,10 @@ $(call as-option-add,CFLAGS,CC,"invpcid >>> (%rax)$$(comma)%rax",-DHAVE_AS_INVPCID) >>> $(call as-op

Re: [Xen-devel] [PATCH v3 5/7] x86/alt: Support for automatic padding calculations

2018-03-08 Thread Andrew Cooper
On 08/03/18 16:49, Jan Beulich wrote: On 08.03.18 at 17:23, wrote: >> On 08/03/18 15:42, Jan Beulich wrote: >> On 07.03.18 at 16:51, wrote: @@ -175,18 +175,47 @@ void init_or_livepatch apply_alternatives(const struct alt_instr *start, * So be careful if you want to

Re: [Xen-devel] [PATCH v3 5/7] x86/alt: Support for automatic padding calculations

2018-03-08 Thread Jan Beulich
>>> On 08.03.18 at 17:23, wrote: > On 08/03/18 15:42, Jan Beulich wrote: > On 07.03.18 at 16:51, wrote: >>> @@ -175,18 +175,47 @@ void init_or_livepatch apply_alternatives(const >>> struct alt_instr *start, >>> * So be careful if you want to change the scan order to any other >>>

Re: [Xen-devel] [PATCH v3 7/7] x86/build: Use new .nops directive when available

2018-03-08 Thread Andrew Cooper
On 08/03/18 15:53, Jan Beulich wrote: On 07.03.18 at 16:51, wrote: >> --- a/xen/arch/x86/Rules.mk >> +++ b/xen/arch/x86/Rules.mk >> @@ -29,6 +29,10 @@ $(call as-option-add,CFLAGS,CC,"invpcid >> (%rax)$$(comma)%rax",-DHAVE_AS_INVPCID) >> $(call as-option-add,CFLAGS,CC,\ >> ".if ((1 > 0)

Re: [Xen-devel] [BUG] unable to shutdown (page fault in mwait_idle()/do_dbs_timer()/__find_next_bit()) (fwd)

2018-03-08 Thread Jan Beulich
>>> On 08.03.18 at 11:26, wrote: > Console output added (7x OK, 2x FAILED). Thanks. You've chopped off some of the messages though. I think I've spotted the issue nevertheless - would you please give the patch below a try? Jan cpufreq/ondemand: fix race while offlining CPU Offlining a CPU invo

Re: [Xen-devel] [PATCH 21/57] ARM: GICv2: extend LR read/write functions to cover EOI and source

2018-03-08 Thread Julien Grall
Hi, On 08/03/18 16:25, Andre Przywara wrote: On 06/03/18 16:06, Julien Grall wrote: On 05/03/18 16:03, Andre Przywara wrote: diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h index 8fab458d7f..89a07ae6b4 100644 --- a/xen/include/asm-arm/gic.h +++ b/xen/include/asm-arm/gic.h @@

Re: [Xen-devel] [PATCH 44/57] ARM: new VGIC: Add SGIPENDR register handlers

2018-03-08 Thread Julien Grall
Hi Andre, On 05/03/18 16:04, Andre Przywara wrote: As this register is v2 specific, its implementation lives entirely in vgic-mmio-v2.c. This register allows setting the source mask of an IPI. This is based on Linux commit ed40213ef9b0, written by Andre Przywara. Signed-off-by: Andre Przywara

Re: [Xen-devel] [PATCH 42/57] ARM: new VGIC: Add TARGET registers handlers

2018-03-08 Thread Andre Przywara
Hi, On 08/03/18 16:18, Julien Grall wrote: > Hi Andre, > > On 05/03/18 16:04, Andre Przywara wrote: >> The target register handlers are v2 emulation specific, so their >> implementation lives entirely in vgic-mmio-v2.c. >> We copy the old VGIC behaviour of assigning an IRQ to the first VCPU >> se

Re: [Xen-devel] [PATCH 43/57] ARM: new VGIC: Add SGIR register handler

2018-03-08 Thread Julien Grall
Hi, On 05/03/18 16:04, Andre Przywara wrote: Triggering an IPI via this register is v2 specific, so the implementation lives entirely in vgic-mmio-v2.c. This is based on Linux commit 55cc01fb9004, written by Andre Przywara. Signed-off-by: Andre Przywara --- Changelog RFC ... v1: - use symboli

Re: [Xen-devel] [GIT PULL] (xen) stable/for-jens-4.15

2018-03-08 Thread Jens Axboe
On 3/8/18 9:19 AM, Konrad Rzeszutek Wilk wrote: > Hi Jens, > > Please git pull the following branch for your for-linus branch: > > git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git > stable/for-jens-4.15 > > It has one simple fix for the multi-queue support not showing up after a blo

Re: [Xen-devel] [PATCH 21/57] ARM: GICv2: extend LR read/write functions to cover EOI and source

2018-03-08 Thread Andre Przywara
Hi, On 06/03/18 16:06, Julien Grall wrote: > Hi Andre, > > On 05/03/18 16:03, Andre Przywara wrote: >> So far our LR read/write functions do not handle the EOI bit and the >> source CPUID bits in an LR, because the current VGIC implementation does >> not use them. >> Extend the gic_lr data struct

Re: [Xen-devel] [PATCH 40/57] ARM: new VGIC: Add PRIORITY registers handlers

2018-03-08 Thread Julien Grall
On 08/03/18 16:21, Andre Przywara wrote: Hi, On 08/03/18 15:48, Julien Grall wrote: On 05/03/18 16:03, Andre Przywara wrote: The priority register handlers are shared between the v2 and v3 emulation, so their implementation goes into vgic-mmio.c, to be easily referenced from the v3 emulati

Re: [Xen-devel] [PATCH v3 5/7] x86/alt: Support for automatic padding calculations

2018-03-08 Thread Andrew Cooper
On 08/03/18 15:42, Jan Beulich wrote: On 07.03.18 at 16:51, wrote: >> @@ -175,18 +175,47 @@ void init_or_livepatch apply_alternatives(const struct >> alt_instr *start, >> * So be careful if you want to change the scan order to any other >> * order. >> */ >> -for ( a = s

Re: [Xen-devel] [PATCH 40/57] ARM: new VGIC: Add PRIORITY registers handlers

2018-03-08 Thread Andre Przywara
Hi, On 08/03/18 15:48, Julien Grall wrote: > > > On 05/03/18 16:03, Andre Przywara wrote: >> The priority register handlers are shared between the v2 and v3 >> emulation, >> so their implementation goes into vgic-mmio.c, to be easily referenced >> from the v3 emulation as well later. >> There is

[Xen-devel] [GIT PULL] (xen) stable/for-jens-4.15

2018-03-08 Thread Konrad Rzeszutek Wilk
Hi Jens, Please git pull the following branch for your for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git stable/for-jens-4.15 It has one simple fix for the multi-queue support not showing up after a block device was detached/re-attached. The patch was originally po

Re: [Xen-devel] [PATCH 42/57] ARM: new VGIC: Add TARGET registers handlers

2018-03-08 Thread Julien Grall
Hi Andre, On 05/03/18 16:04, Andre Przywara wrote: The target register handlers are v2 emulation specific, so their implementation lives entirely in vgic-mmio-v2.c. We copy the old VGIC behaviour of assigning an IRQ to the first VCPU set in the target mask instead of making it possibly pending o

Re: [Xen-devel] [PATCH 41/57] ARM: new VGIC: Add CONFIG registers handlers

2018-03-08 Thread Julien Grall
Hi Andre, On 05/03/18 16:03, Andre Przywara wrote: The config register handlers are shared between the v2 and v3 emulation, so their implementation goes into vgic-mmio.c, to be easily referenced from the v3 emulation as well later. This is based on Linux commit 79717e4ac09c, written by Andre Pr

Re: [Xen-devel] [PATCH v3 7/7] x86/build: Use new .nops directive when available

2018-03-08 Thread Jan Beulich
>>> On 07.03.18 at 16:51, wrote: > --- a/xen/arch/x86/Rules.mk > +++ b/xen/arch/x86/Rules.mk > @@ -29,6 +29,10 @@ $(call as-option-add,CFLAGS,CC,"invpcid > (%rax)$$(comma)%rax",-DHAVE_AS_INVPCID) > $(call as-option-add,CFLAGS,CC,\ > ".if ((1 > 0) < 0); .error \"\";.endif",,-DHAVE_AS_NEGATIV

Re: [Xen-devel] [PATCH 40/57] ARM: new VGIC: Add PRIORITY registers handlers

2018-03-08 Thread Julien Grall
On 05/03/18 16:03, Andre Przywara wrote: The priority register handlers are shared between the v2 and v3 emulation, so their implementation goes into vgic-mmio.c, to be easily referenced from the v3 emulation as well later. There is a corner case when we change the priority of a pending interru

Re: [Xen-devel] [PATCH v3 5/7] x86/alt: Support for automatic padding calculations

2018-03-08 Thread Jan Beulich
>>> On 07.03.18 at 16:51, wrote: > @@ -175,18 +175,47 @@ void init_or_livepatch apply_alternatives(const struct > alt_instr *start, > * So be careful if you want to change the scan order to any other > * order. > */ > -for ( a = start; a < end; a++ ) > +for ( a = base =

Re: [Xen-devel] [PATCH 39/57] ARM: new VGIC: Add ACTIVE registers handlers

2018-03-08 Thread Julien Grall
Hi Andre, On 05/03/18 16:03, Andre Przywara wrote: The active register handlers are shared between the v2 and v3 emulation, so their implementation goes into vgic-mmio.c, to be easily referenced from the v3 emulation as well later. Since activation/deactivation of an interrupt may happen entirel

[Xen-devel] [xen-4.10-testing test] 120284: regressions - trouble: blocked/broken/fail/pass

2018-03-08 Thread osstest service owner
flight 120284 xen-4.10-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/120284/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-amd64 4 host-

Re: [Xen-devel] [PATCH 04/57] ARM: GICv3: simplify GICv3 redistributor stride handling

2018-03-08 Thread Julien Grall
On 08/03/18 12:40, Andre Przywara wrote: Hi, Hi, On 06/03/18 13:49, Julien Grall wrote: On 05/03/18 17:08, Julien Grall wrote: On 05/03/18 16:03, Andre Przywara wrote: Instead of hard coding the architected redistributor stride into the code, lets use a clear #define to the two values

Re: [Xen-devel] [PATCH v2 6/6] xen/x86: use PCID feature for XPTI

2018-03-08 Thread Jan Beulich
>>> On 02.03.18 at 09:14, wrote: > Avoid flushing the complete TLB when switching %cr3 for mitigation of > Meltdown by using the PCID feature if available. > > We are using 4 PCID values for a 64 bit pv domain subject to XPTI: > > - hypervisor active and guest in kernel mode > - guest active and

[Xen-devel] [RFC] xen/arm: Restrict when a physical IRQ can be routed/removed from/to a domain

2018-03-08 Thread julien . grall
From: Julien Grall Xen is currently allowing to route/remove an interrupt from/to the domain while it is running. However, we never sync the virtual interrupt state to the physical interrupt. This could lead to undesirable effect on the vGIC emulation and potentially the hardware. One solution

[Xen-devel] [seabios test] 120289: regressions - FAIL

2018-03-08 Thread osstest service owner
flight 120289 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/120289/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail REGR. vs. 115539 Tests which did not suc

Re: [Xen-devel] [PATCH v4 0/7] unsafe big.LITTLE support

2018-03-08 Thread Julien Grall
Hi, On 08/03/18 12:43, Peng Fan wrote: I am not sure whether this issue cause DomU big/Little not work. Well, I would recommend to speak with NXP whether this errata affects TLB flush for Hypervisor Page-Table or Stage-2 Page-Table. I tried the following, but no help. Not sure my patch is co

Re: [Xen-devel] [PATCH v2 4/6] xen/x86: disable global pages for domains with XPTI active

2018-03-08 Thread Jan Beulich
>>> On 02.03.18 at 09:14, wrote: > @@ -123,22 +142,14 @@ unsigned int flush_area_local(const void *va, unsigned > int flags) > u32 t = pre_flush(); > > if ( !cpu_has_invpcid ) > -{ > -unsigned long cr4 = read_cr4(); > - > -wr

Re: [Xen-devel] [PATCH v2 4/6] xen/x86: disable global pages for domains with XPTI active

2018-03-08 Thread Juergen Gross
On 08/03/18 15:33, Jan Beulich wrote: On 08.03.18 at 15:05, wrote: >> On 08/03/18 14:38, Jan Beulich wrote: >> On 02.03.18 at 09:14, wrote: Instead of flushing the TLB from global pages when switching address spaces with XPTI being active just disable global pages via %cr4

Re: [Xen-devel] [PATCH v2 4/6] xen/x86: disable global pages for domains with XPTI active

2018-03-08 Thread Jan Beulich
>>> On 08.03.18 at 15:05, wrote: > On 08/03/18 14:38, Jan Beulich wrote: > On 02.03.18 at 09:14, wrote: >>> Instead of flushing the TLB from global pages when switching address >>> spaces with XPTI being active just disable global pages via %cr4 >>> completely when a domain subject to XPTI is

Re: [Xen-devel] [PATCH] xen: xenbus: use put_device() instead of kfree()

2018-03-08 Thread Juergen Gross
On 06/03/18 11:10, Arvind Yadav wrote: > Never directly free @dev after calling device_register(), even > if it returned an error! Always use put_device() to give up the > reference initialized. > > Signed-off-by: Arvind Yadav Committed to xen/tip.git for-linus-4.16a Juergen _

Re: [Xen-devel] [PATCH v2 5/6] xen/x86: use flag byte for decision whether xen_cr3 is valid

2018-03-08 Thread Juergen Gross
On 08/03/18 15:24, Jan Beulich wrote: On 02.03.18 at 09:14, wrote: >> This reduces the number of branches in interrupt handling and results >> in better performance (e.g. parallel make of the Xen hypervisor on my >> system was using about 3% less system time). > > 3% seems an awful lot for a

Re: [Xen-devel] [PATCH v2 5/6] xen/x86: use flag byte for decision whether xen_cr3 is valid

2018-03-08 Thread Jan Beulich
>>> On 02.03.18 at 09:14, wrote: > This reduces the number of branches in interrupt handling and results > in better performance (e.g. parallel make of the Xen hypervisor on my > system was using about 3% less system time). 3% seems an awful lot for a single conditional branch on each of the thre

Re: [Xen-devel] [PATCH v2 4/6] xen/x86: disable global pages for domains with XPTI active

2018-03-08 Thread Juergen Gross
On 08/03/18 14:38, Jan Beulich wrote: On 02.03.18 at 09:14, wrote: >> Instead of flushing the TLB from global pages when switching address >> spaces with XPTI being active just disable global pages via %cr4 >> completely when a domain subject to XPTI is active. This avoids the >> need for ext

Re: [Xen-devel] [PATCH v2 4/6] xen/x86: disable global pages for domains with XPTI active

2018-03-08 Thread Jan Beulich
>>> On 02.03.18 at 09:14, wrote: > Instead of flushing the TLB from global pages when switching address > spaces with XPTI being active just disable global pages via %cr4 > completely when a domain subject to XPTI is active. This avoids the > need for extra TLB flushes as loading %cr3 will remove

[Xen-devel] [xen-unstable-smoke test] 120347: tolerable all pass - PUSHED

2018-03-08 Thread osstest service owner
flight 120347 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/120347/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [PATCH v2 3/6] xen/x86: support per-domain flag for xpti

2018-03-08 Thread Juergen Gross
On 08/03/18 13:49, Jan Beulich wrote: On 08.03.18 at 12:30, wrote: >> On 08/03/18 11:17, Jan Beulich wrote: >> On 02.03.18 at 09:14, wrote: +static int parse_xpti(const char *s) +{ +int rc = 0; + +switch ( parse_bool(s, NULL) ) +{ +case

Re: [Xen-devel] [PATCH v2 1/6] x86/xpti: avoid copying L4 page table contents when possible

2018-03-08 Thread Juergen Gross
On 08/03/18 13:47, Jan Beulich wrote: On 08.03.18 at 12:59, wrote: >> On 05/03/18 17:43, Jan Beulich wrote: >> On 02.03.18 at 09:13, wrote: @@ -3704,18 +3706,22 @@ long do_mmu_update( break; rc = mod_l4_entry(va, l4e_from_intpt

Re: [Xen-devel] [PATCH] xen-pvdevice: Introduce a simplistic xen-pvdevice save state

2018-03-08 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin [mailto:igor.druzhi...@citrix.com] > Sent: 08 March 2018 12:53 > To: qemu-de...@nongnu.org; xen-devel@lists.xenproject.org > Cc: sstabell...@kernel.org; Paul Durrant ; Anthony > Perard ; m...@redhat.com; > pbonz...@redhat.com; Igor Druzhinin > Su

[Xen-devel] [PATCH] xen-pvdevice: Introduce a simplistic xen-pvdevice save state

2018-03-08 Thread Igor Druzhinin
This should help to avoid problems with accessing the device after migration/resume without PV drivers. Older systems will acquire the new record when migrated which should not change their state for worse. Signed-off-by: Igor Druzhinin --- hw/i386/xen/xen_pvdevice.c | 11 +++ 1 file cha

Re: [Xen-devel] [PATCH v2 3/6] xen/x86: support per-domain flag for xpti

2018-03-08 Thread Jan Beulich
>>> On 08.03.18 at 12:30, wrote: > On 08/03/18 11:17, Jan Beulich wrote: > On 02.03.18 at 09:14, wrote: >>> +static int parse_xpti(const char *s) >>> +{ >>> +int rc = 0; >>> + >>> +switch ( parse_bool(s, NULL) ) >>> +{ >>> +case 0: >>> +opt_xpti = XPTI_OFF; >>> +

Re: [Xen-devel] [PATCH v2 1/6] x86/xpti: avoid copying L4 page table contents when possible

2018-03-08 Thread Jan Beulich
>>> On 08.03.18 at 12:59, wrote: > On 05/03/18 17:43, Jan Beulich wrote: > On 02.03.18 at 09:13, wrote: >>> @@ -3704,18 +3706,22 @@ long do_mmu_update( >>> break; >>> rc = mod_l4_entry(va, l4e_from_intpte(req.val), mfn, >>>

Re: [Xen-devel] [PATCH v4 0/7] unsafe big.LITTLE support

2018-03-08 Thread Peng Fan
> -Original Message- > From: Julien Grall [mailto:julien.gr...@arm.com] > Sent: 2018年3月8日 20:30 > To: Peng Fan ; Peng Fan ; > Stefano Stabellini > Cc: xen-de...@lists.xen.org > Subject: Re: [Xen-devel] [PATCH v4 0/7] unsafe big.LITTLE support > > Hi, > > On 08/03/18 12:23, Peng Fan wro

Re: [Xen-devel] [PATCH 04/57] ARM: GICv3: simplify GICv3 redistributor stride handling

2018-03-08 Thread Andre Przywara
Hi, On 06/03/18 13:49, Julien Grall wrote: > > > On 05/03/18 17:08, Julien Grall wrote: >> On 05/03/18 16:03, Andre Przywara wrote: >>> Instead of hard coding the architected redistributor stride into the >>> code, lets use a clear #define to the two values for GICv3 and GICv4 and >>> clarify th

Re: [Xen-devel] [PATCH RFC 00/10] x86 passthrough code cleanup

2018-03-08 Thread Jan Beulich
>>> On 08.03.18 at 13:18, wrote: > Ping? And I'm sorry again, even less so for any RFCs (there are about 100 older ones as well that want looking at). Jan ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/

Re: [Xen-devel] [PATCH v6 0/9] x86: refactor mm.c

2018-03-08 Thread Jan Beulich
>>> On 08.03.18 at 13:17, wrote: > Ping? I'm sorry, but still no time to look over this. Jan ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v4 0/7] unsafe big.LITTLE support

2018-03-08 Thread Julien Grall
Hi, On 08/03/18 12:23, Peng Fan wrote: -Original Message- From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf Of Julien Grall Sent: 2018年3月8日 19:04 To: Peng Fan ; Stefano Stabellini Cc: xen-de...@lists.xen.org Subject: Re: [Xen-devel] [PATCH v4 0/7] unsafe big.L

Re: [Xen-devel] [PATCH v4 0/7] unsafe big.LITTLE support

2018-03-08 Thread Peng Fan
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf Of > Julien Grall > Sent: 2018年3月8日 19:04 > To: Peng Fan ; Stefano Stabellini > > Cc: xen-de...@lists.xen.org > Subject: Re: [Xen-devel] [PATCH v4 0/7] unsafe big.LITTLE support > > Hello, >

Re: [Xen-devel] [PATCH RFC 00/10] x86 passthrough code cleanup

2018-03-08 Thread Wei Liu
Ping? Any more comment on this? On Wed, Feb 21, 2018 at 09:46:51PM +, Wei Liu wrote: > Hi all > > At some point I would like to make CONFIG_HVM and CONFIG_PV work. The > passthrough code is one of the road blocks for that work. > > A short discussion on #xendevel made me think that having

Re: [Xen-devel] [PATCH v6 0/9] x86: refactor mm.c

2018-03-08 Thread Wei Liu
Ping? On Tue, Feb 13, 2018 at 08:03:59PM +, Wei Liu wrote: > Hello > > This series can be found at: >https://xenbits.xen.org/git-http/people/liuw/xen.git wip.split-mm-v6.1 > > Unfortunately there isn't any resemblance to v5 because a lot of things > have changed since Sept last year. And

  1   2   >