Re: [Xen-devel] [PATCH V2] x86/p2m: fixed p2m_change_type_range() start / end check

2018-04-23 Thread Razvan Cojocaru
On 04/18/2018 04:12 PM, Razvan Cojocaru wrote: > p2m_change_type_range() handles end > max_mapped_pfn, but not > start > max_mapped_pfn. Check the latter just after grabbing the > lock and bail if true. > > Signed-off-by: Razvan Cojocaru > Suggested-by: George Dunlap > > --- > Changes since V1:

Re: [Xen-devel] [PATCH 3/8] x86/SVM: Add AVIC vmexit handlers

2018-04-23 Thread Jan Beulich
>>> On 20.04.18 at 22:02, wrote: > On 4/17/2018 7:58 AM, Jan Beulich wrote: > On 04.04.18 at 01:01, wrote: >>> --- a/xen/include/asm-x86/hvm/vlapic.h >>> +++ b/xen/include/asm-x86/hvm/vlapic.h >>> @@ -137,6 +137,10 @@ void vlapic_ipi(struct vlapic *vlapic, uint32_t > icr_low, >>> uint32_t ic

[Xen-devel] [PATCH v5] x86/mm: Suppresses vm_events caused by page-walks

2018-04-23 Thread Alexandru Isaila
This patch is adding a way to enable/disable inguest pagefault events. It introduces the xc_monitor_inguest_pagefault function and adds the inguest_pagefault_disabled in the monitor structure. This is needed by the introspection so it will only get gla faults and not get spammed with other faults.

Re: [Xen-devel] [PATCH v2] Input: xen-kbdfront - allow better run-time configuration

2018-04-23 Thread Oleksandr Andrushchenko
Juergen, Jason, Dmitry any comment on this? Thank you, Oleksandr On 04/19/2018 04:39 PM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko It is now only possible to control if multi-touch virtual device is created or not (via the corresponding XenStore entries), but keyboard and po

Re: [Xen-devel] [PATCH V2] x86/p2m: fixed p2m_change_type_range() start / end check

2018-04-23 Thread Jan Beulich
>>> On 23.04.18 at 09:23, wrote: > On 04/18/2018 04:12 PM, Razvan Cojocaru wrote: >> p2m_change_type_range() handles end > max_mapped_pfn, but not >> start > max_mapped_pfn. Check the latter just after grabbing the >> lock and bail if true. >> >> Signed-off-by: Razvan Cojocaru >> Suggested-by: G

Re: [Xen-devel] [Bug 198497] handle_mm_fault / xen_pmd_val / radix_tree_lookup_slot Null pointer

2018-04-23 Thread Juergen Gross
On 20/04/18 17:20, Jason Andryuk wrote: > Adding xen-devel and the Linux Xen maintainers. > > Summary: Some Xen users (and maybe others) are hitting a BUG in > __radix_tree_lookup() under do_swap_page() - example backtrace is > provided at the end. Matthew Wilcox provided a band-aid patch that >

Re: [Xen-devel] [PATCH v2] Input: xen-kbdfront - allow better run-time configuration

2018-04-23 Thread Juergen Gross
On 23/04/18 10:02, Oleksandr Andrushchenko wrote: > Juergen, Jason, Dmitry > any comment on this? Oleksandr, please give us some time. I can't speak for others, but I am not sitting here idling and hoping that some work (e.g. patches to review) might appear. I have a lot of other stuff to do and

Re: [Xen-devel] Setting up a call to discuss PCI Emulation - Future Direction

2018-04-23 Thread Lars Kurth
Hi all, so it seems we have no perfect slot proposals, but 2 semi-perfect. May 2nd: 16:00 - 17:00 Christopher can't attend May 2nd: 17:00 - 18:00 Chao can't attend Maybe a compromise would be 16:30 to 17:30 Regards Lars On 21/04/2018, 05:47, "Alexey G" wrote: On Fri, 13 Apr 2018 11:01:49 +0

Re: [Xen-devel] [PATCH v2] Input: xen-kbdfront - allow better run-time configuration

2018-04-23 Thread Oleksandr Andrushchenko
On 04/23/2018 11:23 AM, Juergen Gross wrote: On 23/04/18 10:02, Oleksandr Andrushchenko wrote: Juergen, Jason, Dmitry any comment on this? Oleksandr, please give us some time. I can't speak for others, but I am not sitting here idling and hoping that some work (e.g. patches to review) might app

Re: [Xen-devel] [PATCH v2 for-4.11] libxl: fix memory map reported to PVH guests

2018-04-23 Thread Wei Liu
On Fri, Apr 20, 2018 at 03:57:19PM +0100, Roger Pau Monne wrote: > PVH guests with 4GB of RAM or more get a memory map like the > following: > > 0x00 - 0x00fee0 RAM > 0x00fee0 - 0x01 RESERVED > 0x00fc009000 - 0x00fc009040 ACPI > 0x00fc00 - 0x

Re: [Xen-devel] [PATCH v3] shim: don't let build modify shim.config

2018-04-23 Thread Wei Liu
On Fri, Apr 20, 2018 at 05:47:55PM +0200, Juergen Gross wrote: > Currently building the shim will modify shim.config in case some config > option was added or modified in the hypervisor. > > Avoid that by copying shim.config to an intermediate file instead. > > Signed-off-by: Juergen Gross Acke

Re: [Xen-devel] [RFC v2 4/9] libxl_qmp: Move the buffer realloc to the same scope level as read

2018-04-23 Thread Wei Liu
On Mon, Apr 16, 2018 at 06:32:22PM +0100, Anthony PERARD wrote: > In qmp_next(), the inner loop should only try to parse messages from > QMP, if there is more than one. > > The handling of the receive buffer ('incomplete'), should be done at the > same scope level as read(). It doesn't need to be

Re: [Xen-devel] [RFC v2 5/9] libxl: Learned to send FD through QMP to QEMU

2018-04-23 Thread Wei Liu
On Mon, Apr 16, 2018 at 06:32:23PM +0100, Anthony PERARD wrote: > Adding the ability to send a file descriptor from libxl to QEMU via the > QMP interface. This will be use with the "add-fd" QMP command. > > Signed-off-by: Anthony PERARD > --- Acked-by: Wei Liu _

Re: [Xen-devel] [RFC v2 6/9] libxl: Have QEMU save its state to a file descriptor

2018-04-23 Thread Wei Liu
On Mon, Apr 16, 2018 at 06:32:24PM +0100, Anthony PERARD wrote: > In case QEMU have restricted access to the system, open the file for it, > and QEMU will save its state to this file descritor. > > Signed-off-by: Anthony PERARD I think this is going to break FreeBSD? And what is /dev/fdset exac

Re: [Xen-devel] [RFC v2 7/9] libxl_qmp: Implement query-status command

2018-04-23 Thread Wei Liu
On Mon, Apr 16, 2018 at 06:32:25PM +0100, Anthony PERARD wrote: > It check via QMP if QEMU as reach the intended status. Some typos. "... checks ... if QEMU has reached ..." > > Signed-off-by: Anthony PERARD > --- > tools/libxl/libxl_internal.h | 3 +++ > tools/libxl/libxl_qmp.c | 39 ++

[Xen-devel] [distros-debian-sid test] 74636: tolerable FAIL

2018-04-23 Thread Platform Team regression test user
flight 74636 distros-debian-sid real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/74636/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-i386-sid-netboot-pvgrub 10 debian-di-install fail like 74625 test-armhf-armhf-armhf-sid-n

Re: [Xen-devel] EVTCHNOP_failure / xen 4.11

2018-04-23 Thread Yessine Daoud
Hi all, forgot to mention: I am testing xen on Salvator-X board. ᐧ 2018-04-20 12:05 GMT+01:00 Yessine Daoud : > Hi, > > When I upgrade to Xen 4.11, I got the following when creating any guest: > > (XEN)_event_channel.c:319:d0v3_EVTCHNOP_failure:_domain_1,_error_-22 > (XEN)_event_channel.c:319:d

Re: [Xen-devel] [PATCH 2/3] xen netback: add fault injection facility

2018-04-23 Thread Wei Liu
On Fri, Apr 20, 2018 at 10:47:31AM +, Stanislav Kinsburskii wrote: > > #include > #include > @@ -1649,6 +1650,7 @@ static int __init netback_init(void) > PTR_ERR(xen_netback_dbg_root)); > #endif /* CONFIG_DEBUG_FS */ > > + (void) xen_netbk_fi_init(); If you c

Re: [Xen-devel] [PATCH v5] x86/mm: Suppresses vm_events caused by page-walks

2018-04-23 Thread Wei Liu
On Mon, Apr 23, 2018 at 11:00:50AM +0300, Alexandru Isaila wrote: > This patch is adding a way to enable/disable inguest pagefault > events. It introduces the xc_monitor_inguest_pagefault function > and adds the inguest_pagefault_disabled in the monitor structure. > This is needed by the introspect

Re: [Xen-devel] RFC Xen signature verification for kexec

2018-04-23 Thread Daniel Kiper
On Mon, Apr 23, 2018 at 12:55:45AM -0600, Jan Beulich wrote: > >>> On 20.04.18 at 21:12, wrote: > > Two options for signature verification in Xen > > > > This proposal outlines two options under consideration for enhancing > > Xen to support signature verification of kexec loaded images. The > > f

Re: [Xen-devel] RFC Xen signature verification for kexec

2018-04-23 Thread Jan Beulich
>>> On 23.04.18 at 12:25, wrote: > On Mon, Apr 23, 2018 at 12:55:45AM -0600, Jan Beulich wrote: >> >>> On 20.04.18 at 21:12, wrote: >> > Two options for signature verification in Xen >> > >> > This proposal outlines two options under consideration for enhancing >> > Xen to support signature verif

Re: [Xen-devel] osstest outage,

2018-04-23 Thread Ian Jackson
The work is complete and a test job seems to have gone well. I have therefore un-stopped it. The Xen Project osstest is now operational and will start picking up work from the staging branches. Please let me know if you spot anything untoward. Ian. _

Re: [Xen-devel] [PATCH v2 01/10] xen/arm64: Added handling of the trapped access to OSLSR register

2018-04-23 Thread Julien Grall
Hi Mirela, On 20/04/18 13:25, Mirela Simonovic wrote: Linux/dom0 accesses OSLSR register when saving CPU context during the suspend procedure. Xen traps access to this register, but has no handling for it. Consequently, Xen injects undef exception to linux, causing it to crash. This patch adds h

Re: [Xen-devel] [PATCH v2 02/10] xen/arm: Ignore write to GICD_ISACTIVERn registers (vgic-v2)

2018-04-23 Thread Julien Grall
Hi Mirela, On 20/04/18 13:25, Mirela Simonovic wrote: Guests attempt to write into these registers on resume (for example Linux). Without this patch a data abort exception will be raised to the guest. This patch handles the write access by ignoring it, but only if the value to be written is zero

Re: [Xen-devel] [PATCH v2 03/10] xen/arm: Implement CPU_OFF PSCI call (physical interface)

2018-04-23 Thread Julien Grall
Hi Mirela, On 20/04/18 13:25, Mirela Simonovic wrote: During the system suspend to RAM non-boot CPUs will be hotplugged. This will be triggered via disable_nonboot_cpus() call. When hotplugged the CPU will end up in an infinite wfi loop in stop_cpu(). This patch adds PSCI CPU_OFF call to the EL3

Re: [Xen-devel] [PATCH v2 04/10] xen/arm: Remove __initdata and __init to enable CPU hotplug

2018-04-23 Thread Julien Grall
Hi Mirela, On 20/04/18 13:25, Mirela Simonovic wrote: CPU up flow is currently used during the initial boot to start secondary CPUs. However, the same flow should be used for CPU hotplug, e.g. when hotplugging secondary CPUs within the resume procedure (resume from the suspend to RAM). Therefore

Re: [Xen-devel] [PATCH v2 05/10] xen/arm: Setup virtual paging for non-boot CPUs on hotplug/resume

2018-04-23 Thread Julien Grall
Hi Mirela, On 20/04/18 13:25, Mirela Simonovic wrote: In existing code the paging for non-boot CPUs is setup only on boot. The setup is triggered from start_xen() after all CPUs are brought online. In other words, the initialization of VTCR_EL2 register is done out of the cpu_up/start_secondary(

Re: [Xen-devel] [PATCH v2 07/10] xen/arm: Release maintenance interrupt when CPU is hot-unplugged

2018-04-23 Thread Julien Grall
Hi Mirela, On 20/04/18 13:25, Mirela Simonovic wrote: When a CPU is hot-unplugged the maintenance interrupt has to be released in order to free the memory that was allocated when the CPU was hotplugged and interrupt requested. The interrupt was requested using request_irq() which is called from

[Xen-devel] [PATCH-for-4.11] xpti: fix bug in double fault handling

2018-04-23 Thread Juergen Gross
When entering the hypervisor via the double fault handler resetting xen_cr3 was missing. This led to switching to pv_cr3 when returning from the next following interrupt, e.g. after re-enabling interrupts in machine_restart(). Signed-off-by: Juergen Gross --- tools/firmware/xen-dir/shim.config |

Re: [Xen-devel] [PATCH v2 09/10] xen/arm: Free memory allocated for sibling/core maps on CPU hot-unplug

2018-04-23 Thread Julien Grall
Hi, On 20/04/18 13:25, Mirela Simonovic wrote: The memory allocated in setup_cpu_sibling_map() when a CPU is hotplugged has to be freed when the CPU is hot-unplugged. This is done in remove_cpu_sibling_map() and called from __cpu_disable() on CPU hot-unplug. Signed-off-by: Mirela Simonovic --

Re: [Xen-devel] [PATCH v2 10/10] xen/arm: Call check_local_cpu_errata for secondary CPU only on boot

2018-04-23 Thread Julien Grall
Hi, On 20/04/18 13:25, Mirela Simonovic wrote: Checking CPU errata should be done only when a CPU is initially booted. It is assumed that the CPU which is hotplugged after the system/Xen boots, was initially hotplugged during the system/Xen boot, so errata is checked by each CPU only once, on bo

Re: [Xen-devel] [PATCH V2] x86/p2m: fixed p2m_change_type_range() start / end check

2018-04-23 Thread George Dunlap
On 04/18/2018 02:12 PM, Razvan Cojocaru wrote: > p2m_change_type_range() handles end > max_mapped_pfn, but not > start > max_mapped_pfn. Check the latter just after grabbing the > lock and bail if true. > > Signed-off-by: Razvan Cojocaru > Suggested-by: George Dunlap Sorry, I meant to reply to

Re: [Xen-devel] [PATCH 0/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver

2018-04-23 Thread Wei Liu
On Fri, Apr 20, 2018 at 02:25:20PM +0300, Oleksandr Andrushchenko wrote: > > > the gntdev. > > > > > > I think this is generic enough that it could be implemented by a > > > device not tied to Xen. AFAICT the hyper_dma guys also wanted > > > something similar to this. > > You can't just wrap r

Re: [Xen-devel] [PATCH V2] x86/p2m: fixed p2m_change_type_range() start / end check

2018-04-23 Thread Razvan Cojocaru
On 04/23/2018 02:47 PM, George Dunlap wrote: > On 04/18/2018 02:12 PM, Razvan Cojocaru wrote: >> p2m_change_type_range() handles end > max_mapped_pfn, but not >> start > max_mapped_pfn. Check the latter just after grabbing the >> lock and bail if true. >> >> Signed-off-by: Razvan Cojocaru >> Sugge

[Xen-devel] [xen-unstable-smoke test] 122352: tolerable all pass - PUSHED

2018-04-23 Thread osstest service owner
flight 122352 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/122352/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [PATCH 0/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver

2018-04-23 Thread Oleksandr Andrushchenko
On 04/23/2018 02:52 PM, Wei Liu wrote: On Fri, Apr 20, 2018 at 02:25:20PM +0300, Oleksandr Andrushchenko wrote: the gntdev. I think this is generic enough that it could be implemented by a device not tied to Xen. AFAICT the hyper_dma guys also wanted something similar to this. You can't j

Re: [Xen-devel] [PATCH-for-4.11] xpti: fix bug in double fault handling

2018-04-23 Thread Jan Beulich
>>> On 23.04.18 at 13:37, wrote: > When entering the hypervisor via the double fault handler resetting > xen_cr3 was missing. This led to switching to pv_cr3 when returning > from the next following interrupt, e.g. after re-enabling interrupts > in machine_restart(). Pointing at bad behavior to j

Re: [Xen-devel] [PATCH-for-4.11] xpti: fix bug in double fault handling

2018-04-23 Thread Juergen Gross
On 23/04/18 14:11, Jan Beulich wrote: On 23.04.18 at 13:37, wrote: >> When entering the hypervisor via the double fault handler resetting >> xen_cr3 was missing. This led to switching to pv_cr3 when returning >> from the next following interrupt, e.g. after re-enabling interrupts >> in machin

[Xen-devel] [PATCH-for-4.11 v2] xpti: fix bug in double fault handling

2018-04-23 Thread Juergen Gross
When entering the hypervisor via the double fault handler resetting xen_cr3 was missing. This led to switching to pv_cr3 when returning from the next following interrupt. So repair this in order to allow interrupt handling to work even after a double fault. Signed-off-by: Juergen Gross --- xen/a

Re: [Xen-devel] [PATCH-for-4.11] xpti: fix bug in double fault handling

2018-04-23 Thread Jan Beulich
>>> On 23.04.18 at 14:22, wrote: > On 23/04/18 14:11, Jan Beulich wrote: > On 23.04.18 at 13:37, wrote: >>> --- a/tools/firmware/xen-dir/shim.config >>> +++ b/tools/firmware/xen-dir/shim.config >>> @@ -1,6 +1,6 @@ >>> # >>> # Automatically generated file; DO NOT EDIT. >>> -# Xen/x86 4.11-un

Re: [Xen-devel] [PATCH-for-4.11 v2] xpti: fix bug in double fault handling

2018-04-23 Thread Jan Beulich
>>> On 23.04.18 at 14:38, wrote: > When entering the hypervisor via the double fault handler resetting > xen_cr3 was missing. This led to switching to pv_cr3 when returning > from the next following interrupt. So repair this in order to allow > interrupt handling to work even after a double fault.

Re: [Xen-devel] [PATCH-for-4.11 v2] xpti: fix bug in double fault handling

2018-04-23 Thread Juergen Gross
On 23/04/18 14:49, Jan Beulich wrote: On 23.04.18 at 14:38, wrote: >> When entering the hypervisor via the double fault handler resetting >> xen_cr3 was missing. This led to switching to pv_cr3 when returning >> from the next following interrupt. So repair this in order to allow >> interrupt

Re: [Xen-devel] [PATCH-for-4.11 v2] xpti: fix bug in double fault handling

2018-04-23 Thread Andrew Cooper
On 23/04/18 13:38, Juergen Gross wrote: > When entering the hypervisor via the double fault handler resetting > xen_cr3 was missing. This led to switching to pv_cr3 when returning > from the next following interrupt. So repair this in order to allow > interrupt handling to work even after a double

Re: [Xen-devel] [PATCH] x86: correct assertion in destroy_perdomain_mapping()

2018-04-23 Thread Andrew Cooper
On 20/04/18 16:03, Jan Beulich wrote: > hvm_domain_initialise() may call this with nr being zero, which triggers > the "does not cross L3 boundary" check. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@list

Re: [Xen-devel] [PATCH-for-4.11 v2] xpti: fix bug in double fault handling

2018-04-23 Thread Juergen Gross
On 23/04/18 15:06, Andrew Cooper wrote: > On 23/04/18 13:38, Juergen Gross wrote: >> When entering the hypervisor via the double fault handler resetting >> xen_cr3 was missing. This led to switching to pv_cr3 when returning >> from the next following interrupt. So repair this in order to allow >> i

Re: [Xen-devel] [PATCH] x86: correct assertion in destroy_perdomain_mapping()

2018-04-23 Thread Juergen Gross
On 23/04/18 15:39, Andrew Cooper wrote: > On 20/04/18 16:03, Jan Beulich wrote: >> hvm_domain_initialise() may call this with nr being zero, which triggers >> the "does not cross L3 boundary" check. >> >> Signed-off-by: Jan Beulich > > Acked-by: Andrew Cooper > Release-acked-by: Juergen Gross

[Xen-devel] [PATCH v3] xpti: fix bug in double fault handling

2018-04-23 Thread Juergen Gross
When entering the hypervisor via the double fault handler resetting xen_cr3 was missing. This led to switching to pv_cr3 when returning from the next following exception, so repair this in order to allow exception handling to work even after a double fault. Signed-off-by: Juergen Gross --- xen/a

Re: [Xen-devel] [PATCH v3] xpti: fix bug in double fault handling

2018-04-23 Thread Jan Beulich
>>> On 23.04.18 at 15:59, wrote: > When entering the hypervisor via the double fault handler resetting > xen_cr3 was missing. This led to switching to pv_cr3 when returning > from the next following exception, so repair this in order to allow > exception handling to work even after a double fault.

Re: [Xen-devel] [PATCH v3] xpti: fix bug in double fault handling

2018-04-23 Thread Andrew Cooper
On 23/04/18 14:59, Juergen Gross wrote: > When entering the hypervisor via the double fault handler resetting > xen_cr3 was missing. This led to switching to pv_cr3 when returning > from the next following exception, so repair this in order to allow > exception handling to work even after a double

Re: [Xen-devel] [RFC 0/2] To introduce xenwatch multithreading (xen mtwatch)

2018-04-23 Thread Wei Liu
On Sat, Apr 07, 2018 at 07:25:53PM +0800, Dongli Zhang wrote: > About per-domU xenwatch thread create/destroy, a new type of xenstore node is > introduced: '/local/domain/0/mtwatch/'. > > Suppose the new domid id 7. During the domU (domid=7) creation, the xen > toolstack writes '/local/domain/0/mt

Re: [Xen-devel] Setting up a call to discuss PCI Emulation - Future Direction

2018-04-23 Thread Chao Gao
On Mon, Apr 23, 2018 at 08:26:59AM +, Lars Kurth wrote: >Hi all, >so it seems we have no perfect slot proposals, but 2 semi-perfect. >May 2nd: 16:00 - 17:00 Christopher can't attend >May 2nd: 17:00 - 18:00 Chao can't attend >Maybe a compromise would be 16:30 to 17:30 Hi Lars, Your suggestion

Re: [Xen-devel] [PATCH] tools/kdd: silence gcc 8 warning a different way

2018-04-23 Thread Wei Liu
On Mon, Apr 16, 2018 at 02:43:32PM +0200, Marek Marczykowski wrote: > On Mon, Apr 16, 2018 at 06:00:37AM -0600, Jan Beulich wrote: > > >>> On 16.04.18 at 12:33, wrote: > > > On Thu, Apr 12, 2018 at 06:04:49AM -0600, Jan Beulich wrote: > > >> Older gcc doesn't like "#pragma GCC diagnostic" inside f

Re: [Xen-devel] Setting up a call to discuss PCI Emulation - Future Direction

2018-04-23 Thread Chao Gao
On Mon, Apr 23, 2018 at 10:12:22PM +0800, Chao Gao wrote: >On Mon, Apr 23, 2018 at 08:26:59AM +, Lars Kurth wrote: >>Hi all, >>so it seems we have no perfect slot proposals, but 2 semi-perfect. >>May 2nd: 16:00 - 17:00 Christopher can't attend >>May 2nd: 17:00 - 18:00 Chao can't attend >>Maybe

[Xen-devel] [xen-unstable-smoke test] 122366: tolerable all pass - PUSHED

2018-04-23 Thread osstest service owner
flight 122366 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/122366/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [PATCH 05/16] xen: defer call to xen_restrict until just before os_setup_post

2018-04-23 Thread Anthony PERARD
On Thu, Apr 19, 2018 at 05:45:08PM +0100, Ian Jackson wrote: > We need to restrict *all* the control fds that qemu opens. Looking in > /proc/PID/fd shows there are many; their allocation seems scattered > throughout Xen support code in qemu. > > We must postpone the restrict call until roughly th

Re: [Xen-devel] [PATCH V2] x86/p2m: fixed p2m_change_type_range() start / end check

2018-04-23 Thread George Dunlap
On 04/23/2018 12:56 PM, Razvan Cojocaru wrote: > On 04/23/2018 02:47 PM, George Dunlap wrote: >> On 04/18/2018 02:12 PM, Razvan Cojocaru wrote: >>> p2m_change_type_range() handles end > max_mapped_pfn, but not >>> start > max_mapped_pfn. Check the latter just after grabbing the >>> lock and bail if

Re: [Xen-devel] [PATCH V2] x86/p2m: fixed p2m_change_type_range() start / end check

2018-04-23 Thread Razvan Cojocaru
On 04/23/2018 05:28 PM, George Dunlap wrote: > On 04/23/2018 12:56 PM, Razvan Cojocaru wrote: >> On 04/23/2018 02:47 PM, George Dunlap wrote: >>> On 04/18/2018 02:12 PM, Razvan Cojocaru wrote: p2m_change_type_range() handles end > max_mapped_pfn, but not start > max_mapped_pfn. Check the

Re: [Xen-devel] [RFC v2 4/9] libxl_qmp: Move the buffer realloc to the same scope level as read

2018-04-23 Thread Anthony PERARD
On Mon, Apr 23, 2018 at 10:03:39AM +0100, Wei Liu wrote: > On Mon, Apr 16, 2018 at 06:32:22PM +0100, Anthony PERARD wrote: > > In qmp_next(), the inner loop should only try to parse messages from > > QMP, if there is more than one. > > > > The handling of the receive buffer ('incomplete'), should

[Xen-devel] [OSSTEST PATCH 3/3] ms-planner: Including Unshare event for previous sharing state

2018-04-23 Thread Ian Jackson
Arrange for the initial plan to contain an Unshare event for resources which are unallocated, but currently recorded as shared (ie, they might be ready for reuse). Specifically, we need to: * Include the Wear in the information for a host with no unallocatable shares (since the consumers migh

[Xen-devel] [OSSTEST PATCH 0/3] ms-*: Support for host reuse

2018-04-23 Thread Ian Jackson
These three patches help support within-flight test hose reuse. Currently there is nothing that uses these new features in any public branch. I have a private branch with the client side, which has seen some testing and which I hope will be ready soon. These daemon changes have been in productio

[Xen-devel] [OSSTEST PATCH 1/3] ms-queuedaemon: Support infra-priority

2018-04-23 Thread Ian Jackson
This will allow a flight to order the queueing its own test jobs more sensibly without interfering with inter-flight priority. Signed-off-by: Ian Jackson --- README.planner | 1 + ms-queuedaemon | 6 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/README.planner b/README.pl

[Xen-devel] [OSSTEST PATCH 2/3] ms-planner: include PreviousShare information in Unshare events

2018-04-23 Thread Ian Jackson
We can't put this in $evt->{Share} because existing clients will see it there and assume it means the resource is shared. Signed-off-by: Ian Jackson --- ms-planner | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ms-planner b/ms-planner index af0c746..5d20cc2 100755 --- a/ms-planner +++ b/

Re: [Xen-devel] Setting up a call to discuss PCI Emulation - Future Direction

2018-04-23 Thread Lars Kurth
Alright: 17:00-18:00 it is. I will send out a separate mail with call-in details Lars On 23/04/2018, 15:24, "Chao Gao" wrote: On Mon, Apr 23, 2018 at 10:12:22PM +0800, Chao Gao wrote: >On Mon, Apr 23, 2018 at 08:26:59AM +, Lars Kurth wrote: >>Hi all, >>so it seems we have no

Re: [Xen-devel] [RFC v2 4/9] libxl_qmp: Move the buffer realloc to the same scope level as read

2018-04-23 Thread Wei Liu
On Mon, Apr 23, 2018 at 03:50:27PM +0100, Anthony PERARD wrote: > On Mon, Apr 23, 2018 at 10:03:39AM +0100, Wei Liu wrote: > > On Mon, Apr 16, 2018 at 06:32:22PM +0100, Anthony PERARD wrote: > > > In qmp_next(), the inner loop should only try to parse messages from > > > QMP, if there is more than

Re: [Xen-devel] [PATCH 03/16] xen: link against xentoolcore

2018-04-23 Thread Anthony PERARD
On Thu, Apr 19, 2018 at 05:45:06PM +0100, Ian Jackson wrote: > From: Anthony PERARD > > Xen libraries in 4.10 include a new xentoolcore library. This > contains the xentoolcore_restrict_all function which we are about to > want to use. > > Signed-off-by: Ian Jackson > Acked-by: Stefano Stabell

Re: [Xen-devel] [PATCH RFC 01/10] passthrough: rearrange x86 code

2018-04-23 Thread Jan Beulich
>>> On 21.02.18 at 22:46, wrote: > Clean up the hierarchy of the directory: put vtd, amd and io.c under > x86. Adjust makefile and MAINTAINERS. Considering the history in particular of VT-d, I'm not convinced of this move: x86 and ia64 did share the bulk of the VT-d code back when ia64 was still

Re: [Xen-devel] [PATCH RFC 02/10] passthrough: split out x86 PCI code to x86/pci.c

2018-04-23 Thread Jan Beulich
>>> On 21.02.18 at 22:46, wrote: > Move the functions that reference x86 hvm data structures to its own > file. Rename pci_clean_dpci_irqs to arch_pci_clean_irqs. > > There is still one location in that file which references > arch.hvm_domain, but it is fine because ARM guest is HVM. > > Signed

Re: [Xen-devel] [PATCH RFC 03/10] x86/passthrough: io.c is used for HVM only

2018-04-23 Thread Jan Beulich
>>> On 21.02.18 at 22:46, wrote: > Signed-off-by: Wei Liu > --- > This file has a few functions that are called in other places. We need > to provide stubs for them at some point. Currently the declarations > are in different places. What is the preferred name / location for the > stubs? Perhaps

Re: [Xen-devel] [PATCH 12/16] xen: Remove now-obsolete xen_xc_domain_add_to_physmap

2018-04-23 Thread Anthony PERARD
On Thu, Apr 19, 2018 at 05:45:15PM +0100, Ian Jackson wrote: > The last user was just removed; remove this function, accordingly. > > Signed-off-by: Ian Jackson Acked-by: Anthony PERARD -- Anthony PERARD ___ Xen-devel mailing list Xen-devel@lists.x

Re: [Xen-devel] [PATCH RFC 05/10] x86/passthrough: move hvm_dpci_isairq_eoi

2018-04-23 Thread Jan Beulich
>>> On 21.02.18 at 22:46, wrote: > This function is not Intel specific. Move it to io.c along side its > sole user. Remove declaration in iommu.h. > > Signed-off-by: Wei Liu Acked-by: Jan Beulich (with whatever path name adjustments are necessary depending on the disposition of patches earlier

Re: [Xen-devel] [PATCH RFC 07/10] passthrough/amd: split out hvm code from iommu_map.c

2018-04-23 Thread Jan Beulich
>>> On 21.02.18 at 22:46, wrote: > Move and rename update_paging_mode. Create a local header file for > this and other functions that need exporting. Functions you move into global name space need suitable prefixes - neither hvm_update_paging_mode() nor set_iommu_pde_present() clarify that this i

Re: [Xen-devel] [RFC v2 6/9] libxl: Have QEMU save its state to a file descriptor

2018-04-23 Thread Anthony PERARD
On Mon, Apr 23, 2018 at 10:20:42AM +0100, Wei Liu wrote: > On Mon, Apr 16, 2018 at 06:32:24PM +0100, Anthony PERARD wrote: > > In case QEMU have restricted access to the system, open the file for it, > > and QEMU will save its state to this file descritor. > > > > Signed-off-by: Anthony PERARD >

Re: [Xen-devel] [PATCH RFC 09/10] passthrough/intel: put some code under CONFIG_HVM

2018-04-23 Thread Jan Beulich
>>> On 21.02.18 at 22:47, wrote: > @@ -1873,6 +1876,7 @@ int iommu_pte_flush(struct domain *d, u64 gfn, u64 *pte, > return rc; > } > > +#ifdef CONFIG_HVM > static int __init vtd_ept_page_compatible(struct iommu *iommu) > { > u64 ept_cap, vtd_cap = iommu->cap; > @@ -1885,6 +1889,7 @@

Re: [Xen-devel] [PATCH RFC for-next] x86/mm: introduce and use virt_to_xen_l4e

2018-04-23 Thread Jan Beulich
>>> On 31.10.17 at 19:51, wrote: > Avoid open-coding in a lot of places. > > No functional change. > > Signed-off-by: Wei Liu > --- > Is this patch useful or is open-coding preferred? I think we want to revisit this when 5-level paging code arrives. Jan

Re: [Xen-devel] [PATCH 05/16] xen: defer call to xen_restrict until just before os_setup_post

2018-04-23 Thread Anthony PERARD
On Thu, Apr 19, 2018 at 05:45:08PM +0100, Ian Jackson wrote: > diff --git a/stubs/xen-hvm.c b/stubs/xen-hvm.c > index 0067bcc..7787ea2 100644 > --- a/stubs/xen-hvm.c > +++ b/stubs/xen-hvm.c > @@ -13,6 +13,7 @@ > #include "hw/xen/xen.h" > #include "exec/memory.h" > #include "qapi/qapi-commands-mi

Re: [Xen-devel] [RFC PATCH 1/8] x86/domctl: introduce a pair of hypercall to set and get cpu topology

2018-04-23 Thread Jan Beulich
>>> On 08.01.18 at 05:01, wrote: > Define interface, structures and hypercalls for toolstack to build > cpu topology and for guest that will retrieve it [1]. > Two subop hypercalls introduced by this patch: > XEN_DOMCTL_set_cpu_topology to define cpu topology information per domain > and XENMEM_ge

Re: [Xen-devel] [RFC PATCH 2/8] x86/vlapic: use apic_id array to set initial (x2)APIC ID

2018-04-23 Thread Jan Beulich
>>> On 08.01.18 at 05:01, wrote: > --- a/xen/include/asm-x86/hvm/domain.h > +++ b/xen/include/asm-x86/hvm/domain.h > @@ -213,6 +213,9 @@ struct hvm_domain { > uint8_t thread_per_core; > }; > > +#define hvm_vcpu_x2apic_id(v) > (v->domain->arch.hvm_domain.apic_id[v->vcpu_id]) I can't seem

Re: [Xen-devel] Xen and safety certification, Minutes of the meeting on Apr 4th (Notes on MISRA, ISO 26262 static code analysis requirements)

2018-04-23 Thread Lars Kurth
Hi all, On 06/04/2018, 15:13, "Lars Kurth" wrote: > 1) Requirements to the code, a subset of MISRA for ASIL B > Next step: get more information about requirements and publish it to > xen-devel. I see a few problems here: * The MISRA 2012 spec has to be bought

Re: [Xen-devel] [PATCH 16/16] configure: do_compiler: Dump some extra info under bash

2018-04-23 Thread Anthony PERARD
On Thu, Apr 19, 2018 at 05:45:19PM +0100, Ian Jackson wrote: > This makes it much easier to find a particular thing in config.log. > > The information may be lacking in other shells, resulting in harmless > empty output. (This is why we don't use the proper ${FUNCNAME[*]} > array syntax - other s

Re: [Xen-devel] [Qemu-devel] [PATCH 16/16] configure: do_compiler: Dump some extra info under bash

2018-04-23 Thread Daniel P . Berrangé
On Mon, Apr 23, 2018 at 05:21:42PM +0100, Anthony PERARD wrote: > On Thu, Apr 19, 2018 at 05:45:19PM +0100, Ian Jackson wrote: > > This makes it much easier to find a particular thing in config.log. > > > > The information may be lacking in other shells, resulting in harmless > > empty output. (T

Re: [Xen-devel] [PATCH 16/16] configure: do_compiler: Dump some extra info under bash

2018-04-23 Thread Ian Jackson
Anthony PERARD writes ("Re: [PATCH 16/16] configure: do_compiler: Dump some extra info under bash"): > On Thu, Apr 19, 2018 at 05:45:19PM +0100, Ian Jackson wrote: > > +funcs: ${FUNCNAME} > > +lines: ${BASH_LINENO} > > +files: ${BASH_SOURCE}" > > echo $compiler "$@" >> config.log > > $co

[Xen-devel] [xen-unstable-smoke test] 122371: tolerable all pass - PUSHED

2018-04-23 Thread osstest service owner
flight 122371 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/122371/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [RFC v2 8/9] HACK libxl_exec: Check QEMU status via QMP instead of xenstore

2018-04-23 Thread Anthony PERARD
On Fri, Apr 20, 2018 at 07:37:17PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("[RFC v2 8/9] HACK libxl_exec: Check QEMU status via > QMP instead of xenstore"): > > When QEMU is restricted, the qemu on the receiving side cann't write > > anything to xenstore once the migration is started. S

Re: [Xen-devel] [RFC v2 8/9] HACK libxl_exec: Check QEMU status via QMP instead of xenstore

2018-04-23 Thread Ian Jackson
Anthony PERARD writes ("Re: [RFC v2 8/9] HACK libxl_exec: Check QEMU status via QMP instead of xenstore"): > But, with the to be release QEMU 2.12, there is a new interface that > allow to pre-open a socket: > -chardev socket,fd=? > See > https://git.qemu.org/?p=qemu.git;a=commit;h=0935700f8544

Re: [Xen-devel] [Qemu-devel] [PATCH 16/16] configure: do_compiler: Dump some extra info under bash

2018-04-23 Thread Ian Jackson
Daniel P. Berrangé writes ("Re: [Qemu-devel] [PATCH 16/16] configure: do_compiler: Dump some extra info under bash"): > Personally I'd suggest we add informative messages throughout the > configure script for each check being run. If people really hate the > idea of a verbose output from configure

Re: [Xen-devel] [PATCH v2 03/10] xen/arm: Implement CPU_OFF PSCI call (physical interface)

2018-04-23 Thread Mirela Simonovic
Hi Julien, On Mon, Apr 23, 2018 at 1:21 PM, Julien Grall wrote: > Hi Mirela, > > On 20/04/18 13:25, Mirela Simonovic wrote: >> >> During the system suspend to RAM non-boot CPUs will be hotplugged. >> This will be triggered via disable_nonboot_cpus() call. When >> hotplugged the CPU will end up in

Re: [Xen-devel] [PATCH v2 03/10] xen/arm: Implement CPU_OFF PSCI call (physical interface)

2018-04-23 Thread Julien Grall
On 23/04/18 18:12, Mirela Simonovic wrote: On Mon, Apr 23, 2018 at 1:21 PM, Julien Grall wrote: On 20/04/18 13:25, Mirela Simonovic wrote: +if ( errno ) +panic("PSCI cpu off failed for CPU%d err=%d\n", get_processor_id(), + errno); +} + void call_psci_system_off(v

Re: [Xen-devel] Graduation Review: Windows PV Driver

2018-04-23 Thread Lars Kurth
The attachment is also at https://wiki.xenproject.org/images/c/cf/Windows_PV_Driver_-_Graduation_Proposal.pdf Lars > On 23 Apr 2018, at 18:14, Lars Kurth wrote: > > Dear Community members, > please find attached (and in markdown, but without graphs) the case to > graduate the Windows PV Driver

Re: [Xen-devel] [PATCH 0/6] arm: more kconfig configurability and small default configs

2018-04-23 Thread Andrii Anisov
Hello Stefano, I'm really glad to see this series. In the list of platform-specific bits you are trying to make selectable, you missed platform support code itself. Moreover, as it is said in your follow-up emails, set of UART, IOMMU, GIC is defined by SoC family. So wouldn't it be more natur

Re: [Xen-devel] [PATCH 0/6] arm: more kconfig configurability and small default configs

2018-04-23 Thread Andrii Anisov
Hello Stefano, I'm really glad to see this series. In the list of platform-specific bits you are trying to make selectable, you missed platform support code itself. Moreover, as it is said in your follow-up emails, set of UART, IOMMU, GIC is defined by SoC family. So wouldn't it be more natur

Re: [Xen-devel] [PATCH 3/6] arm: make it possible to disable the SMMU driver

2018-04-23 Thread Andrii Anisov
Hello Stefano, On 20.04.18 01:43, Stefano Stabellini wrote: Let's take this example: SMMUv2. The driver is decently quality, and definitely some boards will require it. It makes sense to security support it. However, some boards don't come with an SMMU at all, such as Pine64 I guess arm passth

Re: [Xen-devel] [PATCH 4/6] arm: add a small kconfig for Renesas RCar H3

2018-04-23 Thread Andrii Anisov
Hello Stefano, If we stick with platform specific configuration file: On 19.04.18 01:15, Stefano Stabellini wrote: This is a reference tiny kconfig for Renesas RCar. In terms of schedulers, it selects credit and NULL only. It enables all the ARM64 errata. Signed-off-by: Stefano Stabellini

Re: [Xen-devel] [PATCH v2] Input: xen-kbdfront - allow better run-time configuration

2018-04-23 Thread Jason Andryuk
Hi, Oleksandr. On Thu, Apr 19, 2018 at 9:39 AM, Oleksandr Andrushchenko wrote: > @@ -241,60 +242,84 @@ static int xenkbd_probe(struct xenbus_device *dev, > } > > /* keyboard */ > - kbd = input_allocate_device(); > - if (!kbd) > - goto error_nomem; > -

[Xen-devel] [examine test] 122372: tolerable ALL FAIL

2018-04-23 Thread osstest service owner
flight 122372 examine real [real] http://logs.test-lab.xenproject.org/osstest/logs/122372/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: examine-laxton0 2 hosts-allocatebroken blocked in 121088 examine-rimava0 2 hosts-all

Re: [Xen-devel] [PATCH] Input: xen-kbdfront - allow better run-time configuration

2018-04-23 Thread Dmitry Torokhov
On Thu, Apr 19, 2018 at 02:44:19PM +0300, Oleksandr Andrushchenko wrote: > On 04/19/2018 02:25 PM, Juergen Gross wrote: > > On 18/04/18 17:04, Oleksandr Andrushchenko wrote: > > > From: Oleksandr Andrushchenko > > > > > > It is now only possible to control if multi-touch virtual device > > > is c

Re: [Xen-devel] [PATCH v2] Input: xen-kbdfront - allow better run-time configuration

2018-04-23 Thread Dmitry Torokhov
On Mon, Apr 23, 2018 at 11:29:45AM +0300, Oleksandr Andrushchenko wrote: > On 04/23/2018 11:23 AM, Juergen Gross wrote: > > On 23/04/18 10:02, Oleksandr Andrushchenko wrote: > > > Juergen, Jason, Dmitry > > > any comment on this? > > Oleksandr, please give us some time. I can't speak for others, bu

Re: [Xen-devel] [PATCH 2/8] x86/HVM/SVM: Add AVIC initialization code

2018-04-23 Thread Konrad Rzeszutek Wilk
> +++ b/xen/arch/x86/hvm/svm/avic.c > @@ -0,0 +1,191 @@ > +/* > + * avic.c: implements AMD Advanced Virtual Interrupt Controller (AVIC) > support > + * Copyright (c) 2016, Advanced Micro Devices, Inc. Not 2018? ___ Xen-devel mailing list Xen-devel@list

Re: [Xen-devel] [PATCH 2/8] x86/HVM/SVM: Add AVIC initialization code

2018-04-23 Thread Natarajan, Janakarajan
On 4/23/2018 2:33 PM, Konrad Rzeszutek Wilk wrote: +++ b/xen/arch/x86/hvm/svm/avic.c @@ -0,0 +1,191 @@ +/* + * avic.c: implements AMD Advanced Virtual Interrupt Controller (AVIC) support + * Copyright (c) 2016, Advanced Micro Devices, Inc. Not 2018? Ah good catch. Yeah it should be 2018. _

Re: [Xen-devel] [Qemu-devel] [PATCH 16/16] configure: do_compiler: Dump some extra info under bash

2018-04-23 Thread Eric Blake
On 04/23/2018 11:38 AM, Ian Jackson wrote: > You are right. Perhaps my testing was inadequate. I wrote this a > long while ago, and if there was a syntax along these lines that DTRT > in both bash and dash in my tests it is long gone. Starting de novo, > the following code works for me: > >

[Xen-devel] [linux-4.14 baseline test] 122368: tolerable FAIL

2018-04-23 Thread osstest service owner
"Old" tested version had not actually been tested; therefore in this flight we test it, rather than a new candidate. The baseline, if any, is the most recent actually tested revision. flight 122368 linux-4.14 real [real] http://logs.test-lab.xenproject.org/osstest/logs/122368/ Failures :-/ but n

  1   2   >