Re: [Xen-devel] [PATCH for-4.11] x86/SVM: Fix intercepted {RD, WR}MSR for the SYS{CALL, ENTER} MSRs

2018-04-24 Thread Juergen Gross
On 24/04/18 20:51, Andrew Cooper wrote: > By default, the SYSCALL MSRs are not intercepted, and accesses are completed > by hardware. The SYSENTER MSRs are intercepted for cross-vendor > purposes (albeit needlessly in the common case), and are fully emulated. > > However, {RD,WR}MSR instructions

Re: [Xen-devel] [Qemu-devel] [PATCH 09/16] os-posix: cleanup: Replace fprintfs with error_report in change_process_uid

2018-04-24 Thread Thomas Huth
On 24.04.2018 19:58, Ian Jackson wrote: > I'm going to be editing this function and it makes sense to clean up > this style problem in advance. > > Signed-off-by: Ian Jackson > CC: Paolo Bonzini > CC: Markus Armbruster > CC:

Re: [Xen-devel] [Qemu-devel] [PATCH 14/16] os-posix: cleanup: Replace fprintf with error_report in remaining call sites

2018-04-24 Thread Thomas Huth
On 24.04.2018 19:58, Ian Jackson wrote: > Signed-off-by: Ian Jackson > CC: Paolo Bonzini > CC: Markus Armbruster > CC: Daniel P. Berrange > CC: Michael Tokarev > Reviewed-by: Philippe

Re: [Xen-devel] [PATCH 16/16] configure: do_compiler: Dump some extra info under bash

2018-04-24 Thread Thomas Huth
On 24.04.2018 19:58, Ian Jackson wrote: > This makes it much easier to find a particular thing in config.log. > > We have to use the ${BASH_LINENO[*]} syntax which is a syntax error in > other shells, so test what shell we are running and use eval. > > The extra output is only printed if

[Xen-devel] [xen-unstable test] 122363: regressions - FAIL

2018-04-24 Thread osstest service owner
flight 122363 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/122363/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 16 guest-localmigrate/x10 fail REGR. vs. 122343

Re: [Xen-devel] [PATCH for-4.11] x86/SVM: Fix intercepted {RD, WR}MSR for the SYS{CALL, ENTER} MSRs

2018-04-24 Thread Boris Ostrovsky
On 04/24/2018 02:51 PM, Andrew Cooper wrote: > By default, the SYSCALL MSRs are not intercepted, and accesses are completed > by hardware. The SYSENTER MSRs are intercepted for cross-vendor > purposes (albeit needlessly in the common case), and are fully emulated. > > However, {RD,WR}MSR

Re: [Xen-devel] [PATCH 15/16] os-posix: cleanup: Replace perror with error_report

2018-04-24 Thread Alistair Francis
On Tue, Apr 24, 2018 at 10:58 AM, Ian Jackson wrote: > perror() is defined to fprintf(stderr,...). HACKING says > fprintf(stderr,...) is wrong. So perror() is too. > > Signed-off-by: Ian Jackson > CC: Paolo Bonzini >

Re: [Xen-devel] [PATCH 0/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver

2018-04-24 Thread Dongwon Kim
Had a meeting with Daniel and talked about bringing out generic part of hyper-dmabuf to the userspace, which means we most likely reuse IOCTLs defined in xen-zcopy for our use-case if we follow his suggestion. So assuming we use these IOCTLs as they are, Several things I would like you to

[Xen-devel] [ovmf baseline-only test] 74639: all pass

2018-04-24 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 74639 ovmf real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/74639/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf ee4dc24f57c32a445e7c747396c9bfbd8b221568 baseline

[Xen-devel] [linux-4.9 test] 122360: regressions - trouble: broken/fail/pass

2018-04-24 Thread osstest service owner
flight 122360 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/122360/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-win10-i386 broken

[Xen-devel] [qemu-mainline baseline-only test] 74638: tolerable FAIL

2018-04-24 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 74638 qemu-mainline real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/74638/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win10-i386 10 windows-install fail

Re: [Xen-devel] [Qemu-devel] [PATCH 09/16] os-posix: cleanup: Replace fprintfs with error_report in change_process_uid

2018-04-24 Thread Peter Maydell
On 24 April 2018 at 18:58, Ian Jackson wrote: > I'm going to be editing this function and it makes sense to clean up > this style problem in advance. > > Signed-off-by: Ian Jackson > CC: Paolo Bonzini > CC: Markus

[Xen-devel] [PATCH for-4.11] x86/SVM: Fix intercepted {RD, WR}MSR for the SYS{CALL, ENTER} MSRs

2018-04-24 Thread Andrew Cooper
By default, the SYSCALL MSRs are not intercepted, and accesses are completed by hardware. The SYSENTER MSRs are intercepted for cross-vendor purposes (albeit needlessly in the common case), and are fully emulated. However, {RD,WR}MSR instructions which happen to be emulated (FEP, introspection,

[Xen-devel] [ovmf test] 122362: all pass - PUSHED

2018-04-24 Thread osstest service owner
flight 122362 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/122362/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf ee4dc24f57c32a445e7c747396c9bfbd8b221568 baseline version: ovmf

[Xen-devel] [PATCH 11/16] xen: Use newly added dmops for mapping VGA memory

2018-04-24 Thread Ian Jackson
From: Ross Lagerwall Xen unstable (to be in 4.11) has two new dmops, relocate_memory and pin_memory_cacheattr. Use these to set up the VGA memory, replacing the previous calls to libxc. This allows the VGA console to work properly when QEMU is running restricted

[Xen-devel] [PATCH 07/16] xen: move xc_interface compatibility fallback further up the file

2018-04-24 Thread Ian Jackson
We are going to want to use the dummy xendevicemodel_handle type in new stub functions in the CONFIG_XEN_CTRL_INTERFACE_VERSION < 41000 section. So we need to provide that definition, or (as applicable) include the appropriate header, earlier in the file. (Ideally the newer compatibility layers

[Xen-devel] [PATCH 05/16] xen: defer call to xen_restrict until just before os_setup_post

2018-04-24 Thread Ian Jackson
We need to restrict *all* the control fds that qemu opens. Looking in /proc/PID/fd shows there are many; their allocation seems scattered throughout Xen support code in qemu. We must postpone the restrict call until roughly the same time as qemu changes its uid, chroots (if applicable), and so

[Xen-devel] [PATCH 06/16] xen: destroy_hvm_domain: Move reason into a variable

2018-04-24 Thread Ian Jackson
We are going to want to reuse this. No functional change. Signed-off-by: Ian Jackson Reviewed-by: Anthony PERARD Acked-by: Stefano Stabellini --- hw/i386/xen/xen-hvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[Xen-devel] [PATCH 14/16] os-posix: cleanup: Replace fprintf with error_report in remaining call sites

2018-04-24 Thread Ian Jackson
Signed-off-by: Ian Jackson CC: Paolo Bonzini CC: Markus Armbruster CC: Daniel P. Berrange CC: Michael Tokarev Reviewed-by: Philippe Mathieu-Daudé --- v8: Remove one

[Xen-devel] [PATCH 04/16] xen: restrict: use xentoolcore_restrict_all

2018-04-24 Thread Ian Jackson
And insist that it works. Drop individual use of xendevicemodel_restrict and xenforeignmemory_restrict. These are not actually effective in this version of qemu, because qemu has a large number of fds open onto various Xen control devices. The restriction arrangements are still not right,

[Xen-devel] [PATCH v8 00/16] xen: xen-domid-restrict improvements

2018-04-24 Thread Ian Jackson
This series provides necessary support for running qemu as a Xen device model without power equivalent to root. In particular, it makes -xen-domid-restrict effective. Compared to v8, it addresses review comments. 01/16 checkpatch: Add xendevicemodel_handle to the list of r 02/16

[Xen-devel] [PATCH 15/16] os-posix: cleanup: Replace perror with error_report

2018-04-24 Thread Ian Jackson
perror() is defined to fprintf(stderr,...). HACKING says fprintf(stderr,...) is wrong. So perror() is too. Signed-off-by: Ian Jackson CC: Paolo Bonzini CC: Markus Armbruster CC: Daniel P. Berrange CC:

[Xen-devel] [PATCH 03/16] xen: link against xentoolcore

2018-04-24 Thread Ian Jackson
From: Anthony PERARD Xen libraries in 4.10 include a new xentoolcore library. This contains the xentoolcore_restrict_all function which we are about to want to use. Signed-off-by: Ian Jackson Acked-by: Stefano Stabellini

[Xen-devel] [PATCH 02/16] AccelClass: Introduce accel_setup_post

2018-04-24 Thread Ian Jackson
This is called just before os_setup_post. Currently none of the accelerators provide this hook, but the Xen one is going to provide one in a moment. Signed-off-by: Ian Jackson Reviewed-by: Eduardo Habkost --- v7: New patch in this version of the

[Xen-devel] [PATCH 10/16] os-posix: Provide new -runas : facility

2018-04-24 Thread Ian Jackson
This allows the caller to specify a uid and gid to use, even if there is no corresponding password entry. This will be useful in certain Xen configurations. We don't support just -runas because: (i) deprivileging without calling setgroups would be ineffective (ii) given only a uid we don't know

[Xen-devel] [PATCH 13/16] xen: Expect xenstore write to fail when restricted

2018-04-24 Thread Ian Jackson
From: Ross Lagerwall Saving the current state to xenstore may fail when running restricted (in particular, after a migration). Therefore, don't report the error or exit when running restricted. Toolstacks that want to allow running QEMU restricted should instead make

[Xen-devel] [PATCH 01/16] checkpatch: Add xendevicemodel_handle to the list of types

2018-04-24 Thread Ian Jackson
This avoids checkpatch misparsing (as statements) long function definitions or declarations, which sometimes start with constructs like this: static inline int xendevicemodel_relocate_memory( xendevicemodel_handle *dmod, domid_t domid, ... The type xendevicemodel_handle does not conform

[Xen-devel] [PATCH 16/16] configure: do_compiler: Dump some extra info under bash

2018-04-24 Thread Ian Jackson
This makes it much easier to find a particular thing in config.log. We have to use the ${BASH_LINENO[*]} syntax which is a syntax error in other shells, so test what shell we are running and use eval. The extra output is only printed if configure is run with bash. On systems where /bin/sh is

[Xen-devel] [PATCH 08/16] xen: destroy_hvm_domain: Try xendevicemodel_shutdown

2018-04-24 Thread Ian Jackson
xc_interface_open etc. is not going to work if we have dropped privilege, but xendevicemodel_shutdown will if everything is new enough. xendevicemodel_shutdown is only availabe in Xen 4.10 and later, so provide a stub for earlier versions. Signed-off-by: Ian Jackson

[Xen-devel] [PATCH 12/16] xen: Remove now-obsolete xen_xc_domain_add_to_physmap

2018-04-24 Thread Ian Jackson
The last user was just removed; remove this function, accordingly. Signed-off-by: Ian Jackson Acked-by: Anthony PERARD --- include/hw/xen/xen_common.h | 22 -- 1 file changed, 22 deletions(-) diff --git

[Xen-devel] [PATCH 09/16] os-posix: cleanup: Replace fprintfs with error_report in change_process_uid

2018-04-24 Thread Ian Jackson
I'm going to be editing this function and it makes sense to clean up this style problem in advance. Signed-off-by: Ian Jackson CC: Paolo Bonzini CC: Markus Armbruster CC: Daniel P. Berrange CC: Michael

[Xen-devel] [xtf test] 122361: all pass - PUSHED

2018-04-24 Thread osstest service owner
flight 122361 xtf real [real] http://logs.test-lab.xenproject.org/osstest/logs/122361/ Perfect :-) All tests in this flight passed as required version targeted for testing: xtf c3a84a8f7cedd97b34139cb6abde62f17b9d2b1c baseline version: xtf

Re: [Xen-devel] [PATCH v2 02/10] xen/arm: Ignore write to GICD_ISACTIVERn registers (vgic-v2)

2018-04-24 Thread Mirela Simonovic
Hi Julien, Thank you for the feedback, we have a v3 agreement. On Tue, Apr 24, 2018 at 6:12 PM, Julien Grall wrote: > Hi Mirela, > > > On 04/24/2018 12:02 PM, Mirela Simonovic wrote: >> >> Hi Julien, >> >> On Mon, Apr 23, 2018 at 1:15 PM, Julien Grall

[Xen-devel] 4.11.0 RC1 panic

2018-04-24 Thread Manuel Bouyer
Hello, I tested xen 4.11.0 rc1 with NetBSD as dom0. I could boot a NetBSD PV domU without problem, but at shutdown time (poweroff in the domU), I got a Xen panic: (XEN) Assertion 'cpu < nr_cpu_ids' failed at ...1/work/xen-4.11.0-rc1/xen/include/xen/cpumask.h:97 A xl destroy instead of poweroff

[Xen-devel] [linux-linus test] 122358: regressions - FAIL

2018-04-24 Thread osstest service owner
flight 122358 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/122358/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 10 debian-install fail REGR. vs. 118324

Re: [Xen-devel] [PATCH v2 05/10] xen/arm: Setup virtual paging for non-boot CPUs on hotplug/resume

2018-04-24 Thread Julien Grall
On 04/24/2018 03:50 PM, Mirela Simonovic wrote: Hi Julien, Hi Mirela, Thanks for the feedback. On Mon, Apr 23, 2018 at 1:28 PM, Julien Grall wrote: Hi Mirela, On 20/04/18 13:25, Mirela Simonovic wrote: In existing code the paging for non-boot CPUs is setup only

Re: [Xen-devel] [PATCH v2 3/5] ALSA: xen-front: Implement Xen event channel handling

2018-04-24 Thread Oleksandr Andrushchenko
On 04/24/2018 06:02 PM, Takashi Iwai wrote: On Tue, 24 Apr 2018 16:58:43 +0200, Oleksandr Andrushchenko wrote: On 04/24/2018 05:35 PM, Takashi Iwai wrote: On Tue, 24 Apr 2018 16:29:15 +0200, Oleksandr Andrushchenko wrote: On 04/24/2018 05:20 PM, Takashi Iwai wrote: On Mon, 16 Apr 2018

Re: [Xen-devel] [PATCH 4/6] arm: add a small kconfig for Renesas RCar H3

2018-04-24 Thread Julien Grall
Hi, On 04/24/2018 03:18 PM, Andrii Anisov wrote: Can you quantify what would be the cost of keeping that code around for IOMMU-less platform? I'm not sure I understand your question. Do you mean a number of loc of the passthrough feature for arm? I meant that disabling something in Xen

Re: [Xen-devel] [Qemu-devel] [PATCH 15/16] os-posix: cleanup: Replace perror with error_report

2018-04-24 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 04/19/2018 01:45 PM, Ian Jackson wrote: >> perror() is defined to fprintf(stderr,...). HACKING says >> fprintf(stderr,...) is wrong. So perror() is too. >> >> Signed-off-by: Ian Jackson >> CC: Paolo Bonzini

Re: [Xen-devel] [PATCH 2/2] Add Brian Woods as Designated reviewer to AMD IOMMU and AMD SVM

2018-04-24 Thread Brian Woods
On Tue, Apr 24, 2018 at 04:56:23PM +0100, Lars Kurth wrote: > This was discussed in an IRC discussion post the April x86 meeting. > > Signed-off-by: Lars Kurth > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS >

Re: [Xen-devel] [PATCH v2 02/10] xen/arm: Ignore write to GICD_ISACTIVERn registers (vgic-v2)

2018-04-24 Thread Julien Grall
Hi Mirela, On 04/24/2018 12:02 PM, Mirela Simonovic wrote: Hi Julien, On Mon, Apr 23, 2018 at 1:15 PM, Julien Grall wrote: Hi Mirela, On 20/04/18 13:25, Mirela Simonovic wrote: Guests attempt to write into these registers on resume (for example Linux). Without this

[Xen-devel] [PATCH 2/2] Add Brian Woods as Designated reviewer to AMD IOMMU and AMD SVM

2018-04-24 Thread Lars Kurth
This was discussed in an IRC discussion post the April x86 meeting. Signed-off-by: Lars Kurth --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index cc1fdc013f..fab76b0af4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -144,12

[Xen-devel] [PATCH 0/2] Add Designated Reviewer (R:) to MAINTAINERS (plus a test case)

2018-04-24 Thread Lars Kurth
This follows up from a conversation after the April x86 community call, in which I had the following action: Lars to propose fixing CC issue in xen.git:MAINTAINERS copying the R section entries from Linux.git:MAINTAINERS (will need changes to get_maintainers.pl also) Lars Kurth (2): Add

[Xen-devel] [PATCH 1/2] Add Designated Reviewer (R:) to MAINTAINERS file and add support for it in get_maintainer.pl

2018-04-24 Thread Lars Kurth
The syntax has been copied from the Linux Maintainers file. I moved the following Linux get_maintainer.pl patches to Xen, fixing up some merge issues (and a bug). The get_maintainer.pl changes were based on the following git commits *

Re: [Xen-devel] [Qemu-devel] [PATCH 15/16] os-posix: cleanup: Replace perror with error_report

2018-04-24 Thread Daniel P . Berrangé
On Tue, Apr 24, 2018 at 10:43:09AM -0500, Eric Blake wrote: > On 04/24/2018 10:40 AM, Eric Blake wrote: > > On 04/24/2018 10:18 AM, Daniel P. Berrangé wrote: > > > >>> - static void vreport(report_type type, const char *fmt, va_list ap) > >>> + static void vreport(report_type type, int

Re: [Xen-devel] [Qemu-devel] [PATCH 15/16] os-posix: cleanup: Replace perror with error_report

2018-04-24 Thread Eric Blake
On 04/24/2018 10:40 AM, Eric Blake wrote: > On 04/24/2018 10:18 AM, Daniel P. Berrangé wrote: > >>> - static void vreport(report_type type, const char *fmt, va_list ap) >>> + static void vreport(report_type type, int errnoval, const char *fmt, >>> va_list ap) >>> ... >>> + if (errnoval >=

Re: [Xen-devel] [Qemu-devel] [PATCH 15/16] os-posix: cleanup: Replace perror with error_report

2018-04-24 Thread Eric Blake
On 04/24/2018 10:18 AM, Daniel P. Berrangé wrote: >> - static void vreport(report_type type, const char *fmt, va_list ap) >> + static void vreport(report_type type, int errnoval, const char *fmt, >> va_list ap) >> ... >> + if (errnoval >= 0) { >> + error_printf(": %s",

Re: [Xen-devel] [Qemu-devel] [PATCH 15/16] os-posix: cleanup: Replace perror with error_report

2018-04-24 Thread Daniel P . Berrangé
On Tue, Apr 24, 2018 at 03:53:48PM +0100, Ian Jackson wrote: > Philippe Mathieu-Daudé writes ("Re: [Qemu-devel] [PATCH 15/16] os-posix: > cleanup: Replace perror with error_report"): > > On 04/19/2018 01:45 PM, Ian Jackson wrote: > > > -perror("mlockall"); > > > +

Re: [Xen-devel] [PATCH 05/16] xen: defer call to xen_restrict until just before os_setup_post

2018-04-24 Thread Ian Jackson
Anthony PERARD writes ("Re: [PATCH 05/16] xen: defer call to xen_restrict until just before os_setup_post"): > I think this include is not needed anymore, and can go away from the > patch series. Yes. Thanks, Ian. ___ Xen-devel mailing list

Re: [Xen-devel] [Qemu-devel] [PATCH 16/16] configure: do_compiler: Dump some extra info under bash

2018-04-24 Thread Ian Jackson
Eric Blake writes ("Re: [Qemu-devel] [PATCH 16/16] configure: do_compiler: Dump some extra info under bash"): > That's still fork-heavy. You could do: > > test -n "$BASH_VERSION" && eval ' > echo >>config.log " > funcs: ${FUNCNAME[*]} > lines: ${BASH_LINENO[*]} > files: ${BASH_SOURCE[*]}"' > >

Re: [Xen-devel] [PATCH v2 3/5] ALSA: xen-front: Implement Xen event channel handling

2018-04-24 Thread Takashi Iwai
On Tue, 24 Apr 2018 16:58:43 +0200, Oleksandr Andrushchenko wrote: > > On 04/24/2018 05:35 PM, Takashi Iwai wrote: > > On Tue, 24 Apr 2018 16:29:15 +0200, > > Oleksandr Andrushchenko wrote: > >> On 04/24/2018 05:20 PM, Takashi Iwai wrote: > >>> On Mon, 16 Apr 2018 08:24:51 +0200, > >>> Oleksandr

Re: [Xen-devel] [PATCH v2 3/5] ALSA: xen-front: Implement Xen event channel handling

2018-04-24 Thread Oleksandr Andrushchenko
On 04/24/2018 05:35 PM, Takashi Iwai wrote: On Tue, 24 Apr 2018 16:29:15 +0200, Oleksandr Andrushchenko wrote: On 04/24/2018 05:20 PM, Takashi Iwai wrote: On Mon, 16 Apr 2018 08:24:51 +0200, Oleksandr Andrushchenko wrote: +static irqreturn_t evtchnl_interrupt_req(int irq, void *dev_id) +{ +

Re: [Xen-devel] [Qemu-devel] [PATCH 15/16] os-posix: cleanup: Replace perror with error_report

2018-04-24 Thread Ian Jackson
Philippe Mathieu-Daudé writes ("Re: [Qemu-devel] [PATCH 15/16] os-posix: cleanup: Replace perror with error_report"): > On 04/19/2018 01:45 PM, Ian Jackson wrote: > > -perror("mlockall"); > > +error_report("mlockall: %s", strerror(errno)); > > } > > > > return ret; >

Re: [Xen-devel] [PATCH v2 05/10] xen/arm: Setup virtual paging for non-boot CPUs on hotplug/resume

2018-04-24 Thread Mirela Simonovic
Hi Julien, Thanks for the feedback. On Mon, Apr 23, 2018 at 1:28 PM, Julien Grall wrote: > Hi Mirela, > > > On 20/04/18 13:25, Mirela Simonovic wrote: >> >> In existing code the paging for non-boot CPUs is setup only on boot. The >> setup is triggered from start_xen()

[Xen-devel] [xen-unstable-smoke test] 122392: tolerable all pass - PUSHED

2018-04-24 Thread osstest service owner
flight 122392 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/122392/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] [PATCH v2 3/5] ALSA: xen-front: Implement Xen event channel handling

2018-04-24 Thread Takashi Iwai
On Tue, 24 Apr 2018 16:29:15 +0200, Oleksandr Andrushchenko wrote: > > On 04/24/2018 05:20 PM, Takashi Iwai wrote: > > On Mon, 16 Apr 2018 08:24:51 +0200, > > Oleksandr Andrushchenko wrote: > >> +static irqreturn_t evtchnl_interrupt_req(int irq, void *dev_id) > >> +{ > >> + struct

Re: [Xen-devel] [PATCH v2 3/5] ALSA: xen-front: Implement Xen event channel handling

2018-04-24 Thread Oleksandr Andrushchenko
On 04/24/2018 05:20 PM, Takashi Iwai wrote: On Mon, 16 Apr 2018 08:24:51 +0200, Oleksandr Andrushchenko wrote: +static irqreturn_t evtchnl_interrupt_req(int irq, void *dev_id) +{ + struct xen_snd_front_evtchnl *channel = dev_id; + struct xen_snd_front_info *front_info =

Re: [Xen-devel] [PATCH 03/16] xen: link against xentoolcore

2018-04-24 Thread Ian Jackson
Anthony PERARD writes ("Re: [PATCH 03/16] xen: link against xentoolcore"): > On Thu, Apr 19, 2018 at 05:45:06PM +0100, Ian Jackson wrote: > > xen_pc="xencontrol xenstore xenguest xenforeignmemory xengnttab" > > -xen_pc="$xen_pc xenevtchn xendevicemodel" > > +xen_pc="$xen_pc xenevtchn

Re: [Xen-devel] [PATCH v2 3/5] ALSA: xen-front: Implement Xen event channel handling

2018-04-24 Thread Takashi Iwai
On Mon, 16 Apr 2018 08:24:51 +0200, Oleksandr Andrushchenko wrote: > +static irqreturn_t evtchnl_interrupt_req(int irq, void *dev_id) > +{ > + struct xen_snd_front_evtchnl *channel = dev_id; > + struct xen_snd_front_info *front_info = channel->front_info; > + struct xensnd_resp *resp;

Re: [Xen-devel] [PATCH 4/6] arm: add a small kconfig for Renesas RCar H3

2018-04-24 Thread Andrii Anisov
Can you quantify what would be the cost of keeping that code around for IOMMU-less platform? I'm not sure I understand your question. Do you mean a number of loc of the passthrough feature for arm? -- *Andrii Anisov* ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH v2 1/5] ALSA: xen-front: Introduce Xen para-virtualized sound frontend driver

2018-04-24 Thread Oleksandr Andrushchenko
On 04/24/2018 04:55 PM, Takashi Iwai wrote: On Mon, 16 Apr 2018 08:24:49 +0200, Oleksandr Andrushchenko wrote: --- /dev/null +++ b/sound/xen/Kconfig @@ -0,0 +1,10 @@ +# ALSA Xen drivers + +config SND_XEN_FRONTEND + tristate "Xen para-virtualized sound frontend driver" + depends on

Re: [Xen-devel] [PATCH v2 1/5] ALSA: xen-front: Introduce Xen para-virtualized sound frontend driver

2018-04-24 Thread Takashi Iwai
On Mon, 16 Apr 2018 08:24:49 +0200, Oleksandr Andrushchenko wrote: > --- /dev/null > +++ b/sound/xen/Kconfig > @@ -0,0 +1,10 @@ > +# ALSA Xen drivers > + > +config SND_XEN_FRONTEND > + tristate "Xen para-virtualized sound frontend driver" > + depends on XEN && SND_PCM Please do select

Re: [Xen-devel] [PATCH for-4.11] x86/spec_ctrl: Fix typo in ARCH_CAPS decode

2018-04-24 Thread Andrew Cooper
On 24/04/18 14:35, Konrad Rzeszutek Wilk wrote: > On April 24, 2018 5:44:33 AM EDT, Andrew Cooper > wrote: >> Signed-off-by: Andrew Cooper >> --- >> CC: Jan Beulich >> CC: Juergen Gross > > You are

Re: [Xen-devel] [PATCH for-4.11] x86/spec_ctrl: Fix typo in ARCH_CAPS decode

2018-04-24 Thread Konrad Rzeszutek Wilk
On April 24, 2018 5:44:33 AM EDT, Andrew Cooper wrote: >Signed-off-by: Andrew Cooper >--- >CC: Jan Beulich >CC: Juergen Gross You are missing an Reported-by.. Also pls Reviewed-by: Konrad Rzeszutek

Re: [Xen-devel] [RFC PATCH 1/1] xen: credit2: rb-tree for runqueues

2018-04-24 Thread Praveen Kumar
On Tuesday 24 April 2018 04:33 PM, Dario Faggioli wrote: On Tue, 2018-04-24 at 14:30 +0530, Praveen Kumar wrote: Hi Dario, Hi! On Tuesday 17 April 2018 04:16 PM, Dario Faggioli wrote: On Tue, 2018-04-03 at 22:25 +0530, Praveen Kumar wrote: +if ( svc->credit < entry->credit ) +

Re: [Xen-devel] [PATCH] xen-netfront: fix xennet_start_xmit()'s return type

2018-04-24 Thread Wei Liu
On Tue, Apr 24, 2018 at 03:18:14PM +0200, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too.

Re: [Xen-devel] [PATCH] xen-netback: fix xenvif_start_xmit()'s return type

2018-04-24 Thread Wei Liu
On Tue, Apr 24, 2018 at 03:18:12PM +0200, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too.

[Xen-devel] [PATCH] xen-netback: fix xenvif_start_xmit()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[Xen-devel] [PATCH] xen-netfront: fix xennet_start_xmit()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[Xen-devel] [OSSTEST PATCH] cr-for-branches: Add linux-4.14

2018-04-24 Thread Ian Jackson
Signed-off-by: Ian Jackson --- cr-for-branches | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cr-for-branches b/cr-for-branches index cf48390..c4de52f 100755 --- a/cr-for-branches +++ b/cr-for-branches @@ -31,7 +31,7 @@ scriptoptions="$1"; shift

Re: [Xen-devel] [PATCH 0/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver

2018-04-24 Thread Oleksandr Andrushchenko
On 04/24/2018 02:54 PM, Daniel Vetter wrote: On Mon, Apr 23, 2018 at 03:10:35PM +0300, Oleksandr Andrushchenko wrote: On 04/23/2018 02:52 PM, Wei Liu wrote: On Fri, Apr 20, 2018 at 02:25:20PM +0300, Oleksandr Andrushchenko wrote: the gntdev. I think this is generic enough that it could

Re: [Xen-devel] [PATCH 0/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver

2018-04-24 Thread Daniel Vetter
On Mon, Apr 23, 2018 at 03:10:35PM +0300, Oleksandr Andrushchenko wrote: > On 04/23/2018 02:52 PM, Wei Liu wrote: > > On Fri, Apr 20, 2018 at 02:25:20PM +0300, Oleksandr Andrushchenko wrote: > > > > > the gntdev. > > > > > > > > > > I think this is generic enough that it could be implemented

Re: [Xen-devel] [PATCH for-4.11] x86/spec_ctrl: Fix typo in ARCH_CAPS decode

2018-04-24 Thread Jan Beulich
>>> On 24.04.18 at 11:44, wrote: > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

Re: [Xen-devel] RFC Xen signature verification for kexec

2018-04-24 Thread Jan Beulich
>>> On 24.04.18 at 12:13, wrote: > On Tue, Apr 24, 2018 at 10:46:38AM +0100, George Dunlap wrote: >> On Mon, Apr 23, 2018 at 11:33 AM, Jan Beulich wrote: >> On 23.04.18 at 12:25, wrote: >> >> On Mon, Apr 23, 2018 at

Re: [Xen-devel] [PATCH v8 1/9] x86/xpti: avoid copying L4 page table contents when possible

2018-04-24 Thread Juergen Gross
On 24/04/18 12:31, Tim Deegan wrote: > At 07:45 +0200 on 23 Apr (1524469545), Juergen Gross wrote: >> On 22/04/18 18:39, Tim Deegan wrote: >>> At 19:11 +0200 on 21 Apr (1524337893), Juergen Gross wrote: On 21/04/18 15:32, Tim Deegan wrote: > At 09:44 +0200 on 19 Apr (1524131080), Juergen

[Xen-devel] [qemu-mainline test] 122357: tolerable FAIL - PUSHED

2018-04-24 Thread osstest service owner
flight 122357 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/122357/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-xsm 14 saverestore-support-checkfail like 122212 test-armhf-armhf-libvirt 14

Re: [Xen-devel] [PATCH 4/6] arm: add a small kconfig for Renesas RCar H3

2018-04-24 Thread Julien Grall
On 24/04/2018 12:04, Andrii Anisov wrote: Hello Julien, On 24.04.18 13:06, Julien Grall wrote: I believe that passthrough should be kept as core Xen, it is small and quite tight to the rest of Xen. It might be. But I would be interested to know what would be the rationale to disable

Re: [Xen-devel] SVM MSRs issue

2018-04-24 Thread Razvan Cojocaru
> While testing MSR vm_events, we've come accross some puzzling behaviour > while trying to follow the guest's MSR_LSTAR: it starts out as zero, > then it changes value before the first MSR write event, without going > through svm_msr_write_intercept(). The culprit seems to be a > svm_vmsave_pa()

Re: [Xen-devel] [RFC PATCH 1/1] xen: credit2: rb-tree for runqueues

2018-04-24 Thread Dario Faggioli
On Tue, 2018-04-24 at 14:30 +0530, Praveen Kumar wrote: > Hi Dario, > Hi! > On Tuesday 17 April 2018 04:16 PM, Dario Faggioli wrote: > > On Tue, 2018-04-03 at 22:25 +0530, Praveen Kumar wrote: > > > > > > +if ( svc->credit < entry->credit ) > > > +node = >rb_left; > > > +

Re: [Xen-devel] [PATCH 4/6] arm: add a small kconfig for Renesas RCar H3

2018-04-24 Thread Andrii Anisov
Hello Julien, On 24.04.18 13:06, Julien Grall wrote: I believe that passthrough should be kept as core Xen, it is small and quite tight to the rest of Xen. It might be. But I would be interested to know what would be the rationale to disable that. Do you foresee certification on IOMMU-less

Re: [Xen-devel] [PATCH v2 02/10] xen/arm: Ignore write to GICD_ISACTIVERn registers (vgic-v2)

2018-04-24 Thread Mirela Simonovic
Hi Julien, On Mon, Apr 23, 2018 at 1:15 PM, Julien Grall wrote: > Hi Mirela, > > > On 20/04/18 13:25, Mirela Simonovic wrote: >> >> Guests attempt to write into these registers on resume (for example >> Linux). >> Without this patch a data abort exception will be raised to

[Xen-devel] [distros-debian-snapshot test] 74637: tolerable FAIL

2018-04-24 Thread Platform Team regression test user
flight 74637 distros-debian-snapshot real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/74637/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-i386-daily-netboot-pvgrub 10 debian-di-install fail like 74630

Re: [Xen-devel] [PATCH v8 1/9] x86/xpti: avoid copying L4 page table contents when possible

2018-04-24 Thread Tim Deegan
At 07:45 +0200 on 23 Apr (1524469545), Juergen Gross wrote: > On 22/04/18 18:39, Tim Deegan wrote: > > At 19:11 +0200 on 21 Apr (1524337893), Juergen Gross wrote: > >> On 21/04/18 15:32, Tim Deegan wrote: > >>> At 09:44 +0200 on 19 Apr (1524131080), Juergen Gross wrote: > Another alternative

Re: [Xen-devel] [PATCH 0/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver

2018-04-24 Thread Juergen Gross
On 24/04/18 12:14, Oleksandr Andrushchenko wrote: > On 04/24/2018 01:01 PM, Wei Liu wrote: >> On Tue, Apr 24, 2018 at 11:08:41AM +0200, Juergen Gross wrote: >>> On 24/04/18 11:03, Oleksandr Andrushchenko wrote: On 04/24/2018 11:40 AM, Juergen Gross wrote: > On 24/04/18 10:07, Oleksandr

Re: [Xen-devel] [PATCH 0/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver

2018-04-24 Thread Oleksandr Andrushchenko
On 04/24/2018 01:01 PM, Wei Liu wrote: On Tue, Apr 24, 2018 at 11:08:41AM +0200, Juergen Gross wrote: On 24/04/18 11:03, Oleksandr Andrushchenko wrote: On 04/24/2018 11:40 AM, Juergen Gross wrote: On 24/04/18 10:07, Oleksandr Andrushchenko wrote: On 04/24/2018 10:51 AM, Juergen Gross wrote:

Re: [Xen-devel] RFC Xen signature verification for kexec

2018-04-24 Thread Daniel Kiper
On Tue, Apr 24, 2018 at 10:46:38AM +0100, George Dunlap wrote: > On Mon, Apr 23, 2018 at 11:33 AM, Jan Beulich wrote: > On 23.04.18 at 12:25, wrote: > >> On Mon, Apr 23, 2018 at 12:55:45AM -0600, Jan Beulich wrote: > >>> >>> On 20.04.18 at 21:12,

Re: [Xen-devel] [PATCH 4/6] arm: add a small kconfig for Renesas RCar H3

2018-04-24 Thread Julien Grall
On 04/24/2018 10:52 AM, Andrii Anisov wrote: Hello Julien, Hi Andrii, On 24.04.18 12:01, Julien Grall wrote: You can't unselect HAS_PASSTHROUGH support. Given that you are going to have passthrough in the future, I don't much see the point to try to allow that option to be disabled. If

[Xen-devel] SVM MSRs issue

2018-04-24 Thread Razvan Cojocaru
Hello, While testing MSR vm_events, we've come accross some puzzling behaviour while trying to follow the guest's MSR_LSTAR: it starts out as zero, then it changes value before the first MSR write event, without going through svm_msr_write_intercept(). The culprit seems to be a svm_vmsave_pa()

Re: [Xen-devel] [PATCH 0/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver

2018-04-24 Thread Wei Liu
On Tue, Apr 24, 2018 at 11:08:41AM +0200, Juergen Gross wrote: > On 24/04/18 11:03, Oleksandr Andrushchenko wrote: > > On 04/24/2018 11:40 AM, Juergen Gross wrote: > >> On 24/04/18 10:07, Oleksandr Andrushchenko wrote: > >>> On 04/24/2018 10:51 AM, Juergen Gross wrote: > On 24/04/18 07:43,

Re: [Xen-devel] [PATCH 4/6] arm: add a small kconfig for Renesas RCar H3

2018-04-24 Thread Andrii Anisov
Hello Julien, On 24.04.18 12:01, Julien Grall wrote: You can't unselect HAS_PASSTHROUGH support. Given that you are going to have passthrough in the future, I don't much see the point to try to allow that option to be disabled. If we are speaking of R-Car Gen3, you might be right. We are

Re: [Xen-devel] [PATCH for-4.11] x86/spec_ctrl: Fix typo in ARCH_CAPS decode

2018-04-24 Thread Juergen Gross
On 24/04/18 11:44, Andrew Cooper wrote: > Signed-off-by: Andrew Cooper Release-acked-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

Re: [Xen-devel] RFC Xen signature verification for kexec

2018-04-24 Thread George Dunlap
On Mon, Apr 23, 2018 at 11:33 AM, Jan Beulich wrote: On 23.04.18 at 12:25, wrote: >> On Mon, Apr 23, 2018 at 12:55:45AM -0600, Jan Beulich wrote: >>> >>> On 20.04.18 at 21:12, wrote: >>> > Two options for signature

Re: [Xen-devel] [RFC v2 6/9] libxl: Have QEMU save its state to a file descriptor

2018-04-24 Thread Wei Liu
On Mon, Apr 16, 2018 at 06:32:24PM +0100, Anthony PERARD wrote: > In case QEMU have restricted access to the system, open the file for it, > and QEMU will save its state to this file descritor. > > Signed-off-by: Anthony PERARD Acked-by: Wei Liu

[Xen-devel] [PATCH for-4.11] x86/spec_ctrl: Fix typo in ARCH_CAPS decode

2018-04-24 Thread Andrew Cooper
Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Juergen Gross --- xen/arch/x86/spec_ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c index

[Xen-devel] [xen-4.10-testing test] 122356: regressions - FAIL

2018-04-24 Thread osstest service owner
flight 122356 xen-4.10-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/122356/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-win7-amd64 7 xen-boot fail REGR. vs. 122255

Re: [Xen-devel] [RFC v2 6/9] libxl: Have QEMU save its state to a file descriptor

2018-04-24 Thread Wei Liu
On Mon, Apr 23, 2018 at 04:45:28PM +0100, Anthony PERARD wrote: > On Mon, Apr 23, 2018 at 10:20:42AM +0100, Wei Liu wrote: > > On Mon, Apr 16, 2018 at 06:32:24PM +0100, Anthony PERARD wrote: > > > In case QEMU have restricted access to the system, open the file for it, > > > and QEMU will save its

Re: [Xen-devel] [PATCH 0/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver

2018-04-24 Thread Oleksandr Andrushchenko
On 04/24/2018 12:08 PM, Juergen Gross wrote: On 24/04/18 11:03, Oleksandr Andrushchenko wrote: On 04/24/2018 11:40 AM, Juergen Gross wrote: On 24/04/18 10:07, Oleksandr Andrushchenko wrote: On 04/24/2018 10:51 AM, Juergen Gross wrote: On 24/04/18 07:43, Oleksandr Andrushchenko wrote: On

Re: [Xen-devel] [PATCH 0/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver

2018-04-24 Thread Juergen Gross
On 24/04/18 11:03, Oleksandr Andrushchenko wrote: > On 04/24/2018 11:40 AM, Juergen Gross wrote: >> On 24/04/18 10:07, Oleksandr Andrushchenko wrote: >>> On 04/24/2018 10:51 AM, Juergen Gross wrote: On 24/04/18 07:43, Oleksandr Andrushchenko wrote: > On 04/24/2018 01:41 AM, Boris

Re: [Xen-devel] [PATCH RFC 02/10] passthrough: split out x86 PCI code to x86/pci.c

2018-04-24 Thread Julien Grall
Hi, On 04/23/2018 04:34 PM, Jan Beulich wrote: On 21.02.18 at 22:46, wrote: Move the functions that reference x86 hvm data structures to its own file. Rename pci_clean_dpci_irqs to arch_pci_clean_irqs. There is still one location in that file which references

Re: [Xen-devel] [PATCH 0/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver

2018-04-24 Thread Oleksandr Andrushchenko
On 04/24/2018 11:40 AM, Juergen Gross wrote: On 24/04/18 10:07, Oleksandr Andrushchenko wrote: On 04/24/2018 10:51 AM, Juergen Gross wrote: On 24/04/18 07:43, Oleksandr Andrushchenko wrote: On 04/24/2018 01:41 AM, Boris Ostrovsky wrote: On 04/23/2018 08:10 AM, Oleksandr Andrushchenko wrote:

  1   2   >