Re: [Xen-devel] PCI passthrough performance loss with Skylake-SP

2018-06-25 Thread Roger Pau Monné
On Mon, Jun 25, 2018 at 05:32:58PM +0200, Andreas Kinzler wrote: > I am currently testing PCI passthrough on the Skylake-SP platform using a > Supermicro X11SPi-TF mainboard. Using PCI passthrough (an LSI SAS HBA) > causes severe performance loss on the Skylake-SP platform while Xeon E3 v5 > is not

[Xen-devel] [linux-linus test] 124671: trouble: blocked/broken/pass

2018-06-25 Thread osstest service owner
flight 124671 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/124671/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-pvops broken build-amd64-xsm

Re: [Xen-devel] [PATCH RFC] tools/libxl: Switch Arm guest type to PVH

2018-06-25 Thread Roger Pau Monné
On Mon, Jun 25, 2018 at 05:39:12PM +0100, Ian Jackson wrote: > Roger Pau Monné writes ("Re: [PATCH RFC] tools/libxl: Switch Arm guest type > to PVH"): > > IMO I would remove the 'type' option from xl.cfg (so that it's > > basically ignored) in the ARM case and force it internally to PVH (if > > th

[Xen-devel] [PATCH for-4.11 v2 3/3] VMX: check host CR0 before entering guest

2018-06-25 Thread Jan Beulich
While we don't expect CR0 to change behind our backs, cope with this happening, but other than for CR4 also log a (debug) message. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -1676,7 +1676,7 @@ void vmx_vmentry_failure(void) void vmx_do_resu

[Xen-devel] [PATCH for-4.11 v2 2/3] x86: guard against #NM

2018-06-25 Thread Jan Beulich
Just in case we still don't get CR0.TS handling right, prevent a host crash by honoring exception fixups in do_device_not_available(). This would in particular cover emulator stubs raising #NM. Signed-off-by: Jan Beulich --- v2: Add ASSERT_UNREACHABLE(). --- a/xen/arch/x86/traps.c +++ b/xen/arch

[Xen-devel] [PATCH for-4.11 v2 1/3] x86/HVM: don't cause #NM to be raised in Xen

2018-06-25 Thread Jan Beulich
The changes for XSA-267 did not touch management of CR0.TS for HVM guests. In fully eager mode this bit should never be set when respective vCPU-s are active, or else hvmemul_get_fpu() might leave it wrongly set, leading to #NM in hypervisor context. {svm,vmx}_enter() and {svm,vmx}_fpu_dirty_inter

[Xen-devel] [PATCH for-4.11 v2 0/3] x86: XSA-267 follow-up

2018-06-25 Thread Jan Beulich
The first patch alone should be sufficient to address an issue with the XSA-267 changes, causing a BUG_ON() to be triggered. The other two patches would, afaict, each individually also have avoided the issue, hence I'm also including them here. While the first patch obviously is a strong candidate

[Xen-devel] [PATCH v5 14/27] x86/percpu: Adapt percpu for PIE support

2018-06-25 Thread Thomas Garnier
Perpcu uses a clever design where the .percu ELF section has a virtual address of zero and the custom linux relocation code avoid relocating specific symbols. It makes the code simple and easily adaptable with or without SMP support. This design is incompatible with PIE. While creating a PIE binar

[Xen-devel] Commit moratorium is lifted

2018-06-25 Thread Juergen Gross
Committers, With 4.11 branched off the commit moratorium is lifted. For 4.11 only very few selected patches will be accepted until the release. Please wait to commit any larger series to the main branch until 4.11 has been released, in case some security patches or late fixes need to be applied

[Xen-devel] [xen-unstable-smoke test] 124710: trouble: blocked/broken/pass

2018-06-25 Thread osstest service owner
flight 124710 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/124710/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-armhf

[Xen-devel] [ovmf test] 124675: trouble: blocked/broken

2018-06-25 Thread osstest service owner
flight 124675 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/124675/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-amd64-xsm

[Xen-devel] [xen-unstable test] 124669: trouble: blocked/broken/pass

2018-06-25 Thread osstest service owner
flight 124669 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/124669/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-pvopsbroken build-amd64-xsm

[Xen-devel] [seabios test] 124679: trouble: blocked/broken

2018-06-25 Thread osstest service owner
flight 124679 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/124679/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-amd64-pvops

[Xen-devel] [linux-4.9 test] 124658: trouble: blocked/broken/pass

2018-06-25 Thread osstest service owner
flight 124658 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/124658/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm broken build-i386-xsm

[Xen-devel] [xen-4.11-testing baseline test] 124696: trouble: blocked/broken/pass

2018-06-25 Thread osstest service owner
"Old" tested version had not actually been tested; therefore in this flight we test it, rather than a new candidate. The baseline, if any, is the most recent actually tested revision. flight 124696 xen-4.11-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/124696/ Failures and

[Xen-devel] [PATCH v5 18/27] xen: Adapt assembly for PIE support

2018-06-25 Thread Thomas Garnier
Change the assembly code to use the new _ASM_MOVABS macro which get a symbol reference while being PIE compatible. Adapt the relocation tool to ignore 32-bit Xen code. Position Independent Executable (PIE) support will allow to extend the KASLR randomization range 0x8000. Signed-off-b

[Xen-devel] [PATCH v5 00/27] x86: PIE support and option to extend KASLR randomization

2018-06-25 Thread Thomas Garnier
Changes: - patch v5: - Adapt new crypto modules for PIE. - Improve per-cpu commit message. - Fix xen 32-bit build error with .quad. - Remove extra code for ftrace. - patch v4: - Simplify early boot by removing global variables. - Modify the mcount location script for __mcount_lo

[Xen-devel] [xen-unstable-smoke test] 124698: trouble: blocked/broken/pass

2018-06-25 Thread osstest service owner
flight 124698 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/124698/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-armhf

[Xen-devel] [freebsd-master test] 124706: regressions - trouble: blocked/fail

2018-06-25 Thread osstest service owner
flight 124706 freebsd-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/124706/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-freebsd 7 freebsd-buildfail REGR. vs. 124694 Tests which did

[Xen-devel] [freebsd-master test] 124705: regressions - trouble: blocked/fail

2018-06-25 Thread osstest service owner
flight 124705 freebsd-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/124705/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-freebsd 7 freebsd-buildfail REGR. vs. 124694 Tests which did

[Xen-devel] [freebsd-master baseline test] 124694: all pass

2018-06-25 Thread osstest service owner
"Old" tested version had not actually been tested; therefore in this flight we test it, rather than a new candidate. The baseline, if any, is the most recent actually tested revision. flight 124694 freebsd-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/124694/ Perfect :-) Al

Re: [Xen-devel] [PATCH 3/3] process docs: Final branching checklist steps

2018-06-25 Thread Jason Andryuk
On Mon, Jun 25, 2018 at 10:53 AM, Ian Jackson wrote: > Document two steps which were done this time, and last time: > (i) setting off an early osstest run > (ii) sending the mail confirming it's done. > > Signed-off-by: Ian Jackson > --- > docs/process/branching-checklist.txt | 9 + > 1

Re: [Xen-devel] [PATCH RFC] tools/libxl: Switch Arm guest type to PVH

2018-06-25 Thread Ian Jackson
Roger Pau Monné writes ("Re: [PATCH RFC] tools/libxl: Switch Arm guest type to PVH"): > IMO I would remove the 'type' option from xl.cfg (so that it's > basically ignored) in the ARM case and force it internally to PVH (if > that's the best route for current ARM guests). What about libvirt users

Re: [Xen-devel] [PATCH RFC] tools/libxl: Switch Arm guest type to PVH

2018-06-25 Thread Roger Pau Monné
On Mon, Jun 25, 2018 at 05:18:31PM +0100, Julien Grall wrote: > Hi Wei, > > On 25/06/18 14:19, Wei Liu wrote: > > On Mon, Jun 25, 2018 at 02:08:14PM +0100, Julien Grall wrote: > > > Currently, the toolstack is considering Arm guest always PV. However, > > > they are very similar to PVH because HW

Re: [Xen-devel] [PATCH v2 6/6] tools: --with-system-{ovmf, seabios, ipxe} should provide absolute paths

2018-06-25 Thread Roger Pau Monné
On Mon, Jun 25, 2018 at 12:35:33PM +0100, Wei Liu wrote: > The paths shouldn't be set to "yes". If you want to check if an absolute path is provided I would rather do: case $withval in no) ovmf_path= ;; /*) ovmf_path=$withval ;; *) AC_MSG_ERROR([OVMF specified, but is not an absolute

Re: [Xen-devel] [PATCH RFC] tools/libxl: Switch Arm guest type to PVH

2018-06-25 Thread Julien Grall
Hi Wei, On 25/06/18 14:19, Wei Liu wrote: On Mon, Jun 25, 2018 at 02:08:14PM +0100, Julien Grall wrote: Currently, the toolstack is considering Arm guest always PV. However, they are very similar to PVH because HW virtualization extension are used and QEMU is not started. So switch Arm guest ty

Re: [Xen-devel] [PATCH v2 5/6] tools: provide --with-system-ipxe

2018-06-25 Thread Roger Pau Monné
On Mon, Jun 25, 2018 at 12:35:32PM +0100, Wei Liu wrote: > diff --git a/tools/configure.ac b/tools/configure.ac > index 0826af8cbc..8e4b173d6f 100644 > --- a/tools/configure.ac > +++ b/tools/configure.ac > @@ -84,6 +84,7 @@ AX_ARG_DEFAULT_ENABLE([ocamltools], [Disable Ocaml tools]) > AX_ARG_DEFAUL

Re: [Xen-devel] [PATCH v2 4/6] tools: load IPXE from standalone file

2018-06-25 Thread Roger Pau Monné
On Mon, Jun 25, 2018 at 12:35:31PM +0100, Wei Liu wrote: > diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c > index f0fd5fd3a3..1b9e45c492 100644 > --- a/tools/libxl/libxl_dom.c > +++ b/tools/libxl/libxl_dom.c > @@ -1128,6 +1128,16 @@ static int libxl__domain_firmware(libxl__gc *gc, >

Re: [Xen-devel] [PATCH v2 3/6] libxc: allow HVM guest to have modules

2018-06-25 Thread Roger Pau Monné
On Mon, Jun 25, 2018 at 12:35:30PM +0100, Wei Liu wrote: > Lift the loading code out of PVH specific branch. Take the chance to > make the debug message more useful. Would be nice to mention that you also account for virt_base being unset. > IPXE will be loaded as a module of Rombios. > > Signe

Re: [Xen-devel] [PATCH v2 3/8] xen/x86: manually build xen.mb.efi binary

2018-06-25 Thread Jan Beulich
>>> On 19.06.18 at 16:35, wrote: > Not done: >- ASM PE header conversion to C; not feasible, Hmm. As long as you can convince Andrew to give you an ack, I won't veto it. But I continue to dislike it, and hence I don't currently foresee myself acking it. >- DOS stub code reduction; experi

[Xen-devel] PCI passthrough performance loss with Skylake-SP

2018-06-25 Thread Andreas Kinzler
I am currently testing PCI passthrough on the Skylake-SP platform using a Supermicro X11SPi-TF mainboard. Using PCI passthrough (an LSI SAS HBA) causes severe performance loss on the Skylake-SP platform while Xeon E3 v5 is not affected at all. The test uses standard iperf3 as a client - the

[Xen-devel] [PATCH v8 11/11] x86/hvm: Remove save_one handler

2018-06-25 Thread Alexandru Isaila
Signed-off-by: Alexandru Isaila --- xen/arch/x86/cpu/mcheck/vmce.c | 1 - xen/arch/x86/hvm/hpet.c| 2 +- xen/arch/x86/hvm/hvm.c | 5 + xen/arch/x86/hvm/i8254.c | 2 +- xen/arch/x86/hvm/irq.c | 6 +++--- xen/arch/x86/hvm/mtrr.c| 2 +- xen/arch/x86/hv

[Xen-devel] [PATCH v8 04/11] x86/hvm: Introduce hvm_save_cpu_xsave_states_one

2018-06-25 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila --- xen/arch/x86/hvm/hvm.c | 36 +++- 1 file changed, 23 insertions(+), 13 deletions(-) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 73aac25..1fac4d7 100644 --

[Xen-devel] [PATCH v8 06/11] x86/hvm: Introduce hvm_save_mtrr_msr_one func

2018-06-25 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila --- Changes since V7: - Add const to the declaration of mtrr_state Note: This patch is based on Roger Pau Monne's series[1] --- xen/arch/x86/hvm/mtrr.c | 79 +++

[Xen-devel] [PATCH v8 02/11] x86/hvm: Introduce hvm_save_tsc_adjust_one() func

2018-06-25 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila --- xen/arch/x86/hvm/hvm.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 93092d2..c47d162 100644 --- a/xen/arch/x86/hvm/hv

[Xen-devel] [PATCH for-4.12 0/3] process docs: Branching checklist updates

2018-06-25 Thread Ian Jackson
From: Ian Jackson Today's run through the branching checklist generated these doc improvement suggestions. Ian Jackson (3): process docs: Drop some obsolete stuff process docs: Add some detail about changes during branching process docs: Final branching checklist steps docs/process/branc

[Xen-devel] [PATCH 3/3] process docs: Final branching checklist steps

2018-06-25 Thread Ian Jackson
Document two steps which were done this time, and last time: (i) setting off an early osstest run (ii) sending the mail confirming it's done. Signed-off-by: Ian Jackson --- docs/process/branching-checklist.txt | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/process/branching-ch

[Xen-devel] [PATCH 1/3] process docs: Drop some obsolete stuff

2018-06-25 Thread Ian Jackson
* Drop reference to long-gone Citrix-internal HG trees * Drop reference to RT-accessible web pages; web page editing is now handled via the RM, community manager, etc. * Drop reference to git description files; this is not needed because now we have one tree with all branches, not one per branc

[Xen-devel] [PATCH 2/3] process docs: Add some detail about changes during branching

2018-06-25 Thread Ian Jackson
Split out the required work for the new and old branches and be more specific about what is to be done. In the RT checklist, reformat and expand the "turn off debug" instructions. Signed-off-by: Ian Jackson --- docs/process/branching-checklist.txt | 13 + docs/process/relea

[Xen-devel] [linux-4.14 test] 124661: trouble: blocked/broken/pass

2018-06-25 Thread osstest service owner
flight 124661 linux-4.14 real [real] http://logs.test-lab.xenproject.org/osstest/logs/124661/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-amd64

[Xen-devel] [PATCH v8 10/11] x86/hvm: Remove redundant save functions

2018-06-25 Thread Alexandru Isaila
This patch removes the redundant save functions and renames the save_one* to save. It then changes the domain param to vcpu in the save funcs. Signed-off-by: Alexandru Isaila --- xen/arch/x86/cpu/mcheck/vmce.c | 19 ++ xen/arch/x86/hvm/hpet.c| 3 +- xen/arch/x86/hvm/hvm.c

[Xen-devel] [PATCH v8 07/11] x86/hvm: Introduce viridian_save_vcpu_ctxt_one() func

2018-06-25 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila --- xen/arch/x86/hvm/viridian.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/xen/arch/x86/hvm/viridian.c b/xen/arch/x86/hvm/viridian.c index 694eae6..ed164ab 10064

[Xen-devel] [PATCH v8 01/11] x86/cpu: Introduce vmce_save_vcpu_ctxt_one() func

2018-06-25 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila --- xen/arch/x86/cpu/mcheck/vmce.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/xen/arch/x86/cpu/mcheck/vmce.c b/xen/arch/x86/cpu/mcheck/vmce.c index e07cd2f..8a1fbfc 1

[Xen-devel] [PATCH v8 03/11] x86/hvm: Introduce hvm_save_cpu_ctxt_one func

2018-06-25 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila --- Changes since V7: - Moved the memset in the hvm_save_cpu_ctxt_one func. --- xen/arch/x86/hvm/hvm.c| 218 -- xen/include/asm-x86/hvm/support.h | 2 + 2

[Xen-devel] [PATCH v8 08/11] x86/hvm: Add handler for save_one funcs

2018-06-25 Thread Alexandru Isaila
Signed-off-by: Alexandru Isaila --- xen/arch/x86/cpu/mcheck/vmce.c | 1 + xen/arch/x86/hvm/hpet.c| 2 +- xen/arch/x86/hvm/hvm.c | 6 +- xen/arch/x86/hvm/i8254.c | 2 +- xen/arch/x86/hvm/irq.c | 6 +++--- xen/arch/x86/hvm/mtrr.c| 4 ++-- xen/arch/x86/hvm/p

[Xen-devel] [PATCH v8 09/11] x86/domctl: Don't pause the whole domain if only getting vcpu state

2018-06-25 Thread Alexandru Isaila
This patch is focused on moving the for loop to the caller so now we can save info for a single vcpu instance with the save_one handlers. Signed-off-by: Alexandru Isaila --- xen/arch/x86/hvm/save.c | 141 +--- 1 file changed, 111 insertions(+), 30 dele

[Xen-devel] [PATCH v8 00/11] x86/domctl: Save info for one vcpu instance

2018-06-25 Thread Alexandru Isaila
Hi all, This patch series addresses the ideea of saving data from a single vcpu instance. First it starts by adding *save_one functions, then it introduces a handler for the new save_one* funcs and makes use of it in the hvm_save and hvm_save_one funcs. The final 2 patches are used for clean up.

[Xen-devel] [PATCH v8 05/11] x86/hvm: Introduce hvm_save_cpu_msrs_one func

2018-06-25 Thread Alexandru Isaila
This is used to save data from a single instance. Signed-off-by: Alexandru Isaila --- Changes since V7: - Moved the init of ctxt->count to hvm_save_cpu_msrs_one() --- xen/arch/x86/hvm/hvm.c | 103 +++-- 1 file changed, 57 insertions(+), 46 del

Re: [Xen-devel] Commit moratorium for preparing 4.11 branch

2018-06-25 Thread Ian Jackson
4.11 is now branched off from unstable. I have set a baseline osstest run off by hand. (osstest will only start regularly testing the new branches when the osstest commit that adds the branch makes it through the push gate, so there will be a delay unless I force push it.) With Juergen's approva

[Xen-devel] [PATCH 2/2] configure: Rerun autogen.sh (on stretch)

2018-06-25 Thread Ian Jackson
This is just a version number update. Signed-off-by: Ian Jackson --- configure | 18 +- docs/configure| 18 +- stubdom/configure | 18 +- tools/configure | 18 +- 4 files changed, 36 insertions(+), 36 deletions(-) dif

[Xen-devel] [PATCH 1/2] README, Makefiles, Config.mk: Update for branching 4.11 vs 4.12-unstable

2018-06-25 Thread Ian Jackson
Signed-off-by: Ian Jackson --- Config.mk| 6 +++--- README | 10 +- SUPPORT.md | 2 +- xen/Makefile | 4 ++-- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/Config.mk b/Config.mk index 9183496..0e829bb 100644 --- a/Config.mk +++ b/Config.mk @@ -275,15 +275

[Xen-devel] [PATCH V2] x86/altp2m: Fixed crash with INVALID_ALTP2M EPTP index

2018-06-25 Thread Razvan Cojocaru
When SECONDARY_EXEC_ENABLE_VIRT_EXCEPTIONS is set, vmx_vcpu_update_eptp() __vmwrites() EPTP_INDEX in altp2m_vcpu_destroy(). This means that when disabling altp2m on a domain after xc_altp2m_set_vcpu_enable_notify() has been successfully called, EPTP_INDEX ends up being stored as INVALID_ALTP2M. Thi

Re: [Xen-devel] [PATCH for-4.11 v2] x86/EFI: further correct FPU state handling around runtime calls

2018-06-25 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 25 June 2018 13:49 > To: Paul Durrant > Cc: Andrew Cooper ; xen-devel de...@lists.xenproject.org>; Juergen Gross > Subject: RE: [PATCH for-4.11 v2] x86/EFI: further correct FPU state handling > around runtime cal

Re: [Xen-devel] [PATCH v2 2/8] xen: introduce XEN_COMPILE_POSIX_TIME

2018-06-25 Thread Andrew Cooper
On 25/06/18 14:54, Jan Beulich wrote: On 19.06.18 at 16:35, wrote: >> We need the POSIX time to properly fill the TimeDateStamp field in the PE >> header. >> >> Additionally, realign the variables assignment in xen/Makefile to increase >> readability. >> >> Signed-off-by: Daniel Kiper >> -

Re: [Xen-devel] [PATCH v2 2/8] xen: introduce XEN_COMPILE_POSIX_TIME

2018-06-25 Thread Jan Beulich
>>> On 19.06.18 at 16:35, wrote: > We need the POSIX time to properly fill the TimeDateStamp field in the PE > header. > > Additionally, realign the variables assignment in xen/Makefile to increase > readability. > > Signed-off-by: Daniel Kiper > --- > v2 - suggestions/fixes: >- derive XE

Re: [Xen-devel] [PATCH v2 1/8] xen: calculate XEN_BUILD_TIME using XEN_BUILD_DATE value

2018-06-25 Thread Jan Beulich
>>> On 19.06.18 at 16:35, wrote: > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -9,7 +9,7 @@ export XEN_FULLVERSION = > $(XEN_VERSION).$(XEN_SUBVERSION)$(XEN_EXTRAVERSION) > export XEN_WHOAMI?= $(USER) > export XEN_DOMAIN?= $(shell ([ -x /bin/dnsdomainname ] && > /bin/dnsdomainname)

Re: [Xen-devel] [PATCH v2 4/6] tools: load IPXE from standalone file

2018-06-25 Thread Jan Beulich
>>> On 25.06.18 at 13:35, wrote: > --- a/tools/firmware/hvmloader/config.h > +++ b/tools/firmware/hvmloader/config.h > @@ -22,7 +22,8 @@ struct bios_config { > /* ROMS */ > void (*load_roms)(void); > > -void (*bios_load)(const struct bios_config *config, void *addr, uint32_t > siz

Re: [Xen-devel] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-06-25 Thread Michal Hocko
On Mon 25-06-18 10:01:03, Michal Hocko wrote: > On Fri 22-06-18 16:09:06, Felix Kuehling wrote: > > On 2018-06-22 11:24 AM, Michal Hocko wrote: > > > On Fri 22-06-18 17:13:02, Christian König wrote: > > >> Hi Michal, > > >> > > >> [Adding Felix as well] > > >> > > >> Well first of all you have a mi

Re: [Xen-devel] [PATCH RFC] tools/libxl: Switch Arm guest type to PVH

2018-06-25 Thread Wei Liu
On Mon, Jun 25, 2018 at 02:08:14PM +0100, Julien Grall wrote: > Currently, the toolstack is considering Arm guest always PV. However, > they are very similar to PVH because HW virtualization extension are used > and QEMU is not started. So switch Arm guest type to PVH. > > Furthermore, the default

Re: [Xen-devel] [PATCH V2 2/2] x86/altp2m: Fixed domain crash with INVALID_ALTP2M EPTP index

2018-06-25 Thread Jan Beulich
>>> On 25.06.18 at 14:59, wrote: > Quite right, that's exactly what I've been doing: a satisfactory fix > appears to be to simply reverse the order of altp2m_vcpu_update_p2m(v) > and altp2m_vcpu_update_vmfunc_ve(v) in altp2m_vcpu_destroy(). And that's also more logical considering that vmx_vcpu_u

[Xen-devel] [PATCH RFC] tools/libxl: Switch Arm guest type to PVH

2018-06-25 Thread Julien Grall
Currently, the toolstack is considering Arm guest always PV. However, they are very similar to PVH because HW virtualization extension are used and QEMU is not started. So switch Arm guest type to PVH. Furthermore, the default type for Arm in xl will now be PVH to allow smooth transition for user.

Re: [Xen-devel] [PATCH V2 2/2] x86/altp2m: Fixed domain crash with INVALID_ALTP2M EPTP index

2018-06-25 Thread Razvan Cojocaru
On 06/25/2018 03:54 PM, Jan Beulich wrote: On 25.06.18 at 14:40, wrote: >>> Crash: >>> >>> (XEN) [ 1924.367273] altp2m_vcpu_initialise() >>> (XEN) [ 1924.367277] altp2m_vcpu_reset() >>> (XEN) [ 1924.367278] 1 altp2m_vcpu_update_p2m() >>> (XEN) [ 1924.367279] vmx_vcpu_update_eptp() >>> (XEN) [

Re: [Xen-devel] [PATCH V2 2/2] x86/altp2m: Fixed domain crash with INVALID_ALTP2M EPTP index

2018-06-25 Thread Jan Beulich
>>> On 25.06.18 at 14:40, wrote: >> Crash: >> >> (XEN) [ 1924.367273] altp2m_vcpu_initialise() >> (XEN) [ 1924.367277] altp2m_vcpu_reset() >> (XEN) [ 1924.367278] 1 altp2m_vcpu_update_p2m() >> (XEN) [ 1924.367279] vmx_vcpu_update_eptp() >> (XEN) [ 1924.367318] HVMOP_altp2m_vcpu_enable_notify >> (

Re: [Xen-devel] [PATCH for-4.11 v2] x86/EFI: further correct FPU state handling around runtime calls

2018-06-25 Thread Jan Beulich
>>> On 25.06.18 at 14:24, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 25 June 2018 13:18 >> --- a/xen/arch/x86/i387.c >> +++ b/xen/arch/x86/i387.c >> @@ -206,11 +206,11 @@ static inline void fpu_fxsave(struct vcp >> /* VCPU FPU Functions*/ >> /**

[Xen-devel] [PATCH v5 14/46] hw/display: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Gerd Hoffmann Reviewed-by: Alistair Francis --- include/hw/display/xlnx_dp.h |

[Xen-devel] [PATCH v5 11/46] hw/xen: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alan Robinson --- hw/block/xen_disk.c| 3 ++- hw/i386/xen/xen-mapcache

Re: [Xen-devel] [PATCH V2 2/2] x86/altp2m: Fixed domain crash with INVALID_ALTP2M EPTP index

2018-06-25 Thread Razvan Cojocaru
> (XEN) [ 1923.964832] altp2m_vcpu_initialise() > (XEN) [ 1923.964836] altp2m_vcpu_reset() > (XEN) [ 1923.964837] 1 altp2m_vcpu_update_p2m() > (XEN) [ 1923.964838] vmx_vcpu_update_eptp() > (XEN) [ 1923.964876] HVMOP_altp2m_vcpu_enable_notify > (XEN) [ 1923.964878] vmx_vcpu_update_vmfunc_ve(0), > v-

Re: [Xen-devel] [PATCH V2 2/2] x86/altp2m: Fixed domain crash with INVALID_ALTP2M EPTP index

2018-06-25 Thread Razvan Cojocaru
On 06/25/2018 03:28 PM, Jan Beulich wrote: On 25.06.18 at 14:12, wrote: >> On 06/22/2018 07:55 PM, Razvan Cojocaru wrote: >>> On 06/22/2018 06:28 PM, Jan Beulich wrote: >>> On 13.06.18 at 10:52, wrote: > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@

Re: [Xen-devel] [PATCH for-4.11 v2] x86/EFI: further correct FPU state handling around runtime calls

2018-06-25 Thread Andrew Cooper
On 25/06/18 13:17, Jan Beulich wrote: > We must not leave a vCPU with CR0.TS clear when it is not in fully eager > mode and has not touched non-lazy state. Instead of adding a 3rd > invocation of stts() to vcpu_restore_fpu_eager(), consolidate all of > them into a single one done at the end of the

Re: [Xen-devel] [PATCH for-4.11 v2] x86/EFI: further correct FPU state handling around runtime calls

2018-06-25 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 25 June 2018 13:18 > To: xen-devel > Cc: Andrew Cooper ; Paul Durrant > ; Juergen Gross > Subject: [PATCH for-4.11 v2] x86/EFI: further correct FPU state handling > around runtime calls > > We must not leave a vC

Re: [Xen-devel] [PATCH V2 2/2] x86/altp2m: Fixed domain crash with INVALID_ALTP2M EPTP index

2018-06-25 Thread Jan Beulich
>>> On 25.06.18 at 14:12, wrote: > On 06/22/2018 07:55 PM, Razvan Cojocaru wrote: >> On 06/22/2018 06:28 PM, Jan Beulich wrote: >> On 13.06.18 at 10:52, wrote: --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -3592,7 +3592,7 @@ void vmx_vmexit_handler(struct

[Xen-devel] [PATCH for-4.11 v2] x86/EFI: further correct FPU state handling around runtime calls

2018-06-25 Thread Jan Beulich
We must not leave a vCPU with CR0.TS clear when it is not in fully eager mode and has not touched non-lazy state. Instead of adding a 3rd invocation of stts() to vcpu_restore_fpu_eager(), consolidate all of them into a single one done at the end of the function. Rename the function at the same tim

Re: [Xen-devel] [PATCH V2 2/2] x86/altp2m: Fixed domain crash with INVALID_ALTP2M EPTP index

2018-06-25 Thread Razvan Cojocaru
On 06/22/2018 07:55 PM, Razvan Cojocaru wrote: > On 06/22/2018 06:28 PM, Jan Beulich wrote: > On 13.06.18 at 10:52, wrote: >>> --- a/xen/arch/x86/hvm/vmx/vmx.c >>> +++ b/xen/arch/x86/hvm/vmx/vmx.c >>> @@ -3592,7 +3592,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) >>> }

[Xen-devel] [PATCH v2 6/6] tools: --with-system-{ovmf, seabios, ipxe} should provide absolute paths

2018-06-25 Thread Wei Liu
The paths shouldn't be set to "yes". Reported-by: Anthony Perard Signed-off-by: Wei Liu --- Cc: Ian Jackson new in v2 --- tools/configure| 3 +++ tools/configure.ac | 3 +++ 2 files changed, 6 insertions(+) diff --git a/tools/configure b/tools/configure index 16960a425b..b40d6646fb 10075

[Xen-devel] [PATCH v2 1/6] Tools.mk.in: drop unused variables

2018-06-25 Thread Wei Liu
Signed-off-by: Wei Liu --- Cc: Ian Jackson --- config/Tools.mk.in | 2 -- 1 file changed, 2 deletions(-) diff --git a/config/Tools.mk.in b/config/Tools.mk.in index 2d6c440324..4cc9f29090 100644 --- a/config/Tools.mk.in +++ b/config/Tools.mk.in @@ -20,8 +20,6 @@ BCC := @BCC@ IAS

[Xen-devel] [PATCH v2 0/6] Load ipxe from a standalone file

2018-06-25 Thread Wei Liu
Addressed some comments in this new version. Cc: Jan Beulich Cc: Andrew Cooper Cc: Ian Jackson Cc: Anoob Soman Cc: Doug Goldstein Wei Liu (6): Tools.mk.in: drop unused variables ipxe: produce a single binary from its build libxc: allow HVM guest to have modules tools: load IPXE from

[Xen-devel] [PATCH v2 2/6] ipxe: produce a single binary from its build

2018-06-25 Thread Wei Liu
And switch hvmloader/Makefile to use that binary. This will help later when we change hvmloader to pick a user provided binary. No functional change. Signed-off-by: Wei Liu Acked-by: Jan Beulich --- v2: use intermediary file Cc: Ian Jackson --- tools/firmware/etherboot/Makefile | 7 ++-

[Xen-devel] [PATCH v2 4/6] tools: load IPXE from standalone file

2018-06-25 Thread Wei Liu
Do not embed IPXE into Rombios anymore. Instead, it is loaded by the toolstack from a file as a separate module. Ability to let user specify an IPXE blob will come later. No user visible change. Signed-off-by: Wei Liu --- Cc: Jan Beulich Cc: Andrew Cooper Cc: anthony.per...@citrix.com --- to

[Xen-devel] [PATCH v2 3/6] libxc: allow HVM guest to have modules

2018-06-25 Thread Wei Liu
Lift the loading code out of PVH specific branch. Take the chance to make the debug message more useful. IPXE will be loaded as a module of Rombios. Signed-off-by: Wei Liu --- Cc: Ian Jackson --- tools/libxc/xc_dom_x86.c | 32 ++-- 1 file changed, 18 insertions(+),

[Xen-devel] [PATCH v2 5/6] tools: provide --with-system-ipxe

2018-06-25 Thread Wei Liu
Signed-off-by: Wei Liu --- Cc: Ian Jackson --- config/Tools.mk.in| 1 + tools/config.h.in | 3 +++ tools/configure | 53 +++ tools/configure.ac| 18 tools/libxl/libxl_paths.c | 6 +- 5 files cha

[Xen-devel] [qemu-mainline test] 124636: trouble: blocked/broken/pass

2018-06-25 Thread osstest service owner
flight 124636 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/124636/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-amd64-pvops

Re: [Xen-devel] [PATCH v3 5/6] vpt: add support for level interrupts

2018-06-25 Thread Roger Pau Monné
On Fri, Jun 22, 2018 at 08:23:02AM -0600, Jan Beulich wrote: > >>> On 08.06.18 at 17:07, wrote: > > @@ -316,7 +317,9 @@ int pt_update_irq(struct vcpu *v) > > if ( pt->pending_intr_nr ) > > { > > /* RTC code takes care of disabling the timer itself. */ > > -

[Xen-devel] [PATCH] x86/Xen: further refine add_preferred_console() invocations

2018-06-25 Thread Jan Beulich
As the sequence of invocations matters, add "tty" only after "hvc" when a VGA console is available (which is often the case for Dom0, but hardly ever for DomU). Signed-off-by: Jan Beulich --- Slightly RFC, as there may be side effects which I simply haven't observed myself yet. --- arch/x86/xen/

[Xen-devel] [PATCH] compat-ioctl/Xen: support at least some IOCTLs of evtchn and privcmd

2018-06-25 Thread Jan Beulich
While this is only a start (IOCTL_PRIVCMD_MMAP* and IOCTL_PRIVCMD_DM_OP require more work), it at least allows some simple operations (like "xl dmesg") which have always been available on XenoLinux to work again with a 64-bit kernel underneath a 32-bit distro. Signed-off-by: Jan Beulich --- fs/c

[Xen-devel] [PATCH] x86/Xen: mark xen_setup_gdt() __init

2018-06-25 Thread Jan Beulich
Its only caller is __init, so to avoid section mismatch warnings when a compiler decides to not inline the function marke this function so as well. Take the opportunity and also make the function actually use its argument: The sole caller passes in zero anyway. Signed-off-by: Jan Beulich --- arc

[Xen-devel] [libvirt test] 124660: regressions - trouble: blocked/broken/fail/pass

2018-06-25 Thread osstest service owner
flight 124660 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/124660/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm broken build-armhf-pvops

[Xen-devel] [PATCH RESEND] xen/mcelog: eliminate redundant setting of interface version

2018-06-25 Thread Jan Beulich
This already gets done in HYPERVISOR_mca(). Signed-off-by: Jan Beulich --- drivers/xen/mcelog.c |2 -- 1 file changed, 2 deletions(-) --- 4.18-rc2/drivers/xen/mcelog.c +++ 4.18-rc2-xen-mcelog-interface-version/drivers/xen/mcelog.c @@ -288,7 +288,6 @@ static int mc_queue_handle(uint32_t flag

[Xen-devel] [PATCH] xen/ACPI: don't upload Px/Cx data for disabled processors

2018-06-25 Thread Jan Beulich
This is unnecessary and triggers a warning in the hypervisor. Often systems have more processor entries in their ACPI tables than are actually installed/active. The ACPI_STA_DEVICE_PRESENT bit cannot be reliably used, but the ACPI_MADT_ENABLED bit can. In order to not introduce new functions in th

[Xen-devel] [distros-debian-sid test] 74906: trouble: blocked/broken

2018-06-25 Thread Platform Team regression test user
flight 74906 distros-debian-sid real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/74906/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-pvopsbroken build-i386

Re: [Xen-devel] Commit moratorium for preparing 4.11 branch

2018-06-25 Thread Ian Jackson
Juergen Gross writes ("[Xen-devel] Commit moratorium for preparing 4.11 branch"): > Committers, > > Please don't push any new patch to staging because osstest should > catch up to do a push. As soon as this has happened I'm planning to > initiate branching off Xen 4.11. > > Another email will be

Re: [Xen-devel] [linux-next test] 124593: regressions - trouble: broken/fail/pass

2018-06-25 Thread Ian Jackson
osstest service owner writes ("[linux-next test] 124593: regressions - trouble: broken/fail/pass"): > test-amd64-amd64-xl-qemut-ws16-amd64 4 host-install(4) broken REGR. vs. > 124373 > test-armhf-armhf-xl-multivcpu 4 host-install(4) broken REGR. vs. > 124373 > test-armhf-armhf-xl-credi

Re: [Xen-devel] [PATCH v3 6/6] vhpet: add support for level triggered interrupts

2018-06-25 Thread Roger Pau Monné
On Mon, Jun 25, 2018 at 02:26:00AM -0600, Jan Beulich wrote: > >>> On 22.06.18 at 18:07, wrote: > > On Fri, Jun 22, 2018 at 10:00:41AM -0600, Jan Beulich wrote: > >> >>> On 22.06.18 at 17:31, wrote: > >> > On Fri, Jun 22, 2018 at 09:00:27AM -0600, Jan Beulich wrote: > >> >> >>> On 08.06.18 at 17:

Re: [Xen-devel] [PATCH v3 07/13] xen/arm: Simplify alternative patching of non-writable region

2018-06-25 Thread Julien Grall
Hi Konrad, On 22/06/18 14:33, Konrad Rzeszutek Wilk wrote: On Tue, Jun 12, 2018 at 11:06:16PM +0100, Julien Grall wrote: On 12/06/2018 22:17, Konrad Rzeszutek Wilk wrote: On Tue, Jun 12, 2018 at 12:36:37PM +0100, Julien Grall wrote: Won't this mean the traps (if there are any) won't be recogni

Re: [Xen-devel] [PATCH for-next 4/5] tools: load IPXE from standalone file

2018-06-25 Thread Jan Beulich
>>> On 25.06.18 at 10:16, wrote: > On Mon, Jun 04, 2018 at 02:47:57PM +0100, Anthony PERARD wrote: >> On Tue, May 15, 2018 at 07:22:42PM +0100, Wei Liu wrote: >> > diff --git a/tools/firmware/hvmloader/hvmloader.c >> > b/tools/firmware/hvmloader/hvmloader.c >> > index f603f68ded..f546cfb3ab 10064

Re: [Xen-devel] [PATCH v1] stubdom/vtpm: fix memcmp in TPM_ChangeAuthAsymFinish

2018-06-25 Thread Wei Liu
On Mon, Jun 18, 2018 at 03:04:46PM +0200, Samuel Thibault wrote: > Olaf Hering, le lun. 18 juin 2018 14:55:36 +0200, a ecrit: > > gcc8 spotted this error: > > error: 'memcmp' reading 20 bytes from a region of size 8 > > [-Werror=stringop-overflow=] > > > > Signed-off-by: Olaf Hering > > Indeed!

Re: [Xen-devel] 4.11.0 RC1 panic

2018-06-25 Thread Manuel Bouyer
On Thu, Jun 14, 2018 at 08:33:17AM -0600, Jan Beulich wrote: > > So far I've not been able to make Xen panic with the new xen kernel. > > Attached is a log of the serial console, in case you notice something. > > None of the printk()s replacing ASSERT()s have triggered, so nothing > interesting to

Re: [Xen-devel] [PATCH v3 6/6] vhpet: add support for level triggered interrupts

2018-06-25 Thread Jan Beulich
>>> On 22.06.18 at 18:07, wrote: > On Fri, Jun 22, 2018 at 10:00:41AM -0600, Jan Beulich wrote: >> >>> On 22.06.18 at 17:31, wrote: >> > On Fri, Jun 22, 2018 at 09:00:27AM -0600, Jan Beulich wrote: >> >> >>> On 08.06.18 at 17:07, wrote: >> >> > @@ -394,6 +411,32 @@ static int hpet_write( >> >> >

Re: [Xen-devel] XSM in osstest, grub config, outstanding patch

2018-06-25 Thread Wei Liu
On Tue, May 29, 2018 at 12:29:36AM -0500, Doug Goldstein wrote: > On 5/17/18 10:09 AM, Ian Jackson wrote: > > Hi, I'm emailing you because I know you have an interest in XSM > > (and therefore in its testing in osstest). > > > > osstest manages the booting of its test hosts using the > > distro-su

Re: [Xen-devel] [PATCH for-next 4/5] tools: load IPXE from standalone file

2018-06-25 Thread Wei Liu
On Mon, Jun 04, 2018 at 02:47:57PM +0100, Anthony PERARD wrote: > On Tue, May 15, 2018 at 07:22:42PM +0100, Wei Liu wrote: > > diff --git a/tools/firmware/hvmloader/hvmloader.c > > b/tools/firmware/hvmloader/hvmloader.c > > index f603f68ded..f546cfb3ab 100644 > > --- a/tools/firmware/hvmloader/hvm

Re: [Xen-devel] [PATCH for-next 5/5] tools: provide --with-system-ipxe

2018-06-25 Thread Wei Liu
On Mon, Jun 04, 2018 at 02:59:21PM +0100, Anthony PERARD wrote: > On Tue, May 15, 2018 at 07:22:43PM +0100, Wei Liu wrote: > > diff --git a/tools/configure.ac b/tools/configure.ac > > index 0826af8cbc..8e4b173d6f 100644 > > --- a/tools/configure.ac > > +++ b/tools/configure.ac > > @@ -241,6 +242,23

  1   2   >