Re: [Xen-devel] [PATCH] pass-through: adjust pIRQ migration

2018-09-12 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Monday, September 10, 2018 9:59 PM > > For one it is quite pointless to iterate over all pIRQ-s the domain has > when just one is being adjusted. Introduce hvm_migrate_pirq(). it's migrate_pirq being introduced here. > > Additionally it is

Re: [Xen-devel] [PATCH v2 1/1] cameraif: add ABI for para-virtual camera

2018-09-12 Thread Oleksandr Andrushchenko
On 09/12/2018 05:38 PM, Hans Verkuil wrote: On 09/12/18 16:15, Oleksandr Andrushchenko wrote: On 09/12/2018 04:38 PM, Hans Verkuil wrote: On 09/12/18 15:02, Oleksandr Andrushchenko wrote: On 09/12/2018 03:25 PM, Hans Verkuil wrote: + * formats + * Values: + * + * Formats

Re: [Xen-devel] [PATCH] xen: fix GCC warning and remove duplicate EVTCHN_ROW/EVTCHN_COL usage

2018-09-12 Thread Juergen Gross
On 13/09/18 03:13, Josh Abraham wrote: > This patch removes duplicate macro useage in events_base.c. > > It also fixes gcc warning: > variable ‘col’ set but not used [-Wunused-but-set-variable] > > Signed-off-by: Joshua Abraham Reviewed-by: Juergen Gross Juergen

[Xen-devel] [PATCH] xen: fix GCC warning and remove duplicate EVTCHN_ROW/EVTCHN_COL usage

2018-09-12 Thread Josh Abraham
This patch removes duplicate macro useage in events_base.c. It also fixes gcc warning: variable ‘col’ set but not used [-Wunused-but-set-variable] Signed-off-by: Joshua Abraham --- drivers/xen/events/events_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Xen-devel] [ovmf test] 127554: all pass - PUSHED

2018-09-12 Thread osstest service owner
flight 127554 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/127554/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 7c41b8135de692ea45334747b73936ea6804622f baseline version: ovmf

[Xen-devel] [xen-unstable test] 127541: tolerable FAIL - PUSHED

2018-09-12 Thread osstest service owner
flight 127541 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/127541/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-xtf-amd64-amd64-4 104 leak-check/check fail in 127520 pass in 127541 test-amd64-i386-rumprun-i386 17

[Xen-devel] [linux-linus test] 127535: regressions - FAIL

2018-09-12 Thread osstest service owner
flight 127535 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/127535/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs. 125898

[Xen-devel] null scheduler bug

2018-09-12 Thread Stefano Stabellini
Hi Dario, Milan has just found a bug in the null scheduler: apparently it is not possible to start a VM again after it has been destroyed. My initial suspicion was that the VM wasn't properly destroyed, but I asked Milan to double check with xl list, and the VM doesn't show in the list anymore.

[Xen-devel] [linux-next test] 127531: regressions - FAIL

2018-09-12 Thread osstest service owner
flight 127531 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/127531/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-boot fail REGR. vs. 127516

[Xen-devel] [ovmf baseline-only test] 75207: trouble: blocked/broken

2018-09-12 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75207 ovmf real [real] http://osstest.xensource.com/osstest/logs/75207/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm

Re: [Xen-devel] [PATCH v2] schedule: move last_run_time to the credit scheduler privates

2018-09-12 Thread Andrii Anisov
On 12.09.18 20:27, Dario Faggioli wrote: On Wed, 2018-09-12 at 17:47 +0300, Andrii Anisov wrote: From: Andrii Anisov The structure member last_run_time is used by credit scheduler only. So move it from a generic vcpu sctructure to the credit scheduler private vcpu definition. Signed-off-by:

[Xen-devel] PXE boot with e1000 using OVMF

2018-09-12 Thread Tamas K Lengyel
HI all, I'm experimenting with OVMF and I checked to see if OVMF can do PXE boot out-of-the box with a e1000 emulated network interface and was surprised to find that it does not. After reading some of the prior discussions on the topic (https://lists.gt.net/xen/devel/382432 and

[Xen-devel] [PATCH v4 1/2] Created tools/shared directory containing MD5 files

2018-09-12 Thread Joshua Perrett
MD5 code is originally from the public domain (written by Colin Plumb in 1993), files taken from xen/tools/blktap2/drivers/. They have been modified slightly (useful functions made public). Signed-off-by: Joshua perrett --- tools/Makefile| 1 + tools/Rules.mk| 1 +

[Xen-devel] [PATCH v4 2/2] libxl: made vm mac address assignment deterministic

2018-09-12 Thread Joshua Perrett
Uses MD5 on a host mac address, the vm name and vif index to generate the last three bytes of the vm mac address (for each vm). It uses the vif index to account for multiple vifs. Reported-by: George Dunlap Signed-off-by: Joshua Perrett --- tools/libxl/Makefile | 2 +-

[Xen-devel] [PATCH v4 0/2] libxl: deterministic mac addresses

2018-09-12 Thread Joshua Perrett
The patch has now been split into two parts. One adds the MD5 files to a shared directory in tools, so that it can potentially be reused. The second patch makes mac addresses deterministic. It still uses a host mac address, seeing as gethostid() won't work (as George explained). The code should

Re: [Xen-devel] [PATCH 5/5] formats: print time values as decimals

2018-09-12 Thread Dario Faggioli
On Wed, 2018-09-12 at 20:28 +0300, Andrii Anisov wrote: > On 12.09.18 10:54, Dario Faggioli wrote: > > > > Or, in general, what I think would be useful, is to have the > > timestamps > > and the scheduling parameters in the same domain (when possible). > > As I understand, now we do have among

[Xen-devel] [PATCH] x86/xen: disable cpu0 hotplug for xen pv

2018-09-12 Thread Juergen Gross
Xen pv guests don't allow cpu0 hotplug, so disable it. Signed-off-by: Juergen Gross --- arch/x86/kernel/topology.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/topology.c b/arch/x86/kernel/topology.c index 12cbe2b88c0f..738bf42b0218 100644 ---

[Xen-devel] [xen-unstable-smoke test] 127542: tolerable all pass - PUSHED

2018-09-12 Thread osstest service owner
flight 127542 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/127542/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] [PATCH 5/5] formats: print time values as decimals

2018-09-12 Thread Andrii Anisov
On 12.09.18 10:54, Dario Faggioli wrote: Reviewed-by: Dario Faggioli Thank you. Andrii, if you decide to make the patch that turns timestamps into secs.nsecs, can we also convert these to such format (again, in case we have MHz)? I plan to do the patch. I'll keep this mind. Or, in

Re: [Xen-devel] [PATCH v2] schedule: move last_run_time to the credit scheduler privates

2018-09-12 Thread Dario Faggioli
On Wed, 2018-09-12 at 17:47 +0300, Andrii Anisov wrote: > From: Andrii Anisov > > The structure member last_run_time is used by credit scheduler only. > So move it from a generic vcpu sctructure to the credit scheduler > private > vcpu definition. > > Signed-off-by: Andrii Anisov > --- >

Re: [Xen-devel] [PATCH 1/5] xentrace_format: print timestamps in nanoseconds

2018-09-12 Thread Andrii Anisov
Hello George, On 11.09.18 18:54, George Dunlap wrote: FYI, I never use xentrace_format; as far as I'm concerned it's been made obsolete by xenalyze, and if it were up to me I'd remove it from the tree. Lots of people seem to find it useful, so I review patches. But I really care very little

Re: [Xen-devel] [PATCH v2] xen/domain: Remove trailing whitespace

2018-09-12 Thread Andrii Anisov
Hello Andrew, On 11.09.18 18:38, Andrew Cooper wrote: Acked-by: Andrew Cooper Thank you. -- *Andrii Anisov* ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH v3] Change timestamps representation for keyhandlers

2018-09-12 Thread Andrii Anisov
From: Andrii Anisov For different keyhandlers, replace a hex with delimiter representation of time to PRI_stime which is decimal ns currently. Signed-off-by: Andrii Anisov --- Changes in v3: - patch a missed dump_domains() keyhandler Changes in v2: - Time representation change

Re: [Xen-devel] [PATCH v2] Change a time printout representation for keyhandlers

2018-09-12 Thread Andrii Anisov
On 12.09.18 19:47, Dario Faggioli wrote: Right. But am I missing something, or you forgot dump_domains() in xen/common/keyhandler.c ? You are OK. I've missed it :( -- *Andrii Anisov* ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

Re: [Xen-devel] [PATCH v2] Change a time printout representation for keyhandlers

2018-09-12 Thread Dario Faggioli
On Wed, 2018-09-12 at 18:58 +0300, Andrii Anisov wrote: > From: Andrii Anisov > > For different keyhandlers, replace a hex with delimiter > representation > of time to PRI_stime which is decimal ns currently. > > Signed-off-by: Andrii Anisov > --- > > Changes in v2: > - Time

[Xen-devel] [linux-linus bisection] complete test-amd64-i386-xl

2018-09-12 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-xl testid guest-start Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git

Re: [Xen-devel] [PATCH 1/5] xentrace_format: print timestamps in nanoseconds

2018-09-12 Thread Andrii Anisov
Hello Dario, On 12.09.18 10:42, Dario Faggioli wrote: Sorry, I'm not sure I'm getting this properly. When you say "with the current formula", do you mean before or after this series? I did mean the formula existing before this series. IAC, changing the default format file that we ship so

Re: [Xen-devel] [PATCH v6 14/14] x86: extend the map and unmap iommu_ops to support grant references

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 15:13 > To: Paul Durrant > Cc: Julien Grall ; Andrew Cooper > ; Wei Liu ; George > Dunlap ; Ian Jackson ; > Stefano Stabellini ; xen-devel de...@lists.xenproject.org>; Konrad Rzeszutek Wilk > ;

[Xen-devel] [PATCH v2] Change a time printout representation for keyhandlers

2018-09-12 Thread Andrii Anisov
From: Andrii Anisov For different keyhandlers, replace a hex with delimiter representation of time to PRI_stime which is decimal ns currently. Signed-off-by: Andrii Anisov --- Changes in v2: - Time representation change propagated to all keyhandlers as agreed here [1] - Title and

Re: [Xen-devel] BUG: sched=credit2 crashes system when using cpupools

2018-09-12 Thread Steven Haigh
On Thursday, 13 September 2018 1:11:20 AM AEST Dario Faggioli wrote: > On Thu, 2018-08-30 at 18:49 +1000, Steven Haigh wrote: > > On 2018-08-30 18:33, Jan Beulich wrote: > > > Anyway - as Jürgen says, something for the scheduler > > > maintainers to look into. > > Ok, I'm back. > > > Yep - I

Re: [Xen-devel] RFE: Detect NUMA misconfigurations and prevent machine freezes

2018-09-12 Thread Dario Faggioli
On Thu, 2018-08-30 at 14:01 +1000, Steven Haigh wrote: > On 2018-08-29 15:49, Juergen Gross wrote: > > > > RAM placement should not matter here. As the name already suggests > > cpupools do assignment of cpus. RAM allocated will be preferred > > taken > > from a local node, but this shouldn't be

Re: [Xen-devel] BUG: sched=credit2 crashes system when using cpupools

2018-09-12 Thread Dario Faggioli
On Thu, 2018-08-30 at 18:49 +1000, Steven Haigh wrote: > On 2018-08-30 18:33, Jan Beulich wrote: > > > > > > > Anyway - as Jürgen says, something for the scheduler > > maintainers to look into. > Ok, I'm back. > Yep - I just want to confirm that we tested this in BOTH NUMA > configurations -

Re: [Xen-devel] [PATCH v2] xen/vcpu: Rework sanity checks in vcpu_create()

2018-09-12 Thread Jan Beulich
>>> On 11.09.18 at 18:46, wrote: > Poisoning idle_vcpu[0] with the sanity debug value isn't actually a clever > idea, because it passes a NULL pointer check but isn't a usable vcpu. It is > also the reason for the (!is_idle_domain(d) || vcpu_id) part of the existing > sanity BUG_ON(). But you

[Xen-devel] [PATCH v2] schedule: move last_run_time to the credit scheduler privates

2018-09-12 Thread Andrii Anisov
From: Andrii Anisov The structure member last_run_time is used by credit scheduler only. So move it from a generic vcpu sctructure to the credit scheduler private vcpu definition. Signed-off-by: Andrii Anisov --- Changes in v2: - last_run_time type changed to s_time_t - scurr changed

[Xen-devel] [ovmf baseline-only test] 75205: trouble: blocked/broken

2018-09-12 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75205 ovmf real [real] http://osstest.xensource.com/osstest/logs/75205/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm

Re: [Xen-devel] [PATCH v2 1/1] cameraif: add ABI for para-virtual camera

2018-09-12 Thread Hans Verkuil
On 09/12/18 16:15, Oleksandr Andrushchenko wrote: > On 09/12/2018 04:38 PM, Hans Verkuil wrote: >> On 09/12/18 15:02, Oleksandr Andrushchenko wrote: >>> On 09/12/2018 03:25 PM, Hans Verkuil wrote: >>> + * formats >>> + * Values: >>> + * >>> + * Formats are

[Xen-devel] [xen-unstable test] 127520: regressions - FAIL

2018-09-12 Thread osstest service owner
flight 127520 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/127520/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-xtf-amd64-amd64-4 104 leak-check/checkfail REGR. vs. 127489 Tests which did

Re: [Xen-devel] [PATCH v2 1/1] cameraif: add ABI for para-virtual camera

2018-09-12 Thread Oleksandr Andrushchenko
On 09/12/2018 04:38 PM, Hans Verkuil wrote: On 09/12/18 15:02, Oleksandr Andrushchenko wrote: On 09/12/2018 03:25 PM, Hans Verkuil wrote: + * formats + * Values: + * + * Formats are organized as a set of directories one per each + * supported pixel format. The name of

Re: [Xen-devel] [PATCH v6 14/14] x86: extend the map and unmap iommu_ops to support grant references

2018-09-12 Thread Jan Beulich
>>> On 23.08.18 at 11:47, wrote: > +int > +acquire_gref_for_iommu(struct domain *d, grant_ref_t gref, > + bool readonly, mfn_t *mfn) > +{ > +struct domain *currd = current->domain; > +struct grant_table *gt = d->grant_table; > +grant_entry_header_t *shah; > +

Re: [Xen-devel] [PATCH v6 1/3] x86/mm: Change default value for suppress #VE in set_mem_access()

2018-09-12 Thread Tamas K Lengyel
On Wed, Sep 12, 2018 at 1:50 AM Adrian Pop wrote: > > From: Vlad Ioan Topan > > The default value for the "suppress #VE" bit set by set_mem_access() > currently depends on whether the call is made from the same domain (the > bit is set when called from another domain and cleared if called from >

Re: [Xen-devel] [PATCH v2 08/13] optee: add support for RPC SHM buffers

2018-09-12 Thread Volodymyr Babchuk
Hi, On 12.09.18 13:59, Julien Grall wrote: Hi Volodymyr, On 09/11/2018 08:30 PM, Volodymyr Babchuk wrote: On 11.09.18 14:53, Julien Grall wrote: On 10/09/18 18:44, Volodymyr Babchuk wrote: On 10.09.18 16:01, Julien Grall wrote: On 03/09/18 17:54, Volodymyr Babchuk wrote: OP-TEE usually

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 14:39 > To: Paul Durrant > Cc: George Dunlap ; Kevin Tian > ; xen-devel > Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops > > >>> On 12.09.18 at 15:25, wrote: > >>

[Xen-devel] [freebsd-master test] 127532: all pass - PUSHED

2018-09-12 Thread osstest service owner
flight 127532 freebsd-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/127532/ Perfect :-) All tests in this flight passed as required version targeted for testing: freebsd fb9b6e89c258993ee5fbbe0d0fcd444b1b6da413 baseline version: freebsd

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 15:25, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 12 September 2018 14:20 >> To: Paul Durrant >> Cc: George Dunlap ; Kevin Tian >> ; xen-devel >> Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops >> >>

Re: [Xen-devel] [PATCH v2 1/1] cameraif: add ABI for para-virtual camera

2018-09-12 Thread Hans Verkuil
On 09/12/18 15:02, Oleksandr Andrushchenko wrote: > On 09/12/2018 03:25 PM, Hans Verkuil wrote: > + * formats > + * Values: > + * > + * Formats are organized as a set of directories one per each > + * supported pixel format. The name of the directory is

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 14:20 > To: Paul Durrant > Cc: George Dunlap ; Kevin Tian > ; xen-devel > Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops > > >>> On 12.09.18 at 14:53, wrote: > > The

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 14:53, wrote: > The function will never return its results to a guest, PV or HVM, so I > really don't see the concern. It's a low level function, for Xen's internal > use only. It's essentially the equivalent of a p2m lookup function and > there's no way we'd ever expose the

Re: [Xen-devel] [PATCH v2 1/1] cameraif: add ABI for para-virtual camera

2018-09-12 Thread Oleksandr Andrushchenko
On 09/12/2018 03:25 PM, Hans Verkuil wrote: On 09/12/18 12:09, Oleksandr Andrushchenko wrote: Hi, Hans! Thank you for valuable comments and valid concerns! On 09/12/2018 10:52 AM, Hans Verkuil wrote: On 09/11/2018 10:29 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko This

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 13:39 > To: Paul Durrant > Cc: George Dunlap ; Kevin Tian > ; xen-devel > Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops > > >>> On 12.09.18 at 14:22, wrote: > >>

Re: [Xen-devel] [PATCH v2 09/13] optee: add support for arbitrary shared memory

2018-09-12 Thread Volodymyr Babchuk
Hi, On 12.09.18 14:02, Julien Grall wrote: On 09/11/2018 08:33 PM, Volodymyr Babchuk wrote: Hi Julien, Hi, On 11.09.18 16:37, Julien Grall wrote: Hi Volodymyr, On 10/09/18 19:04, Volodymyr Babchuk wrote: On 10.09.18 17:02, Julien Grall wrote: On 03/09/18 17:54, Volodymyr Babchuk

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 14:22, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 12 September 2018 13:15 >> To: Paul Durrant >> Cc: George Dunlap ; Kevin Tian >> ; xen-devel >> Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops >> >>

Re: [Xen-devel] [PATCH v2 1/1] cameraif: add ABI for para-virtual camera

2018-09-12 Thread Hans Verkuil
On 09/12/18 12:09, Oleksandr Andrushchenko wrote: > Hi, Hans! > > Thank you for valuable comments and valid concerns! > > On 09/12/2018 10:52 AM, Hans Verkuil wrote: >> On 09/11/2018 10:29 AM, Oleksandr Andrushchenko wrote: >>> From: Oleksandr Andrushchenko >>> >>> This is the ABI for the two

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 13:15 > To: Paul Durrant > Cc: George Dunlap ; Kevin Tian > ; xen-devel > Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops > > >>> On 12.09.18 at 12:09, wrote: > >>

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 12:09, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 12 September 2018 11:08 >> To: Paul Durrant >> Cc: George Dunlap ; Kevin Tian >> ; xen-devel >> Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops >> >>

Re: [Xen-devel] [PATCH v7 1/6] iommu: introduce the concept of DFN...

2018-09-12 Thread Roger Pau Monné
On Wed, Sep 12, 2018 at 12:30:23PM +0100, Paul Durrant wrote: > diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h > index e35d941f3c..19d5d55d79 100644 > --- a/xen/include/xen/iommu.h > +++ b/xen/include/xen/iommu.h > @@ -23,11 +23,37 @@ > #include > #include > #include >

Re: [Xen-devel] [PATCH] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 13:51, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 12 September 2018 10:10 >> To: xen-devel >> Cc: Andrew Cooper ; Paul Durrant >> >> Subject: [PATCH] x86/HVM: correct hvmemul_map_linear_addr() for multi- >> page case >> >>

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-12 Thread Andrew Cooper
On 12/09/18 11:05, Jan Beulich wrote: On 12.09.18 at 11:24, wrote: >> On 12/09/18 10:17, Jan Beulich wrote: >> On 12.09.18 at 11:12, wrote: On 12/09/18 09:29, Sergey Dyasli wrote: > On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: >> @@ -822,13 +818,13 @@ int

Re: [Xen-devel] [PATCH v7 1/6] iommu: introduce the concept of DFN...

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper > Sent: 12 September 2018 12:49 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Kevin Tian ; Stefano Stabellini > ; Wei Liu ; Suravee > Suthikulpanit ; Julien Grall > ; Jan Beulich > Subject: Re: [Xen-devel] [PATCH v7 1/6] iommu:

[Xen-devel] [PATCH v4 1/3] x86/msr: Dispatch Xen and Viridian MSRs from guest_{wr, rd}msr()

2018-09-12 Thread Andrew Cooper
Despite the complicated diff in {svm,vmx}_msr_write_intercept(), it is just the 0 case losing one level of indentation, as part of removing the call to wrmsr_hypervisor_regs(). The case blocks in guest_{wr,rd}msr() use raw numbers, partly for consistency with the CPUID side of things, but mainly

Re: [Xen-devel] [PATCH v8 6/6] x86/iommu: add map-reserved dom0-iommu option to map reserved memory ranges

2018-09-12 Thread Suravee Suthikulpanit
On 9/7/18 4:07 PM, Roger Pau Monne wrote: Several people have reported hardware issues (malfunctioning USB controllers) due to iommu page faults on Intel hardware. Those faults are caused by missing RMRR (VTd) entries in the ACPI tables. Those can be worked around on VTd hardware by manually

Re: [Xen-devel] [PATCH v8 3/6] iommu: make iommu_inclusive_mapping a suboption of dom0-iommu

2018-09-12 Thread Suravee Suthikulpanit
On 9/7/18 4:07 PM, Roger Pau Monne wrote: Introduce a new dom0-iommu=map-inclusive generic option that supersedes iommu_inclusive_mapping. The previous behavior is preserved and the option should only be enabled by default on Intel hardware. Signed-off-by: Roger Pau Monné Reviewed-by: Paul

Re: [Xen-devel] [PATCH v8 1/6] iommu: rename iommu_dom0_strict and iommu_passthrough

2018-09-12 Thread Suravee Suthikulpanit
Roger, On 9/7/18 4:07 PM, Roger Pau Monne wrote: To iommu_hwdom_strict and iommu_hwdom_passthrough which is more descriptive of their usage. Also change their type from bool_t to bool. No functional change. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich Reviewed-by: Kevin Tian

Re: [Xen-devel] [PATCH] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 10:10 > To: xen-devel > Cc: Andrew Cooper ; Paul Durrant > > Subject: [PATCH] x86/HVM: correct hvmemul_map_linear_addr() for multi- > page case > > The function does two translations in one go

Re: [Xen-devel] [PATCH v7 1/6] iommu: introduce the concept of DFN...

2018-09-12 Thread Andrew Cooper
On 12/09/18 12:30, Paul Durrant wrote: > diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h > index e35d941f3c..19d5d55d79 100644 > --- a/xen/include/xen/iommu.h > +++ b/xen/include/xen/iommu.h > @@ -23,11 +23,37 @@ > #include > #include > #include > +#include > #include >

Re: [Xen-devel] v4.19-rc3, wrong pageflags in dom0

2018-09-12 Thread Juergen Gross
On 10/09/18 17:03, Olaf Hering wrote: > Am Mon, 10 Sep 2018 14:49:07 +0200 > schrieb Olaf Hering : > >> After reboot I tried to start my HVM domU, this is what I get in dom0: >> [ 223.019451] page:ea007bed9040 count:1 mapcount:-1 >> mapping: index:0x0 > > this also happens

[Xen-devel] [distros-debian-squeeze test] 75204: trouble: blocked/broken

2018-09-12 Thread Platform Team regression test user
flight 75204 distros-debian-squeeze real [real] http://osstest.xensource.com/osstest/logs/75204/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-pvopsbroken build-i386

Re: [Xen-devel] [PATCH v2] xen/vcpu: Rework sanity checks in vcpu_create()

2018-09-12 Thread Jason Andryuk
On Tue, Sep 11, 2018 at 12:48 PM Andrew Cooper wrote: > > Poisoning idle_vcpu[0] with the sanity debug value isn't actually a clever > idea, because it passes a NULL pointer check but isn't a usable vcpu. It is > also the reason for the (!is_idle_domain(d) || vcpu_id) part of the existing >

[Xen-devel] [PATCH v7 3/6] iommu: push use of type-safe DFN and MFN into iommu_ops

2018-09-12 Thread Paul Durrant
This patch modifies the methods in struct iommu_ops to use type-safe DFN and MFN. This follows on from the prior patch that modified the functions exported in xen/iommu.h. Signed-off-by: Paul Durrant Reviewed-by: Wei Liu Reviewed-by: Kevin Tian Acked-by: Jan Beulich --- Cc: Suravee

[Xen-devel] [PATCH v7 1/6] iommu: introduce the concept of DFN...

2018-09-12 Thread Paul Durrant
...meaning 'device DMA frame number' i.e. a frame number mapped in the IOMMU (rather than the MMU) and hence used for DMA address translation. This patch is a largely cosmetic change that substitutes the terms 'gfn' and 'gaddr' for 'dfn' and 'daddr' in all the places where the frame number or

[Xen-devel] [PATCH v7 5/6] memory: add check_get_page_from_gfn() as a wrapper...

2018-09-12 Thread Paul Durrant
...for some uses of get_page_from_gfn(). There are many occurences of the following pattern in the code: q = ? P2M_ALLOC : P2M_UNSHARE; page = get_page_from_gfn(d, gfn, , q); if ( p2m_is_paging(p2mt) ) { if ( page ) put_page(page);

[Xen-devel] [PATCH v7 0/6] paravirtual IOMMU pre-requisites and clean-up

2018-09-12 Thread Paul Durrant
This series contains pre-requisites and clean-up needed for paravirtual IOMMU support. I have separated these patches to avoid further delaying their application whilst I re-work the implementation of paravirtual IOMMU after review of v6 of the series. Several of them already have all necessary

[Xen-devel] [PATCH v7 6/6] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Paul Durrant
This patch adds a new method to the VT-d IOMMU implementation to find the MFN currently mapped by the specified DFN along with a wrapper function in generic IOMMU code to call the implementation if it exists. This patch also cleans up the initializers in intel_iommu_map_page() and uses

[Xen-devel] [PATCH v7 2/6] iommu: make use of type-safe DFN and MFN in exported functions

2018-09-12 Thread Paul Durrant
This patch modifies the declaration of the entry points to the IOMMU sub-system to use dfn_t and mfn_t in place of unsigned long. A subsequent patch will similarly modify the methods in the iommu_ops structure. Signed-off-by: Paul Durrant Reviewed-by: Wei Liu Reviewed-by: Kevin Tian Acked-by:

[Xen-devel] [PATCH v7 4/6] iommu: don't domain_crash() inside iommu_map/unmap_page()

2018-09-12 Thread Paul Durrant
This patch removes the implicit domain_crash() from iommu_map(), unmap_page() and iommu_iotlb_flush() and turns them into straightforward wrappers that check the existence of the relevant iommu_op and call through to it. This makes them usable by PV IOMMU code to be delivered in future patches.

Re: [Xen-devel] [PATCH v2 09/13] optee: add support for arbitrary shared memory

2018-09-12 Thread Julien Grall
On 09/11/2018 08:33 PM, Volodymyr Babchuk wrote: Hi Julien, Hi, On 11.09.18 16:37, Julien Grall wrote: Hi Volodymyr, On 10/09/18 19:04, Volodymyr Babchuk wrote: On 10.09.18 17:02, Julien Grall wrote: On 03/09/18 17:54, Volodymyr Babchuk wrote: [...] +    if ( !pages_data_xen_start

Re: [Xen-devel] [PATCH v2 08/13] optee: add support for RPC SHM buffers

2018-09-12 Thread Julien Grall
Hi Volodymyr, On 09/11/2018 08:30 PM, Volodymyr Babchuk wrote: On 11.09.18 14:53, Julien Grall wrote: On 10/09/18 18:44, Volodymyr Babchuk wrote: On 10.09.18 16:01, Julien Grall wrote: On 03/09/18 17:54, Volodymyr Babchuk wrote: OP-TEE usually uses the same idea with command buffers (see

Re: [Xen-devel] [PATCH] libxl: made vm mac address assignment deterministic

2018-09-12 Thread George Dunlap
On 09/12/2018 10:54 AM, Marcus Granado wrote: >> Wei Liu writes ("Re: [PATCH] libxl: made vm mac address assignment >> deterministic"): >>> On Wed, Sep 05, 2018 at 12:25:55PM +, Joshua Perrett wrote: >>> > Uses MD5 on the host mac address, vm name and vif index to generate >>> the >>> > last

[Xen-devel] [linux-linus test] 127516: regressions - FAIL

2018-09-12 Thread osstest service owner
flight 127516 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/127516/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs. 125898

Re: [Xen-devel] [PATCH] drivers/block/xen-blkback/common.h: use DIV_ROUND_UP instead of reimplementing its function

2018-09-12 Thread Roger Pau Monné
On Wed, Sep 12, 2018 at 10:48:42AM +0100, Julien Grall wrote: > Hi, > > On 09/12/2018 10:16 AM, Roger Pau Monné wrote: > > On Wed, Sep 12, 2018 at 11:13:50AM +0200, Roger Pau Monné wrote: > > > Adding Julien how did the work to support XEN_PAGE_SIZE != PAGE_SIZE. > > > > > > On Wed, Sep 12, 2018

Re: [Xen-devel] [PATCH v7 2/8] libxl: introduce a new structure to represent static shared memory regions

2018-09-12 Thread Julien Grall
On 09/12/2018 12:09 AM, Stefano Stabellini wrote: + +/* Constants for libxl_static_shm */ +#define LIBXL_SSHM_RANGE_UNKNOWN UINT64_MAX +#define LIBXL_SSHM_ID_MAXLEN128 Why do you need to bound the size of the string? It is passed by the user, it is good to be clear about the max size?

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-12 Thread Andrew Cooper
On 12/09/18 10:46, Sergey Dyasli wrote: > On Wed, 2018-09-12 at 10:12 +0100, Andrew Cooper wrote: >> On 12/09/18 09:29, Sergey Dyasli wrote: >>> On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: Rename them to guest_{rd,wr}msr_xen() for consistency, and because the _regs

Re: [Xen-devel] [PATCH v2 1/1] cameraif: add ABI for para-virtual camera

2018-09-12 Thread Oleksandr Andrushchenko
On 09/12/2018 12:16 PM, Hans Verkuil wrote: On 09/11/18 10:29, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko This is the ABI for the two halves of a para-virtualized camera driver which extends Xen's reach multimedia capabilities even farther enabling it for video conferencing,

Re: [Xen-devel] [PATCH v6 12/14] memory: add get_paged_gfn() as a wrapper...

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 12:01, wrote: > On 09/12/2018 10:15 AM, Jan Beulich wrote: > On 12.09.18 at 11:10, wrote: From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf Of Jan Beulich Sent: 11 September 2018 15:56 >>> On 23.08.18 at 11:47, wrote: >

Re: [Xen-devel] [PATCH v2 1/1] cameraif: add ABI for para-virtual camera

2018-09-12 Thread Oleksandr Andrushchenko
Hi, Hans! Thank you for valuable comments and valid concerns! On 09/12/2018 10:52 AM, Hans Verkuil wrote: On 09/11/2018 10:29 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko This is the ABI for the two halves of a para-virtualized camera driver which extends Xen's reach

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 11:08 > To: Paul Durrant > Cc: George Dunlap ; Kevin Tian > ; xen-devel > Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops > > >>> On 12.09.18 at 11:30, wrote: > >>

Re: [Xen-devel] [PATCH v6 12/14] memory: add get_paged_gfn() as a wrapper...

2018-09-12 Thread Paul Durrant
> -Original Message- > From: George Dunlap [mailto:george.dun...@citrix.com] > Sent: 12 September 2018 11:02 > To: Jan Beulich ; Paul Durrant > > Cc: Julien Grall ; Andrew Cooper > ; Ian Jackson ; Wei > Liu ; Stefano Stabellini ; xen- > devel ; Konrad Rzeszutek Wilk > ; Tim (Xen.org) >

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 11:30, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 12 September 2018 10:21 >> To: Paul Durrant >> Cc: George Dunlap ; Kevin Tian >> ; xen-devel >> Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops >> >>

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 11:24, wrote: > On 12/09/18 10:17, Jan Beulich wrote: > On 12.09.18 at 11:12, wrote: >>> On 12/09/18 09:29, Sergey Dyasli wrote: On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: > @@ -822,13 +818,13 @@ int wrmsr_hypervisor_regs(uint32_t idx, uint64_t >

Re: [Xen-devel] [PATCH v6 12/14] memory: add get_paged_gfn() as a wrapper...

2018-09-12 Thread George Dunlap
On 09/12/2018 10:15 AM, Jan Beulich wrote: On 12.09.18 at 11:10, wrote: >>> From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf >>> Of Jan Beulich >>> Sent: 11 September 2018 15:56 >>> >> On 23.08.18 at 11:47, wrote: ...for some uses of get_page_from_gfn().

[Xen-devel] [ovmf test] 127528: all pass - PUSHED

2018-09-12 Thread osstest service owner
flight 127528 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/127528/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 4423f0bc613b5451feaa546c3f330ad625d65638 baseline version: ovmf

Re: [Xen-devel] [PATCH] libxl: made vm mac address assignment deterministic

2018-09-12 Thread Marcus Granado
Wei Liu writes ("Re: [PATCH] libxl: made vm mac address assignment deterministic"): On Wed, Sep 05, 2018 at 12:25:55PM +, Joshua Perrett wrote: > Uses MD5 on the host mac address, vm name and vif index to generate the > last three bytes of the vm mac address (for each vm). There is no such

[Xen-devel] [xen-unstable-coverity test] 127530: all pass - PUSHED

2018-09-12 Thread osstest service owner
flight 127530 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/127530/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 1dfb8e6e0948912d1fd96d6ed9034527c5c74f31 baseline version: xen

Re: [Xen-devel] [PATCH] drivers/block/xen-blkback/common.h: use DIV_ROUND_UP instead of reimplementing its function

2018-09-12 Thread Julien Grall
Hi, On 09/12/2018 10:16 AM, Roger Pau Monné wrote: On Wed, Sep 12, 2018 at 11:13:50AM +0200, Roger Pau Monné wrote: Adding Julien how did the work to support XEN_PAGE_SIZE != PAGE_SIZE. On Wed, Sep 12, 2018 at 02:14:26AM -0600, Jan Beulich wrote: On 12.09.18 at 07:45, wrote: ---

[Xen-devel] [PATCH v2] x86/mm: Suppresses vm_events caused by page-walks

2018-09-12 Thread Alexandru Isaila
The original version of the patch emulated the current instruction (which, as a side-effect, emulated the page-walk as well), however we need finer-grained control. We want to emulate the page-walk, but still get an EPT violation event if the current instruction would trigger one. This patch

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-12 Thread Sergey Dyasli
On Wed, 2018-09-12 at 10:12 +0100, Andrew Cooper wrote: > On 12/09/18 09:29, Sergey Dyasli wrote: > > On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: > > > Rename them to guest_{rd,wr}msr_xen() for consistency, and because the > > > _regs > > > suffix isn't very appropriate. > > > > > >

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 12 September 2018 10:21 > To: Paul Durrant > Cc: George Dunlap ; Kevin Tian > ; xen-devel > Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops > > >>> On 12.09.18 at 11:15, wrote: > >>

Re: [Xen-devel] [PATCH] schedule: move last_run_time to the credit scheduler privates

2018-09-12 Thread Andrii Anisov
Hello Dario, On 12.09.18 11:14, Dario Faggioli wrote: I think that, while we're doing this, we should take the chance to convert the type to s_time_t too. Good point, as well as renaming scurr. -- *Andrii Anisov* ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-12 Thread Andrew Cooper
On 12/09/18 10:17, Jan Beulich wrote: On 12.09.18 at 11:12, wrote: >> On 12/09/18 09:29, Sergey Dyasli wrote: >>> On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: @@ -822,13 +818,13 @@ int wrmsr_hypervisor_regs(uint32_t idx, uint64_t val) if ( p2m_is_paging(t) )

Re: [Xen-devel] [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 11:15, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 12 September 2018 10:13 >> To: Paul Durrant >> Cc: George Dunlap ; Kevin Tian >> ; xen-devel >> Subject: RE: [PATCH v6 08/14] vtd: add lookup_page method to iommu_ops >> >>

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-12 Thread Jan Beulich
>>> On 12.09.18 at 11:12, wrote: > On 12/09/18 09:29, Sergey Dyasli wrote: >> On Tue, 2018-09-11 at 19:56 +0100, Andrew Cooper wrote: >>> @@ -822,13 +818,13 @@ int wrmsr_hypervisor_regs(uint32_t idx, uint64_t val) >>> if ( p2m_is_paging(t) ) >>> { >>>

  1   2   >