[Xen-devel] [xen-unstable test] 127573: regressions - trouble: broken/fail/pass

2018-09-13 Thread osstest service owner
flight 127573 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/127573/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-migrupgrade broken test-amd64-amd64-xl-qemuu-dmrestrict-amd6

[Xen-devel] [ovmf test] 127590: all pass - PUSHED

2018-09-13 Thread osstest service owner
flight 127590 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/127590/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf f316a26013f2a8cfb1041d9f74a5c6d5bb9df9c9 baseline version: ovmf 52664c525223a36e5cb9b

Re: [Xen-devel] [PATCH RESEND] tpm: Restore functionality to xen vtpm driver.

2018-09-13 Thread Jason Gunthorpe
On Thu, Sep 13, 2018 at 03:47:49PM -0400, Boris Ostrovsky wrote: > From: "Dr. Greg Wettstein" > > Functionality of the xen-tpmfront driver was lost secondary to > the introduction of xenbus multi-page support in commit ccc9d90a9a8b > ("xenbus_client: Extend interface to support multi-page ring").

Re: [Xen-devel] [PATCH v9 7/7] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Tian, Kevin
> From: Paul Durrant [mailto:paul.durr...@citrix.com] > Sent: Thursday, September 13, 2018 11:21 PM > > This patch adds a new method to the VT-d IOMMU implementation to find > the > MFN currently mapped by the specified DFN along with a wrapper function > in generic IOMMU code to call the implemen

Re: [Xen-devel] [PATCH v9 6/7] vtd: add missing check for shared EPT...

2018-09-13 Thread Tian, Kevin
> From: Paul Durrant [mailto:paul.durr...@citrix.com] > Sent: Thursday, September 13, 2018 11:21 PM > > ...in intel_iommu_unmap_page(). > > This patch also includes some non-functional modifications in > intel_iommu_map_page(). > > Signed-off-by: Paul Durrant Acked-by: Kevin Tian ___

Re: [Xen-devel] [PATCH v9 1/7] iommu: introduce the concept of DFN...

2018-09-13 Thread Tian, Kevin
> From: Paul Durrant [mailto:paul.durr...@citrix.com] > Sent: Thursday, September 13, 2018 11:21 PM > > ...meaning 'device DMA frame number' i.e. a frame number mapped in the > IOMMU > (rather than the MMU) and hence used for DMA address translation. > > This patch is a largely cosmetic change th

Re: [Xen-devel] [PATCH v2 4/4] x86/HVM: prefill cache with PDPTEs when possible

2018-09-13 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Thursday, September 13, 2018 4:55 PM > > >>> On 13.09.18 at 08:30, wrote: > >> From: Jan Beulich [mailto:jbeul...@suse.com] > >> Sent: Tuesday, September 11, 2018 9:16 PM > >> > >> Since strictly speaking it is incorrect for guest_walk_table

[Xen-devel] [xen-unstable-smoke test] 127585: tolerable all pass - PUSHED

2018-09-13 Thread osstest service owner
flight 127585 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/127585/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[Xen-devel] [ovmf baseline-only test] 75215: trouble: blocked/broken

2018-09-13 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75215 ovmf real [real] http://osstest.xensource.com/osstest/logs/75215/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm

[Xen-devel] [linux-linus test] 127569: regressions - FAIL

2018-09-13 Thread osstest service owner
flight 127569 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/127569/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs. 125898

Re: [Xen-devel] [PATCH] xen: fix GCC warning and remove duplicate EVTCHN_ROW/EVTCHN_COL usage

2018-09-13 Thread Boris Ostrovsky
On 9/13/18 1:13 AM, Juergen Gross wrote: > On 13/09/18 03:13, Josh Abraham wrote: >> This patch removes duplicate macro useage in events_base.c. >> >> It also fixes gcc warning: >> variable ‘col’ set but not used [-Wunused-but-set-variable] >> >> Signed-off-by: Joshua Abraham > Reviewed-by: Juerge

[Xen-devel] [xen-unstable-smoke test] 127581: regressions - FAIL

2018-09-13 Thread osstest service owner
flight 127581 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/127581/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt 7 xen-boot fail REGR. vs. 127575 Tests which

[Xen-devel] [PATCH v2] tpm: Restore functionality to xen vtpm driver.

2018-09-13 Thread Boris Ostrovsky
From: "Dr. Greg Wettstein" Functionality of the xen-tpmfront driver was lost secondary to the introduction of xenbus multi-page support in commit ccc9d90a9a8b ("xenbus_client: Extend interface to support multi-page ring"). In this commit a pointer to the shared page address was being passed to t

[Xen-devel] [seabios baseline-only test] 75214: trouble: blocked/broken

2018-09-13 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75214 seabios real [real] http://osstest.xensource.com/osstest/logs/75214/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm

[Xen-devel] [PATCH RESEND] tpm: Restore functionality to xen vtpm driver.

2018-09-13 Thread Boris Ostrovsky
From: "Dr. Greg Wettstein" Functionality of the xen-tpmfront driver was lost secondary to the introduction of xenbus multi-page support in commit ccc9d90a9a8b ("xenbus_client: Extend interface to support multi-page ring"). In this commit a pointer to the shared page address was being passed to t

[Xen-devel] [xen-unstable-smoke test] 127575: tolerable all pass - PUSHED

2018-09-13 Thread osstest service owner
flight 127575 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/127575/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] Reading guest page flags

2018-09-13 Thread Tamas K Lengyel
On Thu, Sep 13, 2018 at 11:48 AM Razvan Cojocaru wrote: > > On 9/13/18 8:29 PM, Spencer Michaels wrote: > > I'm writing an application that can read/write guest memory, and as part > > of that I need to check whether the page being manipulated is > > readable/writable by the guest itself. Does Xen

Re: [Xen-devel] Reading guest page flags

2018-09-13 Thread Razvan Cojocaru
On 9/13/18 8:29 PM, Spencer Michaels wrote: > I'm writing an application that can read/write guest memory, and as part > of that I need to check whether the page being manipulated is > readable/writable by the guest itself. Does Xen have an API that would > allow me to read the flags of an arbitrar

Re: [Xen-devel] null scheduler bug

2018-09-13 Thread Dario Faggioli
On Thu, 2018-09-13 at 17:18 +0200, Milan Boberic wrote: > Commits are there and I will definitely continue with 4.10 version. > But it didn't solve my problem entirely. > > I create my bare-metal application (with xl create) and destroy it > with xl destroy (it disappears from xl list) and when I

[Xen-devel] Reading guest page flags

2018-09-13 Thread Spencer Michaels
Hello, I'm writing an application that can read/write guest memory, and as part of that I need to check whether the page being manipulated is readable/writable by the guest itself. Does Xen have an API that would allow me to read the flags of an arbitrary page on a guest, given either its address

[Xen-devel] [OSSTEST PATCH] README.dev: Document things that are now handled by ansible in Mass

2018-09-13 Thread Ian Jackson
Signed-off-by: Ian Jackson --- README.dev | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/README.dev b/README.dev index a8bfbb53..eff82350 100644 --- a/README.dev +++ b/README.dev @@ -92,14 +92,14 @@ Set up any necessary host properties: For example, one might ne

Re: [Xen-devel] [PATCH v4 1/7] x86/p2m/pod: make it build with !CONFIG_HVM

2018-09-13 Thread Tamas K Lengyel
> diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c > index 4793aac..50d5ebc 100644 > --- a/xen/common/vm_event.c > +++ b/xen/common/vm_event.c > @@ -630,8 +630,6 @@ int vm_event_domctl(struct domain *d, struct > xen_domctl_vm_event_op *vec, > { > case XEN_VM_EVENT_ENABL

Re: [Xen-devel] [PATCH v4 4/7] x86/mm: put HVM only code under CONFIG_HVM

2018-09-13 Thread Tamas K Lengyel
On Thu, Sep 13, 2018 at 10:38 AM Wei Liu wrote: > > Going through the code, HAP, EPT, PoD and ALTP2M depend on HVM code. > Put these components under CONFIG_HVM. This further requires putting > one of the vm event under CONFIG_HVM. > > Altp2m requires a bit more attention because its code is embed

Re: [Xen-devel] [PATCH] Make credit2 the default scheduler

2018-09-13 Thread Dario Faggioli
On Thu, 2018-09-13 at 17:38 +0100, George Dunlap wrote: > Credit2 was declared "supported" in 4.8, and as of 4.10 had two other > critical features implemented (soft affinity / NUMA and caps). > > [..] > > Credit2, like credit, has a number of workloads / setups for which > performance could be im

Re: [Xen-devel] [PATCH] pass-through: adjust pIRQ migration

2018-09-13 Thread Wei Liu
On Mon, Sep 10, 2018 at 07:59:16AM -0600, Jan Beulich wrote: > For one it is quite pointless to iterate over all pIRQ-s the domain has > when just one is being adjusted. Introduce hvm_migrate_pirq(). > > Additionally it is bogus to migrate the pIRQ to a vCPU different from > the one the event is s

Re: [Xen-devel] [PATCH 4/4] vm_event: Add support for multi-page ring buffer

2018-09-13 Thread Tamas K Lengyel
On Thu, Sep 13, 2018 at 9:02 AM Petre Pircalabu wrote: > > In high throughput introspection scenarios where lots of monitor > vm_events are generated, the ring buffer can fill up before the monitor > application gets a chance to handle all the requests thus blocking > other vcpus which will have t

[Xen-devel] [PATCH v4 3/7] x86/mm: put nested p2m code under CONFIG_HVM

2018-09-13 Thread Wei Liu
These functions are only useful for nested hvm, which isn't enabled when CONFIG_HVM is false. Enclose relevant code and fields in CONFIG_HVM. Signed-off-by: Wei Liu --- v4: 1. Introduce p2m_nestedp2m_init --- xen/arch/x86/domain.c| 4 xen/arch/x86/mm/p2m.c| 25

Re: [Xen-devel] [PATCH v3 12/16] x86/mm: put paging_update_nestedmode under CONFIG_HVM

2018-09-13 Thread George Dunlap
On 09/04/2018 05:15 PM, Wei Liu wrote: > Nested HVM is not enabled when !CONFIG_HVM. > > Signed-off-by: Wei Liu Acked-by: George Dunlap ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH] Make credit2 the default scheduler

2018-09-13 Thread George Dunlap
Credit2 was declared "supported" in 4.8, and as of 4.10 had two other critical features implemented (soft affinity / NUMA and caps). Why change the default? The code is better: more predictable, less jitter, easier to determine how modifications will affect overall behavior, easier in the future

[Xen-devel] [PATCH v4 6/7] xen: connect guest creation with CONFIG_HVM

2018-09-13 Thread Wei Liu
Signed-off-by: Wei Liu --- v4: drop PV part to avoid breaking Arm --- xen/common/domain.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/xen/common/domain.c b/xen/common/domain.c index a043812..6dfcea4 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -315,7 +315,14 @@ str

[Xen-devel] [PATCH v4 5/7] x86/mm: put paging_update_nestedmode under CONFIG_HVM

2018-09-13 Thread Wei Liu
Nested HVM is not enabled when !CONFIG_HVM. Signed-off-by: Wei Liu --- xen/arch/x86/mm/paging.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/arch/x86/mm/paging.c b/xen/arch/x86/mm/paging.c index dcee496..7f460bd 100644 --- a/xen/arch/x86/mm/paging.c +++ b/xen/arch/x86/mm/paging.c @@

[Xen-devel] [PATCH v4 2/7] x86: provide stubs, declarations and macros in hvm.h

2018-09-13 Thread Wei Liu
Make sure hvm_enabled evaluate to false then provide necessary things to make xen build when !CONFIG_HVM. Signed-off-by: Wei Liu --- v4: 1. Add more comments. 2. Reshuffle sections a bit. 3. Don't use gcc extension, use comma expression instead. 4. Adjustment to functions prototypes. --- xen/inc

[Xen-devel] [PATCH v4 1/7] x86/p2m/pod: make it build with !CONFIG_HVM

2018-09-13 Thread Wei Liu
Populate-on-demand is HVM only. Provide a bunch of stubs for common p2m code and guard one invocation of guest_physmap_mark_populate_on_demand with is_hvm_domain. Put relevant fields in p2m_domain and code which touches those fields under CONFIG_HVM. Signed-off-by: Wei Liu --- v4: 1. Factor out

[Xen-devel] [PATCH v4 4/7] x86/mm: put HVM only code under CONFIG_HVM

2018-09-13 Thread Wei Liu
Going through the code, HAP, EPT, PoD and ALTP2M depend on HVM code. Put these components under CONFIG_HVM. This further requires putting one of the vm event under CONFIG_HVM. Altp2m requires a bit more attention because its code is embedded in generic x86 p2m code. Also make hap_enabled evaluate

[Xen-devel] [PATCH v4 7/7] x86: expose CONFIG_HVM

2018-09-13 Thread Wei Liu
Signed-off-by: Wei Liu --- v4: remove a blank line v3: longer text v2: use tab to indent Haven't added a dependency on PV_SHIM_EXCLUSIVE because agreement is not yet reached. CC more people for opinions. Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Konrad Rzeszute

[Xen-devel] [PATCH v4 0/7] Make CONFIG_HVM work

2018-09-13 Thread Wei Liu
This series goes through x86 code to make CONFIG_HVM work. With this series, it is possible to build Xen with PV support only. See cover letters from previous versions for more details. Wei. Wei Liu (7): x86/p2m/pod: make it build with !CONFIG_HVM x86: provide stubs, declarations and macros

Re: [Xen-devel] [PATCH v3 11/16] x86/mm: put HVM only code under CONFIG_HVM

2018-09-13 Thread Tamas K Lengyel
On Thu, Sep 13, 2018 at 9:43 AM Wei Liu wrote: > > On Fri, Sep 07, 2018 at 03:27:37PM -0600, Tamas K Lengyel wrote: > > On Tue, Sep 4, 2018, 10:29 AM Wei Liu wrote: > > > > > Going through the code, HAP, EPT, PoD and ALTP2M depend on HVM code. > > > Put these components under CONFIG_HVM. This fur

Re: [Xen-devel] [PATCH] tools: correct tools/tests/depriv/Makefile

2018-09-13 Thread Wei Liu
On Fri, Sep 07, 2018 at 11:16:54AM +0200, Juergen Gross wrote: > tools/tests/depriv/Makefile directly builds the target program from > its C-source. This is problematic when an incremental build is needed > after a header the program is depending on has been modified: in this > case all headers are

Re: [Xen-devel] [PATCH] tools/tests: allow depriv-fd-checker to build with really old Linux headers

2018-09-13 Thread Wei Liu
On Fri, Aug 31, 2018 at 01:02:42AM -0600, Jan Beulich wrote: > Assuming it was intentional for this test utility, other than most other > ones, to always be built, I think it would be nice if it didn't fail to > build on really old distros just because of the lack of a TUNGETIFF > definition. > >

[Xen-devel] [xen-unstable baseline-only test] 75210: trouble: blocked/broken

2018-09-13 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75210 xen-unstable real [real] http://osstest.xensource.com/osstest/logs/75210/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64

Re: [Xen-devel] [PATCH v3 01/16] x86: change name of parameter for various invlpg functions

2018-09-13 Thread George Dunlap
On 09/04/2018 05:15 PM, Wei Liu wrote: > They all incorrectly named a parameter virtual address while it should > have been linear address. > > Requested-by: Andrew Cooper > Signed-off-by: Wei Liu > Acked-by: Jan Beulich > Reviewed-by: Kevin Tian > Acked-by: Boris Ostrovsky Acked-by: George

Re: [Xen-devel] [PATCH v3 10/16] x86/mm: put nested p2m code under CONFIG_HVM

2018-09-13 Thread George Dunlap
On 09/13/2018 04:46 PM, Wei Liu wrote: > On Thu, Sep 06, 2018 at 05:20:53PM +0100, George Dunlap wrote: >> On 09/04/2018 05:15 PM, Wei Liu wrote: >>> These functions are only useful for nested hvm, which isn't enabled >>> when CONFIG_HVM is false. >>> >>> Enclose relevant code and fields in CONFIG_

Re: [Xen-devel] [PATCH v3 14/16] x86: expose CONFIG_HVM

2018-09-13 Thread Wei Liu
On Fri, Sep 07, 2018 at 01:15:05AM -0600, Jan Beulich wrote: > >>> On 04.09.18 at 18:15, wrote: > > Signed-off-by: Wei Liu > > --- > > v3: longer text > > v2: use tab to indent > > > > Haven't added a dependency on PV_SHIM_EXCLUSIVE because agreement is > > not yet reached. > > Hmm, but then I

Re: [Xen-devel] [PATCH v3 16/16] xen: decouple HVM and IOMMU capabilities

2018-09-13 Thread Ian Jackson
Wei Liu writes ("[PATCH v3 16/16] xen: decouple HVM and IOMMU capabilities"): > HVM and IOMMU are two distinct hardware features, yet they were > bundled together in sysctl and xl's output. > > Decouple them on sysctl level. On toolstack level we still need to > maintain a sensible semantics for `

Re: [Xen-devel] [PATCH v3 10/16] x86/mm: put nested p2m code under CONFIG_HVM

2018-09-13 Thread Wei Liu
On Thu, Sep 06, 2018 at 05:20:53PM +0100, George Dunlap wrote: > On 09/04/2018 05:15 PM, Wei Liu wrote: > > These functions are only useful for nested hvm, which isn't enabled > > when CONFIG_HVM is false. > > > > Enclose relevant code and fields in CONFIG_HVM. Guard np2m_schedule > > with nestedh

Re: [Xen-devel] [PATCH v3 11/16] x86/mm: put HVM only code under CONFIG_HVM

2018-09-13 Thread Wei Liu
On Fri, Sep 07, 2018 at 03:27:37PM -0600, Tamas K Lengyel wrote: > On Tue, Sep 4, 2018, 10:29 AM Wei Liu wrote: > > > Going through the code, HAP, EPT, PoD and ALTP2M depend on HVM code. > > Put these components under CONFIG_HVM. This further requires putting > > one of the vm event under CONFIG_

Re: [Xen-devel] [PATCH v3 09/16] x86: provide stubs, declarations and macros in hvm.h

2018-09-13 Thread Wei Liu
On Fri, Sep 07, 2018 at 01:02:02AM -0600, Jan Beulich wrote: > >>> On 04.09.18 at 18:15, wrote: > > @@ -675,6 +678,100 @@ static inline bool altp2m_vcpu_emulate_ve(struct vcpu > > *v) > > d_->arch.hvm.pi_ops.vcpu_block(v_); \ > > }) > > > > +#else /* CONFIG_HVM */

Re: [Xen-devel] [PATCH v9 0/6] paravirtual IOMMU pre-requisites and clean-up

2018-09-13 Thread Paul Durrant
This should clearly say 0/7 rather then 0/6. Apologies. Paul > -Original Message- > From: Paul Durrant [mailto:paul.durr...@citrix.com] > Sent: 13 September 2018 16:21 > To: xen-devel@lists.xenproject.org > Cc: Paul Durrant ; Andrew Cooper > ; George Dunlap ; Ian > Jackson ; Jan Beulich

Re: [Xen-devel] [PATCH v7 6/6] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Paul Durrant
This patch is stale. Sorry for the noise. Paul > -Original Message- > From: Paul Durrant [mailto:paul.durr...@citrix.com] > Sent: 13 September 2018 16:21 > To: xen-devel@lists.xenproject.org > Cc: Paul Durrant ; Wei Liu ; > Kevin Tian ; Jan Beulich ; George > Dunlap > Subject: [PATCH v

Re: [Xen-devel] [PATCH] xen/netfront: don't bug in case of too many frags

2018-09-13 Thread David Miller
From: Juergen Gross Date: Tue, 11 Sep 2018 09:04:48 +0200 > Commit 57f230ab04d291 ("xen/netfront: raise max number of slots in > xennet_get_responses()") raised the max number of allowed slots by one. > This seems to be problematic in some configurations with netback using > a larger MAX_SKB_FRAG

[Xen-devel] [PATCH v9 0/6] paravirtual IOMMU pre-requisites and clean-up

2018-09-13 Thread Paul Durrant
This series contains pre-requisites and clean-up needed for paravirtual IOMMU support. I have separated these patches to avoid further delaying their application whilst I re-work the implementation of paravirtual IOMMU after review of v6 of the series. Several of them already have all necessary ac

[Xen-devel] [PATCH v9 6/7] vtd: add missing check for shared EPT...

2018-09-13 Thread Paul Durrant
...in intel_iommu_unmap_page(). This patch also includes some non-functional modifications in intel_iommu_map_page(). Signed-off-by: Paul Durrant --- Cc: Wei Liu Cc: Kevin Tian Cc: Jan Beulich Cc: George Dunlap v8: - New in v8. (Split from the next patch in the series as requested by Ke

[Xen-devel] [PATCH v9 7/7] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Paul Durrant
This patch adds a new method to the VT-d IOMMU implementation to find the MFN currently mapped by the specified DFN along with a wrapper function in generic IOMMU code to call the implementation if it exists. NOTE: This patch only adds a Xen-internal interface. This will be used by a subsequ

[Xen-devel] [PATCH v9 2/7] iommu: make use of type-safe DFN and MFN in exported functions

2018-09-13 Thread Paul Durrant
This patch modifies the declaration of the entry points to the IOMMU sub-system to use dfn_t and mfn_t in place of unsigned long. A subsequent patch will similarly modify the methods in the iommu_ops structure. Signed-off-by: Paul Durrant Reviewed-by: Wei Liu Reviewed-by: Kevin Tian Reviewed-by

[Xen-devel] [PATCH v9 1/7] iommu: introduce the concept of DFN...

2018-09-13 Thread Paul Durrant
...meaning 'device DMA frame number' i.e. a frame number mapped in the IOMMU (rather than the MMU) and hence used for DMA address translation. This patch is a largely cosmetic change that substitutes the terms 'gfn' and 'gaddr' for 'dfn' and 'daddr' in all the places where the frame number or addr

[Xen-devel] [PATCH v9 5/7] memory: add check_get_page_from_gfn() as a wrapper...

2018-09-13 Thread Paul Durrant
...for some uses of get_page_from_gfn(). There are many occurrences of the following pattern in the code: q = ? P2M_ALLOC : P2M_UNSHARE; page = get_page_from_gfn(d, gfn, &p2mt, q); if ( p2m_is_paging(p2mt) ) { if ( page ) put_page(page); p2m_mem_pagi

[Xen-devel] [PATCH v7 6/6] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Paul Durrant
This patch adds a new method to the VT-d IOMMU implementation to find the MFN currently mapped by the specified DFN along with a wrapper function in generic IOMMU code to call the implementation if it exists. This patch also cleans up the initializers in intel_iommu_map_page() and uses array-style

[Xen-devel] [PATCH v9 3/7] iommu: push use of type-safe DFN and MFN into iommu_ops

2018-09-13 Thread Paul Durrant
This patch modifies the methods in struct iommu_ops to use type-safe DFN and MFN. This follows on from the prior patch that modified the functions exported in xen/iommu.h. Signed-off-by: Paul Durrant Reviewed-by: Wei Liu Reviewed-by: Kevin Tian Reviewed-by: Roger Pau Monne Acked-by: Jan Beulic

[Xen-devel] [PATCH v9 4/7] iommu: don't domain_crash() inside iommu_map/unmap_page()

2018-09-13 Thread Paul Durrant
This patch removes the implicit domain_crash() from iommu_map(), unmap_page() and iommu_iotlb_flush() and turns them into straightforward wrappers that check the existence of the relevant iommu_op and call through to it. This makes them usable by PV IOMMU code to be delivered in future patches. Thi

Re: [Xen-devel] null scheduler bug

2018-09-13 Thread Milan Boberic
I'm sorry for html and dropping xen-devel and dropping other CCs, missed to read the rules. I tried 4.10 version and checked for commits you asked in earlier reply. 2b936ea7b "xen: RCU: avoid busy waiting until the end of grace period." 38ad8151f "xen: RCU: don't let a CPU with a callback go idle.

[Xen-devel] [xen-unstable test] 127557: regressions - trouble: broken/fail/pass

2018-09-13 Thread osstest service owner
flight 127557 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/127557/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm broken test-amd64-amd64-xl-qemuu-dmre

Re: [Xen-devel] [DRBD-user] [PATCH] xen-blkback: Switch to closed state after releasing the backing device

2018-09-13 Thread Roger Pau Monné
On Mon, Sep 10, 2018 at 06:18:31PM +0200, Valentin Vidic wrote: > On Mon, Sep 10, 2018 at 05:00:58PM +0200, Roger Pau Monné wrote: > > I can try to take a look at this and attempt to make sure the state is > > only changed to closed in blkback _after_ the device has been > > released, but it might

Re: [Xen-devel] [PATCH v3 10/16] x86/mm: put nested p2m code under CONFIG_HVM

2018-09-13 Thread Wei Liu
On Fri, Sep 07, 2018 at 01:06:38AM -0600, Jan Beulich wrote: > >>> On 04.09.18 at 18:15, wrote: > > @@ -149,6 +149,7 @@ static void p2m_teardown_hostp2m(struct domain *d) > > } > > } > > > > +#ifdef CONFIG_HVM > > static void p2m_teardown_nestedp2m(struct domain *d) > > { > > unsign

[Xen-devel] [PATCH 0/4] Add support for multi-page vm_event ring buffer

2018-09-13 Thread Petre Pircalabu
This series enables the vm_event ring to use buffers larger than 4K. Petre Pircalabu (4): x86_emulator: Add PHONY uninstall target tools/libxc: Define VM_EVENT type x86: Add map_domain_pages_global vm_event: Add support for multi-page ring buffer tools/libxc/include/xenctrl.h |

[Xen-devel] [PATCH 2/4] tools/libxc: Define VM_EVENT type

2018-09-13 Thread Petre Pircalabu
Define the type for each of the supported vm_event rings (paging, monitor and sharing) and replace the ring param field with this type. Signed-off-by: Petre Pircalabu --- tools/libxc/xc_monitor.c| 2 +- tools/libxc/xc_private.h| 6 +-- tools/libxc/xc_vm_event.c | 90 +

[Xen-devel] [PATCH 4/4] vm_event: Add support for multi-page ring buffer

2018-09-13 Thread Petre Pircalabu
In high throughput introspection scenarios where lots of monitor vm_events are generated, the ring buffer can fill up before the monitor application gets a chance to handle all the requests thus blocking other vcpus which will have to wait for a slot to become available. This patch adds support fo

[Xen-devel] [PATCH 1/4] x86_emulator: Add PHONY uninstall target

2018-09-13 Thread Petre Pircalabu
The missing uninstall target breaks the top 'tools' uninstall target. Signed-off-by: Petre Pircalabu --- tools/tests/x86_emulator/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/tests/x86_emulator/Makefile b/tools/tests/x86_emulator/Makefile index e8a3e90..8696a65 100644 -

[Xen-devel] [PATCH 3/4] x86: Add map_domain_pages_global

2018-09-13 Thread Petre Pircalabu
Create a single mapping for multiple domain pages. Signed-off-by: Petre Pircalabu --- tools/libxc/xc_vm_event.c | 2 +- xen/arch/x86/domain_page.c| 22 ++ xen/include/xen/domain_page.h | 9 + 3 files changed, 32 insertions(+), 1 deletion(-) diff --git a/too

Re: [Xen-devel] [PATCH v8 7/7] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 September 2018 15:51 > To: Paul Durrant > Cc: George Dunlap ; Wei Liu > ; Kevin Tian ; xen-devel de...@lists.xenproject.org> > Subject: RE: [PATCH v8 7/7] vtd: add lookup_page method to iommu_ops > > >>> On 13

Re: [Xen-devel] [PATCH v8 7/7] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Jan Beulich
>>> On 13.09.18 at 16:04, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 13 September 2018 14:57 >> To: Paul Durrant >> Cc: George Dunlap ; Wei Liu >> ; Kevin Tian ; xen-devel > de...@lists.xenproject.org> >> Subject: RE: [PATCH v8 7/7] vtd: add loo

[Xen-devel] [ovmf baseline-only test] 75211: trouble: blocked/broken

2018-09-13 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75211 ovmf real [real] http://osstest.xensource.com/osstest/logs/75211/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm

Re: [Xen-devel] [PATCH v2] x86/mm: Suppresses vm_events caused by page-walks

2018-09-13 Thread Jan Beulich
>>> On 12.09.18 at 11:47, wrote: > The original version of the patch emulated the current instruction > (which, as a side-effect, emulated the page-walk as well), however we > need finer-grained control. We want to emulate the page-walk, but still > get an EPT violation event if the current instru

Re: [Xen-devel] [PATCH v8 1/7] iommu: introduce the concept of DFN...

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Paul Durrant > Sent: 13 September 2018 14:47 > To: 'Jan Beulich' ; Julien Grall > Cc: xen-devel ; Kevin Tian > ; Stefano Stabellini ; Wei > Liu ; Suravee Suthikulpanit > > Subject: Re: [X

Re: [Xen-devel] [PATCH v8 7/7] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 September 2018 14:57 > To: Paul Durrant > Cc: George Dunlap ; Wei Liu > ; Kevin Tian ; xen-devel de...@lists.xenproject.org> > Subject: RE: [PATCH v8 7/7] vtd: add lookup_page method to iommu_ops > > >>> On 13

Re: [Xen-devel] [PATCH v8 7/7] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Jan Beulich
>>> On 13.09.18 at 15:50, wrote: > Ok. I'll spell it out in the header if you think it is non-obvious. Obvious or not - do we _have_ any such outer locking in place right now? Jan ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lis

Re: [Xen-devel] [PATCH v8 7/7] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 September 2018 14:45 > To: Paul Durrant > Cc: George Dunlap ; Wei Liu > ; Kevin Tian ; xen-devel de...@lists.xenproject.org> > Subject: RE: [PATCH v8 7/7] vtd: add lookup_page method to iommu_ops > > >>> On 13

Re: [Xen-devel] [PATCH v8 1/7] iommu: introduce the concept of DFN...

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 September 2018 14:41 > To: Paul Durrant > Cc: Suravee Suthikulpanit ; Julien Grall > ; Wei Liu ; Kevin Tian > ; Stefano Stabellini ; xen- > devel > Subject: RE: [PATCH v8 1/7] iommu: introduce the concept of DF

Re: [Xen-devel] [PATCH v8 7/7] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Jan Beulich
>>> On 13.09.18 at 15:34, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 13 September 2018 14:29 >> >> >>> On 13.09.18 at 12:31, wrote: >> > This patch adds a new method to the VT-d IOMMU implementation to find >> the >> > MFN currently mapped by the specified DFN along with a w

Re: [Xen-devel] [PATCH v8 5/7] memory: add check_get_page_from_gfn() as a wrapper...

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 September 2018 14:23 > To: Paul Durrant > Cc: Julien Grall ; Andrew Cooper > ; Wei Liu ; George Dunlap > ; Ian Jackson ; Stefano > Stabellini ; xen-devel de...@lists.xenproject.org>; Konrad Rzeszutek Wilk > ; T

Re: [Xen-devel] [PATCH v8 1/7] iommu: introduce the concept of DFN...

2018-09-13 Thread Jan Beulich
>>> On 13.09.18 at 15:09, wrote: > Do you want me to move the page size definitions and re-submit with > the other things fixed up? Irrespective of your subsequent reply, re-submission perhaps wants to wait until you've clarified with ARM folks which of the #define-s need to move, and which ones

Re: [Xen-devel] [PATCH v8 7/7] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 September 2018 14:29 > To: Paul Durrant > Cc: George Dunlap ; Wei Liu > ; Kevin Tian ; xen-devel de...@lists.xenproject.org> > Subject: Re: [PATCH v8 7/7] vtd: add lookup_page method to iommu_ops > > >>> On 13

Re: [Xen-devel] [PATCH v8 7/7] vtd: add lookup_page method to iommu_ops

2018-09-13 Thread Jan Beulich
>>> On 13.09.18 at 12:31, wrote: > This patch adds a new method to the VT-d IOMMU implementation to find the > MFN currently mapped by the specified DFN along with a wrapper function > in generic IOMMU code to call the implementation if it exists. Would you mind clarifying what the use of this is

Re: [Xen-devel] [PATCH v3] Change timestamps representation for keyhandlers

2018-09-13 Thread Dario Faggioli
On Wed, 2018-09-12 at 20:03 +0300, Andrii Anisov wrote: > From: Andrii Anisov > > For different keyhandlers, replace a hex with delimiter > representation > of time to PRI_stime which is decimal ns currently. > > Signed-off-by: Andrii Anisov > Reviewed-by: Dario Faggioli Regards, Dario -- <>

Re: [Xen-devel] [PATCH v8 5/7] memory: add check_get_page_from_gfn() as a wrapper...

2018-09-13 Thread Jan Beulich
>>> On 13.09.18 at 12:31, wrote: > --- a/xen/arch/x86/hvm/emulate.c > +++ b/xen/arch/x86/hvm/emulate.c > @@ -353,33 +353,20 @@ static int hvmemul_do_io_buffer( > > static int hvmemul_acquire_page(unsigned long gmfn, struct page_info **page) > { > -struct domain *curr_d = current->domain; >

Re: [Xen-devel] [PATCH v8 1/7] iommu: introduce the concept of DFN...

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Paul Durrant > Sent: 13 September 2018 14:09 > To: 'Jan Beulich' > Cc: Kevin Tian ; Stefano Stabellini > ; Wei Liu ; Julien Grall > ; Suravee Suthikulpanit > ; xen-devel de...@lists.xenpr

Re: [Xen-devel] [PATCH v8 1/7] iommu: introduce the concept of DFN...

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 September 2018 13:46 > To: Paul Durrant > Cc: Suravee Suthikulpanit ; Julien Grall > ; Wei Liu ; Kevin Tian > ; Stefano Stabellini ; xen- > devel > Subject: Re: [PATCH v8 1/7] iommu: introduce the concept of DF

Re: [Xen-devel] [PATCH v8 1/7] iommu: introduce the concept of DFN...

2018-09-13 Thread Jan Beulich
>>> On 13.09.18 at 12:31, wrote: > ...meaning 'device DMA frame number' i.e. a frame number mapped in the IOMMU > (rather than the MMU) and hence used for DMA address translation. > > This patch is a largely cosmetic change that substitutes the terms 'gfn' > and 'gaddr' for 'dfn' and 'daddr' in a

[Xen-devel] [seabios test] 127565: tolerable FAIL - PUSHED

2018-09-13 Thread osstest service owner
flight 127565 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/127565/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stop fail like 127226 test-amd64-amd64-xl-qemuu-ws16-amd64 17 g

Re: [Xen-devel] [PATCH v3 3/3] x86: Clean up the Xen MSR infrastructure

2018-09-13 Thread Jan Beulich
>>> On 13.09.18 at 09:57, wrote: > With this being rebased on top of v4 1/3: > > Reviewed-by: Sergey Dyasli Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 2/3] x86/viridan: Clean up Viridian MSR infrastructure

2018-09-13 Thread Jan Beulich
>>> On 11.09.18 at 20:56, wrote: > Rename the functions to guest_{rd,wr}msr_viridian() for consistency, and > because the _regs() suffix isn't very appropriate. > > Update them to take a vcpu pointer rather than presuming that they act on > current, which is safe for all implemented operations, a

Re: [Xen-devel] [PATCH v4 1/3] x86/msr: Dispatch Xen and Viridian MSRs from guest_{wr, rd}msr()

2018-09-13 Thread Jan Beulich
>>> On 12.09.18 at 14:00, wrote: > Despite the complicated diff in {svm,vmx}_msr_write_intercept(), it is just > the 0 case losing one level of indentation, as part of removing the call to > wrmsr_hypervisor_regs(). > > The case blocks in guest_{wr,rd}msr() use raw numbers, partly for consistency

[Xen-devel] [linux-linus test] 127551: regressions - FAIL

2018-09-13 Thread osstest service owner
flight 127551 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/127551/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs. 125898

[Xen-devel] [PATCH] xen: sched/Credit2: fix bug when moving CPUs between two Credit2 cpupools

2018-09-13 Thread Dario Faggioli
Whether or not a CPU is assigned to a runqueue (and, if yes, to which one) within a Credit2 scheduler instance must be both a per-cpu and per-scheduler instance one. In fact, when we move a CPU between cpupools, we first setup its per-cpu data in the new pool, and then cleanup its per-cpu data fro

Re: [Xen-devel] RFE: Detect NUMA misconfigurations and prevent machine freezes

2018-09-13 Thread Dario Faggioli
On Wed, 2018-09-12 at 17:13 +0200, Dario Faggioli wrote: > On Thu, 2018-08-30 at 14:01 +1000, Steven Haigh wrote: > > > > Add the CPUs: > > (XEN) Adding cpu 12 to runqueue 0 > > (XEN) First cpu on runqueue, activating > > (XEN) Removing cpu 12 from runqueue 0 > > (XEN) Adding cpu 13 to runqueue 0

Re: [Xen-devel] [PATCH] xentrace: handle sparse cpu ids correctly in xen trace buffer handling

2018-09-13 Thread George Dunlap
On 08/30/2018 10:28 AM, Juergen Gross wrote: > On 30/08/18 10:26, Jan Beulich wrote: > On 30.08.18 at 09:52, wrote: >>> @@ -202,7 +202,7 @@ static int alloc_trace_bufs(unsigned int pages) >>> * Allocate buffers for all of the cpus. >>> * If any fails, deallocate what you have so fa

Re: [Xen-devel] [PATCH v2] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 September 2018 12:39 > To: Paul Durrant > Cc: Andrew Cooper ; xen-devel de...@lists.xenproject.org> > Subject: RE: [PATCH v2] x86/HVM: correct hvmemul_map_linear_addr() for > multi-page case > > >>> On 13.09.1

Re: [Xen-devel] [PATCH v2] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case

2018-09-13 Thread Jan Beulich
>>> On 13.09.18 at 13:06, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 13 September 2018 11:13 >> >> @@ -544,7 +574,7 @@ static void *hvmemul_map_linear_addr( >> struct hvm_emulate_ctxt *hvmemul_ctxt) >> { >> struct vcpu *curr = current; >> -void *err, *mapping;

Re: [Xen-devel] [PATCH v2] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case

2018-09-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 September 2018 11:13 > To: xen-devel > Cc: Andrew Cooper ; Paul Durrant > > Subject: [PATCH v2] x86/HVM: correct hvmemul_map_linear_addr() for multi- > page case > > The function does two translations in one

[Xen-devel] [libvirt test] 127559: regressions - FAIL

2018-09-13 Thread osstest service owner
flight 127559 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/127559/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 123814 build-amd64-libvirt

Re: [Xen-devel] [PATCH 2/3] xen/vcpu: Introduce vcpu_destroy()

2018-09-13 Thread Roger Pau Monné
On Thu, Sep 06, 2018 at 08:25:33PM +0100, Andrew Cooper wrote: > Like _domain_destroy(), this will eventually idempotently free all parts of a > struct vcpu. > > While breaking apart the failure path of vcpu_create(), rework the codeflow to > be in a line at the end of the function for clarity. >

  1   2   >