Re: [Xen-devel] PLEASE REVERT URGENTLY: Re: [PATCH v5 2/3] x86/boot: add acpi rsdp address to setup_header

On 11/9/18 11:02 PM, Juergen Gross wrote: >> >> Yes. We know that and it is resolved by: >> >> a) the length field in setup_header; >> b) the "sentinel" field which catches legacy non-compliant bootloaders. > > Doesn't help for boot loaders reading struct setup_header from the > kernel image and t

Re: [Xen-devel] PLEASE REVERT URGENTLY: Re: [PATCH v5 2/3] x86/boot: add acpi rsdp address to setup_header

On 10/11/2018 07:32, H. Peter Anvin wrote: >> >> Unfortunately there are many major distros shipping boot loaders which >> write crap data past the end of setup_header. >> > > Yes. We know that and it is resolved by: > > a) the length field in setup_header; > b) the "sentinel" field which catches

[Xen-devel] [ovmf test] 129734: regressions - FAIL

flight 129734 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129734/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-amd64

Re: [Xen-devel] PLEASE REVERT URGENTLY: Re: [PATCH v5 2/3] x86/boot: add acpi rsdp address to setup_header

> > Unfortunately there are many major distros shipping boot loaders which > write crap data past the end of setup_header. > Yes. We know that and it is resolved by: a) the length field in setup_header; b) the "sentinel" field which catches legacy non-compliant bootloaders. >> >> This field th

Re: [Xen-devel] PLEASE REVERT URGENTLY: Re: [PATCH v5 2/3] x86/boot: add acpi rsdp address to setup_header

On 09/11/2018 23:23, H. Peter Anvin wrote: > I just noticed this patch -- I missed it because the cover message > seemed far more harmless so I didn't notice this change. > > THIS PATCH IS FATALLY WRONG AND NEEDS TO BE IMMEDIATELY REVERTED BEFORE > ANYONE STARTS RELYING ON IT; IT HAS THE POTENTIAL

[Xen-devel] [xen-unstable test] 129581: regressions - FAIL

flight 129581 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/129581/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-boot fail REGR. vs. 129426 test-amd64

[Xen-devel] [ovmf test] 129730: regressions - FAIL

flight 129730 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129730/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-amd64

[Xen-devel] [xen-unstable-smoke test] 129727: tolerable all pass - PUSHED

flight 129727 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/129727/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] PLEASE REVERT URGENTLY: Re: [PATCH v5 2/3] x86/boot: add acpi rsdp address to setup_header

One more aspect on this patchset: when CONFIG_ACPI_TABLE_UPGRADE was inroduced, it was seen as a security problem and disabled by default (unlike for device tree, where feeding entries from the boot loader is standard operating procedure.) Thus functionally makes that possible to bypass that prohi

[Xen-devel] [ovmf test] 129725: regressions - FAIL

flight 129725 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129725/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-amd64

[Xen-devel] [xen-4.8-testing test] 129570: regressions - FAIL

flight 129570 xen-4.8-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/129570/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-xtf-amd64-amd64-1 50 xtf/test-hvm64-lbr-tsx-vmentry fail REGR. vs. 128792 test-xtf-amd64-

Re: [Xen-devel] [PATCH] xen/netfront: remove unnecessary wmb

From: Jacob Wen Date: Fri, 9 Nov 2018 14:53:59 +0800 > RING_PUSH_REQUESTS_AND_CHECK_NOTIFY is already able to make sure backend sees > requests before req_prod is updated. > > Signed-off-by: Jacob Wen Applied to net-next. ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH 4/4] xen/arm: gic: Relax barrier when sending an SGI

On Tue, 23 Oct 2018, Julien Grall wrote: > When sending an SGI to another CPU, we require a barrier to ensure that > any pending stores to normal memory are made visible to the recipient > before the interrupt arrives. > > For GICv2, rather than using dsb(sy) before writel_gicd, we can instead >

Re: [Xen-devel] [PATCH 3/4] xen/arm: gic: Remove duplicated comment in do_sgi

On Tue, 23 Oct 2018, Julien Grall wrote: > Signed-off-by: Julien Grall Acked-by: Stefano Stabellini > --- > xen/arch/arm/gic.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c > index 30c0fba0d7..0108e9603c 100644 > --- a/xen/arch/arm/gic.c > +++

Re: [Xen-devel] [PATCH 1/4] xen/arm: gic: Ensure we have an ISB between ack and do_IRQ()

On Tue, 23 Oct 2018, Julien Grall wrote: > Devices that expose their interrupt status registers via system > registers (e.g. Statistical profiling, CPU PMU, DynamIQ PMU, arch timer, > vgic (although unused by Linux), ...) rely on a context synchronising > operation on the CPU to ensure that the upd

Re: [Xen-devel] [PATCH 2/4] xen/arm: gic: Ensure ordering between read of INTACK and shared data

On Tue, 23 Oct 2018, Julien Grall wrote: > When an IPI is generated by a CPU, the pattern looks roughly like: > > > dsb(sy); > > > On the receiving CPU we rely on the fact that, once we've taken the > interrupt, then the freshly written shared data must be visible to us. > Put another way

[Xen-devel] [ovmf test] 129722: regressions - FAIL

flight 129722 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129722/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-amd64

Re: [Xen-devel] [PATCH v6 05/26] xen/arm: check for multiboot nodes only under /chosen

Hi Stefano, On 11/9/18 9:38 PM, Stefano Stabellini wrote: On Fri, 9 Nov 2018, Julien Grall wrote: Hi, On 02/11/2018 23:44, Stefano Stabellini wrote: Make sure to only look for multiboot compatible nodes only under /chosen, not under any other paths (depth <= 3). Signed-off-by: Stefano Stabel

[Xen-devel] PLEASE REVERT URGENTLY: Re: [PATCH v5 2/3] x86/boot: add acpi rsdp address to setup_header

I just noticed this patch -- I missed it because the cover message seemed far more harmless so I didn't notice this change. THIS PATCH IS FATALLY WRONG AND NEEDS TO BE IMMEDIATELY REVERTED BEFORE ANYONE STARTS RELYING ON IT; IT HAS THE POTENTIAL OF BREAKING THE BOOTLOADER PROTOCOL FOR ALL FUTURE.

Re: [Xen-devel] [PATCH v3 4/4] xen: use SYMBOL everywhere

On Fri, 9 Nov 2018, Julien Grall wrote: > Hi Stefano, > > On 06/11/2018 22:05, Stefano Stabellini wrote: > > Use SYMBOL everywhere _stext, _etext, etc. are used. Technically, it > > is required when comparing and subtracting pointers [1], but use it > > everywhere to avoid confusion. > > > > M3CM

[Xen-devel] [ovmf test] 129718: regressions - FAIL

flight 129718 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129718/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-amd64

Re: [Xen-devel] [PATCH v6 05/26] xen/arm: check for multiboot nodes only under /chosen

On Fri, 9 Nov 2018, Julien Grall wrote: > Hi, > > On 02/11/2018 23:44, Stefano Stabellini wrote: > > Make sure to only look for multiboot compatible nodes only under > > /chosen, not under any other paths (depth <= 3). > > > > Signed-off-by: Stefano Stabellini > > > > --- > > > > Changes in v6

Re: [Xen-devel] [PATCH v6 12/26] xen/arm: introduce allocate_memory

On Fri, 9 Nov 2018, Julien Grall wrote: > Hi Stefano, > > Most of the code is mine, so it is hard to review it :). Although, I have a > few comments below. > > > On 02/11/2018 23:45, Stefano Stabellini wrote: > > Introduce an allocate_memory function able to allocate memory for DomUs > > and map

[Xen-devel] [xen-unstable-smoke test] 129713: tolerable all pass - PUSHED

flight 129713 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/129713/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[Xen-devel] [xen-4.11-testing test] 129552: regressions - FAIL

flight 129552 xen-4.11-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/129552/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow211 guest-start fail REGR. vs. 129463 Tests which di

Re: [Xen-devel] [PATCH v6 24/26] xen/vpl011: buffer out chars when the backend is xen

On Fri, 9 Nov 2018, Julien Grall wrote: > Hi Stefano, > > On 02/11/2018 23:45, Stefano Stabellini wrote: > > To avoid mixing the output of different domains on the console, buffer > > the output chars and print line by line. Unless the domain has input > > from the serial, in which case we want to

[Xen-devel] [ovmf test] 129715: regressions - FAIL

flight 129715 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129715/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-amd64

Re: [Xen-devel] [PATCH v4 17/19] xen_pvh: support building a standalone image

On Fri, Nov 02, 2018 at 01:37:36PM +0100, Juergen Gross wrote: > Support mkimage for xen_pvh. > > In order to avoid using plain integers for the ELF notes use the > available Xen include instead. While at it replace the plain numbers > for Xen PV mode, too. > > Signed-off-by: Juergen Gross > Revie

Re: [Xen-devel] [PATCH v4 14/19] xen: init memory regions for PVH

On Fri, Nov 02, 2018 at 01:37:33PM +0100, Juergen Gross wrote: > Add all usable memory regions to grub memory management and add the > needed mmap iterate code, which will be used by grub core (e.g. > grub-core/lib/relocator.c or grub-core/mmap/mmap.c). > > As we are running in 32-bit mode don't ad

Re: [Xen-devel] [OSSTEST PATCH] README.hardware-acquisition [and 1 more messages] [and 2 more messages] [and 2 more messages]

Hi Ian, Given that the Debian bug is filed so either way we have a path forward, should I get started with the discussion about shipping the hardware (get various approvals, prepare boxes for shipping, etc.)? That's going to take a few weeks for sure. Or would you like to wait for the Debian bug t

Re: [Xen-devel] [PATCH v4 13/19] xen: setup Xen specific data for PVH

On Fri, Nov 02, 2018 at 01:37:32PM +0100, Juergen Gross wrote: > Initialize the needed Xen specific data. This is: > > - the Xen start of day page containing the console and Xenstore ring > page PFN and event channel > - the grant table > - the shared info page > > Write back the possibly modifie

[Xen-devel] [ovmf test] 129703: regressions - FAIL

flight 129703 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129703/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-amd64

[Xen-devel] [freebsd-master test] 129693: all pass - PUSHED

flight 129693 freebsd-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/129693/ Perfect :-) All tests in this flight passed as required version targeted for testing: freebsd 93a7ff50c08a505984e4312bf8f139f6c50d725f baseline version: freebsd 18dc8b40483

[Xen-devel] [linux-next test] 129542: regressions - FAIL

flight 129542 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/129542/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 129460 test-arm64-arm64-xl-

Re: [Xen-devel] [PATCH v4 12/19] xen: add PCI MMIO areas to memory map

On Fri, Nov 02, 2018 at 01:37:31PM +0100, Juergen Gross wrote: > Add possible PCI space MMIO areas as "Reserved" to the memory map in > order to avoid using those areas for special Xen pages later. > > Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper but I would like to here something from

Re: [Xen-devel] [PATCH v2] xen-blkfront: fix kernel panic with blkfront_remove()

oops! sorry for not noticing this. -Manjunath On 11/8/2018 10:16 PM, Juergen Gross wrote: On 09/11/2018 02:10, Manjunath Patil wrote: When we try to detach the device, blkfront_remove() tries to access blkfront_info leading to kernel panic. Typical call stack involving panic - #10 page_faul

[Xen-devel] [linux-linus bisection] complete test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm

branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm testid xen-boot Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.or

Re: [Xen-devel] [PATCH 3/5] xen/domain: Audit config->max_vcpus during {, arch_}check_domain_config()

On 08/10/18 14:45, Jan Beulich wrote: > >> --- a/xen/common/domain.c >> +++ b/xen/common/domain.c >> @@ -297,6 +297,9 @@ static int check_domain_config(struct >> xen_domctl_createdomain *config) >> XEN_DOMCTL_CDF_xs_domain) ) >> return -EINVAL; >> >> +if

Re: [Xen-devel] [PATCH 3/5] xen/domain: Audit config->max_vcpus during {, arch_}check_domain_config()

On 09/10/18 12:23, Julien Grall wrote: > On 05/10/2018 15:54, Andrew Cooper wrote: >> --- >>   xen/arch/arm/domain.c | 18 ++ >>   xen/arch/x86/domain.c |  6 ++ >>   xen/common/domain.c   |  3 +++ >>   3 files changed, 27 insertions(+) >> >> diff --git a/xen/arch/arm/domain.c b/x

Re: [Xen-devel] [PATCH v4 11/19] xen: get memory map from hypervisor for PVH

On Fri, Nov 02, 2018 at 01:37:30PM +0100, Juergen Gross wrote: > Retrieve the memory map from the hypervisor and normalize it to contain > no overlapping entries and to be sorted by address. > > Signed-off-by: Juergen Gross One nit pick below. Otherwise Reviewed-by: Daniel Kiper > --- > V3: u

Re: [Xen-devel] [PATCH v2 00/21] xen/arm: Bunch of clean-ups

I committed the whole series On Wed, 31 Oct 2018, Julien Grall wrote: > Hi all, > > This patch series is a bunch of clean-ups I have collected the past few weeks. > > The main goal is to reduce the scope of some includes and reduce the size of > processor.h by moving some parts in new/current he

Re: [Xen-devel] [PATCH v4 10/19] xen: setup hypercall page for PVH

On Fri, Nov 02, 2018 at 01:37:29PM +0100, Juergen Gross wrote: > Add the needed code to setup the hypercall page for calling into the > Xen hypervisor. > > Signed-off-by: Juergen Gross > --- > V3: grub_xen_early_halt->grub_xen_panic (Roger Pau Monné) > issue panic message (Roger Pau Monné) >

Re: [Xen-devel] [PATCH 1/8] xen/page_alloc: Move get_pg_owner()/put_pg_owner() from x86 to common code

Hi Jan, On 07/11/2018 09:28, Jan Beulich wrote: On 06.11.18 at 20:14, wrote: From: Benjamin Sanda get_pg_owner() and put_pg_owner() will be necessary in a follow-up commit to support xentrace on Arm. So move the helper to common code. Note that put_pg_owner() has been turned to a macro rath

Re: [Xen-devel] Xen 4.12 Development Update

On Fri, 2018-11-09 at 03:53 -0700, Jan Beulich wrote: > > > > On 09.11.18 at 11:16, wrote: > > == Hypervisor == > > > > * Per-cpu tasklet > > - XEN-28 > > - Konrad Rzeszutek Wilk > > > > * Improvements to domain creation (v2) > > - Andrew Cooper > > > > * Argo (inter-VM communicati

Re: [Xen-devel] [PATCH v2 2/5] xen/common: Use %*pb[l] instead of {cpu, node}mask_scn{, list}printf()

On 25/10/18 11:56, Jan Beulich wrote: On 22.10.18 at 14:57, wrote: >> This removes all use of keyhandler_scratch as a bounce-buffer for the >> rendered >> string. In some cases, collapse combine adjacent printk()'s which are >> writing >> parts of the same line. >> >> No functional change.

Re: [Xen-devel] [PATCH v4 08/19] xen: add basic hooks for PVH in current code

On Thu, Nov 08, 2018 at 08:23:20PM +0100, Juergen Gross wrote: > On 08/11/2018 16:45, Daniel Kiper wrote: > > On Fri, Nov 02, 2018 at 01:37:27PM +0100, Juergen Gross wrote: > >> Add the hooks to current code needed for Xen PVH. They will be filled > >> with code later when the related functionality

[Xen-devel] [PATCH v2 1/2] guest/pvh: fix handling of multiboot info and module list

When booting Xen as a PVH guest the data in the PVH start info structure is copied over to a multiboot structure and a module list array that resides in the .init section of the Xen image. The resulting multiboot structures are then handled to the generic boot process using their physical address.

Re: [Xen-devel] [PATCH 1/4] xen/arm: gic: Ensure we have an ISB between ack and do_IRQ()

On 09/11/2018 14:42, Andrii Anisov wrote: Hello Julien, Hi Andrii, I just wonder, do you plan to upstream the patch below? I don't plan to upstream the patch below. Andre and I discussed about it extensively and haven't found potential issue with the 2 vGIC implementation we have in Xe

Re: [Xen-devel] [PATCH v5 15/15] libxl: Re-implement domain_suspend_device_model using libxl__ev_qmp

On Fri, Nov 09, 2018 at 05:11:05PM +, Ian Jackson wrote: > Anthony PERARD writes ("Re: [PATCH v5 15/15] libxl: Re-implement > domain_suspend_device_model using libxl__ev_qmp"): > > On Tue, Oct 16, 2018 at 04:28:55PM +0100, Ian Jackson wrote: > > > Does this statefile fd really need to be a car

Re: [Xen-devel] Problems building and running Xen on Hikey960

Hi Omkar, Please configure your e-mail client to quote properly and remove the disclaimer below. On 09/11/2018 16:55, Omkar Bolla wrote: On Fri, Nov 9, 2018 at 4:52 PM Julien Grall > wrote: On 08/11/2018 07:07, Matthew Daley wrote: > Hi all, Hi Ma

[Xen-devel] [PATCH 1/2] guest/pvh: fix handling of multiboot info and module list

When booting Xen as a PVH guest the data in the PVH start info structure is copied over to a multiboot structure and a module list array that resides in the .init section of the Xen image. The resulting multiboot structures are then handled to the generic boot process using their physical address.

[Xen-devel] [PATCH 0/2] guest/pvh: fixes for idle memory scrubbing

Hello, The patch to perform memory scrubbing by the idle CPUs has revealed two latent bugs when running Xen as a PVH guest which this series attempts to fix. This should allow the PV shim to be functional again. The series can be found at: git://xenbits.xen.org/people/royger/xen.git fix_memory_s

[Xen-devel] [PATCH 2/2] guest/pvh: special case the low 1MB

When running as a PVH guest Xen only special cases the trampoline code in the low 1MB, without also reserving the space used by the relocated metadata or the trampoline stack. Fix this by always reserving the low 1MB regardless of whether Xen is running as a guest or natively. Reported-by: Sergey

Re: [Xen-devel] [PATCH 6/6] x86/emul: dedup hvmemul_cpuid() and pv_emul_cpuid()

On 06/11/18 16:16, Jan Beulich wrote: On 06.11.18 at 16:52, wrote: >> On 06/11/18 15:38, Jan Beulich wrote: >> On 05.11.18 at 12:21, wrote: They are identical, so provide a single x86emul_cpuid() instead. As x86_emulate() now only uses the ->cpuid() hook for real CPUID >>

Re: [Xen-devel] [PATCH v5 15/15] libxl: Re-implement domain_suspend_device_model using libxl__ev_qmp

Anthony PERARD writes ("Re: [PATCH v5 15/15] libxl: Re-implement domain_suspend_device_model using libxl__ev_qmp"): > On Tue, Oct 16, 2018 at 04:28:55PM +0100, Ian Jackson wrote: > > Does this statefile fd really need to be a carefd ? Is it a pipe or a > > file ? If it is a file, is it of nontri

Re: [Xen-devel] [PATCH v5 15/15] libxl: Re-implement domain_suspend_device_model using libxl__ev_qmp

On Tue, Oct 16, 2018 at 04:28:55PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("[PATCH v5 15/15] libxl: Re-implement > domain_suspend_device_model using libxl__ev_qmp"): > > +if (rc) > > +goto error; > > + > > +libxl__carefd_begin(); > > +ev->cfd = libxl__carefd_opened(C

Re: [Xen-devel] Problems building and running Xen on Hikey960

HI Mathues, I checked your log and crashes in xen and linux. Do following things to fix or move further. On Fri, Nov 9, 2018 at 4:52 PM Julien Grall wrote: > > > On 08/11/2018 07:07, Matthew Daley wrote: > > Hi all, > > Hi Matthew, > > > > > I'm trying to build and run Linux (Debian) on top of

Re: [Xen-devel] [PATCH v3 0/4] misc safety certification fixes

On Fri, 9 Nov 2018, Julien Grall wrote: > On 06/11/2018 22:05, Stefano Stabellini wrote: > > Hi all, > > Hi, > > > This short patch series fixes a few issues discovered by the safety > > certifications code scanner. The first two patches address simple > > variable initializations concerns. The t

[Xen-devel] [distros-debian-jessie test] 75584: regressions - FAIL

flight 75584 distros-debian-jessie real [real] http://osstest.xensource.com/osstest/logs/75584/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-i386-jessie-netboot-pvgrub 11 guest-start fail REGR. vs. 75562 Tests which did no

Re: [Xen-devel] [PATCH] x86: eliminate pv_post_outb_hook

On 09/11/18 16:29, Wei Liu wrote: > Use amd_acpi_c1e_quirk and amd_check_disable_c1e instead. > > Requested-by: Jan Beulich > Signed-off-by: Wei Liu Acked-by: Andrew Cooper Good riddance to unnecessary function pointers, especially in a retpoline world. ___

[Xen-devel] [xen-unstable-smoke test] 129702: tolerable all pass - PUSHED

flight 129702 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/129702/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[Xen-devel] [PATCH] x86: eliminate pv_post_outb_hook

Use amd_acpi_c1e_quirk and amd_check_disable_c1e instead. Requested-by: Jan Beulich Signed-off-by: Wei Liu --- xen/arch/x86/cpu/amd.c | 6 +- xen/arch/x86/pv/emul-priv-op.c | 11 +-- xen/include/asm-x86/io.h | 2 -- 3 files changed, 6 insertions(+), 13 deletions(-)

Re: [Xen-devel] [PATCH 2/6] libx86: Split x86_cpuid_policy_fill_native() out of calculate_raw_policy()

On 06/11/18 16:31, Roger Pau Monné wrote: > On Mon, Nov 05, 2018 at 11:21:03AM +, Andrew Cooper wrote: >> This will shortly be wanted by the userspace emulator harnesses as well. >> >> Consolidate the cpuid{,_count}_leaf() helpers beside the structure >> definition, >> rather than having them

[Xen-devel] [xen-4.7-testing baseline-only test] 75583: tolerable FAIL

This run is configured for baseline tests only. flight 75583 xen-4.7-testing real [real] http://osstest.xensource.com/osstest/logs/75583/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 6 xen-install fail baseline unt

[Xen-devel] [PATCH 2/6] libx86: Split x86_cpuid_policy_fill_native() out of calculate_raw_policy()

On 06/11/18 13:44, Jan Beulich wrote: On 05.11.18 at 12:21, wrote: >> --- a/xen/include/xen/lib/x86/cpuid.h >> +++ b/xen/include/xen/lib/x86/cpuid.h >> @@ -20,6 +20,21 @@ struct cpuid_leaf >> uint32_t a, b, c, d; >> }; >> >> +static inline void cpuid_leaf(uint32_t leaf, struct cpuid_l

Re: [Xen-devel] [PATCH V4 3/3] x86/altp2m: fix display frozen when switching to a new view early

On 11/9/18 4:19 PM, Razvan Cojocaru wrote: > On 11/8/18 8:14 PM, George Dunlap wrote: >> On 11/01/2018 02:45 PM, Razvan Cojocaru wrote: >> ...here and... >> >>> + >>> int p2m_set_ioreq_server(struct domain *d, >>> unsigned int flags, >>> struct h

Re: [Xen-devel] [PATCH] xen: fix xen_qlock_wait()

On 09/11/2018 16:29, Sander Eikelenboom wrote: > On 09/11/18 16:20, Juergen Gross wrote: >> On 09/11/2018 16:02, Sander Eikelenboom wrote: >>> On 09/11/18 13:04, Juergen Gross wrote: Commit a856531951dc80 ("xen: make xen_qlock_wait() nestable") introduced a regression for Xen guests runni

Re: [Xen-devel] [PATCH] xen: fix xen_qlock_wait()

On 09/11/18 16:20, Juergen Gross wrote: > On 09/11/2018 16:02, Sander Eikelenboom wrote: >> On 09/11/18 13:04, Juergen Gross wrote: >>> Commit a856531951dc80 ("xen: make xen_qlock_wait() nestable") >>> introduced a regression for Xen guests running fully virtualized >>> (HVM or PVH mode). The Xen h

[Xen-devel] [PATCH 3/3 Xen-4.8] x86/dom0: Fix shadowing of PV guests with 2M superpages

This is a minimal backport of pieces of: c/s 28d9a9a2d41759b9e5163037b759ac557aea767c c/s 4c5d78a10dc89427140a50a1df5a0b8e9f073e82 to fix a PV shadowing problem which I hadn't anticipated at the time these fixes were first accepted. Having opt_allow_superpage disabled causes guest_supports_sup

[Xen-devel] [PATCH 0/3] x86: Fixes to shadowing dom0

It turns out there are some real bugs attempting to shadow dom0, and it is because of these that XSA-273 went out with `pv-l1tf=` defaulting to not shadowing dom0. They aren't security issues themselves. Patch 1 is a general problem with dom0 and 1G superpages, and wants to be taken onto all rele

[Xen-devel] [PATCH 1/3] x86/dom0: Avoid using 1G superpages if shadowing may be necessary

The shadow code doesn't support 1G superpages, and will hand #PF[RSVD] back to guests. For dom0's with 512GB of RAM or more (and subject to the P2M alignment), Xen's domain builder might use 1G superpages. Avoid using 1G superpages (falling back to 2M superpages instead) if there is a reasonable

[Xen-devel] [PATCH 2/3 Xen-4.9] x86/dom0: Fix shadowing of PV guests with 2M superpages

This is a straight backport of c/s 28d9a9a2d41759b9e5163037b759ac557aea767c but with a different justification. Dom0 may have superpages (e.g. initial P2M), and may be shadowed (e.g. PV-L1TF). Because of this incorrect check, when PV superpages are disallowed (which is the security supported conf

Re: [Xen-devel] [PATCH] xen: fix xen_qlock_wait()

On 09/11/2018 16:02, Sander Eikelenboom wrote: > On 09/11/18 13:04, Juergen Gross wrote: >> Commit a856531951dc80 ("xen: make xen_qlock_wait() nestable") >> introduced a regression for Xen guests running fully virtualized >> (HVM or PVH mode). The Xen hypervisor wouldn't return from the poll >> hyp

Re: [Xen-devel] [PATCH] xen: fix xen_qlock_wait()

On 09/11/18 13:04, Juergen Gross wrote: > Commit a856531951dc80 ("xen: make xen_qlock_wait() nestable") > introduced a regression for Xen guests running fully virtualized > (HVM or PVH mode). The Xen hypervisor wouldn't return from the poll > hypercall with interrupts disabled in case of an interru

Re: [Xen-devel] [PATCH] x86/hvm: Unify hvm_event_pending()'s API with the !CONFIG_HVM version

On 11/9/18 9:42 AM, Andrew Cooper wrote: > No functional change. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Wei Liu > CC: Jun Nakajima > CC: Kevin Tian > CC: Boris Ostrovsky > CC: Suravee Suthikulpanit > CC: Brian Woods > --- Reviewed-by: Boris Ostrovsky ___

Re: [Xen-devel] [PATCH] xen: fix xen_qlock_wait()

On 11/9/18 7:04 AM, Juergen Gross wrote: > Commit a856531951dc80 ("xen: make xen_qlock_wait() nestable") > introduced a regression for Xen guests running fully virtualized > (HVM or PVH mode). The Xen hypervisor wouldn't return from the poll > hypercall with interrupts disabled in case of an interr

Re: [Xen-devel] Xen 4.12 Development Update

Hi Juergen, On 09/11/2018 10:16, Juergen Gross wrote: This email only tracks big items for xen.git tree. Please reply for items you would like to see in 4.12 so that people have an idea what is going on and prioritise accordingly. You're welcome to provide description and use cases of the featu

Re: [Xen-devel] [PATCH V4 3/3] x86/altp2m: fix display frozen when switching to a new view early

On 11/9/18 4:19 PM, Razvan Cojocaru wrote: > (XEN) Xen call trace: > (XEN)[] vcpu_sleep_sync+0x40/0x71 > (XEN)[] domain.c#do_domain_pause+0x33/0x4f > (XEN)[] domain_pause+0x25/0x27 > (XEN)[] hap_track_dirty_vram+0x2b3/0x491 > (XEN)[] dm.c#dm_op+0x472/0xd46 > (XEN)[] do_dm_op

Re: [Xen-devel] [PATCH] x86/hvm: Unify hvm_event_pending()'s API with the !CONFIG_HVM version

On Fri, Nov 09, 2018 at 02:42:27PM +, Andrew Cooper wrote: > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-d

Re: [Xen-devel] [PATCH] x86/badpage: Fix badpage->order overflow

On Fri, Nov 09, 2018 at 02:42:55PM +, Andrew Cooper wrote: > For order 32 or more, the shift will truncate. Spotted by Coverity. > > Signed-off-by: Andrew Cooper Reviewed-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org http

[Xen-devel] [PATCH] x86/badpage: Fix badpage->order overflow

For order 32 or more, the shift will truncate. Spotted by Coverity. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu --- xen/common/page_alloc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 1aec13e.

Re: [Xen-devel] [PATCH 1/4] xen/arm: gic: Ensure we have an ISB between ack and do_IRQ()

Hello Julien, I just wonder, do you plan to upstream the patch below? Andrii Anisov On 29/10/2018 10:06, Andrii Anisov wrote: > Hello Julien, Hi, > > Sorry for the previous email sent as html. Don't worry. I didn't notice it :). > > > On 27.10.18 15:14, Andrii Anisov wrote: diff --g

[Xen-devel] [PATCH] x86/hvm: Unify hvm_event_pending()'s API with the !CONFIG_HVM version

No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Jun Nakajima CC: Kevin Tian CC: Boris Ostrovsky CC: Suravee Suthikulpanit CC: Brian Woods --- xen/arch/x86/hvm/svm/svm.c| 5 ++--- xen/arch/x86/hvm/vmx/vmx.c| 2 +- xen/include/asm-x86/hvm/hvm.h

Re: [Xen-devel] [PATCH v6 26/26] xen/arm: split domain_build.c

Hi Stefano, On 02/11/2018 23:45, Stefano Stabellini wrote: domain_build.c is too large. Move all the ACPI specific device tree generating functions from domain_build.c to acpi/domain_build.c. Signed-off-by: Stefano Stabellini --- Changes in v6: - fix license Changes in v4: - rename acpi_dt

Re: [Xen-devel] [PATCH v6 24/26] xen/vpl011: buffer out chars when the backend is xen

Hi Stefano, On 02/11/2018 23:45, Stefano Stabellini wrote: To avoid mixing the output of different domains on the console, buffer the output chars and print line by line. Unless the domain has input from the serial, in which case we want to print char by char for a smooth user experience. The s

Re: [Xen-devel] [PATCH v5 09/24] hw: i386: Move PCI host definitions to pci_host.h

On Mon, 5 Nov 2018 02:40:32 +0100 Samuel Ortiz wrote: > The PCI hole properties are not pc or i386 specific. They belong to the > PCI host header instead. > > Signed-off-by: Samuel Ortiz > --- > include/hw/i386/pc.h | 5 - > include/hw/pci/pci_host.h | 6 ++ > 2 files changed, 6

Re: [Xen-devel] [PATCH v5 02/24] hw: acpi: Export ACPI build alignment API

On Mon, 5 Nov 2018 02:40:25 +0100 Samuel Ortiz wrote: > This is going to be needed by the Hardware-reduced ACPI routines. > > Reviewed-by: Philippe Mathieu-Daudé > Tested-by: Philippe Mathieu-Daudé > Signed-off-by: Samuel Ortiz the patch is probably misplaced withing series, if there is an e

Re: [Xen-devel] [PATCH] xen: remove size limit of privcmd-buf mapping interface

On 11/9/18 2:03 AM, Juergen Gross wrote: > Ping? > > Jan's remark regarding de-privileged qemu is no issue as the hypercall > node is being closed by the de-privilege library function. Reviewed-by: Boris Ostrovsky ___ Xen-devel mailing list Xen-devel

Re: [Xen-devel] [PATCH v5 01/24] hw: i386: Decouple the ACPI build from the PC machine type

On Mon, 5 Nov 2018 02:40:24 +0100 Samuel Ortiz wrote: > ACPI tables are platform and machine type and even architecture > agnostic, and as such we want to provide an internal ACPI API that > only depends on platform agnostic information. > > For the x86 architecture, in order to build ACPI tabl

Re: [Xen-devel] [PATCH V4 3/3] x86/altp2m: fix display frozen when switching to a new view early

On 11/8/18 8:14 PM, George Dunlap wrote: > On 11/01/2018 02:45 PM, Razvan Cojocaru wrote: > ...here and... > >> + >> int p2m_set_ioreq_server(struct domain *d, >> unsigned int flags, >> struct hvm_ioreq_server *s) >> @@ -994,12 +1033,12 @@ int p

Re: [Xen-devel] [PATCH v6 12/26] xen/arm: introduce allocate_memory

Hi Stefano, Most of the code is mine, so it is hard to review it :). Although, I have a few comments below. On 02/11/2018 23:45, Stefano Stabellini wrote: Introduce an allocate_memory function able to allocate memory for DomUs and map it at the right guest addresses, according to the guest m

Re: [Xen-devel] [PATCH v6 09/26] xen/arm: add start to struct bootcmdline

Hi Stefano, On 02/11/2018 23:45, Stefano Stabellini wrote: Add a new start address field to struct bootcmdline to easily match a cmdline to the corresponding bootmodule. This is useful for debugging (not actually needed for functionalities today, but could be.) Instead of printing the index in

Re: [Xen-devel] [PATCH v6 08/26] xen/arm: probe domU kernels and initrds

Hi Stefano, On 02/11/2018 23:45, Stefano Stabellini wrote: -info->initrd_bootmodule = boot_module_find_by_kind(BOOTMOD_RAMDISK); +printk("Loading Dom%d kernel from boot module @ %"PRIpaddr"\n", + info->d->domain_id, info->kernel_bootmodule->start); NIT: You probably want to u

Re: [Xen-devel] [PATCH v6 07/26] xen/arm: don't add duplicate boot modules, introduce domU flag

Hi Stefano, On 02/11/2018 23:44, Stefano Stabellini wrote: Don't add duplicate boot modules (same kind and same start address), they are freed later, we don't want to introduce double-free errors. Introduce a domU flag in struct bootmodule and struct bootcmdline. Set it for kernels and ramdisks

Re: [Xen-devel] [PATCH v6 05/26] xen/arm: check for multiboot nodes only under /chosen

Hi, On 02/11/2018 23:44, Stefano Stabellini wrote: Make sure to only look for multiboot compatible nodes only under /chosen, not under any other paths (depth <= 3). Signed-off-by: Stefano Stabellini --- Changes in v6: - do not proceed if fdt_get_path returns error != -FDT_ERR_NOSPACE - remov

[Xen-devel] [ovmf test] 129696: regressions - FAIL

flight 129696 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129696/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-amd64

Re: [Xen-devel] [PATCH v2 03/21] xen/arm: Remove __init from prototype

Reviewed-by: Andrii Anisov ANDRII ANISOV ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v2 01/21] xen/arm: traps: Constify show_*, do_unexpected_trap and do_bug_frame parameters

Hello Julien, Reviewed-by: Andrii Anisov ps. please reach me by my gmail andrii.ani...@gmail.com further, rather than epam's email. Our infra enabled 2-factor auth, and I didn't manage to make thunderbird functional any more. And outlook's web interface is nearly unusable. ANDRII ANISOV

Re: [Xen-devel] [PATCH v5 07/24] hw: acpi: Generalize AML build routines

On Mon, 5 Nov 2018 02:40:30 +0100 Samuel Ortiz wrote: > From: Yang Zhong > > Most of the AML build routines under acpi-build are not even > architecture specific. They can be moved to the more generic hw/acpi > folder where they could be shared across machine types and > architectures. I'd pr

[Xen-devel] [xen-unstable-smoke test] 129698: tolerable all pass - PUSHED

flight 129698 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/129698/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

  1   2   >