[Xen-devel] [ovmf test] 129928: regressions - FAIL

2018-11-12 Thread osstest service owner
flight 129928 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129928/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-amd64

[Xen-devel] [linux-4.14 test] 129762: tolerable FAIL - PUSHED

2018-11-12 Thread osstest service owner
flight 129762 linux-4.14 real [real] http://logs.test-lab.xenproject.org/osstest/logs/129762/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-multivcpu 6 xen-install fail like 129492 test-amd64-amd64-libvirt 13

[Xen-devel] [ovmf test] 129923: regressions - FAIL

2018-11-12 Thread osstest service owner
flight 129923 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129923/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-amd64

[Xen-devel] [linux-linus bisection] complete test-amd64-i386-qemuu-rhel6hvm-amd

2018-11-12 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-qemuu-rhel6hvm-amd testid xen-boot Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu

[Xen-devel] [xen-unstable-smoke test] 129916: regressions - FAIL

2018-11-12 Thread osstest service owner
flight 129916 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/129916/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 129852 Tests which

[Xen-devel] [linux-3.18 bisection] complete test-amd64-i386-examine

2018-11-12 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-examine testid reboot Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git

[Xen-devel] [ovmf test] 129918: regressions - FAIL

2018-11-12 Thread osstest service owner
flight 129918 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129918/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-amd64

[Xen-devel] [ovmf test] 129912: regressions - FAIL

2018-11-12 Thread osstest service owner
flight 129912 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129912/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-amd64

[Xen-devel] [xen-unstable-smoke test] 129909: regressions - FAIL

2018-11-12 Thread osstest service owner
flight 129909 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/129909/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 129852 Tests which

[Xen-devel] [ovmf test] 129905: regressions - FAIL

2018-11-12 Thread osstest service owner
flight 129905 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129905/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-amd64

[Xen-devel] [xen-unstable-smoke test] 129900: regressions - FAIL

2018-11-12 Thread osstest service owner
flight 129900 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/129900/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 129852 Tests which

Re: [Xen-devel] [PATCH 00/18] xen/arm64: Suspend to RAM support for Xen

2018-11-12 Thread Stefano Stabellini
On Mon, 12 Nov 2018, Julien Grall wrote: > Hi Mirela, > > Thank you for posting the series. Could you provide a branch with the patch > applied? > > On 11/12/18 11:30 AM, Mirela Simonovic wrote: > > > > > > The

[Xen-devel] [ovmf test] 129902: regressions - FAIL

2018-11-12 Thread osstest service owner
flight 129902 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129902/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-amd64

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-12 Thread Stefano Stabellini
On Mon, 12 Nov 2018, Andrew Cooper wrote: > On 12/11/18 16:35, Mirela Simonovic wrote: > > Hi Julien, > > > > Thanks for your feedback, I'll need to answer in iterations. > > > > On Mon, Nov 12, 2018 at 4:27 PM Julien Grall wrote: > >> Hi Mirela, > >> > >> On 11/12/18 11:30 AM, Mirela Simonovic

[Xen-devel] [xen-unstable bisection] complete test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict

2018-11-12 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict testid debian-hvm-install Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu

Re: [Xen-devel] [PATCH 15/18] xen/arm: Resume memory management on Xen resume

2018-11-12 Thread Stefano Stabellini
On Mon, 12 Nov 2018, Julien Grall wrote: > Hi, > > On 11/12/18 11:30 AM, Mirela Simonovic wrote: > > The MMU needs to be enabled in the resume flow before the context > > can be restored (we need to be able to access the context data by > > virtual address in order to restore it). The

[Xen-devel] [ovmf test] 129891: regressions - FAIL

2018-11-12 Thread osstest service owner
flight 129891 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129891/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-i386-xsm

[Xen-devel] [linux-4.4 test] 129761: regressions - FAIL

2018-11-12 Thread osstest service owner
flight 129761 linux-4.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/129761/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-arndale 16 guest-start/debian.repeat fail REGR. vs. 129159 Tests which did not

[Xen-devel] [xen-unstable-smoke test] 129870: regressions - FAIL

2018-11-12 Thread osstest service owner
flight 129870 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/129870/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 129852 Tests which

Re: [Xen-devel] [PATCH 05/18] xen/arm: Trigger Xen suspend when Dom0 completes suspend

2018-11-12 Thread Stefano Stabellini
On Mon, 12 Nov 2018, Julien Grall wrote: > Hi, > > On 11/12/18 11:30 AM, Mirela Simonovic wrote: > > When Dom0 finalizes its suspend procedure the suspend of Xen is > > triggered by calling system_suspend(). Dom0 finalizes the suspend from > > its boot core (VCPU#0), which could be mapped to any

[Xen-devel] [xen-unstable-smoke bisection] complete build-amd64

2018-11-12 Thread osstest service owner
branch xen-unstable-smoke xenbranch xen-unstable-smoke job build-amd64 testid xen-build Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in

Re: [Xen-devel] [RFC 09/16] xen/arm: p2m: Introduce a function to resolve translation fault

2018-11-12 Thread Stefano Stabellini
On Mon, 12 Nov 2018, Julien Grall wrote: > Hi Stefano, > > On 11/6/18 2:20 PM, Julien Grall wrote: > > On 05/11/2018 17:56, Stefano Stabellini wrote: > > > On Mon, 5 Nov 2018, Julien Grall wrote: > > > > On 02/11/2018 23:27, Stefano Stabellini wrote: > > > > > On Mon, 8 Oct 2018, Julien Grall

[Xen-devel] [ovmf test] 129856: regressions - FAIL

2018-11-12 Thread osstest service owner
flight 129856 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129856/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-i386-xsm

[Xen-devel] [PATCH v4 0/2] misc safety certification fixes

2018-11-12 Thread Stefano Stabellini
Hi all, The first patch introduces a new macro that is used throughout the code in patch #2 to access _stext, _etext pointers and friends. Cheers, Stefano Stefano Stabellini (2): xen: introduce SYMBOL xen: use SYMBOL when required xen/arch/arm/alternative.c| 7 ---

[Xen-devel] [PATCH v4 2/2] xen: use SYMBOL when required

2018-11-12 Thread Stefano Stabellini
Use SYMBOL in cases of comparisons and subtractions of: _start, _end, __init_begin, __init_end, __2M_text_end, __2M_rodata_start, __2M_rodata_end, __2M_init_start,__2M_init_end, __2M_rwdata_start, __2M_rwdata_end, _stext, _etext, _srodata, _erodata, __end_vpci_array, __start_vpci_array,

[Xen-devel] [PATCH v7 07/25] xen/arm: don't add duplicate boot modules, introduce domU flag

2018-11-12 Thread Stefano Stabellini
Don't add duplicate boot modules (same kind and same start address), they are freed later, we don't want to introduce double-free errors. Introduce a domU flag in struct bootmodule and struct bootcmdline. Set it for kernels and ramdisks of "xen,domain" nodes to avoid getting confused in

[Xen-devel] [PATCH v7 00/25] dom0less step1: boot multiple domains from device tree

2018-11-12 Thread Stefano Stabellini
Hi all, This is first step toward "dom0less" as discussed in the various certifications related threads and discussions. The goal of this series is to enable Xen to boot multiple domains in parallel, in addition to dom0, out of information found on device tree. The device tree based boot

[Xen-devel] [PATCH v7 22/25] xen: support console_switching between Dom0 and DomUs on ARM

2018-11-12 Thread Stefano Stabellini
Today Ctrl-AAA is used to switch between Xen and Dom0. Extend the mechanism to allow for switching between Xen, Dom0, and any of the initial DomU created from Xen alongside Dom0 out of information provided via device tree. Rename xen_rx to console_rx to match the new behavior. Clarify existing

[Xen-devel] [PATCH v7 23/25] xen/arm: Allow vpl011 to be used by DomU

2018-11-12 Thread Stefano Stabellini
Make vpl011 being able to be used without a userspace component in Dom0. In that case, output is printed to the Xen serial and input is received from the Xen serial one character at a time. Call domain_vpl011_init during construct_domU if vpl011 is enabled. Introduce a new ring struct with only

[Xen-devel] [PATCH v7 19/25] xen/arm: generate vpl011 node on device tree for domU

2018-11-12 Thread Stefano Stabellini
Introduce vpl011 support to guests started from Xen: it provides a simple way to print output from a guest, as most guests come with a pl011 driver. It is also able to provide a working console with interrupt support. The UART exposed to the guest is a SBSA compatible UART and not a PL011. SBSA

[Xen-devel] [PATCH v7 15/25] xen/arm: introduce create_domUs

2018-11-12 Thread Stefano Stabellini
Call a new function, "create_domUs", from setup_xen to start DomU VMs. Introduce support for the "xen,domain" compatible node on device tree. Create new DomU VMs based on the information found on device tree under "xen,domain". Call construct_domU for each domain. Introduce a simple global

[Xen-devel] [PATCH v7 01/25] xen: allow console_io hypercalls from certain DomUs

2018-11-12 Thread Stefano Stabellini
Introduce an is_console option to allow certain classes of domUs to use the Xen console. Specifically, it will be used to give console access to all domUs started from Xen from information on device tree. Signed-off-by: Stefano Stabellini Acked-by: Daniel De Graaf CC: andrew.coop...@citrix.com

[Xen-devel] [PATCH v7 18/25] xen/arm: make set_interrupt_ppi able to handle non-PPI

2018-11-12 Thread Stefano Stabellini
also rename it to set_interrupt. Signed-off-by: Stefano Stabellini Reviewed-by: Julien Grall --- xen/arch/arm/domain_build.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index

[Xen-devel] [PATCH v7 20/25] xen/arm: introduce a union in vpl011

2018-11-12 Thread Stefano Stabellini
Introduce a union in struct vpl011 to contain the console ring members. A later patch will add another member of the union for the case where the backend is in Xen. Signed-off-by: Stefano Stabellini Acked-by: Julien Grall --- Changes in v4: - name union "backend" Changes in v3: - rename ring

[Xen-devel] [PATCH v7 03/25] xen/arm: document dom0less

2018-11-12 Thread Stefano Stabellini
Add a new document to provide information on how to use dom0less related features and their current limitations. Signed-off-by: Stefano Stabellini --- Changes in v5: - convert to markdown - move to docs/features - add entry to docs/INDEX Changes in v4: - rename to .txt - improve wording

[Xen-devel] [PATCH v7 09/25] xen/arm: add start to struct bootcmdline

2018-11-12 Thread Stefano Stabellini
Add a new start address field to struct bootcmdline to easily match a cmdline to the corresponding bootmodule. This is useful for debugging (not actually needed for functionalities today, but could be.) Instead of printing the index in the cmdline array, print the start address of the

[Xen-devel] [PATCH v7 25/25] xen/arm: split domain_build.c

2018-11-12 Thread Stefano Stabellini
domain_build.c is too large. Move all the ACPI specific device tree generating functions from domain_build.c to acpi/domain_build.c. Signed-off-by: Stefano Stabellini Acked-by: Julien Grall --- Changes in v7: - build domain_build.init.o - remove "static" from prepare_acpi implementation

[Xen-devel] [PATCH v7 08/25] xen/arm: probe domU kernels and initrds

2018-11-12 Thread Stefano Stabellini
Find addresses, sizes on device tree from kernel_probe. Find the cmdline from the bootcmdlines array. Introduce a new boot_module_find_by_addr_and_kind function to match not just on boot module kind, but also by address so that we can support multiple domains. Introduce a

[Xen-devel] [PATCH v7 05/25] xen/arm: check for multiboot nodes only under /chosen

2018-11-12 Thread Stefano Stabellini
Make sure to only look for multiboot compatible nodes only under /chosen, not under any other paths (depth <= 3). Signed-off-by: Stefano Stabellini --- Changes in v7: - set path size to 92, treat -FDT_ERR_NOSPACE as erro Changes in v6: - do not proceed if fdt_get_path returns error !=

[Xen-devel] [PATCH v7 24/25] xen/arm: move kernel.h to asm-arm/

2018-11-12 Thread Stefano Stabellini
It will be #included by a file in a xen/arch/arm subdirectory. Signed-off-by: Stefano Stabellini Reviewed-by: Julien Grall --- xen/arch/arm/domain_build.c | 2 +- xen/arch/arm/kernel.c| 3 +- xen/arch/arm/kernel.h| 86

[Xen-devel] [PATCH v7 21/25] xen/arm: refactor vpl011_data_avail

2018-11-12 Thread Stefano Stabellini
Move the code to calculate in_fifo_level and out_fifo_level out of vpl011_data_avail, to the caller. This change will make it possible to reuse vpl011_data_avail with different ring structures in a later patch. Signed-off-by: Stefano Stabellini Acked-by: Julien Grall --- Changes in v3: -

[Xen-devel] [PATCH v7 13/25] xen/arm: refactor construct_dom0

2018-11-12 Thread Stefano Stabellini
Move generic initializations out of construct_dom0 so that they can be reused. Rename prepare_dtb to prepare_dtb_hwdom to avoid confusion. No functional changes in this patch. Signed-off-by: Stefano Stabellini Acked-by: Julien Grall --- Changes in v5: - rename __construct_domain to

[Xen-devel] [PATCH v7 16/25] xen/arm: implement construct_domU

2018-11-12 Thread Stefano Stabellini
Similar to construct_dom0, construct_domU creates a barebone DomU guest. The device tree node passed as argument is compatible "xen,domain", see docs/misc/arm/device-tree/booting.txt. Remove #if 0 from allocate_memory as this patch will start using it. Signed-off-by: Stefano Stabellini

[Xen-devel] [PATCH v7 06/25] xen/arm: introduce bootcmdlines

2018-11-12 Thread Stefano Stabellini
Introduce a new array to store the cmdline of each boot module. It is separate from struct bootmodules. Remove the cmdline field from struct boot_module. This way, kernels and initrds with the same address in memory can share struct bootmodule (important because we want them to be free'd only

[Xen-devel] [PATCH v7 10/25] xen/arm: rename get_11_allocation_size to get_allocation_size

2018-11-12 Thread Stefano Stabellini
No functional changes. Signed-off-by: Stefano Stabellini Acked-by: Julien Grall --- Changes in v3: - no change in print messages - do not remove BUG_ON Changes in v2: - new patch --- xen/arch/arm/domain_build.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[Xen-devel] [PATCH v7 02/25] xen/arm: extend device tree based multiboot protocol

2018-11-12 Thread Stefano Stabellini
Extend the existing device tree based multiboot protocol to include information regarding multiple domains to boot. Signed-off-by: Stefano Stabellini --- Changes in v4: - memory is 64bit Changes in v3: - remove "xen,initial-domain" for now - make vpl011 an empty property - memory in KBs

[Xen-devel] [PATCH v7 14/25] xen/arm: move unregister_init_virtual_region to init_done

2018-11-12 Thread Stefano Stabellini
Move unregister_init_virtual_region to init_done. Follow the same path as x86. It is also useful to move it later so that create_domUs can be called before that in following patches. Signed-off-by: Stefano Stabellini Reviewed-by: Julien Grall --- xen/arch/arm/setup.c | 6 +++--- 1 file

[Xen-devel] [PATCH v7 04/25] xen/arm: increase MAX_MODULES

2018-11-12 Thread Stefano Stabellini
Xen boot modules need to account not just for Dom0 but also for a few potential DomUs, each of them coming with their own kernel and initrd. Increase MAX_MODULES to 32 to allow for more DomUs. Signed-off-by: Stefano Stabellini Reviewed-by: Doug Goldstein --- xen/include/asm-arm/setup.h | 2 +-

[Xen-devel] [PATCH v7 17/25] xen/arm: generate a simple device tree for domUs

2018-11-12 Thread Stefano Stabellini
Introduce functions to generate a basic domU device tree, similar to the existing functions in tools/libxl/libxl_arm.c. Signed-off-by: Stefano Stabellini Acked-by: Julien Grall --- Changes in v5: - use d->arch.vgic.version Changes in v4: - code style - two separate functions for gicv2 and

[Xen-devel] [PATCH v7 12/25] xen/arm: introduce allocate_memory

2018-11-12 Thread Stefano Stabellini
Introduce an allocate_memory function able to allocate memory for DomUs and map it at the right guest addresses, according to the guest memory map: GUEST_RAM0_BASE and GUEST_RAM1_BASE. This is under #if 0 as not used for now. Signed-off-by: Julien Grall Signed-off-by: Stefano Stabellini ---

[Xen-devel] [PATCH v7 11/25] xen/arm: rename allocate_memory to allocate_memory_11

2018-11-12 Thread Stefano Stabellini
allocate_memory only deals with directly mapped memory. Rename it to allocate_memory_11. Signed-off-by: Stefano Stabellini Acked-by: Julien Grall --- Changes in v3: - add patch --- xen/arch/arm/domain_build.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [Xen-devel] [PATCH v6 05/26] xen/arm: check for multiboot nodes only under /chosen

2018-11-12 Thread Julien Grall
Hi, On 12/11/2018 21:13, Stefano Stabellini wrote: > On Fri, 9 Nov 2018, Julien Grall wrote: >> Hi Stefano, >> >> On 11/9/18 9:38 PM, Stefano Stabellini wrote: >>> On Fri, 9 Nov 2018, Julien Grall wrote: Hi, On 02/11/2018 23:44, Stefano Stabellini wrote: > Make sure to only

Re: [Xen-devel] [PATCH v6 05/26] xen/arm: check for multiboot nodes only under /chosen

2018-11-12 Thread Stefano Stabellini
On Fri, 9 Nov 2018, Julien Grall wrote: > Hi Stefano, > > On 11/9/18 9:38 PM, Stefano Stabellini wrote: > > On Fri, 9 Nov 2018, Julien Grall wrote: > > > Hi, > > > > > > On 02/11/2018 23:44, Stefano Stabellini wrote: > > > > Make sure to only look for multiboot compatible nodes only under > > >

[Xen-devel] [linux-linus bisection] complete test-amd64-amd64-qemuu-nested-amd

2018-11-12 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-qemuu-nested-amd testid xen-boot Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu

[Xen-devel] [xen-unstable-smoke test] 129861: regressions - FAIL

2018-11-12 Thread osstest service owner
flight 129861 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/129861/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 129852 build-armhf

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-12 Thread Julien Grall
On 11/12/18 4:35 PM, Mirela Simonovic wrote: Hi Julien, Thanks for your feedback, I'll need to answer in iterations. On Mon, Nov 12, 2018 at 4:27 PM Julien Grall wrote: Hi Mirela, On 11/12/18 11:30 AM, Mirela Simonovic wrote: The implementation consists of: -Adding PSCI system suspend

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-12 Thread Julien Grall
Hi Andrew, On 11/12/18 4:41 PM, Andrew Cooper wrote: On 12/11/18 16:35, Mirela Simonovic wrote: diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index e594b48d81..7f8105465c 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -97,6 +97,11 @@ static void

Re: [Xen-devel] [PATCH 03/18] xen/arm: Save GIC and virtual timer context when the domain suspends

2018-11-12 Thread Julien Grall
(+ Andre) On 11/12/18 5:42 PM, Mirela Simonovic wrote: Hi Julien, On Mon, Nov 12, 2018 at 6:00 PM Julien Grall wrote: On 11/12/18 4:52 PM, Mirela Simonovic wrote: Hi Julien, Hi, Thanks for the feedback. On Mon, Nov 12, 2018 at 4:36 PM Julien Grall wrote: Hi Mirela, On 11/12/18

Re: [Xen-devel] [PATCH] x86/badpage: Fix badpage->order overflow

2018-11-12 Thread Andrew Cooper
On 12/11/18 09:54, Jan Beulich wrote: On 09.11.18 at 15:42, wrote: >> For order 32 or more, the shift will truncate. Spotted by Coverity. > I find this pretty absurd. What about order 64 or more? Are you > suggesting you expect 16Tb or larger bad page ranges? > >> Signed-off-by: Andrew

[Xen-devel] [xen-unstable-smoke test] 129852: tolerable all pass - PUSHED

2018-11-12 Thread osstest service owner
flight 129852 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/129852/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] [PATCH v3 4/4] xen: use SYMBOL everywhere

2018-11-12 Thread Stefano Stabellini
On Mon, 12 Nov 2018, Julien Grall wrote: > Hi Stefano, > > On 11/8/18 10:27 PM, Stefano Stabellini wrote: > > On Thu, 8 Nov 2018, Jan Beulich wrote: > > > > > > On 06.11.18 at 23:05, wrote: > > > > Use SYMBOL everywhere _stext, _etext, etc. are used. Technically, it > > > > is required when

Re: [Xen-devel] [PATCH v4 07/44] x86emul: also allow running the 32-bit harness on a 64-bit distro

2018-11-12 Thread Andrew Cooper
On 25/09/18 14:29, Jan Beulich wrote: > In order to be able to verify the 32-bit variant builds and runs, > introduce a respective target (and the necessary other adjustments). > > Signed-off-by: Jan Beulich I tried this, but got: make: Entering directory

Re: [Xen-devel] [PATCH 03/18] xen/arm: Save GIC and virtual timer context when the domain suspends

2018-11-12 Thread Mirela Simonovic
Hi Julien, On Mon, Nov 12, 2018 at 6:00 PM Julien Grall wrote: > > > > On 11/12/18 4:52 PM, Mirela Simonovic wrote: > > Hi Julien, > > Hi, > > > Thanks for the feedback. > > > > On Mon, Nov 12, 2018 at 4:36 PM Julien Grall wrote: > >> > >> Hi Mirela, > >> > >> On 11/12/18 11:30 AM, Mirela

Re: [Xen-devel] [PATCH v6 06/11] libxl_exec: Add libxl__spawn_initiate_failure

2018-11-12 Thread Ian Jackson
Anthony PERARD writes ("[PATCH v6 06/11] libxl_exec: Add libxl__spawn_initiate_failure"): > This function can be used by user of libxl__spawn_* when they setup a > notification other than xenstore. The parent can already report success > via libxl__spawn_initiate_detach(), this new function can

Re: [Xen-devel] [PATCH v6 04/11] libxl: Design of an async API to issue QMP commands to QEMU

2018-11-12 Thread Ian Jackson
Anthony PERARD writes ("[PATCH v6 04/11] libxl: Design of an async API to issue QMP commands to QEMU"): > All the functions will be implemented in later patches. > > This patch includes the API that libxl can use to send QMP commands to > QEMU. ... > Rewrite the comment about the

[Xen-devel] [ovmf test] 129847: regressions - FAIL

2018-11-12 Thread osstest service owner
flight 129847 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129847/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 129475 build-i386-xsm

Re: [Xen-devel] [PATCH v6 03/11] libxl_qmp: Change qmp_qemu_check_version to compare version

2018-11-12 Thread Ian Jackson
Anthony PERARD writes ("[PATCH v6 03/11] libxl_qmp: Change qmp_qemu_check_version to compare version"): > This patch makes the function simpler to read. It also add the ability > for a caller to tell if QEMU is newer or have the exact version. Acked-by: Ian Jackson Thanks, Ian.

Re: [Xen-devel] [PATCH v6 02/11] libxl_qmp: Separate QMP message generation from qmp_send_prepare

2018-11-12 Thread Ian Jackson
Thanks for the repost. I feel I am going to make some comments which could perhaps have been made earlier, so sorry for that: Anthony PERARD writes ("[PATCH v6 02/11] libxl_qmp: Separate QMP message generation from qmp_send_prepare"): > v6: > comment about ownership of buf This is

Re: [Xen-devel] [PATCH 8/8] xen: Swich parameter in get_page_from_gfn to use typesafe gfn

2018-11-12 Thread Julien Grall
Hi, On 11/12/18 4:58 PM, Andrii Anisov wrote: What's wrong with including clean-up patch in a series adding a feature? I do not mean it is wrong. Just assuming that introducing a new feature and cleaning up a code might be different processes with a different review period. We don't have

Re: [Xen-devel] [PATCH 03/18] xen/arm: Save GIC and virtual timer context when the domain suspends

2018-11-12 Thread Julien Grall
On 11/12/18 4:52 PM, Mirela Simonovic wrote: Hi Julien, Hi, Thanks for the feedback. On Mon, Nov 12, 2018 at 4:36 PM Julien Grall wrote: Hi Mirela, On 11/12/18 11:30 AM, Mirela Simonovic wrote: GIC and virtual timer context must be saved when the domain suspends. Please provide the

Re: [Xen-devel] [PATCH v6 01/11] libxl: Enhance libxl__sendmsg_fds to deal with EINTR and EWOULDBLOCK

2018-11-12 Thread Ian Jackson
Anthony PERARD writes ("[PATCH v6 01/11] libxl: Enhance libxl__sendmsg_fds to deal with EINTR and EWOULDBLOCK"): > This patch change the behavior of libxl__sendmsg_fds to retry sendmsg on > EINTR error. > > This patch also allow a caller of libxl__sendmsg_fds to deal with > EWOULDBLOCK. It is

Re: [Xen-devel] [PATCH 8/8] xen: Swich parameter in get_page_from_gfn to use typesafe gfn

2018-11-12 Thread Andrii Anisov
> What's wrong with including clean-up patch in a series adding a feature? I do not mean it is wrong. Just assuming that introducing a new feature and cleaning up a code might be different processes with a different review period. Sincerely, Andrii Anisov.

[Xen-devel] [PATCH v6 10/11] libxl: Change libxl__domain_suspend_device_model() to be async

2018-11-12 Thread Anthony PERARD
This create an extra step for the two call sites of the function. libxl__domain_suspend_device_model() in this patch gets an extra error variable (there is ret and rc), but ret goes away in the next patch. Signed-off-by: Anthony PERARD --- libxl_domain_soft_reset() haven't been tested, as it

[Xen-devel] [PATCH v6 11/11] libxl: Re-implement domain_suspend_device_model using libxl__ev_qmp

2018-11-12 Thread Anthony PERARD
The re-implementation is done because we want to be able to send the file description that QEMU can use to save its state. When QEMU is restricted, it would not be able to write to a path. This replace both libxl__qmp_stop() and libxl__qmp_save(). qmp_qemu_check_version() was only used by

Re: [Xen-devel] [PATCH 03/18] xen/arm: Save GIC and virtual timer context when the domain suspends

2018-11-12 Thread Mirela Simonovic
Hi Julien, Thanks for the feedback. On Mon, Nov 12, 2018 at 4:36 PM Julien Grall wrote: > > Hi Mirela, > > On 11/12/18 11:30 AM, Mirela Simonovic wrote: > > GIC and virtual timer context must be saved when the domain suspends. > > Please provide the rationale for this. Is it required by the

Re: [Xen-devel] [PATCH 8/8] xen: Swich parameter in get_page_from_gfn to use typesafe gfn

2018-11-12 Thread Julien Grall
On 11/12/18 4:49 PM, Andrii Anisov wrote: Hello Julien, Hi, I'm just wondering if this patch really belongs to xentrace series. It rather looks like a separate cleanup patch. What's wrong with including clean-up patch in a series adding a feature? Cheers, -- Julien Grall

[Xen-devel] [PATCH v6 08/11] libxl: QEMU startup sync based on QMP

2018-11-12 Thread Anthony PERARD
This is only activated when dm_restrict=1, as explained in the previous patch "libxl_dm: Pre-open QMP socket for QEMU" Signed-off-by: Anthony PERARD Reviewed-by: Roger Pau Monné --- Notes: v6: invent ERROR_QEMU_API return better rc: ERROR_QEMU_API or ERROR_NOT_READY

[Xen-devel] [PATCH v6 00/11] libxl: Enable save/restore/migration of a restricted QEMU + libxl__ev_qmp_*

2018-11-12 Thread Anthony PERARD
Changes in v6: Implementation of libxl__ev_qmp_* functions have been squashed to a single patch. And with that, a lot of changes in order to make it simpler to read the implementation, have better error reporting and a few bug fix. Checkout more detail changelog in the notes of

[Xen-devel] [PATCH v6 07/11] libxl_dm: Pre-open QMP socket for QEMU

2018-11-12 Thread Anthony PERARD
This patch move the creation of the QMP unix socket from QEMU to libxl. But libxl doesn't rely on this yet. When starting QEMU with dm_restrict=1, pre-open the QMP socket before exec QEMU. That socket will be usefull to findout if QEMU is ready, and pre-opening it means that libxl can connect to

[Xen-devel] [PATCH v6 04/11] libxl: Design of an async API to issue QMP commands to QEMU

2018-11-12 Thread Anthony PERARD
All the functions will be implemented in later patches. This patch includes the API that libxl can use to send QMP commands to QEMU. Signed-off-by: Anthony PERARD --- Notes: v6: use libxl_domid type for domid instead of plain uin32_t avoid the work "chained", rewrite the

[Xen-devel] [PATCH v6 02/11] libxl_qmp: Separate QMP message generation from qmp_send_prepare

2018-11-12 Thread Anthony PERARD
To be able to re-use qmp_prepare_qmp_cmd with libxl__ev_qmp. Also, add the QMP end of command '\r\n' into the generated string. Signed-off-by: Anthony PERARD --- Notes: v6: comment about ownership of buf use lib__sprintf instead of two strncpy v5: rename

[Xen-devel] [PATCH v6 01/11] libxl: Enhance libxl__sendmsg_fds to deal with EINTR and EWOULDBLOCK

2018-11-12 Thread Anthony PERARD
This patch change the behavior of libxl__sendmsg_fds to retry sendmsg on EINTR error. This patch also allow a caller of libxl__sendmsg_fds to deal with EWOULDBLOCK. It is best to only sent one byte when dealing with non-blocking fds so a EWOULDBLOCK error would mean that the fds haven't been sent

Re: [Xen-devel] [PATCH 8/8] xen: Swich parameter in get_page_from_gfn to use typesafe gfn

2018-11-12 Thread Andrii Anisov
Hello Julien, I'm just wondering if this patch really belongs to xentrace series. It rather looks like a separate cleanup patch. Sincerely, Andrii Anisov. вт, 6 лист. 2018 о 21:16 Julien Grall пише: > No functional change intended. > > Only reasonable clean-ups are done in this patch. The

[Xen-devel] [PATCH v6 03/11] libxl_qmp: Change qmp_qemu_check_version to compare version

2018-11-12 Thread Anthony PERARD
This patch makes the function simpler to read. It also add the ability for a caller to tell if QEMU is newer or have the exact version. Signed-off-by: Anthony PERARD --- Notes: v6: new patch tools/libxl/libxl_qmp.c | 28 +--- 1 file changed, 21

[Xen-devel] [PATCH v6 09/11] libxl_qmp: Store advertised QEMU version in libxl__ev_qmp

2018-11-12 Thread Anthony PERARD
This will be used in a later patch. Signed-off-by: Anthony PERARD --- Notes: v6: new local macro GRAB_VERSION better definition of qemu_version field in libxl_internal.h v5: initialise qemu_version struct in libxl__ev_qmp_init tools/libxl/libxl_internal.h

[Xen-devel] [PATCH v6 05/11] libxl_qmp: Implementation of libxl__ev_qmp_*

2018-11-12 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- Notes: v6: This is a squash of 7 commits on the previous version: - libxl_qmp: Connect to QMP socket - libxl_qmp: Implement fd callback and read data - libxl_qmp: Parse JSON input from QMP - libxl_qmp: Prepare the

[Xen-devel] [PATCH v6 06/11] libxl_exec: Add libxl__spawn_initiate_failure

2018-11-12 Thread Anthony PERARD
This function can be used by user of libxl__spawn_* when they setup a notification other than xenstore. The parent can already report success via libxl__spawn_initiate_detach(), this new function can be used for failure instead of waiting for the timeout. Signed-off-by: Anthony PERARD

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-12 Thread Andrew Cooper
On 12/11/18 16:35, Mirela Simonovic wrote: > Hi Julien, > > Thanks for your feedback, I'll need to answer in iterations. > > On Mon, Nov 12, 2018 at 4:27 PM Julien Grall wrote: >> Hi Mirela, >> >> On 11/12/18 11:30 AM, Mirela Simonovic wrote: >>> The implementation consists of: >>> -Adding PSCI

Re: [Xen-devel] [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)

2018-11-12 Thread Mirela Simonovic
Hi Julien, Thanks for your feedback, I'll need to answer in iterations. On Mon, Nov 12, 2018 at 4:27 PM Julien Grall wrote: > > Hi Mirela, > > On 11/12/18 11:30 AM, Mirela Simonovic wrote: > > The implementation consists of: > > -Adding PSCI system suspend call as new PSCI function > >

Re: [Xen-devel] [PATCH 15/18] xen/arm: Resume memory management on Xen resume

2018-11-12 Thread Julien Grall
Hi, On 11/12/18 11:30 AM, Mirela Simonovic wrote: The MMU needs to be enabled in the resume flow before the context can be restored (we need to be able to access the context data by virtual address in order to restore it). The configuration of system registers prior to branching to the routine

[Xen-devel] [PATCH v2 1/5] xen/domain: Introduce a new sanitise_domain_config() helper

2018-11-12 Thread Andrew Cooper
Call it from the head of domain_create() (before doing any memory allocations), which will apply the checks to dom0 as well as domU's. For now, just subsume the XEN_DOMCTL_CDF_* check from XEN_DOMCTL_createdomain. In an effort to aid future developoment, leave a debug printk() identifying the

[Xen-devel] [PATCH v2 5/5] Revert "xen/arm: vgic-v3: Delay the initialization of the domain information"

2018-11-12 Thread Andrew Cooper
This reverts commit 703d9d5ec13a0f487e7415174ba54e0e3ca158db. The domain creation logic has been adjusted to set up d->max_vcpus early enough to be usable in vgic_v3_domain_init(). Signed-off-by: Andrew Cooper Acked-by: Julien Grall --- xen/arch/arm/vgic-v3.c | 29

[Xen-devel] [PATCH v2 4/5] xen/domain: Allocate d->vcpu[] earlier during domain_create()

2018-11-12 Thread Andrew Cooper
The ARM code has a chicken-and-egg problem. One of the vGIC_v3 emulations wants to know d->max_vcpus to be able to size itself appropriately, but the current order of initialisation requires the vGIC to be set up before the requested number of vcpus can be checked. Move the range checking of

[Xen-devel] [PATCH v2 0/5] xen/domain: Allocate d->vcpu[] earlier during domain construction

2018-11-12 Thread Andrew Cooper
To fix an order-of-construction issue with gic-v3 on ARM, arrange for d->max_vcpus to be auditied and set up prior to arch_domain_create() This is slightly-RFC because all of the interesting changes are in ARM, and therefore only compile tested by me at this point. This can be found in git tree

Re: [Xen-devel] [PATCH 2/2] guest/pvh: special case the low 1MB

2018-11-12 Thread Wei Liu
On Fri, Nov 09, 2018 at 06:22:50PM +0100, Roger Pau Monne wrote: > When running as a PVH guest Xen only special cases the trampoline > code in the low 1MB, without also reserving the space used by the > relocated metadata or the trampoline stack. > > Fix this by always reserving the low 1MB

Re: [Xen-devel] [PATCH v5 11/15] libxl_dm: Pre-open QMP socket for QEMU

2018-11-12 Thread Ian Jackson
Anthony PERARD writes ("Re: [PATCH v5 11/15] libxl_dm: Pre-open QMP socket for QEMU"): > On Mon, Nov 12, 2018 at 03:14:30PM +, Ian Jackson wrote: > > Yes, it would have to be initialised along with the other members of > > libxl__domain_build_state. > > I didn't manage to findout where this

Re: [Xen-devel] [PATCH 05/18] xen/arm: Trigger Xen suspend when Dom0 completes suspend

2018-11-12 Thread Julien Grall
Hi, On 11/12/18 11:30 AM, Mirela Simonovic wrote: When Dom0 finalizes its suspend procedure the suspend of Xen is triggered by calling system_suspend(). Dom0 finalizes the suspend from its boot core (VCPU#0), which could be mapped to any physical CPU, i.e. the system_suspend() function could be

[Xen-devel] [xen-unstable-smoke test] 129846: tolerable all pass - PUSHED

2018-11-12 Thread osstest service owner
flight 129846 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/129846/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[Xen-devel] [freebsd-master test] 129834: all pass - PUSHED

2018-11-12 Thread osstest service owner
flight 129834 freebsd-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/129834/ Perfect :-) All tests in this flight passed as required version targeted for testing: freebsd c18ab92e2c2be1b1550a2ac5a33126bc5fc0f0ff baseline version: freebsd

Re: [Xen-devel] [PATCH 03/18] xen/arm: Save GIC and virtual timer context when the domain suspends

2018-11-12 Thread Julien Grall
Hi Mirela, On 11/12/18 11:30 AM, Mirela Simonovic wrote: GIC and virtual timer context must be saved when the domain suspends. Please provide the rationale for this. Is it required by the spec? This is done by moving the respective code in ctxt_switch_from() before the return that happens

  1   2   >