Re: [Xen-devel] [PATCH] xen/netfront: Remove unneeded .resume callback

2019-03-19 Thread Munehisa Kamata
On 3/18/2019 3:02 AM, Oleksandr Andrushchenko wrote: > +Amazon > pls see inline Hi Oleksandr, Let me add some comments as the original author of the series. > > On 3/14/19 9:00 PM, Julien Grall wrote: >> Hi, >> >> On 3/14/19 3:40 PM, Boris Ostrovsky wrote: >>> On 3/14/19 11:10 AM, Oleksandr

[Xen-devel] [ovmf test] 133917: all pass - PUSHED

2019-03-19 Thread osstest service owner
flight 133917 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/133917/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 7681a891cec6655e66d71c6d96a09cbe7b111a5b baseline version: ovmf

Re: [Xen-devel] [PATCH for-next] xen/arm: irq: Don't use _IRQ_PENDING when handling host interrupt

2019-03-19 Thread Julien Grall
Hi, Gentle ping. Cheers, On 1/28/19 3:59 PM, Julien Grall wrote: While SPIs are shared between CPU, it is not possible to receive the same interrupts on a different CPU while the interrupt is in active state. The deactivation of the interrupt is done at the end of the handling. This means

[Xen-devel] [PATCH] xen/arm64: head: Combine lsl and str instructions in a single one

2019-03-19 Thread Julien Grall
From: Julien Grall We can optimize a bit the assembly code by combining the 2 instructions in a single one. This likely not going to make the code faster, but likely make easier to read the assembly. Signed-off-by: Julien Grall --- xen/arch/arm/arm64/head.S | 12 1 file changed,

[Xen-devel] [PATCH] xen/arm: kernel: Remove Dom prefix when using %pd format

2019-03-19 Thread Julien Grall
The format %pd will already prefix the domain ID with 'd'. So avoid to prefix with 'Dom'. Signed-off-by: Julien Grall --- xen/arch/arm/kernel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c index d04a862f99..e3ffdb2fa1 100644

Re: [Xen-devel] [PATCH] xen: passthrough/amd: Remove unused function guest_iommu_set_base

2019-03-19 Thread Julien Grall
Hi, Hmmm, I mistakenly resent this patch. Please ignore this version and review <20190319232055.23993-1-julien.gr...@arm.com> Sorry for the noise. Cheers, On 3/19/19 11:21 PM, Julien Grall wrote: The function is unused and could potentially lead a to trigger the BUG_ON() in

[Xen-devel] [PATCH] xen: passthrough/amd: Remove unused function guest_iommu_set_base

2019-03-19 Thread Julien Grall
The function is unused and could potentially lead a to trigger the BUG_ON() in p2m_change_type_one if misused as the p2m type is not sanitized. So remove it. Signed-off-by: Julien Grall --- xen/drivers/passthrough/amd/iommu_guest.c | 23 ---

[Xen-devel] [PATCH] x86/mm: Fix typo in comment on top of page_lock

2019-03-19 Thread Julien Grall
Signed-off-by: Julien Grall --- xen/arch/x86/mm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index dbec130da0..94b82e8e5e 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -2003,7 +2003,7 @@ static int free_l4_table(struct

[Xen-devel] [PATCH] xen: passthrough/amd: Remove unused function guest_iommu_set_base

2019-03-19 Thread Julien Grall
The function is unused and could potentially lead a to trigger the BUG_ON() in p2m_change_type_one if misused as the p2m type is not sanitized. So remove it. Signed-off-by: Julien Grall --- xen/drivers/passthrough/amd/iommu_guest.c | 23 ---

[Xen-devel] [PATCH] xen/memory: Fix typo in the comment on top of check_get_page_from_gfn

2019-03-19 Thread Julien Grall
Signed-off-by: Julien Grall --- xen/common/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/memory.c b/xen/common/memory.c index 5387769987..86567e6117 100644 --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -1648,7 +1648,7 @@ void

[Xen-devel] [PATCH] xen/drivers: char: Match #if DEBUG_TRACE_DUMP and #endif comment

2019-03-19 Thread Julien Grall
Signed-off-by: Julien Grall --- xen/drivers/char/console.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c index f41b689847..61695d967e 100644 --- a/xen/drivers/char/console.c +++ b/xen/drivers/char/console.c @@ -1320,7

[Xen-devel] [xen-4.11-testing test] 133908: regressions - FAIL

2019-03-19 Thread osstest service owner
flight 133908 xen-4.11-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/133908/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 6 xen-install fail REGR. vs. 133658

Re: [Xen-devel] [PATCH] xen/pv: Add PV specific legacy_pic struct to expose legacy IRQs.

2019-03-19 Thread Boris Ostrovsky
On 3/19/19 4:02 PM, Jennifer Herbert wrote: > The ACPI tables doesn't always contain all IRQs for legacy devices > such as RTC. Since no PIC controller is visible for a PV linux guest, > under Xen, legacy_pic currently defaults to the null_legacy_pic - with > reports no legacy IRQs. Since the

[Xen-devel] [linux-linus test] 133902: regressions - FAIL

2019-03-19 Thread osstest service owner
flight 133902 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/133902/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-amd 12 guest-start/redhat.repeat fail REGR. vs. 133580

Re: [Xen-devel] [PATCH v6 00/12] improve late microcode loading

2019-03-19 Thread Woods, Brian
On 3/19/19 3:22 PM, Brian Woods wrote: > On 3/11/19 2:57 AM, Chao Gao wrote: >> Major changes in version 6: >>   - run wbinvd before updating microcode (patch 10) >>   - add an userspace tool for late microcode update (patch 1) >>   - scale time to wait by the number of remaining CPUs to respond

Re: [Xen-devel] [PATCH v6 00/12] improve late microcode loading

2019-03-19 Thread Woods, Brian
On 3/11/19 2:57 AM, Chao Gao wrote: > Major changes in version 6: > - run wbinvd before updating microcode (patch 10) > - add an userspace tool for late microcode update (patch 1) > - scale time to wait by the number of remaining CPUs to respond > - remove 'cpu' parameters from some

[Xen-devel] [PATCH] xen/pv: Add PV specific legacy_pic struct to expose legacy IRQs.

2019-03-19 Thread Jennifer Herbert
The ACPI tables doesn't always contain all IRQs for legacy devices such as RTC. Since no PIC controller is visible for a PV linux guest, under Xen, legacy_pic currently defaults to the null_legacy_pic - with reports no legacy IRQs. Since the commit "rtc: cmos: Do not assume irq 8 for rtc when

Re: [Xen-devel] Maintainers, please tell us how to boot your machines!

2019-03-19 Thread Peter Maydell
On Tue, 19 Mar 2019 at 18:34, Markus Armbruster wrote: Here are some command lines from my image zoo. Unfortunately typically the images themselves are random accumulations from people and I have no idea how to rebuild them (and they are thus not redistributable, generally). > =

[Xen-devel] [libvirt test] 133904: regressions - FAIL

2019-03-19 Thread osstest service owner
flight 133904 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/133904/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 133846 build-arm64-libvirt

Re: [Xen-devel] Maintainers, please tell us how to boot your machines!

2019-03-19 Thread Markus Armbruster
Markus Armbruster writes: > Dear board code maintainers, > > This is a (rather late) follow-up to the last QEMU summit. Minutes[*]: > > * Deprecating unmaintained features (devices, targets, backends) in QEMU > >QEMU has a mechanism to deprecate features but there remains a lot of >old

[Xen-devel] [xen-unstable-smoke test] 133927: tolerable all pass - PUSHED

2019-03-19 Thread osstest service owner
flight 133927 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/133927/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [Xen-devel] [PATCH 3/3] mwait-idle: add enablement for AMD Naples and Rome

2019-03-19 Thread Jan Beulich
>>> On 19.03.19 at 16:59, wrote: > On 3/15/19 3:54 AM, Jan Beulich wrote: > On 14.03.19 at 20:29, wrote: >>> There's another register we _might_ >>> be able to use, but support for CC6 is AND'd with that and another >>> another register (we don't have access to). The register we'd read is

Re: [Xen-devel] [PATCH v2] x86: don't allow clearing of TF_kernel_mode for other than 64-bit PV

2019-03-19 Thread George Dunlap
On 3/11/19 4:37 PM, Jan Beulich wrote: > The flag is really only meant for those, both HVM and 32-bit PV tell > kernel from user mode based on CPL/RPL. Remove the all-question-marks > comment and let's be on the safe side here and also suppress clearing > for 32-bit PV (this isn't a fast path

Re: [Xen-devel] [PATCH] x86/paging: paging_set_allocation() is init-only

2019-03-19 Thread George Dunlap
On 3/11/19 4:38 PM, Jan Beulich wrote: > This is needed for Dom0 creation only, therefore it gets additionally > framed by an #ifdef. > > Signed-off-by: Jan Beulich Reviewed-by: George Dunlap ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

Re: [Xen-devel] [PATCH 1/3] mwait-idle: add support for using halt

2019-03-19 Thread Jan Beulich
>>> On 19.03.19 at 17:12, wrote: > On 3/15/19 3:37 AM, Jan Beulich wrote: > On 14.03.19 at 20:00, wrote: >>> On 3/13/19 4:35 AM, Jan Beulich wrote: >>> On 25.02.19 at 21:23, wrote: > --- a/xen/arch/x86/cpu/mwait-idle.c > +++ b/xen/arch/x86/cpu/mwait-idle.c > @@ -103,6

Re: [Xen-devel] [PATCH] xen/arm: p2m: configure pa_range_info table to support 42 bit PA systems.

2019-03-19 Thread Feng Kan OS
On 3/18/19 4:05 AM, Julien Grall wrote: > Hello, > > On 15/03/2019 23:57, Feng Kan OS wrote: >> On 3/15/19 4:21 AM, Julien Grall wrote: >>> On 15/03/2019 08:34, Vishnu Pajjuri OS wrote: Current pa_range_info table's configuration prevents 42 bit PA systems from booting DOM0. This

Re: [Xen-devel] [PATCH RFC 42/55] x86_64/mm: map and unmap page tables in share_hotadd_m2p_table

2019-03-19 Thread Nuernberger, Stefan
On Thu, 2019-02-07 at 16:44 +, Wei Liu wrote: > Signed-off-by: Wei Liu > --- >  xen/arch/x86/x86_64/mm.c | 31 +++ >  1 file changed, 23 insertions(+), 8 deletions(-) > > diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c > index

Re: [Xen-devel] [PATCH RFC 41/55] x86_64/mm: map and unmap page tables in m2p_mapped

2019-03-19 Thread Nuernberger, Stefan
On Thu, 2019-02-07 at 16:44 +, Wei Liu wrote: > Signed-off-by: Wei Liu > --- >  xen/arch/x86/x86_64/mm.c | 22 +++--- >  1 file changed, 15 insertions(+), 7 deletions(-) > > diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c > index 216f97c95f..2b88a1af37 100644

Re: [Xen-devel] [PATCH RFC 39/55] x86: switch root_pgt to mfn_t and use new APIs

2019-03-19 Thread Nuernberger, Stefan
On Thu, 2019-02-07 at 16:44 +, Wei Liu wrote: > This then requires moving declaration of root page table mfn into > mm.h > and modify setup_cpu_root_pgt to have a single exit path. > > We also need to force map_domain_page to use direct map when > switching > per-domain mappings. This is

Re: [Xen-devel] [PATCH v10 10/11] viridian: add implementation of synthetic timers

2019-03-19 Thread Jan Beulich
>>> On 19.03.19 at 16:22, wrote: > This patch introduces an implementation of the STIMER0-15_CONFIG/COUNT MSRs > and hence a the first SynIC message source. > > The new (and documented) 'stimer' viridian enlightenment group may be > specified to enable this feature. > > While in the

Re: [Xen-devel] [PATCH 3/3] docs/admin-guide: Boot time microcode loading

2019-03-19 Thread Jan Beulich
>>> On 19.03.19 at 17:20, wrote: > Recent discussion on xen-devel has demonstrated that Xen existing microcode > loading support isn't adequately documented. Take the opportunity to address > this, and start some end-user focused documentation. > > Signed-off-by: Andrew Cooper Acked-by: Jan

Re: [Xen-devel] [PULL 0/1] xen queue 2019-03-19

2019-03-19 Thread Peter Maydell
are available in the Git repository at: > > https://xenbits.xen.org/git-http/people/aperard/qemu-dm.git > tags/pull-xen-20190319 > > for you to fetch changes up to 4158e93f4aced247c8db94a0275fc027da7dc97e: > > xen-mapcache: use MAP_FIXED flag so the mmap address hint is

[Xen-devel] [PATCH 3/3] docs/admin-guide: Boot time microcode loading

2019-03-19 Thread Andrew Cooper
Recent discussion on xen-devel has demonstrated that Xen existing microcode loading support isn't adequately documented. Take the opportunity to address this, and start some end-user focused documentation. Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Ian Jackson CC: Jan Beulich CC:

[Xen-devel] [PATCH 0/3] docs: User oriented documentation

2019-03-19 Thread Andrew Cooper
This is a project I've been musing over for a long time now, to try and address Xen's almost complete absense of documentation. This series, plus some other in-progress conversion of the command line doc, is available to view at: https://andrewcoop-xen.readthedocs.io/en/latest/ This is

[Xen-devel] [PATCH 1/3] docs/sphinx: Skeleton setup

2019-03-19 Thread Andrew Cooper
Sphinx is a documentation system, which is popular for technical writing. It uses ReStructuredText as its markup syntax, and is designed for whole-project documentation, rather than the misc assortment of individual files that we currently have. This is a skeleton setup which just enough

[Xen-devel] [PATCH 2/3] docs/rst: Use pandoc to render ReStructuredText

2019-03-19 Thread Andrew Cooper
Sphinx uses ReStructuredText as its markup format. Although missing the project wide integration, individual *.rst files can be rendered by pandoc to suppliement our existing ad-hoc documentation. Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Ian Jackson CC: Jan Beulich CC: Konrad

Re: [Xen-devel] [PATCH 1/3] mwait-idle: add support for using halt

2019-03-19 Thread Woods, Brian
On 3/15/19 3:37 AM, Jan Beulich wrote: On 14.03.19 at 20:00, wrote: >> On 3/13/19 4:35 AM, Jan Beulich wrote: >> On 25.02.19 at 21:23, wrote: --- a/xen/arch/x86/cpu/mwait-idle.c +++ b/xen/arch/x86/cpu/mwait-idle.c @@ -103,6 +103,11 @@ static const struct cpuidle_state {

[Xen-devel] [PATCH] libxc: fix HVM core dump

2019-03-19 Thread Wei Liu
f969bc9fc96 forbid get_address_size call on HVM guests, because that didn't make sense. It broke core dump functionality on HVM because libxc unconditionally asked for guest width. Only issue the call when necessary in libxc. Reported-by: Igor Druzhinin Signed-off-by: Wei Liu --- Cc: Ian

Re: [Xen-devel] [PATCH 3/3] mwait-idle: add enablement for AMD Naples and Rome

2019-03-19 Thread Woods, Brian
On 3/15/19 3:54 AM, Jan Beulich wrote: On 14.03.19 at 20:29, wrote: >> On 3/13/19 4:51 AM, Jan Beulich wrote: >> On 25.02.19 at 21:24, wrote: Add the needed data structures for enabling Naples (F17h M01h). Since Rome (F17h M31h) has the same c-state latencies and entry

[Xen-devel] [PULL 1/1] xen-mapcache: use MAP_FIXED flag so the mmap address hint is always honored

2019-03-19 Thread Anthony PERARD
From: Roger Pau Monne Or if it's not possible to honor the hinted address an error is returned instead. This makes it easier to spot the actual failure, instead of failing later on when the caller of xen_remap_bucket realizes the mapping has not been created at the requested address. Also note

[Xen-devel] [PULL 0/1] xen queue 2019-03-19

2019-03-19 Thread Anthony PERARD
-dm.git tags/pull-xen-20190319 for you to fetch changes up to 4158e93f4aced247c8db94a0275fc027da7dc97e: xen-mapcache: use MAP_FIXED flag so the mmap address hint is always honored (2019-03-19 15:32:13 +) Xen queue Fix a bug

[Xen-devel] [PATCH v10 11/11] viridian: add implementation of the HvSendSyntheticClusterIpi hypercall

2019-03-19 Thread Paul Durrant
This patch adds an implementation of the hypercall as documented in the specification [1], section 10.5.2. This enlightenment, as with others, is advertised by CPUID leaf 0x4004 and is under control of a new 'hcall_ipi' option in libxl. If used, this enlightenment should mean the guest only

[Xen-devel] [PATCH v10 10/11] viridian: add implementation of synthetic timers

2019-03-19 Thread Paul Durrant
This patch introduces an implementation of the STIMER0-15_CONFIG/COUNT MSRs and hence a the first SynIC message source. The new (and documented) 'stimer' viridian enlightenment group may be specified to enable this feature. While in the neighbourhood, this patch adds a missing check for an

[Xen-devel] [PATCH v10 08/11] viridian: stop directly calling viridian_time_ref_count_freeze/thaw()...

2019-03-19 Thread Paul Durrant
...from arch_domain_shutdown/pause/unpause(). A subsequent patch will introduce an implementaion of synthetic timers which will also need freeze/thaw hooks, so make the exported hooks more generic and call through to (re-named and static) time_ref_count_freeze/thaw functions. NOTE: This patch

[Xen-devel] [PATCH v10 09/11] viridian: add implementation of synthetic interrupt MSRs

2019-03-19 Thread Paul Durrant
This patch introduces an implementation of the SCONTROL, SVERSION, SIEFP, SIMP, EOM and SINT0-15 SynIC MSRs. No message source is added and, as such, nothing will yet generate a synthetic interrupt. A subsequent patch will add an implementation of synthetic timers which will need the

[Xen-devel] [PATCH v10 06/11] viridian: add missing context save helpers into synic and time modules

2019-03-19 Thread Paul Durrant
Currently the time module lacks vcpu context save helpers and the synic module lacks domain context save helpers. These helpers are not yet required but subsequent patches will require at least some of them so this patch completes the set to avoid introducing them in an ad-hoc way. Signed-off-by:

[Xen-devel] [PATCH v10 03/11] viridian: use stack variables for viridian_vcpu and viridian_domain...

2019-03-19 Thread Paul Durrant
...where there is more than one dereference inside a function. This shortens the code and makes it more readable. No functional change. Signed-off-by: Paul Durrant Reviewed-by: Jan Beulich --- Cc: Andrew Cooper Cc: Wei Liu Cc: "Roger Pau Monné" v4: - New in v4 ---

[Xen-devel] [PATCH v10 02/11] viridian: separately allocate domain and vcpu structures

2019-03-19 Thread Paul Durrant
Currently the viridian_domain and viridian_vcpu structures are inline in the hvm_domain and hvm_vcpu structures respectively. Subsequent patches will need to add sizable extra fields to the viridian structures which will cause the PAGE_SIZE limit of the overall vcpu structure to be exceeded. This

[Xen-devel] [PATCH v10 05/11] viridian: extend init/deinit hooks into synic and time modules

2019-03-19 Thread Paul Durrant
This patch simply adds domain and vcpu init/deinit hooks into the synic and time modules and wires them into viridian_[domain|vcpu]_[init|deinit](). Only one of the hooks is currently needed (to unmap the 'VP Assist' page) but subsequent patches will make use of the others. NOTE: To perform the

[Xen-devel] [PATCH v10 07/11] viridian: use viridian_map/unmap_guest_page() for reference tsc page

2019-03-19 Thread Paul Durrant
Whilst the reference tsc page does not currently need to be kept mapped after it is initially set up (or updated after migrate), the code can be simplified by using the common guest page map/unmap and dump functions. New functionality added by a subsequent patch will also require the page to kept

[Xen-devel] [PATCH v10 00/11] viridian: implement more enlightenments

2019-03-19 Thread Paul Durrant
This series adds three new enlightenments: - Synthetic timers, which depends on the... - Synthetic interrupt controller (or SynIC) - Synthetic cluster IPI All these enlightenments are implemented in current versions of QEMU/KVM so this series closes the gap. Paul Durrant (11): viridian: add

Re: [Xen-devel] [PATCH v3] xen-mapcache: use MAP_FIXED flag so the mmap address hint is always honored

2019-03-19 Thread Anthony PERARD
On Mon, Mar 18, 2019 at 06:37:31PM +0100, Roger Pau Monne wrote: > Or if it's not possible to honor the hinted address an error is returned > instead. This makes it easier to spot the actual failure, instead of > failing later on when the caller of xen_remap_bucket realizes the > mapping has not

Re: [Xen-devel] Arm boot regression with Xen 4.12

2019-03-19 Thread Julien Grall
On 19/03/2019 14:01, Amit Tomer wrote: I tried the above patch but still see the same crash: [..] On the other hand, it didn't come on 4.11. That's good to know. Can you bisect Xen and see if you can pin point a specific commit? Cheers, -- Julien Grall

[Xen-devel] [linux-4.19 test] 133899: regressions - FAIL

2019-03-19 Thread osstest service owner
flight 133899 linux-4.19 real [real] http://logs.test-lab.xenproject.org/osstest/logs/133899/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-amd 12 guest-start/redhat.repeat fail in 133868 REGR. vs. 129313

Re: [Xen-devel] [PATCH] x86: drop "depends on X86" for TBOOT Kconfig option

2019-03-19 Thread Jan Beulich
>>> On 19.03.19 at 14:59, wrote: > Given that this file already resides under arch/x86, there is no need > to have the dependency. > > Signed-off-by: Wei Liu Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

Re: [Xen-devel] [PATCH v13] tolerate jitter in cpu_khz calculation to avoid TSC emulation

2019-03-19 Thread Olaf Hering
Am Thu, 14 Mar 2019 15:41:55 +0100 schrieb Olaf Hering : > So before I spam you guys with any more variants, I better ask if any further > attempt would fly anyway. So, should I spend any more time to fix this bug? Olaf pgpxD61zDeHs3.pgp Description: Digitale Signatur von OpenPGP

Re: [Xen-devel] [PATCH v3] xen-mapcache: use MAP_FIXED flag so the mmap address hint is always honored

2019-03-19 Thread Anthony PERARD
On Mon, Mar 18, 2019 at 10:43:12PM +0100, Marek Marczykowski-Górecki wrote: > On Mon, Mar 18, 2019 at 06:37:31PM +0100, Roger Pau Monne wrote: > > Or if it's not possible to honor the hinted address an error is returned > > instead. > > Just to be sure: MAP_FIXED will cause to map at specified

Re: [Xen-devel] [PATCH RESEND 1/3] OvmfPkg/XenSupport: remove usage of prefetchable PCI host bridge aperture

2019-03-19 Thread Anthony PERARD
On Thu, Mar 14, 2019 at 07:45:56PM +, Igor Druzhinin wrote: > On 14/03/2019 17:41, Anthony PERARD wrote: > > Hi, > > > > On Wed, Mar 06, 2019 at 12:40:54PM +, Igor Druzhinin wrote: > >> This aperture doesn't exist in OVMF and trying to use it causes > > > > I'm trying to understand what

Re: [Xen-devel] Arm boot regression with Xen 4.12

2019-03-19 Thread Amit Tomer
Hi, > Could you give a try to the below patch? > > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > index 01ae20..2c34138bbd 100644 > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -1139,7 +1139,7 @@ void free_init_memory(void) > *(p + i) = insn; > >

Re: [Xen-devel] [PATCH v3] x86: decouple xen alignment setting from EFI/ELF build

2019-03-19 Thread Jan Beulich
>>> On 19.03.19 at 14:57, wrote: > Introduce a new Kconfig option to pick the alignment for xen binary. > To retain original behaviour, the default pick for EFI build is 2M and > ELF build 4K. > > Make the PVHSHIM build use 2M alignment for potentially better > performance. > > Signed-off-by:

[Xen-devel] [PATCH] x86: drop "depends on X86" for TBOOT Kconfig option

2019-03-19 Thread Wei Liu
Given that this file already resides under arch/x86, there is no need to have the dependency. Signed-off-by: Wei Liu --- xen/arch/x86/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index 5c2d1070b6..76393fd23a 100644 ---

Re: [Xen-devel] [PATCH v2 03/14] x86/cpu/vpmu: Add Hygon Dhyana and AMD Zen support for vPMU

2019-03-19 Thread Jan Beulich
>>> On 19.03.19 at 14:47, wrote: > On 2019/3/19 20:58, Jan Beulich wrote: >> On 19.03.19 at 12:32, wrote: >>> On 2019/3/18 16:59, Jan Beulich wrote: On 16.03.19 at 11:11, wrote: > On 2019/3/15 20:41, Jan Beulich wrote: >> On 21.02.19 at 10:50, wrote: >>> ---

Re: [Xen-devel] [PATCH v2 2/2] x86/pvshim: use 2M alignment

2019-03-19 Thread Jan Beulich
>>> On 19.03.19 at 14:50, wrote: > On Tue, Mar 19, 2019 at 07:42:56AM -0600, Jan Beulich wrote: >> >>> On 19.03.19 at 14:05, wrote: >> > --- a/xen/arch/x86/configs/pvshim_defconfig >> > +++ b/xen/arch/x86/configs/pvshim_defconfig >> > @@ -5,6 +5,7 @@ CONFIG_PVH_GUEST=y >> > CONFIG_PV_SHIM=y >>

[Xen-devel] [PATCH v3] x86: decouple xen alignment setting from EFI/ELF build

2019-03-19 Thread Wei Liu
Introduce a new Kconfig option to pick the alignment for xen binary. To retain original behaviour, the default pick for EFI build is 2M and ELF build 4K. Make the PVHSHIM build use 2M alignment for potentially better performance. Signed-off-by: Wei Liu --- xen/arch/x86/Kconfig | 23

Re: [Xen-devel] [PATCH v2 03/14] x86/cpu/vpmu: Add Hygon Dhyana and AMD Zen support for vPMU

2019-03-19 Thread Pu Wen
On 2019/3/19 20:58, Jan Beulich wrote: > On 19.03.19 at 12:32, wrote: >> On 2019/3/18 16:59, Jan Beulich wrote: >>> On 16.03.19 at 11:11, wrote: On 2019/3/15 20:41, Jan Beulich wrote: > On 21.02.19 at 10:50, wrote: >> --- a/xen/arch/x86/cpu/vpmu_amd.c >> +++

Re: [Xen-devel] [PATCH v2 2/2] x86/pvshim: use 2M alignment

2019-03-19 Thread Wei Liu
On Tue, Mar 19, 2019 at 07:42:56AM -0600, Jan Beulich wrote: > >>> On 19.03.19 at 14:05, wrote: > > --- a/xen/arch/x86/configs/pvshim_defconfig > > +++ b/xen/arch/x86/configs/pvshim_defconfig > > @@ -5,6 +5,7 @@ CONFIG_PVH_GUEST=y > > CONFIG_PV_SHIM=y > > CONFIG_PV_SHIM_EXCLUSIVE=y > >

Re: [Xen-devel] [PATCH v2 1/2] x86: decouple xen alignment setting from EFI/ELF build

2019-03-19 Thread Wei Liu
On Tue, Mar 19, 2019 at 01:09:35PM +, Andrew Cooper wrote: > On 19/03/2019 13:05, Wei Liu wrote: > > @@ -20,13 +19,22 @@ ENTRY(efi_start) > > #else /* !EFI */ > > > > #define FORMAT "elf64-x86-64" > > -#define SECTION_ALIGN PAGE_SIZE > > #define DECL_SECTION(x) x : AT(ADDR(x) -

Re: [Xen-devel] [PATCH v2 1/2] x86: decouple xen alignment setting from EFI/ELF build

2019-03-19 Thread Jan Beulich
>>> On 19.03.19 at 14:05, wrote: > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -138,6 +138,29 @@ config TBOOT > > If unsure, say Y. > > +choice > + prompt "Alignment of Xen image" > + depends on X86 Sorry, noticed only while looking at patch 2 again: This

Re: [Xen-devel] [PATCH v2 2/2] x86/pvshim: use 2M alignment

2019-03-19 Thread Jan Beulich
>>> On 19.03.19 at 14:05, wrote: > --- a/xen/arch/x86/configs/pvshim_defconfig > +++ b/xen/arch/x86/configs/pvshim_defconfig > @@ -5,6 +5,7 @@ CONFIG_PVH_GUEST=y > CONFIG_PV_SHIM=y > CONFIG_PV_SHIM_EXCLUSIVE=y > CONFIG_NR_CPUS=32 > +CONFIG_XEN_ALIGN_2M=y > # Disable features not used by the

Re: [Xen-devel] [PATCH v2 1/2] x86: decouple xen alignment setting from EFI/ELF build

2019-03-19 Thread Jan Beulich
>>> On 19.03.19 at 14:09, wrote: > On 19/03/2019 13:05, Wei Liu wrote: >> @@ -20,13 +19,22 @@ ENTRY(efi_start) >> #else /* !EFI */ >> >> #define FORMAT "elf64-x86-64" >> -#define SECTION_ALIGN PAGE_SIZE >> #define DECL_SECTION(x) x : AT(ADDR(x) - __XEN_VIRT_START) >> >> ENTRY(start_pa) >>

Re: [Xen-devel] [PATCH v2 01/14] x86/cpu: Create Hygon Dhyana architecture support file

2019-03-19 Thread Pu Wen
On 2019/3/19 21:02, Jan Beulich wrote: > On 19.03.19 at 13:33, wrote: >> On 2019/3/18 16:55, Jan Beulich wrote: >>> On 16.03.19 at 10:57, wrote: On 2019/3/15 19:18, Jan Beulich wrote: > On 15.03.19 at 11:17, wrote: >> On 2019/3/15 1:11, Jan Beulich wrote: >>> This is a lot of

[Xen-devel] [linux-next test] 133897: regressions - FAIL

2019-03-19 Thread osstest service owner
flight 133897 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/133897/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-amd64 10 freebsd-install fail REGR. vs. 133829 Tests which did not

Re: [Xen-devel] [PATCH v9 10/11] viridian: add implementation of synthetic timers

2019-03-19 Thread Jan Beulich
>>> On 19.03.19 at 13:47, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 19 March 2019 12:18 >> >> So perhaps a set >> pending bit should result in the RDMSR handling to clear the enabled >> bit in the returned value for a non-periodic timer? > > I get tied in knots every time

Re: [Xen-devel] [PATCH v9 10/11] viridian: add implementation of synthetic timers

2019-03-19 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf Of > Paul Durrant > Sent: 19 March 2019 12:47 > To: 'Jan Beulich' > Cc: Stefano Stabellini ; Wei Liu > ; Konrad Rzeszutek Wilk > ; Andrew Cooper ; Tim > (Xen.org) ; > George Dunlap ; Julien

[Xen-devel] [PATCH v2 0/2] x86: more flexible alignment handling for xen image

2019-03-19 Thread Wei Liu
Wei Liu (2): x86: decouple xen alignment setting from EFI/ELF build x86/pvshim: use 2M alignment xen/arch/x86/Kconfig | 23 +++ xen/arch/x86/configs/pvshim_defconfig | 1 + xen/arch/x86/xen.lds.S| 12 ++-- 3 files changed, 34

Re: [Xen-devel] [PATCH v2 01/14] x86/cpu: Create Hygon Dhyana architecture support file

2019-03-19 Thread Jan Beulich
>>> On 19.03.19 at 13:33, wrote: > On 2019/3/18 16:55, Jan Beulich wrote: >> On 16.03.19 at 10:57, wrote: >>> On 2019/3/15 19:18, Jan Beulich wrote: On 15.03.19 at 11:17, wrote: > On 2019/3/15 1:11, Jan Beulich wrote: >> This is a lot of duplicated code with only minor differences.

Re: [Xen-devel] [PATCH v2 03/14] x86/cpu/vpmu: Add Hygon Dhyana and AMD Zen support for vPMU

2019-03-19 Thread Jan Beulich
>>> On 19.03.19 at 12:32, wrote: > On 2019/3/18 16:59, Jan Beulich wrote: > On 16.03.19 at 11:11, wrote: >>> On 2019/3/15 20:41, Jan Beulich wrote: >>> On 21.02.19 at 10:50, wrote: > --- a/xen/arch/x86/cpu/vpmu_amd.c > +++ b/xen/arch/x86/cpu/vpmu_amd.c > @@ -545,6 +545,8 @@

Re: [Xen-devel] [PATCH 1/2] x86: decouple xen alignment setting from EFI/non-EFI build

2019-03-19 Thread Jan Beulich
>>> On 19.03.19 at 12:24, wrote: > On Tue, Mar 19, 2019 at 04:45:35AM -0600, Jan Beulich wrote: >> >>> On 18.03.19 at 15:57, wrote: >> > --- a/xen/arch/x86/Kconfig >> > +++ b/xen/arch/x86/Kconfig >> > @@ -138,6 +138,32 @@ config TBOOT >> > >> > If unsure, say Y. >> > >> > +choice >> > +

Re: [Xen-devel] [PATCH v9 10/11] viridian: add implementation of synthetic timers

2019-03-19 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 19 March 2019 12:18 > To: Paul Durrant > Cc: Julien Grall ; Andrew Cooper > ; Roger Pau Monne > ; Wei Liu ; George Dunlap > ; Ian > Jackson ; Stefano Stabellini > ; xen-devel de...@lists.xenproject.org>;

Re: [Xen-devel] [PATCH v2 01/14] x86/cpu: Create Hygon Dhyana architecture support file

2019-03-19 Thread Pu Wen
On 2019/3/18 16:55, Jan Beulich wrote: > On 16.03.19 at 10:57, wrote: >> On 2019/3/15 19:18, Jan Beulich wrote: >>> On 15.03.19 at 11:17, wrote: On 2019/3/15 1:11, Jan Beulich wrote: > This is a lot of duplicated code with only minor differences. I think > you would be better off

[Xen-devel] [distros-debian-snapshot test] 83751: trouble: blocked/broken

2019-03-19 Thread Platform Team regression test user
flight 83751 distros-debian-snapshot real [real] http://osstest.xensource.com/osstest/logs/83751/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-pvopsbroken build-i386

Re: [Xen-devel] [PATCH v9 10/11] viridian: add implementation of synthetic timers

2019-03-19 Thread Jan Beulich
>>> On 19.03.19 at 10:21, wrote: > +static void poll_stimer(struct vcpu *v, unsigned int stimerx) > +{ > +struct viridian_vcpu *vv = v->arch.hvm.viridian; > +struct viridian_stimer *vs = >stimer[stimerx]; > + > +/* > + * Timer expiry may race with the timer being disabled. If the

Re: [Xen-devel] [PATCH v2 03/14] x86/cpu/vpmu: Add Hygon Dhyana and AMD Zen support for vPMU

2019-03-19 Thread Pu Wen
On 2019/3/18 16:59, Jan Beulich wrote: On 16.03.19 at 11:11, wrote: On 2019/3/15 20:41, Jan Beulich wrote: On 21.02.19 at 10:50, wrote: --- a/xen/arch/x86/cpu/vpmu_amd.c +++ b/xen/arch/x86/cpu/vpmu_amd.c @@ -545,6 +545,8 @@ int __init amd_vpmu_init(void) switch ( current_cpu_data.x86

Re: [Xen-devel] [PATCH 1/2] x86: decouple xen alignment setting from EFI/non-EFI build

2019-03-19 Thread Wei Liu
On Tue, Mar 19, 2019 at 04:45:35AM -0600, Jan Beulich wrote: > >>> On 18.03.19 at 15:57, wrote: > > Introduce a new Kconfig option to pick the alignment for xen binary. > > To retain original behaviour, the default pick for EFI build is 2M and > > non-EFI build 4K. > > Is this a worthwhile step

Re: [Xen-devel] [PATCH 1/2] x86: decouple xen alignment setting from EFI/non-EFI build

2019-03-19 Thread Jan Beulich
>>> On 18.03.19 at 15:57, wrote: > Introduce a new Kconfig option to pick the alignment for xen binary. > To retain original behaviour, the default pick for EFI build is 2M and > non-EFI build 4K. Is this a worthwhile step to take, considering that we mean to switch to 2M main section boundaries

[Xen-devel] Arm boot regression with Xen 4.12

2019-03-19 Thread Julien Grall
(+ Juergen) Hi Amit, On 3/18/19 3:12 PM, Amit Tomer wrote: >> It will be difficult to help without any log. You probably want to try with >> Stefano series instead. However ... > > If we comment out GPU node(gpu@3800) , we don't see this issue and > Dom0 kernel is > loaded into memory but

[Xen-devel] [xen-unstable test] 133896: tolerable FAIL

2019-03-19 Thread osstest service owner
flight 133896 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/133896/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stopfail like 133864

[Xen-devel] [PATCH v9 11/11] viridian: add implementation of the HvSendSyntheticClusterIpi hypercall

2019-03-19 Thread Paul Durrant
This patch adds an implementation of the hypercall as documented in the specification [1], section 10.5.2. This enlightenment, as with others, is advertised by CPUID leaf 0x4004 and is under control of a new 'hcall_ipi' option in libxl. If used, this enlightenment should mean the guest only

[Xen-devel] [PATCH v9 10/11] viridian: add implementation of synthetic timers

2019-03-19 Thread Paul Durrant
This patch introduces an implementation of the STIMER0-15_CONFIG/COUNT MSRs and hence a the first SynIC message source. The new (and documented) 'stimer' viridian enlightenment group may be specified to enable this feature. While in the neighbourhood, this patch adds a missing check for an

[Xen-devel] [PATCH v9 03/11] viridian: use stack variables for viridian_vcpu and viridian_domain...

2019-03-19 Thread Paul Durrant
...where there is more than one dereference inside a function. This shortens the code and makes it more readable. No functional change. Signed-off-by: Paul Durrant Reviewed-by: Jan Beulich --- Cc: Andrew Cooper Cc: Wei Liu Cc: "Roger Pau Monné" v4: - New in v4 ---

[Xen-devel] [PATCH v9 07/11] viridian: use viridian_map/unmap_guest_page() for reference tsc page

2019-03-19 Thread Paul Durrant
Whilst the reference tsc page does not currently need to be kept mapped after it is initially set up (or updated after migrate), the code can be simplified by using the common guest page map/unmap and dump functions. New functionality added by a subsequent patch will also require the page to kept

[Xen-devel] [PATCH v9 04/11] viridian: make 'fields' struct anonymous...

2019-03-19 Thread Paul Durrant
...inside viridian_page_msr and viridian_guest_os_id_msr unions. There's no need to name it and the code is shortened by not doing so. No functional change. Signed-off-by: Paul Durrant Reviewed-by: Jan Beulich --- Cc: Andrew Cooper Cc: Wei Liu Cc: "Roger Pau Monné" v4: - New in v4 ---

[Xen-devel] [PATCH v9 00/11] viridian: implement more enlightenments

2019-03-19 Thread Paul Durrant
This series adds three new enlightenments: - Synthetic timers, which depends on the... - Synthetic interrupt controller (or SynIC) - Synthetic cluster IPI All these enlightenments are implemented in current versions of QEMU/KVM so this series closes the gap. Paul Durrant (11): viridian: add

[Xen-devel] [PATCH v9 06/11] viridian: add missing context save helpers into synic and time modules

2019-03-19 Thread Paul Durrant
Currently the time module lacks vcpu context save helpers and the synic module lacks domain context save helpers. These helpers are not yet required but subsequent patches will require at least some of them so this patch completes the set to avoid introducing them in an ad-hoc way. Signed-off-by:

[Xen-devel] [PATCH v9 01/11] viridian: add init hooks

2019-03-19 Thread Paul Durrant
This patch adds domain and vcpu init hooks for viridian features. The init hooks do not yet do anything; the functionality will be added to by subsequent patches. Signed-off-by: Paul Durrant Reviewed-by: Wei Liu Acked-by: Jan Beulich --- Cc: Andrew Cooper Cc: "Roger Pau Monné" v5: - Put

[Xen-devel] [PATCH v9 08/11] viridian: stop directly calling viridian_time_ref_count_freeze/thaw()...

2019-03-19 Thread Paul Durrant
...from arch_domain_shutdown/pause/unpause(). A subsequent patch will introduce an implementaion of synthetic timers which will also need freeze/thaw hooks, so make the exported hooks more generic and call through to (re-named and static) time_ref_count_freeze/thaw functions. NOTE: This patch

[Xen-devel] [PATCH v9 09/11] viridian: add implementation of synthetic interrupt MSRs

2019-03-19 Thread Paul Durrant
This patch introduces an implementation of the SCONTROL, SVERSION, SIEFP, SIMP, EOM and SINT0-15 SynIC MSRs. No message source is added and, as such, nothing will yet generate a synthetic interrupt. A subsequent patch will add an implementation of synthetic timers which will need the

[Xen-devel] [PATCH v9 02/11] viridian: separately allocate domain and vcpu structures

2019-03-19 Thread Paul Durrant
Currently the viridian_domain and viridian_vcpu structures are inline in the hvm_domain and hvm_vcpu structures respectively. Subsequent patches will need to add sizable extra fields to the viridian structures which will cause the PAGE_SIZE limit of the overall vcpu structure to be exceeded. This

[Xen-devel] [PATCH v9 05/11] viridian: extend init/deinit hooks into synic and time modules

2019-03-19 Thread Paul Durrant
This patch simply adds domain and vcpu init/deinit hooks into the synic and time modules and wires them into viridian_[domain|vcpu]_[init|deinit](). Only one of the hooks is currently needed (to unmap the 'VP Assist' page) but subsequent patches will make use of the others. NOTE: To perform the

Re: [Xen-devel] [PATCH V2 02/10] block: avoid to break XEN by multi-page bvec

2019-03-19 Thread Juergen Gross
On 17/03/2019 11:01, Ming Lei wrote: > XEN has special page merge requirement, see xen_biovec_phys_mergeable(). > We can't merge pages into one bvec simply for XEN. > > So move XEN's specific check on page merge into __bio_try_merge_page(), > then abvoid to break XEN by multi-page bvec. > > Cc:

  1   2   >