Re: [Xen-devel] [PATCH v2] Allow get_maintainer.pl / add_maintainers.pl scripts to be called outside of xen.git

On 16/08/2019 13:17, Lars Kurth wrote: On 16/08/2019, 11:01, "Julien Grall" wrote: From my understanding, any use on mini-os.git & co will be legitimate. However, we still print the WARNING in those cases. Usually WARNING means something needs attention. As most of the

Re: [Xen-devel] [PATCH 03/11] xen/arm: pass one less argument to dma_cache_maint

On 16/08/2019 14:00, Christoph Hellwig wrote: Instead of taking apart the dma address in both callers do it inside dma_cache_maint itself. Signed-off-by: Christoph Hellwig --- arch/arm/xen/mm.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/arch/arm/xen/mm.c b

Re: [Xen-devel] [PATCH v2] Allow get_maintainer.pl / add_maintainers.pl scripts to be called outside of xen.git

> On 16 Aug 2019, at 14:28, Julien Grall wrote: > > > > On 16/08/2019 13:17, Lars Kurth wrote: >> On 16/08/2019, 11:01, "Julien Grall" wrote: >> From my understanding, any use on mini-os.git & co will be legitimate. >> However, >> we still print the WARNING in those cases. >>

Re: [Xen-devel] [livepatch-build-tools part2 v2 5/6] create-diff-object: Add new entries to special sections array array

On 8/16/19 1:06 PM, Wieczorkiewicz, Pawel wrote: On 16. Aug 2019, at 11:40, Ross Lagerwall > wrote: On 8/8/19 1:35 PM, Pawel Wieczorkiewicz wrote: …snip...   * The rela groups in the .fixup section vary in size.  The beginning of each   * .fixup rela gro

Re: [Xen-devel] [livepatch-build-tools part3 v2 3/3] create-diff-object: Strip all undefined entires of known size

On 8/8/19 1:51 PM, Pawel Wieczorkiewicz wrote: The patched ELF object file contains all sections and symbols as resulted from the compilation. However, certain symbols may not be copied over to the resulting object file, due to being unchanged or not included for other reasons. In such situation

Re: [Xen-devel] [libvirt test] 140186: regressions - FAIL

On 8/16/19 7:01 AM, osstest service owner wrote: > flight 140186 libvirt real [real] > http://logs.test-lab.xenproject.org/osstest/logs/140186/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > build-amd64-libvirt 6 libvi

Re: [Xen-devel] [livepatch-build-tools part3 v2 2/3] create-diff-object: Extend patchability verification: STN_UNDEF

On 8/8/19 1:48 PM, Pawel Wieczorkiewicz wrote: During verification check if all sections do not contain any entries with undefined symbols (STN_UNDEF). This situation can happen when a section is copied over from its original object to a patched object, but various symbols related to the section

Re: [Xen-devel] [RFC] Code of Conduct

On Aug 16, 2019, at 07:19, George Dunlap wrote: > > On 8/15/19 6:23 PM, Rich Persaud wrote: >>> On Aug 9, 2019, at 13:48, Lars Kurth wrote: >>> >>> Hi all, >> >> Hi Lars, >> >>> >>> Following the discussion we had at the Developer Summit (see >>> https://wiki.xenproject.org/wiki/Design_Sess

Re: [Xen-devel] [RFC] Code of Conduct

From: Rich Persaud Date: Friday, 16 August 2019 at 16:49 To: George Dunlap Cc: Lars Kurth , xen-devel , "minios-de...@lists.xenproject.org" , "mirageos-de...@lists.xenproject.org" , "win-pv-de...@lists.xenproject.org" , "committ...@xenproject.org" Subject: Re: [Xen-devel] [RFC] Code of Co

Re: [Xen-devel] [PATCH] xen/arm: domain_build: Remove redundant check in make_vpl011_uart_node()

Hi Julien, Julien Grall writes: > None of the code since the last check of res modify the value. So the > check can be removed. > > Coverity-ID: 1476824 > Signed-off-by: Julien Grall Reviewed-by: Volodymyr Babchuk > --- > xen/arch/arm/domain_build.c | 3 +-- > 1 file changed, 1 insertion(+),

Re: [Xen-devel] [PATCH] xen/arm: domain_build: Print the correct domain in construct_domain()

Julien Grall writes: > construct_domain() can be called by other domain than dom0. To avoid > confusion in the log, print the correct domain. > > Signed-off-by: Julien Grall Reviewed-by: Volodymyr Babchuk > --- > xen/arch/arm/domain_build.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletio

Re: [Xen-devel] [PATCH] xen/arm: domain_build: Print the correct domain in initrd_load()

Julien Grall writes: > initrd_load() can be called by other domain than dom0. To avoid > confusion in the log, print the correct domain. > > Signed-off-by: Julien Grall Reviewed-by: Volodymyr Babchuk But why didn't you gathered all those patches into one patch series? > --- > xen/arch/arm/dom

Re: [Xen-devel] [PATCH v2] xen/arm: domain_build: Print the correct domain in dtb_load()

Julien Grall writes: > dtb_load() can be called by other domain than dom0. To avoid confusion > in the log, print the correct domain. > > Signed-off-by: Julien Grall Reviewed-by: Volodymyr Babchuk > > --- > Changes in v2: > - Fix the second print in the function as well. > --- > x

Re: [Xen-devel] [PATCH] xen/arm: domain_build: Print the correct domain in initrd_load()

On 16/08/2019 17:32, Volodymyr Babchuk wrote: Julien Grall writes: initrd_load() can be called by other domain than dom0. To avoid confusion in the log, print the correct domain. Signed-off-by: Julien Grall Reviewed-by: Volodymyr Babchuk But why didn't you gathered all those patches int

Re: [Xen-devel] [PATCH 03/11] xen/arm: pass one less argument to dma_cache_maint

On Fri, Aug 16, 2019 at 02:37:58PM +0100, Robin Murphy wrote: > On 16/08/2019 14:00, Christoph Hellwig wrote: >> Instead of taking apart the dma address in both callers do it inside >> dma_cache_maint itself. >> >> Signed-off-by: Christoph Hellwig >> --- >> arch/arm/xen/mm.c | 10 ++ >>

[Xen-devel] [linux-4.4 test] 140180: regressions - FAIL

flight 140180 linux-4.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/140180/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvshim 20 guest-start/debian.repeat fail in 140072 REGR. vs. 139698 Tests which

[Xen-devel] [PATCH v6 01/10] make passthrough/pci.c:deassign_device() static

This function is only ever called from within the same source module and really has no business being declared xen/iommu.h. This patch relocates the function ahead of the first called and makes it static. Signed-off-by: Paul Durrant Acked-by: Jan Beulich --- Previously part of series https://l

[Xen-devel] [PATCH v6 07/10] use is_iommu_enabled() where appropriate...

...rather than testing the global iommu_enabled flag and ops pointer. Now that there is a per-domain flag indicating whether the domain is permitted to use the IOMMU (which determines whether the ops pointer will be set), many tests of the global iommu_enabled flag and ops pointer can be translate

[Xen-devel] [PATCH v6 08/10] remove late (on-demand) construction of IOMMU page tables

Now that there is a per-domain IOMMU enable flag, which should be enabled if any device is going to be passed through, stop deferring page table construction until the assignment is done. Also don't tear down the tables again when the last device is de-assigned; defer that task until domain destruc

[Xen-devel] [PATCH v6 06/10] domain: introduce XEN_DOMCTL_CDF_iommu flag

This patch introduces a common domain creation flag to determine whether the domain is permitted to make use of the IOMMU. Currently the flag is always set (for both dom0 and domU) if the IOMMU is globally enabled (i.e. iommu_enabled == 1). sanitise_domain_config() is modified to reject the flag if

[Xen-devel] [PATCH v6 04/10] domain: remove the 'is_xenstore' flag

This patch introduces a convenience macro, is_xenstore_domain(), which tests the domain 'options' directly and then uses that in place of the 'is_xenstore' flag. Signed-off-by: Paul Durrant Reviewed-by: "Roger Pau Monné" Acked-by: George Dunlap --- Cc: Andrew Cooper Cc: Ian Jackson Cc: Jan Be

[Xen-devel] [PATCH v6 05/10] x86/domain: remove the 's3_integrity' flag

The flag is not needed since the domain 'options' can now be tested directly. Signed-off-by: Paul Durrant Reviewed-by: "Roger Pau Monné" Reviewed-by: Jan Beulich --- Cc: Andrew Cooper Cc: Wei Liu v4: - s/TBOOT/CONFIG_TBOOT/g v3: - Also sanitise the flag against CONFIG_TBOOT being set ---

[Xen-devel] [PATCH v6 02/10] x86/hvm/domain: remove the 'hap_enabled' flag

The hap_enabled() macro can determine whether the feature is available using the domain 'options'; there is no need for a separate flag. NOTE: Furthermore, by extending sanitiziing of the domain 'options', the macro can be transformed into an inline function and re-located to xen/sched

[Xen-devel] [PATCH v6 00/10] use stashed domain create flags...

...and add per-domain IOMMU control This is a combination of my previously separate series [1] and [2]. [1] https://lists.xenproject.org/archives/html/xen-devel/2019-07/msg02253.html [2] https://lists.xenproject.org/archives/html/xen-devel/2019-07/msg02267.html Paul Durrant (10): make passthro

[Xen-devel] [PATCH v6 03/10] x86/domain: remove the 'oos_off' flag

The flag is not needed since the domain 'options' can now be tested directly. Signed-off-by: Paul Durrant Reviewed-by: Jan Beulich --- Cc: Tim Deegan Cc: George Dunlap Cc: Andrew Cooper Cc: Wei Liu Cc: "Roger Pau Monné" v3: - Force 'oos_off' to be set for PV guests (to avoid call to is

[Xen-devel] [PATCH v6 09/10] iommu: tidy up iommu_use_hap_pt() and need_iommu_pt_sync() macros

Thes macros really ought to live in the common xen/iommu.h header rather then being distributed amongst architecture specific iommu headers and xen/sched.h. This patch moves them there. NOTE: Disabling 'sharept' in the command line iommu options should really be hard error on ARM (as opposed

Re: [Xen-devel] [PATCH v6 08/10] remove late (on-demand) construction of IOMMU page tables

On 8/16/19 8:19 PM, Paul Durrant wrote: > Now that there is a per-domain IOMMU enable flag, which should be enabled if > any device is going to be passed through, stop deferring page table > construction until the assignment is done. Also don't tear down the tables > again when the last device is d

[Xen-devel] [PATCH v6 10/10] introduce a 'passthrough' configuration option to xl.cfg...

...and hence the ability to disable IOMMU mappings, and control EPT sharing. This patch introduces a new 'libxl_passthrough' enumeration into libxl_domain_create_info. The value will be set by xl either when it parses a new 'passthrough' option in xl.cfg, or implicitly if there is passthrough hard

Re: [Xen-devel] [PATCH v2 3/4] xen/public: Document HYPERCALL_console_io()

Hi, On 08/08/2019 15:03, Jan Beulich wrote: On 05.08.2019 15:29, Julien Grall wrote: Currently, OS developpers will have to look at Xen code in order to know the parameters of an hypercall and how it is meant to work. This is not a trivial task as you may need to have a deep understanding of X

[Xen-devel] [linux-linus bisection] complete test-amd64-i386-xl-xsm

branch xen-unstable xenbranch xen-unstable job test-amd64-i386-xl-xsm testid xen-boot Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu g

[Xen-devel] More questions about Xen memory layout/usage, access to guest memory

Hi all, I have some follow-up questions about Xen's usage and layout of memory, building on the ones I asked here a few weeks ago (which were quite helpfully answered: see https://lists.xenproject.org/archives/html/xen-devel/2019-07/msg01513.html for reference). For context on why I'm asking t

[Xen-devel] [freebsd-master test] 140195: all pass - PUSHED

flight 140195 freebsd-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/140195/ Perfect :-) All tests in this flight passed as required version targeted for testing: freebsd f39a1bd1426e0e5a462522b7a1de56e8233591e7 baseline version: freebsd 4bc76934c5c

Re: [Xen-devel] [PATCH v2 3/4] xen/public: Document HYPERCALL_console_io()

On 8/16/19 6:42 PM, Julien Grall wrote: Hi, On 08/08/2019 15:03, Jan Beulich wrote: On 05.08.2019 15:29, Julien Grall wrote: Currently, OS developpers will have to look at Xen code in order to know the parameters of an hypercall and how it is meant to work. This is not a trivial task as you m

Re: [Xen-devel] [PATCH v2 0/4] xen/console: Bug fixes and doc improvement

Hi, On 8/5/19 2:29 PM, Julien Grall wrote: Hi all, This series contains a bunch of bug fixes for the hypercall CONSOLEIO_write and some documentation. Cheers, Julien Grall (4): xen/console: Don't treat NUL character as the end of the buffer xen/console: Rework HYPERCALL_console_io inter

[Xen-devel] [linux-linus test] 140188: regressions - FAIL

flight 140188 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/140188/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-examine 8 reboot fail REGR. vs. 133580 test-amd64-i386-xl-

Re: [Xen-devel] [PATCH 07/11] swiotlb-xen: provide a single page-coherent.h header

Hi, On 8/16/19 2:00 PM, Christoph Hellwig wrote: Merge the various page-coherent.h files into a single one that either provides prototypes or stubs depending on the need for cache maintainance. For extra benefits alo include in the file actually implementing the interfaces provided. Signed-of

Re: [Xen-devel] [PATCH v6 7/8] xen/arm: don't iomem_permit_access for reserved-memory regions

On Fri, 16 Aug 2019, Julien Grall wrote: > On 16/08/2019 00:36, Stefano Stabellini wrote: > > Don't allow reserved-memory regions to be remapped into any unprivileged > > guests, until reserved-memory regions are properly supported in Xen. For > > now, do not call iomem_permit_access on them, becau

[Xen-devel] [xen-unstable-smoke test] 140214: tolerable all pass - PUSHED

flight 140214 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/140214/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [PATCH v6 1/8] xen/arm: pass node to device_tree_for_each_node

On Fri, 16 Aug 2019, Julien Grall wrote: > Hi, > > On 16/08/2019 00:36, Stefano Stabellini wrote: > > Add a new parameter to device_tree_for_each_node: node, the node to > > start the search from. Passing 0 triggers the old behavior. > > Here you say 0 triggers the old behavior but... > > > > >

Re: [Xen-devel] [PATCH v6 2/8] xen/arm: make process_memory_node a device_tree_node_func

On Fri, 16 Aug 2019, Julien Grall wrote: > Hi, > > On 16/08/2019 00:36, Stefano Stabellini wrote: > > Change the signature of process_memory_node to match > > device_tree_node_func. Thanks to this change, the next patch will be > > able to use device_tree_for_each_node to call process_memory_node

[Xen-devel] [xen-unstable test] 140192: regressions - FAIL

flight 140192 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/140192/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvshim 20 guest-start/debian.repeat fail REGR. vs. 139876 Tests which did no

[Xen-devel] [linux-4.14 test] 140193: regressions - FAIL

flight 140193 linux-4.14 real [real] http://logs.test-lab.xenproject.org/osstest/logs/140193/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-xsm 7 xen-boot fail REGR. vs. 139910 test-amd64-i386-free

Re: [Xen-devel] [PATCH 07/11] swiotlb-xen: provide a single page-coherent.h header

On Fri, Aug 16, 2019 at 11:40:43PM +0100, Julien Grall wrote: > I am not sure I agree with this rename. The implementation of the helpers > are very Arm specific as this is assuming Dom0 is 1:1 mapped. > > This was necessary due to the lack of IOMMU on Arm platforms back then. > But this is now a

<    1   2