Re: [Xen-devel] [GIT PULL] dma-mapping updates for 5.4

2019-09-19 Thread Michal Simek
On 20. 09. 19 1:17, Michael Ellerman wrote: > > > On 20 September 2019 6:33:50 am AEST, Linus Torvalds > wrote: >> On Wed, Sep 18, 2019 at 8:27 AM Christoph Hellwig >> wrote: >>> >>> please pull the dma-mapping updates for 5.4. >> >> Pulled. >> >>> In addition to the usual Kconfig conflics

[Xen-devel] [xen-unstable test] 141459: tolerable FAIL

2019-09-19 Thread osstest service owner
flight 141459 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/141459/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-examine 11 examine-serial/bootloaderfail like 141376

[Xen-devel] [xen-unstable-smoke test] 141489: regressions - FAIL

2019-09-19 Thread osstest service owner
flight 141489 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/141489/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 7 xen-boot fail REGR. vs. 141253 Tests which

[Xen-devel] [linux-4.19 test] 141453: regressions - FAIL

2019-09-19 Thread osstest service owner
flight 141453 linux-4.19 real [real] http://logs.test-lab.xenproject.org/osstest/logs/141453/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-pvops 6 kernel-build fail REGR. vs. 129313 Tests which are

Re: [Xen-devel] [PATCH] xen/arm: iommu: Panic if not all IOMMUs are initialized

2019-09-19 Thread Stefano Stabellini
On Tue, 20 Aug 2019, Oleksandr wrote: > > On 20.08.19 15:22, Julien Grall wrote: > > Hi, Julien > > > -iommu_setup(); > > +rc = iommu_setup(); > > +if ( !iommu_enabled && rc != -ENODEV ) > > +panic("Couldn't configure correctly all the IOMMUs."); > > > > Please add

Re: [Xen-devel] [PATCH V4 8/8] iommu/arm: Add Renesas IPMMU-VMSA support

2019-09-19 Thread Yoshihiro Shimoda
Hi Oleksandr-san, > From: Oleksandr Tyshchenko, Sent: Saturday, September 14, 2019 12:35 AM > > From: Oleksandr Tyshchenko > > The IPMMU-VMSA is VMSA-compatible I/O Memory Management Unit (IOMMU) > which provides address translation and access protection functionalities > to processing units

[Xen-devel] [xen-unstable-smoke test] 141485: regressions - FAIL

2019-09-19 Thread osstest service owner
flight 141485 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/141485/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 7 xen-boot fail REGR. vs. 141253 Tests which

Re: [Xen-devel] [[PATCH for-4.13]] xen/arm: mm: Allow generic xen page-tables helpers to be called early

2019-09-19 Thread Stefano Stabellini
On Tue, 17 Sep 2019, Julien Grall wrote: > The current implementations of xen_{map, unmap}_table() expect > {map, unmap}_domain_page() to be usable. Those helpers are used to > map/unmap page tables while update Xen page-tables. > > Since commit 022387ee1a "xen/arm: mm: Don't open-code Xen PT

[Xen-devel] [libvirt test] 141456: regressions - FAIL

2019-09-19 Thread osstest service owner
flight 141456 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/141456/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-qcow2 15 guest-start/debian.repeat fail REGR. vs. 141415 Tests which did

Re: [Xen-devel] [GIT PULL] dma-mapping updates for 5.4

2019-09-19 Thread Michael Ellerman
On 20 September 2019 6:33:50 am AEST, Linus Torvalds wrote: >On Wed, Sep 18, 2019 at 8:27 AM Christoph Hellwig >wrote: >> >> please pull the dma-mapping updates for 5.4. > >Pulled. > >> In addition to the usual Kconfig conflics where you just want to keep >> both edits there are a few more

Re: [Xen-devel] [PATCH] xen/arm32: setup: Give a xenheap page to the boot allocator

2019-09-19 Thread Stefano Stabellini
On Tue, 17 Sep 2019, Julien Grall wrote: > After commit 6e3e771203 "xen/arm: setup: Relocate the Device-Tree later on > in the boot", the boot allocator will not receive any xenheap page (i.e. > mapped page) on Arm32. > > However, the boot allocator implicitely rely on having the first page >

Re: [Xen-devel] [PATCH RFC] pass-through: sync pir to irr after msix vector been updated

2019-09-19 Thread Joe Jin
On 9/19/19 3:24 AM, Jan Beulich wrote: > On 18.09.2019 23:16, Joe Jin wrote: >> On 9/16/19 11:48 PM, Jan Beulich wrote: >>> On 17.09.2019 00:20, Joe Jin wrote: On 9/16/19 1:01 AM, Jan Beulich wrote: > On 13.09.2019 18:38, Joe Jin wrote: >> On 9/13/19 12:14 AM, Jan Beulich wrote:

Re: [Xen-devel] [GIT PULL] dma-mapping updates for 5.4

2019-09-19 Thread pr-tracker-bot
The pull request you sent on Wed, 18 Sep 2019 08:27:48 -0700: > git://git.infradead.org/users/hch/dma-mapping.git tags/dma-mapping-5.4 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/671df189537883f36cf9c7d4f9495bfac0f86627 Thank you! -- Deet-doot-dot, I am a bot.

[Xen-devel] [xen-unstable-smoke test] 141480: regressions - FAIL

2019-09-19 Thread osstest service owner
flight 141480 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/141480/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 7 xen-boot fail REGR. vs. 141253 Tests which

[Xen-devel] [linux-linus test] 141446: regressions - FAIL

2019-09-19 Thread osstest service owner
flight 141446 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/141446/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-i386 7 xen-boot fail REGR. vs. 133580

Re: [Xen-devel] [PATCH] SVM: correct CPUID event processing

2019-09-19 Thread Razvan COJOCARU
On 9/19/19 11:07 PM, Boris Ostrovsky wrote: > On 9/19/19 6:37 AM, Jan Beulich wrote: >> hvm_monitor_cpuid() expects the input registers, not two of the outputs. >> >> However, once having made the necessary adjustment, the SVM and VMX >> functions are so similar that they should be folded (thus

Re: [Xen-devel] [GIT PULL] dma-mapping updates for 5.4

2019-09-19 Thread Linus Torvalds
On Wed, Sep 18, 2019 at 8:27 AM Christoph Hellwig wrote: > > please pull the dma-mapping updates for 5.4. Pulled. > In addition to the usual Kconfig conflics where you just want to keep > both edits there are a few more interesting merge issues this time: > > - most importanly powerpc and

[Xen-devel] [linux-4.4 test] 141448: regressions - FAIL

2019-09-19 Thread osstest service owner
flight 141448 linux-4.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/141448/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvshim 20 guest-start/debian.repeat fail REGR. vs. 139698 Tests which are

Re: [Xen-devel] [PATCH] SVM: correct CPUID event processing

2019-09-19 Thread Boris Ostrovsky
On 9/19/19 6:37 AM, Jan Beulich wrote: > hvm_monitor_cpuid() expects the input registers, not two of the outputs. > > However, once having made the necessary adjustment, the SVM and VMX > functions are so similar that they should be folded (thus avoiding > further similar asymmetries to get

Re: [Xen-devel] [PATCH v2 00/35] libxl refactoring to use ev_qmp (with API changes)

2019-09-19 Thread Ian Jackson
Anthony PERARD writes ("[PATCH v2 00/35] libxl refactoring to use ev_qmp (with API changes)"): > Patches with missing ackes: > libxl: Use ev_qmp for switch_qemu_xen_logdirty > libxl: Use ev_qmp in libxl_set_vcpuonline > libxl_pci: Extract common part of *qemu_trad_watch_state_cb > >

Re: [Xen-devel] [PATCH v2 35/35] libxl_pci: Extract common part of *qemu_trad_watch_state_cb

2019-09-19 Thread Ian Jackson
Anthony PERARD writes ("[PATCH v2 35/35] libxl_pci: Extract common part of *qemu_trad_watch_state_cb"): > Functions pci_add_qemu_trad_watch_state_cb and > pci_remove_qemu_trad_watch_state_cb are similar so the common part is > extracted in a different function. OK (though not quite how I would

Re: [Xen-devel] [PATCH v2 00/35] libxl refactoring to use ev_qmp (with API changes) [and 1 more messages]

2019-09-19 Thread Ian Jackson
Anthony PERARD writes ("[PATCH v2 00/35] libxl refactoring to use ev_qmp (with API changes)"): > Patches with missing ackes: ... > libxl: Use ev_qmp in libxl_set_vcpuonline From my point of view I seem to have sent a ack for this, Message-ID:

Re: [Xen-devel] [PATCH v2 06/35] libxl: Use ev_qmp for switch_qemu_xen_logdirty

2019-09-19 Thread Ian Jackson
Anthony PERARD writes ("[PATCH v2 06/35] libxl: Use ev_qmp for switch_qemu_xen_logdirty"): > Signed-off-by: Anthony PERARD Acked-by: Ian Jackson (in line with my previous comments) ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

[Xen-devel] [ovmf test] 141451: all pass - PUSHED

2019-09-19 Thread osstest service owner
flight 141451 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/141451/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b0c15fb128c518b9acd8611a2deea213e9e55193 baseline version: ovmf

Re: [Xen-devel] [PATCH STABLE 4.9] x86, mm, gup: prevent get_page() race with munmap in paravirt guest

2019-09-19 Thread Ben Hutchings
On Mon, 2019-08-19 at 18:58 +0100, Vlastimil Babka wrote: [...] > Hi, I'm sending this stable-only patch for consideration because it's probably > unrealistic to backport the 4.13 switch to generic GUP. I can look at 4.4 and > 3.16 if accepted. The RCU page table freeing could be also considered.

[Xen-devel] [PATCH v2 28/35] libxl_pci: Use ev_qmp in do_pci_add

2019-09-19 Thread Anthony PERARD
This patch also replaces the use of libxl__wait_for_device_model_deprecated() by its equivalent without the need for a thread. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl_internal.h | 1 - tools/libxl/libxl_pci.c | 288 ---

[Xen-devel] [PATCH v2 24/35] libxl: Remove libxl__qmp_run_command_flexarray

2019-09-19 Thread Anthony PERARD
There are no more users. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl_internal.h | 3 --- tools/libxl/libxl_qmp.c | 16 2 files changed, 19 deletions(-) diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h index

[Xen-devel] [PATCH v2 13/35] libxl_dm: Update libxl__spawn_stub_dm to use libxl__domain_unpause

2019-09-19 Thread Anthony PERARD
Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl_dm.c | 22 +- tools/libxl/libxl_internal.h | 1 + 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index 246c570121d3..c00356a2f16a

[Xen-devel] [PATCH v2 15/35] libxl: Inline do_usbdev_add into libxl__device_usbdev_add

2019-09-19 Thread Anthony PERARD
Having the function do_usbdev_add makes it harder to add asynchronous calls into it. Move its body back into libxl__device_usbdev_add and adjust the latter as there are no reason to have a separated function. No functional changes. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson ---

[Xen-devel] [PATCH v2 17/35] libxl: Add libxl__ev_qmp to libxl__ao_device

2019-09-19 Thread Anthony PERARD
`aodev->qmp' is initialised in libxl__prepare_ao_device(), but since there isn't a single exit path for a `libxl__ao_device', users of this new `qmp' field will have to disposed of it. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- Notes: v2: - Added a comment to

[Xen-devel] [PATCH v2 16/35] libxl: Inline do_usbdev_remove into libxl__device_usbdev_remove

2019-09-19 Thread Anthony PERARD
Having the function do_usbdev_remove makes it harder to add asynchronous calls into it. Move its body back into libxl__device_usbdev_remove and adjust the latter as there are no reason to have a separated function. No functional changes. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson ---

[Xen-devel] [PATCH v2 31/35] libxl: Use ev_qmp for libxl_send_trigger

2019-09-19 Thread Anthony PERARD
Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl_domain.c | 49 ++-- tools/libxl/libxl_internal.h | 2 -- tools/libxl/libxl_qmp.c | 5 3 files changed, 42 insertions(+), 14 deletions(-) diff --git

[Xen-devel] [PATCH v2 10/35] libxl: Re-introduce libxl__domain_resume

2019-09-19 Thread Anthony PERARD
libxl__domain_resume is a rework libxl__domain_resume_deprecated. It makes uses of ev_xswatch and ev_qmp, to replace synchronous QMP calls and libxl__wait_for_device_model_deprecated call. This patch also introduce libxl__dm_resume which is a sub-operation of both libxl__domain_resume and

[Xen-devel] [PATCH v2 23/35] libxl: libxl__initiate_device_usbdev_remove now use ev_qmp

2019-09-19 Thread Anthony PERARD
Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl_usb.c | 78 +++-- 1 file changed, 68 insertions(+), 10 deletions(-) diff --git a/tools/libxl/libxl_usb.c b/tools/libxl/libxl_usb.c index 3b432231ea85..1fc7ccf41f86 100644 ---

[Xen-devel] [PATCH v2 21/35] libxl_usb: Make libxl__device_usbdev_add uses ev_qmp

2019-09-19 Thread Anthony PERARD
Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl_usb.c | 99 + 1 file changed, 81 insertions(+), 18 deletions(-) diff --git a/tools/libxl/libxl_usb.c b/tools/libxl/libxl_usb.c index 373b37d7159a..b9a31f96ebe3 100644 ---

[Xen-devel] [PATCH v2 29/35] libxl_pci: Use libxl__ao_device with pci_remove

2019-09-19 Thread Anthony PERARD
This is in preparation of using asynchronous operation to communicate with QEMU via QMP (libxl__ev_qmp). Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl_domain.c | 49 ++-- tools/libxl/libxl_internal.h | 6 +- tools/libxl/libxl_pci.c | 221

[Xen-devel] [PATCH v2 35/35] libxl_pci: Extract common part of *qemu_trad_watch_state_cb

2019-09-19 Thread Anthony PERARD
Functions pci_add_qemu_trad_watch_state_cb and pci_remove_qemu_trad_watch_state_cb are similar so the common part is extracted in a different function. Signed-off-by: Anthony PERARD --- Notes: v2: - new patch which attempt to combine the "basically-identical" functions

[Xen-devel] [PATCH v2 12/35] libxl: Re-introduce libxl__domain_unpause

2019-09-19 Thread Anthony PERARD
libxl__domain_unpause is a reimplementation of libxl__domain_unpause_deprecated with asynchronous operation. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl_domain.c | 52 tools/libxl/libxl_internal.h | 5 +++- 2 files changed,

[Xen-devel] [PATCH v2 22/35] libxl: Use aodev for libxl__device_usbdev_remove

2019-09-19 Thread Anthony PERARD
This also mean libxl__initiate_device_usbctrl_remove, which uses libxl__device_usbdev_remove synchronously, needs to be updated to use it with multidev. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl_usb.c | 79 +++-- 1 file

[Xen-devel] [PATCH v2 20/35] libxl_usb: Make libxl__initiate_device_usbctrl_remove uses ev_qmp

2019-09-19 Thread Anthony PERARD
Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl_usb.c | 97 + 1 file changed, 79 insertions(+), 18 deletions(-) diff --git a/tools/libxl/libxl_usb.c b/tools/libxl/libxl_usb.c index 506dbdcf5ee4..373b37d7159a 100644 ---

[Xen-devel] [PATCH v2 25/35] libxl_pci: Coding style of do_pci_add

2019-09-19 Thread Anthony PERARD
do_pci_add is going to be asynchronous, so we start by having a single path out of the function. All `return`s instead set rc and goto out. While here, some use of `rc' was used to store the return value of libxc calls, change them to store into `r'. Also, add the value of `r' in the error

[Xen-devel] [PATCH v2 30/35] libxl_pci: Use ev_qmp for pci_remove

2019-09-19 Thread Anthony PERARD
This patch also replaces the use of libxl__wait_for_device_model_deprecated() by its equivalent without the need for a thread. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl_internal.h | 2 - tools/libxl/libxl_pci.c | 222 +--

[Xen-devel] [PATCH v2 11/35] libxl_domain: Convert libxl_domain_resume to use libxl__domain_resume

2019-09-19 Thread Anthony PERARD
Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl_domain.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_domain.c b/tools/libxl/libxl_domain.c index 80797c5ed21c..d78ffa6b6019 100644 ---

[Xen-devel] [PATCH v2 32/35] libxl: Use ev_qmp in libxl_set_vcpuonline

2019-09-19 Thread Anthony PERARD
Removed libxl__qmp_cpu_add since it's not used anymore. `cpumap' arg of libxl__set_vcpuonline_xenstore is constified. The QMP command "query-cpus" is going to be called from different places, so the algorithm that parse the answer is in a separate function, qmp_parse_query_cpus. Signed-off-by:

[Xen-devel] [PATCH v2 14/35] libxl_domain: Convert libxl_domain_unpause to use libxl__domain_unpause

2019-09-19 Thread Anthony PERARD
Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl_domain.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/tools/libxl/libxl_domain.c b/tools/libxl/libxl_domain.c index 52a8bd7895cb..f3c39fa86fc9 100644 ---

[Xen-devel] [PATCH v2 27/35] libxl_pci: Use libxl__ao_device with libxl__device_pci_add

2019-09-19 Thread Anthony PERARD
Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl_internal.h | 7 +- tools/libxl/libxl_pci.c | 170 ++- 2 files changed, 150 insertions(+), 27 deletions(-) diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h

[Xen-devel] [PATCH v2 34/35] libxl: libxl_qemu_monitor_command now uses ev_qmp

2019-09-19 Thread Anthony PERARD
Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl_qmp.c | 52 +++-- 1 file changed, 50 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/libxl_qmp.c index 9639d491d991..9aabad74fabd 100644 ---

[Xen-devel] [PATCH v2 18/35] libxl: Add device_{config, type} to libxl__ao_device

2019-09-19 Thread Anthony PERARD
These two fields help to give more information about the device been hotplug/hotunplug to callbacks. There is already `dev' of type `libxl__device', but it is mostly useful when the backend/frontend is xenstore. Some device (like `usbdev') don't have devid, so `dev' can't be used. Signed-off-by:

[Xen-devel] [PATCH v2 19/35] libxl_usb: Make libxl__device_usbctrl_add uses ev_qmp

2019-09-19 Thread Anthony PERARD
Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl_usb.c | 93 ++--- 1 file changed, 77 insertions(+), 16 deletions(-) diff --git a/tools/libxl/libxl_usb.c b/tools/libxl/libxl_usb.c index de8122dc57e9..506dbdcf5ee4 100644 ---

[Xen-devel] [PATCH v2 26/35] libxl_pci: Only check if qemu-dm is running in qemu-trad case

2019-09-19 Thread Anthony PERARD
QEMU upstream (or qemu-xen) may not have set "running" state in xenstore. "running" with QEMU doesn't mean that the binary is running, it means that the emulation have started. When adding a pci-passthrough device to QEMU, we do so via QMP, we have a direct answer to whether QEMU is running or

[Xen-devel] [PATCH v2 33/35] libxl: libxl_retrieve_domain_configuration now uses ev_qmp

2019-09-19 Thread Anthony PERARD
This was the last user of libxl__qmp_query_cpus which can now be removed. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- Notes: v3: - following rename of ev_lock to ev_devlock, renamed field rdcs.ev_lock to rdcs.devlock tools/libxl/libxl_domain.c | 163

[Xen-devel] [PATCH v2 01/35] libxl: Make libxl_domain_unpause async

2019-09-19 Thread Anthony PERARD
libxl_domain_unpause needs to make QMP calls, which are asynchronous, change the API to reflect that. Do the same with libxl_domain_pause async, even if it will keep completing synchronously. Also fix some coding style issue in those functions. Signed-off-by: Anthony PERARD Acked-by: Ian

[Xen-devel] [PATCH v2 07/35] libxl: Move "qmp_initializations" to libxl_dm

2019-09-19 Thread Anthony PERARD
libxl__qmp_initializations is part of the device domain startup, it queries information about the newly spawned QEMU and do some post-startup configuration. So the function call doesn't belong to the general domain creation, but only to the device model part of the process, thus the call belong to

[Xen-devel] [PATCH v2 03/35] libxl: Make libxl_set_vcpuonline async

2019-09-19 Thread Anthony PERARD
.. because it makes QMP calls which are going to be async. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl.h| 15 ++- tools/libxl/libxl_domain.c | 12 tools/xl/xl_cpupool.c | 2 +- tools/xl/xl_vcpu.c | 2 +- 4 files

[Xen-devel] [PATCH v2 04/35] libxl: Make libxl_retrieve_domain_configuration async

2019-09-19 Thread Anthony PERARD
.. because it makes QMP calls which are going to be async. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl.h| 13 - tools/libxl/libxl_domain.c | 14 +++--- tools/xl/xl_info.c | 3 ++- tools/xl/xl_saverestore.c | 3 ++-

[Xen-devel] [PATCH v2 05/35] libxl: Make libxl_qemu_monitor_command async

2019-09-19 Thread Anthony PERARD
.. because it makes QMP calls which are going to be async. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl.h | 14 +- tools/libxl/libxl_qmp.c | 9 + tools/xl/xl_misc.c | 2 +- 3 files changed, 19 insertions(+), 6 deletions(-) diff --git

[Xen-devel] [PATCH v2 08/35] libxl: Replace libxl__qmp_initializations by ev_qmp calls

2019-09-19 Thread Anthony PERARD
Setup a timeout of 10s for all the commands. It used to be about 5s per commands. The order of command is changed, we call 'query-vnc' before 'change-vnc-password', but that should not matter. That makes it easier to call 'change-vnc-password' conditionally. Also 'change' command is replaced by

[Xen-devel] [PATCH v2 02/35] libxl: Make libxl_send_trigger async

2019-09-19 Thread Anthony PERARD
.. because it makes QMP calls which are going to be async. Signed-off-by: Anthony PERARD Acked-by: Ian Jackson --- tools/libxl/libxl.h| 13 - tools/libxl/libxl_domain.c | 12 tools/xl/xl_misc.c | 4 ++-- tools/xl/xl_vmcontrol.c| 4 ++-- 4 files

[Xen-devel] [PATCH v2 09/35] libxl: Deprecate libxl__domain_{unpause, resume}

2019-09-19 Thread Anthony PERARD
These two functions are used from many places in libxl and need to change to be able to accomodate libxl__ev_qmp calls and thus needs to be asynchronous. (There is also libxl__domain_resume_device_model in the mix.) A later patch will introduce a new libxl__domain_resume and

[Xen-devel] [PATCH v2 00/35] libxl refactoring to use ev_qmp (with API changes)

2019-09-19 Thread Anthony PERARD
Patches with missing ackes: libxl: Use ev_qmp for switch_qemu_xen_logdirty libxl: Use ev_qmp in libxl_set_vcpuonline libxl_pci: Extract common part of *qemu_trad_watch_state_cb The series depends on "Some cleanup of libxl" series. Patch series available in this git branch (which is on

[Xen-devel] [PATCH v2 06/35] libxl: Use ev_qmp for switch_qemu_xen_logdirty

2019-09-19 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- tools/libxl/libxl_dom_save.c | 41 tools/libxl/libxl_internal.h | 3 +-- tools/libxl/libxl_qmp.c | 10 - 3 files changed, 38 insertions(+), 16 deletions(-) diff --git a/tools/libxl/libxl_dom_save.c

[Xen-devel] [xen-unstable-smoke test] 141474: regressions - FAIL

2019-09-19 Thread osstest service owner
flight 141474 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/141474/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 7 xen-boot fail REGR. vs. 141253 Tests which

Re: [Xen-devel] [PATCH 00/15] Some cleanup of libxl

2019-09-19 Thread Anthony PERARD
On Fri, Jun 14, 2019 at 12:24:29PM +0100, Anthony PERARD wrote: > Hi, > > This series contains cleanup patches, ahead of a series that's going to make > more changes to libxl. v2 with patch 11 acked and the whole branch rebased pushed to:

Re: [Xen-devel] [PATCH v3 09/12] livepatch: Add support for modules .modinfo section metadata

2019-09-19 Thread Ross Lagerwall
On 9/16/19 11:59 AM, Pawel Wieczorkiewicz wrote: Having detailed hotpatch metadata helps to properly identify module's origin and version. It also allows to keep track of the history of hotpatch loads in the system (at least within dmesg buffer size limits). The hotpatch metadata are embedded

Re: [Xen-devel] [PATCH 33/35] libxl: Extract qmp_parse_query_cpus

2019-09-19 Thread Ian Jackson
Anthony PERARD writes ("Re: [PATCH 33/35] libxl: Extract qmp_parse_query_cpus"): > On Tue, Sep 17, 2019 at 06:42:10PM +0100, Ian Jackson wrote: > > Anthony PERARD writes ("[PATCH 33/35] libxl: Extract qmp_parse_query_cpus"): > > > The QMP command "query-cpus" is called from different places,

Re: [Xen-devel] [PATCH 17/35] libxl: Add libxl__ev_qmp to libxl__ao_device

2019-09-19 Thread Ian Jackson
Anthony PERARD writes ("Re: [PATCH 17/35] libxl: Add libxl__ev_qmp to libxl__ao_device"): > On Tue, Sep 17, 2019 at 06:07:31PM +0100, Ian Jackson wrote: > > It might be nice to add a comment about the field(s) of > > libxl__ao_device which callers of libxl__prepare_ao_device are > > expected to

Re: [Xen-devel] [PATCH v3 08/12] livepatch: Add support for inline asm hotpatching expectations

2019-09-19 Thread Ross Lagerwall
On 9/16/19 11:59 AM, Pawel Wieczorkiewicz wrote: This is the initial implementation of the expectations enhancement to improve inline asm hotpatching. Expectations are designed as optional feature, since the main use of them is planned for inline asm hotpatching. The flag enabled allows to

[Xen-devel] Ping: [PATCH v3 0/2] x86/traps: improve show_trace()'s top-of-stack handling

2019-09-19 Thread Jan Beulich
Andrew, On 15.07.2019 16:58, Jan Beulich wrote: > 1: guard top-of-stack reads > 2: widen condition for logging top-of-stack > > The issue patch 2 fixes (a curious lack of an intermediate call stack > entry) was observed in practice; patch 1 is a result of me just looking > at the code. I

Re: [Xen-devel] [PATCH v3 13/47] xen/sched: add is_running indicator to struct sched_unit

2019-09-19 Thread Jan Beulich
On 14.09.2019 10:52, Juergen Gross wrote: > @@ -1673,8 +1676,10 @@ static void schedule(void) > * switch, else lost_records resume will not work properly. > */ > > -ASSERT(!next->is_running); > +ASSERT(!next->sched_unit->is_running); > next->is_running = 1; > +

Re: [Xen-devel] [PATCH v3 10/47] xen/sched: add scheduler helpers hiding vcpu

2019-09-19 Thread Jan Beulich
On 14.09.2019 10:52, Juergen Gross wrote: > Add the following helpers using a sched_unit as input instead of a > vcpu: > > - is_idle_unit() similar to is_idle_vcpu() > - is_unit_online() similar to is_vcpu_online() (returns true when any > of its vcpus is online) > - unit_runnable() like

Re: [Xen-devel] [PATCH 17/35] libxl: Add libxl__ev_qmp to libxl__ao_device

2019-09-19 Thread Anthony PERARD
On Tue, Sep 17, 2019 at 06:07:31PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("[PATCH 17/35] libxl: Add libxl__ev_qmp to > libxl__ao_device"): > > `aodev->qmp' is initialised in libxl__prepare_ao_device(), but since > > there isn't a single exit path for a `libxl__ao_device', users of

Re: [Xen-devel] [PATCH v3 09/47] xen/sched: move some per-vcpu items to struct sched_unit

2019-09-19 Thread Jan Beulich
On 14.09.2019 10:52, Juergen Gross wrote: > Affinities are scheduler specific attributes, they should be per > scheduling unit. So move all affinity related fields in struct vcpu > to struct sched_unit. While at it switch affinity related functions in > sched-if.h to use a pointer to sched_unit

[Xen-devel] [linux-4.9 test] 141444: regressions - FAIL

2019-09-19 Thread osstest service owner
flight 141444 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/141444/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvshim 20 guest-start/debian.repeat fail in 141392 REGR. vs. 141254 Tests

Re: [Xen-devel] [PATCH v3 07/47] xen/sched: move per cpu scheduler private data into struct sched_resource

2019-09-19 Thread Jan Beulich
On 14.09.2019 10:52, Juergen Gross wrote: > This prepares support of larger scheduling granularities, e.g. core > scheduling. > > While at it move sched_has_urgent_vcpu() from include/asm-x86/cpuidle.h > into sched.h removing the need for including sched-if.h in cpuidle.h. > For that purpose

Re: [Xen-devel] [PATCH v3 07/12] livepatch: Add per-function applied/reverted state tracking marker

2019-09-19 Thread Ross Lagerwall
On 9/16/19 11:59 AM, Pawel Wieczorkiewicz wrote: Livepatch only tracks an entire payload applied/reverted state. But, with an option to supply the apply_payload() and/or revert_payload() functions as optional hooks, it becomes possible to intermix the execution of the original

Re: [Xen-devel] [PATCH 33/35] libxl: Extract qmp_parse_query_cpus

2019-09-19 Thread Anthony PERARD
On Tue, Sep 17, 2019 at 06:42:10PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("[PATCH 33/35] libxl: Extract qmp_parse_query_cpus"): > > The QMP command "query-cpus" is called from different places, extract > > the algorithm that parse the answer into a separate function. > > I hope you

Re: [Xen-devel] [PATCH v3 06/12] livepatch: Do not enforce ELF_LIVEPATCH_FUNC section presence

2019-09-19 Thread Ross Lagerwall
On 9/16/19 11:59 AM, Pawel Wieczorkiewicz wrote: With default implementation the ELF_LIVEPATCH_FUNC section containing all functions to be replaced or added must be part of the hotpatch payload, otherwise the payload is rejected (with -EINVAL). However, with the extended hooks implementation, a

Re: [Xen-devel] [PATCH v3 05/12] livepatch: Add support for apply|revert action replacement hooks

2019-09-19 Thread Ross Lagerwall
On 9/16/19 11:59 AM, Pawel Wieczorkiewicz wrote: By default, in the quiescing zone, a hotpatch payload is applied with s/hotpatch/livepatch/ (for all the patches) apply_payload() and reverted with revert_payload() functions. Both of the functions receive the payload struct pointer as a

Re: [Xen-devel] [PATCH v11] x86/emulate: Send vm_event from emulate

2019-09-19 Thread Paul Durrant
> -Original Message- > diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c > index fdb1e17f59..4cc077bb3f 100644 > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -3236,6 +3236,19 @@ static enum hvm_translation_result __hvm_copy( > return

Re: [Xen-devel] [PATCH] xen/arm32: setup: Give a xenheap page to the boot allocator

2019-09-19 Thread Jan Beulich
On 17.09.2019 15:21, Julien Grall wrote: > After commit 6e3e771203 "xen/arm: setup: Relocate the Device-Tree later on > in the boot", the boot allocator will not receive any xenheap page (i.e. > mapped page) on Arm32. > > However, the boot allocator implicitely rely on having the first page >

Re: [Xen-devel] [PATCH v11] x86/emulate: Send vm_event from emulate

2019-09-19 Thread Jan Beulich
On 19.09.2019 15:03, Alexandru Stefan ISAILA wrote: > @@ -601,6 +602,7 @@ static void *hvmemul_map_linear_addr( > > case HVMTRANS_gfn_paged_out: > case HVMTRANS_gfn_shared: > +case HVMTRANS_bad_gfn_access: > err = ERR_PTR(~X86EMUL_RETRY); >

[Xen-devel] [xen-unstable-smoke test] 141470: regressions - FAIL

2019-09-19 Thread osstest service owner
flight 141470 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/141470/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 7 xen-boot fail REGR. vs. 141253 Tests which

Re: [Xen-devel] [PATCH V4 7/8] iommu/arm: Introduce iommu_add_dt_device API

2019-09-19 Thread Oleksandr
On 19.09.19 15:29, Julien Grall wrote: Hi, Hi, Julien + +int __init iommu_add_dt_device(struct dt_device_node *np) Sorry to only realise it now. Would it make sense to have this function implemented in xen/passthrough/device_tree.c? Not entirely sure. device_tree.c is a common

[Xen-devel] [PATCH v6 8/8] AMD/IOMMU: pre-fill all DTEs right after table allocation

2019-09-19 Thread Jan Beulich
Make sure we don't leave any DTEs unexpected requests through which would be passed through untranslated. Set V and IV right away (with all other fields left as zero), relying on the V and/or IV bits getting cleared only by amd_iommu_set_root_page_table() and amd_iommu_set_intremap_table() under

[Xen-devel] [PATCH v6 7/8] AMD/IOMMU: allocate one device table per PCI segment

2019-09-19 Thread Jan Beulich
Having a single device table for all segments can't possibly be right. (Even worse, the symbol wasn't static despite being used in just one source file.) Attach the device tables to their respective IVRS mapping ones. Signed-off-by: Jan Beulich --- v6: New. ---

[Xen-devel] [PATCH v6 6/8] AMD/IOMMU: tidy struct ivrs_mappings

2019-09-19 Thread Jan Beulich
Move the device flags field up into an unused hole, thus shrinking overall structure size by 8 bytes. Use bool and uint_t as appropriate. Drop pointless (redundant) initializations. Signed-off-by: Jan Beulich --- v6: New. --- xen/drivers/passthrough/amd/iommu_acpi.c |6 +++---

[Xen-devel] [PATCH v6 5/8] AMD/IOMMU: restrict interrupt remapping table sizes

2019-09-19 Thread Jan Beulich
There's no point setting up tables with more space than a PCI device can use. For both MSI and MSI-X we can determine how many interrupts could be set up at most. Tables allocated during ACPI table parsing, however, will (for now at least) continue to be set up to have maximum size. Note that

[Xen-devel] [PATCH v6 4/8] AMD/IOMMU: replace INTREMAP_ENTRIES

2019-09-19 Thread Jan Beulich
Prepare for the number of entries to not be the maximum possible, by separating checks against maximum size from ones against actual size. For caller side simplicity have alloc_intremap_entry() return the maximum possible value upon allocation failure, rather than the first just out-of-bounds one.

[Xen-devel] [PATCH v6 3/8] x86/PCI: read maximum MSI vector count early

2019-09-19 Thread Jan Beulich
Rather than doing this every time we set up interrupts for a device anew (and then in several places) fill this invariant field right after allocating struct pci_dev. Signed-off-by: Jan Beulich --- v6: New. --- xen/arch/x86/msi.c| 13 + xen/drivers/passthrough/pci.c |

[Xen-devel] [PATCH v6 2/8] AMD/IOMMU: make phantom functions share interrupt remapping tables

2019-09-19 Thread Jan Beulich
Rather than duplicating entries in amd_iommu_msi_msg_update_ire(), share the tables. This mainly requires some care while freeing them, to avoid freeing memory blocks twice. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- v5: New. --- xen/drivers/passthrough/amd/iommu_init.c |

[Xen-devel] [PATCH v6 1/8] AMD/IOMMU: don't blindly allocate interrupt remapping tables

2019-09-19 Thread Jan Beulich
ACPI tables are free to list far more device coordinates than there are actual devices. By delaying the table allocations for most cases, and doing them only when an actual device is known to be present at a given position, overall memory used for the tables goes down from over 500k pages to just

Re: [Xen-devel] [PATCH 06/35] libxl: Use ev_qmp for switch_qemu_xen_logdirty

2019-09-19 Thread Anthony PERARD
On Thu, Sep 19, 2019 at 02:03:10PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("Re: [PATCH 06/35] libxl: Use ev_qmp for > switch_qemu_xen_logdirty"): > > On Tue, Sep 17, 2019 at 05:52:24PM +0100, Ian Jackson wrote: > > I guess we could try to optimise the simpler case when there is only

[Xen-devel] [PATCH v6 0/8] AMD IOMMU: further improvements

2019-09-19 Thread Jan Beulich
The main goal continues to be to reduce the huge memory overhead that we've noticed. On the way there a number of other things were once again noticed. All patches have now been tested on a Fam15 and a Fam17 system. 01: don't blindly allocate interrupt remapping tables 02: make phantom functions

[Xen-devel] [PATCH v11] x86/emulate: Send vm_event from emulate

2019-09-19 Thread Alexandru Stefan ISAILA
A/D bit writes (on page walks) can be considered benign by an introspection agent, so receiving vm_events for them is a pessimization. We try here to optimize by filtering these events out. Currently, we are fully emulating the instruction at RIP when the hardware sees an EPT fault with npfec.kind

Re: [Xen-devel] [PATCH 06/35] libxl: Use ev_qmp for switch_qemu_xen_logdirty

2019-09-19 Thread Ian Jackson
Anthony PERARD writes ("Re: [PATCH 06/35] libxl: Use ev_qmp for switch_qemu_xen_logdirty"): > On Tue, Sep 17, 2019 at 05:52:24PM +0100, Ian Jackson wrote: > > I hate to suggest this at this stage, but: maybe the timeout could be > > incorporated into libxl__ev_qmp ? > > > > I think every

Re: [Xen-devel] [PATCH for-4.13] configure: fix print syntax for python 3

2019-09-19 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH for-4.13] configure: fix print syntax for python 3"): > On Thu, 19 Sep 2019 at 12:28, Ian Jackson wrote: > > My previous reply bounced due to header mangling in your first mail. > > Let me try again: > > > > This is good in principle but: > > > > Can you provide as a

Re: [Xen-devel] [PATCH 06/35] libxl: Use ev_qmp for switch_qemu_xen_logdirty

2019-09-19 Thread Anthony PERARD
On Tue, Sep 17, 2019 at 05:52:24PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("[PATCH 06/35] libxl: Use ev_qmp for > switch_qemu_xen_logdirty"): > > Signed-off-by: Anthony PERARD > ... > > +rc = libxl__ev_time_register_rel(ao, >timeout, > > +

Re: [Xen-devel] [PATCH V4 7/8] iommu/arm: Introduce iommu_add_dt_device API

2019-09-19 Thread Julien Grall
Hi, On 19/09/2019 13:25, Oleksandr wrote: On 19.09.19 14:35, Julien Grall wrote: Hi Oleksandr, On 13/09/2019 16:35, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko The main puprose of this patch is to add a way to register DT device (which is behind the IOMMU) using the generic

Re: [Xen-devel] [PATCH V4 7/8] iommu/arm: Introduce iommu_add_dt_device API

2019-09-19 Thread Oleksandr
On 19.09.19 14:35, Julien Grall wrote: Hi Oleksandr, Hi, Julien. On 13/09/2019 16:35, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko The main puprose of this patch is to add a way to register DT device (which is behind the IOMMU) using the generic IOMMU DT bindings [1] before

[Xen-devel] [linux-4.14 test] 141442: regressions - FAIL

2019-09-19 Thread osstest service owner
flight 141442 linux-4.14 real [real] http://logs.test-lab.xenproject.org/osstest/logs/141442/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvshim 20 guest-start/debian.repeat fail in 141400 REGR. vs. 139910 Tests

  1   2   >