Re: [Xen-devel] [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-16 Thread Vladimir Sementsov-Ogievskiy
On 14.03.2020 00:54, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 13.03.2020 18:42, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 12.03.2020 19:36, Markus Armbruster wrote: I may have a second look tomorrow with fresher eyes, but let's get this out now a

[Xen-devel] [linux-linus test] 148603: regressions - trouble: fail/pass/starved

2020-03-16 Thread osstest service owner
flight 148603 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/148603/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 17 debian-hvm-install/l1/l2 fail REGR. vs. 133580 Tests which

Re: [Xen-devel] [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-16 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > On 14.03.2020 00:54, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 13.03.2020 18:42, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: > 12.03.2020 19:36, Markus Armbruster wrote: >> I may have a seco

[Xen-devel] Commit 0d99c909d7e1 introduced bug

2020-03-16 Thread Jürgen Groß
Commit 0d99c909d7e1 ("libxl: wait for console path before firing console_available") introduced a bug: when trying to start a guest from a config file when it is already running, I get: xl create -c minios.pv Parsing config from minios.pv libxl: error: libxl_domain.c:81:libxl__domain_rename: Doma

Re: [Xen-devel] [PATCH 2/4] x86/time: reduce rounding errors in calculations

2020-03-16 Thread Jan Beulich
On 13.03.2020 16:14, Andrew Cooper wrote: > On 13/03/2020 09:25, Jan Beulich wrote: >> Plain (unsigned) integer division simply truncates the results. The >> overall errors are smaller though if we use proper rounding. (Extend >> this to the purely cosmetic aspect of time.c's freq_string(), which >

Re: [Xen-devel] [PATCH 3/4] x86/APIC: reduce rounding errors in calculations

2020-03-16 Thread Jan Beulich
On 13.03.2020 16:50, Andrew Cooper wrote: > On 13/03/2020 09:26, Jan Beulich wrote: >> --- a/xen/arch/x86/apic.c >> +++ b/xen/arch/x86/apic.c >> @@ -1249,17 +1249,16 @@ static int __init calibrate_APIC_clock(v >> tt2 = apic_read(APIC_TMCCT); >> t2 = rdtsc_ordered(); >> >> -result =

Re: [Xen-devel] [PATCH 4/4] x86/APIC: restrict certain messages to BSP

2020-03-16 Thread Jan Beulich
On 13.03.2020 17:18, Andrew Cooper wrote: > On 13/03/2020 09:26, Jan Beulich wrote: >> All CPUs get an equal setting of EOI broadcast suppression; no need to >> log one message per CPU, even if it's only in verbose APIC mode. >> >> Only the BSP is eligible to possibly get ExtINT enabled; no need to

Re: [Xen-devel] Commit 0d99c909d7e1 introduced bug

2020-03-16 Thread Andrew Cooper
On 16/03/2020 08:47, Jürgen Groß wrote: > Commit 0d99c909d7e1 ("libxl: wait for console path before firing > console_available") introduced a bug: when trying to start a guest > from a config file when it is already running, I get: > > xl create -c minios.pv > Parsing config from minios.pv > libxl:

Re: [Xen-devel] Commit 0d99c909d7e1 introduced bug

2020-03-16 Thread Jürgen Groß
On 16.03.20 10:17, Andrew Cooper wrote: On 16/03/2020 08:47, Jürgen Groß wrote: Commit 0d99c909d7e1 ("libxl: wait for console path before firing console_available") introduced a bug: when trying to start a guest from a config file when it is already running, I get: xl create -c minios.pv Parsin

Re: [Xen-devel] [PATCH v2 2/2] xen/spinlocks: fix placement of preempt_[dis|en]able()

2020-03-16 Thread Jan Beulich
On 13.03.2020 15:37, Juergen Gross wrote: > In case Xen ever gains preemption support the spinlock coding's > placement of preempt_disable() and preempt_enable() should be outside > of the locked section. > > Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich ___

Re: [Xen-devel] [PATCH v2 1/2] xen/rwlocks: call preempt_disable() when taking a rwlock

2020-03-16 Thread Jan Beulich
On 13.03.2020 15:37, Juergen Gross wrote: > Similar to spinlocks preemption should be disabled while holding a > rwlock. > > Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists

Re: [Xen-devel] [PATCH v3 1/9] x86/HVM: reduce domain.h include dependencies

2020-03-16 Thread Jan Beulich
On 13.03.2020 12:14, Jan Beulich wrote: > Drop #include-s not needed by the header itself. Put the ones needed > into whichever other files actually need them. > > Signed-off-by: Jan Beulich > Reviewed-by: Paul Durrant > --- > v3: Also make things build with all{yes,no}config. > v2: Also make th

[Xen-devel] [linux-5.4 test] 148610: regressions - trouble: fail/pass/starved

2020-03-16 Thread osstest service owner
flight 148610 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/148610/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 17 debian-hvm-install/l1/l2 fail REGR. vs. 146121 Tests which a

[Xen-devel] [PATCH] x86/HVM: fix AMD ECS handling for Fam 10

2020-03-16 Thread Jan Beulich
The involved comparison was, very likely inadvertently, converted from >= to > when making changes unrelated to the actual family range. Fixes: 9841eb71ea87 ("x86/cpuid: Drop a guests cached x86 family and model information") Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/ioreq.c +++ b/xen/a

Re: [Xen-devel] [PATCH v11 0/3] VM forking

2020-03-16 Thread Tamas K Lengyel
On Fri, Feb 28, 2020 at 11:41 AM Tamas K Lengyel wrote: > > The following series implements VM forking for Intel HVM guests to allow for > the fast creation of identical VMs without the assosciated high startup costs > of booting or restoring the VM from a savefile. > > JIRA issue: https://xenproj

Re: [Xen-devel] [PATCH 2/4] x86/time: reduce rounding errors in calculations

2020-03-16 Thread Andrew Cooper
On 16/03/2020 08:58, Jan Beulich wrote: > On 13.03.2020 16:14, Andrew Cooper wrote: >> On 13/03/2020 09:25, Jan Beulich wrote: >>> Plain (unsigned) integer division simply truncates the results. The >>> overall errors are smaller though if we use proper rounding. (Extend >>> this to the purely cosm

Re: [Xen-devel] [PATCH 3/4] x86/APIC: reduce rounding errors in calculations

2020-03-16 Thread Andrew Cooper
On 16/03/2020 09:07, Jan Beulich wrote: > On 13.03.2020 16:50, Andrew Cooper wrote: >> On 13/03/2020 09:26, Jan Beulich wrote: >>> --- a/xen/arch/x86/apic.c >>> +++ b/xen/arch/x86/apic.c >>> @@ -1249,17 +1249,16 @@ static int __init calibrate_APIC_clock(v >>> tt2 = apic_read(APIC_TMCCT); >>>

Re: [Xen-devel] [PATCH] x86/HVM: fix AMD ECS handling for Fam 10

2020-03-16 Thread Andrew Cooper
On 16/03/2020 11:00, Jan Beulich wrote: > The involved comparison was, very likely inadvertently, converted from >> = to > when making changes unrelated to the actual family range. > > Fixes: 9841eb71ea87 ("x86/cpuid: Drop a guests cached x86 family and model > information") > Signed-off-by: Jan

[Xen-devel] [xen-unstable-smoke test] 148624: tolerable all pass - PUSHED

2020-03-16 Thread osstest service owner
flight 148624 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/148624/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [PATCH 1/2] x86/xen: Make the boot CPU idle task reliable

2020-03-16 Thread Boris Ostrovsky
On 3/12/20 10:20 AM, Miroslav Benes wrote: > --- a/arch/x86/xen/xen-head.S > +++ b/arch/x86/xen/xen-head.S > @@ -35,7 +35,7 @@ SYM_CODE_START(startup_xen) > rep __ASM_SIZE(stos) > > mov %_ASM_SI, xen_start_info > - mov $init_thread_union+THREAD_SIZE, %_ASM_SP > + mov $init_t

Re: [Xen-devel] [PATCH v7 00/11] error: auto propagated local_err part I

2020-03-16 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 03.03.2020 11:01, Markus Armbruster wrote: >> Hi Vladimir, >> >> I've come to rather like your ERRP_AUTO_PROPAGATE() idea. What I >> wouldn't like is a protracted conversion. >> >> Once we're happy with PATCH 1-3, it's a matter of running Coccinelle and >>

Re: [Xen-devel] [PATCH v6 1/4] xen/rcu: don't use stop_machine_run() for rcu_barrier()

2020-03-16 Thread Igor Druzhinin
On 13/03/2020 13:06, Juergen Gross wrote: > Today rcu_barrier() is calling stop_machine_run() to synchronize all > physical cpus in order to ensure all pending rcu calls have finished > when returning. > > As stop_machine_run() is using tasklets this requires scheduling of > idle vcpus on all cpus

Re: [Xen-devel] [RFC PATCH 2/2] x86/xen: Make the secondary CPU idle tasks reliable

2020-03-16 Thread Miroslav Benes
On Fri, 13 Mar 2020, Miroslav Benes wrote: > On Fri, 13 Mar 2020, Jürgen Groß wrote: > > > On 12.03.20 15:20, Miroslav Benes wrote: > > > The unwinder reports the secondary CPU idle tasks' stack on XEN PV as > > > unreliable, which affects at least live patching. > > > cpu_initialize_context() se

Re: [Xen-devel] [PATCH v6 1/4] xen/rcu: don't use stop_machine_run() for rcu_barrier()

2020-03-16 Thread Jürgen Groß
On 16.03.20 16:24, Igor Druzhinin wrote: On 13/03/2020 13:06, Juergen Gross wrote: Today rcu_barrier() is calling stop_machine_run() to synchronize all physical cpus in order to ensure all pending rcu calls have finished when returning. As stop_machine_run() is using tasklets this requires sche

[Xen-devel] [PATCH v3 18/19] hw/arm: Do not build to 'virt' machine on Xen

2020-03-16 Thread Philippe Mathieu-Daudé
Xen on ARM does not use QEMU machines [*]. Disable the 'virt' machine there to avoid odd errors such: CC i386-softmmu/hw/cpu/a15mpcore.o hw/cpu/a15mpcore.c:28:10: fatal error: kvm_arm.h: No such file or directory [*] https://wiki.xenproject.org/wiki/Xen_ARM_with_Virtualization_Extensi

Re: [Xen-devel] [PATCH v6 2/5] mm: keep PGC_extra pages on a separate list

2020-03-16 Thread Jan Beulich
On 10.03.2020 18:49, p...@xen.org wrote: > --- a/xen/arch/x86/domain.c > +++ b/xen/arch/x86/domain.c > @@ -257,6 +257,13 @@ void dump_pageframe_info(struct domain *d) > _p(mfn_x(page_to_mfn(page))), > page->count_info, page->u.inuse.type_info); > } > + > +pa

Re: [Xen-devel] [PATCH v3 18/19] hw/arm: Do not build to 'virt' machine on Xen

2020-03-16 Thread Stefano Stabellini
On Mon, 16 Mar 2020, Philippe Mathieu-Daudé wrote: > Xen on ARM does not use QEMU machines [*]. Disable the 'virt' > machine there to avoid odd errors such: > > CC i386-softmmu/hw/cpu/a15mpcore.o > hw/cpu/a15mpcore.c:28:10: fatal error: kvm_arm.h: No such file or directory > > [*] > h

Re: [Xen-devel] [PATCH v3 18/19] hw/arm: Do not build to 'virt' machine on Xen

2020-03-16 Thread Peter Maydell
On Mon, 16 Mar 2020 at 16:08, Philippe Mathieu-Daudé wrote: > > Xen on ARM does not use QEMU machines [*]. Disable the 'virt' > machine there to avoid odd errors such: > > CC i386-softmmu/hw/cpu/a15mpcore.o > hw/cpu/a15mpcore.c:28:10: fatal error: kvm_arm.h: No such file or directory >

[Xen-devel] [PATCH] x86/tboot: check return value of dmar_table allocation

2020-03-16 Thread Hongyan Xia
From: Hongyan Xia The allocation can just return NULL. Return an error value early instead of crashing later on. Signed-off-by: Hongyan Xia --- xen/arch/x86/tboot.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/arch/x86/tboot.c b/xen/arch/x86/tboot.c index 8c232270b4..ce85a710dd 10

Re: [Xen-devel] [PATCH v6 1/4] xen/rcu: don't use stop_machine_run() for rcu_barrier()

2020-03-16 Thread Igor Druzhinin
On 16/03/2020 16:01, Jürgen Groß wrote: > On 16.03.20 16:24, Igor Druzhinin wrote: >> On 13/03/2020 13:06, Juergen Gross wrote: >>> Today rcu_barrier() is calling stop_machine_run() to synchronize all >>> physical cpus in order to ensure all pending rcu calls have finished >>> when returning. >>> >

Re: [Xen-devel] [PATCH v6 2/5] mm: keep PGC_extra pages on a separate list

2020-03-16 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 16 March 2020 16:53 > To: p...@xen.org > Cc: xen-devel@lists.xenproject.org; Andrew Cooper > ; George Dunlap > ; Ian Jackson ; Julien > Grall ; > Stefano Stabellini ; Wei Liu ; Roger > Pau Monné > > Subject: Re: [PATCH v6 2/5] mm: keep P

[Xen-devel] [xen-unstable test] 148611: tolerable trouble: fail/pass/starved

2020-03-16 Thread osstest service owner
flight 148611 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/148611/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemut-rhel6hvm-amd 12 guest-start/redhat.repeat fail in 148591 pass in 148571 test-amd64-amd64

[Xen-devel] [qemu-mainline test] 148616: regressions - trouble: fail/pass/starved

2020-03-16 Thread osstest service owner
flight 148616 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/148616/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 10 debian-hvm-install fail REGR. vs. 14486

Re: [Xen-devel] [PATCH v3 18/19] hw/arm: Do not build to 'virt' machine on Xen

2020-03-16 Thread Philippe Mathieu-Daudé
On 3/16/20 6:11 PM, Peter Maydell wrote: On Mon, 16 Mar 2020 at 16:08, Philippe Mathieu-Daudé wrote: Xen on ARM does not use QEMU machines [*]. Disable the 'virt' machine there to avoid odd errors such: CC i386-softmmu/hw/cpu/a15mpcore.o hw/cpu/a15mpcore.c:28:10: fatal error: kvm

[Xen-devel] [xen-unstable-smoke test] 148633: tolerable all pass - PUSHED

2020-03-16 Thread osstest service owner
flight 148633 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/148633/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [RFC PATCH 2/2] x86/xen: Make the secondary CPU idle tasks reliable

2020-03-16 Thread Josh Poimboeuf
On Mon, Mar 16, 2020 at 04:51:12PM +0100, Miroslav Benes wrote: > > diff --git a/arch/x86/xen/smp_pv.c b/arch/x86/xen/smp_pv.c > > index 6b88cdcbef8f..39afd88309cb 100644 > > --- a/arch/x86/xen/smp_pv.c > > +++ b/arch/x86/xen/smp_pv.c > > @@ -92,6 +92,7 @@ asmlinkage __visible void cpu_bringup_and_

[Xen-devel] [PATCH] x86/shim: fix ballooning up the guest

2020-03-16 Thread Igor Druzhinin
args.preempted as meaningless here and doesn't show if the hypercall was preempted before. Use start_extent instead which is correct. Signed-off-by: Igor Druzhinin --- This fixes ballooning for 64-bit PV guests inside shim. 32-bit PV guests require a little bit more work due to compat layer being

[Xen-devel] [linux-linus test] 148618: regressions - trouble: fail/pass/starved

2020-03-16 Thread osstest service owner
flight 148618 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/148618/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-amd 12 guest-start/redhat.repeat fail REGR. vs. 133580 test-amd64-

[Xen-devel] [seabios test] 148629: regressions - FAIL

2020-03-16 Thread osstest service owner
flight 148629 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/148629/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 17 debian-hvm-install/l1/l2 fail REGR. vs. 148176 Tests which did

[Xen-devel] [linux-5.4 test] 148623: regressions - trouble: fail/pass/starved

2020-03-16 Thread osstest service owner
flight 148623 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/148623/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 17 debian-hvm-install/l1/l2 fail REGR. vs. 146121 Tests which a

Re: [Xen-devel] [PATCH v3] IOMMU: make DMA containment of quarantined devices optional

2020-03-16 Thread Tian, Kevin
> From: Paul Durrant > Sent: Friday, March 13, 2020 5:26 PM > > > -Original Message- > > From: Tian, Kevin > > Sent: 13 March 2020 03:23 > > To: p...@xen.org; 'Jan Beulich' > > Cc: xen-devel@lists.xenproject.org; 'Andrew Cooper' > > > Subject: RE: [Xen-devel] [PATCH v3] IOMMU: make DMA

Re: [Xen-devel] [PATCH v3] IOMMU: make DMA containment of quarantined devices optional

2020-03-16 Thread Tian, Kevin
> From: Paul Durrant > Sent: Friday, March 13, 2020 5:26 PM > > > -Original Message- > > From: Jan Beulich > > Sent: 13 March 2020 08:10 > > To: Tian, Kevin > > Cc: xen-devel@lists.xenproject.org; Andrew Cooper > ; Paul Durrant > > > > Subject: Re: [PATCH v3] IOMMU: make DMA containmen

Re: [Xen-devel] [linux-linus bisection] complete test-amd64-amd64-qemuu-nested-intel

2020-03-16 Thread Tian, Kevin
> From: Andrew Cooper > Sent: Saturday, March 14, 2020 12:03 AM > > On 12/03/2020 23:56, osstest service owner wrote: > > branch xen-unstable > > xenbranch xen-unstable > > job test-amd64-amd64-qemuu-nested-intel > > testid debian-hvm-install/l1/l2 > > > > Tree: linux git://git.kernel.org/pub/scm