[Xen-devel] [linux-5.4 test] 148706: regressions - trouble: fail/pass/starved

2020-03-18 Thread osstest service owner
flight 148706 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/148706/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 17 debian-hvm-install/l1/l2 fail REGR. vs. 146121 test-amd64-am

Re: [Xen-devel] PV dom0 crash: kernel NULL pointer dereference in evtchn_from_irq

2020-03-18 Thread Jürgen Groß
On 19.03.20 03:26, Marek Marczykowski-Górecki wrote: Hi, From time to time, during intensive tests I get the dom0 crash like below. This is PV dom0, running on Xen nested inside KVM. I don't really know when it started happening, I've got it on at least those versions: - Xen 4.8.5 + Linux dom

[Xen-devel] [linux-linus test] 148702: regressions - trouble: fail/pass/starved

2020-03-18 Thread osstest service owner
flight 148702 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/148702/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-examine 4 memdisk-try-append fail REGR. vs. 133580 test-amd64-amd64-qe

[Xen-devel] [PATCH] xen-pciback: fix INTERRUPT_TYPE_* defines

2020-03-18 Thread Marek Marczykowski-Górecki
INTERRUPT_TYPE_NONE should be 0, as it is assumed in xen_pcibk_get_interrupt_type(). Fix the definition, and also shift other values to not leave holes. But also use INTERRUPT_TYPE_NONE in xen_pcibk_get_interrupt_type() to avoid similar confusions in the future. Fixes: 476878e4b2be ("xen-pciback:

[Xen-devel] PV dom0 crash: kernel NULL pointer dereference in evtchn_from_irq

2020-03-18 Thread Marek Marczykowski-Górecki
Hi, From time to time, during intensive tests I get the dom0 crash like below. This is PV dom0, running on Xen nested inside KVM. I don't really know when it started happening, I've got it on at least those versions: - Xen 4.8.5 + Linux dom0 4.19.94 - Xen 4.13.0 + Linux dom0 5.4.25 - at least o

Re: [Xen-devel] Xen crash after S3 suspend - Xen 4.13

2020-03-18 Thread Marek Marczykowski-Górecki
On Thu, Mar 19, 2020 at 01:28:10AM +0100, Dario Faggioli wrote: > Do you remember (or can easily test) whether this was also occurring on > Xen 4.12, Looking at my tests logs it did not happened on Xen 4.12. > i.e., without core-scheduling code even being there, when > this ASSERT was: > > ASS

[Xen-devel] [qemu-mainline test] 148693: regressions - trouble: fail/pass/starved

2020-03-18 Thread osstest service owner
flight 148693 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/148693/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 10 debian-hvm-install fail REGR. vs. 14486

Re: [Xen-devel] Xen crash after S3 suspend - Xen 4.13

2020-03-18 Thread Dario Faggioli
[Adding Juergen] On Wed, 2020-03-18 at 23:10 +0100, Marek Marczykowski-Górecki wrote: > On Wed, Mar 18, 2020 at 02:50:52PM +, Andrew Cooper wrote: > > On 18/03/2020 14:16, Marek Marczykowski-Górecki wrote: > > > Hi, > > > > > > In my test setup (inside KVM with nested virt enabled), I rather

[Xen-devel] [PATCH v2 0/2] xen: credit2: fix vcpu starvation due to too few credits

2020-03-18 Thread Dario Faggioli
Hello everyone, Here's v2 of the series for fixing some starvation issues, under Credit2, if as a consequence of some (still unclear) bug/circumstance, vCPUs manage to run uninterrupted for long timeslices. v1 is this: https://lore.kernel.org/xen-devel/158402056376.753.7091379488590272336.stgit@P

[Xen-devel] [PATCH v2 1/2] xen: credit2: avoid vCPUs to ever reach lower credits than idle

2020-03-18 Thread Dario Faggioli
There have been report of stalls of guest vCPUs, when Credit2 was used. It seemed like these vCPUs were not getting scheduled for very long time, even under light load conditions (e.g., during dom0 boot). Investigations led to the discovery that --although rarely-- it can happen that a vCPU manage

[Xen-devel] [PATCH v2 2/2] xen: credit2: fix credit reset happening too few times

2020-03-18 Thread Dario Faggioli
There is a bug in commit 5e4b4199667b9 ("xen: credit2: only reset credit on reset condition"). In fact, the aim of that commit was to make sure that we do not perform too many credit reset operations (which are not super cheap, and in an hot-path). But the check used to determine whether a reset is

[Xen-devel] [xen-unstable-smoke test] 148717: tolerable all pass - PUSHED

2020-03-18 Thread osstest service owner
flight 148717 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/148717/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] Xen crash after S3 suspend - Xen 4.13

2020-03-18 Thread Marek Marczykowski-Górecki
On Wed, Mar 18, 2020 at 02:50:52PM +, Andrew Cooper wrote: > On 18/03/2020 14:16, Marek Marczykowski-Górecki wrote: > > Hi, > > > > In my test setup (inside KVM with nested virt enabled), I rather > > frequently get Xen crash on resume from S3. Full message below. > > > > This is Xen 4.13.0, wi

Re: [Xen-devel] [PATCH] xen/x86: Move microcode into its own directory

2020-03-18 Thread Andrew Cooper
On 18/03/2020 21:05, Andrew Cooper wrote: > Split the existing asm/microcode.h in half, keeping the per-cpu cpu_sig > available to external users, and moving everything else into private.h > > Take the opportunity to trim and clean up the include lists for all 3 source > files, all of which include

[Xen-devel] [PATCH 2/n] x86/microcode: Move interface from processor.h to microcode.h

2020-03-18 Thread Andrew Cooper
This reduces the complexity of processor.h, particularly the need to include public/xen.h. Substitute processor.h includes for microcode.h in some sources, and add microcode.h includes in others. Only 4 of the 7 function declarations are actually called externally. early_microcode_update_cpu() ha

[Xen-devel] [PATCH] xen/x86: Move microcode into its own directory

2020-03-18 Thread Andrew Cooper
Split the existing asm/microcode.h in half, keeping the per-cpu cpu_sig available to external users, and moving everything else into private.h Take the opportunity to trim and clean up the include lists for all 3 source files, all of which include rather more than necessary. No functional change.

Re: [Xen-devel] [PATCH] Add -MP to CFLAGS along with -MMD.

2020-03-18 Thread David Woodhouse
On Wed, 2020-03-18 at 18:19 +, Ian Jackson wrote: > David Woodhouse writes ("Re: [PATCH] Add -MP to CFLAGS along with -MMD."): > > OK... I have attempted to address my frustration in a more coherent and > > hopefully productive way (qv), rather than resorting to monosyllabic > > responses. Apol

[Xen-devel] [xen-unstable test] 148685: regressions - trouble: fail/pass/starved

2020-03-18 Thread osstest service owner
flight 148685 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/148685/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 7 xen-boot fail REGR. vs. 148611 test-amd64-amd64-d

Re: [Xen-devel] [PATCH] Add -MP to CFLAGS along with -MMD.

2020-03-18 Thread Ian Jackson
David Woodhouse writes ("Re: [PATCH] Add -MP to CFLAGS along with -MMD."): > OK... I have attempted to address my frustration in a more coherent and > hopefully productive way (qv), rather than resorting to monosyllabic > responses. Apologies for that. > > Back to the specifics of this patch... W

Re: [Xen-devel] [PATCH] Add -MP to CFLAGS along with -MMD.

2020-03-18 Thread David Woodhouse
On Tue, 2020-03-17 at 16:59 +, Ian Jackson wrote: > David Woodhouse writes ("Re: [PATCH] Add -MP to CFLAGS along with -MMD."): > > On Tue, 2020-03-17 at 15:52 +0100, Jan Beulich wrote: > > > On 17.03.2020 15:34, David Woodhouse wrote: > > > > From: David Woodhouse > > > > > > > > This causes

[Xen-devel] [seabios test] 148690: regressions - FAIL

2020-03-18 Thread osstest service owner
flight 148690 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/148690/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 148666 Tests which did not suc

Re: [Xen-devel] [BUG] panic: "IO-APIC + timer doesn't work" - several people have reproduced

2020-03-18 Thread Jason Andryuk
On Wed, Mar 18, 2020 at 10:04 AM Jason Andryuk wrote: > On Wed, Mar 18, 2020 at 6:38 AM Jan Beulich wrote: > > On 17.03.2020 16:23, Jason Andryuk wrote: > > > On 17.03.2020 15:08, Jan Beulich wrote: > > >> On 17.03.2020 15:08, Jan Beulich wrote: > > >>> On 17.03.2020 14:48, Jason Andryuk wrote: >

[Xen-devel] [PATCH v4 1/3] mm: keep PGC_extra pages on a separate list

2020-03-18 Thread Paul Durrant
This patch adds a new page_list_head into struct domain to hold PGC_extra pages. This avoids them getting confused with 'normal' domheap pages where the domain's page_list is walked. A new dump loop is also added to dump_pageframe_info() to unconditionally dump the 'extra page list'. Signed-off-b

[Xen-devel] [PATCH v4 2/3] x86 / ioreq: use a MEMF_no_refcount allocation for server pages...

2020-03-18 Thread Paul Durrant
From: Paul Durrant ... now that it is safe to assign them. This avoids relying on libxl (or whatever toolstack is in use) setting max_pages up with sufficient 'slop' to allow all necessary ioreq server pages to be allocated. Signed-off-by: Paul Durrant Reviewed-by: Jan Beulich --- Cc: Andrew

[Xen-devel] [PATCH v4 3/3] mm: add 'is_special_page' inline function...

2020-03-18 Thread Paul Durrant
From: Paul Durrant ... to cover xenheap and PGC_extra pages. PGC_extra pages are intended to hold data structures that are associated with a domain and may be mapped by that domain. They should not be treated as 'normal' guest pages (i.e. RAM or page tables). Hence, in many cases where code curr

[Xen-devel] [PATCH v4 0/3] make sure PGC_extra pages are dealt with properly

2020-03-18 Thread Paul Durrant
This series was formerly called "remove one more shared xenheap page: shared_info" but I have dropped the patches actually changing shared_info and just left the PGC_extra clean-up that was previously intertwined. Paul Durrant (3): mm: keep PGC_extra pages on a separate list x86 / ioreq: use a

Re: [Xen-devel] [PATCH 1/2] xen/mm: fold PGC_broken into PGC_state bits

2020-03-18 Thread David Woodhouse
On Wed, 2020-03-18 at 12:31 +, Julien Grall wrote: > On 18/03/2020 09:56, Jan Beulich wrote: > > On 17.03.2020 22:52, David Woodhouse wrote: > > > On Thu, 2020-02-20 at 12:10 +0100, Jan Beulich wrote: > > > > > @@ -1699,14 +1714,14 @@ unsigned int online_page(mfn_t mfn, > > > > > uint32_t *stat

[Xen-devel] [PATCH v1] libxl: Fix xl shutdown for HVM without PV drivers

2020-03-18 Thread Olaf Hering
A return value of zero means no PV drivers. Restore a hunk which was removed. Fixes commit b183e180bce93037d3ef385a8c2338bbfb7f23d9 Signed-off-by: Olaf Hering --- tools/libxl/libxl_domain.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/libxl/libxl_domain.c b/tools/libxl/libxl_dom

[Xen-devel] [PATCH] travis: add mem_sharing compile test

2020-03-18 Thread Tamas K Lengyel
Add compile test for mem_sharing to avoid future breakage going unnoticed. Signed-off-by: Tamas K Lengyel --- .travis.yml | 3 +++ scripts/travis-build | 3 +++ 2 files changed, 6 insertions(+) diff --git a/.travis.yml b/.travis.yml index 15ca9e9047..908d205d27 100644 --- a/.travis.yml

Re: [Xen-devel] [PATCH] x86/mem_sharing: move mem_sharing_domain declaration

2020-03-18 Thread Andrew Cooper
On 18/03/2020 15:31, Tamas K Lengyel wrote: > Due to recent reshuffling of header include paths mem_sharing no longer > compiles. Fix it by moving mem_sharing_domain declaration to location it > is used in. > > Signed-off-by: Tamas K Lengyel Acked-by: Andrew Cooper _

[Xen-devel] [PATCH] x86/mem_sharing: move mem_sharing_domain declaration

2020-03-18 Thread Tamas K Lengyel
Due to recent reshuffling of header include paths mem_sharing no longer compiles. Fix it by moving mem_sharing_domain declaration to location it is used in. Signed-off-by: Tamas K Lengyel --- xen/include/asm-x86/hvm/domain.h | 13 + xen/include/asm-x86/mem_sharing.h | 11 ---

Re: [Xen-devel] [PATCH v11 2/3] x86/mem_sharing: reset a fork

2020-03-18 Thread Tamas K Lengyel
On Wed, Mar 18, 2020 at 8:13 AM Jan Beulich wrote: > > On 18.03.2020 15:00, Tamas K Lengyel wrote: > > On Wed, Mar 18, 2020 at 5:36 AM Jan Beulich wrote: > >> On 28.02.2020 19:40, Tamas K Lengyel wrote: > >>> +mfn = page_to_mfn(page); > >>> +if ( mfn_valid(mfn) ) > >> > >> All pag

Re: [Xen-devel] Xen crash after S3 suspend - Xen 4.13

2020-03-18 Thread Andrew Cooper
On 18/03/2020 14:16, Marek Marczykowski-Górecki wrote: > Hi, > > In my test setup (inside KVM with nested virt enabled), I rather > frequently get Xen crash on resume from S3. Full message below. > > This is Xen 4.13.0, with some patches, including "sched: fix resuming > from S3 with smt=0". > > Co

[Xen-devel] [xen-unstable-smoke test] 148704: tolerable all pass - PUSHED

2020-03-18 Thread osstest service owner
flight 148704 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/148704/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[Xen-devel] Xen crash after S3 suspend - Xen 4.13

2020-03-18 Thread Marek Marczykowski-Górecki
Hi, In my test setup (inside KVM with nested virt enabled), I rather frequently get Xen crash on resume from S3. Full message below. This is Xen 4.13.0, with some patches, including "sched: fix resuming from S3 with smt=0". Contrary to the previous issue, this one does not happen always - I woul

Re: [Xen-devel] [PATCH v11 2/3] x86/mem_sharing: reset a fork

2020-03-18 Thread Jan Beulich
On 18.03.2020 15:00, Tamas K Lengyel wrote: > On Wed, Mar 18, 2020 at 5:36 AM Jan Beulich wrote: >> On 28.02.2020 19:40, Tamas K Lengyel wrote: >>> +mfn = page_to_mfn(page); >>> +if ( mfn_valid(mfn) ) >> >> All pages on a domain's list should have a valid MFN - what are you >> tryi

Re: [Xen-devel] [PATCH 1/2] x86/setup: simplify handling of initrdidx when no initrd present

2020-03-18 Thread Jan Beulich
On 18.03.2020 14:29, Julien Grall wrote: > > > On 18/03/2020 13:20, Jan Beulich wrote: >> On 18.03.2020 13:12, Julien Grall wrote: >>> Hi, >>> >>> On 18/03/2020 11:51, Jan Beulich wrote: On 18.03.2020 12:46, David Woodhouse wrote: > From: David Woodhouse > > Remove a ternary ope

Re: [Xen-devel] [BUG] panic: "IO-APIC + timer doesn't work" - several people have reproduced

2020-03-18 Thread Jason Andryuk
On Wed, Mar 18, 2020 at 6:38 AM Jan Beulich wrote: > > On 17.03.2020 16:23, Jason Andryuk wrote: > > On 17.03.2020 15:08, Jan Beulich wrote: > >> On 17.03.2020 15:08, Jan Beulich wrote: > >>> On 17.03.2020 14:48, Jason Andryuk wrote: > I got it to boot past "IO-APIC + timer doesn't work". I

Re: [Xen-devel] [PATCH v11 2/3] x86/mem_sharing: reset a fork

2020-03-18 Thread Tamas K Lengyel
On Wed, Mar 18, 2020 at 5:36 AM Jan Beulich wrote: > > On 28.02.2020 19:40, Tamas K Lengyel wrote: > > --- a/xen/arch/x86/mm/mem_sharing.c > > +++ b/xen/arch/x86/mm/mem_sharing.c > > @@ -1775,6 +1775,91 @@ static int fork(struct domain *cd, struct domain *d) > > return rc; > > } > > > > +/

Re: [Xen-devel] [PATCH 1/2] x86/setup: simplify handling of initrdidx when no initrd present

2020-03-18 Thread Julien Grall
On 18/03/2020 13:20, Jan Beulich wrote: On 18.03.2020 13:12, Julien Grall wrote: Hi, On 18/03/2020 11:51, Jan Beulich wrote: On 18.03.2020 12:46, David Woodhouse wrote: From: David Woodhouse Remove a ternary operator that made my brain hurt. My position towards this hasn't changed, just

Re: [Xen-devel] [PATCH 2/2] xen/mm: Introduce PG_state_uninitialised

2020-03-18 Thread Jan Beulich
On 18.03.2020 13:11, David Woodhouse wrote: > On Wed, 2020-03-18 at 11:03 +0100, Jan Beulich wrote: >> On 17.03.2020 23:15, David Woodhouse wrote: >>> On Thu, 2020-02-20 at 12:59 +0100, Jan Beulich wrote: On 07.02.2020 19:04, David Woodhouse wrote: >>> >>> ASSERT((pg[i].count_info &

Re: [Xen-devel] [PATCH 1/2] x86/setup: simplify handling of initrdidx when no initrd present

2020-03-18 Thread Jan Beulich
On 18.03.2020 13:33, David Woodhouse wrote: > On Wed, 2020-03-18 at 12:51 +0100, Jan Beulich wrote: >> On 18.03.2020 12:46, David Woodhouse wrote: >>> From: David Woodhouse >>> >>> Remove a ternary operator that made my brain hurt. >> >> My position towards this hasn't changed, just ftr. > > Your

Re: [Xen-devel] [PATCH 1/2] xen/mm: fold PGC_broken into PGC_state bits

2020-03-18 Thread Jan Beulich
On 18.03.2020 13:31, Julien Grall wrote: > On 18/03/2020 09:56, Jan Beulich wrote: >> On 17.03.2020 22:52, David Woodhouse wrote: >>> On Thu, 2020-02-20 at 12:10 +0100, Jan Beulich wrote: On 07.02.2020 16:57, David Woodhouse wrote: > +#define page_is_offlining(pg)  (page_state_is((pg),

Re: [Xen-devel] [PATCH 1/2] x86/setup: simplify handling of initrdidx when no initrd present

2020-03-18 Thread Jan Beulich
On 18.03.2020 13:12, Julien Grall wrote: > Hi, > > On 18/03/2020 11:51, Jan Beulich wrote: >> On 18.03.2020 12:46, David Woodhouse wrote: >>> From: David Woodhouse >>> >>> Remove a ternary operator that made my brain hurt. >> >> My position towards this hasn't changed, just ftr. >> >>> Replace it

[Xen-devel] [linux-5.4 test] 148678: regressions - trouble: fail/pass/starved

2020-03-18 Thread osstest service owner
flight 148678 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/148678/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 17 debian-hvm-install/l1/l2 fail REGR. vs. 146121 Tests which a

Re: [Xen-devel] [PATCH 1/2] x86/setup: simplify handling of initrdidx when no initrd present

2020-03-18 Thread David Woodhouse
On Wed, 2020-03-18 at 12:51 +0100, Jan Beulich wrote: > On 18.03.2020 12:46, David Woodhouse wrote: > > From: David Woodhouse > > > > Remove a ternary operator that made my brain hurt. > > My position towards this hasn't changed, just ftr. Your position was not clearly stated. In https://lists.

Re: [Xen-devel] [PATCH 1/2] xen/mm: fold PGC_broken into PGC_state bits

2020-03-18 Thread Julien Grall
Hi Jan, On 18/03/2020 09:56, Jan Beulich wrote: On 17.03.2020 22:52, David Woodhouse wrote: On Thu, 2020-02-20 at 12:10 +0100, Jan Beulich wrote: On 07.02.2020 16:57, David Woodhouse wrote: @@ -1145,16 +1145,19 @@ static int reserve_offlined_page(struct page_info *head)   for ( cur_head =

Re: [Xen-devel] [PATCH 1/2] x86/setup: simplify handling of initrdidx when no initrd present

2020-03-18 Thread Julien Grall
Hi, On 18/03/2020 11:51, Jan Beulich wrote: On 18.03.2020 12:46, David Woodhouse wrote: From: David Woodhouse Remove a ternary operator that made my brain hurt. My position towards this hasn't changed, just ftr. Replace it with something simpler that makes it somewhat clearer that the che

Re: [Xen-devel] [PATCH 2/2] xen/mm: Introduce PG_state_uninitialised

2020-03-18 Thread David Woodhouse
On Wed, 2020-03-18 at 11:03 +0100, Jan Beulich wrote: > On 17.03.2020 23:15, David Woodhouse wrote: > > On Thu, 2020-02-20 at 12:59 +0100, Jan Beulich wrote: > > > On 07.02.2020 19:04, David Woodhouse wrote: > > > > ASSERT((pg[i].count_info & ~PGC_extra) == PGC_state_inuse || > >

Re: [Xen-devel] [XEN PATCH v3 20/23] xen/build: factorise generation of the linker scripts

2020-03-18 Thread Anthony PERARD
On Thu, Mar 05, 2020 at 12:05:02PM +0100, Jan Beulich wrote: > On 26.02.2020 12:33, Anthony PERARD wrote: > > --- a/xen/Rules.mk > > +++ b/xen/Rules.mk > > @@ -230,6 +230,14 @@ cmd_s_S = $(CPP) $(filter-out -Wa$(comma)%,$(a_flags)) > > $< -o $@ > > %.s: %.S FORCE > > $(call if_changed,cpp_s_S

Re: [Xen-devel] [PATCH 1/2] x86/setup: simplify handling of initrdidx when no initrd present

2020-03-18 Thread Jan Beulich
On 18.03.2020 12:46, David Woodhouse wrote: From: David Woodhouse Remove a ternary operator that made my brain hurt. My position towards this hasn't changed, just ftr. Replace it with something simpler that makes it somewhat clearer that the check for initrdidx < mbi->mods_count is because

[Xen-devel] [PATCH 2/2] x86/setup: lift dom0 creation out into create_dom0() function

2020-03-18 Thread David Woodhouse
From: David Woodhouse The creation of dom0 can be relatively self-contained. Shift it into a separate function and simplify __start_xen() a little bit. This is a cleanup in its own right, but will be even more desireable when live update provides an alternative path through __start_xen() that do

[Xen-devel] [PATCH 1/2] x86/setup: simplify handling of initrdidx when no initrd present

2020-03-18 Thread David Woodhouse
From: David Woodhouse Remove a ternary operator that made my brain hurt. Replace it with something simpler that makes it somewhat clearer that the check for initrdidx < mbi->mods_count is because larger values are what find_first_bit() will return when it doesn't find anything. Also drop the ex

[Xen-devel] [PATCH 0/2] x86/setup: Dom0 creation cleanups

2020-03-18 Thread David Woodhouse
As a precursor to live update support, clean up the dom0 creation in start_xen() a little bit. This makes it easier for later live update patches to make it conditional, since in live update we'll already have an existing dom0 being brought over from the previous Xen. But it's a cleanup in its own

Re: [Xen-devel] [PATCH v11 2/3] x86/mem_sharing: reset a fork

2020-03-18 Thread Jan Beulich
On 28.02.2020 19:40, Tamas K Lengyel wrote: --- a/xen/arch/x86/mm/mem_sharing.c +++ b/xen/arch/x86/mm/mem_sharing.c @@ -1775,6 +1775,91 @@ static int fork(struct domain *cd, struct domain *d) return rc; } +/* + * The fork reset operation is intended to be used on short-lived forks onl

Re: [Xen-devel] [XEN PATCH v3 16/23] xen/build: introduce if_changed and if_changed_rule

2020-03-18 Thread Jan Beulich
On 18.03.2020 11:44, Anthony PERARD wrote: On Wed, Mar 04, 2020 at 04:45:36PM +0100, Jan Beulich wrote: On 26.02.2020 12:33, Anthony PERARD wrote: The if_changed macro from Linux can record the command used to build a target then compare it on rebuild. Thus if a command has changed, for example

Re: [Xen-devel] [XEN PATCH v3 19/23] xen/build: Use if_changed_rules with %.o:%.c targets

2020-03-18 Thread Anthony PERARD
On Wed, Mar 04, 2020 at 05:09:19PM +0100, Jan Beulich wrote: > On 26.02.2020 12:33, Anthony PERARD wrote: > > +define rule_cc_o_c > > +$(call cmd_and_record,cc_o_c) > > +$(call cmd,objcopy_fix_sym) > > The machinery is resilient to a command (here: cmd_objcopy_fix_sym) > not being defined,

[Xen-devel] [PATCH v7 1/2] docs/designs: Add a design document for non-cooperative live migration

2020-03-18 Thread Paul Durrant
From: Paul Durrant It has become apparent to some large cloud providers that the current model of cooperative migration of guests under Xen is not usable as it relies on software running inside the guest, which is likely beyond the provider's control. This patch introduces a proposal for non-coop

[Xen-devel] [PATCH v7 2/2] docs/designs: Add a design document for migration of xenstore data

2020-03-18 Thread Paul Durrant
From: Paul Durrant This patch details proposes extra migration data and xenstore protocol extensions to support non-cooperative live migration of guests. NOTE: doc/misc/xenstore.txt is also amened to replace the term for the INTRODUCE operation with the , since this is what it actua

Re: [Xen-devel] [PATCH 2/2] xen/mm: Introduce PG_state_uninitialised

2020-03-18 Thread Jan Beulich
On 18.03.2020 11:41, Paul Durrant wrote: -Original Message- From: Jan Beulich Sent: 18 March 2020 10:10 To: p...@xen.org Cc: 'David Woodhouse' ; sstabell...@kernel.org; jul...@xen.org; w...@xen.org; konrad.w...@oracle.com; george.dun...@eu.citrix.com; andrew.coop...@citrix.com; ian.jack

[Xen-devel] [PATCH v7 0/2] docs: Migration design documents

2020-03-18 Thread Paul Durrant
Paul Durrant (2): docs/designs: Add a design document for non-cooperative live migration docs/designs: Add a design document for migration of xenstore data docs/designs/non-cooperative-migration.md | 280 ++ docs/designs/xenstore-migration.md| 256 +

[Xen-devel] [libvirt test] 148688: regressions - FAIL

2020-03-18 Thread osstest service owner
flight 148688 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/148688/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 146182 build-arm64-libvirt

Re: [Xen-devel] [XEN PATCH v3 18/23] xen/build: use if_changed on built_in.o

2020-03-18 Thread Anthony PERARD
On Wed, Mar 04, 2020 at 05:03:40PM +0100, Jan Beulich wrote: > On 26.02.2020 12:33, Anthony PERARD wrote: > > --- a/xen/Rules.mk > > +++ b/xen/Rules.mk > > @@ -126,14 +126,21 @@ include $(BASEDIR)/arch/$(TARGET_ARCH)/Rules.mk > > c_flags += $(CFLAGS-y) > > a_flags += $(CFLAGS-y) $(AFLAGS-y) > >

Re: [Xen-devel] [XEN PATCH v3 17/23] xen/build: Start using if_changed

2020-03-18 Thread Anthony PERARD
On Wed, Mar 04, 2020 at 05:00:28PM +0100, Jan Beulich wrote: > On 27.02.2020 14:09, Roger Pau Monné wrote: > > On Wed, Feb 26, 2020 at 11:33:49AM +, Anthony PERARD wrote: > >> @@ -161,29 +173,47 @@ else > >>$(CC) $(c_flags) -c $< -o $@ > >> endif > >> > >> -%.o: %.S Makefile > >> - $(CC

Re: [Xen-devel] [XEN PATCH v3 16/23] xen/build: introduce if_changed and if_changed_rule

2020-03-18 Thread Anthony PERARD
On Wed, Mar 04, 2020 at 04:45:36PM +0100, Jan Beulich wrote: > On 26.02.2020 12:33, Anthony PERARD wrote: > > The if_changed macro from Linux can record the command used to build a > > target then compare it on rebuild. Thus if a command has changed, for > > example due to introducing new flags in

Re: [Xen-devel] [PATCH 2/2] xen/mm: Introduce PG_state_uninitialised

2020-03-18 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 18 March 2020 10:10 > To: p...@xen.org > Cc: 'David Woodhouse' ; sstabell...@kernel.org; > jul...@xen.org; w...@xen.org; > konrad.w...@oracle.com; george.dun...@eu.citrix.com; > andrew.coop...@citrix.com; > ian.jack...@eu.citrix.com; georg

Re: [Xen-devel] [BUG] panic: "IO-APIC + timer doesn't work" - several people have reproduced

2020-03-18 Thread Jan Beulich
On 17.03.2020 16:23, Jason Andryuk wrote: On 17.03.2020 15:08, Jan Beulich wrote: On 17.03.2020 15:08, Jan Beulich wrote: On 17.03.2020 14:48, Jason Andryuk wrote: I got it to boot past "IO-APIC + timer doesn't work". I programmed the HPET to provide a periodic timer in hpet_resume() on T0.

[Xen-devel] [xen-unstable-coverity test] 148699: all pass - PUSHED

2020-03-18 Thread osstest service owner
flight 148699 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/148699/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 1faa954df18733792c33b3f5b1b4de4662cfa892 baseline version: xen d094

Re: [Xen-devel] [XEN PATCH v3 15/23] xen/build: have the root Makefile generates the CFLAGS

2020-03-18 Thread Jan Beulich
On 17.03.2020 19:35, Anthony PERARD wrote: On Wed, Mar 04, 2020 at 04:00:52PM +0100, Jan Beulich wrote: On 26.02.2020 12:33, Anthony PERARD wrote: @@ -113,6 +115,64 @@ $(KCONFIG_CONFIG): +AFLAGS += -D__ASSEMBLY__ + +CFLAGS += $(CFLAGS-y) I can't seem to be able to spot a similar line for AFLA

[Xen-devel] [linux-linus test] 148664: regressions - trouble: fail/pass/starved

2020-03-18 Thread osstest service owner
flight 148664 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/148664/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 17 debian-hvm-install/l1/l2 fail REGR. vs. 133580 Tests which

Re: [Xen-devel] [PATCH 2/2] xen/mm: Introduce PG_state_uninitialised

2020-03-18 Thread Jan Beulich
On 18.03.2020 09:53, Paul Durrant wrote: -Original Message- From: Xen-devel On Behalf Of David Woodhouse Sent: 17 March 2020 22:15 On Thu, 2020-02-20 at 12:59 +0100, Jan Beulich wrote: On 07.02.2020 19:04, David Woodhouse wrote: --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -488

Re: [Xen-devel] [PATCH 2/2] xen/mm: Introduce PG_state_uninitialised

2020-03-18 Thread Jan Beulich
On 17.03.2020 23:15, David Woodhouse wrote: On Thu, 2020-02-20 at 12:59 +0100, Jan Beulich wrote: On 07.02.2020 19:04, David Woodhouse wrote: ASSERT((pg[i].count_info & ~PGC_extra) == PGC_state_inuse || (pg[i].count_info & ~PGC_extra) == PGC_state_uninitialised);

Re: [Xen-devel] [PATCH 1/2] xen/mm: fold PGC_broken into PGC_state bits

2020-03-18 Thread Jan Beulich
On 17.03.2020 22:52, David Woodhouse wrote: On Thu, 2020-02-20 at 12:10 +0100, Jan Beulich wrote: On 07.02.2020 16:57, David Woodhouse wrote: @@ -1145,16 +1145,19 @@ static int reserve_offlined_page(struct page_info *head) for ( cur_head = head; cur_head < head + ( 1UL << head_order);

Re: [Xen-devel] [PATCH] x86/shim: fix ballooning up the guest

2020-03-18 Thread Roger Pau Monné
On Mon, Mar 16, 2020 at 09:47:44PM +, Igor Druzhinin wrote: > args.preempted as meaningless here and doesn't show if the hypercall ^ is^ as it doesn't signal whether the hypercall ... > was preempted before. Use start_extent instead which is correct. > > Signe

Re: [Xen-devel] [PATCH 2/2] xen/mm: Introduce PG_state_uninitialised

2020-03-18 Thread Paul Durrant
> -Original Message- > From: Xen-devel On Behalf Of David > Woodhouse > Sent: 17 March 2020 22:15 > To: Jan Beulich > Cc: sstabell...@kernel.org; jul...@xen.org; w...@xen.org; > konrad.w...@oracle.com; > george.dun...@eu.citrix.com; andrew.coop...@citrix.com; > ian.jack...@eu.citrix.co

Re: [Xen-devel] [PATCH v6 3/4] xen/rcu: add assertions to debug build

2020-03-18 Thread Jan Beulich
On 18.03.2020 07:26, Jürgen Groß wrote: On 17.03.20 15:36, Jan Beulich wrote: On 13.03.2020 14:06, Juergen Gross wrote: Xen's RCU implementation relies on no softirq handling taking place while being in a RCU critical section. Add ASSERT()s in debug builds in order to catch any violations. For

[Xen-devel] [qemu-mainline test] 148661: regressions - trouble: fail/pass/starved

2020-03-18 Thread osstest service owner
flight 148661 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/148661/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 10 debian-hvm-install fail REGR. vs. 14486