[Xen-devel] [qemu-mainline test] 149189: regressions - trouble: fail/pass/starved

2020-03-30 Thread osstest service owner
flight 149189 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/149189/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-amd64 10 debian-hvm-install fail REGR. vs. 144861 test-amd6

[Xen-devel] [xen-unstable test] 149188: tolerable trouble: fail/pass/starved

2020-03-30 Thread osstest service owner
flight 149188 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/149188/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 13 saverestore-support-checkfail like 149151 test-amd64-amd64-xl-qemuu-ws16-amd64

Re: [Xen-devel] [PATCH v2] xen/arm: implement GICD_I[S/C]ACTIVER reads

2020-03-30 Thread Julien Grall
Hi, On 27/03/2020 02:34, Stefano Stabellini wrote: It doesn't take into account the latest state of interrupts on other vCPUs. So I think your implementation is going to introduce a deadlock in the guest. Let's imagine a guest with 2 vCPUs (A and B) with the following setup: * The HW SP

[Xen-devel] [xen-unstable-smoke test] 149225: tolerable all pass - PUSHED

2020-03-30 Thread osstest service owner
flight 149225 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/149225/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [PATCH v2] xen/arm: implement GICD_I[S/C]ACTIVER reads

2020-03-30 Thread Julien Grall
Hi Stefano, On 30/03/2020 17:35, Stefano Stabellini wrote: On Sat, 28 Mar 2020, Julien Grall wrote: qHi Stefano, On 27/03/2020 02:34, Stefano Stabellini wrote: This is a simple implementation of GICD_ICACTIVER / GICD_ISACTIVER reads. It doesn't take into account the latest state of interrupts

Re: [Xen-devel] Tools build failure with gcc-9.2.1

2020-03-30 Thread Julien Grall
Hi Dario, On 30/03/2020 11:58, Dario Faggioli wrote: On Sun, 2020-03-29 at 18:19 +0100, Julien Grall wrote: On 25/03/2020 09:40, Dario Faggioli wrote: /usr/include/string.h:43:14: note: expected 'void * restrict' but argument is of type 'const char *' 43 | extern void *memcpy (void *__res

[Xen-devel] [PATCH 8/8] tools/ocaml: Fix stubs build when OCaml has been compiled with -safe-string

2020-03-30 Thread Julien Grall
From: Julien Grall The OCaml code has been fixed to handle properly -safe-string in Xen 4.11, however the stubs part were missed. On OCaml newer than 4.06.1, String_Val() will return a const char * when using -safe-string leading to build failure when this is used in place where char * is expect

[Xen-devel] [PATCH 1/8] xen/guest_access: Harden copy_to_guest_offset to prevent const dest operand

2020-03-30 Thread Julien Grall
From: Julien Grall At the moment, copy_to_guest_offset() will allow the hypervisor to copy data to guest handle marked const. Thankfully, no users of the helper will do that. Rather than hoping this can be caught during review, harden copy_to_guest_offset() so the build will fail if such users a

[Xen-devel] [PATCH 5/8] tools/ocaml: libxc: Check error return in stub_xc_vcpu_context_get()

2020-03-30 Thread Julien Grall
From: Julien Grall xc_vcpu_getcontext() may fail to retrieve the vcpu context. Rather than ignoring the return value, check it and throw an error if needed. Signed-off-by: Julien Grall --- tools/ocaml/libs/xc/xenctrl_stubs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/ocaml/lib

[Xen-devel] [PATCH 4/8] tools/libxc: misc: Mark const the parameter 'params' of xc_set_parameters()

2020-03-30 Thread Julien Grall
From: Julien Grall The parameter 'params' of xc_set_parameters() should never be modified. So mark it as const. Signed-off-by: Julien Grall --- tools/libxc/include/xenctrl.h | 2 +- tools/libxc/xc_misc.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/lib

[Xen-devel] [PATCH 3/8] tools/libxc: misc: Mark const the parameter 'keys' of xc_send_debug_keys()

2020-03-30 Thread Julien Grall
From: Julien Grall OCaml is using a string to describe the parameter 'keys' of xc_send_debug_keys(). Since Ocaml 4.06.01, String_val() will return a const char * when using -safe-string. This will result to a build failure because xc_send_debug_keys() expects a char *. The function should never

[Xen-devel] [PATCH 6/8] tools/ocaml: libxb: Harden stub_header_of_string()

2020-03-30 Thread Julien Grall
From: Julien Grall stub_header_of_string() should not modify the header. So mark the variable 'hdr' as const. Signed-off-by: Julien Grall --- tools/ocaml/libs/xb/xenbus_stubs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/ocaml/libs/xb/xenbus_stubs.c b/tools/o

[Xen-devel] [PATCH 2/8] xen/public: sysctl: set_parameter.params and debug.keys should be const

2020-03-30 Thread Julien Grall
From: Julien Grall The fields set_parameter.params and debug.keys should never be modified by the hypervisor. So mark them as const. Signed-off-by: Julien Grall --- I am not entirely sure whether we should bump the systcl version for this change. Any thoughts? --- xen/include/public/sysctl.h

[Xen-devel] [PATCH 0/8] Fix build with using OCaml 4.06.1 and -safe-string

2020-03-30 Thread Julien Grall
From: Julien Grall Hi all, This series is meant to solve the build issue reported by Dario when using recent version of OCaml and -safe-string. I took the opportunity to harden a bit more the code by using const more often. This series was only build tested. Cheers, Julien Grall (8): xen/g

[Xen-devel] [PATCH 7/8] tools/ocaml: libxb: Avoid to use String_val() when value is bytes

2020-03-30 Thread Julien Grall
From: Julien Grall Commit ec7d54dd1a "ocaml/libs/xb: Use bytes in place of strings for mutable buffers" switch mutable buffers from string to bytes. However the C code were still using String_Val() to access them. While the underlying structure is the same between string and bytes, a string is m

[Xen-devel] [xen-unstable-smoke test] 149213: tolerable all pass - PUSHED

2020-03-30 Thread osstest service owner
flight 149213 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/149213/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [PATCH 1/2] tools/xenstore: Do not abort xenstore-ls if a node disappears while iterating

2020-03-30 Thread Ian Jackson
Ian Jackson writes ("Re: [Xen-devel] [PATCH 1/2] tools/xenstore: Do not abort xenstore-ls if a node disappears while iterating"): > And making a node visible by XS_DIRECTORY[_PART] doesn't count as > reading it. But it does count as reading the parent ? > In principle adding or removing a node co

Re: [Xen-devel] [PATCH 1/2] tools/xenstore: Do not abort xenstore-ls if a node disappears while iterating

2020-03-30 Thread Ian Jackson
Jürgen Groß writes ("Re: [Xen-devel] [PATCH 1/2] tools/xenstore: Do not abort xenstore-ls if a node disappears while iterating"): > On 20.03.20 15:58, David Woodhouse wrote: > > But it does still happen. And even if I turn the errx() into a warn() > > to stop it aborting, and add a warn() when the

Re: [Xen-devel] [PATCH v2] xen/arm: implement GICD_I[S/C]ACTIVER reads

2020-03-30 Thread Stefano Stabellini
On Sat, 28 Mar 2020, Julien Grall wrote: > qHi Stefano, > > On 27/03/2020 02:34, Stefano Stabellini wrote: > > This is a simple implementation of GICD_ICACTIVER / GICD_ISACTIVER > > reads. It doesn't take into account the latest state of interrupts on > > other vCPUs. Only the current vCPU is up-t

[Xen-devel] [PATCH v13 1/3] xen/mem_sharing: VM forking

2020-03-30 Thread Tamas K Lengyel
VM forking is the process of creating a domain with an empty memory space and a parent domain specified from which to populate the memory when necessary. For the new domain to be functional the VM state is copied over as part of the fork operation (HVM params, hap allocation, etc). Signed-off-by:

[Xen-devel] [PATCH v13 0/3] VM forking

2020-03-30 Thread Tamas K Lengyel
The following series implements VM forking for Intel HVM guests to allow for the fast creation of identical VMs without the assosciated high startup costs of booting or restoring the VM from a savefile. JIRA issue: https://xenproject.atlassian.net/browse/XEN-89 The fork operation is implemented a

[Xen-devel] [PATCH v13 2/3] x86/mem_sharing: reset a fork

2020-03-30 Thread Tamas K Lengyel
Implement hypercall that allows a fork to shed all memory that got allocated for it during its execution and re-load its vCPU context from the parent VM. This allows the forked VM to reset into the same state the parent VM is in a faster way then creating a new fork would be. Measurements show abou

[Xen-devel] [PATCH v13 3/3] xen/tools: VM forking toolstack side

2020-03-30 Thread Tamas K Lengyel
Add necessary bits to implement "xl fork-vm" commands. The command allows the user to specify how to launch the device model allowing for a late-launch model in which the user can execute the fork without the device model and decide to only later launch it. Signed-off-by: Tamas K Lengyel --- doc

Re: [Xen-devel] [PATCH 1/3] docs etc.: https: Fix references to wiki.xen[project.org

2020-03-30 Thread Ian Jackson
Julien Grall writes ("Re: [PATCH 1/3] docs etc.: https: Fix references to wiki.xen[project.org"): > Hi Ian, > > Title: Did you intend to use {,project} rather than [project? I intended to use [project]. Will fix. Ian.

Re: [Xen-devel] [PATCH 2/3] docs etc.: https: Fix references to other Xen pages

2020-03-30 Thread Julien Grall
Hi Ian, On 30/03/2020 14:57, Ian Jackson wrote: Change the url scheme to https. This is all in-tree references to xenbits and the main website except for those in Config.mk. We leave Config.mk alone for now because those urls are used by CI systems and we need to check that nothing breaks when

Re: [Xen-devel] [PATCH 3/3] docs/README: Fix a broken url

2020-03-30 Thread Julien Grall
Hi Ian, On 30/03/2020 14:57, Ian Jackson wrote: There was a / missing here. Signed-off-by: Ian Jackson Reviewed-by: Julien Grall Cheers, --- README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README b/README index 555f3415fa..d0c87a78f0 100644 --- a/README +++

Re: [Xen-devel] [PATCH 1/3] docs etc.: https: Fix references to wiki.xen[project.org

2020-03-30 Thread Julien Grall
Hi Ian, Title: Did you intend to use {,project} rather than [project? Cheers, On 30/03/2020 14:57, Ian Jackson wrote: Change the url scheme to https. This is all in-tree references to the Xen wiki. Signed-off-by: Ian Jackson --- README| 16 co

Re: [Xen-devel] [XEN PATCH] mismatch between pyxc_methods flags and PyObject definitions

2020-03-30 Thread Ian Jackson
Wei Liu writes ("Re: [XEN PATCH] mismatch between pyxc_methods flags and PyObject definitions"): > Ian, this needs to be backported to at least 4.13 since we started > supported Python 3 in that version. > > Backport: 4.13 Noted. Ian.

[Xen-devel] [PATCH 0/3] docs: Fix our url schemes to use https

2020-03-30 Thread Ian Jackson
Obviously we should be publishing https: URLs instead of http: ones where possible. I have not changed URLs referring to other projects at this stage because that would have involved checking whether https:// works for them. Ian Jackson (3): docs etc.: https: Fix references to wiki.xen[project.

[Xen-devel] [PATCH 1/3] docs etc.: https: Fix references to wiki.xen[project.org

2020-03-30 Thread Ian Jackson
Change the url scheme to https. This is all in-tree references to the Xen wiki. Signed-off-by: Ian Jackson --- README| 16 config/Paths.mk.in| 2 +- docs/README.colo | 2 +- docs/README.remus | 2 +-

[Xen-devel] [PATCH 3/3] docs/README: Fix a broken url

2020-03-30 Thread Ian Jackson
There was a / missing here. Signed-off-by: Ian Jackson --- README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README b/README index 555f3415fa..d0c87a78f0 100644 --- a/README +++ b/README @@ -20,7 +20,7 @@ GPL. Since its initial public release, Xen has grown a large deve

[Xen-devel] [PATCH 2/3] docs etc.: https: Fix references to other Xen pages

2020-03-30 Thread Ian Jackson
Change the url scheme to https. This is all in-tree references to xenbits and the main website except for those in Config.mk. We leave Config.mk alone for now because those urls are used by CI systems and we need to check that nothing breaks when we change the download method. Signed-off-by: Ian

Re: [Xen-devel] [PATCH 2/2] scripts: Use stat to check lock claim

2020-03-30 Thread Wei Liu
On Mon, Mar 30, 2020 at 02:28:30PM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH 2/2] scripts: Use stat to check lock claim"): > > On Thu, Mar 12, 2020 at 10:54:17AM -0400, Jason Andryuk wrote: > > > Replace the perl locking check with stat(1). Stat is able to fstat > > > stdin (file des

Re: [Xen-devel] [PATCH 2/2] scripts: Use stat to check lock claim

2020-03-30 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH 2/2] scripts: Use stat to check lock claim"): > On Thu, Mar 12, 2020 at 10:54:17AM -0400, Jason Andryuk wrote: > > Replace the perl locking check with stat(1). Stat is able to fstat > > stdin (file descriptor 0) when passed '-' as an argument. This is now > > used to c

Re: [Xen-devel] [PATCH 2/2] scripts: Use stat to check lock claim

2020-03-30 Thread Wei Liu
On Thu, Mar 12, 2020 at 10:54:17AM -0400, Jason Andryuk wrote: > Replace the perl locking check with stat(1). Stat is able to fstat > stdin (file descriptor 0) when passed '-' as an argument. This is now > used to check $_lockfd. stat(1) support for '-' was introduced to > coreutils in 2009. >

[Xen-devel] [seabios test] 149173: regressions - FAIL

2020-03-30 Thread osstest service owner
flight 149173 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/149173/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 17 debian-hvm-install/l1/l2 fail REGR. vs. 148666 Tests which did

Re: [Xen-devel] [PATCH v2] xen/x86: Compress lines for immediate return

2020-03-30 Thread Wei Liu
On Mon, Mar 30, 2020 at 05:53:08PM +0530, Simran Singhal wrote: > Compress two lines into a single line if immediate return statement is found. > It also remove variables retval, freq, effective, vector, ovf and now > as they are no longer needed. > > Signed-off-by: Simran Singhal Reviewed-by: W

Re: [Xen-devel] [PATCH 3/3] xen/x86: ioapic: Simplify ioapic_init()

2020-03-30 Thread Julien Grall
Hi Roger, On 30/03/2020 11:43, Roger Pau Monné wrote: On Fri, Mar 27, 2020 at 07:05:46PM +, Julien Grall wrote: From: Julien Grall Since commit 9facd54a45 "x86/ioapic: Add register level checks to detect bogus io-apic entries", Xen is able to cope with IO APICs not mapped in the fixmap.

Re: [Xen-devel] [PATCH 2/3] xen/x86: ioapic: Rename init_ioapic_mappings() to init_ioapic()

2020-03-30 Thread Julien Grall
On 30/03/2020 11:37, Roger Pau Monné wrote: On Fri, Mar 27, 2020 at 07:05:45PM +, Julien Grall wrote: From: Julien Grall The function init_ioapic_mappings() is doing more than initialization mappings. It is also initialization the number of IRQs/GSIs supported. So rename the function t

Re: [Xen-devel] [PATCH v2] xen/x86: Remove unnecessary cast on void pointer

2020-03-30 Thread Roger Pau Monné
On Mon, Mar 30, 2020 at 01:09:20PM +0200, Jan Beulich wrote: > On 30.03.2020 12:11, Roger Pau Monné wrote: > > On Sun, Mar 29, 2020 at 10:25:12AM +0530, Simran Singhal wrote: > >> diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c > >> index f049920196..2edb103205 100644 > >> --

[Xen-devel] [libvirt test] 149193: regressions - FAIL

2020-03-30 Thread osstest service owner
flight 149193 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/149193/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 146182 build-i386-libvirt

[Xen-devel] [PATCH v2] xen/x86: Compress lines for immediate return

2020-03-30 Thread Simran Singhal
Compress two lines into a single line if immediate return statement is found. It also remove variables retval, freq, effective, vector, ovf and now as they are no longer needed. Signed-off-by: Simran Singhal --- Changes in v2: - Remove variable ovf as it is also not needed. xen/arch/x86

[Xen-devel] [ovmf test] 149176: all pass - PUSHED

2020-03-30 Thread osstest service owner
flight 149176 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/149176/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d671d1fa48dbb3f22b68c1d67914c55ba1d58454 baseline version: ovmf 6e9bd495b38e05ece5f53

Re: [Xen-devel] [PATCH] x86/ucode/amd: Fix more potential buffer overruns with microcode parsing

2020-03-30 Thread Andrew Cooper
On 30/03/2020 12:44, Jan Beulich wrote: > On 28.03.2020 16:29, Andrew Cooper wrote: >> --- a/xen/arch/x86/cpu/microcode/amd.c >> +++ b/xen/arch/x86/cpu/microcode/amd.c >> @@ -303,11 +303,20 @@ static int get_ucode_from_buffer_amd( >> static int install_equiv_cpu_table( >> struct microcode_amd

Re: [Xen-devel] [PATCH] x86/ucode/amd: Fix more potential buffer overruns with microcode parsing

2020-03-30 Thread Jan Beulich
On 28.03.2020 16:29, Andrew Cooper wrote: > --- a/xen/arch/x86/cpu/microcode/amd.c > +++ b/xen/arch/x86/cpu/microcode/amd.c > @@ -303,11 +303,20 @@ static int get_ucode_from_buffer_amd( > static int install_equiv_cpu_table( > struct microcode_amd *mc_amd, > const void *data, > +size_

Re: [Xen-devel] [PATCH] xen/x86: Compress lines for immediate return

2020-03-30 Thread Simran Singhal
On Sun, Mar 29, 2020 at 7:17 PM Wei Liu wrote: > On Sun, Mar 29, 2020 at 11:46:08AM +0530, Simran Singhal wrote: > > diff --git a/xen/arch/x86/oprofile/op_model_athlon.c > b/xen/arch/x86/oprofile/op_model_athlon.c > > index 5c48f868ae..2bc0d04a1f 100644 > > --- a/xen/arch/x86/oprofile/op_model_at

Re: [Xen-devel] [PATCH v2] xen/x86: Remove unnecessary cast on void pointer

2020-03-30 Thread Jan Beulich
On 30.03.2020 12:11, Roger Pau Monné wrote: > On Sun, Mar 29, 2020 at 10:25:12AM +0530, Simran Singhal wrote: >> diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c >> index f049920196..2edb103205 100644 >> --- a/xen/arch/x86/hvm/vmx/vvmx.c >> +++ b/xen/arch/x86/hvm/vmx/vvmx.c >>

Re: [Xen-devel] [PATCH] xen/x86: Remove parentheses from return arguments

2020-03-30 Thread Jan Beulich
On 29.03.2020 15:49, Wei Liu wrote: > On Sun, Mar 29, 2020 at 12:07:47PM +0530, Simran Singhal wrote: >> This patch remove unnecessary parentheses from return arguments. >> >> Signed-off-by: Simran Singhal > > Reviewed-by: Wei Liu Acked-by: Jan Beulich

Re: [Xen-devel] [PATCH v2] xen/x86: Remove unnecessary cast on void pointer

2020-03-30 Thread Jan Beulich
On 30.03.2020 12:05, Roger Pau Monné wrote: > On Sun, Mar 29, 2020 at 02:36:51PM +0100, Wei Liu wrote: >> On Sun, Mar 29, 2020 at 10:25:12AM +0530, Simran Singhal wrote: >>> Assignment to a typed pointer is sufficient in C. >>> No cast is needed. >>> >>> Also, changed some u64/u32 to uint64_t/uint3

Re: [Xen-devel] [PATCH v2] xen/x86: Remove unnecessary cast on void pointer

2020-03-30 Thread Simran Singhal
On Mon, Mar 30, 2020 at 3:41 PM Roger Pau Monné wrote: > On Sun, Mar 29, 2020 at 10:25:12AM +0530, Simran Singhal wrote: > > diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c > > index f049920196..2edb103205 100644 > > --- a/xen/arch/x86/hvm/vmx/vvmx.c > > +++ b/xen/arch/x86/

Re: [Xen-devel] Tools build failure with gcc-9.2.1

2020-03-30 Thread Dario Faggioli
On Sun, 2020-03-29 at 18:19 +0100, Julien Grall wrote: > On 25/03/2020 09:40, Dario Faggioli wrote: > > /usr/include/string.h:43:14: note: expected 'void * restrict' but > > argument is of type 'const char *' > > 43 | extern void *memcpy (void *__restrict __dest, const void > > *__restrict __sr

Re: [Xen-devel] [PATCH 3/5] tools/misc: add xen-ctx to present domain context

2020-03-30 Thread Jan Beulich
On 27.03.2020 19:50, Paul Durrant wrote: > This tools is analogous to 'xen-hvmctx' which presents HVM context. > Subsequent patches will add 'dump' functions when new records are > introduced. > > Signed-off-by: Paul Durrant > --- > Cc: Ian Jackson > Cc: Wei Liu > --- > .gitignore |

Re: [Xen-devel] [PATCH 3/3] xen/x86: ioapic: Simplify ioapic_init()

2020-03-30 Thread Roger Pau Monné
On Fri, Mar 27, 2020 at 07:05:46PM +, Julien Grall wrote: > From: Julien Grall > > Since commit 9facd54a45 "x86/ioapic: Add register level checks to detect > bogus io-apic entries", Xen is able to cope with IO APICs not mapped in > the fixmap. > > Therefore the whole logic to allocate a fake

Re: [Xen-devel] [PATCH 2/3] xen/x86: ioapic: Rename init_ioapic_mappings() to init_ioapic()

2020-03-30 Thread Roger Pau Monné
On Fri, Mar 27, 2020 at 07:05:45PM +, Julien Grall wrote: > From: Julien Grall > > The function init_ioapic_mappings() is doing more than initialization > mappings. It is also initialization the number of IRQs/GSIs supported. > > So rename the function to init_ioapic(). This will allow us to

Re: [Xen-devel] [PATCH] automation: update openSUSE Tumbleweed building dependencies

2020-03-30 Thread Dario Faggioli
On Fri, 2020-03-27 at 13:50 +, Andrew Cooper wrote: > On 26/03/2020 17:29, Dario Faggioli wrote: > > > > diff --git a/automation/build/suse/opensuse-tumbleweed.dockerfile > > b/automation/build/suse/opensuse-tumbleweed.dockerfile > > index 2676a87c85..e80d773a79 100644 > > --- a/automation/bui

Re: [Xen-devel] [PATCH v2] xen/x86: Remove unnecessary cast on void pointer

2020-03-30 Thread Roger Pau Monné
On Sun, Mar 29, 2020 at 10:25:12AM +0530, Simran Singhal wrote: > diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c > index f049920196..2edb103205 100644 > --- a/xen/arch/x86/hvm/vmx/vvmx.c > +++ b/xen/arch/x86/hvm/vmx/vvmx.c > @@ -253,12 +253,12 @@ static int vvmcs_offset(u32

Re: [Xen-devel] [PATCH v2] xen/x86: Remove unnecessary cast on void pointer

2020-03-30 Thread Roger Pau Monné
On Sun, Mar 29, 2020 at 02:36:51PM +0100, Wei Liu wrote: > On Sun, Mar 29, 2020 at 10:25:12AM +0530, Simran Singhal wrote: > > Assignment to a typed pointer is sufficient in C. > > No cast is needed. > > > > Also, changed some u64/u32 to uint64_t/uint32_t. > > > > Signed-off-by: Simran Singhal >

[Xen-devel] [PATCH] drm/xen: fix passing zero to 'PTR_ERR' warning

2020-03-30 Thread Ding Xiang
Fix a static code checker warning: drivers/gpu/drm/xen/xen_drm_front.c:404 xen_drm_drv_dumb_create() warn: passing zero to 'PTR_ERR' Signed-off-by: Ding Xiang --- drivers/gpu/drm/xen/xen_drm_front.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xen/x

[Xen-devel] [linux-5.4 test] 149164: regressions - trouble: fail/pass/starved

2020-03-30 Thread osstest service owner
flight 149164 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/149164/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 17 debian-hvm-install/l1/l2 fail REGR. vs. 146121 Tests which d

Re: [Xen-devel] [PATCH 0/5] use new API for Xen page tables

2020-03-30 Thread Hongyan Xia
On Sun, 2020-03-29 at 16:06 +0100, Wei Liu wrote: > On Mon, Mar 23, 2020 at 09:41:37AM +, Hongyan Xia wrote: > > From: Hongyan Xia > > > > This small series is basically just rewriting functions using the > > new > > API to map and unmap PTEs. Each patch is independent. > > > > Apart from ma

Re: [Xen-devel] [PATCH 16/17] xen/mm: Convert {s, g}et_gpfn_from_mfn() to use typesafe MFN

2020-03-30 Thread Jan Beulich
On 28.03.2020 12:14, Julien Grall wrote: > On 27/03/2020 13:15, Jan Beulich wrote: >> On 22.03.2020 17:14, jul...@xen.org wrote: >>> @@ -983,19 +984,20 @@ long p2m_pt_audit_p2m(struct p2m_domain *p2m) >>>   /* check for 1GB super page */ >>>   if ( l3e_get_flags(l3e[

Re: [Xen-devel] [PATCH 05/17] xen/x86: Remove the non-typesafe version of pagetable_* helpers

2020-03-30 Thread Jan Beulich
On 28.03.2020 11:52, Julien Grall wrote: > On 26/03/2020 15:39, Jan Beulich wrote: >> On 22.03.2020 17:14, jul...@xen.org wrote: >>> @@ -3116,24 +3116,24 @@ int vcpu_destroy_pagetables(struct vcpu *v) >>>     /* Free that page if non-zero */ >>>   do { >>> -    if ( mfn ) >>> +    i

Re: [Xen-devel] [PATCH 01/17] xen/x86: Introduce helpers to generate/convert the CR3 from/to a MFN/GFN

2020-03-30 Thread Jan Beulich
On 28.03.2020 11:14, Julien Grall wrote: > On 25/03/2020 14:46, Jan Beulich wrote: >> On 22.03.2020 17:14, jul...@xen.org wrote: >>> From: Julien Grall >>> >>> Introduce handy helpers to generate/convert the CR3 from/to a MFN/GFN. >>> >>> Note that we are using cr3_pa() rather than xen_cr3_to_pfn(

[Xen-devel] [linux-linus test] 149158: regressions - trouble: fail/pass/starved

2020-03-30 Thread osstest service owner
flight 149158 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/149158/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 17 debian-hvm-install/l1/l2 fail REGR. vs. 133580 Tests which