Re: [PATCH v11 1/3] x86/tlb: introduce a flush HVM ASIDs flag

2020-04-28 Thread Tim Deegan
At 11:12 +0100 on 27 Apr (1587985955), Wei Liu wrote: > On Thu, Apr 23, 2020 at 06:33:49PM +0200, Jan Beulich wrote: > > On 23.04.2020 16:56, Roger Pau Monne wrote: > > > Introduce a specific flag to request a HVM guest linear TLB flush, > > > which is an ASID/VPID tickle that forces a guest linear

[qemu-mainline test] 149866: tolerable FAIL - PUSHED

2020-04-28 Thread osstest service owner
flight 149866 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/149866/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds16 guest-start/debian.repeat fail REGR. vs. 149744 Tests which did not succee

Re: [PATCH] tools/xenstore: don't store domU's mfn of ring page in xensotred

2020-04-28 Thread Jürgen Groß
On 28.04.20 22:55, Julien Grall wrote: Hi Juergen, On Tue, 28 Apr 2020 at 16:53, Juergen Gross wrote: The XS_INTRODUCE command has two parameters: the mfn (or better: gfn) of the domain's xenstore ring page and the event channel of the domain for communicating with Xenstore. The gfn is not r

Re: [PATCH 02/11] xen: Fix and improve handling of device_add usb-host errors

2020-04-28 Thread Markus Armbruster
Paul Durrant writes: >> -Original Message- >> From: Markus Armbruster >> Sent: 24 April 2020 20:20 >> To: qemu-de...@nongnu.org >> Cc: Stefano Stabellini ; Anthony Perard >> ; Paul >> Durrant ; Gerd Hoffmann ; >> xen-devel@lists.xenproject.org >> Subject: [PATCH 02/11] xen: Fix and imp

[xen-unstable test] 149865: tolerable FAIL - PUSHED

2020-04-28 Thread osstest service owner
flight 149865 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/149865/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds16 guest-start/debian.repeat fail REGR. vs. 149842 Tests which did not succeed

[ovmf test] 149867: all pass - PUSHED

2020-04-28 Thread osstest service owner
flight 149867 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/149867/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 099dfbb29d8bf0a30e397e3f5baf1da437b8f0ba baseline version: ovmf 0f1946b6626e263c7f764

[PATCH v2 1/2] Fix undefined behaviour

2020-04-28 Thread Grzegorz Uriasz
This patch fixes qemu crashes when passing through an IGD device to HVM guests under XEN. The problem is that on almost every laptop reading the IGD ROM from SYSFS will fail, the reason for it is that the IGD rom is polymorphic and it modifies itself during bootup - this results in an invalid rom

[PATCH v2 2/2] Improve legacy vbios handling

2020-04-28 Thread Grzegorz Uriasz
The current method of getting the vbios is broken - it just isn't working on any device I've tested - the reason for this is explained in the previous patch. The vbios is polymorphic and getting a proper unmodified copy is often not possible without reverse engineering the firmware. We don't need

[PATCH v2 0/2] Fix QEMU crashes when passing IGD to a guest VM under XEN

2020-04-28 Thread Grzegorz Uriasz
This is the v1 cover letter - the patches now include a detailed description of the changes. Hi, This patch series is a small subset of a bigger patch set spanning few projects aiming to isolate the GPU in QUBES OS to a dedicated security domain. I'm doing this together with 3 colleagues as pa

Re: [PATCH] x86/xen: drop an unused parameter gsi_override

2020-04-28 Thread Boris Ostrovsky
On 4/28/20 11:36 AM, Wei Liu wrote: > All callers within the same file pass in -1 (no override). > > Signed-off-by: Wei Liu Reviewed-by: Boris Ostrovsky

[linux-linus test] 149854: tolerable FAIL - PUSHED

2020-04-28 Thread osstest service owner
flight 149854 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/149854/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-examine 8 reboot fail in 149840 pass in 149854 test-amd64-amd64-examine4 mem

Re: [Xen-devel] [BUG] panic: "IO-APIC + timer doesn't work" - several people have reproduced

2020-04-28 Thread Jason Andryuk
On Fri, Apr 17, 2020 at 5:31 AM Jan Beulich wrote: > > On 17.03.2020 16:23, Jason Andryuk wrote: > > Below is the diff. It was messier and I tidied it up some. > > I've looked into this some more. I can see how what we currently > do is not in line with firmware handing off with LegacyReplacement

Re: [PATCH] tools/xenstore: don't store domU's mfn of ring page in xensotred

2020-04-28 Thread Julien Grall
Hi Juergen, On Tue, 28 Apr 2020 at 16:53, Juergen Gross wrote: > > The XS_INTRODUCE command has two parameters: the mfn (or better: gfn) > of the domain's xenstore ring page and the event channel of the > domain for communicating with Xenstore. > > The gfn is not really needed. It is stored in th

Re: [PATCH] tools/xenstore: don't store domU's mfn of ring page in xensotred

2020-04-28 Thread Andrew Cooper
On 28/04/2020 16:51, Juergen Gross wrote: > The XS_INTRODUCE command has two parameters: the mfn (or better: gfn) > of the domain's xenstore ring page and the event channel of the > domain for communicating with Xenstore. > > The gfn is not really needed. It is stored in the per-domain struct > in

[xen-unstable-smoke test] 149863: tolerable all pass - PUSHED

2020-04-28 Thread osstest service owner
flight 149863 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/149863/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH] xen/swiotlb: correct the check for xen_destroy_contiguous_region

2020-04-28 Thread Stefano Stabellini
On Tue, 28 Apr 2020, Jürgen Groß wrote: > On 28.04.20 09:33, peng@nxp.com wrote: > > From: Peng Fan > > > > When booting xen on i.MX8QM, met: > > " > > [3.602128] Unable to handle kernel paging request at virtual address > > 00272d40 > > [3.610804] Mem abort info: > > [3.6

Re: [PATCH] xen/swiotlb: correct the check for xen_destroy_contiguous_region

2020-04-28 Thread Joe Jin
On 4/28/20 10:25 AM, Konrad Rzeszutek Wilk wrote: > On Tue, Apr 28, 2020 at 12:19:41PM +0200, Jürgen Groß wrote: >> On 28.04.20 10:25, Peng Fan wrote: > > Adding Joe Jin. > > Joe, didn't you have some ideas on how this could be implemented? > Subject: Re: [PATCH] xen/swiotlb: correct the ch

Re: Golang Xen packages and the golang packaging system

2020-04-28 Thread Nick Rosbrook
> BTW the separate repo isn’t off the table. But there were some things other > Ian pointed out: After trying (and failing) to get a go module with a remote import path like `golang.xenproject.org/xenlight` defined in xen.git, I would like to circle back to the separate repo. In theory, modules

Re: [PATCH] xen/swiotlb: correct the check for xen_destroy_contiguous_region

2020-04-28 Thread Konrad Rzeszutek Wilk
On Tue, Apr 28, 2020 at 12:19:41PM +0200, Jürgen Groß wrote: > On 28.04.20 10:25, Peng Fan wrote: Adding Joe Jin. Joe, didn't you have some ideas on how this could be implemented? > > > Subject: Re: [PATCH] xen/swiotlb: correct the check for > > > xen_destroy_contiguous_region > > > > > > On 28

[xen-4.12-testing test] 149845: tolerable FAIL - PUSHED

2020-04-28 Thread osstest service owner
flight 149845 xen-4.12-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/149845/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qcow217 guest-localmigrate/x10 fail like 149646 test-amd64-i386-xl-pvshim12

[xen-unstable test] 149842: tolerable FAIL - PUSHED

2020-04-28 Thread osstest service owner
flight 149842 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/149842/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 18 guest-localmigrate/x10 fail blocked in 149831 test-amd64-amd64-xl-qemuu-ws16-amd64

Re: Xen network domain performance for 10Gb NIC

2020-04-28 Thread Roger Pau Monné
On Tue, Apr 28, 2020 at 04:08:08PM +, tosher 1 wrote: > > Do you get the expected performance from the driver domain when not > > using it as a backend? Ie: running the iperf benchmarks directly on > > the driver domain and not on the guest. > > > Yes, the bandwidth between the driver domain

Re: [PATCH] x86/pass-through: avoid double IRQ unbind during domain cleanup

2020-04-28 Thread Roger Pau Monné
On Tue, Apr 28, 2020 at 02:21:48PM +0200, Jan Beulich wrote: > XEN_DOMCTL_destroydomain creates a continuation if domain_kill -ERESTARTs. > In that scenario, it is possible to receive multiple _pirq_guest_unbind > calls for the same pirq from domain_kill, if the pirq has not yet been > removed from

Re: Xen network domain performance for 10Gb NIC

2020-04-28 Thread tosher 1
> Do you get the expected performance from the driver domain when not > using it as a backend? Ie: running the iperf benchmarks directly on > the driver domain and not on the guest. Yes, the bandwidth between the driver domain and the client machine is close to 10Gbits/sec.

Re: [PATCH 5/6] x86/pv: map and unmap page tables in mark_pv_pt_pages_rdonly

2020-04-28 Thread Hongyan Xia
On Tue, 2020-04-28 at 16:55 +0100, Hongyan Xia wrote: > On Tue, 2020-04-28 at 17:33 +0200, Jan Beulich wrote: > > On 17.04.2020 11:52, Hongyan Xia wrote: > > > --- a/xen/arch/x86/pv/dom0_build.c > > > +++ b/xen/arch/x86/pv/dom0_build.c > > > @@ -50,17 +50,17 @@ static __init void > > > mark_pv_pt_p

Re: [PATCH 5/6] x86/pv: map and unmap page tables in mark_pv_pt_pages_rdonly

2020-04-28 Thread Hongyan Xia
On Tue, 2020-04-28 at 17:33 +0200, Jan Beulich wrote: > On 17.04.2020 11:52, Hongyan Xia wrote: > > --- a/xen/arch/x86/pv/dom0_build.c > > +++ b/xen/arch/x86/pv/dom0_build.c > > @@ -50,17 +50,17 @@ static __init void > > mark_pv_pt_pages_rdonly(struct domain *d, > > unsigned long count; > >

[PATCH] tools/xenstore: don't store domU's mfn of ring page in xensotred

2020-04-28 Thread Juergen Gross
The XS_INTRODUCE command has two parameters: the mfn (or better: gfn) of the domain's xenstore ring page and the event channel of the domain for communicating with Xenstore. The gfn is not really needed. It is stored in the per-domain struct in xenstored and in case of another XS_INTRODUCE for the

Re: [PATCH 5/6] x86/pv: map and unmap page tables in mark_pv_pt_pages_rdonly

2020-04-28 Thread Wei Liu
On Tue, Apr 28, 2020 at 05:33:29PM +0200, Jan Beulich wrote: > On 17.04.2020 11:52, Hongyan Xia wrote: > > --- a/xen/arch/x86/pv/dom0_build.c > > +++ b/xen/arch/x86/pv/dom0_build.c > > @@ -50,17 +50,17 @@ static __init void mark_pv_pt_pages_rdonly(struct > > domain *d, > > unsigned long count

RE: [PATCH v2 4/5] common/domain: add a domain context record for shared_info...

2020-04-28 Thread Paul Durrant
> -Original Message- > From: Julien Grall > Sent: 20 April 2020 18:35 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Paul Durrant ; Ian Jackson > ; Wei Liu ; > Andrew Cooper ; George Dunlap > ; Jan Beulich > ; Stefano Stabellini > Subject: Re: [PATCH v2 4/5] common/domain: ad

RE: [PATCH v2 2/5] xen/common/domctl: introduce XEN_DOMCTL_get/setdomaincontext

2020-04-28 Thread Paul Durrant
> -Original Message- > From: Julien Grall > Sent: 20 April 2020 18:26 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Paul Durrant ; Daniel De Graaf > ; Ian Jackson > ; Wei Liu ; Andrew Cooper > ; George > Dunlap ; Jan Beulich ; Stefano > Stabellini > > Subject: Re: [PATCH v2

[PATCH] x86/xen: drop an unused parameter gsi_override

2020-04-28 Thread Wei Liu
All callers within the same file pass in -1 (no override). Signed-off-by: Wei Liu --- arch/x86/pci/xen.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c index 91220cc25854..e3f1ca316068 100644 --- a/arch/x86/pci/xen.c

RE: [PATCH v2 1/5] xen/common: introduce a new framework for save/restore of 'domain' context

2020-04-28 Thread Paul Durrant
> -Original Message- > From: Julien Grall > Sent: 20 April 2020 18:21 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Paul Durrant ; Andrew Cooper > ; George Dunlap > ; Ian Jackson ; Jan > Beulich ; > Stefano Stabellini ; Wei Liu ; > Volodymyr Babchuk > ; Roger Pau Monné > Su

Re: [PATCH 6/6] x86/pv: map and unmap page table in dom0_construct_pv

2020-04-28 Thread Jan Beulich
On 24.04.2020 11:18, Julien Grall wrote: > On 17/04/2020 10:52, Hongyan Xia wrote: >> From: Wei Liu >> >> Signed-off-by: Wei Liu >> Signed-off-by: Hongyan Xia > > Reviewed-by: Julien Grall Acked-by: Jan Beulich

Re: [PATCH 5/6] x86/pv: map and unmap page tables in mark_pv_pt_pages_rdonly

2020-04-28 Thread Jan Beulich
On 17.04.2020 11:52, Hongyan Xia wrote: > --- a/xen/arch/x86/pv/dom0_build.c > +++ b/xen/arch/x86/pv/dom0_build.c > @@ -50,17 +50,17 @@ static __init void mark_pv_pt_pages_rdonly(struct domain > *d, > unsigned long count; > struct page_info *page; > l4_pgentry_t *pl4e; > -l3_pge

Re: [PATCH 4/6] x86/smpboot: map and unmap page tables in cleanup_cpu_root_pgt

2020-04-28 Thread Jan Beulich
On 24.04.2020 11:13, Julien Grall wrote: > On 17/04/2020 10:52, Hongyan Xia wrote: >> From: Wei Liu >> >> Signed-off-by: Wei Liu >> Signed-off-by: Hongyan Xia > > Reviewed-by: Julien Grall Acked-by: Jan Beulich

[PATCH v2] mem_sharing: map shared_info page to same gfn during fork

2020-04-28 Thread Tamas K Lengyel
During a VM fork we copy the shared_info page; however, we also need to ensure that the page is mapped into the same GFN in the fork as its in the parent. Signed-off-by: Tamas K Lengyel Suggested-by: Roger Pau Monne --- xen/arch/x86/mm/mem_sharing.c | 25 + 1 file change

Re: [PATCH 3/6] x86_64/mm: map and unmap page tables in subarch_memory_op

2020-04-28 Thread Jan Beulich
On 24.04.2020 11:06, Julien Grall wrote: > On 17/04/2020 10:52, Hongyan Xia wrote: >> From: Wei Liu >> >> Signed-off-by: Wei Liu >> Signed-off-by: Hongyan Xia > > Reviewed-by: Julien Grall Acked-by: Jan Beulich

Re: [PATCH 2/6] x86_64/mm: map and unmap page tables in subarch_init_memory

2020-04-28 Thread Jan Beulich
On 24.04.2020 11:04, Julien Grall wrote: > On 17/04/2020 10:52, Hongyan Xia wrote: >> From: Wei Liu >> >> Signed-off-by: Wei Liu >> Signed-off-by: Hongyan Xia > > Reviewed-by: Julien Grall Acked-by: Jan Beulich

Re: [PATCH 1/6] x86_64/mm: map and unmap page tables in cleanup_frame_table

2020-04-28 Thread Jan Beulich
On 24.04.2020 11:02, Julien Grall wrote: > On 17/04/2020 10:52, Hongyan Xia wrote: >> @@ -763,10 +763,10 @@ static void cleanup_frame_table(struct mem_hotadd_info >> *info) >>   continue; >>   } >>   -    ASSERT(l1e_get_flags(l2e_to_l1e(l2e)[l1_table_offset(sva)]) & >> -   

[PATCH v5] docs/designs: re-work the xenstore migration document...

2020-04-28 Thread Paul Durrant
From: Paul Durrant ... to specify a separate migration stream that will also be suitable for live update. The original scope of the document was to support non-cooperative migration of guests [1] but, since then, live update of xenstored has been brought into scope. Thus it makes more sense to d

Re: [PATCH] tools/xenstore: simplify socket initialization

2020-04-28 Thread Wei Liu
On Tue, Apr 28, 2020 at 04:58:37PM +0200, Juergen Gross wrote: > The setup of file descriptors for the Xenstore sockets is needlessly > complicated: the space is allocated dynamically, while two static > variables really would do the job. > > For tearing down the sockets it is easier to widen the

[PATCH] tools/xenstore: simplify socket initialization

2020-04-28 Thread Juergen Gross
The setup of file descriptors for the Xenstore sockets is needlessly complicated: the space is allocated dynamically, while two static variables really would do the job. For tearing down the sockets it is easier to widen the scope of the file descriptors from function to file. Signed-off-by: Juer

Re: [XEN PATCH v5 16/16] build, include: rework compat-build-header.py

2020-04-28 Thread Wei Liu
On 21/04/2020 17:12, Anthony PERARD wrote: Replace a mix of shell script and python script by all python script. No change to the final generated headers. Signed-off-by: Anthony PERARD To the best of my knowledge this patch is doing the right transformation. Acked-by: Wei Liu

Re: [PATCH v4] docs/designs: re-work the xenstore migration document...

2020-04-28 Thread Jürgen Groß
On 28.04.20 16:50, Paul Durrant wrote: -Original Message- From: Jürgen Groß Sent: 28 April 2020 13:56 To: p...@xen.org; 'Julien Grall' ; xen-devel@lists.xenproject.org Cc: 'Paul Durrant' ; 'Andrew Cooper' ; 'George Dunlap' ; 'Ian Jackson' ; 'Jan Beulich' ; 'Stefano Stabellini' ; 'Wei

RE: [PATCH v4] docs/designs: re-work the xenstore migration document...

2020-04-28 Thread Paul Durrant
> -Original Message- > From: Jürgen Groß > Sent: 28 April 2020 13:56 > To: p...@xen.org; 'Julien Grall' ; > xen-devel@lists.xenproject.org > Cc: 'Paul Durrant' ; 'Andrew Cooper' > ; 'George Dunlap' > ; 'Ian Jackson' ; 'Jan > Beulich' > ; 'Stefano Stabellini' ; 'Wei Liu' > > Subject: R

[xen-unstable-smoke test] 149857: tolerable all pass - PUSHED

2020-04-28 Thread osstest service owner
flight 149857 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/149857/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [XEN PATCH v5 16/16] build, include: rework compat-build-header.py

2020-04-28 Thread Jan Beulich
On 21.04.2020 18:12, Anthony PERARD wrote: > Replace a mix of shell script and python script by all python script. > > No change to the final generated headers. > > Signed-off-by: Anthony PERARD > --- > > Notes: > v5: > - Removed -P from CPP when generating compat/%.i > -> keep re

Re: [XEN PATCH v5 15/16] build, include: rework compat-build-source.py

2020-04-28 Thread Jan Beulich
On 21.04.2020 18:12, Anthony PERARD wrote: > Improvement are: > - give the path to xlat.lst as argument > - include `grep -v` in compat-build-source.py script, we don't need to > write this in several scripted language. > > No changes in final compat/%.h headers. > > Signed-off-by: Anthony PERA

RE: [PATCH] PCI: drop a redundant variable from pci_add_device()

2020-04-28 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 28 April 2020 14:00 > To: xen-devel@lists.xenproject.org > Cc: Paul Durrant > Subject: [PATCH] PCI: drop a redundant variable from pci_add_device() > > Surrounding code already uses the available alternative, after all. > > Signed-off-by:

Re: [XEN PATCH v5 08/16] build: Introduce $(cpp_flags)

2020-04-28 Thread Jan Beulich
On 28.04.2020 16:01, Anthony PERARD wrote: > On Thu, Apr 23, 2020 at 06:48:51PM +0200, Jan Beulich wrote: >> On 21.04.2020 18:12, Anthony PERARD wrote: >>> --- a/xen/Rules.mk >>> +++ b/xen/Rules.mk >>> @@ -123,6 +123,7 @@ $(obj-bin-y): XEN_CFLAGS := $(filter-out >>> -flto,$(XEN_CFLAGS)) >>> >>>

Re: [XEN PATCH v5 14/16] build: use if_changed to build mm/*/guest_%.o

2020-04-28 Thread Jan Beulich
On 21.04.2020 18:12, Anthony PERARD wrote: > Use if_changed for building all guest_%.o objects, and make use of > command that already exist. > > The current command only runs `CC`, but the runes to build every other > object in Xen also runs `objcopy` (when CONFIG_ENFORCE_UNIQUE_SYMBOLS=y) > whic

Re: [PATCH] PCI: drop a redundant variable from pci_add_device()

2020-04-28 Thread Andrew Cooper
On 28/04/2020 13:59, Jan Beulich wrote: > Surrounding code already uses the available alternative, after all. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper

Re: [XEN PATCH v5 13/16] xen,symbols: rework file symbols selection

2020-04-28 Thread Jan Beulich
On 21.04.2020 18:12, Anthony PERARD wrote: > We want to use the same rune to build mm/*/guest_*.o as the one use to > build every other *.o object. The consequence it that file symbols that > the program ./symbols prefer changes with CONFIG_ENFORCE_UNIQUE_SYMBOLS=y. > > For example, when building

Re: [XEN PATCH v5 08/16] build: Introduce $(cpp_flags)

2020-04-28 Thread Anthony PERARD
On Thu, Apr 23, 2020 at 06:48:51PM +0200, Jan Beulich wrote: > On 21.04.2020 18:12, Anthony PERARD wrote: > > --- a/xen/Rules.mk > > +++ b/xen/Rules.mk > > @@ -123,6 +123,7 @@ $(obj-bin-y): XEN_CFLAGS := $(filter-out > > -flto,$(XEN_CFLAGS)) > > > > c_flags = -MMD -MP -MF $(@D)/.$(@F).d $(XEN_C

Re: [XEN PATCH v5 11/16] xen/build: factorise generation of the linker scripts

2020-04-28 Thread Jan Beulich
On 21.04.2020 18:12, Anthony PERARD wrote: > In Arm and X86 makefile, generating the linker script is the same, so > we can simply have both call the same macro. > > We need to add *.lds files into extra-y so that Rules.mk can find the > .*.cmd dependency file and load it. > > Change made to the

Re: [XEN PATCH v5 09/16] xen/build: use if_changed on built_in.o

2020-04-28 Thread Jan Beulich
On 21.04.2020 18:12, Anthony PERARD wrote: > In the case where $(obj-y) is empty, we also replace $(c_flags) by > $(XEN_CFLAGS) to avoid generating an .%.d dependency file. This avoid > make trying to include %.h file in the ld command if $(obj-y) isn't > empty anymore on a second run. > > Signed-

[PATCH] PCI: drop a redundant variable from pci_add_device()

2020-04-28 Thread Jan Beulich
Surrounding code already uses the available alternative, after all. Signed-off-by: Jan Beulich --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -760,7 +760,6 @@ int pci_add_device(u16 seg, u8 bus, u8 d { unsigned int idx = pos + PCI_SRIOV_B

Re: [PATCH v4] docs/designs: re-work the xenstore migration document...

2020-04-28 Thread Jürgen Groß
On 28.04.20 14:46, Paul Durrant wrote: -Original Message- From: Julien Grall Sent: 28 April 2020 11:23 To: Jürgen Groß ; Paul Durrant ; xen-devel@lists.xenproject.org Cc: Paul Durrant ; Andrew Cooper ; George Dunlap ; Ian Jackson ; Jan Beulich ; Stefano Stabellini ; Wei Liu Subject:

RE: [PATCH v4] docs/designs: re-work the xenstore migration document...

2020-04-28 Thread Paul Durrant
> -Original Message- > From: Julien Grall > Sent: 28 April 2020 10:06 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Paul Durrant ; Juergen Gross ; > Andrew Cooper > ; George Dunlap ; Ian > Jackson > ; Jan Beulich ; Stefano > Stabellini > ; Wei Liu > Subject: Re: [PATCH v4]

RE: [PATCH v4] docs/designs: re-work the xenstore migration document...

2020-04-28 Thread Paul Durrant
> -Original Message- > From: Julien Grall > Sent: 28 April 2020 11:23 > To: Jürgen Groß ; Paul Durrant ; > xen-devel@lists.xenproject.org > Cc: Paul Durrant ; Andrew Cooper > ; George Dunlap > ; Ian Jackson ; Jan > Beulich ; > Stefano Stabellini ; Wei Liu > Subject: Re: [PATCH v4] docs

RE: [PATCH 1/2] Fix undefined behaviour

2020-04-28 Thread Paul Durrant
> -Original Message- > From: Paul Durrant > Sent: 28 April 2020 13:33 > To: 'Artur Puzio' ; 'Grzegorz Uriasz' > ; qemu-de...@nongnu.org > Cc: marma...@invisiblethingslab.com; ja...@bartmin.ski; > j.nowa...@student.uw.edu.pl; 'Stefano > Stabellini' ; 'Anthony Perard' > ; xen- > de...@lis

RE: [PATCH 1/2] Fix undefined behaviour

2020-04-28 Thread Paul Durrant
> -Original Message- > From: Artur Puzio > Sent: 28 April 2020 10:41 > To: p...@xen.org; 'Grzegorz Uriasz' ; > qemu-de...@nongnu.org > Cc: marma...@invisiblethingslab.com; ja...@bartmin.ski; > j.nowa...@student.uw.edu.pl; 'Stefano > Stabellini' ; 'Anthony Perard' > ; xen- > de...@lists.

RE: [PATCH] x86/pass-through: avoid double IRQ unbind during domain cleanup

2020-04-28 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 28 April 2020 13:22 > To: xen-devel@lists.xenproject.org > Cc: Paul Durrant ; Varad Gautam ; Andrew Cooper > ; Roger Pau Monné ; Wei Liu > > Subject: [PATCH] x86/pass-through: avoid double IRQ unbind during domain > cleanup > > XEN_DOMCT

[PATCH] x86/pass-through: avoid double IRQ unbind during domain cleanup

2020-04-28 Thread Jan Beulich
XEN_DOMCTL_destroydomain creates a continuation if domain_kill -ERESTARTs. In that scenario, it is possible to receive multiple _pirq_guest_unbind calls for the same pirq from domain_kill, if the pirq has not yet been removed from the domain's pirq_tree, as: domain_kill() -> domain_relinquish

Re: [PATCH v4] x86: irq: Do not BUG_ON multiple unbind calls for shared pirqs

2020-04-28 Thread Jan Beulich
On 28.04.2020 13:58, v...@amazon.com wrote: > On 3/10/20 3:19 PM, Jan Beulich wrote: >> On 09.03.2020 18:47, Paul Durrant wrote: >>> Please suggest code if you think it ought to be done differentely. I tried. >> How about this? It's admittedly more code, but imo less ad hoc. >> I've smoke tested it

Re: [PATCH v4] x86: irq: Do not BUG_ON multiple unbind calls for shared pirqs

2020-04-28 Thread vrd
Hi Jan, On 3/10/20 3:19 PM, Jan Beulich wrote: On 09.03.2020 18:47, Paul Durrant wrote: -Original Message- From: Jan Beulich Sent: 09 March 2020 16:29 To: p...@xen.org Cc: xen-devel@lists.xenproject.org; Varad Gautam ; Julien Grall ; Roger Pau Monné ; Andrew Cooper Subject: Re: [PATC

Re: [PATCH] mini-os: Avoid segfaults in tc{g,s}etattr

2020-04-28 Thread Andrew Cooper
On 28/04/2020 12:44, Jason Andryuk wrote: > From: Andrew Cooper > > Andrew Cooper wrote: >> On 28/04/2020 12:16, Wei Liu wrote: >> --- >> I can't get ioemu-stubdom to start without this. With this, the guest >> just reboots immediately, but it does that with a non-stubdom >> devic

Re: [PATCH] mini-os: Avoid segfaults in tc{g,s}etattr

2020-04-28 Thread Jason Andryuk
From: Andrew Cooper Andrew Cooper wrote: >On 28/04/2020 12:16, Wei Liu wrote: > --- > I can't get ioemu-stubdom to start without this. With this, the guest > just reboots immediately, but it does that with a non-stubdom > device_model_version="qemu-xen-traditional" . The same gu

Re: [PATCH] MAINTAINERS: list myself as mini-os reviewer

2020-04-28 Thread Wei Liu
On Tue, Apr 28, 2020 at 01:30:20PM +0200, Samuel Thibault wrote: > Wei Liu, le mar. 28 avril 2020 12:23:46 +0100, a ecrit: > > I probably don't have much time to actually review patches, but I do > > want to be CC'ed such that I can commit patches in a timely manner. > > > > Signed-off-by: Wei Liu

Re: [PATCH] MAINTAINERS: list myself as mini-os reviewer

2020-04-28 Thread Jan Beulich
On 28.04.2020 13:30, Samuel Thibault wrote: > Wei Liu, le mar. 28 avril 2020 12:23:46 +0100, a ecrit: >> I probably don't have much time to actually review patches, but I do >> want to be CC'ed such that I can commit patches in a timely manner. >> >> Signed-off-by: Wei Liu > > I actually thought

Re: [PATCH v7 08/12] xen: add /buildinfo/config entry to hypervisor filesystem

2020-04-28 Thread Jürgen Groß
On 28.04.20 13:23, George Dunlap wrote: On Apr 28, 2020, at 9:39 AM, Jan Beulich wrote: On 28.04.2020 10:24, George Dunlap wrote: On Apr 28, 2020, at 8:20 AM, Jan Beulich wrote: On 27.04.2020 18:25, George Dunlap wrote: If Jan is OK with it simply being outside CONFIG_EXPERT, then great.

Re: [PATCH] MAINTAINERS: list myself as mini-os reviewer

2020-04-28 Thread Samuel Thibault
Wei Liu, le mar. 28 avril 2020 12:23:46 +0100, a ecrit: > I probably don't have much time to actually review patches, but I do > want to be CC'ed such that I can commit patches in a timely manner. > > Signed-off-by: Wei Liu I actually thought you were already referenced there... Reviewed-by: Sa

Re: [PATCH] mini-os: Avoid segfaults in tc{g,s}etattr

2020-04-28 Thread Andrew Cooper
On 28/04/2020 12:16, Wei Liu wrote: --- I can't get ioemu-stubdom to start without this. With this, the guest just reboots immediately, but it does that with a non-stubdom device_model_version="qemu-xen-traditional" . The same guest disk image (cirros 0.5.1) boots with a

[PATCH] MAINTAINERS: list myself as mini-os reviewer

2020-04-28 Thread Wei Liu
I probably don't have much time to actually review patches, but I do want to be CC'ed such that I can commit patches in a timely manner. Signed-off-by: Wei Liu --- Cc: Samuel Thibault Cc: minios-de...@lists.xenproject.org --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINT

Re: [PATCH v7 08/12] xen: add /buildinfo/config entry to hypervisor filesystem

2020-04-28 Thread George Dunlap
> On Apr 28, 2020, at 9:39 AM, Jan Beulich wrote: > > On 28.04.2020 10:24, George Dunlap wrote: >>> On Apr 28, 2020, at 8:20 AM, Jan Beulich wrote: >>> On 27.04.2020 18:25, George Dunlap wrote: If Jan is OK with it simply being outside CONFIG_EXPERT, then great. But if he insists o

Re: [PATCH] mini-os: Avoid segfaults in tc{g,s}etattr

2020-04-28 Thread Wei Liu
On Mon, Apr 27, 2020 at 09:54:29AM +0200, Samuel Thibault wrote: > Jason Andryuk, le dim. 26 avril 2020 23:40:19 -0400, a ecrit: > > Commit c96c22f1d94 "mini-os: minimal implementations of some termios > > functions" introduced implementations of tcgetattr and tcsetattr. > > However, they do not ch

Re: [PATCH] mini-os: Avoid segfaults in tc{g,s}etattr

2020-04-28 Thread Wei Liu
On Mon, Apr 27, 2020 at 09:30:50AM -0400, Jason Andryuk wrote: > On Mon, Apr 27, 2020 at 3:54 AM Samuel Thibault > wrote: > > > > Jason Andryuk, le dim. 26 avril 2020 23:40:19 -0400, a ecrit: > > > Commit c96c22f1d94 "mini-os: minimal implementations of some termios > > > functions" introduced imp

[libvirt test] 149850: regressions - FAIL

2020-04-28 Thread osstest service owner
flight 149850 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/149850/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 146182 build-i386-libvirt

Re: [PATCH 1/2] Fix undefined behaviour

2020-04-28 Thread Artur Puzio
On 28.04.2020 10:10, Paul Durrant wrote: >> -Original Message- >> From: Grzegorz Uriasz >> Sent: 28 April 2020 07:29 >> To: qemu-de...@nongnu.org >> Cc: Grzegorz Uriasz ; marma...@invisiblethingslab.com; >> ar...@puzio.waw.pl; >> ja...@bartmin.ski; j.nowa...@student.uw.edu.pl; Stefano Sta

[linux-linus test] 149840: regressions - FAIL

2020-04-28 Thread osstest service owner
flight 149840 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/149840/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 149832 test-amd64-amd64-ex

Re: [PATCH v4] docs/designs: re-work the xenstore migration document...

2020-04-28 Thread Julien Grall
Hi Juergen, On 28/04/2020 11:10, Jürgen Groß wrote: On 28.04.20 11:05, Julien Grall wrote: -where tx_id is the non-zero identifier values of an open transaction. +| Field | Description   | +|---|---|

Re: [PATCH] xen/swiotlb: correct the check for xen_destroy_contiguous_region

2020-04-28 Thread Jürgen Groß
On 28.04.20 10:25, Peng Fan wrote: Subject: Re: [PATCH] xen/swiotlb: correct the check for xen_destroy_contiguous_region On 28.04.20 09:33, peng@nxp.com wrote: From: Peng Fan When booting xen on i.MX8QM, met: " [3.602128] Unable to handle kernel paging request at virtual address

Re: [PATCH v4] docs/designs: re-work the xenstore migration document...

2020-04-28 Thread Jürgen Groß
On 28.04.20 11:05, Julien Grall wrote: Hi Paul, On 27/04/2020 16:50, Paul Durrant wrote: diff --git a/docs/designs/xenstore-migration.md b/docs/designs/xenstore-migration.md index 6ab351e8fe..51d8b85171 100644 --- a/docs/designs/xenstore-migration.md +++ b/docs/designs/xenstore-migration.md @@

Re: [PATCH v7 08/12] xen: add /buildinfo/config entry to hypervisor filesystem

2020-04-28 Thread Julien Grall
Hi Jan, On 28/04/2020 10:59, Jan Beulich wrote: On 28.04.2020 11:43, Julien Grall wrote: Hi Jan, On 28/04/2020 09:39, Jan Beulich wrote: On 28.04.2020 10:24, George Dunlap wrote: On Apr 28, 2020, at 8:20 AM, Jan Beulich wrote: On 27.04.2020 18:25, George Dunlap wrote: If Jan is OK with it

Re: [PATCH v7 08/12] xen: add /buildinfo/config entry to hypervisor filesystem

2020-04-28 Thread Jan Beulich
On 28.04.2020 11:43, Julien Grall wrote: > Hi Jan, > > On 28/04/2020 09:39, Jan Beulich wrote: >> On 28.04.2020 10:24, George Dunlap wrote: On Apr 28, 2020, at 8:20 AM, Jan Beulich wrote: On 27.04.2020 18:25, George Dunlap wrote: > If Jan is OK with it simply being outside CONFIG_EX

Re: [PATCH] mem_sharing: map shared_info page to same gfn during fork

2020-04-28 Thread Roger Pau Monné
On Mon, Apr 27, 2020 at 09:36:05AM -0700, Tamas K Lengyel wrote: > During a VM fork we copy the shared_info page; however, we also need to ensure > that the page is mapped into the same GFN in the fork as its in the parent. > > Signed-off-by: Tamas K Lengyel > Suggested-by: Roger Pau Monne > ---

Re: [PATCH 01/12] libxc/save: Shrink code volume where possible

2020-04-28 Thread Wei Liu
On Mon, Apr 27, 2020 at 09:00:30PM +0100, Andrew Cooper wrote: > On 27/04/2020 20:55, Wei Liu wrote: > > On Mon, Apr 27, 2020 at 06:19:37PM +0100, Ian Jackson wrote: > >> Andrew Cooper writes ("Re: [PATCH 01/12] libxc/save: Shrink code volume > >> where possible"): > >>> On 14/01/2020 16:48, Ian J

Re: [PATCH v7 08/12] xen: add /buildinfo/config entry to hypervisor filesystem

2020-04-28 Thread Julien Grall
Hi Jan, On 28/04/2020 09:39, Jan Beulich wrote: On 28.04.2020 10:24, George Dunlap wrote: On Apr 28, 2020, at 8:20 AM, Jan Beulich wrote: On 27.04.2020 18:25, George Dunlap wrote: If Jan is OK with it simply being outside CONFIG_EXPERT, then great. But if he insists on some kind of testing

Re: [PATCH v4] docs/designs: re-work the xenstore migration document...

2020-04-28 Thread Julien Grall
Hi Paul, On 27/04/2020 16:50, Paul Durrant wrote: diff --git a/docs/designs/xenstore-migration.md b/docs/designs/xenstore-migration.md index 6ab351e8fe..51d8b85171 100644 --- a/docs/designs/xenstore-migration.md +++ b/docs/designs/xenstore-migration.md @@ -3,254 +3,400 @@ ## Background T

Re: [PATCH 1/2] Fix undefined behaviour

2020-04-28 Thread Peter Maydell
On Tue, 28 Apr 2020 at 08:50, Grzegorz Uriasz wrote: > > Signed-off-by: Grzegorz Uriasz > --- > hw/xen/xen_pt_load_rom.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) The subject doesn't match the patch contents and there is no long-form part of the commit message explaini

Re: [PATCH v7 08/12] xen: add /buildinfo/config entry to hypervisor filesystem

2020-04-28 Thread Jan Beulich
On 28.04.2020 10:24, George Dunlap wrote: >> On Apr 28, 2020, at 8:20 AM, Jan Beulich wrote: >> On 27.04.2020 18:25, George Dunlap wrote: >>> If Jan is OK with it simply being outside CONFIG_EXPERT, then great. But >>> if he insists on some kind of testing for it to be outside of >>> CONFIG_EXP

RE: [PATCH] xen/swiotlb: correct the check for xen_destroy_contiguous_region

2020-04-28 Thread Peng Fan
> Subject: Re: [PATCH] xen/swiotlb: correct the check for > xen_destroy_contiguous_region > > On 28.04.20 09:33, peng@nxp.com wrote: > > From: Peng Fan > > > > When booting xen on i.MX8QM, met: > > " > > [3.602128] Unable to handle kernel paging request at virtual address > 00272d

Re: [PATCH v7 08/12] xen: add /buildinfo/config entry to hypervisor filesystem

2020-04-28 Thread George Dunlap
> On Apr 28, 2020, at 8:20 AM, Jan Beulich wrote: > > On 27.04.2020 18:25, George Dunlap wrote: >> If Jan is OK with it simply being outside CONFIG_EXPERT, then great. But if >> he insists on some kind of testing for it to be outside of CONFIG_EXPERT, >> then again, the people who want it to

Re: [PATCH] x86/ioemul: Rewrite stub generation

2020-04-28 Thread Jan Beulich
On 28.04.2020 00:20, Andrew Cooper wrote: > On 27/04/2020 16:28, Jan Beulich wrote: >> On 27.04.2020 14:20, Andrew Cooper wrote: >>> The logic is completely undocumented and almost impossible to follow. It >>> actually uses return oriented programming. Rewrite it to conform to more >>> normal cal

RE: [PATCH] xen/swiotlb: correct the check for xen_destroy_contiguous_region

2020-04-28 Thread Peng Fan
> Subject: Re: [PATCH] xen/swiotlb: correct the check for > xen_destroy_contiguous_region > > On Tue, Apr 28, 2020 at 03:33:45PM +0800, peng@nxp.com wrote: > > > > In xen_swiotlb_alloc_coherent, if !(dev_addr + size - 1 <= dma_mask) > > or range_straddles_page_boundary(phys, size) are true, it

RE: [PATCH 1/2] Fix undefined behaviour

2020-04-28 Thread Paul Durrant
> -Original Message- > From: Grzegorz Uriasz > Sent: 28 April 2020 07:29 > To: qemu-de...@nongnu.org > Cc: Grzegorz Uriasz ; marma...@invisiblethingslab.com; > ar...@puzio.waw.pl; > ja...@bartmin.ski; j.nowa...@student.uw.edu.pl; Stefano Stabellini > ; Anthony > Perard ; Paul Durrant ;

Re: [PATCH] xen/swiotlb: correct the check for xen_destroy_contiguous_region

2020-04-28 Thread Jürgen Groß
On 28.04.20 09:33, peng@nxp.com wrote: From: Peng Fan When booting xen on i.MX8QM, met: " [3.602128] Unable to handle kernel paging request at virtual address 00272d40 [3.610804] Mem abort info: [3.613905] ESR = 0x9604 [3.617332] EC = 0x25: DABT (current EL)

Re: [PATCH] xen/swiotlb: correct the check for xen_destroy_contiguous_region

2020-04-28 Thread Christoph Hellwig
On Tue, Apr 28, 2020 at 03:33:45PM +0800, peng@nxp.com wrote: > > In xen_swiotlb_alloc_coherent, if !(dev_addr + size - 1 <= dma_mask) or > range_straddles_page_boundary(phys, size) are true, it will > create contiguous region. So when free, we need to free contiguous > region use upper check

Ping: [PATCH v3 0/5] (remaining) XSA-292 follow-up

2020-04-28 Thread Jan Beulich
Andrew, On 25.09.2019 17:19, Jan Beulich wrote: > 1: x86: suppress XPTI-related TLB flushes when possible > 2: x86/mm: honor opt_pcid also for 32-bit PV domains I realize these two weren't entirely uncontroversial. May I please ask that you get back to them, more than half a year after their post

[PATCH] xen/swiotlb: correct the check for xen_destroy_contiguous_region

2020-04-28 Thread peng . fan
From: Peng Fan When booting xen on i.MX8QM, met: " [3.602128] Unable to handle kernel paging request at virtual address 00272d40 [3.610804] Mem abort info: [3.613905] ESR = 0x9604 [3.617332] EC = 0x25: DABT (current EL), IL = 32 bits [3.623211] SET = 0, FnV

  1   2   >