[linux-linus test] 151372: regressions - FAIL

2020-06-26 Thread osstest service owner
flight 151372 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/151372/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-amd64 7 xen-boot fail REGR. vs. 151214 test-arm64-arm64-li

Re: ARM - Successful install on RockPro64

2020-06-26 Thread Richard Simpson
Hello Julien, I also have been busy and unable to reply. On 6/24/20 1:42 PM, Julien Grall wrote: On 17/06/2020 23:28, Richard Simpson wrote: Hello Julien, Hello Richard, Apologies for the late answer. I have just tried 4.14-rc2 and it seems to work fine. Glad to hear that. Thank you

[xen-unstable-smoke test] 151385: tolerable all pass - PUSHED

2020-06-26 Thread osstest service owner
flight 151385 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/151385/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[libvirt test] 151370: tolerable all pass - PUSHED

2020-06-26 Thread osstest service owner
flight 151370 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/151370/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 14 saverestore-support-checkfail like 151352 test-armhf-armhf-libvirt-raw 13 saveresto

[xen-4.12-testing test] 151367: regressions - FAIL

2020-06-26 Thread osstest service owner
flight 151367 xen-4.12-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/151367/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-prev 6 xen-build fail in 151341 REGR. vs. 150176 build-amd64-pr

Re: [PATCH v2 2/2] optee: allow plain TMEM buffers with NULL address

2020-06-26 Thread Julien Grall
(using paul xen.org's email) Hi, Apologies for the late answer. On 23/06/2020 22:09, Stefano Stabellini wrote: On Tue, 23 Jun 2020, Julien Grall wrote: On 23/06/2020 03:49, Volodymyr Babchuk wrote: Hi Stefano, Stefano Stabellini writes: On Fri, 19 Jun 2020, Volodymyr Babchuk wrote: Trus

Re: [PATCH v3 for-4.14] pvcalls: Document correctly and explicitely the padding for all arches

2020-06-26 Thread Julien Grall
Hi Ian, Thank you for your input! On 24/06/2020 13:04, Ian Jackson wrote: Julien Grall writes ("Re: [PATCH v3 for-4.14] pvcalls: Document correctly and explicitely the padding for all arches"): (+ Committers) ... As Jan and you disagree on the approach, I would like to get more input. To s

[PATCH fsgsbase v2 4/4] x86/fsgsbase: Fix Xen PV support

2020-06-26 Thread Andy Lutomirski
On Xen PV, SWAPGS doesn't work. Teach __rdfsbase_inactive() and __wrgsbase_inactive() to use rdmsrl()/wrmsrl() on Xen PV. The Xen pvop code will understand this and issue the correct hypercalls. Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: xen-devel@lists.xenproject.org Si

[PATCH 3/6] x86/entry/64/compat: Fix Xen PV SYSENTER frame setup

2020-06-26 Thread Andy Lutomirski
The SYSENTER frame setup was nonsense. It worked by accident because the normal code into which the Xen asm jumped (entry_SYSENTER_32/compat) threw away SP without touching the stack. entry_SYSENTER_compat was recently modified such that it relied on having a valid stack pointer, so now the Xen as

[xen-unstable-smoke test] 151380: tolerable all pass - PUSHED

2020-06-26 Thread osstest service owner
flight 151380 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/151380/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[PATCH] xsm: Drop trailing whitespace from build scripts

2020-06-26 Thread Andrew Cooper
Signed-off-by: Andrew Cooper --- CC: Daniel De Graaf --- xen/xsm/flask/policy/mkaccess_vector.sh | 26 +- xen/xsm/flask/policy/mkflask.sh | 32 2 files changed, 29 insertions(+), 29 deletions(-) diff --git a/xen/xsm/flask/policy/m

[PATCH] tools/configure: drop BASH configure variable

2020-06-26 Thread Andrew Cooper
This is a weird variable to have in the first place. The only user of it is XSM's CONFIG_SHELL, which opencodes a fallback to sh, and the only two scripts run with this are shebang sh anyway, so don't need bash in the first place. Make the mkflask.sh and mkaccess_vector.sh scripts executable, dro

Re: [PATCH] build: tweak variable exporting for make 3.82

2020-06-26 Thread Jan Beulich
On 26.06.2020 17:32, Bertrand Marquis wrote: > Hi Jan, > >> On 26 Jun 2020, at 16:02, Jan Beulich wrote: >> >> While I've been running into an issue here only because of an additional >> local change I'm carrying, to be able to override just the compiler in >> $(XEN_ROOT)/.config (rather than the

[seabios test] 151363: tolerable FAIL - PUSHED

2020-06-26 Thread osstest service owner
flight 151363 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/151363/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stopfail like 151340 test-amd64-amd64-xl-qemuu-win7-amd64 17 g

[PATCH for-4.14 v4] x86/tlb: fix assisted flush usage

2020-06-26 Thread Roger Pau Monne
Commit e9aca9470ed86 introduced a regression when avoiding sending IPIs for certain flush operations. Xen page fault handler (spurious_page_fault) relies on blocking interrupts in order to prevent handling TLB flush IPIs and thus preventing other CPUs from removing page tables pages. Switching to a

Preparing for the virtual XenSummit

2020-06-26 Thread George Dunlap
Hey all, The virtual Summit this year will be significantly different than an in-person conference. In an effort to make the event as useful as possible, I’m inviting people to join me for a brainstorming session on Monday, 29 June, at 3pm BST. The purpose would be to brainstorm how we can en

RE: [PATCH for-4.14 v3] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-26 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 26 June 2020 16:40 > To: xen-devel@lists.xenproject.org > Cc: p...@xen.org; Roger Pau Monne ; Andrew Cooper > ; > George Dunlap ; Ian Jackson > ; Jan Beulich > ; Julien Grall ; Stefano Stabellini > ; Wei > Liu > Subject: [PATCH for-4

[PATCH for-4.14 v3] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-26 Thread Roger Pau Monne
XENMEM_acquire_resource and it's related structure is currently inside a __XEN__ or __XEN_TOOLS__ guarded section to limit it's scope to the hypervisor or the toolstack only. This is wrong as the hypercall is already being used by the Linux kernel at least, and as such needs to be public. Also swi

[xen-unstable test] 151358: tolerable FAIL

2020-06-26 Thread osstest service owner
flight 151358 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/151358/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-vhd 15 guest-start/debian.repeat fail pass in 151334 Tests which did not succeed, but

Re: [PATCH] build: tweak variable exporting for make 3.82

2020-06-26 Thread Bertrand Marquis
Hi Jan, > On 26 Jun 2020, at 16:02, Jan Beulich wrote: > > While I've been running into an issue here only because of an additional > local change I'm carrying, to be able to override just the compiler in > $(XEN_ROOT)/.config (rather than the whole tool chain), in > config/StdGNU.mk: > > ifeq

Re: [PATCH] xen: introduce xen_vring_use_dma

2020-06-26 Thread Michael S. Tsirkin
On Thu, Jun 25, 2020 at 10:31:27AM -0700, Stefano Stabellini wrote: > On Wed, 24 Jun 2020, Michael S. Tsirkin wrote: > > On Wed, Jun 24, 2020 at 02:53:54PM -0700, Stefano Stabellini wrote: > > > On Wed, 24 Jun 2020, Michael S. Tsirkin wrote: > > > > On Wed, Jun 24, 2020 at 10:59:47AM -0700, Stefano

Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-26 Thread Jan Beulich
On 26.06.2020 17:03, Roger Pau Monné wrote: > On Fri, Jun 26, 2020 at 04:19:36PM +0200, Jan Beulich wrote: >> On 26.06.2020 15:40, Jan Beulich wrote: >>> On 25.06.2020 18:10, Roger Pau Monné wrote: On Thu, Jun 25, 2020 at 11:05:52AM +0200, Roger Pau Monné wrote: > On Wed, Jun 24, 2020 at 0

Re: [PATCH v2 for-4.14] x86/livepatch: Make livepatching compatible with CET Shadow Stacks

2020-06-26 Thread Andrew Cooper
On 26/06/2020 16:07, Ross Lagerwall wrote: > On 2020-06-26 15:46, Andrew Cooper wrote: >> On 26/06/2020 15:26, Jan Beulich wrote: >>> On 26.06.2020 15:59, Ross Lagerwall wrote: On 2020-06-26 13:24, Andrew Cooper wrote: > @@ -56,18 +57,48 @@ int arch_livepatch_safety_check(void) >

Re: [PATCH v2 for-4.14] x86/livepatch: Make livepatching compatible with CET Shadow Stacks

2020-06-26 Thread Ross Lagerwall
On 2020-06-26 15:46, Andrew Cooper wrote: > On 26/06/2020 15:26, Jan Beulich wrote: >> On 26.06.2020 15:59, Ross Lagerwall wrote: >>> On 2020-06-26 13:24, Andrew Cooper wrote: @@ -56,18 +57,48 @@ int arch_livepatch_safety_check(void) return -EBUSY; } -int arch_livep

Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-26 Thread Roger Pau Monné
On Fri, Jun 26, 2020 at 04:19:36PM +0200, Jan Beulich wrote: > On 26.06.2020 15:40, Jan Beulich wrote: > > On 25.06.2020 18:10, Roger Pau Monné wrote: > >> On Thu, Jun 25, 2020 at 11:05:52AM +0200, Roger Pau Monné wrote: > >>> On Wed, Jun 24, 2020 at 04:01:44PM +0200, Jan Beulich wrote: > On 2

[PATCH] build: tweak variable exporting for make 3.82

2020-06-26 Thread Jan Beulich
While I've been running into an issue here only because of an additional local change I'm carrying, to be able to override just the compiler in $(XEN_ROOT)/.config (rather than the whole tool chain), in config/StdGNU.mk: ifeq ($(filter-out default undefined,$(origin CC)),) I'd like to propose to

Re: [PATCH v2 for-4.14] x86/livepatch: Make livepatching compatible with CET Shadow Stacks

2020-06-26 Thread Jan Beulich
On 26.06.2020 16:46, Andrew Cooper wrote: > On 26/06/2020 15:26, Jan Beulich wrote: >> On 26.06.2020 15:59, Ross Lagerwall wrote: >>> On 2020-06-26 13:24, Andrew Cooper wrote: @@ -56,18 +57,48 @@ int arch_livepatch_safety_check(void) return -EBUSY; } -int arch_livep

Re: [PATCH for-4.14] changelog: Add notes about CET and Migration changes

2020-06-26 Thread Jan Beulich
On 26.06.2020 16:37, Andrew Cooper wrote: > Signed-off-by: Andrew Cooper In case wanted / needed: Acked-by: Jan Beulich Jan

Re: [PATCH v2 for-4.14] x86/livepatch: Make livepatching compatible with CET Shadow Stacks

2020-06-26 Thread Andrew Cooper
On 26/06/2020 15:26, Jan Beulich wrote: > On 26.06.2020 15:59, Ross Lagerwall wrote: >> On 2020-06-26 13:24, Andrew Cooper wrote: >>> @@ -56,18 +57,48 @@ int arch_livepatch_safety_check(void) >>> return -EBUSY; >>> } >>> >>> -int arch_livepatch_quiesce(void) >>> +int noinline arch_livepatch

RE: [PATCH for-4.14] changelog: Add notes about CET and Migration changes

2020-06-26 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper > Sent: 26 June 2020 15:38 > To: Xen-devel > Cc: Andrew Cooper ; George Dunlap > ; Ian > Jackson ; Jan Beulich ; Konrad > Rzeszutek Wilk > ; Stefano Stabellini ; Wei > Liu ; Julien > Grall ; Paul Durrant > Subject: [PATCH for-4.14] changelog:

[PATCH for-4.14] changelog: Add notes about CET and Migration changes

2020-06-26 Thread Andrew Cooper
Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Ian Jackson CC: Jan Beulich CC: Konrad Rzeszutek Wilk CC: Stefano Stabellini CC: Wei Liu CC: Julien Grall CC: Paul Durrant --- CHANGELOG.md | 9 + 1 file changed, 9 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index

RE: [PATCH for-4.14 v3] x86/tlb: fix assisted flush usage

2020-06-26 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monné > Sent: 26 June 2020 15:17 > To: Julien Grall > Cc: p...@xen.org; 'Jan Beulich' ; 'Andrew Cooper' > ; xen- > de...@lists.xenproject.org; 'Wei Liu' ; 'George Dunlap' > ; 'Ian > Jackson' ; 'Stefano Stabellini' > ; 'Volodymyr > Babchuk' > Subj

Re: [PATCH v2 for-4.14] x86/livepatch: Make livepatching compatible with CET Shadow Stacks

2020-06-26 Thread Jan Beulich
On 26.06.2020 15:59, Ross Lagerwall wrote: > On 2020-06-26 13:24, Andrew Cooper wrote: >> @@ -56,18 +57,48 @@ int arch_livepatch_safety_check(void) >> return -EBUSY; >> } >> >> -int arch_livepatch_quiesce(void) >> +int noinline arch_livepatch_quiesce(void) >> { >> +/* If Shadow Stacks

Re: [PATCH for-4.14 v3] x86/tlb: fix assisted flush usage

2020-06-26 Thread Jan Beulich
On 26.06.2020 16:16, Roger Pau Monné wrote: > On Fri, Jun 26, 2020 at 02:58:21PM +0100, Julien Grall wrote: >> On 26/06/2020 14:21, Paul Durrant wrote: -Original Message- From: Jan Beulich Sent: 26 June 2020 14:11 To: Roger Pau Monné ; p...@xen.org; Andrew Cooper

Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-26 Thread Jan Beulich
On 26.06.2020 15:40, Jan Beulich wrote: > On 25.06.2020 18:10, Roger Pau Monné wrote: >> On Thu, Jun 25, 2020 at 11:05:52AM +0200, Roger Pau Monné wrote: >>> On Wed, Jun 24, 2020 at 04:01:44PM +0200, Jan Beulich wrote: On 24.06.2020 15:41, Julien Grall wrote: > On 24/06/2020 11:12, Jan Beu

Re: [PATCH for-4.14 v3] x86/tlb: fix assisted flush usage

2020-06-26 Thread Roger Pau Monné
On Fri, Jun 26, 2020 at 02:58:21PM +0100, Julien Grall wrote: > On 26/06/2020 14:21, Paul Durrant wrote: > > > -Original Message- > > > From: Jan Beulich > > > Sent: 26 June 2020 14:11 > > > To: Roger Pau Monné ; p...@xen.org; Andrew Cooper > > > > > > Cc: Julien Grall ; xen-devel@lists.

Re: [PATCH v2 for-4.14] x86/livepatch: Make livepatching compatible with CET Shadow Stacks

2020-06-26 Thread Ross Lagerwall
On 2020-06-26 13:24, Andrew Cooper wrote: > Just like the alternatives infrastructure, the livepatch infrastructure > disables CR0.WP to perform patching, which is not permitted with CET active. > > Modify arch_livepatch_{quiesce,revive}() to disable CET before disabling WP, > and reset the dirty

Re: [PATCH for-4.14 v3] x86/tlb: fix assisted flush usage

2020-06-26 Thread Julien Grall
On 26/06/2020 14:21, Paul Durrant wrote: -Original Message- From: Jan Beulich Sent: 26 June 2020 14:11 To: Roger Pau Monné ; p...@xen.org; Andrew Cooper Cc: Julien Grall ; xen-devel@lists.xenproject.org; Wei Liu ; George Dunlap ; Ian Jackson ; Stefano Stabellini ; Volodymyr Babchu

Re: [PATCH for-4.14] mm: fix public declaration of struct xen_mem_acquire_resource

2020-06-26 Thread Jan Beulich
On 25.06.2020 18:10, Roger Pau Monné wrote: > On Thu, Jun 25, 2020 at 11:05:52AM +0200, Roger Pau Monné wrote: >> On Wed, Jun 24, 2020 at 04:01:44PM +0200, Jan Beulich wrote: >>> On 24.06.2020 15:41, Julien Grall wrote: On 24/06/2020 11:12, Jan Beulich wrote: > On 23.06.2020 19:26, Roger P

Re: [PATCH v3 7/7] tools/proctrace: add proctrace tool

2020-06-26 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH v3 7/7] tools/proctrace: add proctrace tool"): > On Mon, Jun 22, 2020 at 08:12:56PM +0200, Michał Leszczyński wrote: > > Add an demonstration tool that uses xc_vmtrace_* calls in order > > to manage external IPT monitoring for DomU. ... > > +if (rc) { > > +fp

RE: [PATCH v2 for-4.14] x86/livepatch: Make livepatching compatible with CET Shadow Stacks

2020-06-26 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 26 June 2020 14:15 > To: Andrew Cooper > Cc: Xen-devel ; Wei Liu ; Roger > Pau Monné > ; Konrad Rzeszutek Wilk ; Ross > Lagerwall > ; Pawel Wieczorkiewicz ; Paul > Durrant > Subject: Re: [PATCH v2 for-4.14] x86/livepatch: Make livepatch

RE: [PATCH for-4.14 v3] x86/tlb: fix assisted flush usage

2020-06-26 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 26 June 2020 14:11 > To: Roger Pau Monné ; p...@xen.org; Andrew Cooper > > Cc: Julien Grall ; xen-devel@lists.xenproject.org; Wei Liu > ; George Dunlap > ; Ian Jackson ; Stefano > Stabellini > ; Volodymyr Babchuk > Subject: Re: [PATCH f

Re: [PATCH v2 for-4.14] x86/livepatch: Make livepatching compatible with CET Shadow Stacks

2020-06-26 Thread Jan Beulich
On 26.06.2020 14:24, Andrew Cooper wrote: > Just like the alternatives infrastructure, the livepatch infrastructure > disables CR0.WP to perform patching, which is not permitted with CET active. > > Modify arch_livepatch_{quiesce,revive}() to disable CET before disabling WP, > and reset the dirty

[xen-unstable-smoke test] 151376: tolerable all pass - PUSHED

2020-06-26 Thread osstest service owner
flight 151376 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/151376/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH for-4.14 v3] x86/tlb: fix assisted flush usage

2020-06-26 Thread Jan Beulich
On 26.06.2020 12:07, Roger Pau Monné wrote: > On Fri, Jun 26, 2020 at 10:38:11AM +0100, Julien Grall wrote: >> Hi Roger, >> >> Sorry I didn't manage to answer to your question before you sent v3. >> >> On 25/06/2020 12:30, Roger Pau Monne wrote: >>> diff --git a/xen/include/asm-arm/flushtlb.h b/xen

Re: [PATCH v2 for-4.14] x86/msr: Disallow access to Processor Trace MSRs

2020-06-26 Thread Jan Beulich
On 26.06.2020 13:29, Andrew Cooper wrote: > We do not expose the feature to guests, so should disallow access to the > respective MSRs. For simplicity, drop the entire block of MSRs, not just the > subset which have been specified thus far. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beul

Re: [PATCH for-4.14] x86/livepatch: Make livepatching compatible with CET Shadow Stacks

2020-06-26 Thread Jan Beulich
On 26.06.2020 13:56, Andrew Cooper wrote: > On 15/06/2020 16:16, Jan Beulich wrote: > @@ -58,6 +59,10 @@ int arch_livepatch_safety_check(void) > > int arch_livepatch_quiesce(void) > { > +/* If Shadow Stacks are in use, disable CR4.CET so we can modify > CR0.WP. */ >

[PATCH v2 for-4.14] x86/livepatch: Make livepatching compatible with CET Shadow Stacks

2020-06-26 Thread Andrew Cooper
Just like the alternatives infrastructure, the livepatch infrastructure disables CR0.WP to perform patching, which is not permitted with CET active. Modify arch_livepatch_{quiesce,revive}() to disable CET before disabling WP, and reset the dirty bits on all virtual regions before re-enabling CET.

Re: [PATCH for-4.14] x86/livepatch: Make livepatching compatible with CET Shadow Stacks

2020-06-26 Thread Andrew Cooper
On 15/06/2020 16:16, Jan Beulich wrote: @@ -58,6 +59,10 @@ int arch_livepatch_safety_check(void) int arch_livepatch_quiesce(void) { +/* If Shadow Stacks are in use, disable CR4.CET so we can modify CR0.WP. */ +if ( cpu_has_xen_shstk ) +wr

Re: [PATCH v3 6/7] tools/libxl: add vmtrace_pt_size parameter

2020-06-26 Thread Wei Liu
On Mon, Jun 22, 2020 at 08:12:26PM +0200, Michał Leszczyński wrote: > Allow to specify the size of per-vCPU trace buffer upon > domain creation. This is zero by default (meaning: not enabled). > > Signed-off-by: Michal Leszczynski > --- > docs/man/xl.cfg.5.pod.in | 10 ++ > t

Re: [PATCH v3 5/7] tools/libxc: add xc_vmtrace_* functions

2020-06-26 Thread Wei Liu
On Mon, Jun 22, 2020 at 08:12:02PM +0200, Michał Leszczyński wrote: > Add functions in libxc that use the new HVMOP_vmtrace interface. > > Signed-off-by: Michal Leszczynski They look to be simple wrappers for hypercalls, so their acceptance will be dependent on the hypervisor side code. Wei.

Re: [PATCH v3 7/7] tools/proctrace: add proctrace tool

2020-06-26 Thread Wei Liu
On Mon, Jun 22, 2020 at 08:12:56PM +0200, Michał Leszczyński wrote: > Add an demonstration tool that uses xc_vmtrace_* calls in order > to manage external IPT monitoring for DomU. > > Signed-off-by: Michal Leszczynski > --- > tools/proctrace/COPYING | 339

Re: [PATCH v2 for-4.14] x86/msr: Disallow access to Processor Trace MSRs

2020-06-26 Thread Wei Liu
On Fri, Jun 26, 2020 at 12:29:37PM +0100, Andrew Cooper wrote: > We do not expose the feature to guests, so should disallow access to the > respective MSRs. For simplicity, drop the entire block of MSRs, not just the > subset which have been specified thus far. > > Signed-off-by: Andrew Cooper >

RE: [PATCH v2 for-4.14] x86/msr: Disallow access to Processor Trace MSRs

2020-06-26 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper > Sent: 26 June 2020 12:30 > To: Xen-devel > Cc: Andrew Cooper ; Jan Beulich > ; Wei Liu ; > Roger Pau Monné ; Paul Durrant ; Michał > Leszczyński > > Subject: [PATCH v2 for-4.14] x86/msr: Disallow access to Processor Trace MSRs > > We do not

Re: [PATCH v2 00/10] Coverity fixes for vchan-socket-proxy

2020-06-26 Thread Wei Liu
On Fri, Jun 26, 2020 at 01:12:01PM +0200, Marek Marczykowski-Górecki wrote: > On Fri, Jun 26, 2020 at 10:18:07AM +, Wei Liu wrote: > > On Wed, Jun 10, 2020 at 11:29:26PM -0400, Jason Andryuk wrote: > > > This series addresses some Coverity reports. To handle closing FDs, a > > > state struct i

[PATCH v2 for-4.14] x86/msr: Disallow access to Processor Trace MSRs

2020-06-26 Thread Andrew Cooper
We do not expose the feature to guests, so should disallow access to the respective MSRs. For simplicity, drop the entire block of MSRs, not just the subset which have been specified thus far. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné CC: Paul Durrant C

RE: [PATCH] libxl: tooling expects wrong errno

2020-06-26 Thread Paul Durrant
> -Original Message- > From: Wei Liu > Sent: 26 June 2020 12:25 > To: Ian Jackson > Cc: p...@xen.org; Roger Pau Monne ; 'Grzegorz Uriasz' > ; 'Jan > Beulich' ; Andrew Cooper ; > Kevin Tian > ; 'Wei Liu' ; ja...@bartmin.ski; > marma...@invisiblethingslab.com; > j.nowa...@student.uw.edu.

Re: [PATCH] libxl: tooling expects wrong errno

2020-06-26 Thread Wei Liu
On Mon, Jun 15, 2020 at 06:39:30PM +0100, Ian Jackson wrote: > Paul Durrant writes ("RE: [PATCH] libxl: tooling expects wrong errno"): > > > -Original Message- > > > From: Ian Jackson > > > Thanks for the analysis. So: > > > > > > Acked-by: Ian Jackson > > > > > > This would seem to be

[qemu-mainline test] 151353: regressions - FAIL

2020-06-26 Thread osstest service owner
flight 151353 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/151353/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-xsm 12 guest-start fail REGR. vs. 151065 test-amd64-i386-q

Re: [PATCH v2 00/10] Coverity fixes for vchan-socket-proxy

2020-06-26 Thread Marek Marczykowski-Górecki
On Fri, Jun 26, 2020 at 10:18:07AM +, Wei Liu wrote: > On Wed, Jun 10, 2020 at 11:29:26PM -0400, Jason Andryuk wrote: > > This series addresses some Coverity reports. To handle closing FDs, a > > state struct is introduced to track FDs closed in both main() and > > data_loop(). > > > > v2 cha

Re: Kexec and libxenctlr.so

2020-06-26 Thread Wei Liu
On Thu, Jun 11, 2020 at 03:57:37PM +0100, Julien Grall wrote: > Hi all, > > kexec-tools has an option to load dynamically libxenctlr.so (not .so.4.x) > (see [1]). > > Given that the library has never been considered stable, it is probably a > disaster that is waiting to happen. > > Looking at th

Re: [PATCH for-4.14 v2 2/2] x86/passthrough: introduce a flag for GSIs not requiring an EOI or unmask

2020-06-26 Thread Wei Liu
On Wed, Jun 10, 2020 at 04:29:23PM +0200, Roger Pau Monne wrote: > There's no need to setup a timer for GSIs that are edge triggered, > since those don't require any EIO or unmask, and hence couldn't block One small nit. I think you meant "EOI" here.

RE: [PATCH v2 00/10] Coverity fixes for vchan-socket-proxy

2020-06-26 Thread Paul Durrant
> -Original Message- > From: Wei Liu > Sent: 26 June 2020 11:18 > To: Jason Andryuk > Cc: xen-devel@lists.xenproject.org; Ian Jackson ; > Wei Liu ; > Paul Durrant ; marma...@invisiblethingslab.com > Subject: Re: [PATCH v2 00/10] Coverity fixes for vchan-socket-proxy > > On Wed, Jun 10,

Re: [PATCH v1] kdd: remove zero-length arrays

2020-06-26 Thread Wei Liu
On Fri, Jun 26, 2020 at 11:31:48AM +0100, Paul Durrant wrote: > > -Original Message- > > From: Wei Liu > > Sent: 26 June 2020 11:27 > > To: p...@xen.org > > Cc: 'Christopher Clark' ; 'Olaf Hering' > > ; 'Tim Deegan' > > ; 'xen-devel' ; 'Ian Jackson' > > ; 'Wei Liu' > > Subject: Re: [PATC

RE: [PATCH v1] kdd: remove zero-length arrays

2020-06-26 Thread Paul Durrant
> -Original Message- > From: Wei Liu > Sent: 26 June 2020 11:27 > To: p...@xen.org > Cc: 'Christopher Clark' ; 'Olaf Hering' > ; 'Tim Deegan' > ; 'xen-devel' ; 'Ian Jackson' > ; 'Wei Liu' > Subject: Re: [PATCH v1] kdd: remove zero-length arrays > > On Wed, Jun 17, 2020 at 09:21:22AM +01

Re: [PATCH v1] kdd: remove zero-length arrays

2020-06-26 Thread Wei Liu
On Wed, Jun 17, 2020 at 09:21:22AM +0100, Paul Durrant wrote: > > -Original Message- > > From: Christopher Clark > > Sent: 16 June 2020 21:50 > > To: Olaf Hering > > Cc: Tim Deegan ; xen-devel ; > > Ian Jackson > > ; Wei Liu ; p...@xen.org > > Subject: Re: [PATCH v1] kdd: remove zero-len

Re: [PATCH v2 00/10] Coverity fixes for vchan-socket-proxy

2020-06-26 Thread Wei Liu
On Wed, Jun 10, 2020 at 11:29:26PM -0400, Jason Andryuk wrote: > This series addresses some Coverity reports. To handle closing FDs, a > state struct is introduced to track FDs closed in both main() and > data_loop(). > > v2 changes "Ensure UNIX path NUL terminated" to avoid a warning with > gcc-

Re: [PATCH for-4.14 v3] x86/tlb: fix assisted flush usage

2020-06-26 Thread Roger Pau Monné
On Fri, Jun 26, 2020 at 10:38:11AM +0100, Julien Grall wrote: > Hi Roger, > > Sorry I didn't manage to answer to your question before you sent v3. > > On 25/06/2020 12:30, Roger Pau Monne wrote: > > diff --git a/xen/include/asm-arm/flushtlb.h b/xen/include/asm-arm/flushtlb.h > > index ab1aae5c90.

Re: [PATCH for-4.14 v3] x86/tlb: fix assisted flush usage

2020-06-26 Thread Julien Grall
Hi Roger, Sorry I didn't manage to answer to your question before you sent v3. On 25/06/2020 12:30, Roger Pau Monne wrote: diff --git a/xen/include/asm-arm/flushtlb.h b/xen/include/asm-arm/flushtlb.h index ab1aae5c90..7ae0543885 100644 --- a/xen/include/asm-arm/flushtlb.h +++ b/xen/include/asm-

Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation]

2020-06-26 Thread Roger Pau Monné
On Thu, Jun 25, 2020 at 06:36:59PM +, Anchal Agarwal wrote: > On Tue, Jun 23, 2020 at 10:19:03AM +0200, Roger Pau Monné wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender and know > > the con

RE: [PATCH] scripts: don't rely on "stat -" support

2020-06-26 Thread Paul Durrant
> -Original Message- > From: Ian Jackson > Sent: 25 June 2020 17:36 > To: Jason Andryuk > Cc: Jan Beulich ; Paul Durrant ; > xen-devel@lists.xenproject.org; Wei > Liu > Subject: Re: [PATCH] scripts: don't rely on "stat -" support > > Jason Andryuk writes ("Re: [PATCH] scripts: don't re