[xen-unstable-smoke test] 155287: regressions - FAIL

2020-10-01 Thread osstest service owner
flight 155287 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/155287/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt 12 guest-start fail REGR. vs. 155128 Tests which

Re: [PATCH v3] tools/libs/stat: fix broken build

2020-10-01 Thread Jürgen Groß
On 01.10.20 18:38, Bertrand Marquis wrote: Hi Juergen, On 14 Sep 2020, at 11:58, Bertrand Marquis wrote: On 12 Sep 2020, at 14:08, Juergen Gross wrote: Making getBridge() static triggered a build error with some gcc versions: error: 'strncpy' output may be truncated copying 15 bytes

Re: Ping: [PATCH 0/6] tools/include: adjustments to the population of xen/

2020-10-01 Thread Jürgen Groß
On 01.10.20 18:43, Bertrand Marquis wrote: Hi, On 1 Oct 2020, at 17:29, Bertrand Marquis wrote: Hi Jan, On 1 Oct 2020, at 17:03, Jan Beulich wrote: On 10.09.2020 14:09, Jan Beulich wrote: While looking at what it would take to move around libelf/ in the hypervisor subtree, I've run into

[xen-4.12-testing test] 155152: regressions - FAIL

2020-10-01 Thread osstest service owner
flight 155152 xen-4.12-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/155152/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 12 guest-start fail REGR. vs. 154601

[xen-unstable-smoke bisection] complete test-amd64-amd64-libvirt

2020-10-01 Thread osstest service owner
branch xen-unstable-smoke xenbranch xen-unstable-smoke job test-amd64-amd64-libvirt testid guest-start Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware

[xen-unstable-smoke test] 155271: regressions - FAIL

2020-10-01 Thread osstest service owner
flight 155271 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/155271/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt 12 guest-start fail REGR. vs. 155128 Tests which

[xen-4.11-testing test] 155140: regressions - FAIL

2020-10-01 Thread osstest service owner
flight 155140 xen-4.11-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/155140/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs.

[PATCH] libxl: only query VNC when enabled

2020-10-01 Thread Jason Andryuk
QEMU without VNC support (configure --disable-vnc) will return an error when VNC is queried over QMP since it does not recognize the QMP command. This will cause libxl to fail starting the domain even if VNC is not enabled. Therefore only query QEMU for VNC support when using VNC, so a VNC-less

Re: [PATCH] arm,smmu: match start level of page table walk with P2M

2020-10-01 Thread Stefano Stabellini
On Mon, 28 Sep 2020, laurentiu.tu...@nxp.com wrote: > From: Laurentiu Tudor > > Don't hardcode the lookup start level of the page table walk to 1 > and instead match the one used in P2M. This should fix scenarios > involving SMMU where the start level is different than 1. > > Signed-off-by:

[xen-unstable-smoke test] 155262: regressions - FAIL

2020-10-01 Thread osstest service owner
flight 155262 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/155262/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt 12 guest-start fail REGR. vs. 155128 Tests which

Re: [PATCH RFC] docs: Add minimum version depencency policy document

2020-10-01 Thread Stefano Stabellini
On Thu, 1 Oct 2020, George Dunlap wrote: > > On Sep 30, 2020, at 9:23 PM, Stefano Stabellini > > wrote: > > > > On Wed, 30 Sep 2020, George Dunlap wrote: > >> Define a specific criteria for how we determine what tools and > >> libraries to be compatible with. This will clarify issues such as,

[xen-unstable-smoke test] 155246: regressions - FAIL

2020-10-01 Thread osstest service owner
flight 155246 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/155246/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt 12 guest-start fail REGR. vs. 155128 Tests which

[seabios test] 155136: tolerable FAIL - PUSHED

2020-10-01 Thread osstest service owner
flight 155136 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/155136/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stopfail like 155049 test-amd64-amd64-xl-qemuu-ws16-amd64 17

[xen-4.13-testing test] 155132: regressions - FAIL

2020-10-01 Thread osstest service owner
flight 155132 xen-4.13-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/155132/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-xsm 12 guest-start fail REGR. vs. 154358

Re: [PATCH] evtchn/Flask: pre-allocate node on send path

2020-10-01 Thread Jason Andryuk
On Thu, Oct 1, 2020 at 12:05 PM Julien Grall wrote: > > Hi, > > On 24/09/2020 11:53, Jan Beulich wrote: > > xmalloc() & Co may not be called with IRQs off, or else check_lock() > > will have its assertion trigger about locks getting acquired > > inconsistently. Re-arranging the locking in

[xen-unstable bisection] complete test-amd64-amd64-xl-xsm

2020-10-01 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-xl-xsm testid guest-start Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu

Re: Ping: [PATCH 0/6] tools/include: adjustments to the population of xen/

2020-10-01 Thread Bertrand Marquis
Hi, > On 1 Oct 2020, at 17:29, Bertrand Marquis wrote: > > Hi Jan, > >> On 1 Oct 2020, at 17:03, Jan Beulich wrote: >> >> On 10.09.2020 14:09, Jan Beulich wrote: >>> While looking at what it would take to move around libelf/ >>> in the hypervisor subtree, I've run into this rule, which I >>>

Re: [PATCH v3] tools/libs/stat: fix broken build

2020-10-01 Thread Bertrand Marquis
Hi Juergen, > On 14 Sep 2020, at 11:58, Bertrand Marquis wrote: > > > >> On 12 Sep 2020, at 14:08, Juergen Gross wrote: >> >> Making getBridge() static triggered a build error with some gcc versions: >> >> error: 'strncpy' output may be truncated copying 15 bytes from a string of >> length

Re: Ping: [PATCH 0/6] tools/include: adjustments to the population of xen/

2020-10-01 Thread Bertrand Marquis
Hi Jan, > On 1 Oct 2020, at 17:03, Jan Beulich wrote: > > On 10.09.2020 14:09, Jan Beulich wrote: >> While looking at what it would take to move around libelf/ >> in the hypervisor subtree, I've run into this rule, which I >> think can do with a few improvements and some simplification. >> >>

[OSSTEST PATCH 8/8] Tolerate lack of platform-specific hosts in old Xen branches

2020-10-01 Thread Ian Jackson
Right now we have a situation where these can't all be made to work because because some older Xen branches are hard to make work on current Debian stable, and we have some hardware (which we have tagged as specific "platforms") which doesn't work with oldstable. This seems like a general

[OSSTEST PATCH 4/8] ts-hosts-allocate-Executive: Allow to tolerate missing resources

2020-10-01 Thread Ian Jackson
Now, a job can specify that lack of a suitable host should be treated as a plain test failure (ie, subject to the usual regression analysis) rather than as an infrastructure or configuration problem. This will be useful for some tests which don't work in some branches because of lack of suitable

[OSSTEST PATCH 7/8] standalone-generate-dump-flight-runvars: Simulate cri-getplatforms

2020-10-01 Thread Ian Jackson
Set MF_SIMULATE_PLATFORMS to a suitable value if it is not *set*. (Distinguishing unset from set to empty.) I have verified that this, plus the preceding commits to cri-getplatforms, produces no change in the output of MF_SIMULATE_PLATFORMS='' OSSTEST_CONFIG=standalone-config-example eatmydata

[OSSTEST PATCH 6/8] cri-getplatforms: Honour new MF_SIMULATE_PLATFORMS env var

2020-10-01 Thread Ian Jackson
This is to be expanded by the shell, using eval, so that it can refer to $xenarch, $suite and $blessing. No functional change if this variable is unset, or empty. If it is set to a single space, cri-getplatforms produces no output (as it does anyway in standalone mode). Signed-off-by: Ian

[OSSTEST PATCH 1/8] Executive: Fix an undef warning message

2020-10-01 Thread Ian Jackson
$onhost can be undef too Signed-off-by: Ian Jackson --- Osstest/Executive.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm index 80e70070..a0d9f81e 100644 --- a/Osstest/Executive.pm +++ b/Osstest/Executive.pm @@ -1283,7 +1283,8

[OSSTEST PATCH 2/8] standalone: Use mkdir -p

2020-10-01 Thread Ian Jackson
These two mkdir calls could fail if standalone-generate-dump-flight-runvars is run without a log directory, because they were not concurrency-correct. mkdir -p should fix that. Signed-off-by: Ian Jackson --- standalone | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git

[OSSTEST PATCH 5/8] cri-getplatforms: Give names to xenarch and suite

2020-10-01 Thread Ian Jackson
No functional change. This will be useful in a moment. Signed-off-by: Ian Jackson --- cri-getplatforms | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cri-getplatforms b/cri-getplatforms index 2b8cee0b..1f206908 100755 --- a/cri-getplatforms +++ b/cri-getplatforms @@

[OSSTEST PATCH 3/8] sg-run-job: Preserve step state "fail" if set by test script

2020-10-01 Thread Ian Jackson
If the test script exits nonzero but after setting the step status to 'fail', we can leave it that way. This is particularly relevant if the iffail in the job spec says 'broken' or something. After this change, a step can decide to override that. An alternative would be to have the step script

Re: [PATCH 11/12] evtchn: convert vIRQ lock to an r/w one

2020-10-01 Thread Julien Grall
Hi Jan, On 30/09/2020 11:16, Jan Beulich wrote: On 30.09.2020 10:52, Paul Durrant wrote: Looking again, given that both send_guest_vcpu_virq() and send_guest_global_virq() (rightly) hold the evtchn lock before calling evtchn_port_set_pending() I think you could do away with the virq lock by

Re: [PATCH v2 3/3] tools/lixenguest: hide struct elf_dom_parms layout from users

2020-10-01 Thread Bertrand Marquis
Hi Juergen, > On 25 Sep 2020, at 07:20, Juergen Gross wrote: > > Don't include struct elf_dom_parms in struct xc_dom_image, but rather > use a pointer to reference it. Together with adding accessor functions > for the externally needed elements this enables to drop including the > Xen private

Re: [PATCH] evtchn/Flask: pre-allocate node on send path

2020-10-01 Thread Julien Grall
Hi, On 24/09/2020 11:53, Jan Beulich wrote: xmalloc() & Co may not be called with IRQs off, or else check_lock() will have its assertion trigger about locks getting acquired inconsistently. Re-arranging the locking in evtchn_send() doesn't seem very reasonable, especially since the per-channel

Ping: [PATCH 0/6] tools/include: adjustments to the population of xen/

2020-10-01 Thread Jan Beulich
On 10.09.2020 14:09, Jan Beulich wrote: > While looking at what it would take to move around libelf/ > in the hypervisor subtree, I've run into this rule, which I > think can do with a few improvements and some simplification. > > 1: adjust population of acpi/ > 2: fix (drop) dependencies of when

Re: [PATCH 07/12] evtchn: cut short evtchn_reset()'s loop in the common case

2020-10-01 Thread Julien Grall
Hi, On 28/09/2020 12:00, Jan Beulich wrote: The general expectation is that there are only a few open ports left when a domain asks its event channel configuration to be reset. Similarly on average half a bucket worth of event channels can be expected to be inactive. Try to avoid iterating over

Re: [PATCH RFC] docs: Add minimum version depencency policy document

2020-10-01 Thread Roger Pau Monné
On Wed, Sep 30, 2020 at 01:57:36PM +0100, George Dunlap wrote: > Define a specific criteria for how we determine what tools and > libraries to be compatible with. This will clarify issues such as, > "Should we continue to support Python 2.4" moving forward. > > Note that CentOS 7 is set to stop

Re: [PATCH 4/4] xen/arm: Introduce fw_unreserved_regions() and use it

2020-10-01 Thread Julien Grall
Hi Stefano, On 01/10/2020 00:40, Stefano Stabellini wrote: On Sat, 26 Sep 2020, Julien Grall wrote: I have a small suggestion for improvement that could be done on commit: given that bootinfo is actually used on EFI systems (granted, not bootinfo.reserved_mem but bootinfo.mem, see

Re: [PATCH v9 8/8] tools/libxc: add DOMAIN_CONTEXT records to the migration stream...

2020-10-01 Thread Andrew Cooper
On 24/09/2020 14:10, Paul Durrant wrote: > From: Paul Durrant > > ... and bump the version. > > This patch implements version 4 of the migration stream by adding the code > necessary to save and restore DOMAIN_CONTEXT records, and removing the code > to save the SHARED_INFO and TSC_INFO records

Re: [PATCH 2/4] xen/arm: acpi: The fixmap area should always be cleared during failure/unmap

2020-10-01 Thread Julien Grall
Hi Stefano, On 01/10/2020 01:30, Stefano Stabellini wrote: On Sat, 26 Sep 2020, Julien Grall wrote: From: Julien Grall Commit 022387ee1ad3 "xen/arm: mm: Don't open-code Xen PT update in {set, clear}_fixmap()" enforced that each set_fixmap() should be paired with a clear_fixmap(). Any failure

Re: [PATCH 1/4] xen/acpi: Rework acpi_os_map_memory() and acpi_os_unmap_memory()

2020-10-01 Thread Julien Grall
Hi Stefano, On 01/10/2020 01:06, Stefano Stabellini wrote: On Sat, 26 Sep 2020, Julien Grall wrote: From: Julien Grall The functions acpi_os_{un,}map_memory() are meant to be arch-agnostic while the __acpi_os_{un,}map_memory() are meant to be arch-specific. Currently, the former are still

Re: [PATCH RFC] docs: Add minimum version depencency policy document

2020-10-01 Thread George Dunlap
> On Oct 1, 2020, at 1:58 PM, Andrew Cooper wrote: > > On 30/09/2020 13:57, George Dunlap wrote: >> Define a specific criteria for how we determine what tools and >> libraries to be compatible with. This will clarify issues such as, >> "Should we continue to support Python 2.4" moving

[xen-unstable-smoke test] 155225: regressions - FAIL

2020-10-01 Thread osstest service owner
flight 155225 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/155225/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt 12 guest-start fail REGR. vs. 155128 Tests which

Re: [XEN PATCH v14 7/8] Add IOREQ_TYPE_VMWARE_PORT

2020-10-01 Thread Jan Beulich
On 19.08.2020 18:52, Don Slutz wrote: > This adds synchronization of the 6 vcpu registers (only 32bits of > them) that QEMU's vmport.c and vmmouse.c needs between Xen and QEMU. > This is how VMware defined the use of these registers. > > This is to avoid a 2nd and 3rd exchange between QEMU and

Re: [PATCH RFC] docs: Add minimum version depencency policy document

2020-10-01 Thread Bertrand Marquis
Hi George, + Christopher Clark to have his view on what to put for Yocto. > On 30 Sep 2020, at 13:57, George Dunlap wrote: > > Define a specific criteria for how we determine what tools and > libraries to be compatible with. This will clarify issues such as, > "Should we continue to support

Re: Boot crash due to "x86/msi: Consolidate MSI allocation"

2020-10-01 Thread Thomas Gleixner
Yan, On Thu, Oct 01 2020 at 09:39, Zi Yan wrote: > On 1 Oct 2020, at 4:22, Thomas Gleixner wrote: >> Can you please test: >> >>git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/irq >> >> which contains fixes and if it still crashes provide the dmesg of it. > > My system boots

Re: Boot crash due to "x86/msi: Consolidate MSI allocation"

2020-10-01 Thread Zi Yan
On 1 Oct 2020, at 4:22, Thomas Gleixner wrote: > Yan, > > On Wed, Sep 30 2020 at 21:29, Zi Yan wrote: >> I am running linux-next on my Dell R630 and the system crashed at boot >> time. I bisected linux-next and got to your commit: >> >> x86/msi: Consolidate MSI allocation >> >> The crash log

[linux-linus test] 155125: regressions - FAIL

2020-10-01 Thread osstest service owner
flight 155125 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/155125/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 6 xen-install fail REGR. vs. 152332

Re: [XEN PATCH v14 5/8] xen: Add vmware_port support

2020-10-01 Thread Jan Beulich
On 19.08.2020 18:51, Don Slutz wrote: > --- a/xen/arch/x86/domain.c > +++ b/xen/arch/x86/domain.c > @@ -504,6 +504,8 @@ int arch_sanitise_domain_config(struct > xen_domctl_createdomain *config) > > static bool emulation_flags_ok(const struct domain *d, uint32_t emflags) > { > +uint32_t

Re: [PATCH RFC] docs: Add minimum version depencency policy document

2020-10-01 Thread Andrew Cooper
On 30/09/2020 13:57, George Dunlap wrote: > Define a specific criteria for how we determine what tools and > libraries to be compatible with. This will clarify issues such as, > "Should we continue to support Python 2.4" moving forward. Luckily that one is settled.  Arguably a better option

Re: [PATCH v3 01/11] xen/manage: keep track of the on-going suspend mode

2020-10-01 Thread boris . ostrovsky
>>> Also, wrt KASLR stuff, that issue is still seen sometimes but I haven't >>> had >>> bandwidth to dive deep into the issue and fix it. So what's the plan there? You first mentioned this issue early this year and judged by your response it is not clear whether you will

Re: Yet another S3 issue in Xen 4.14

2020-10-01 Thread Andrew Cooper
On 01/10/2020 13:31, Marek Marczykowski-Górecki wrote: > On Thu, Oct 01, 2020 at 01:59:32PM +0200, Jan Beulich wrote: >> On 01.10.2020 03:12, Marek Marczykowski-Górecki wrote: >>> After patching the previous issue ("x86/S3: Fix Shadow Stack resume >>> path") I still encounter issues resume from

Re: Yet another S3 issue in Xen 4.14

2020-10-01 Thread Marek Marczykowski-Górecki
On Thu, Oct 01, 2020 at 01:59:32PM +0200, Jan Beulich wrote: > On 01.10.2020 03:12, Marek Marczykowski-Górecki wrote: > > After patching the previous issue ("x86/S3: Fix Shadow Stack resume > > path") I still encounter issues resume from S3. > > Since I had it working on Xen 4.13 on this

[xen-4.10-testing test] 155126: regressions - trouble: broken/fail/pass

2020-10-01 Thread osstest service owner
flight 155126 xen-4.10-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/155126/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-thunderx broken

Re: Yet another S3 issue in Xen 4.14

2020-10-01 Thread Jan Beulich
On 01.10.2020 14:00, Marek Marczykowski-Górecki wrote: > On Thu, Oct 01, 2020 at 03:12:47AM +0200, Marek Marczykowski-Górecki wrote: >> After patching the previous issue ("x86/S3: Fix Shadow Stack resume >> path") I still encounter issues resume from S3. >> Since I had it working on Xen 4.13 on

Re: Yet another S3 issue in Xen 4.14

2020-10-01 Thread Marek Marczykowski-Górecki
On Thu, Oct 01, 2020 at 03:12:47AM +0200, Marek Marczykowski-Górecki wrote: > Hi, > > After patching the previous issue ("x86/S3: Fix Shadow Stack resume > path") I still encounter issues resume from S3. > Since I had it working on Xen 4.13 on this particular hardware (Thinkpad > P52), I bisected

Re: Yet another S3 issue in Xen 4.14

2020-10-01 Thread Jan Beulich
On 01.10.2020 03:12, Marek Marczykowski-Górecki wrote: > After patching the previous issue ("x86/S3: Fix Shadow Stack resume > path") I still encounter issues resume from S3. > Since I had it working on Xen 4.13 on this particular hardware (Thinkpad > P52), I bisected it and got this: > > commit

Re: [PATCH] xen/domain: check IOMMU options doesn't contain unknown bits set

2020-10-01 Thread Jan Beulich
On 01.10.2020 13:44, Roger Pau Monne wrote: > Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich

[PATCH] xen/domain: check IOMMU options doesn't contain unknown bits set

2020-10-01 Thread Roger Pau Monne
Signed-off-by: Roger Pau Monné --- xen/common/domain.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/xen/common/domain.c b/xen/common/domain.c index 8cfa2e0b6b..c4a480fa14 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -310,6 +310,12 @@ static int

Re: [PATCH v2] xen-bus: reduce scope of backend watch

2020-10-01 Thread Anthony PERARD
On Thu, Oct 01, 2020 at 09:15:00AM +0100, Paul Durrant wrote: > From: Paul Durrant > > Currently a single watch on /local/domain/X/backend is registered by each > QEMU process running in service domain X (where X is usually 0). The purpose > of this watch is to ensure that QEMU is notified when

[xen-unstable-smoke test] 155213: regressions - FAIL

2020-10-01 Thread osstest service owner
flight 155213 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/155213/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt 12 guest-start fail REGR. vs. 155128 Tests which

Re: [PATCH v2 0/3] Fix and cleanup xenguest.h

2020-10-01 Thread Wei Liu
On Fri, Sep 25, 2020 at 08:20:28AM +0200, Juergen Gross wrote: > This series fixes builds of libxenguest users outside the Xen build > system and it cleans up the xenguest.h header merging xenctrl_dom.h > into it. > > Juergen Gross (3): > tools/libs: merge xenctrl_dom.h into xenguest.h >

Re: [PATCH 8/8] x86/cpuid: Move VMX/SVM out of the default policy

2020-10-01 Thread Roger Pau Monné
On Wed, Sep 30, 2020 at 02:42:48PM +0100, Andrew Cooper wrote: > Nested virt is still experimental, and requires explicitly opting in to at > domain create time. The VMX/SVM features should not be visible by default. > > Also correct them from all HVM guests, to just HAP-enabled guests. This

Re: [PATCH 3/8] xen/domctl: Introduce and use XEN_DOMCTL_CDF_nested_virt

2020-10-01 Thread Andrew Cooper
On 01/10/2020 11:23, Jan Beulich wrote: > On 30.09.2020 15:42, Andrew Cooper wrote: >> @@ -667,6 +668,12 @@ int arch_sanitise_domain_config(struct >> xen_domctl_createdomain *config) >> */ >> config->flags |= XEN_DOMCTL_CDF_oos_off; >> >> +if ( nested_virt && !hap ) >> +

Re: [PATCH 7/8] x86/hvm: Drop restore boolean from hvm_cr4_guest_valid_bits()

2020-10-01 Thread Roger Pau Monné
On Wed, Sep 30, 2020 at 02:42:47PM +0100, Andrew Cooper wrote: > Previously, migration was reordered so the CPUID data was available before > register state. nestedhvm_enabled() has recently been made accurate for the > entire lifetime of the domain. > > Therefore, we can drop the bodge in

Re: [PATCH 6/8] xen/xsm: Drop xsm_hvm_param_nested()

2020-10-01 Thread Wei Liu
On Wed, Sep 30, 2020 at 02:42:46PM +0100, Andrew Cooper wrote: > The sole caller has been removed. > > Signed-off-by: Andrew Cooper Acked-by: Wei Liu

Re: [PATCH 5/8] x86/hvm: Obsolete the use of HVM_PARAM_NESTEDHVM

2020-10-01 Thread Wei Liu
On Wed, Sep 30, 2020 at 02:42:45PM +0100, Andrew Cooper wrote: > With XEN_DOMCTL_CDF_nested_virt now passed properly to domain_create(), > reimplement nestedhvm_enabled() to use the property which is fixed for the > lifetime of the domain. > > This makes the call to nestedhvm_vcpu_initialise()

Re: [PATCH 4/8] tools/cpuid: Plumb nested_virt down into xc_cpuid_apply_policy()

2020-10-01 Thread Wei Liu
On Wed, Sep 30, 2020 at 02:42:44PM +0100, Andrew Cooper wrote: > Nested Virt is the final special case in legacy CPUID handling. Pass the > (poorly named) nested_hvm setting down into xc_cpuid_apply_policy() to break > the semantic dependency on HVM_PARAM_NESTEDHVM. > > No functional change. >

Re: [PATCH 3/8] xen/domctl: Introduce and use XEN_DOMCTL_CDF_nested_virt

2020-10-01 Thread Wei Liu
On Wed, Sep 30, 2020 at 02:42:43PM +0100, Andrew Cooper wrote: > Like other major areas of functionality, nested virt (or not) needs to be > known at domain creation time for sensible CPUID handling, and wants to be > known this early for sensible infrastructure handling in Xen. > > Introduce

Re: [PATCH 2/8] xen/domctl: Simplify DOMCTL_CDF_ checking logic

2020-10-01 Thread Wei Liu
On Wed, Sep 30, 2020 at 02:42:42PM +0100, Andrew Cooper wrote: > Introduce some local variables to make the resulting logic easier to follow. > Join the two IOMMU checks in sanitise_domain_config(). Tweak some of the > terminology for better accuracy. > > No functional change. > >

Re: [PATCH 6/8] xen/xsm: Drop xsm_hvm_param_nested()

2020-10-01 Thread Roger Pau Monné
On Wed, Sep 30, 2020 at 02:42:46PM +0100, Andrew Cooper wrote: > The sole caller has been removed. > > Signed-off-by: Andrew Cooper Acked-by: Roger Pau Monné Thanks, Roger.

Re: [PATCH 1/8] tools/libxl: Simplify DOMCTL_CDF_ flags handling in libxl__domain_make()

2020-10-01 Thread Wei Liu
On Wed, Sep 30, 2020 at 02:42:41PM +0100, Andrew Cooper wrote: > The use of the ternary operator serves only to obfuscate the code. Rewrite it > in more simple terms, avoiding the need to conditionally OR zero into the > flags. > > Signed-off-by: Andrew Cooper Acked-by: Wei Liu

Re: [PATCH 5/8] x86/hvm: Obsolete the use of HVM_PARAM_NESTEDHVM

2020-10-01 Thread Roger Pau Monné
On Wed, Sep 30, 2020 at 02:42:45PM +0100, Andrew Cooper wrote: > With XEN_DOMCTL_CDF_nested_virt now passed properly to domain_create(), > reimplement nestedhvm_enabled() to use the property which is fixed for the > lifetime of the domain. > > This makes the call to nestedhvm_vcpu_initialise()

Re: [PATCH v4 31/31] tools: move libxlutil to tools/libs/util

2020-10-01 Thread Wei Liu
On Fri, Aug 28, 2020 at 05:07:47PM +0200, Juergen Gross wrote: > Move the libxlutil source to tools/libs/util and delete tools/libxl. > > Signed-off-by: Juergen Gross Acked-by: Wei Liu

Re: [PATCH v4 30/31] tools/libs: add option for library names not starting with libxen

2020-10-01 Thread Wei Liu
On Sat, Aug 29, 2020 at 06:38:40AM +0200, Jürgen Groß wrote: > On 28.08.20 18:00, Wei Liu wrote: > > On Fri, Aug 28, 2020 at 05:07:46PM +0200, Juergen Gross wrote: > > > libxlutil doesn't follow the standard name pattern of all other Xen > > > libraries, so add another make variable which can be

Re: [PATCH v4 29/31] tools: rename global libxlutil make variables

2020-10-01 Thread Wei Liu
On Mon, Sep 07, 2020 at 06:16:32PM +0200, Jürgen Groß wrote: > On 07.09.20 17:55, Wei Liu wrote: > > On Fri, Aug 28, 2020 at 05:07:45PM +0200, Juergen Gross wrote: > > > Rename *_libxlutil make variables to *_libxenutil in order to avoid > > > nasty indirections when moving libxlutil under the

Re: [PATCH 2/3] tools/init-xenstore-domain: support xenstore pvh stubdom

2020-10-01 Thread Jürgen Groß
On 30.09.20 17:46, Wei Liu wrote: On Wed, Sep 23, 2020 at 08:45:40AM +0200, Juergen Gross wrote: Instead of creating the xenstore-stubdom domain first and parsing the kernel later do it the other way round. This enables to probe for the domain type supported by the xenstore-stubdom and to

Re: [PATCH 3/8] xen/domctl: Introduce and use XEN_DOMCTL_CDF_nested_virt

2020-10-01 Thread Jan Beulich
On 30.09.2020 15:42, Andrew Cooper wrote: > @@ -667,6 +668,12 @@ int arch_sanitise_domain_config(struct > xen_domctl_createdomain *config) > */ > config->flags |= XEN_DOMCTL_CDF_oos_off; > > +if ( nested_virt && !hap ) > +{ > +dprintk(XENLOG_INFO, "Nested virt

[xen-4.14-testing bisection] complete test-amd64-amd64-xl-qemut-debianhvm-i386-xsm

2020-10-01 Thread osstest service owner
branch xen-4.14-testing xenbranch xen-4.14-testing job test-amd64-amd64-xl-qemut-debianhvm-i386-xsm testid debian-hvm-install Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git

Re: [PATCH 4/8] tools/cpuid: Plumb nested_virt down into xc_cpuid_apply_policy()

2020-10-01 Thread Roger Pau Monné
On Wed, Sep 30, 2020 at 02:42:44PM +0100, Andrew Cooper wrote: > Nested Virt is the final special case in legacy CPUID handling. Pass the > (poorly named) nested_hvm setting down into xc_cpuid_apply_policy() to break > the semantic dependency on HVM_PARAM_NESTEDHVM. > > No functional change. >

Re: Xen Coding style and clang-format

2020-10-01 Thread George Dunlap
> On Oct 1, 2020, at 10:06 AM, Anastasiia Lukianenko > wrote: > > Hi, > > On Wed, 2020-09-30 at 10:24 +, George Dunlap wrote: >>> On Sep 30, 2020, at 10:57 AM, Jan Beulich >>> wrote: >>> >>> On 30.09.2020 11:18, Anastasiia Lukianenko wrote: I would like to know your opinion on the

Re: [PATCH 3/8] xen/domctl: Introduce and use XEN_DOMCTL_CDF_nested_virt

2020-10-01 Thread Roger Pau Monné
On Wed, Sep 30, 2020 at 02:42:43PM +0100, Andrew Cooper wrote: > Like other major areas of functionality, nested virt (or not) needs to be > known at domain creation time for sensible CPUID handling, and wants to be > known this early for sensible infrastructure handling in Xen. > > Introduce

Re: [PATCH RFC] docs: Add minimum version depencency policy document

2020-10-01 Thread George Dunlap
> On Sep 30, 2020, at 9:23 PM, Stefano Stabellini > wrote: > > On Wed, 30 Sep 2020, George Dunlap wrote: >> Define a specific criteria for how we determine what tools and >> libraries to be compatible with. This will clarify issues such as, >> "Should we continue to support Python 2.4"

Re: [PATCH 2/8] xen/domctl: Simplify DOMCTL_CDF_ checking logic

2020-10-01 Thread Roger Pau Monné
On Wed, Sep 30, 2020 at 02:42:42PM +0100, Andrew Cooper wrote: > Introduce some local variables to make the resulting logic easier to follow. > Join the two IOMMU checks in sanitise_domain_config(). Tweak some of the > terminology for better accuracy. > > No functional change. > >

Re: [PATCH 0/2] mini-os: netfront: fix some issues

2020-10-01 Thread Wei Liu
On Tue, Sep 22, 2020 at 12:58:24PM +0200, Juergen Gross wrote: > Fix two issues in mini-os netfront: > > - undo init_netfront interface change and replace it with an alternative > - fix mini-os suspend/resume handling in netfront > > Juergen Gross (2): > mini-os: netfront: retrieve netmask and

Re: [PATCH 1/8] tools/libxl: Simplify DOMCTL_CDF_ flags handling in libxl__domain_make()

2020-10-01 Thread Roger Pau Monné
On Wed, Sep 30, 2020 at 02:42:41PM +0100, Andrew Cooper wrote: > The use of the ternary operator serves only to obfuscate the code. Rewrite it > in more simple terms, avoiding the need to conditionally OR zero into the > flags. > > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné

Re: [xen-unstable-smoke test] 155187: regressions - FAIL

2020-10-01 Thread Jan Beulich
On 01.10.2020 07:11, osstest service owner wrote: > flight 155187 xen-unstable-smoke real [real] > http://logs.test-lab.xenproject.org/osstest/logs/155187/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-amd64-amd64-libvirt

Re: Xen Coding style and clang-format

2020-10-01 Thread Anastasiia Lukianenko
Hi, On Wed, 2020-09-30 at 10:24 +, George Dunlap wrote: > > On Sep 30, 2020, at 10:57 AM, Jan Beulich > > wrote: > > > > On 30.09.2020 11:18, Anastasiia Lukianenko wrote: > > > I would like to know your opinion on the following coding style > > > cases. > > > Which option do you think is

[xen-unstable-smoke test] 155200: regressions - FAIL

2020-10-01 Thread osstest service owner
flight 155200 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/155200/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt 12 guest-start fail REGR. vs. 155128 Tests which

Re: VirtIO & Argo: a Linux VirtIO transport driver on Xen

2020-10-01 Thread Roger Pau Monné
On Wed, Sep 30, 2020 at 09:03:03PM -0700, Christopher Clark wrote: > Hello > > Following up on a topic introduced in last month's community call, > here are some notes on combining existing Linux guest virtio drivers > with Argo inter-VM communication on Xen. If feasible, this would > combine

RE: [PATCH V1 02/16] xen/ioreq: Make x86's IOREQ feature common

2020-10-01 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 01 October 2020 09:49 > To: Julien Grall > Cc: Oleksandr ; xen-devel@lists.xenproject.org; > p...@xen.org; 'Oleksandr > Tyshchenko' ; 'Andrew Cooper' > ; 'George > Dunlap' ; 'Ian Jackson' > ; 'Stefano Stabellini' > ; 'Wei Liu' ; 'Roger

Re: [PATCH V1 02/16] xen/ioreq: Make x86's IOREQ feature common

2020-10-01 Thread Jan Beulich
On 30.09.2020 19:47, Julien Grall wrote: > Regarding the fix itself, I am not sure what sort of synchronization we > can do. Are you suggesting to wait for the I/O to complete? If so, how > do we handle the case the IOREQ server died? In simple cases retrying the entire request may be an

[xen-4.12-testing bisection] complete test-amd64-i386-xl-xsm

2020-10-01 Thread osstest service owner
branch xen-4.12-testing xenbranch xen-4.12-testing job test-amd64-i386-xl-xsm testid guest-start Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu

[xen-unstable test] 155113: regressions - FAIL

2020-10-01 Thread osstest service owner
flight 155113 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/155113/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-xsm 12 guest-start fail REGR. vs. 154611

Re: Boot crash due to "x86/msi: Consolidate MSI allocation"

2020-10-01 Thread Thomas Gleixner
Yan, On Wed, Sep 30 2020 at 21:29, Zi Yan wrote: > I am running linux-next on my Dell R630 and the system crashed at boot > time. I bisected linux-next and got to your commit: > > x86/msi: Consolidate MSI allocation > > The crash log is below and my .config is attached. > > [ 11.840905]

[PATCH v2] xen-bus: reduce scope of backend watch

2020-10-01 Thread Paul Durrant
From: Paul Durrant Currently a single watch on /local/domain/X/backend is registered by each QEMU process running in service domain X (where X is usually 0). The purpose of this watch is to ensure that QEMU is notified when the Xen toolstack creates a new device backend area. Such a backend area

RE: [PATCH] xen-bus: reduce scope of backend watch

2020-10-01 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD > Sent: 30 September 2020 12:43 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; qemu-de...@nongnu.org; Paul Durrant > ; Jerome > Leseinne ; Edwin Torok ; > Stefano Stabellini > > Subject: Re: [PATCH] xen-bus: reduce scope of backend

RE: [PATCH v2 0/2] fix 'xl block-detach'

2020-10-01 Thread Paul Durrant
Toolstack maintainers... Ping+1 > -Original Message- > From: Paul Durrant > Sent: 25 September 2020 11:39 > To: xen-devel@lists.xenproject.org > Cc: 'Paul Durrant' > Subject: RE: [PATCH v2 0/2] fix 'xl block-detach' > > Ping? AFAICT this series is fully acked. Can it be committed

RE: [PATCH V1 02/16] xen/ioreq: Make x86's IOREQ feature common

2020-10-01 Thread Paul Durrant
> -Original Message- > From: Julien Grall > Sent: 30 September 2020 18:48 > To: Oleksandr ; xen-devel@lists.xenproject.org > Cc: p...@xen.org; 'Oleksandr Tyshchenko' ; > 'Andrew Cooper' > ; 'George Dunlap' ; 'Ian > Jackson' > ; 'Jan Beulich' ; 'Stefano > Stabellini' > ; 'Wei Liu' ;

Re: [PATCH 2/2] libgnttab: Add support for Linux dma-buf offset

2020-10-01 Thread Oleksandr Andrushchenko
Hi, On 9/28/20 6:20 PM, Ian Jackson wrote: > Oleksandr Andrushchenko writes ("[PATCH 2/2] libgnttab: Add support for Linux > dma-buf offset"): >> From: Oleksandr Andrushchenko >> >> Add version 2 of the dma-buf ioctls which adds data_ofs parameter. >> >> dma-buf is backed by a scatter-gather