[qemu-mainline test] 155518: regressions - FAIL

2020-10-07 Thread osstest service owner
flight 155518 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/155518/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 11 guest-startfail REGR. vs. 152631

[linux-linus test] 155516: regressions - FAIL

2020-10-07 Thread osstest service owner
flight 155516 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/155516/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 6 xen-install fail REGR. vs. 152332

[xen-4.10-testing test] 155514: FAIL

2020-10-07 Thread osstest service owner
flight 155514 xen-4.10-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/155514/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-thunderx broken in 155496

Re: Xen Coding style and clang-format

2020-10-07 Thread Stefano Stabellini
On Wed, 7 Oct 2020, Anastasiia Lukianenko wrote: > On Thu, 2020-10-01 at 10:06 +, George Dunlap wrote: > > > On Oct 1, 2020, at 10:06 AM, Anastasiia Lukianenko < > > > anastasiia_lukiane...@epam.com> wrote: > > > > > > Hi, > > > > > > On Wed, 2020-09-30 at 10:24 +, George Dunlap wrote: >

[PATCH v3] xen/rpi4: implement watchdog-based reset

2020-10-07 Thread Stefano Stabellini
The preferred method to reboot RPi4 is PSCI. If it is not available, touching the watchdog is required to be able to reboot the board. The implementation is based on drivers/watchdog/bcm2835_wdt.c:__bcm2835_restart in Linux v5.9-rc7. Signed-off-by: Stefano Stabellini Acked-by: Julien Grall CC:

[linux-5.4 test] 155513: regressions - FAIL

2020-10-07 Thread osstest service owner
flight 155513 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/155513/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-examine 4 memdisk-try-append fail REGR. vs. 155222 Tests which did not

Re: VirtIO & Argo: a Linux VirtIO transport driver on Xen

2020-10-07 Thread Christopher Clark
Roger: thanks for your interest and fast response to the first post in this thread. Responses inline below. On Thu, Oct 1, 2020 at 1:55 AM Roger Pau Monné wrote: > > On Wed, Sep 30, 2020 at 09:03:03PM -0700, Christopher Clark wrote: > > Hello > > > > Following up on a topic introduced in last

[xen-unstable-smoke test] 155521: tolerable all pass - PUSHED

2020-10-07 Thread osstest service owner
flight 155521 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/155521/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[xen-unstable-smoke bisection] complete build-amd64

2020-10-07 Thread osstest service owner
branch xen-unstable-smoke xenbranch xen-unstable-smoke job build-amd64 testid xen-build Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug introduced:

[OSSTEST PATCH 33/82] plan search: Move $share_compat_ok further up the file

2020-10-07 Thread Ian Jackson
From: Ian Jackson We are going to want to use this outside the loop. No functional change. Signed-off-by: Ian Jackson --- Osstest/Executive.pm | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm

[OSSTEST PATCH 64/82] hsot reuse: Hash the share type

2020-10-07 Thread Ian Jackson
From: Ian Jackson We don't really want to duplicate (triplicate, actually) lots of the runvars. This will make the runvars table needlessly bloated. So hash the values. Signed-off-by: Ian Jackson --- README| 2 +- ts-host-reuse | 11 +++ 2 files changed, 8 insertions(+), 5

[OSSTEST PATCH 23/82] db_retry: Make the sleeps random and increasing

2020-10-07 Thread Ian Jackson
From: Ian Jackson When there's a thundering herd, this can run out of retries. Signed-off-by: Ian Jackson --- Osstest.pm | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/Osstest.pm b/Osstest.pm index 734c0ef6..809194f0 100644 --- a/Osstest.pm +++ b/Osstest.pm @@

[OSSTEST PATCH 19/82] host allocation: Executive: Honour $xparams{InfraPriority}

2020-10-07 Thread Ian Jackson
From: Ian Jackson And pass it to ms-queuedaemon. No functional change with existing callers since no-one sets this yet. Forthcoming test host sharing machinery uses this. Signed-off-by: Ian Jackson --- Osstest/Executive.pm | 1 + 1 file changed, 1 insertion(+) diff --git

[OSSTEST PATCH 62/82] runvar access: Introduce effects_gone_before_share_reuse

2020-10-07 Thread Ian Jackson
From: Ian Jackson The syslog server, and its port, is used for things that happen in this job, but the syslog server is torn down and a new one started, when the host is reused. Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 10 ++ Osstest/TestSupport.pm | 6 ++ 2 files

[OSSTEST PATCH 37/82] ts-hosts-allocate-Executive: Better message for hosts abandoned mid-test

2020-10-07 Thread Ian Jackson
From: Ian Jackson Signed-off-by: Ian Jackson --- ts-hosts-allocate-Executive | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts-hosts-allocate-Executive b/ts-hosts-allocate-Executive index 6fcfd2e3..58e9f891 100755 --- a/ts-hosts-allocate-Executive +++

[OSSTEST PATCH 35/82] resource reporting: Print username when listing "rogue tasks"

2020-10-07 Thread Ian Jackson
From: Ian Jackson Signed-off-by: Ian Jackson --- ms-planner | 1 + 1 file changed, 1 insertion(+) diff --git a/ms-planner b/ms-planner index 78d27b2f..41f27fa0 100755 --- a/ms-planner +++ b/ms-planner @@ -325,6 +325,7 @@ END $info .= " $arow->{type} $arow->{refkey}";

[OSSTEST PATCH 76/82] sg-report-flight: Reformat slightly

2020-10-07 Thread Ian Jackson
This is more regular and will make the next commit easier to understand. Signed-off-by: Ian Jackson --- sg-report-flight | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sg-report-flight b/sg-report-flight index 0413a730..7dc218cf 100755 --- a/sg-report-flight +++

[OSSTEST PATCH 49/82] host reuse: sg-run-job: per-host prep: Use @ for per-host-ts

2020-10-07 Thread Ian Jackson
From: Ian Jackson These are the steps that will be skipped when we reuse a test host. No functional change yet since we don't allocate the host shared yet. Signed-off-by: Ian Jackson --- sg-run-job | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sg-run-job

[OSSTEST PATCH 16/82] abolish "kernkind"; desupport non-pvops kernels

2020-10-07 Thread Ian Jackson
From: Ian Jackson This was for distinguishing the old-style Xenolinux kernels from pvops kernels. We have not actually tested any non-pvops kernels for a very very long time. Delete this now because the runvar is slightly in the way of test host reuse. (Sorry for the wide CC but it seems

[OSSTEST PATCH 71/82] resource reporting, nfc: split a here document

2020-10-07 Thread Ian Jackson
From: Ian Jackson Signed-off-by: Ian Jackson --- sg-report-flight | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sg-report-flight b/sg-report-flight index 281361c0..a1f424c5 100755 --- a/sg-report-flight +++ b/sg-report-flight @@ -1213,6 +1213,9 @@ END Status:$ji->{status} +END +

[OSSTEST PATCH 32/82] plan_search: Use plan's Wear information rather than tracking it ourselves

2020-10-07 Thread Ian Jackson
From: Ian Jackson There is no reason not to use this information from the plan. Not computing it ourselves saves some confusing logic here. Signed-off-by: Ian Jackson --- Osstest/Executive.pm | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git

[OSSTEST PATCH 70/82] sg-report-flight: Refactor runvar access

2020-10-07 Thread Ian Jackson
From: Ian Jackson Collect the runvars query into local perl variables. This will allow us to reuse the information without going back to the db. No functional change. Signed-off-by: Ian Jackson --- sg-report-flight | 20 1 file changed, 12 insertions(+), 8 deletions(-)

[OSSTEST PATCH 15/82] target setup refactoring: Add a doc comment

2020-10-07 Thread Ian Jackson
From: Ian Jackson Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm index fd7b238b..d9bb2585 100644 --- a/Osstest/TestSupport.pm +++ b/Osstest/TestSupport.pm @@ -2563,6 +2563,9 @@ sub

[OSSTEST PATCH 52/82] host allocation: Group jobs by their reuse parameters

2020-10-07 Thread Ian Jackson
From: Ian Jackson This promotes reuse by arranging that jobs that can reuse a host get to run consecutively. Signed-off-by: Ian Jackson --- Osstest/JobDB/Executive.pm | 47 + Osstest/JobDB/Standalone.pm | 2 ++ ts-host-reuse | 1 +

[OSSTEST PATCH 45/82] sg-run-job: Detect improper use of @ iffail with run-ts

2020-10-07 Thread Ian Jackson
From: Ian Jackson Only per-host-ts understands this. This is a bit of a bear trap, so arrange to bail rather than putting strange step status values with `@' at the front in the database... Signed-off-by: Ian Jackson --- sg-run-job | 3 +++ 1 file changed, 3 insertions(+) diff --git

[OSSTEST PATCH 44/82] sg-run-job: New @ iffail tag for prep tasks

2020-10-07 Thread Ian Jackson
From: Ian Jackson Currently no users sites, so no functional change. Signed-off-by: Ian Jackson --- sg-run-job | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/sg-run-job b/sg-run-job index 3f44cae7..a074cd42 100755 --- a/sg-run-job +++ b/sg-run-job @@

[OSSTEST PATCH 24/82] host allocation: *_shared_mark_ready: Allow other states

2020-10-07 Thread Ian Jackson
From: Ian Jackson Generalise these functions so they can set the state to something other than `ready', and so that they can expect a state other than `prep'. No functional change with existing callers. Signed-off-by: Ian Jackson --- Osstest/Executive.pm | 19 +++

[OSSTEST PATCH 25/82] host allocation: *_shared_mark_ready: Make $sharetype check optional

2020-10-07 Thread Ian Jackson
From: Ian Jackson We are going to want to be able to set shares to other than ready, without double-checking the sharetype. The change to the UPDATE statement makes no difference because resource_check_allocated_core has just got that sharetype out of the db. (This does remove one safety check

[OSSTEST PATCH 77/82] sg-report-flight: Improvements to other job (share/reuse) reporting

2020-10-07 Thread Ian Jackson
* Prefer to show "prep" (purple) rather than "share". * Show our own relationship, in particular to show if it was prep. Signed-off-by: Ian Jackson --- sg-report-flight | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/sg-report-flight b/sg-report-flight index

[OSSTEST PATCH 20/82] ts-hosts-allocate-Executive: Fix handling of failed preps for same sharing

2020-10-07 Thread Ian Jackson
From: Ian Jackson This code was previously unreachable. It ought to be executed when all the shares are allocatable or prep: in that case, we can unshare and re-share the host. Signed-off-by: Ian Jackson --- ts-hosts-allocate-Executive | 11 +-- 1 file changed, 5 insertions(+), 6

[OSSTEST PATCH 75/82] host reuse: New protocol between sg-run-job and ts-host-reuse

2020-10-07 Thread Ian Jackson
From: Ian Jackson Abolish post-test-ok (which runs only if successful) and replace it with final (which sets the runvar to indicate finality, and runs regardless). This allows a subsequent job which reuses the host to see that this job had finished using the host. This is relevant for builds,

[OSSTEST PATCH 34/82] plan_search: Track last sharing state to determine $share_reuse

2020-10-07 Thread Ian Jackson
From: Ian Jackson What matters for the purpose of $share_reuse is not whether the host is actually being _shared_ (ie, there are other concurrent allocations and therefore a concurrent Event with Share information). What we really want to know is whether the *last* use of this host was a

[OSSTEST PATCH 60/82] runvar access: Use runvar_glob for dmrestrict runvar search

2020-10-07 Thread Ian Jackson
From: Ian Jackson Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index 3fa26e45..ae3c1d33 100644 --- a/Osstest/Debian.pm +++ b/Osstest/Debian.pm @@ -1032,7 +1032,7 @@ END #

[OSSTEST PATCH 50/82] shared/reuse: Rely on @ for ts-host-ping-check

2020-10-07 Thread Ian Jackson
From: Ian Jackson Remove the check for SharedReady. The existence of this check is perplexing. It was introduced in ts-host-ping-check: Do not run if host is being reused in 8f1dc3f7c401 (from 2015). At that time we only share build hosts, and build hosts never ran this script. So I don't

[OSSTEST PATCH 67/82] host lifecycle: Fix detection of concurrent jobs

2020-10-07 Thread Ian Jackson
The previous algorithm was wrong here. This commit was originally considerably later than the previous one. I'm avoiding squshing this commit, to make future archaeology easier. The effect of the bug is to report other tasks as live too often, so hosts show up as shared rather than reused.

[OSSTEST PATCH 82/82] sg-report-flight: Word-wrapping improvements to job and step names

2020-10-07 Thread Ian Jackson
Use . Signed-off-by: Ian Jackson --- sg-report-flight | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/sg-report-flight b/sg-report-flight index 33f953ca..a07e03cb 100755 --- a/sg-report-flight +++ b/sg-report-flight @@ -1185,6 +1185,15 @@ sub nullcols {

[OSSTEST PATCH 40/82] ts-host-reuse: Do not depend on bios

2020-10-07 Thread Ian Jackson
From: Ian Jackson Weirdly, this is only used for guests. Really, it should be a target_var, not a raw runvar applying to all guests, since it can be guest-specific. Signed-off-by: Ian Jackson --- ts-host-reuse | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts-host-reuse

[OSSTEST PATCH 63/82] test host reuse: Switch to principled sharing scope runvar scheme

2020-10-07 Thread Ian Jackson
From: Ian Jackson * When selecthost is passed an @host ident, indicating prep work, engage restricted runvar access. If no call to sharing_for_build was made, this means it can access only the runvars in the default value of @accessible_runvar_pats. * Make the sharetype for host reuse be

[OSSTEST PATCH 18/82] host allocation: Remove some unnecessary definedness tests

2020-10-07 Thread Ian Jackson
From: Ian Jackson $set_info->() already checkes for undef, and returns immediately in that case. So there is no point checking at the call site. No functional change. Signed-off-by: Ian Jackson --- Osstest/Executive.pm | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff

[OSSTEST PATCH 51/82] host reuse: Reuse test hosts within a flight

2020-10-07 Thread Ian Jackson
From: Ian Jackson Mark the host shareable, and unshareable, as appropriate. There is still a lot more cleanup and improvement to do. Signed-off-by: Ian Jackson --- sg-run-job | 5 + 1 file changed, 5 insertions(+) diff --git a/sg-run-job b/sg-run-job index af43008d..1e2fcfee 100755 ---

[OSSTEST PATCH 73/82] host reuse: sg-run-job: Reanme post-test-ok parameter

2020-10-07 Thread Ian Jackson
From: Ian Jackson This is more accurate. No overall functional change. Signed-off-by: Ian Jackson --- sg-run-job| 2 +- ts-host-reuse | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sg-run-job b/sg-run-job index 1e2fcfee..2feb67d9 100755 --- a/sg-run-job +++

[OSSTEST PATCH 38/82] ts-host-reuse: New script, to do reuse state changes

2020-10-07 Thread Ian Jackson
From: Ian Jackson This will be made part of the test job recipes. We calculate the sharing scope (sharetype) by reference to a lot of runvars, etc. This version of the script is rather far from the finished working one, but it seems better to preserve the actual history for how it got the way

[OSSTEST PATCH 81/82] sg-report-flight: Sharing reports: more task finished info

2020-10-07 Thread Ian Jackson
Other steps from jobs affecting this host either started after we are running, and therefore didn't affect the stuff we're reporting, or already in the db. Furthermore, any such effects for steps which have finished must have completed by the max finished time But if there are unfinished steps,

[OSSTEST PATCH 27/82] host allocation: *_shared_mark_ready: allow alternative $oldtypes

2020-10-07 Thread Ian Jackson
From: Ian Jackson $oldtype may now be a hashref, where keys mapping to truthy values are permitted for the sharetype precondition. No functional change for existing callers. Signed-off-by: Ian Jackson --- Osstest/Executive.pm | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[OSSTEST PATCH 10/82] hsot reuse: ms-planner: Abbreviate reporting of test shares

2020-10-07 Thread Ian Jackson
From: Ian Jackson Signed-off-by: Ian Jackson --- ms-planner | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ms-planner b/ms-planner index 4e38e4e3..78d27b2f 100755 --- a/ms-planner +++ b/ms-planner @@ -414,11 +414,13 @@ END next if $plan->{Events}{$reskey};

[OSSTEST PATCH 78/82] flight other job reporting: Put nulls last in the report

2020-10-07 Thread Ian Jackson
From: Ian Jackson Cosmetic change only, but this makes the results easier to understand. Signed-off-by: Ian Jackson --- sg-report-flight | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sg-report-flight b/sg-report-flight index 2a79db13..d8829932 100755 ---

[OSSTEST PATCH 43/82] ts-hosts-allocate-Executive print sharing info in debug output

2020-10-07 Thread Ian Jackson
From: Ian Jackson Signed-off-by: Ian Jackson --- ts-hosts-allocate-Executive | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ts-hosts-allocate-Executive b/ts-hosts-allocate-Executive index 58e9f891..fc107c08 100755 --- a/ts-hosts-allocate-Executive +++

[OSSTEST PATCH 74/82] host reuse: ts-host-reuse: Prepare for argument handling

2020-10-07 Thread Ian Jackson
From: Ian Jackson No functional change. Signed-off-by: Ian Jackson --- ts-host-reuse | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/ts-host-reuse b/ts-host-reuse index aad45bdd..21d77500 100755 --- a/ts-host-reuse +++ b/ts-host-reuse @@ -48,9 +48,9 @@ use

[OSSTEST PATCH 39/82] ts-host-reuse: tolerate unremoveable lv

2020-10-07 Thread Ian Jackson
From: Ian Jackson It might be a symlink in the pair tests. Signed-off-by: Ian Jackson --- ts-host-reuse | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts-host-reuse b/ts-host-reuse index e14a9149..74ac94aa 100755 --- a/ts-host-reuse +++ b/ts-host-reuse @@ -112,7 +112,7 @@

[OSSTEST PATCH 61/82] runvar access: Introduce sharing_for_build

2020-10-07 Thread Ian Jackson
From: Ian Jackson Builds don't have so much contingent setup. We don't track the runvars; we just rely on the share-* hostflag set in the job. But selecthost() is going to automatically enable runvar access control for shared/reused hosts. So, provide a way to disable that. Signed-off-by:

[OSSTEST PATCH 36/82] resource reporting, nfc: Break out report_rogue_task_description

2020-10-07 Thread Ian Jackson
From: Ian Jackson Signed-off-by: Ian Jackson --- Osstest/Executive.pm | 14 ++ ms-planner | 6 +- 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm index 5f59c44e..e3ab1dc3 100644 --- a/Osstest/Executive.pm

[OSSTEST PATCH 48/82] shared/reuse: Use @ for freebsd host prep

2020-10-07 Thread Ian Jackson
From: Ian Jackson These are all the relevant call sites for ts-freebsd-host-install and ts-freebsd-build-prep. (There's a ts-freebsd-host-install in ts-memdisk-try-append but that's for host examination and does not uee or want sharing or reuse.) Signed-off-by: Ian Jackson --- sg-run-job

[OSSTEST PATCH 30/82] plan_search: Break out $share_compat_ok

2020-10-07 Thread Ian Jackson
From: Ian Jackson No functional change. Signed-off-by: Ian Jackson --- Osstest/Executive.pm | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm index 4cd4aa50..e4bb0868 100644 --- a/Osstest/Executive.pm +++

[OSSTEST PATCH 41/82] ts-host-reuse: Add some missing runvars to the host sharing control

2020-10-07 Thread Ian Jackson
From: Ian Jackson Add some missing runvars to the host sharing control. Signed-off-by: Ian Jackson --- ts-host-reuse | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ts-host-reuse b/ts-host-reuse index 67de480f..5bdb07d1 100755 --- a/ts-host-reuse +++ b/ts-host-reuse @@

[OSSTEST PATCH 79/82] flight other job reporting: Further improvements to ordering

2020-10-07 Thread Ian Jackson
From: Ian Jackson We want to definitely put these NULLs last. Signed-off-by: Ian Jackson --- sg-report-flight | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/sg-report-flight b/sg-report-flight index d8829932..8f99bb69 100755 --- a/sg-report-flight +++

[OSSTEST PATCH 17/82] Debian: osstest-erase-other-disks: Slightly guard against races

2020-10-07 Thread Ian Jackson
From: Ian Jackson Apparently it can happen that something decides to rescan a partition table, removing a partition block device, while it is being zeroed: osstest-erase-other-disks-6081: hd devices present after: /dev/hd* osstest-erase-other-disks-6081: Erasing /dev/sda

[OSSTEST PATCH 11/82] cr-publish-flight-logs: Fix abs_time calls

2020-10-07 Thread Ian Jackson
From: Ian Jackson There was a missing space in these messages, since they were introduced in 31b7cae19fe1 timing traces: cr-publish-flight-logs: Report more progress Signed-off-by: Ian Jackson --- cr-publish-flight-logs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[OSSTEST PATCH 59/82] runvar access: Provide runvar_glob

2020-10-07 Thread Ian Jackson
From: Ian Jackson We will need this because when runvar access is restricted, accessing via %r directly won't work. We want to see what patterns the code is interested in (so that interest in a nonexistent runvar is properly tracked). Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm |

[OSSTEST PATCH 68/82] host lifecycle: Prevent referential integrity violation

2020-10-07 Thread Ian Jackson
From: Ian Jackson We can't use normal constraints for either of these, sadly. We can make the constraints into a single query which says "OK". Signed-off-by: Ian Jackson --- Osstest/JobDB/Executive.pm | 25 + 1 file changed, 25 insertions(+) diff --git

[OSSTEST PATCH 53/82] host reuse: Jiggle the infra-priority a bit, within a flight

2020-10-07 Thread Ian Jackson
From: Ian Jackson Signed-off-by: Ian Jackson --- ts-hosts-allocate-Executive | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/ts-hosts-allocate-Executive b/ts-hosts-allocate-Executive index a50f8bf3..c1002fc9 100755 --- a/ts-hosts-allocate-Executive +++

[OSSTEST PATCH 80/82] tsreadconfig: Change misleading "setting" message

2020-10-07 Thread Ian Jackson
These are the *existing* runvars and it is confusing that we print "setting" for them. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm index 163862f8..f2d8a0e1 100644 ---

[OSSTEST PATCH 29/82] host allocation: *_shared_mark_ready: Only prod when $newstate is ready

2020-10-07 Thread Ian Jackson
From: Ian Jackson Signed-off-by: Ian Jackson --- Osstest/Executive.pm | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm index f2d43464..4cd4aa50 100644 --- a/Osstest/Executive.pm +++ b/Osstest/Executive.pm @@

[OSSTEST PATCH 31/82] plan_search: Improve debugging of $share_compat_ok->()

2020-10-07 Thread Ian Jackson
From: Ian Jackson No change other than to debugging output. Signed-off-by: Ian Jackson --- Osstest/Executive.pm | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm index e4bb0868..dfa3710a 100644 --- a/Osstest/Executive.pm +++

[OSSTEST PATCH 56/82] subst_netboot_template: Do not use all of %r

2020-10-07 Thread Ian Jackson
From: Ian Jackson Instead of copying all of %r into %v, have the template substitutor fall back to %r from %v. This is going to be important when we have host-reuse-related access control to %r. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 3 ++- 1 file changed, 2 insertions(+), 1

[OSSTEST PATCH 21/82] sg-run-job: support +! for *only* adding things to TESTID

2020-10-07 Thread Ian Jackson
From: Ian Jackson Signed-off-by: Ian Jackson --- sg-run-job | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/sg-run-job b/sg-run-job index 702ed558..3ca725e7 100755 --- a/sg-run-job +++ b/sg-run-job @@ -277,6 +277,10 @@ proc recipe-flag {flagname {def 0}} { #

[OSSTEST PATCH 22/82] sg-run-job: Use +! in per-host-ts implementation

2020-10-07 Thread Ian Jackson
From: Ian Jackson This makes this slightly clearer, even more so in a moment. No functional change. Signed-off-by: Ian Jackson --- sg-run-job | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/sg-run-job b/sg-run-job index 3ca725e7..3f44cae7 100755 --- a/sg-run-job

Re: [OSSTEST PATCH 00/82] Reuse test hosts

2020-10-07 Thread Ian Jackson
Ian Jackson writes ("[OSSTEST PATCH 00/82] Reuse test hosts"): > This series arranges to save on host setup by reusing a test host, if > the previous test passed. Care is taken to make sure that a host is > only reused in this way if the new test would have set it up > identically. > > I have

[OSSTEST PATCH 13/82] target setup refactoring: Move target_kernkind_console_inittab

2020-10-07 Thread Ian Jackson
From: Ian Jackson We move this earlier. This is OK because it depends only on the console runvar (inside the sub; this is set by target_kernkind_check), $ho and $gho (which are set by this point); and $mountpoint$ (which is set by access(). No functional change. Signed-off-by: Ian Jackson

[OSSTEST PATCH 42/82] host allocation: selecthost(): Support @IDENT for reuse

2020-10-07 Thread Ian Jackson
From: Ian Jackson This is the first part of a central way to control host reuse, rather than having to write code in each ts-* script to check Shared etc. No functional change with existing callers. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 26 -- 1 file

[OSSTEST PATCH 69/82] host lifecycle: Record lifecycle in db and runvar

2020-10-07 Thread Ian Jackson
From: Ian Jackson This is just the calls to host_update_lifecycle_info. Now the db table is Needed. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm| 2 ++ schema/host-lifecycle.sql | 2 +- ts-freebsd-host-install | 1 + ts-host-install | 1 + ts-host-reuse |

[OSSTEST PATCH 54/82] host reuse: Use literal for the hosts_infraprioritygroup runvar

2020-10-07 Thread Ian Jackson
From: Ian Jackson At some point this might make the database smarter about indexing. It's certainly clearer. Signed-off-by: Ian Jackson --- Osstest/JobDB/Executive.pm | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Osstest/JobDB/Executive.pm

[OSSTEST PATCH 55/82] host reuse: Bump host share reuse bonus

2020-10-07 Thread Ian Jackson
From: Ian Jackson In test jobs this is now contending with the variation bonus. If we fail to vary properly this time, we get another go in the next flight, so this is not so critical. This increases the amount of test host reuse. Signed-off-by: Ian Jackson --- ts-hosts-allocate-Executive |

[OSSTEST PATCH 58/82] runvar access: Introduce access control machinery

2020-10-07 Thread Ian Jackson
From: Ian Jackson This will allow us to trap accesses, during test host setup, to runvars which weren't included in ithe calculation of the sharing scope. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 53 ++ README | 2 +- 2

[OSSTEST PATCH 47/82] shared/reuse: Use @ for ts-host-install

2020-10-07 Thread Ian Jackson
From: Ian Jackson Pass @ from sg-run-job. These are all the call sites for ts-host-install-*, so we can lose the open-coded test for SharedReady. Signed-off-by: Ian Jackson --- sg-run-job | 6 +++--- ts-host-install | 1 - 2 files changed, 3 insertions(+), 4 deletions(-) diff --git

[OSSTEST PATCH 12/82] target setup refactoring: Move target_kernkind_check

2020-10-07 Thread Ian Jackson
From: Ian Jackson This is OK because nothing in access() looks at the rootdev or console runvars, which are what target_kernkind_check sets. No functional change other than perhaps to log output. Signed-off-by: Ian Jackson --- ts-debian-fixup | 2 +- 1 file changed, 1 insertion(+), 1

[OSSTEST PATCH 14/82] target setup refactoring: Merge target_kernkind_*

2020-10-07 Thread Ian Jackson
From: Ian Jackson Combine these two functions. Rename them to a name which doesn't mention "kernkind". No functional change. Signed-off-by: Ian Jackson --- Osstest/Debian.pm | 3 +-- Osstest/TestSupport.pm | 11 --- ts-debian-fixup| 3 +-- 3 files changed, 6

[OSSTEST PATCH 65/82] hsot reuse: Make share type hash more easily greppable

2020-10-07 Thread Ian Jackson
From: Ian Jackson Use - and _ to make up the base64 alphabet instead of + and / Signed-off-by: Ian Jackson --- ts-host-reuse | 1 + 1 file changed, 1 insertion(+) diff --git a/ts-host-reuse b/ts-host-reuse index 701070b2..0ecbb0bd 100755 --- a/ts-host-reuse +++ b/ts-host-reuse @@ -75,6 +75,7

[OSSTEST PATCH 28/82] host allocation: Support new reuse-* magic hostflag

2020-10-07 Thread Ian Jackson
From: Ian Jackson This is like share-* except it has different MaxTasks and MaxWear parameters. Signed-off-by: Ian Jackson --- README.planner | 7 +++ ts-hosts-allocate-Executive | 15 +++ 2 files changed, 22 insertions(+) diff --git a/README.planner

[OSSTEST PATCH 72/82] resource reporting: Report host reuse/sharing in job report

2020-10-07 Thread Ian Jackson
From: Ian Jackson Compatibility: in principle this might generate erroneous reports which omit sharing/reuse information for allocations made by jobs using older versions of osstest. However, we do not share or reuse hosts across different osstest versions, so this cannot occur. Signed-off-by:

[OSSTEST PATCH 46/82] shared/reuse: Use @ for ts-xen-build-prep

2020-10-07 Thread Ian Jackson
From: Ian Jackson Pass @ from sg-run-job. This is the only call site for ts-xen-build-prep, so it can lose the open-coded test for SharedReady. Signed-off-by: Ian Jackson --- sg-run-job| 2 +- ts-xen-build-prep | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git

[OSSTEST PATCH 26/82] host allocation: selecthost: allow sort-of-selection of prospective hosts

2020-10-07 Thread Ian Jackson
From: Ian Jackson If one passes a trueish value for $prospective, selecthost does not worry about whether any host has actually been selected. It does a limited amount of prep work. This will be useful if we want to know some of the non-host-specific information selecthost computes - in

[OSSTEST PATCH 66/82] host lifecycle: Machinery, db, for tracking relevant events

2020-10-07 Thread Ian Jackson
From: Ian Jackson When we reuse test hosts, we want to be able to give a list of the other jobs which might be responsible for any problem. In principle it would be possible to do this by digging into the db's history tables like sg-report-host-history does, but this is quite slow and also I

[OSSTEST PATCH 57/82] TestSupport: Provide runvar_is_synth

2020-10-07 Thread Ian Jackson
From: Ian Jackson Internally we use an array %r_notsynth. This allows us to avoid adding code to store_runvar etc. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/Osstest/TestSupport.pm

[OSSTEST PATCH 06/82] show_abs_time: Represent undef $timet as

2020-10-07 Thread Ian Jackson
From: Ian Jackson This can happen, for example, if a badly broken flight has steps which are STARTING and have NULL in the start time column, and is then reported using sg-report-flight. Signed-off-by: Ian Jackson --- Osstest.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/Osstest.pm

[OSSTEST PATCH 09/82] host reuse: ms-planner: Do not show reuse as shared in the plan

2020-10-07 Thread Ian Jackson
From: Ian Jackson If the number of shares is 1, do not show it as shared, and also ignore the Unshare events. This clarifies the display, especially when used with forthcoming test host reuse work. Signed-off-by: Ian Jackson --- ms-planner | 7 +-- 1 file changed, 5 insertions(+), 2

[PATCH] x86/ucode: Trivial further cleanup

2020-10-07 Thread Andrew Cooper
* Drop unused include in private.h. * Used explicit width integers for Intel header fields. * Adjust comment to better describe the extended header. * Drop unnecessary __packed attribute for AMD header. * Switch mc_patch_data_id to being uint16_t, which is how it is more commonly referred

[OSSTEST PATCH 05/82] sg-run-job: Improve some internal API docs

2020-10-07 Thread Ian Jackson
Signed-off-by: Ian Jackson --- sg-run-job | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sg-run-job b/sg-run-job index 3db05b34..702ed558 100755 --- a/sg-run-job +++ b/sg-run-job @@ -206,12 +206,12 @@ proc recipe-flag {flagname {def 0}} { #

[OSSTEST PATCH 04/82] sg-run-job: Minor whitespace (formatting) changes

2020-10-07 Thread Ian Jackson
From: Ian Jackson No functional change. Signed-off-by: Ian Jackson --- sg-run-job | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sg-run-job b/sg-run-job index df3d08d0..3db05b34 100755 --- a/sg-run-job +++ b/sg-run-job @@ -30,12 +30,12 @@ proc per-host-prep {} {

[OSSTEST PATCH 08/82] host reuse: ms-planner: Bring some variables forward

2020-10-07 Thread Ian Jackson
From: Ian Jackson Move the scope of $share earlier in cmd_show_html, and also introduce $shared in the colour computation. This makes the next changes easier. No functional change. Signed-off-by: Ian Jackson --- ms-planner | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-)

[OSSTEST PATCH 07/82] ts-hosts-allocate-Executive: Add a comment about a warning

2020-10-07 Thread Ian Jackson
From: Ian Jackson Signed-off-by: Ian Jackson --- ts-hosts-allocate-Executive | 4 1 file changed, 4 insertions(+) diff --git a/ts-hosts-allocate-Executive b/ts-hosts-allocate-Executive index 58d2a389..78b94c6d 100755 --- a/ts-hosts-allocate-Executive +++ b/ts-hosts-allocate-Executive @@

[OSSTEST PATCH 02/82] Executive.pm planner: fix typo

2020-10-07 Thread Ian Jackson
From: Ian Jackson Signed-off-by: Ian Jackson --- Osstest/Executive.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm index a0d9f81e..f17e7b70 100644 --- a/Osstest/Executive.pm +++ b/Osstest/Executive.pm @@ -702,7 +702,7 @@ sub

[OSSTEST PATCH 00/82] Reuse test hosts

2020-10-07 Thread Ian Jackson
This series arranges to save on host setup by reusing a test host, if the previous test passed. Care is taken to make sure that a host is only reused in this way if the new test would have set it up identically. I have had this branch in preparation since November 2017... -- 2.20.1

[OSSTEST PATCH 01/82] ms-queuedaemon: Update for newer Tcl's socket channel ids

2020-10-07 Thread Ian Jackson
From: Ian Jackson Now we have things like "sock55599edaf050" where previously we had something like "sock142". So the output is misaligned. Bump the sizes. And with these longer names, when showing the front of the queue only print the full first entry and the start of the next one.

[OSSTEST PATCH 03/82] README.planner: Document magic job hostflags

2020-10-07 Thread Ian Jackson
From: Ian Jackson Signed-off-by: Ian Jackson --- README.planner | 60 ++ 1 file changed, 60 insertions(+) diff --git a/README.planner b/README.planner index c33aae11..f134d716 100644 --- a/README.planner +++ b/README.planner @@ -203,6 +203,66 @@

[xen-unstable test] 155510: tolerable FAIL - PUSHED

2020-10-07 Thread osstest service owner
flight 155510 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/155510/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 14 saverestore-support-checkfail like 155493

Re: [PATCH] xen/arm: print update firmware only once

2020-10-07 Thread Stefano Stabellini
On Wed, 7 Oct 2020, Julien Grall wrote: > Hi Bertrand, > > On 07/10/2020 12:05, Bertrand Marquis wrote: > > Fix enable_smccc_arch_workaround_1 to only print the warning asking to > > update the firmware once. > > > > Signed-off-by: Bertrand Marquis > > --- > > xen/arch/arm/cpuerrata.c | 2 +-

Re: xen-swiotlb vs phys_to_dma

2020-10-07 Thread Stefano Stabellini
On Wed, 7 Oct 2020, Christoph Hellwig wrote: > On Tue, Oct 06, 2020 at 01:46:12PM -0700, Stefano Stabellini wrote: > > OK, this makes a lot of sense, and I like the patch because it makes the > > swiotlb interface clearer. > > > > Just one comment below. > > > > > > +phys_addr_t

[ovmf test] 155512: all pass - PUSHED

2020-10-07 Thread osstest service owner
flight 155512 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/155512/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf c640186ec8aae6164123ee38de6409aed69eab12 baseline version: ovmf

Re: [PATCH] x86/msr: fix handling of MSR_IA32_PERF_{STATUS/CTL}

2020-10-07 Thread Roger Pau Monné
On Wed, Oct 07, 2020 at 01:06:08PM +0100, Andrew Cooper wrote: > On 06/10/2020 17:23, Roger Pau Monne wrote: > > Currently a PV hardware domain can also be given control over the CPU > > frequency, and such guest is allowed to write to MSR_IA32_PERF_CTL. > > This might be how the current logic

[xen-unstable-smoke test] 155517: regressions - FAIL

2020-10-07 Thread osstest service owner
flight 155517 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/155517/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 155495 Tests which

  1   2   >