[PATCH 08/30] mspro: use blk_mq_alloc_disk

2021-06-01 Thread Christoph Hellwig
Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/memstick/core/mspro_block.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/drivers/memstick/core/mspro_block.c b/dri

[PATCH 07/30] ms_block: use blk_mq_alloc_disk

2021-06-01 Thread Christoph Hellwig
Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/memstick/core/ms_block.c | 25 ++--- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/drivers/memstick/core/ms_block.c b/drivers/mem

[PATCH 06/30] pf: use blk_mq_alloc_disk

2021-06-01 Thread Christoph Hellwig
Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/paride/pf.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/block/paride/pf.c b/drivers/block/paride/pf.c index b

[PATCH 05/30] pcd: use blk_mq_alloc_disk

2021-06-01 Thread Christoph Hellwig
Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/paride/pcd.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/block/paride/pcd.c b/drivers/block/paride/pcd.c ind

[PATCH 03/30] blk-mq: add the blk_mq_alloc_disk APIs

2021-06-01 Thread Christoph Hellwig
Add a new API to allocate a gendisk including the request_queue for use with blk-mq based drivers. This is to avoid boilerplate code in drivers. Signed-off-by: Christoph Hellwig --- block/blk-mq.c | 19 +++ include/linux/blk-mq.h | 12 2 files changed, 31 in

[PATCH 04/30] virtio-blk: use blk_mq_alloc_disk

2021-06-01 Thread Christoph Hellwig
Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/virtio_blk.c | 26 +++--- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_bl

[PATCH 01/30] blk-mq: factor out a blk_mq_alloc_sq_tag_set helper

2021-06-01 Thread Christoph Hellwig
Factour out a helper to initialize a simple single hw queue tag_set from blk_mq_init_sq_queue. This will allow to phase out blk_mq_init_sq_queue in favor of a more symmetric and general API. Signed-off-by: Christoph Hellwig --- block/blk-mq.c | 32 ++-- inclu

simplify gendisk and request_queue allocation for blk-mq based drivers

2021-06-01 Thread Christoph Hellwig
Hi all, this series is the scond part of cleaning up lifetimes and allocation of the gendisk and request_queue structure. It adds a new interface to allocate the disk and queue together for blk based drivers, and uses that in all drivers that do not have any caveats in their gendisk and request_q

[PATCH 02/30] blk-mq: improve the blk_mq_init_allocated_queue interface

2021-06-01 Thread Christoph Hellwig
Don't return the passed in request_queue but a normal error code, and drop the elevator_init argument in favor of just calling elevator_init_mq directly from dm-rq. Signed-off-by: Christoph Hellwig --- block/blk-mq.c | 36 ++-- block/blk.h |

Re: [PATCH v20210601 00/38] leftover from 2020

2021-06-01 Thread Olaf Hering
Am Wed, 2 Jun 2021 08:10:21 +0200 schrieb Juergen Gross : > Would it be possible to split this into multiple independent > patches/series? Sure, I can send each individual part that was already sent over and over again. Olaf pgpIP_w0E80ck.pgp Description: Digitale Signatur von OpenPGP

Re: [PATCH v20210601 06/38] tools: use xc_is_known_page_type

2021-06-01 Thread Juergen Gross
On 01.06.21 18:10, Olaf Hering wrote: Verify pfn type on sending side, also verify incoming batch of pfns. Signed-off-by: Olaf Hering Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signatu

Re: [PATCH v20210601 05/38] tools: add xc_is_known_page_type to libxenctrl

2021-06-01 Thread Juergen Gross
On 01.06.21 18:10, Olaf Hering wrote: Users of xc_get_pfn_type_batch may want to sanity check the data returned by Xen. Add a simple helper for this purpose. Signed-off-by: Olaf Hering --- tools/libs/ctrl/xc_private.h | 33 + 1 file changed, 33 insertions(+)

Re: [PATCH v20210601 04/38] tools: add readv_exact to libxenctrl

2021-06-01 Thread Juergen Gross
On 01.06.21 18:10, Olaf Hering wrote: Read a batch of iovec's. In the common case of short reads, finish individual iov's with read_exact. Signed-off-by: Olaf Hering --- tools/libs/ctrl/xc_private.c | 55 +++- tools/libs/ctrl/xc_private.h | 1 + 2 files cha

Re: [PATCH v20210601 01/38] tools: add API to work with sevaral bits at once

2021-06-01 Thread Juergen Gross
On 01.06.21 18:10, Olaf Hering wrote: Introduce new API to test if a fixed number of bits is clear or set, and clear or set them all at once. More precise: the new functions check whether BITS_PER_LONG bits are set or clear. The caller has to make sure the input bitnumber is a multiply of BIT

Re: [PATCH v20210601 00/38] leftover from 2020

2021-06-01 Thread Juergen Gross
On 01.06.21 18:10, Olaf Hering wrote: Various unreviewed changes, rebase to 57f68dfd2d. Would it be possible to split this into multiple independent patches/series? Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signat

Re: [PATCH v20210601 02/38] xl: fix description of migrate --debug

2021-06-01 Thread Juergen Gross
On 01.06.21 18:10, Olaf Hering wrote: xl migrate --debug used to track every pfn in every batch of pages. But these times are gone. Adjust the help text to tell what --debug is supposed to do today. Signed-off-by: Olaf Hering --- docs/man/xl.1.pod.in | 4 +++- tools/libs/guest/xg_sr

[linux-linus test] 162329: regressions - FAIL

2021-06-01 Thread osstest service owner
flight 162329 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/162329/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd

[PATCH] autoconf: fix handling absolute $PYTHON path

2021-06-01 Thread Marek Marczykowski-Górecki
Don't strip full path from $PYTHON variable. This is especially relevant, if it points outside of $PATH. This is the case for RPM build on CentOS 8 (%{python3} macro points at /usr/libexec/platform-python). For this reason, adjust also python-config handling - AC_PATH_PROG doesn't work on already

[qemu-mainline test] 162328: regressions - FAIL

2021-06-01 Thread osstest service owner
flight 162328 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/162328/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-am

Re: [PATCH v4 3/4] xen: Add files needed for minimal riscv build

2021-06-01 Thread Connor Davis
On 6/1/21 2:40 AM, Julien Grall wrote: Hi, On 01/06/2021 07:03, Jan Beulich wrote: On 01.06.2021 04:26, Connor Davis wrote: On 5/25/21 12:13 PM, Bob Eshleman wrote: On 5/25/21 1:48 AM, Jan Beulich wrote: On 24.05.2021 16:34, Connor Davis wrote: Add arch-specific makefiles and configs n

Re: [PATCH v4 3/4] xen: Add files needed for minimal riscv build

2021-06-01 Thread Connor Davis
On 6/1/21 12:11 AM, Jan Beulich wrote: On 24.05.2021 16:34, Connor Davis wrote: Add arch-specific makefiles and configs needed to build for riscv. Also add a minimal head.S that is a simple infinite loop. head.o can be built with $ make XEN_TARGET_ARCH=riscv SUBSYSTEMS=xen -C xen tiny64_defc

Re: [RFC PATCH V3 09/11] HV/IOMMU: Enable swiotlb bounce buffer for Isolation VM

2021-06-01 Thread Boris Ostrovsky
On 5/30/21 11:06 AM, Tianyu Lan wrote: > @@ -91,6 +92,6 @@ int pci_xen_swiotlb_init_late(void) > EXPORT_SYMBOL_GPL(pci_xen_swiotlb_init_late); > > IOMMU_INIT_FINISH(2, > - NULL, > + hyperv_swiotlb_detect, > pci_xen_swiotlb_init, > NU

[xen-unstable test] 162325: tolerable FAIL

2021-06-01 Thread osstest service owner
flight 162325 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/162325/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 162282 test-amd64-amd64-qemuu-nested-amd 20

[ovmf test] 162326: all pass - PUSHED

2021-06-01 Thread osstest service owner
flight 162326 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/162326/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf fdf3666f01a2dd02d83a808f609b9c744a74c652 baseline version: ovmf d3ff5dbe1dfc3420e5254

[xen-unstable-smoke test] 162327: tolerable all pass - PUSHED

2021-06-01 Thread osstest service owner
flight 162327 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/162327/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[linux-linus test] 162310: regressions - FAIL

2021-06-01 Thread osstest service owner
flight 162310 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/162310/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd

[PATCH v20210601 36/38] tools: use superpages during restore of HVM guest

2021-06-01 Thread Olaf Hering
During creating of a HVM domU meminit_hvm() tries to map superpages. After save/restore or migration this mapping is lost, everything is allocated in single pages. This causes a performance degradation after migration. Add neccessary code to preallocate a superpage for an incoming chunk of pfns. I

[PATCH v20210601 34/38] tools: add API for expandable bitmaps

2021-06-01 Thread Olaf Hering
Since the incoming migration stream lacks info about what the highest pfn will be, data structures can not be allocated upfront. Add an API for expandable bitmaps, loosely based on pfn_set_populated. Signed-off-by: Olaf Hering --- tools/libs/saverestore/common.c | 40 tools

[PATCH v20210601 28/38] tools: adjust libxl_domain_suspend to receive a struct props

2021-06-01 Thread Olaf Hering
Upcoming changes will pass more knobs down to xc_domain_save. Adjust the libxl_domain_suspend API to allow easy adding of additional knobs. No change in behavior intented. Signed-off-by: Olaf Hering Acked-by: Christian Lindig --- tools/include/libxl.h| 26 ++

[PATCH v20210601 35/38] tools: use xg_sr_bitmap for populated_pfns

2021-06-01 Thread Olaf Hering
Signed-off-by: Olaf Hering --- tools/libs/saverestore/common.h | 21 +++- tools/libs/saverestore/restore.c | 69 tools/libs/saverestore/restore_x86_hvm.c | 9 tools/libs/saverestore/restore_x86_pv.c | 7 +++ 4 files changed, 35 insertions(+),

[PATCH v20210601 32/38] tools: add --min_remaining to libxl_domain_suspend

2021-06-01 Thread Olaf Hering
The decision to stop+move a domU to the new host must be based on two factors: - the available network bandwidth for the migration stream - the maximum time a workload within a domU can be savely suspended Both values define how many dirty pages a workload may produce prior the final stop+move. T

[PATCH v20210601 30/38] tools: add callback to libxl for precopy_policy and precopy_stats_t

2021-06-01 Thread Olaf Hering
This duplicates simple_precopy_policy. To recap its purpose: - do up to 5 iterations of copying dirty domU memory to target, including the initial copying of all domU memory, excluding the final copying while the domU is suspended - do fewer iterations in case the domU dirtied less than 50 page

[PATCH v20210601 26/38] tools/guest: restore: write data directly into guest

2021-06-01 Thread Olaf Hering
Read incoming migration stream directly into the guest memory. This avoids the memory allocation and copying, and the resulting performance penalty. Signed-off-by: Olaf Hering --- tools/libs/saverestore/common.h | 1 + tools/libs/saverestore/restore.c | 132 ++- 2

[PATCH v20210601 21/38] tools/guest: restore: move map_errs array

2021-06-01 Thread Olaf Hering
Remove allocation from hotpath, move map_errs array into preallocated space. Signed-off-by: Olaf Hering --- tools/libs/saverestore/common.h | 1 + tools/libs/saverestore/restore.c | 12 +--- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/tools/libs/saverestore/common.h

[PATCH v20210601 25/38] tools/guest: restore: split handle_page_data

2021-06-01 Thread Olaf Hering
handle_page_data must be able to read directly into mapped guest memory. This will avoid unneccesary memcpy calls for data that can be consumed verbatim. Split the various steps of record processing: - move processing to handle_buffered_page_data - adjust xenforeignmemory_map to set errno in case

[PATCH v20210601 33/38] tools: add --abort_if_busy to libxl_domain_suspend

2021-06-01 Thread Olaf Hering
Provide a knob to the host admin to abort the live migration of a running domU if the downtime during final transit will be too long for the workload within domU. Adjust error reporting. Add ERROR_MIGRATION_ABORTED to allow callers of libxl_domain_suspend to distinguish between errors and the requ

[PATCH v20210601 24/38] tools/guest: restore: split record processing

2021-06-01 Thread Olaf Hering
handle_page_data must be able to read directly into mapped guest memory. This will avoid unneccesary memcpy calls for data which can be consumed verbatim. Rearrange the code to allow decisions based on the incoming record. This change is preparation for future changes in handle_page_data, no cha

[PATCH v20210601 16/38] tools/guest: save: move guest_data array

2021-06-01 Thread Olaf Hering
Remove allocation from hotpath, move guest_data array into preallocated space. Because this was allocated with calloc: Adjust the loop to clear unused entries as needed. Signed-off-by: Olaf Hering --- tools/libs/saverestore/common.h | 2 ++ tools/libs/saverestore/save.c | 11 ++- 2 f

[PATCH v20210601 23/38] tools/guest: restore: move pfns array in populate_pfns

2021-06-01 Thread Olaf Hering
Remove allocation from hotpath, move populate_pfns' pfns array into preallocated space. Use some prefix to avoid conflict with an array used in handle_page_data. Signed-off-by: Olaf Hering --- tools/libs/saverestore/common.h | 1 + tools/libs/saverestore/restore.c | 11 +-- 2 files ch

[PATCH v20210601 18/38] tools/guest: restore: move pfns array

2021-06-01 Thread Olaf Hering
Remove allocation from hotpath, move pfns array into preallocated space. Signed-off-by: Olaf Hering --- tools/libs/saverestore/common.h | 2 ++ tools/libs/saverestore/restore.c | 6 ++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/libs/saverestore/common.h b/tools/lib

[PATCH v20210601 19/38] tools/guest: restore: move types array

2021-06-01 Thread Olaf Hering
Remove allocation from hotpath, move types array into preallocated space. Signed-off-by: Olaf Hering --- tools/libs/saverestore/common.h | 1 + tools/libs/saverestore/restore.c | 12 +--- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/tools/libs/saverestore/common.h b/

[PATCH v20210601 03/38] tools: create libxensaverestore

2021-06-01 Thread Olaf Hering
Move all save/restore related code from libxenguest.so into a separate library libxensaverestore.so. The only consumer is libxl-save-helper. There is no need to have the moved code mapped all the time in binaries where libxenguest.so is used. According to size(1) the change is: textdata

[PATCH v20210601 37/38] tools: remove migration stream verify code

2021-06-01 Thread Olaf Hering
The verify code tries to make sure the transferred pages from the paused domU were received correctly in the previous, final iteration. Every page is transferred once again by the sender, the receiver compares the content with what is already mapped into the not-yet started domU. This does unfortu

[PATCH v20210601 31/38] tools: add --max_iters to libxl_domain_suspend

2021-06-01 Thread Olaf Hering
Migrating a large, and potentially busy, domU will take more time than neccessary due to excessive number of copying iterations. Allow to host admin to control the number of iterations which copy cumulated domU dirty pages to the target host. The default remains 5, which means one initial iterati

[PATCH v20210601 38/38] hotplug/Linux: fix starting of xenstored with restarting systemd

2021-06-01 Thread Olaf Hering
A hard to trigger race with another unrelated systemd service and xenstored.service unveiled a bug in the way how xenstored is launched with systemd. launch-xenstore may start either a daemon or a domain. In case a domain is used, systemd-notify was called. If another service triggered a restart o

[PATCH v20210601 29/38] tools: change struct precopy_stats to precopy_stats_t

2021-06-01 Thread Olaf Hering
This will help libxl_save_msgs_gen.pl to copy the struct as a region of memory. No change in behavior intented. Signed-off-by: Olaf Hering --- tools/include/xensaverestore.h | 7 +++ tools/libs/saverestore/common.h | 2 +- tools/libs/saverestore/save.c | 6 +++--- 3 files changed, 7 inse

[PATCH v20210601 27/38] tools: recognize LIBXL_API_VERSION for 4.16

2021-06-01 Thread Olaf Hering
This is required by upcoming API changes. Signed-off-by: Olaf Hering --- tools/include/libxl.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/include/libxl.h b/tools/include/libxl.h index ae7fe27c1f..29931626a2 100644 --- a/tools/include/libxl.h +++ b/tools/include/l

[PATCH v20210601 15/38] tools/guest: save: move rec_pfns array

2021-06-01 Thread Olaf Hering
Remove allocation from hotpath, move rec_pfns array into preallocated space. Signed-off-by: Olaf Hering --- tools/libs/saverestore/common.h | 2 ++ tools/libs/saverestore/save.c | 11 +-- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/tools/libs/saverestore/common.h b

[PATCH v20210601 22/38] tools/guest: restore: move mfns array in populate_pfns

2021-06-01 Thread Olaf Hering
Remove allocation from hotpath, move populate_pfns mfns array into preallocated space. Use some prefix to avoid conflict with an array used in handle_page_data. Signed-off-by: Olaf Hering --- tools/libs/saverestore/common.h | 2 ++ tools/libs/saverestore/restore.c | 5 ++--- 2 files changed, 4

[PATCH v20210601 14/38] tools/guest: save: move iov array

2021-06-01 Thread Olaf Hering
Remove allocation from hotpath, move iov array into preallocated space. Signed-off-by: Olaf Hering --- tools/libs/saverestore/common.h | 2 ++ tools/libs/saverestore/save.c | 7 ++- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/tools/libs/saverestore/common.h b/tools/libs/

[PATCH v20210601 13/38] tools/guest: save: move errors array

2021-06-01 Thread Olaf Hering
Remove allocation from hotpath, move errors array into preallocated space. Signed-off-by: Olaf Hering --- tools/libs/saverestore/common.h | 2 ++ tools/libs/saverestore/save.c | 7 ++- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/tools/libs/saverestore/common.h b/tools/li

[PATCH v20210601 17/38] tools/guest: save: move local_pages array

2021-06-01 Thread Olaf Hering
Remove allocation from hotpath, move local_pages array into preallocated space. Adjust the code to use the src page as is in case of HVM. In case of PV the page may need to be normalised, use an private memory area for this purpose. Signed-off-by: Olaf Hering --- tools/libs/saverestore/common.h

[PATCH v20210601 20/38] tools/guest: restore: move mfns array

2021-06-01 Thread Olaf Hering
Remove allocation from hotpath, move mfns array into preallocated space. Signed-off-by: Olaf Hering --- tools/libs/saverestore/common.h | 2 ++ tools/libs/saverestore/restore.c | 5 ++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/libs/saverestore/common.h b/tools/libs

[PATCH v20210601 11/38] tools/guest: save: move mfns array

2021-06-01 Thread Olaf Hering
Remove allocation from hotpath, move mfns array into preallocated space. Signed-off-by: Olaf Hering --- tools/libs/saverestore/common.h | 2 ++ tools/libs/saverestore/save.c | 7 ++- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/tools/libs/saverestore/common.h b/tools/libs

[PATCH v20210601 08/38] tools: show migration transfer rate in send_dirty_pages

2021-06-01 Thread Olaf Hering
Show how fast domU pages are transferred in each iteration. The relevant data is how fast the pfns travel, not so much how much protocol overhead exists. So the reported MiB/sec is just for pfns. Signed-off-by: Olaf Hering --- tools/libs/saverestore/common.h | 2 ++ tools/libs/saverestore/save

[PATCH v20210601 10/38] tools/guest: save: move batch_pfns

2021-06-01 Thread Olaf Hering
The batch_pfns array is already allocated in advance. Move it into the preallocated area. Signed-off-by: Olaf Hering --- tools/libs/saverestore/common.h | 2 +- tools/libs/saverestore/save.c | 25 +++-- 2 files changed, 12 insertions(+), 15 deletions(-) diff --git a/tools

[PATCH v20210601 02/38] xl: fix description of migrate --debug

2021-06-01 Thread Olaf Hering
xl migrate --debug used to track every pfn in every batch of pages. But these times are gone. Adjust the help text to tell what --debug is supposed to do today. Signed-off-by: Olaf Hering --- docs/man/xl.1.pod.in | 4 +++- tools/libs/guest/xg_sr_save.c | 2 +- tools/xl/xl_cmdtable.c

[PATCH v20210601 12/38] tools/guest: save: move types array

2021-06-01 Thread Olaf Hering
Remove allocation from hotpath, move types array into preallocated space. Signed-off-by: Olaf Hering --- tools/libs/saverestore/common.h | 2 ++ tools/libs/saverestore/save.c | 7 ++- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/tools/libs/saverestore/common.h b/tools/lib

[PATCH v20210601 05/38] tools: add xc_is_known_page_type to libxenctrl

2021-06-01 Thread Olaf Hering
Users of xc_get_pfn_type_batch may want to sanity check the data returned by Xen. Add a simple helper for this purpose. Signed-off-by: Olaf Hering --- tools/libs/ctrl/xc_private.h | 33 + 1 file changed, 33 insertions(+) diff --git a/tools/libs/ctrl/xc_private.h

[PATCH v20210601 09/38] tools/guest: prepare to allocate arrays once

2021-06-01 Thread Olaf Hering
The hotpath 'send_dirty_pages' is supposed to do just one thing: sending. The other end 'handle_page_data' is supposed to do just receiving. But instead both do other costly work like memory allocations and data moving. Do the allocations once, the array sizes are a compiletime constant. Avoid unn

[PATCH v20210601 04/38] tools: add readv_exact to libxenctrl

2021-06-01 Thread Olaf Hering
Read a batch of iovec's. In the common case of short reads, finish individual iov's with read_exact. Signed-off-by: Olaf Hering --- tools/libs/ctrl/xc_private.c | 55 +++- tools/libs/ctrl/xc_private.h | 1 + 2 files changed, 55 insertions(+), 1 deletion(-) diff

[PATCH v20210601 07/38] tools: unify type checking for data pfns in migration stream

2021-06-01 Thread Olaf Hering
Introduce a helper which decides if a given pfn type has data for the migration stream. No change in behavior intended. Signed-off-by: Olaf Hering --- tools/libs/saverestore/common.h | 17 tools/libs/saverestore/restore.c | 34 +--- tools/libs/saver

[PATCH v20210601 06/38] tools: use xc_is_known_page_type

2021-06-01 Thread Olaf Hering
Verify pfn type on sending side, also verify incoming batch of pfns. Signed-off-by: Olaf Hering --- tools/libs/saverestore/restore.c | 3 +-- tools/libs/saverestore/save.c| 6 ++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/tools/libs/saverestore/restore.c b/tools/libs/

[PATCH v20210601 01/38] tools: add API to work with sevaral bits at once

2021-06-01 Thread Olaf Hering
Introduce new API to test if a fixed number of bits is clear or set, and clear or set them all at once. The caller has to make sure the input bitnumber is a multiply of BITS_PER_LONG. This API avoids the loop over each bit in a known range just to see if all of them are either clear or set. Sign

[PATCH v20210601 00/38] leftover from 2020

2021-06-01 Thread Olaf Hering
Various unreviewed changes, rebase to 57f68dfd2d. Olaf Hering (38): tools: add API to work with sevaral bits at once xl: fix description of migrate --debug tools: create libxensaverestore tools: add readv_exact to libxenctrl tools: add xc_is_known_page_type to libxenctrl tools: use xc_

[qemu-mainline test] 162299: regressions - FAIL

2021-06-01 Thread osstest service owner
flight 162299 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/162299/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-am

Re: pci passthrough issue introduced between 4.14.1 and 4.15.0

2021-06-01 Thread AL13N
AL13N schreef op 2021-06-01 16:48: AL13N schreef op 2021-06-01 16:44: Jan Beulich schreef op 2021-06-01 16:33: On 01.06.2021 16:06, AL13N wrote: Jan Beulich schreef op 2021-06-01 12:08: On 01.06.2021 09:36, AL13N wrote: Not 100% it's a bug or something i did wrong, but, with xl create i sta

[XEN PATCH] libs/foreignmemory: Fix osdep_xenforeignmemory_map prototype

2021-06-01 Thread Anthony PERARD
Commit cf8c4d3d13b8 made some preparation to have one day variable-length-array argument, but didn't declare the array in the function prototype the same way as in the function definition. And now GCC 11 complains about it. Fixes: cf8c4d3d13b8 ("tools/libs/foreignmemory: pull array length argument

Re: [PATCH v2] xen/page_alloc: Remove dead code in alloc_domheap_pages()

2021-06-01 Thread Julien Grall
Hi Jan, On 27/05/2021 08:15, Jan Beulich wrote: On 26.05.2021 18:11, Julien Grall wrote: From: Julien Grall Since commit 1aac966e24e9 "xen: support RAM at addresses 0 and 4096", bits_to_zone() will never return 0 and it is expected that we have minimum 2 zones. Therefore the check in alloc_d

Re: pci passthrough issue introduced between 4.14.1 and 4.15.0

2021-06-01 Thread Jan Beulich
On 01.06.2021 16:44, AL13N wrote: > This mailing list is the correct place for the toolstack too? right? Yes. Jan

Re: pci passthrough issue introduced between 4.14.1 and 4.15.0

2021-06-01 Thread AL13N
AL13N schreef op 2021-06-01 16:44: Jan Beulich schreef op 2021-06-01 16:33: On 01.06.2021 16:06, AL13N wrote: Jan Beulich schreef op 2021-06-01 12:08: On 01.06.2021 09:36, AL13N wrote: Not 100% it's a bug or something i did wrong, but, with xl create i start a PV with 3 pci passthroughs aft

Re: pci passthrough issue introduced between 4.14.1 and 4.15.0

2021-06-01 Thread AL13N
Jan Beulich schreef op 2021-06-01 16:33: On 01.06.2021 16:06, AL13N wrote: Jan Beulich schreef op 2021-06-01 12:08: On 01.06.2021 09:36, AL13N wrote: Not 100% it's a bug or something i did wrong, but, with xl create i start a PV with 3 pci passthroughs after wards, xl pci-list shows all 3 ni

Re: pci passthrough issue introduced between 4.14.1 and 4.15.0

2021-06-01 Thread Jan Beulich
On 01.06.2021 16:06, AL13N wrote: > Jan Beulich schreef op 2021-06-01 12:08: >> On 01.06.2021 09:36, AL13N wrote: >>> Not 100% it's a bug or something i did wrong, but, >>> >>> with xl create i start a PV with 3 pci passthroughs >>> >>> after wards, xl pci-list shows all 3 nicely >>> >>> looking at

Re: pci passthrough issue introduced between 4.14.1 and 4.15.0

2021-06-01 Thread AL13N
AL13N schreef op 2021-06-01 16:06: Jan Beulich schreef op 2021-06-01 12:08: On 01.06.2021 09:36, AL13N wrote: Not 100% it's a bug or something i did wrong, but, with xl create i start a PV with 3 pci passthroughs after wards, xl pci-list shows all 3 nicely looking at the domU boot logs, pcif

Re: [PATCH v3 01/11] xen/manage: keep track of the on-going suspend mode

2021-06-01 Thread Boris Ostrovsky
On 5/28/21 5:50 PM, Anchal Agarwal wrote: > That only fails during boot but not after the control jumps into the image. > The > non boot cpus are brought offline(freeze_secondary_cpus) and then online via > cpu hotplug path. In that case xen_vcpu_setup doesn't invokes the hypercall > again.

Re: pci passthrough issue introduced between 4.14.1 and 4.15.0

2021-06-01 Thread AL13N
Jan Beulich schreef op 2021-06-01 12:08: On 01.06.2021 09:36, AL13N wrote: Not 100% it's a bug or something i did wrong, but, with xl create i start a PV with 3 pci passthroughs after wards, xl pci-list shows all 3 nicely looking at the domU boot logs, pcifront is only creating one pci devic

Re: [PATCH v6 1/3] evtchn: slightly defer lock acquire where possible

2021-06-01 Thread Jan Beulich
On 27.05.2021 20:48, Julien Grall wrote: > On 27/05/2021 12:28, Jan Beulich wrote: >> port_is_valid() and evtchn_from_port() are fine to use without holding >> any locks. Accordingly acquire the per-domain lock slightly later in >> evtchn_close() and evtchn_bind_vcpu(). > > So I agree that port_is

[ovmf test] 162288: all pass - PUSHED

2021-06-01 Thread osstest service owner
flight 162288 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/162288/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d3ff5dbe1dfc3420e5254d290500c0b6f6282d17 baseline version: ovmf fe5da0927aad98f3c0050

[xen-unstable test] 162282: tolerable FAIL - PUSHED

2021-06-01 Thread osstest service owner
flight 162282 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/162282/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 162269 test-amd64-amd64-qemuu-nested-amd 20

[XEN PATCH] tools/firmware/ovmf: Use OvmfXen platform file is exist

2021-06-01 Thread Anthony PERARD
A platform introduced in EDK II named OvmfXen is now the one to use for Xen instead of OvmfX64. It comes with PVH support. Also, the Xen support in OvmfX64 is deprecated, "deprecation notice: *dynamic* multi-VMM (QEMU vs. Xen) support in OvmfPkg" https://edk2.groups.io/g/devel/message/7549

Re: pci passthrough issue introduced between 4.14.1 and 4.15.0

2021-06-01 Thread Jan Beulich
On 01.06.2021 09:36, AL13N wrote: > Not 100% it's a bug or something i did wrong, but, > > with xl create i start a PV with 3 pci passthroughs > > after wards, xl pci-list shows all 3 nicely > > looking at the domU boot logs, pcifront is only creating one pci device > and lspci in the guest sho

Re: pci passthrough issue introduced between 4.14.1 and 4.15.0

2021-06-01 Thread George Dunlap
On Tue, Jun 1, 2021 at 8:34 AM AL13N wrote: > Not 100% it's a bug or something i did wrong, but, > > with xl create i start a PV with 3 pci passthroughs > > after wards, xl pci-list shows all 3 nicely > > looking at the domU boot logs, pcifront is only creating one pci device > and lspci in the g

Re: [PATCH v4 3/4] xen: Add files needed for minimal riscv build

2021-06-01 Thread Julien Grall
Hi, On 01/06/2021 07:03, Jan Beulich wrote: On 01.06.2021 04:26, Connor Davis wrote: On 5/25/21 12:13 PM, Bob Eshleman wrote: On 5/25/21 1:48 AM, Jan Beulich wrote: On 24.05.2021 16:34, Connor Davis wrote: Add arch-specific makefiles and configs needed to build for riscv. Also add a minima

pci passthrough issue introduced between 4.14.1 and 4.15.0

2021-06-01 Thread AL13N
Not 100% it's a bug or something i did wrong, but, with xl create i start a PV with 3 pci passthroughs after wards, xl pci-list shows all 3 nicely looking at the domU boot logs, pcifront is only creating one pci device and lspci in the guest shows only 1 pci entry in at least 4.14.1 it still

pci passthrough issue introduced between 4.14.1 and 4.15.0

2021-06-01 Thread AL13N
Not 100% it's a bug or something i did wrong, but, with xl create i start a PV with 3 pci passthroughs after wards, xl pci-list shows all 3 nicely looking at the domU boot logs, pcifront is only creating one pci device and lspci in the guest shows only 1 pci entry in at least 4.14.1 it still

[linux-linus test] 162279: regressions - FAIL

2021-06-01 Thread osstest service owner
flight 162279 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/162279/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd