Re: pci passthrough issue introduced between 4.14.1 and 4.15.0

2021-06-03 Thread Jan Beulich
On 03.06.2021 18:01, AL13N wrote: > Jan Beulich schreef op 2021-06-01 16:53: >> On 01.06.2021 16:44, AL13N wrote: >>> This mailing list is the correct place for the toolstack too? right? >> >> Yes. > > So, what's the plan to fix this? is the plan to fix the toolstack? or > put your patch in kerne

Re: [PATCH 04/13] cpufreq: Add Hardware P-State (HWP) driver

2021-06-03 Thread Jan Beulich
On 03.06.2021 13:55, Jason Andryuk wrote: > On Fri, May 28, 2021 at 2:35 AM Jan Beulich wrote: >> On 27.05.2021 20:50, Jason Andryuk wrote: >>> On Wed, May 26, 2021 at 11:00 AM Jan Beulich wrote: On 03.05.2021 21:28, Jason Andryuk wrote: > +hwp_verbose("HWP: FAST_IA32_HWP_REQUEST %ss

SR-IOV: do we need to virtualize in Xen or rely on Dom0?

2021-06-03 Thread Oleksandr Andrushchenko
Hi, all! While working on PCI SR-IOV support for ARM I started porting [1] on top of current PCI on ARM support [2]. The question I have for this series is if we really need emulating SR-IOV code in Xen? I have implemented a PoC for SR-IOV on ARM [3] (please see the top 2 patches) and it "works

[PATCH v2 6/6] tools/libs/guest: make some definitions private to libxenguest

2021-06-03 Thread Juergen Gross
There are some definitions which are used in libxenguest only now. Move them from libxenctrl over to libxenguest. Remove an unused macro. Signed-off-by: Juergen Gross Acked-by: Wei Liu --- tools/libs/ctrl/xc_private.h | 32 tools/libs/guest/xg_core.h | 2

[PATCH v2 5/6] tools/libs: move xc_core* from libxenctrl to libxenguest

2021-06-03 Thread Juergen Gross
The functionality in xc_core* should be part of libxenguest instead of libxenctrl. Users are already either in libxenguest, or in xl. There is one single exception: xc_core_arch_auto_translated_physmap() is being used by xc_domain_memory_mapping(), which is used by qemu. So leave the xc_core_arch_a

[PATCH v2 3/6] tools/libs/ctrl: use common p2m mapping code in xc_domain_resume_any()

2021-06-03 Thread Juergen Gross
Instead of open coding the mapping of the p2m list use the already existing xc_core_arch_map_p2m() call, especially as the current code does not support guests with the linear p2m map. It should be noted that this code is needed for colo/remus only. Switching to xc_core_arch_map_p2m() drops the ne

[PATCH v2 2/6] tools/libs/ctrl: fix xc_core_arch_map_p2m() to support linear p2m table

2021-06-03 Thread Juergen Gross
The core of a pv linux guest produced via "xl dump-core" is nor usable as since kernel 4.14 only the linear p2m table is kept if Xen indicates it is supporting that. Unfortunately xc_core_arch_map_p2m() is still supporting the 3-level p2m tree only. Fix that by copying the functionality of map_p2m

[PATCH v2 0/6] tools/libs: add missing support of linear p2m_list, cleanup

2021-06-03 Thread Juergen Gross
This is a resend of V2 with the Acks folded in. There are some corners left which don't support the not so very new linear p2m list of pv guests, which has been introduced in Linux kernel 3.19 and which is mandatory for non-legacy versions of Xen since kernel 4.14. This series adds support for th

[PATCH v2 1/6] tools/libs/guest: fix max_pfn setting in map_p2m()

2021-06-03 Thread Juergen Gross
When setting the highest pfn used in the guest, don't subtract 1 from the value read from the shared_info data. The value read already is the correct pfn. Fixes: 91e204d37f449 ("libxc: try to find last used pfn when migrating") Signed-off-by: Juergen Gross Acked-by: Wei Liu --- This is a backpor

[PATCH v2 4/6] tools/libs: move xc_resume.c to libxenguest

2021-06-03 Thread Juergen Gross
The guest suspend functionality is already part of libxenguest. Move the resume functionality from libxenctrl to libxenguest, too. Signed-off-by: Juergen Gross Acked-by: Wei Liu --- tools/include/xenctrl.h | 63 --- tools/include/xenguest.h

RE: [PATCH 01/10] xen/arm: introduce domain on Static Allocation

2021-06-03 Thread Penny Zheng
Hi stefano and julien > -Original Message- > From: Stefano Stabellini > Sent: Friday, June 4, 2021 7:56 AM > To: Julien Grall > Cc: Stefano Stabellini ; Penny Zheng > ; xen-devel@lists.xenproject.org; Bertrand Marquis > ; Wei Chen ; nd > > Subject: Re: [PATCH 01/10] xen/arm: introduce

[linux-linus test] 162354: regressions - FAIL

2021-06-03 Thread osstest service owner
flight 162354 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/162354/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i3

[PATCH v8 2/2] xen: Add files needed for minimal riscv build

2021-06-03 Thread Connor Davis
Add arch-specific makefiles and configs needed to build for riscv. Also add a minimal head.S that is a simple infinite loop. head.o can be built with $ make XEN_TARGET_ARCH=riscv64 SUBSYSTEMS=xen -C xen tiny64_defconfig $ make XEN_TARGET_ARCH=riscv64 SUBSYSTEMS=xen -C xen TARGET=riscv64/head.o No

[PATCH v8 0/2] Minimal build for RISCV

2021-06-03 Thread Connor Davis
Hi all, This series introduces a minimal build for RISCV. It is based on Bobby's previous work from last year[0] rebased onto current Xen. This series provides the patches necessary to get a minimal build working. The build is "minimal" in the sense that it only supports building TARGET=riscv64/h

[PATCH v8 1/2] xen/char: Default HAS_NS16550 to y only for X86 and ARM

2021-06-03 Thread Connor Davis
Defaulting to yes only for X86 and ARM reduces the requirements for a minimal build when porting new architectures. Signed-off-by: Connor Davis Acked-by: Jan Beulich Reviewed-by: Alistair Francis --- xen/drivers/char/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/drivers/char/

Re: [PATCH v3 01/11] xen/manage: keep track of the on-going suspend mode

2021-06-03 Thread Boris Ostrovsky
On 6/3/21 7:27 PM, Anchal Agarwal wrote: > On Thu, Jun 03, 2021 at 04:11:46PM -0400, Boris Ostrovsky wrote: > >> But if KASLR is on then this comparison not failing should cause xen_vcpu >> pointer in the loaded image to become bogus because xen_vcpu is now >> registered for a different xen_vcp

Re: [PATCH v7 1/2] xen/char: Default HAS_NS16550 to y only for X86 and ARM

2021-06-03 Thread Connor Davis
On 6/3/21 5:27 PM, Alistair Francis wrote: On Thu, Jun 3, 2021 at 9:38 AM Connor Davis wrote: Defaulting to yes only for X86 and ARM reduces the requirements for a minimal build when porting new architectures. Signed-off-by: Connor Davis Acked-by: Jan Beulich Reviewed-by: Alistair Franci

Re: [PATCH v7 2/2] xen: Add files needed for minimal riscv build

2021-06-03 Thread Connor Davis
On 6/3/21 5:33 PM, Alistair Francis wrote: On Thu, Jun 3, 2021 at 9:38 AM Connor Davis wrote: Add arch-specific makefiles and configs needed to build for riscv. Also add a minimal head.S that is a simple infinite loop. head.o can be built with $ make XEN_TARGET_ARCH=riscv64 SUBSYSTEMS=xen -

[qemu-mainline test] 162347: regressions - FAIL

2021-06-03 Thread osstest service owner
flight 162347 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/162347/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-am

Re: [PATCH 01/10] xen/arm: introduce domain on Static Allocation

2021-06-03 Thread Stefano Stabellini
On Thu, 3 Jun 2021, Julien Grall wrote: > On Thu, 3 Jun 2021 at 22:33, Stefano Stabellini > wrote: > > On Thu, 3 Jun 2021, Julien Grall wrote: > > > On 02/06/2021 11:09, Penny Zheng wrote: > > > > I could not think a way to fix it properly in codes, do you have any > > > > suggestion? Or we just

Re: [PATCH v7 2/2] xen: Add files needed for minimal riscv build

2021-06-03 Thread Alistair Francis
On Thu, Jun 3, 2021 at 9:38 AM Connor Davis wrote: > > Add arch-specific makefiles and configs needed to build for > riscv. Also add a minimal head.S that is a simple infinite loop. > head.o can be built with > > $ make XEN_TARGET_ARCH=riscv64 SUBSYSTEMS=xen -C xen tiny64_defconfig > $ make XEN_TA

Re: [PATCH v3 01/11] xen/manage: keep track of the on-going suspend mode

2021-06-03 Thread Anchal Agarwal
On Thu, Jun 03, 2021 at 04:11:46PM -0400, Boris Ostrovsky wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you can confirm the sender and know the > content is safe. > > > > On 6/2/21 3:37 PM, Anchal Agarwal wrote: > > On

Re: [PATCH v7 1/2] xen/char: Default HAS_NS16550 to y only for X86 and ARM

2021-06-03 Thread Alistair Francis
On Thu, Jun 3, 2021 at 9:38 AM Connor Davis wrote: > > Defaulting to yes only for X86 and ARM reduces the requirements > for a minimal build when porting new architectures. > > Signed-off-by: Connor Davis > Acked-by: Jan Beulich Reviewed-by: Alistair Francis Alistair > --- > xen/drivers/cha

Re: [PATCH v4 3/4] xen: Add files needed for minimal riscv build

2021-06-03 Thread Alistair Francis
On Tue, Jun 1, 2021 at 12:26 PM Connor Davis wrote: > > > > On 5/25/21 12:13 PM, Bob Eshleman wrote: > > On 5/25/21 1:48 AM, Jan Beulich wrote: > >> On 24.05.2021 16:34, Connor Davis wrote: > >>> Add arch-specific makefiles and configs needed to build for > >>> riscv. Also add a minimal head.S tha

Re: [PATCH 01/10] xen/arm: introduce domain on Static Allocation

2021-06-03 Thread Julien Grall
Hi, On Thu, 3 Jun 2021 at 22:33, Stefano Stabellini wrote: > On Thu, 3 Jun 2021, Julien Grall wrote: > > On 02/06/2021 11:09, Penny Zheng wrote: > > > I could not think a way to fix it properly in codes, do you have any > > > suggestion? Or we just put a warning in doc/commits. > > > > The correc

Re: [PATCH 01/10] xen/arm: introduce domain on Static Allocation

2021-06-03 Thread Stefano Stabellini
I have not read most emails in this thread (sorry!) but I spotted this discussion about device tree and I would like to reply to that as we have discussed something very similar in the context of system device tree. On Thu, 3 Jun 2021, Julien Grall wrote: > On 02/06/2021 11:09, Penny Zheng wrote:

Re: [PATCH v3 01/11] xen/manage: keep track of the on-going suspend mode

2021-06-03 Thread Boris Ostrovsky
On 6/2/21 3:37 PM, Anchal Agarwal wrote: > On Tue, Jun 01, 2021 at 10:18:36AM -0400, Boris Ostrovsky wrote: >> > The resume won't fail because in the image the xen_vcpu and xen_vcpu_info are > same. These are the same values that got in there during saving of the > hibernation image. So whatever

[qemu-mainline bisection] complete test-amd64-i386-freebsd10-amd64

2021-06-03 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-freebsd10-amd64 testid guest-saverestore Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.

[linux-5.4 test] 162346: tolerable FAIL - PUSHED

2021-06-03 Thread osstest service owner
flight 162346 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/162346/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 162247 test-amd64-i386-xl-qemut-win7-amd64 19

Re: [RFC PATCH V3 09/11] HV/IOMMU: Enable swiotlb bounce buffer for Isolation VM

2021-06-03 Thread Boris Ostrovsky
On 6/3/21 11:37 AM, Tianyu Lan wrote: > > Yes, the dependency is between hyperv_swiotlb_detect() and > pci_swiotlb_detect_override()/pci_swiotlb_detect_4gb(). Now > pci_swiotlb_detect_override() and pci_swiotlb_detect_4gb() depends on > pci_xen_swiotlb_detect(). To keep dependency between > hyper

[linux-linus test] 162344: regressions - FAIL

2021-06-03 Thread osstest service owner
flight 162344 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/162344/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd

[PATCH v4] tools/libs/store: cleanup libxenstore interface

2021-06-03 Thread Ian Jackson
Juergen Gross writes ("[PATCH v4] tools/libs/store: cleanup libxenstore interface"): > There are some internals in the libxenstore interface which should be > removed. Thanks. And sorry for not reviewing this sooner. > Move those functions into xs_lib.c and the related definitions into > xs_lib

Re: pci passthrough issue introduced between 4.14.1 and 4.15.0

2021-06-03 Thread AL13N
Jan Beulich schreef op 2021-06-01 16:53: On 01.06.2021 16:44, AL13N wrote: This mailing list is the correct place for the toolstack too? right? Yes. So, what's the plan to fix this? is the plan to fix the toolstack? or put your patch in kernel to kinda workaround it? Is there a way to mak

Re: [PATCH 08/30] mspro: use blk_mq_alloc_disk

2021-06-03 Thread Ulf Hansson
On Wed, 2 Jun 2021 at 08:54, Christoph Hellwig wrote: > > Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue > allocation. > > Signed-off-by: Christoph Hellwig Acked-by: Ulf Hansson Kind regards Uffe > --- > drivers/memstick/core/mspro_block.c | 26 +++--

Re: [PATCH 07/30] ms_block: use blk_mq_alloc_disk

2021-06-03 Thread Ulf Hansson
On Wed, 2 Jun 2021 at 08:54, Christoph Hellwig wrote: > > Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue > allocation. > > Signed-off-by: Christoph Hellwig Acked-by: Ulf Hansson Kind regards Uffe > --- > drivers/memstick/core/ms_block.c | 25 ++--

Re: [RFC PATCH V3 09/11] HV/IOMMU: Enable swiotlb bounce buffer for Isolation VM

2021-06-03 Thread Tianyu Lan
On 6/3/2021 12:02 AM, Boris Ostrovsky wrote: On 6/2/21 11:01 AM, Tianyu Lan wrote: Hi Boris: Thanks for your review. On 6/2/2021 9:16 AM, Boris Ostrovsky wrote: On 5/30/21 11:06 AM, Tianyu Lan wrote: @@ -91,6 +92,6 @@ int pci_xen_swiotlb_init_late(void)   EXPORT_SYMBOL_GPL(pci_xen_swi

Re: [PATCH v4] tools/libs/store: cleanup libxenstore interface

2021-06-03 Thread Juergen Gross
Ping? On 12.05.21 16:48, Juergen Gross wrote: There are some internals in the libxenstore interface which should be removed. Move those functions into xs_lib.c and the related definitions into xs_lib.h. Remove the functions from the mapfile. Add xs_lib.o to xenstore_client as some of the intern

Re: [XEN PATCH v2] libxl/arm: provide guests with random seed

2021-06-03 Thread Julien Grall
Hi, On 27/05/2021 09:52, Sergiy Kibrik wrote: Pass 128 bytes of random seed via FDT, so that guests' CRNGs are better seeded early at boot. This is larger than ChaCha20 key size of 32, so each byte of CRNG state will be mixed 4 times using this seed. There does not seem to be advantage in larger

[PATCH] MAINTAINERS: adjust x86/mm/shadow maintainers

2021-06-03 Thread Tim Deegan
Better reflect reality: Andrew and Jan are active maintainers and I review patches. Keep myself as a reviewer so I can help with historical context &c. Signed-off-by: Tim Deegan --- MAINTAINERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git MAINTAINERS MAINTAINERS index d4

[xen-unstable test] 162343: tolerable FAIL

2021-06-03 Thread osstest service owner
flight 162343 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/162343/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 162337 test-amd64-amd64-qemuu-nested-amd 20

Re: [PATCH 04/13] cpufreq: Add Hardware P-State (HWP) driver

2021-06-03 Thread Jason Andryuk
On Fri, May 28, 2021 at 2:35 AM Jan Beulich wrote: > > On 27.05.2021 20:50, Jason Andryuk wrote: > > On Wed, May 26, 2021 at 11:00 AM Jan Beulich wrote: > >> > >> On 03.05.2021 21:28, Jason Andryuk wrote: > >>> +hwp_verbose("HWP: FAST_IA32_HWP_REQUEST %ssupported\n", > >>> +ea

[qemu-mainline test] 162342: regressions - FAIL

2021-06-03 Thread osstest service owner
flight 162342 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/162342/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-am

Re: [PATCH v2 07/12] mm: allow page scrubbing routine(s) to be arch controlled

2021-06-03 Thread Julien Grall
Hi Jan, On 27/05/2021 14:58, Jan Beulich wrote: On 27.05.2021 15:06, Julien Grall wrote: On 27/05/2021 13:33, Jan Beulich wrote: Especially when dealing with large amounts of memory, memset() may not be very efficient; this can be bad enough that even for debug builds a custom function is warr

Re: [PATCH 01/10] xen/arm: introduce domain on Static Allocation

2021-06-03 Thread Julien Grall
Hi, On 02/06/2021 11:09, Penny Zheng wrote: Hi Julien -Original Message- From: Julien Grall Sent: Thursday, May 20, 2021 4:51 PM To: Penny Zheng ; xen-devel@lists.xenproject.org; sstabell...@kernel.org Cc: Bertrand Marquis ; Wei Chen ; nd Subject: Re: [PATCH 01/10] xen/arm: introduce