Re: [PATCH 4/8] xen/blkfront: don't trust the backend response data blindly

2021-07-07 Thread Juergen Gross
On 08.07.21 08:52, Jan Beulich wrote: On 08.07.2021 08:40, Juergen Gross wrote: On 08.07.21 08:37, Jan Beulich wrote: On 08.07.2021 07:47, Juergen Gross wrote: On 17.05.21 17:33, Jan Beulich wrote: On 17.05.2021 17:22, Juergen Gross wrote: On 17.05.21 17:12, Jan Beulich wrote: On 17.05.2021

[PATCH v1] automation: collect log files in subdirectories

2021-07-07 Thread Olaf Hering
The current single *.log pattern collects just config.log, which usually contains little useful information. Collect also log files in subdirectories, tools/config.log usually contains information about configure failures. Signed-off-by: Olaf Hering --- automation/gitlab-ci/build.yaml | 1 + 1 f

Re: [PATCH 4/8] xen/blkfront: don't trust the backend response data blindly

2021-07-07 Thread Jan Beulich
On 08.07.2021 08:40, Juergen Gross wrote: > On 08.07.21 08:37, Jan Beulich wrote: >> On 08.07.2021 07:47, Juergen Gross wrote: >>> On 17.05.21 17:33, Jan Beulich wrote: On 17.05.2021 17:22, Juergen Gross wrote: > On 17.05.21 17:12, Jan Beulich wrote: >> On 17.05.2021 16:23, Juergen Gro

RE: [Kvmtool] Some thoughts on using kvmtool Virtio for Xen

2021-07-07 Thread Wei Chen
Hi Oleksandr, > -Original Message- > From: Xen-devel On Behalf Of > Oleksandr > Sent: 2021年7月6日 20:07 > To: Wei Chen > Cc: Stefano Stabellini ; w...@kernel.org; > julien.thierry.k...@gmail.com; k...@vger.kernel.org; xen- > de...@lists.xen.org; jean-phili...@linaro.org; Julien Grall > ; A

Re: [PATCH 4/8] xen/blkfront: don't trust the backend response data blindly

2021-07-07 Thread Juergen Gross
On 08.07.21 08:37, Jan Beulich wrote: On 08.07.2021 07:47, Juergen Gross wrote: On 17.05.21 17:33, Jan Beulich wrote: On 17.05.2021 17:22, Juergen Gross wrote: On 17.05.21 17:12, Jan Beulich wrote: On 17.05.2021 16:23, Juergen Gross wrote: On 17.05.21 16:11, Jan Beulich wrote: On 13.05.2021

Re: [PATCH 4/8] xen/blkfront: don't trust the backend response data blindly

2021-07-07 Thread Jan Beulich
On 08.07.2021 07:47, Juergen Gross wrote: > On 17.05.21 17:33, Jan Beulich wrote: >> On 17.05.2021 17:22, Juergen Gross wrote: >>> On 17.05.21 17:12, Jan Beulich wrote: On 17.05.2021 16:23, Juergen Gross wrote: > On 17.05.21 16:11, Jan Beulich wrote: >> On 13.05.2021 12:02, Juergen Gro

[PATCH v1] automation: dump contents of /etc/os-release

2021-07-07 Thread Olaf Hering
To aid debugging build failures, dump /etc/os-release during build. This helps with rolling releases such as Tumbleweed to understand the state of the build container. Signed-off-by: Olaf Hering --- automation/scripts/build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/automation/scripts

Re: [PATCH 4/8] xen/blkfront: don't trust the backend response data blindly

2021-07-07 Thread Juergen Gross
On 17.05.21 17:33, Jan Beulich wrote: On 17.05.2021 17:22, Juergen Gross wrote: On 17.05.21 17:12, Jan Beulich wrote: On 17.05.2021 16:23, Juergen Gross wrote: On 17.05.21 16:11, Jan Beulich wrote: On 13.05.2021 12:02, Juergen Gross wrote: @@ -1574,10 +1580,16 @@ static irqreturn_t blkif_int

Re: [PATCH v2 0/4] bus: Make remove callback return void

2021-07-07 Thread Uwe Kleine-König
On Wed, Jul 07, 2021 at 10:08:53PM -0400, Sven Van Asbroeck wrote: > On Tue, Jul 6, 2021 at 11:50 AM Uwe Kleine-König > wrote: > > > > drivers/staging/fieldbus/anybuss/host.c | 4 +--- > > Awesome ! > > Acked-by: Sven Van Asbroeck I note that as an Ack for patch 4 only, as the others don't t

Re: [PATCH v2 0/4] bus: Make remove callback return void

2021-07-07 Thread Sven Van Asbroeck
On Tue, Jul 6, 2021 at 11:50 AM Uwe Kleine-König wrote: > > drivers/staging/fieldbus/anybuss/host.c | 4 +--- Awesome ! Acked-by: Sven Van Asbroeck

Re: [PATCH v2 4/4] bus: Make remove callback return void

2021-07-07 Thread Thorsten Scherer
On Tue, Jul 06, 2021 at 05:48:03PM +0200, Uwe Kleine-König wrote: > The driver core ignores the return value of this callback because there > is only little it can do when a device disappears. > > This is the final bit of a long lasting cleanup quest where several > buses were converted to also

[xen-unstable-smoke test] 163422: tolerable all pass - PUSHED

2021-07-07 Thread osstest service owner
flight 163422 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/163422/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-armhf-armhf-xl 1

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

2021-07-07 Thread Igor Druzhinin
On 07/07/2021 14:21, Julien Grall wrote: On 07/07/2021 14:14, Jan Beulich wrote: On 07.07.2021 14:59, Julien Grall wrote: On 07/07/2021 13:54, Jan Beulich wrote: On 07.07.2021 14:51, Julien Grall wrote: On 07/07/2021 02:02, Igor Druzhinin wrote: Current unit8_t for pirq argument in this inte

[linux-5.4 test] 163402: regressions - trouble: broken/fail/pass

2021-07-07 Thread osstest service owner
flight 163402 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/163402/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-debianhvm-i386-xsm broken test-amd64-amd64-dom0pvh-xl-amd

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

2021-07-07 Thread Igor Druzhinin
On 08/07/2021 02:26, Andrew Cooper wrote: On 08/07/2021 02:14, Igor Druzhinin wrote: On 08/07/2021 02:11, Andrew Cooper wrote: On 08/07/2021 02:08, Igor Druzhinin wrote: On 07/07/2021 10:19, Andrew Cooper wrote: On 07/07/2021 08:46, Jan Beulich wrote: --- a/tools/include/xenctrl.h +++ b/tool

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

2021-07-07 Thread Andrew Cooper
On 08/07/2021 02:14, Igor Druzhinin wrote: > On 08/07/2021 02:11, Andrew Cooper wrote: >> On 08/07/2021 02:08, Igor Druzhinin wrote: >>> On 07/07/2021 10:19, Andrew Cooper wrote: On 07/07/2021 08:46, Jan Beulich wrote: >> --- a/tools/include/xenctrl.h >> +++ b/tools/include/xenctrl.h >

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

2021-07-07 Thread Igor Druzhinin
On 08/07/2021 02:11, Andrew Cooper wrote: On 08/07/2021 02:08, Igor Druzhinin wrote: On 07/07/2021 10:19, Andrew Cooper wrote: On 07/07/2021 08:46, Jan Beulich wrote: --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -1385,7 +1385,7 @@ int xc_domain_ioport_permission(xc_interface

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

2021-07-07 Thread Andrew Cooper
On 08/07/2021 02:08, Igor Druzhinin wrote: > On 07/07/2021 10:19, Andrew Cooper wrote: >> On 07/07/2021 08:46, Jan Beulich wrote: --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -1385,7 +1385,7 @@ int xc_domain_ioport_permission(xc_interface *xch,     int xc_

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

2021-07-07 Thread Igor Druzhinin
On 07/07/2021 10:19, Andrew Cooper wrote: On 07/07/2021 08:46, Jan Beulich wrote: --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -1385,7 +1385,7 @@ int xc_domain_ioport_permission(xc_interface *xch, int xc_domain_irq_permission(xc_interface *xch,

Re: Xen/ARM API issue (page size)

2021-07-07 Thread Andrew Cooper
On 08/07/2021 01:32, Elliott Mitchell wrote: > Hopefully I'm not about to show the limits of my knowledge... > > Quite a few values passed to Xen via hypercalls include a page number. > This makes sense as that maps to the hardware. Problem is, I cannot help > but notice aarch64 allows for 4KB, 16

[ovmf test] 163404: regressions - FAIL

2021-07-07 Thread osstest service owner
flight 163404 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163404/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu

Re: [XEN PATCH 2/2] automation: Check if ninja is available before building QEMU

2021-07-07 Thread Olaf Hering
Am Wed, 7 Jul 2021 23:47:02 +0100 schrieb Andrew Cooper : > We ought to yes, although I think at the moment we probably don't want > to realise how stale all the containers are. At least for Tumbleweed it is useful information. opensuse-tumbleweed.dockerfile requests zlib-devel already. tools/c

Xen/ARM API issue (page size)

2021-07-07 Thread Elliott Mitchell
Hopefully I'm not about to show the limits of my knowledge... Quite a few values passed to Xen via hypercalls include a page number. This makes sense as that maps to the hardware. Problem is, I cannot help but notice aarch64 allows for 4KB, 16KB and 64KB pages. I don't know how flexible aarch64

Re: [XEN PATCH 2/2] automation: Check if ninja is available before building QEMU

2021-07-07 Thread Olaf Hering
Am Wed, 7 Jul 2021 23:44:33 +0100 schrieb Andrew Cooper : > On 07/07/2021 20:52, Olaf Hering wrote: > > Am Wed, 7 Jul 2021 18:46:03 +0100 > > schrieb Andrew Cooper : > >> iPXE failure > > it just needs to be updated to ipxe.git#master to make it compatible with > > gcc11. > Ah great.  I presu

[qemu-mainline bisection] complete test-amd64-amd64-qemuu-freebsd11-amd64

2021-07-07 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-qemuu-freebsd11-amd64 testid guest-start Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits

Re: [XEN PATCH 2/2] automation: Check if ninja is available before building QEMU

2021-07-07 Thread Andrew Cooper
On 07/07/2021 21:35, Olaf Hering wrote: > Am Wed, 7 Jul 2021 18:46:03 +0100 > schrieb Andrew Cooper : > >> Tumbleweed is generally broken and fails at ./configure due to missing >> compression libraries. > Something requests zlib-devel to be installed. Yeah - it shouldn't be hard to fix. > I sugg

Re: [XEN PATCH 2/2] automation: Check if ninja is available before building QEMU

2021-07-07 Thread Andrew Cooper
On 07/07/2021 20:52, Olaf Hering wrote: > Am Wed, 7 Jul 2021 18:46:03 +0100 > schrieb Andrew Cooper : > >> iPXE failure > it just needs to be updated to ipxe.git#master to make it compatible with > gcc11. Ah great.  I presume that is your "[PATCH v2] tools: ipxe: update for fixing build with GCC1

[xen-unstable-smoke test] 163415: trouble: broken/pass

2021-07-07 Thread osstest service owner
flight 163415 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/163415/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-amd64 broken tes

[qemu-mainline test] 163394: regressions - trouble: broken/fail/pass

2021-07-07 Thread osstest service owner
flight 163394 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/163394/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-rtds broken test-amd64-amd64-dom0pvh-xl-amd

Re: [XEN PATCH 2/2] automation: Check if ninja is available before building QEMU

2021-07-07 Thread Olaf Hering
Am Wed, 7 Jul 2021 18:46:03 +0100 schrieb Andrew Cooper : > Tumbleweed is generally broken and fails at ./configure due to missing > compression libraries. Something requests zlib-devel to be installed. I suggest to provide all config.logs, not just the one from the top directory. Also a "test

Re: [XEN PATCH 2/2] automation: Check if ninja is available before building QEMU

2021-07-07 Thread Olaf Hering
Am Wed, 7 Jul 2021 18:46:03 +0100 schrieb Andrew Cooper : > iPXE failure it just needs to be updated to ipxe.git#master to make it compatible with gcc11. Olaf pgpzeULyg8uF4.pgp Description: Digitale Signatur von OpenPGP

[linux-linus test] 163389: regressions - trouble: broken/fail/pass

2021-07-07 Thread osstest service owner
flight 163389 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/163389/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-coresched-i386-xl broken test-amd64-i386-libvirt-xsm

Re: [RESEND PATCH 03/12] golang/xenlight: fix string conversion in generated toC functions

2021-07-07 Thread Nick Rosbrook
On Thu, Jul 01, 2021 at 02:09:47PM +, George Dunlap wrote: > > > > On Jun 21, 2021, at 5:11 PM, Nick Rosbrook wrote: > > > > On Fri, Jun 18, 2021 at 11:00:26AM +, George Dunlap wrote: > >> > >> > >>> On May 24, 2021, at 9:36 PM, Nick Rosbrook wrote: > >>> > >>> In gengotypes.py, the

Re: [GIT PULL] xen: branch for v5.14-rc1

2021-07-07 Thread pr-tracker-bot
The pull request you sent on Wed, 7 Jul 2021 09:01:39 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git > for-linus-5.14-rc1-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/4ea90317956718e0648e1f87e56530db809a5a04 Thank you! -- Deet-doot-dot, I

[xen-unstable-smoke test] 163408: tolerable all pass - PUSHED

2021-07-07 Thread osstest service owner
flight 163408 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/163408/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [XEN PATCH 2/2] automation: Check if ninja is available before building QEMU

2021-07-07 Thread Andrew Cooper
On 07/07/2021 17:40, Anthony PERARD wrote: > ninja is now required to build the latest version of QEMU, some > container still don't have ninja and attempting to add it breaks the > build for different reasons, so QEMU will be skip on those containers. > > Failures: > - ubuntu/xenial: > fatal:

Re: [XEN PATCH 0/2] automation: Fix build with new qemu-xen version

2021-07-07 Thread Anthony PERARD
On Wed, Jul 07, 2021 at 05:39:59PM +0100, Anthony PERARD wrote: > Adding ninja-build pkg when possible. > > I'll push new containers soon. I've pushed: registry.gitlab.com/xen-project/xen/fedora:29 registry.gitlab.com/xen-project/xen/ubuntu:bionic registry.gitlab.com/xen-project/xen/u

[XEN PATCH 2/2] automation: Check if ninja is available before building QEMU

2021-07-07 Thread Anthony PERARD
ninja is now required to build the latest version of QEMU, some container still don't have ninja and attempting to add it breaks the build for different reasons, so QEMU will be skip on those containers. Failures: - ubuntu/xenial: fatal: ninja version (1.5.1) incompatible with build file ninj

[XEN PATCH 0/2] automation: Fix build with new qemu-xen version

2021-07-07 Thread Anthony PERARD
Patch series available in this git branch: https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.automation-add-ninja-v1 Adding ninja-build pkg when possible. I'll push new containers soon. Anthony PERARD (2): automation: Adding ninja-build to some docker images automation: Ch

[XEN PATCH 1/2] automation: Adding ninja-build to some docker images

2021-07-07 Thread Anthony PERARD
This is to allow building the latest version of QEMU. fedora/29: In addition to adding "ninja", I've add to make some other changes: some `go build` failed with `mkdir /.cache` no permission, so I've created a user. (this was discovered while testing the new container with the

Re: [Resend RFC PATCH V4 13/13] x86/HV: Not set memory decrypted/encrypted during kexec alloc/free page in IVM

2021-07-07 Thread Dave Hansen
On 7/7/21 8:46 AM, Tianyu Lan wrote: > @@ -598,7 +599,7 @@ void arch_kexec_unprotect_crashkres(void) > */ > int arch_kexec_post_alloc_pages(void *vaddr, unsigned int pages, gfp_t gfp) > { > - if (sev_active()) > + if (sev_active() || hv_is_isolation_supported()) > return 0

Re: [XEN PATCH v6 23/31] build: fix arch/x86/node.o rule

2021-07-07 Thread Jan Beulich
On 01.07.2021 16:10, Anthony PERARD wrote: > Avoid different spelling for the location of "xen-syms", and simply > use the dependency variable. This avoid the assumption about $(TARGET) > value. > > Signed-off-by: Anthony PERARD Acked-by: Jan Beulich with s/node/note/ in the title (I was very c

Re: A possible pointer_overflow in xen-4.13

2021-07-07 Thread Jan Beulich
On 07.07.2021 17:54, Rroach wrote: > Hi, sorry about the late respond. I tried your suggestion, it works. I'm kind > of surprised too, since such problem should exposed long time ago.  > > > I looked deep into your suggestion. I believe you were right about it, since > p - ctxt->io_emul_stub  w

Re: A possible pointer_overflow in xen-4.13

2021-07-07 Thread Rroach
Hi, sorry about the late respond. I tried your suggestion, it works. I'm kind of surprised too, since such problem should exposed long time ago.  I looked deep into your suggestion. I believe you were right about it, since p - ctxt->io_emul_stub  won't overflow and the pointer overflow is likel

[Resend RFC PATCH V4 11/13] HV/Netvsc: Add Isolation VM support for netvsc driver

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan In Isolation VM, all shared memory with host needs to mark visible to host via hvcall. vmbus_establish_gpadl() has already done it for netvsc rx/tx ring buffer. The page buffer used by vmbus_sendpacket_ pagebuffer() still need to handle. Use DMA API to map/umap these memory durin

[Resend RFC PATCH V4 10/13] HV/IOMMU: Enable swiotlb bounce buffer for Isolation VM

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan Hyper-V Isolation VM requires bounce buffer support to copy data from/to encrypted memory and so enable swiotlb force mode to use swiotlb bounce buffer for DMA transaction. In Isolation VM with AMD SEV, the bounce buffer needs to be accessed via extra address space which is abov

[Resend RFC PATCH V4 08/13] HV/Vmbus: Initialize VMbus ring buffer for Isolation VM

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan VMbus ring buffer are shared with host and it's need to be accessed via extra address space of Isolation VM with SNP support. This patch is to map the ring buffer address in extra address space via ioremap(). HV host visibility hvcall smears data in the ring buffer and so reset t

[Resend RFC PATCH V4 09/13] x86/Swiotlb/HV: Add Swiotlb bounce buffer remap function for HV IVM

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan In Isolation VM with AMD SEV, bounce buffer needs to be accessed via extra address space which is above shared_gpa_boundary (E.G 39 bit address line) reported by Hyper-V CPUID ISOLATION_CONFIG. The access physical address will be original physical address + shared_gpa_boundary. T

[Resend RFC PATCH V4 13/13] x86/HV: Not set memory decrypted/encrypted during kexec alloc/free page in IVM

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan Hyper-V Isolation VM reuses set_memory_decrypted/encrypted function and not needs to decrypted/encrypted in arch_kexec_post_alloc(pre_free) _pages just likes AMD SEV VM. So skip them. Signed-off-by: Tianyu Lan --- arch/x86/kernel/machine_kexec_64.c | 5 +++-- 1 file changed, 3

[Resend RFC PATCH V4 12/13] HV/Storvsc: Add Isolation VM support for storvsc driver

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan In Isolation VM, all shared memory with host needs to mark visible to host via hvcall. vmbus_establish_gpadl() has already done it for storvsc rx/tx ring buffer. The page buffer used by vmbus_sendpacket_ mpb_desc() still need to handle. Use DMA API to map/umap these memory during

Re: [XEN PATCH v6 17/31] build: convert binfile use to if_changed

2021-07-07 Thread Jan Beulich
On 01.07.2021 16:09, Anthony PERARD wrote: > --- a/xen/common/Makefile > +++ b/xen/common/Makefile > @@ -80,8 +80,12 @@ config.gz: $(CONF_FILE) > > config_data.o: config.gz > > -config_data.S: $(BASEDIR)/tools/binfile > - $(SHELL) $(BASEDIR)/tools/binfile $@ config.gz xen_config_data > +qu

[Resend RFC PATCH V4 07/13] HV/Vmbus: Add SNP support for VMbus channel initiate message

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan The monitor pages in the CHANNELMSG_INITIATE_CONTACT msg are shared with host in Isolation VM and so it's necessary to use hvcall to set them visible to host. In Isolation VM with AMD SEV SNP, the access address should be in the extra space which is above shared gpa boundary. So

[Resend RFC PATCH V4 06/13] HV: Add ghcb hvcall support for SNP VM

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan Hyper-V provides ghcb hvcall to handle VMBus HVCALL_SIGNAL_EVENT and HVCALL_POST_MESSAGE msg in SNP Isolation VM. Add such support. Signed-off-by: Tianyu Lan --- arch/x86/hyperv/ivm.c | 42 + arch/x86/include/asm/mshyperv.h | 1 + dri

[Resend RFC PATCH V4 05/13] HV: Add Write/Read MSR registers via ghcb page

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan Hyper-V provides GHCB protocol to write Synthetic Interrupt Controller MSR registers in Isolation VM with AMD SEV SNP and these registers are emulated by hypervisor directly. Hyper-V requires to write SINTx MSR registers twice. First writes MSR via GHCB page to communicate with h

[Resend RFC PATCH V4 04/13] HV: Mark vmbus ring buffer visible to host in Isolation VM

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan Mark vmbus ring buffer visible with set_memory_decrypted() when establish gpadl handle. Signed-off-by: Tianyu Lan --- drivers/hv/channel.c | 38 -- include/linux/hyperv.h | 10 ++ 2 files changed, 46 insertions(+), 2 deletions(-)

[Resend RFC PATCH V4 03/13] x86/HV: Add new hvcall guest address host visibility support

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan Add new hvcall guest address host visibility support to mark memory visible to host. Call it inside set_memory_decrypted /encrypted(). Signed-off-by: Tianyu Lan --- arch/x86/hyperv/Makefile | 2 +- arch/x86/hyperv/ivm.c | 112 ++

[Resend RFC PATCH V4 02/13] x86/HV: Initialize shared memory boundary in the Isolation VM.

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan Hyper-V exposes shared memory boundary via cpuid HYPERV_CPUID_ISOLATION_CONFIG and store it in the shared_gpa_boundary of ms_hyperv struct. This prepares to share memory with host for SNP guest. Signed-off-by: Tianyu Lan --- arch/x86/kernel/cpu/mshyperv.c | 2 ++ include/asm-

[Resend RFC PATCH V4 01/13] x86/HV: Initialize GHCB page in Isolation VM

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan Hyper-V exposes GHCB page via SEV ES GHCB MSR for SNP guest to communicate with hypervisor. Map GHCB page for all cpus to read/write MSR register and submit hvcall request via GHCB. Signed-off-by: Tianyu Lan --- arch/x86/hyperv/hv_init.c | 64

[Resend RFC PATCH V4 00/13] x86/Hyper-V: Add Hyper-V Isolation VM support

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan Hyper-V provides two kinds of Isolation VMs. VBS(Virtualization-based security) and AMD SEV-SNP unenlightened Isolation VMs. This patchset is to add support for these Isolation VM support in Linux. The memory of these vms are encrypted and host can't access guest memory directly

[Resend RFC PATCH V4 00/13] x86/Hyper-V: Add Hyper-V Isolation VM support

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan Hyper-V provides two kinds of Isolation VMs. VBS(Virtualization-based security) and AMD SEV-SNP unenlightened Isolation VMs. This patchset is to add support for these Isolation VM support in Linux. The memory of these vms are encrypted and host can't access guest memory directly

[RFC PATCH V4 09/12] HV/IOMMU: Enable swiotlb bounce buffer for Isolation VM

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan Hyper-V Isolation VM requires bounce buffer support to copy data from/to encrypted memory and so enable swiotlb force mode to use swiotlb bounce buffer for DMA transaction. In Isolation VM with AMD SEV, the bounce buffer needs to be accessed via extra address space which is abov

[RFC PATCH V4 11/12] HV/Storvsc: Add Isolation VM support for storvsc driver

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan In Isolation VM, all shared memory with host needs to mark visible to host via hvcall. vmbus_establish_gpadl() has already done it for storvsc rx/tx ring buffer. The page buffer used by vmbus_sendpacket_ mpb_desc() still need to handle. Use DMA API to map/umap these memory during

[RFC PATCH V4 12/12] x86/HV: Not set memory decrypted/encrypted during kexec alloc/free page in IVM

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan Hyper-V Isolation VM reuses set_memory_decrypted/encrypted function and not needs to decrypt/encrypt memory in arch_kexec_post_alloc(pre_free) _pages() just likes AMD SEV VM. So skip them. Signed-off-by: Tianyu Lan --- arch/x86/kernel/machine_kexec_64.c | 5 +++-- 1 file chang

[RFC PATCH V4 10/12] HV/Netvsc: Add Isolation VM support for netvsc driver

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan In Isolation VM, all shared memory with host needs to mark visible to host via hvcall. vmbus_establish_gpadl() has already done it for netvsc rx/tx ring buffer. The page buffer used by vmbus_sendpacket_ pagebuffer() still need to handle. Use DMA API to map/umap these memory durin

Re: [XEN PATCH v6 15/31] build: move make option changes check earlier

2021-07-07 Thread Jan Beulich
On 01.07.2021 16:09, Anthony PERARD wrote: > And thus avoiding checking for those variable over and over again. > > Signed-off-by: Anthony PERARD Acked-by: Jan Beulich in its present shape since all you do is move existing logic. But I wonder if I could talk you into ... > --- a/xen/Makefile >

[RFC PATCH V4 08/12] x86/Swiotlb/HV: Add Swiotlb bounce buffer remap function for HV IVM

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan In Isolation VM with AMD SEV, bounce buffer needs to be accessed via extra address space which is above shared_gpa_boundary (E.G 39 bit address line) reported by Hyper-V CPUID ISOLATION_CONFIG. The access physical address will be original physical address + shared_gpa_boundary. T

[RFC PATCH V4 07/12] HV/Vmbus: Initialize VMbus ring buffer for Isolation VM

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan VMbus ring buffer are shared with host and it's need to be accessed via extra address space of Isolation VM with SNP support. This patch is to map the ring buffer address in extra address space via ioremap(). HV host visibility hvcall smears data in the ring buffer and so reset t

[RFC PATCH V4 06/12] HV/Vmbus: Add SNP support for VMbus channel initiate message

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan The monitor pages in the CHANNELMSG_INITIATE_CONTACT msg are shared with host in Isolation VM and so it's necessary to use hvcall to set them visible to host. In Isolation VM with AMD SEV SNP, the access address should be in the extra space which is above shared gpa boundary. So

[RFC PATCH V4 05/12] HV: Add ghcb hvcall support for SNP VM

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan Hyper-V provides ghcb hvcall to handle VMBus HVCALL_SIGNAL_EVENT and HVCALL_POST_MESSAGE msg in SNP Isolation VM. Add such support. Signed-off-by: Tianyu Lan --- arch/x86/hyperv/ivm.c | 42 + arch/x86/include/asm/mshyperv.h | 1 + dri

[RFC PATCH V4 04/12] HV: Add Write/Read MSR registers via ghcb page

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan Hyper-V provides GHCB protocol to write Synthetic Interrupt Controller MSR registers in Isolation VM with AMD SEV SNP and these registers are emulated by hypervisor directly. Hyper-V requires to write SINTx MSR registers twice. First writes MSR via GHCB page to communicate with h

[RFC PATCH V4 03/12] HV: Mark vmbus ring buffer visible to host in Isolation VM

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan Mark vmbus ring buffer visible with set_memory_decrypted() when establish gpadl handle. Signed-off-by: Tianyu Lan --- drivers/hv/channel.c | 38 -- include/linux/hyperv.h | 10 ++ 2 files changed, 46 insertions(+), 2 deletions(-)

[RFC PATCH V4 02/12] x86/HV: Add new hvcall guest address host visibility support

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan Add new hvcall guest address host visibility support to mark memory visible to host. Call it inside set_memory_decrypted /encrypted(). Signed-off-by: Tianyu Lan --- arch/x86/hyperv/Makefile | 2 +- arch/x86/hyperv/ivm.c | 112 ++

[RFC PATCH V4 00/12] x86/Hyper-V: Add Hyper-V Isolation VM support

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan Hyper-V provides two kinds of Isolation VMs. VBS(Virtualization-based security) and AMD SEV-SNP unenlightened Isolation VMs. This patchset is to add support for these Isolation VM support in Linux. The memory of these vms are encrypted and host can't access guest memory directly

[RFC PATCH V4 01/12] x86/HV: Initialize shared memory boundary in the Isolation VM.

2021-07-07 Thread Tianyu Lan
From: Tianyu Lan Hyper-V exposes shared memory boundary via cpuid HYPERV_CPUID_ISOLATION_CONFIG and store it in the shared_gpa_boundary of ms_hyperv struct. This prepares to share memory with host for SNP guest. Signed-off-by: Tianyu Lan --- arch/x86/kernel/cpu/mshyperv.c | 2 ++ include/asm-

Re: [XEN PATCH v6 13/31] build,tools: have default rules depends on symbols

2021-07-07 Thread Jan Beulich
On 01.07.2021 16:09, Anthony PERARD wrote: > No need to call $(MAKE) again. > > Signed-off-by: Anthony PERARD Acked-by: Jan Beulich

Re: [XEN PATCH v6 12/31] build: use subdir-y in test/Makefile

2021-07-07 Thread Jan Beulich
On 01.07.2021 16:09, Anthony PERARD wrote: > --- a/xen/test/Makefile > +++ b/xen/test/Makefile > @@ -4,15 +4,10 @@ tests all: build > > ifneq ($(XEN_TARGET_ARCH),x86_32) > # Xen 32-bit x86 hypervisor no longer supported, so has no test livepatches > -SUBDIRS += livepatch > +subdir-y += livepatc

Re: [XEN PATCH v6 11/31] build: fix clean targets when subdir-y is used

2021-07-07 Thread Jan Beulich
On 01.07.2021 16:09, Anthony PERARD wrote: > The make variable $(subdir-y) isn't used yet but will be in a > following patch. Anything in $(subdir-y) doesn't to have a '/' as > suffix as we already now it's a directory. > > Rework the rules so that it doesn't matter whether there is a '/' or > not

Re: [XEN PATCH v6 10/31] build: use $(kconfig) shortcut in clean rule

2021-07-07 Thread Jan Beulich
On 01.07.2021 16:09, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD Acked-by: Jan Beulich

Re: [XEN PATCH v6 09/31] build: clean "lib.a"

2021-07-07 Thread Jan Beulich
On 01.07.2021 16:09, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD Hmm, I was clearly under the impression (or at least assuming) that $(targets) would be included in what gets cleaned by the general rule. But it looks I was wrong with this: Acked-by: Jan Beulich Jan

Re: [XEN PATCH v6 07/31] build,include: rework compat-build-source.py

2021-07-07 Thread Jan Beulich
On 01.07.2021 16:09, Anthony PERARD wrote: > Improvement are: > - give the path to xlat.lst as argument > - include `grep -v` in compat-build-source.py script, we don't need to > write this in several scripted language. > > Also remove dependency on Makefile as the file generation doesn't > depe

Re: [PATCH v5 1/4] xen: XENMEM_exchange should only be used/compiled for arch supporting PV guest

2021-07-07 Thread Jan Beulich
On 07.07.2021 16:21, Julien Grall wrote: > On 07/07/2021 15:06, Jan Beulich wrote: >> On 07.07.2021 15:39, Julien Grall wrote: >>> On 05/07/2021 09:41, Jan Beulich wrote: On 03.07.2021 19:11, Julien Grall wrote: > Changes in v5: > - Removed the #ifdef CONFIG_X86 as they are not n

Re: [XEN PATCH v6 06/31] x86/mm: avoid building multiple .o from a single .c file

2021-07-07 Thread Jan Beulich
On 01.07.2021 16:09, Anthony PERARD wrote: > This replace the use of a single .c file use for multiple .o file by > creating multiple .c file including the first one. > > There's quite a few issues with trying to build more than one object > file from a single source file: there's is a duplication

[xen-unstable test] 163386: tolerable FAIL

2021-07-07 Thread osstest service owner
flight 163386 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/163386/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 163362 test-armhf-armhf-libvirt 16 save

Re: [PATCH v2 4/4] bus: Make remove callback return void

2021-07-07 Thread Benjamin Tissoires
On 7/6/21 5:48 PM, Uwe Kleine-König wrote: The driver core ignores the return value of this callback because there is only little it can do when a device disappears. This is the final bit of a long lasting cleanup quest where several buses were converted to also return void from their remove cal

Re: how handle domU checkpoints properly

2021-07-07 Thread Olaf Hering
Am Wed, 7 Jul 2021 15:34:27 +0200 schrieb Olaf Hering : > This is incomplete because repeated checkpoint or pause operations are > not handled. Apparently they are, it is just not reported because there is no event when the domU resumes execution. Olaf pgpdooQSDlFvS.pgp Description: Digital

Re: [XEN PATCH v6 05/31] build: factorise generation of the linker scripts

2021-07-07 Thread Jan Beulich
On 01.07.2021 16:09, Anthony PERARD wrote: > In Arm and X86 makefile, generating the linker script is the same, so > we can simply have both call the same macro. > > We need to add *.lds files into extra-y so that Rules.mk can find the > .*.cmd dependency file and load it. > > Change made to the

Re: [PATCH v5 1/4] xen: XENMEM_exchange should only be used/compiled for arch supporting PV guest

2021-07-07 Thread Julien Grall
On 07/07/2021 15:06, Jan Beulich wrote: On 07.07.2021 15:39, Julien Grall wrote: On 05/07/2021 09:41, Jan Beulich wrote: On 03.07.2021 19:11, Julien Grall wrote: Changes in v5: - Removed the #ifdef CONFIG_X86 as they are not necessary anymore - Used paging_mode_translate() rathe

Re: [XEN PATCH v6 02/31] build: introduce cpp_flags macro

2021-07-07 Thread Jan Beulich
On 01.07.2021 16:09, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD > --- > > Notes: > v6: > - switch to a macro as suggested > which allows to be used with both a_flags and c_flags > > v5: > - new patch > > xen/Rules.mk| 7 +-- > xen/ar

[xen-unstable-smoke test] 163401: regressions - trouble: blocked/fail

2021-07-07 Thread osstest service owner
flight 163401 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/163401/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 163326 build-arm64-

Re: [PATCH v5 1/4] xen: XENMEM_exchange should only be used/compiled for arch supporting PV guest

2021-07-07 Thread Jan Beulich
On 07.07.2021 15:39, Julien Grall wrote: > On 05/07/2021 09:41, Jan Beulich wrote: >> On 03.07.2021 19:11, Julien Grall wrote: >>> Changes in v5: >>> - Removed the #ifdef CONFIG_X86 as they are not necessary anymore >>> - Used paging_mode_translate() rather than is_pv_domain() >> >> Is th

Re: [PATCH] tools/go: honor append build flags

2021-07-07 Thread Nick Rosbrook
On Wed, Jul 07, 2021 at 09:15:31AM +0200, Roger Pau Monne wrote: > Make the go build use APPEND_{C/LD}FLAGS when necessary, just like > other parts of the build. > > Reported-by: Ting-Wei Lan > Signed-off-by: Roger Pau Monné > --- > Note sure if it's the best way to add the appended flags, I'm n

Re: [PATCH v5 1/4] xen: XENMEM_exchange should only be used/compiled for arch supporting PV guest

2021-07-07 Thread Julien Grall
Hi Jan, On 05/07/2021 09:41, Jan Beulich wrote: On 03.07.2021 19:11, Julien Grall wrote: Changes in v5: - Removed the #ifdef CONFIG_X86 as they are not necessary anymore - Used paging_mode_translate() rather than is_pv_domain() Is there a particular reason you use this in favor of s

how handle domU checkpoints properly

2021-07-07 Thread Olaf Hering
During 'xl save -c|-p' the monitoring xl process will exit because it gets a LIBXL_EVENT_TYPE_DOMAIN_SHUTDOWN/LIBXL_SHUTDOWN_REASON_SUSPEND event. While this is correct for plain 'xl save' usage, the result is that other events such a shutdown/reboot/etc are not handled anymore for the domU. In ca

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

2021-07-07 Thread Jan Beulich
On 07.07.2021 15:21, Julien Grall wrote: > On 07/07/2021 14:14, Jan Beulich wrote: >> On 07.07.2021 14:59, Julien Grall wrote: >>> The alternative suggestion is to keep a unsigned type but check the bit >>> 31 is not set. >> >> Why? Why not bit 30 or bit 27? There's nothing special about >> bit 31

Re: [PATCH v7 9/9] docs/doxygen: doxygen documentation for grant_table.h

2021-07-07 Thread Julien Grall
Hi Luca, On 06/07/2021 09:44, Luca Fancellu wrote: On 5 Jul 2021, at 15:20, Julien Grall wrote: Hi Luca, On 05/07/2021 11:51, Luca Fancellu wrote: Modification to include/public/grant_table.h: 1) Add doxygen tags to: - Create Grant tables section - include variables in the generated d

[PATCH 2/2] CHANGELOG: record changed PCI device quarantining default

2021-07-07 Thread Jan Beulich
This amends commit 980d6acf1517 ("IOMMU: make DMA containment of quarantined devices optional"). Signed-off-by: Jan Beulich --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,13 @@ The format is based on [Keep a Changelog - XENSTORED_ROOTDIR environment variable from configuartion files and

[PATCH 1/2] IOMMU: correct parsing of "quarantine=scratch-page"

2021-07-07 Thread Jan Beulich
During the multiple renames of the sub-option I apparently forgot to update the left side of the &&, and this pretty consistently. Fixes: 980d6acf1517 ("IOMMU: make DMA containment of quarantined devices optional") Reported-by: Andrew Cooper Signed-off-by: Jan Beulich --- a/xen/drivers/passth

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

2021-07-07 Thread Julien Grall
On 07/07/2021 14:14, Jan Beulich wrote: On 07.07.2021 14:59, Julien Grall wrote: On 07/07/2021 13:54, Jan Beulich wrote: On 07.07.2021 14:51, Julien Grall wrote: On 07/07/2021 02:02, Igor Druzhinin wrote: Current unit8_t for pirq argument in this interface is too restrictive causing failur

[PATCH 0/2] IOMMU: adjustments after ""IOMMU: make DMA containment of quarantined devices optional""

2021-07-07 Thread Jan Beulich
Andrew has spotted a bug, and I've noticed that a changelog entry might be a good idea. 1: IOMMU: correct parsing of "quarantine=scratch-page" 2: CHANGELOG: record changed PCI device quarantining default Jan

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

2021-07-07 Thread Jan Beulich
On 07.07.2021 14:59, Julien Grall wrote: > On 07/07/2021 13:54, Jan Beulich wrote: >> On 07.07.2021 14:51, Julien Grall wrote: >>> On 07/07/2021 02:02, Igor Druzhinin wrote: Current unit8_t for pirq argument in this interface is too restrictive causing failures on modern hardware with lot

  1   2   >