Re: [XEN RFC PATCH 04/40] xen/arm: return default DMA bit width when platform is not set

2021-08-12 Thread Jan Beulich
On 13.08.2021 08:54, Wei Chen wrote: >> From: Jan Beulich >> Sent: 2021年8月11日 18:54 >> >> On 11.08.2021 12:23, Wei Chen wrote: >>> --- a/xen/arch/arm/platform.c >>> +++ b/xen/arch/arm/platform.c >>> @@ -27,6 +27,7 @@ extern const struct platform_desc _splatform[], >> _eplatform[]; >>> /* Pointer

RE: [XEN RFC PATCH 04/40] xen/arm: return default DMA bit width when platform is not set

2021-08-12 Thread Wei Chen
Hi Jan, > -Original Message- > From: Jan Beulich > Sent: 2021年8月11日 18:54 > To: Wei Chen > Cc: Bertrand Marquis ; xen- > de...@lists.xenproject.org; sstabell...@kernel.org; jul...@xen.org > Subject: Re: [XEN RFC PATCH 04/40] xen/arm: return default DMA bit width > when platform is not se

Re: [XEN RFC PATCH 00/40] Add device tree based NUMA support to Arm64

2021-08-12 Thread Jan Beulich
On 13.08.2021 04:33, Wei Chen wrote: >> From: Jan Beulich >> Sent: 2021年8月11日 18:42 >> >> On 11.08.2021 12:23, Wei Chen wrote: >>> Hongda Deng (2): >>> xen/arm: return default DMA bit width when platform is not set >>> xen/arm: Fix lowmem_bitsize when arch_get_dma_bitsize return 0 >>> >>> Wei

RE: [XEN RFC PATCH 01/40] tools: Fix -Werror=maybe-uninitialized for xlu_pci_parse_bdf

2021-08-12 Thread Wei Chen
Hi Jan, > -Original Message- > From: Jan Beulich > Sent: 2021年8月11日 18:50 > To: Wei Chen > Cc: Bertrand Marquis ; xen- > de...@lists.xenproject.org; sstabell...@kernel.org; jul...@xen.org > Subject: Re: [XEN RFC PATCH 01/40] tools: Fix -Werror=maybe-uninitialized > for xlu_pci_parse_bdf

Re: [Stratos-dev] Enabling hypervisor agnosticism for VirtIO backends

2021-08-12 Thread AKASHI Takahiro
Hi François, On Thu, Aug 12, 2021 at 09:55:52AM +0200, Fran??ois Ozog wrote: > I top post as I find it difficult to identify where to make the comments. Thank you for the posting. I think that we should first discuss more about the goal/requirements/ practical use cases for the framework. > 1)

[linux-5.4 test] 164170: trouble: broken/fail/pass

2021-08-12 Thread osstest service owner
flight 164170 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/164170/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-arndale broken test-armhf-armhf-xl-mul

RE: [XEN RFC PATCH 00/40] Add device tree based NUMA support to Arm64

2021-08-12 Thread Wei Chen
Hi Jan, > -Original Message- > From: Jan Beulich > Sent: 2021年8月11日 18:42 > To: Wei Chen > Cc: Bertrand Marquis ; sstabell...@kernel.org; > jul...@xen.org; xen-devel@lists.xenproject.org > Subject: Re: [XEN RFC PATCH 00/40] Add device tree based NUMA support to > Arm64 > > On 11.08.2021

Re: [PATCH v2] libxl: Fix stubdom PCI passthrough

2021-08-12 Thread Jason Andryuk
On Thu, Aug 12, 2021 at 7:20 AM Ian Jackson wrote: > > Jan Beulich writes ("Re: [PATCH v2] libxl: Fix stubdom PCI passthrough"): > > On 12.08.2021 02:57, Jason Andryuk wrote: > > > commit 0fdb48ffe7a1 "libxl: Make sure devices added by pci-attach are > > > reflected in the config" broken stubdom P

RE: [PATCH V3 04/13] HV: Mark vmbus ring buffer visible to host in Isolation VM

2021-08-12 Thread Michael Kelley
From: Tianyu Lan Sent: Monday, August 9, 2021 10:56 AM > Subject: [PATCH V3 04/13] HV: Mark vmbus ring buffer visible to host in > Isolation VM > Use tag "Drivers: hv: vmbus:" in the Subject line. > Mark vmbus ring buffer visible with set_memory_decrypted() when > establish gpadl handle. > >

[linux-linus test] 164168: regressions - trouble: broken/fail/pass

2021-08-12 Thread osstest service owner
flight 164168 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164168/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt broken test-armhf-armhf-xl

RE: [PATCH V3 03/13] x86/HV: Add new hvcall guest address host visibility support

2021-08-12 Thread Michael Kelley
From: Tianyu Lan Sent: Monday, August 9, 2021 10:56 AM [snip] > diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c > index ad8a5c586a35..1e4a0882820a 100644 > --- a/arch/x86/mm/pat/set_memory.c > +++ b/arch/x86/mm/pat/set_memory.c > @@ -29,6 +29,8 @@ > #include > #includ

Re: [PATCH v2] xen/events: Fix race in set_evtchn_to_irq

2021-08-12 Thread Boris Ostrovsky
On 8/12/21 9:09 AM, Maximilian Heyne wrote: > There is a TOCTOU issue in set_evtchn_to_irq. Rows in the evtchn_to_irq > mapping are lazily allocated in this function. The check whether the row > is already present and the row initialization is not synchronized. Two > threads can at the same time

RE: [PATCH V3 03/13] x86/HV: Add new hvcall guest address host visibility support

2021-08-12 Thread Michael Kelley
From: Tianyu Lan Sent: Monday, August 9, 2021 10:56 AM > Subject: [PATCH V3 03/13] x86/HV: Add new hvcall guest address host > visibility support Use "x86/hyperv:" tag in the Subject line. > > From: Tianyu Lan > > Add new hvcall guest address host visibility support to mark > memory visible

[xen-unstable-smoke test] 164169: tolerable all pass - PUSHED

2021-08-12 Thread osstest service owner
flight 164169 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/164169/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

RE: [PATCH V3 02/13] x86/HV: Initialize shared memory boundary in the Isolation VM.

2021-08-12 Thread Michael Kelley
From: Tianyu Lan Sent: Monday, August 9, 2021 10:56 AM > Subject: [PATCH V3 02/13] x86/HV: Initialize shared memory boundary in the > Isolation VM. As with Patch 1, use the "x86/hyperv:" tag in the Subject line. > > From: Tianyu Lan > > Hyper-V exposes shared memory boundary via cpuid > HYPE

Re: Issue with waitqueues and Intel CET-SS

2021-08-12 Thread Andrew Cooper
On 12/08/2021 19:20, Jason Andryuk wrote: > Hi, > > I was reviewing xen/common/wait.c:__prepare_to_wait() and I think I've > identified an incompatibility with shadow stacks like Intel CET-SS. > > The inline asm does: > > "call 1f;" > "1: addq $2f-1b,(%%rsp);" > "sub %%esp,%

RE: [PATCH V3 01/13] x86/HV: Initialize GHCB page in Isolation VM

2021-08-12 Thread Michael Kelley
From: Tianyu Lan Sent: Monday, August 9, 2021 10:56 AM > Subject: [PATCH V3 01/13] x86/HV: Initialize GHCB page in Isolation VM The subject line tag on patches under arch/x86/hyperv is generally "x86/hyperv:". There's some variation in the spelling of "hyperv", but let's go with the all lowercas

Issue with waitqueues and Intel CET-SS

2021-08-12 Thread Jason Andryuk
Hi, I was reviewing xen/common/wait.c:__prepare_to_wait() and I think I've identified an incompatibility with shadow stacks like Intel CET-SS. The inline asm does: "call 1f;" "1: addq $2f-1b,(%%rsp);" "sub %%esp,%%ecx;" "cmp %3,%%ecx;" "ja 3f;" "mo

Re: [PATCH] x86/cet: Fix shskt manipulation error with BUGFRAME_{warn,run_fn}

2021-08-12 Thread Marek Marczykowski-Górecki
On Thu, Aug 12, 2021 at 06:03:50PM +0100, Andrew Cooper wrote: > This was a clear oversight in the original CET work. The BUGFRAME_run_fn and > BUGFRAME_warn paths update regs->rip without an equivlenet adjustment to the > shadow stack, causes IRET to suffer #CP due to the mismatch. > > One subtl

[linux-5.4 test] 164167: trouble: broken/fail/pass

2021-08-12 Thread osstest service owner
flight 164167 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/164167/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-arndale broken test-armhf-armhf-xl-arn

[PATCH] x86/cet: Fix shskt manipulation error with BUGFRAME_{warn,run_fn}

2021-08-12 Thread Andrew Cooper
This was a clear oversight in the original CET work. The BUGFRAME_run_fn and BUGFRAME_warn paths update regs->rip without an equivlenet adjustment to the shadow stack, causes IRET to suffer #CP due to the mismatch. One subtle, and therefore fragile, aspect of extable_shstk_fixup() was that it req

Re: [XEN RFC PATCH 06/40] xen: decouple NUMA from ACPI in Kconfig

2021-08-12 Thread Julien Grall
Hi Wei, On 11/08/2021 11:23, Wei Chen wrote: In current Xen code only implments x86 ACPI-based NUMA support. s/implments/implements/ So in Xen Kconfig system, NUMA equals to ACPI_NUMA. x86 selects NUMA by default, and CONFIG_ACPI_NUMA is hardcode in config.h. In this patch series, we introd

Re: [PATCH V3 09/13] DMA: Add dma_map_decrypted/dma_unmap_encrypted() function

2021-08-12 Thread Tianyu Lan
On 8/12/2021 8:26 PM, Christoph Hellwig wrote: On Mon, Aug 09, 2021 at 01:56:13PM -0400, Tianyu Lan wrote: From: Tianyu Lan In Hyper-V Isolation VM with AMD SEV, swiotlb boucne buffer needs to be mapped into address space above vTOM and so introduce dma_map_decrypted/dma_unmap_encrypted() t

Re: [XEN RFC PATCH 06/40] xen: decouple NUMA from ACPI in Kconfig

2021-08-12 Thread Jan Beulich
On 11.08.2021 12:23, Wei Chen wrote: > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -24,7 +24,7 @@ config X86 > select HAS_UBSAN > select HAS_VPCI if HVM > select NEEDS_LIBELF > - select NUMA > + select ACPI_NUMA We try to keep this alphabetically sorted,

Re: [XEN RFC PATCH 03/40] xen/x86: Initialize memnodemapsize while faking NUMA node

2021-08-12 Thread Jan Beulich
On 11.08.2021 12:23, Wei Chen wrote: > When system turns NUMA off or system lacks of NUMA support, > Xen will fake a NUMA node to make system works as a single > node NUMA system. > > In this case the memory node map doesn't need to be allocated > from boot pages. But we should set the memnodemaps

[PATCH 9/9] tools/libs/light: Add "reset" and "remove" PCI dev commands to xl pcid daemon and libxl PCI

2021-08-12 Thread Anastasiia Lukianenko
From: Anastasiia Lukianenko Add "reset" command processing to xl pcid daemon. Make possible sending "reset"/"remove" PCI device requests from libxl PCI to xl pcid daemon instead of using sysfs on libxl side. Signed-off-by: Anastasiia Lukianenko --- tools/include/pcid.h | 1 + tools/l

[PATCH 7/9] tools/libs/light: Make Libxl PCI get values from xl pcid instead of libxl side

2021-08-12 Thread Anastasiia Lukianenko
From: Anastasiia Lukianenko pci_multifunction_check needs to use "ls" and "lstat" commands to get information from sysfs. Add "is_exists" command processing to xl pcid daemon to make possible pci_multifunction_check read directories and check lstat by using xl pcid. Signed-off-by: Anastasiia Luk

[PATCH 8/9] tools/libs/light: Add "unbind" and "read resources" commands to libxl PCI and xl pcid

2021-08-12 Thread Anastasiia Lukianenko
From: Anastasiia Lukianenko Send requests to xl pcid from libxl PCI to prevent the libxl PCI from reading / writing from / to the local sysfs directly. "Unbind" command returns driver's path or "nolstat" result in success and NULL if writing to PCI path failed. "Read resources" command returns

[PATCH 6/9] tools/libs/light: Add "read" command to xl pcid and libxl PCI

2021-08-12 Thread Anastasiia Lukianenko
From: Anastasiia Lukianenko Libxl PCI can use xl pcid server to read integer value from the given path. Signed-off-by: Anastasiia Lukianenko --- tools/include/pcid.h | 1 + tools/libs/light/libxl_pci.c | 125 ++ tools/libs/light/libxl_pcid.c | 50 ++

[PATCH 5/9] tools/libs/light: Add "write" command to xl pcid and libxl PCI

2021-08-12 Thread Anastasiia Lukianenko
From: Anastasiia Lukianenko Add functions for handling "write" command on xl pcid side. Libxl PCI side receives reply: 1. success - string in "return" message 2. fail - error type of reply message Signed-off-by: Anastasiia Lukianenko --- tools/include/pcid.h | 7 tools/libs/ligh

[PATCH 3/9] tools/xl: Add pcid daemon to xl

2021-08-12 Thread Anastasiia Lukianenko
From: Anastasiia Lukianenko Add draft version of pcid server (based on vchan-node2), which can receive messages from the client. Signed-off-by: Anastasiia Lukianenko --- tools/configure | 5 +- tools/hotplug/FreeBSD/rc.d/xlpcid.in | 75 ++ tools/ho

[PATCH 4/9] tools/libs/light: Add "ls" command processing to xl pcid daemon and libxl PCI

2021-08-12 Thread Anastasiia Lukianenko
From: Anastasiia Lukianenko Messaging format is based on json style. Xl pcid receives "ls" command from client and sends a reply: 1. success case - array of directory's names 2. error case - message with "error" in return Xl pcid server transmits information about devices assigned to the PCI dri

[PATCH 1/9] tools/libs/light: Add vchan support to libxl

2021-08-12 Thread Anastasiia Lukianenko
From: Anastasiia Lukianenko Add possibility to send commands from libxl and execute them on server side. Libxl vchan adds support for JSON messages processing. The using of libxl vchan is preventing the client from libxl from reading and writing from / to the local sysfs directly.To do this, the

[PATCH 2/9] tools/libs/light: Add functions for handling PCI messages in JSON format

2021-08-12 Thread Anastasiia Lukianenko
From: Anastasiia Lukianenko These functions allow to process the received message from PCI server and to generate a reply in JSON format for the client. Signed-off-by: Anastasiia Lukianenko --- tools/include/pcid.h | 49 tools/libs/light/Makefile

[PATCH 0/9] Add xl PCI daemon (server for libxl PCI)

2021-08-12 Thread Anastasiia Lukianenko
From: Anastasiia Lukianenko This work introduces xl PCI daemon that acts as a server for the client in the libxl PCI. The toolstack in Dom0 accesses sysfs to get information about PCI devices and in case of Hardware Domain that sysfs lives in Hardware Domain, so Dom0 can't read that information d

Re: [PATCH] MAINTAINERS: Fix file path for kexec headers

2021-08-12 Thread Jan Beulich
On 12.08.2021 15:51, Andrew Cooper wrote: > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich

[PATCH] MAINTAINERS: Fix file path for kexec headers

2021-08-12 Thread Andrew Cooper
Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Ian Jackson CC: Jan Beulich CC: Stefano Stabellini CC: Wei Liu CC: Julien Grall --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 56d16e4328cf..9be4ad653af8 100644 --- a/

[PATCH v2] xen/events: Fix race in set_evtchn_to_irq

2021-08-12 Thread Maximilian Heyne
There is a TOCTOU issue in set_evtchn_to_irq. Rows in the evtchn_to_irq mapping are lazily allocated in this function. The check whether the row is already present and the row initialization is not synchronized. Two threads can at the same time allocate a new row for evtchn_to_irq and add the irq m

Re: [PATCH V3 10/13] x86/Swiotlb: Add Swiotlb bounce buffer remap function for HV IVM

2021-08-12 Thread Christoph Hellwig
This is still broken. You need to make sure the actual DMA allocations do have struct page backing.

Re: [PATCH V3 09/13] DMA: Add dma_map_decrypted/dma_unmap_encrypted() function

2021-08-12 Thread Christoph Hellwig
On Mon, Aug 09, 2021 at 01:56:13PM -0400, Tianyu Lan wrote: > From: Tianyu Lan > > In Hyper-V Isolation VM with AMD SEV, swiotlb boucne buffer > needs to be mapped into address space above vTOM and so > introduce dma_map_decrypted/dma_unmap_encrypted() to map/unmap > bounce buffer memory. The pla

Re: [PATCH] x86/pv: Provide more helpful error when CONFIG_PV32 is absent

2021-08-12 Thread Jan Beulich
On 12.08.2021 13:48, Jane Malalane wrote: > Currently, when booting a 32bit dom0 kernel, the message isn't very > helpful: > > (XEN) Xen kernel: 64-bit, lsb > (XEN) Dom0 kernel: 32-bit, PAE, lsb, paddr 0x10 -> 0x112000 > (XEN) Mismatch between Xen and DOM0 kernel > (XEN) > (XEN) *

Re: [PATCH v2] xen/bitmap: Don't open code DIV_ROUND_UP()

2021-08-12 Thread Jan Beulich
On 12.08.2021 12:02, Jane Malalane wrote: > Also, change bitmap_long_to_byte() and bitmap_byte_to_long() to take > 'unsigned int' instead of 'int' number of bits, to match the type of > their callers. > > Suggested-by: Andrew Cooper > Signed-off-by: Jane Malalane Reviewed-by: Jan Beulich

Re: [PATCH] tests/xenstore: link in librt

2021-08-12 Thread Jan Beulich
On 12.08.2021 13:24, Ian Jackson wrote: > Jan Beulich writes ("[PATCH] tests/xenstore: link in librt"): >> Old enough glibc has clock_gettime() in librt.so, hence the library >> needs to be specified to the linker. >> >> Fixes: 93c9edbef51b ("tests/xenstore: Rework Makefile") >> Signed-off-by: Jan

Re: [PATCH] xen/events: Fix race in set_evtchn_to_irq

2021-08-12 Thread Heyne, Maximilian
On Wed, 2021-08-11 at 11:05 -0400, Boris Ostrovsky wrote: > On 8/11/21 10:08 AM, Maximilian Heyne wrote: > > This patch sets evtchn_to_irq rows via a cmpxchg operation so that > > they > > will be set only once. Clearing the row was moved up before writing > > the > > row to evtchn_to_irq in order

[linux-linus test] 164164: regressions - trouble: broken/fail/pass

2021-08-12 Thread osstest service owner
flight 164164 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164164/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt broken test-armhf-armhf-xl

[PATCH] x86/pv: Provide more helpful error when CONFIG_PV32 is absent

2021-08-12 Thread Jane Malalane
Currently, when booting a 32bit dom0 kernel, the message isn't very helpful: (XEN) Xen kernel: 64-bit, lsb (XEN) Dom0 kernel: 32-bit, PAE, lsb, paddr 0x10 -> 0x112000 (XEN) Mismatch between Xen and DOM0 kernel (XEN) (XEN) (XEN) Panic on C

[ovmf test] 164166: all pass - PUSHED

2021-08-12 Thread osstest service owner
flight 164166 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164166/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf ac826886c98524e918753419c039d8b44198943f baseline version: ovmf a776bbabd9e8f370feb08

[PATCH] tests/xenstore: link in librt

2021-08-12 Thread Ian Jackson
Jan Beulich writes ("[PATCH] tests/xenstore: link in librt"): > Old enough glibc has clock_gettime() in librt.so, hence the library > needs to be specified to the linker. > > Fixes: 93c9edbef51b ("tests/xenstore: Rework Makefile") > Signed-off-by: Jan Beulich > --- > Cc list based on the assumpti

Re: [PATCH v2] libxl: Fix stubdom PCI passthrough

2021-08-12 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH v2] libxl: Fix stubdom PCI passthrough"): > On 12.08.2021 02:57, Jason Andryuk wrote: > > commit 0fdb48ffe7a1 "libxl: Make sure devices added by pci-attach are > > reflected in the config" broken stubdom PCI passthrough when it moved > > libxl__create_pci_backend lat

[PATCH v2] xen/bitmap: Don't open code DIV_ROUND_UP()

2021-08-12 Thread Jane Malalane
Also, change bitmap_long_to_byte() and bitmap_byte_to_long() to take 'unsigned int' instead of 'int' number of bits, to match the type of their callers. Suggested-by: Andrew Cooper Signed-off-by: Jane Malalane --- CC: Andrew Cooper CC: George Dunlap CC: Ian Jackson CC: Jan Beulich CC: Julien

[libvirt test] 164165: regressions - FAIL

2021-08-12 Thread osstest service owner
flight 164165 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/164165/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-arm64-libvirt

[xen-unstable test] 164163: trouble: broken/fail/pass

2021-08-12 Thread osstest service owner
flight 164163 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/164163/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt broken Tests which are fail