Re: [PATCH v2 1/3] xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu

2021-10-06 Thread Stefano Stabellini
On Wed, 6 Oct 2021, Michal Orzel wrote: > Introduce flag XEN_SYSCTL_PHYSCAP_vpmu which > indicates whether the platform supports vPMU > functionality. Modify Xen and tools accordingly. > > Take the opportunity and fix XEN_SYSCTL_PHYSCAP_vmtrace > definition in sysctl.h which wrongly uses (1<<6) >

Re: [PATCH v2 2/3] xen/arm: Check for PMU platform support

2021-10-06 Thread Stefano Stabellini
On Wed, 6 Oct 2021, Michal Orzel wrote: > ID_AA64DFR0_EL1/ID_DFR0_EL1 registers provide > information about PMU support. Replace structure > dbg64/dbg32 with a union and fill in all the > register fields according to document: > ARM Architecture Registers(DDI 0595, 2021-06). > > Add macros boot_db

[xen-4.15-testing test] 165387: tolerable FAIL - PUSHED

2021-10-06 Thread osstest service owner
flight 165387 xen-4.15-testing real [real] flight 165403 xen-4.15-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/165387/ http://logs.test-lab.xenproject.org/osstest/logs/165403/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): t

Re: [PATCH V5 3/3] xen/arm: Updates for extended regions support

2021-10-06 Thread Stefano Stabellini
On Wed, 6 Oct 2021, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > This is a follow-up of > "b6fe410 xen/arm: Add handling of extended regions for Dom0" > > Add various in-code comments, update Xen hypervisor device tree > bindings text, change the log level for some prints and cla

Re: [PATCH V5 2/3] libxl/arm: Add handling of extended regions for DomU

2021-10-06 Thread Stefano Stabellini
On Wed, 6 Oct 2021, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > The extended region (safe range) is a region of guest physical > address space which is unused and could be safely used to create > grant/foreign mappings instead of wasting real RAM pages from > the domain memory fo

Re: [PATCH V5 1/3] xen/arm: Introduce gpaddr_bits field to struct xen_arch_domainconfig

2021-10-06 Thread Stefano Stabellini
On Wed, 6 Oct 2021, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > We need to pass info about maximum supported guest physical > address space size to the toolstack on Arm in order to properly > calculate the base and size of the extended region (safe range) > for the guest. The ext

Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in libxl

2021-10-06 Thread Stefano Stabellini
On Wed, 6 Oct 2021, Julien Grall wrote: > Hi Rahul, > > On 06/10/2021 19:40, Rahul Singh wrote: > > diff --git a/tools/libs/light/libxl_types.idl > > b/tools/libs/light/libxl_types.idl > > index 3f9fff653a..78b1ddf0b8 100644 > > --- a/tools/libs/light/libxl_types.idl > > +++ b/tools/libs/light/lib

Re: [PATCH v5 02/11] xen/arm: Add PHYSDEVOP_pci_device_(*add/remove) support for ARM

2021-10-06 Thread Stefano Stabellini
On Wed, 6 Oct 2021, Rahul Singh wrote: > Hardware domain is in charge of doing the PCI enumeration and will > discover the PCI devices and then will communicate to XEN via hyper > call PHYSDEVOP_pci_device_add(..) to add the PCI devices in XEN. > > Also implement PHYSDEVOP_pci_device_remove(..) to

Re: [PATCH V5 2/3] libxl/arm: Add handling of extended regions for DomU

2021-10-06 Thread Stefano Stabellini
On Wed, 6 Oct 2021, Oleksandr wrote: > On 06.10.21 14:34, Ian Jackson wrote: > > Hi Ian > > > Oleksandr Tyshchenko writes ("[PATCH V5 2/3] libxl/arm: Add handling of > > extended regions for DomU"): > > > The extended region (safe range) is a region of guest physical > > > address space which is

Re: [PING] Re: [PATCH] xen/arm: optee: Allocate anonymous domheap pages

2021-10-06 Thread Stefano Stabellini
On Wed, 6 Oct 2021, Oleksandr wrote: > Hello all > > Gentle reminder. Many thanks for the ping, this patch fell off my radar. > On 23.09.21 23:57, Volodymyr Babchuk wrote: > > Hi Stefano, > > > > Stefano Stabellini writes: > > > > > On Mon, 6 Sep 2021, Oleksandr Tyshchenko wrote: > > > >

Re: [PATCH] xen/arm: optee: Fix arm_smccc_smc's a0 for OPTEE_SMC_DISABLE_SHM_CACHE

2021-10-06 Thread Stefano Stabellini
On Wed, 6 Oct 2021, Julien Grall wrote: > Hi Stefano, > > On 28/09/2021 06:52, Stefano Stabellini wrote: > > On Mon, 27 Sep 2021, Oleksandr Tyshchenko wrote: > > > From: Oleksandr Tyshchenko > > > > > > Fix a possible copy-paste error in arm_smccc_smc's first argument (a0) > > > for OPTEE_SMC_DI

[xen-4.14-testing test] 165386: tolerable FAIL - PUSHED

2021-10-06 Thread osstest service owner
flight 165386 xen-4.14-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/165386/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 13 guest-start fail baseline untested test-armhf-armhf-libvirt-qcow2 1

Re: [PATCH v4 10/11] xen/arm: Do not map PCI ECAM and MMIO space to Domain-0's p2m

2021-10-06 Thread Stefano Stabellini
On Wed, 6 Oct 2021, Oleksandr Andrushchenko wrote: > On 06.10.21 00:43, Stefano Stabellini wrote: > > On Tue, 5 Oct 2021, Oleksandr Andrushchenko wrote: > >> On 05.10.21 04:24, Stefano Stabellini wrote: > >>> On Mon, 4 Oct 2021, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko >

[linux-arm-xen test] 165391: tolerable all pass - PUSHED

2021-10-06 Thread osstest service owner
flight 165391 linux-arm-xen real [real] http://logs.test-lab.xenproject.org/osstest/logs/165391/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail baseline untested test-armhf-armhf-libvirt 1

Re: [PATCH] xen/arm: optee: Fix arm_smccc_smc's a0 for OPTEE_SMC_DISABLE_SHM_CACHE

2021-10-06 Thread Julien Grall
Hi Stefano, On 28/09/2021 06:52, Stefano Stabellini wrote: On Mon, 27 Sep 2021, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko Fix a possible copy-paste error in arm_smccc_smc's first argument (a0) for OPTEE_SMC_DISABLE_SHM_CACHE case. This error causes Linux > v5.14-rc5 (b5c10dd04b7

Re: [PATCH V4 2/3] xen/arm: Add handling of extended regions for Dom0

2021-10-06 Thread Julien Grall
Hi Oleksandr, On 06/10/2021 20:15, Oleksandr Tyshchenko wrote: On Wed, Oct 6, 2021 at 9:11 PM Julien Grall > wrote: Hi Oleksandr, Hi Julien [Sorry for the possible format issues] On 04/10/2021 14:08, Oleksandr wrote: > > On 04.10.21 09:59, Julien

Re: [PATCH v4 1/3] arm/efi: Introduce xen,uefi-cfg-load DT property

2021-10-06 Thread Julien Grall
Hi Luca, Sorry for jumping late in the conversation. While skimming through what has been committed, I noticed one potential issue in this patch and have also a question. On 30/09/2021 16:28, Luca Fancellu wrote: Introduce the xen,uefi-cfg-load DT property of /chosen node for ARM whose prese

Re: [PATCH V4 2/3] xen/arm: Add handling of extended regions for Dom0

2021-10-06 Thread Oleksandr Tyshchenko
On Wed, Oct 6, 2021 at 9:11 PM Julien Grall wrote: > Hi Oleksandr, > Hi Julien [Sorry for the possible format issues] > > On 04/10/2021 14:08, Oleksandr wrote: > > > > On 04.10.21 09:59, Julien Grall wrote: > >> Hi Oleksandr, > > > > Hi Julien > > Hi Oleksandr, > > > > > > >> > >> I saw Stef

Re: [PATCH V4 2/3] xen/arm: Add handling of extended regions for Dom0

2021-10-06 Thread Julien Grall
Hi Oleksandr, On 04/10/2021 14:08, Oleksandr wrote: On 04.10.21 09:59, Julien Grall wrote: Hi Oleksandr, Hi Julien Hi Oleksandr, I saw Stefano committed this patch on Friday. However, I didn't have a chance go to through a second time and would like to request some follow-up change

Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in libxl

2021-10-06 Thread Julien Grall
Hi Rahul, On 06/10/2021 19:40, Rahul Singh wrote: diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index 3f9fff653a..78b1ddf0b8 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -644,6 +644,7 @@ libxl_domain_build_info = Struc

Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl

2021-10-06 Thread Julien Grall
Hi Rahul, On 06/10/2021 19:34, Rahul Singh wrote: On 6 Oct 2021, at 12:33 pm, Ian Jackson wrote: Rahul Singh writes ("Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl"): Hi Ian What is wrong with putting it in libxl__arch_domain_build_info_setdefault which I think ex

[PATCH v5 11/11] xen/arm: Add linux,pci-domain property for hwdom if not available.

2021-10-06 Thread Rahul Singh
If the property is not present in the device tree node for host bridge, XEN while creating the dtb for hwdom will create this property and assigns the already allocated segment to the host bridge so that XEN and linux will have the same segment for the host bridges. Signed-off-by: Rahul Singh Rev

[PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

2021-10-06 Thread Rahul Singh
The existing VPCI support available for X86 is adapted for Arm. When the device is added to XEN via the hyper call “PHYSDEVOP_pci_device_add”, VPCI handler for the config space access is added to the Xen to emulate the PCI devices config space. A MMIO trap handler for the PCI ECAM space is registe

[PATCH v5 07/11] xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag

2021-10-06 Thread Rahul Singh
Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN. Reject the use of this new flag for x86 as VPCI is not supported for DOMU guests for x86. Signed-off-by: Rahul Singh Reviewed-by: Stefano Stabellini Acked-by: Christian Lindig --- Change in v5: - Added Acked-by: Christian Lindig

[PATCH v5 05/11] xen/arm: Add support for Xilinx ZynqMP PCI host controller

2021-10-06 Thread Rahul Singh
From: Oleksandr Andrushchenko Add support for Xilinx ZynqMP PCI host controller to map the PCI config space to the XEN memory. Patch helps to understand how the generic infrastructure for PCI host-bridge discovery will be used for future references. Signed-off-by: Oleksandr Andrushchenko Signe

[PATCH v5 06/11] xen/arm: Implement pci access functions

2021-10-06 Thread Rahul Singh
Implement generic pci access functions to read/write the configuration space. Signed-off-by: Rahul Singh Reviewed-by: Bertrand Marquis Reviewed-by: Stefano Stabellini --- Change in v5: none Change in v4: - Added Reviewed-by: Stefano Stabellini - Added Reviewed-by: Bertrand Marquis Change in v

[PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in libxl

2021-10-06 Thread Rahul Singh
libxl will create an emulated PCI device tree node in the device tree to enable the guest OS to discover the virtual PCI during guest boot. Emulated PCI device tree node will only be created when there is any device assigned to guest. A new area has been reserved in the arm guest physical map at w

[PATCH v5 09/11] xen/arm: Transitional change to build HAS_VPCI on ARM.

2021-10-06 Thread Rahul Singh
This patch will be reverted once we add support for VPCI MSI/MSIX support on ARM. Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini Reviewed-by: Bertrand Marquis --- Change in v5: none Change in v4: - Added Acked-by: Stefano Stabellini - Added Reviewed-by: Bertrand Marquis Change in v3:

[PATCH v5 04/11] xen/arm: PCI host bridge discovery within XEN on ARM

2021-10-06 Thread Rahul Singh
XEN during boot will read the PCI device tree node “reg” property and will map the PCI config space to the XEN memory. As of now only "pci-host-ecam-generic" compatible board is supported. "linux,pci-domain" device tree property assigns a fixed PCI domain number to a host bridge, otherwise an uns

[PATCH v5 02/11] xen/arm: Add PHYSDEVOP_pci_device_(*add/remove) support for ARM

2021-10-06 Thread Rahul Singh
Hardware domain is in charge of doing the PCI enumeration and will discover the PCI devices and then will communicate to XEN via hyper call PHYSDEVOP_pci_device_add(..) to add the PCI devices in XEN. Also implement PHYSDEVOP_pci_device_remove(..) to remove the PCI device. As most of the code for

[PATCH v5 03/11] xen/arm: Add cmdline boot option "pci-passthrough = "

2021-10-06 Thread Rahul Singh
Add cmdline boot option "pci-passthrough = = " to enable or disable the PCI passthrough support on ARM. Signed-off-by: Rahul Singh Reviewed-by: Stefano Stabellini Reviewed-by: Bertrand Marquis --- Change in v5: none Change in v4: - Fixe minor comments - Added Reviewed-by: Bertrand Marquis - Ad

[PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-06 Thread Rahul Singh
ARM architecture does not implement I/O ports. Ignore this call on ARM to avoid the overhead of making a hypercall just for Xen to return -ENOSYS. Signed-off-by: Rahul Singh Reviewed-by: Stefano Stabellini Reviewed-by: Bertrand Marquis --- Change in v5: none Change in v4: - Added Reviewed-by: B

[PATCH v5 00/11] PCI devices passthrough on Arm

2021-10-06 Thread Rahul Singh
Hello All, The purpose of this patch series is to add PCI passthrough support to Xen on Arm. PCI passthrough support on ARM is the collaboration work between EPAM and ARM. ARM submitted the partial RFC [1][2] last year to get early feedback. We tried to fix all the comments and added more features

Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl

2021-10-06 Thread Rahul Singh
Hi Ian, > On 6 Oct 2021, at 12:33 pm, Ian Jackson wrote: > > Rahul Singh writes ("Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree > node in libxl"): >> Hi Ian >>> What is wrong with putting it in >>> libxl__arch_domain_build_info_setdefault >>> which I think exists precisely for

[xen-4.13-testing test] 165385: regressions - FAIL

2021-10-06 Thread osstest service owner
flight 165385 xen-4.13-testing real [real] flight 165400 xen-4.13-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/165385/ http://logs.test-lab.xenproject.org/osstest/logs/165400/ Regressions :-( Tests which did not succeed and are blocking, including tests which could

Re: [Stratos-dev] Xen Rust VirtIO demos work breakdown for Project Stratos

2021-10-06 Thread Oleksandr
On 05.10.21 00:53, Stefano Stabellini wrote: Hi Stefano, all On Sat, 2 Oct 2021, Oleksandr Tyshchenko wrote: On Sat, Oct 2, 2021 at 2:58 AM Stefano Stabellini wrote: Hi Stefano, all [Sorry for the possible format issues] [I have CCed Julien] On Tue, 28 Sep 2021, Oleksandr Tyshch

[PING] Re: [PATCH] xen/arm: optee: Allocate anonymous domheap pages

2021-10-06 Thread Oleksandr
Hello all Gentle reminder. On 23.09.21 23:57, Volodymyr Babchuk wrote: Hi Stefano, Stefano Stabellini writes: On Mon, 6 Sep 2021, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko Allocate anonymous domheap pages as there is no strict need to account them to a particular domain.

[xen-4.12-testing test] 165384: tolerable FAIL - PUSHED

2021-10-06 Thread osstest service owner
flight 165384 xen-4.12-testing real [real] flight 165399 xen-4.12-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/165384/ http://logs.test-lab.xenproject.org/osstest/logs/165399/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): t

Re: [RFC 1/1] xen/arm: set iommu property for IOMMU-protected devices

2021-10-06 Thread Oleksandr
On 04.10.21 12:54, Roman Skakun wrote: Hi Roman From: Roman Skakun Xen is not exposing any IOMMU properties to Dom0. So Dom0 assumes that all it's devices are not protected by IOMMU. To make Dom0 aware of IOMMU-protected devices, we need to mark them somehow. With this approach Dom0 Linux

Re: [PATCH] x86/pvh: add prototype for xen_pvh_init()

2021-10-06 Thread Boris Ostrovsky
On 10/6/21 2:19 AM, Juergen Gross wrote: > xen_pvh_init() is lacking a prototype in a header, add it. > > Reported-by: kernel test robot > Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky

Re: [PATCH v2 3/3] xen: Expose the PMU to the guests

2021-10-06 Thread Christian Lindig
On 6 Oct 2021, at 11:58, Michal Orzel mailto:michal.or...@arm.com>> wrote: Add parameter vpmu to xl domain configuration syntax to enable the access to PMU registers by disabling the PMU traps(currently only for ARM). The current status is that the PMU registers are not virtualized and the phy

Re: [PATCH V5 2/3] libxl/arm: Add handling of extended regions for DomU

2021-10-06 Thread Oleksandr
On 06.10.21 14:34, Ian Jackson wrote: Hi Ian Oleksandr Tyshchenko writes ("[PATCH V5 2/3] libxl/arm: Add handling of extended regions for DomU"): The extended region (safe range) is a region of guest physical address space which is unused and could be safely used to create grant/foreign map

Re: [PATCH V5 2/3] libxl/arm: Add handling of extended regions for DomU

2021-10-06 Thread Ian Jackson
Oleksandr Tyshchenko writes ("[PATCH V5 2/3] libxl/arm: Add handling of extended regions for DomU"): > The extended region (safe range) is a region of guest physical > address space which is unused and could be safely used to create > grant/foreign mappings instead of wasting real RAM pages from >

Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl

2021-10-06 Thread Ian Jackson
Rahul Singh writes ("Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl"): > Hi Ian > > What is wrong with putting it in > > libxl__arch_domain_build_info_setdefault > > which I think exists precisely for this kind of thing ? > > As we have to set the arch_arm.vpci to

[PATCH V5 3/3] xen/arm: Updates for extended regions support

2021-10-06 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko This is a follow-up of "b6fe410 xen/arm: Add handling of extended regions for Dom0" Add various in-code comments, update Xen hypervisor device tree bindings text, change the log level for some prints and clarify format specifier, reuse dt_for_each_range() to avoid open

[PATCH V5 2/3] libxl/arm: Add handling of extended regions for DomU

2021-10-06 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko The extended region (safe range) is a region of guest physical address space which is unused and could be safely used to create grant/foreign mappings instead of wasting real RAM pages from the domain memory for establishing these mappings. The extended regions are cho

[PATCH V5 1/3] xen/arm: Introduce gpaddr_bits field to struct xen_arch_domainconfig

2021-10-06 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko We need to pass info about maximum supported guest physical address space size to the toolstack on Arm in order to properly calculate the base and size of the extended region (safe range) for the guest. The extended region is unused address space which could be safely u

[PATCH V5 0/3] Add handling of extended regions (safe ranges) on Arm (Was "xen/memory: Introduce a hypercall to provide unallocated space")

2021-10-06 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko You can find an initial discussion at [1]-[5]. The extended region (safe range) is a region of guest physical address space which is unused and could be safely used to create grant/foreign mappings instead of wasting real RAM pages from the domain memory for establish

Re: Xen 4.16 development update

2021-10-06 Thread Ian Jackson
I wrote: > Planned release schedule for Xen 4.16 (recap): > > Friday 24th September PASSEDLast posting date > > Patches adding new features should be posted to the mailing list > by this cate, although perhaps not in their final version. > (3 weeks) > > Friday 15th Octo

Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl

2021-10-06 Thread Rahul Singh
Hi Ian > On 6 Oct 2021, at 12:07 pm, Ian Jackson wrote: > > Rahul Singh writes ("Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree > node in libxl"): >> libxl_defbool_val(libxl_defbool db) is implemented in such a way that it >> will assert >> if db value is the default. Therefore we

Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl

2021-10-06 Thread Ian Jackson
Rahul Singh writes ("Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl"): > libxl_defbool_val(libxl_defbool db) is implemented in such a way that it will > assert > if db value is the default. Therefore we have to explicitly set it to > LIBXL__DEFBOOL_FALSE for x86. > > Th

[PATCH v2 2/3] xen/arm: Check for PMU platform support

2021-10-06 Thread Michal Orzel
ID_AA64DFR0_EL1/ID_DFR0_EL1 registers provide information about PMU support. Replace structure dbg64/dbg32 with a union and fill in all the register fields according to document: ARM Architecture Registers(DDI 0595, 2021-06). Add macros boot_dbg_feature64/boot_dbg_feature32 to check for a debug fe

[PATCH v2 3/3] xen: Expose the PMU to the guests

2021-10-06 Thread Michal Orzel
Add parameter vpmu to xl domain configuration syntax to enable the access to PMU registers by disabling the PMU traps(currently only for ARM). The current status is that the PMU registers are not virtualized and the physical registers are directly accessible when this parameter is enabled. There i

[PATCH v2 1/3] xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu

2021-10-06 Thread Michal Orzel
Introduce flag XEN_SYSCTL_PHYSCAP_vpmu which indicates whether the platform supports vPMU functionality. Modify Xen and tools accordingly. Take the opportunity and fix XEN_SYSCTL_PHYSCAP_vmtrace definition in sysctl.h which wrongly uses (1<<6) instead of (1u<<6) and does not follow the standard of

[PATCH v2 0/3] Expose PMU to the guests

2021-10-06 Thread Michal Orzel
This patch series is a rework of an already pushed patch exposing PMU to the guests. In the second version the vpmu parameter is common and prework in the form of reporting availability of vPMU on the hardware is added. The current status is that the PMU registers are not virtualized and the physi

Re: [PATCH v4 08/11] libxl: Only map legacy PCI IRQs if they are supported

2021-10-06 Thread Rahul Singh
Hi Oleksandr, > On 4 Oct 2021, at 3:11 pm, Oleksandr Andrushchenko wrote: > > From: Oleksandr Andrushchenko > > Arm's PCI passthrough implementation doesn't support legacy interrupts, > but MSI/MSI-X. This can be the case for other platforms too. > For that reason introduce a new CONFIG_PCI_SU

Re: [PATCH v4 09/11] xen/arm: Setup MMIO range trap handlers for hardware domain

2021-10-06 Thread Rahul Singh
Hi Oleksandr, > On 4 Oct 2021, at 3:11 pm, Oleksandr Andrushchenko wrote: > > From: Oleksandr Andrushchenko > > In order for vPCI to work it needs to maintain guest and hardware > domain's views of the configuration space. For example, BARs and > COMMAND registers require emulation for guests

Re: [PATCH v4 06/11] xen/domain: Call pci_release_devices() when releasing domain resources

2021-10-06 Thread Rahul Singh
Hi Oleksandr, > On 4 Oct 2021, at 3:11 pm, Oleksandr Andrushchenko wrote: > > From: Oleksandr Tyshchenko > > This is the very same that we already do for DT devices. Moreover, x86 > already calls pci_release_devices(). > > Signed-off-by: Oleksandr Tyshchenko > Signed-off-by: Oleksandr Andrus

Re: [PATCH v4 05/11] xen/arm: Mark device as PCI while creating one

2021-10-06 Thread Rahul Singh
Hi Oleksandr, > On 4 Oct 2021, at 3:11 pm, Oleksandr Andrushchenko wrote: > > From: Oleksandr Andrushchenko > > While adding a PCI device mark it as such, so other frameworks > can distinguish it from DT devices. > For that introduce an architecture defined helper which may perform > additiona

Re: [PATCH v4 04/11] xen/device-tree: Make dt_find_node_by_phandle global

2021-10-06 Thread Rahul Singh
Hi Oleksandr, > On 4 Oct 2021, at 3:11 pm, Oleksandr Andrushchenko wrote: > > From: Oleksandr Andrushchenko > > Make dt_find_node_by_phandle globally visible, so it can be re-used by > other frameworks. > > Signed-off-by: Oleksandr Andrushchenko > Reviewed-by: Stefano Stabellini Reviewed-b

Re: [PATCH v4 07/11] libxl: Allow removing PCI devices for all types of domains

2021-10-06 Thread Rahul Singh
Hi Oleksandr, > On 4 Oct 2021, at 3:11 pm, Oleksandr Andrushchenko wrote: > > From: Oleksandr Andrushchenko > > The PCI device remove path may now be used by PVH on ARM, so the > assert is no longer valid. > > Cc: Ian Jackson > Cc: Juergen Gross > Signed-off-by: Oleksandr Andrushchenko > A

Re: [PATCH v4 11/11] xen/arm: Process pending vPCI map/unmap operations

2021-10-06 Thread Rahul Singh
Hi Oleksandr, > On 4 Oct 2021, at 3:11 pm, Oleksandr Andrushchenko wrote: > > From: Oleksandr Andrushchenko > > vPCI may map and unmap PCI device memory (BARs) being passed through which > may take a lot of time. For this those operations may be deferred to be > performed later, so that they c

Re: [PATCH v4 03/11] xen/arm: Introduce pci_find_host_bridge_node helper

2021-10-06 Thread Rahul Singh
Hi Oleksandr, > On 4 Oct 2021, at 3:11 pm, Oleksandr Andrushchenko wrote: > > From: Oleksandr Andrushchenko > > Get host bridge node given a PCI device attached to it. > > This helper will be re-used for adding PCI devices by the subsequent > patches. > > Signed-off-by: Oleksandr Andrushchen

[xen-unstable-coverity test] 165397: all pass - PUSHED

2021-10-06 Thread osstest service owner
flight 165397 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/165397/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 192aaf7e146c0b41dbdd35ccdb13eb33ced13633 baseline version: xen dd6c

Re: [PATCH v4 02/11] xen/arm: Add new device type for PCI

2021-10-06 Thread Rahul Singh
Hi Oleksandr, > On 4 Oct 2021, at 3:11 pm, Oleksandr Andrushchenko wrote: > > From: Oleksandr Andrushchenko > > Add new device type (DEV_PCI) to distinguish PCI devices from platform > DT devices, so some drivers, like IOMMU, can handle PCI devices > differently. > > Also add a helper which i

Re: [PATCH V4 3/3] libxl/arm: Add handling of extended regions for DomU

2021-10-06 Thread Oleksandr
On 06.10.21 00:36, Stefano Stabellini wrote: Hi Stefano On Tue, 5 Oct 2021, Oleksandr wrote: From: Oleksandr Tyshchenko The extended region (safe range) is a region of guest physical address space which is unused and could be safely used to create grant/foreign mappings instead of wasting

Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl

2021-10-06 Thread Rahul Singh
Hi Stefano, > On 5 Oct 2021, at 10:32 pm, Stefano Stabellini wrote: > > On Tue, 5 Oct 2021, Rahul Singh wrote: >>> On 5 Oct 2021, at 1:38 am, Stefano Stabellini >>> wrote: >>> >>> On Mon, 4 Oct 2021, Rahul Singh wrote: libxl will create an emulated PCI device tree node in the device tree