Re: [PATCH-4.16 v2] xen/efi: Fix Grub2 boot on arm64

On 09.11.2021 22:52, Stefano Stabellini wrote: > @@ -862,6 +856,7 @@ static int __init efi_check_dt_boot(EFI_LOADED_IMAGE > *loaded_image) > { > int chosen, node, addr_len, size_len; > unsigned int i = 0, modules_found = 0; > +CHAR16 *fname; > > /* Check for the chosen node i

[xen-unstable test] 166099: tolerable FAIL - PUSHED

flight 166099 xen-unstable real [real] flight 166104 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/166099/ http://logs.test-lab.xenproject.org/osstest/logs/166104/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6

RE: [PATCH 0/3][4.16?] VT-d: misc (regression) fixes

> From: Jan Beulich > Sent: Tuesday, November 9, 2021 10:56 PM > > 1: per-domain IOMMU bitmap needs to have dynamic size > 2: fix reduced page table levels support when sharing tables > 3: don't needlessly engage the untrusted-MSI workaround > > As to 4.16 considerations: Only patch 1 addresses

[ovmf test] 166102: all pass - PUSHED

flight 166102 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/166102/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf aab6bb3d32e207c89364504e4a195f9f0cf5ce31 baseline version: ovmf c974257821208fc619177

Re: [XEN][RFC PATCH v2 09/12] xen/arm: Implement device tree node addition functionalities

Hi Jan, Thanks for reviewing the patches. Yeah, I messed it up while breaking the code into multiple patches. For next v3 patch series, I will move the function call "handle_add_overlay_nodes()"(in patch 8/12) to 9/12 patch. Thanks, Vikram From: Jan Beulich Sent

[qemu-mainline test] 166098: tolerable FAIL - PUSHED

flight 166098 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/166098/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail like 166089 test-amd64-amd64-xl-qemuu-win7-amd6

[linux-linus test] 166092: regressions - FAIL

flight 166092 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/166092/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-examine 4 memdisk-try-append fail REGR. vs. 165976 test-armhf-armhf-xl

Re: [PATCH v3 08/16] perf: Force architectures to opt-in to guest callbacks

On Wed, Sep 22, 2021, Sean Christopherson wrote: > On Wed, Sep 22, 2021, Paolo Bonzini wrote: > > On 22/09/21 02:05, Sean Christopherson wrote: > > > @@ -1273,6 +1274,11 @@ static inline unsigned int > > > perf_guest_handle_intel_pt_intr(void) > > > } > > > extern void perf_register_guest_info

Re: [PATCH for-4.16] xen/arm: don't assign domU static-mem to dom0 as reserved-memory

On Tue, 9 Nov 2021, Julien Grall wrote: > On 09/11/2021 00:48, Stefano Stabellini wrote: > > From: Stefano Stabellini > > > > DomUs static-mem ranges are added to the reserved_mem array for > > accounting, but they shouldn't be assigned to dom0 as the other regular > > reserved-memory ranges in d

[PATCH v2] xen/arm: don't assign domU static-mem to dom0 as reserved-memory

From: Stefano Stabellini DomUs static-mem ranges are added to the reserved_mem array for accounting, but they shouldn't be assigned to dom0 as the other regular reserved-memory ranges in device tree. In make_memory_nodes, fix the error by skipping banks with xen_domain set to true in the reserve

Re: [PATCH v3 15/16] KVM: arm64: Drop perf.c and fold its tiny bits of code into arm.c / pmu.c

On Mon, Oct 11, 2021, Marc Zyngier wrote: > On Wed, 22 Sep 2021 01:05:32 +0100, > Sean Christopherson wrote: > > diff --git a/include/kvm/arm_pmu.h b/include/kvm/arm_pmu.h > > index 864b9997efb2..42270676498d 100644 > > --- a/include/kvm/arm_pmu.h > > +++ b/include/kvm/arm_pmu.h > > @@ -14,6 +14,7

Re: [PATCH for-4.16] xen/arm: allocate_bank_memory: don't create memory banks of size zero

Hi Stefano, On 09/11/2021 22:29, Stefano Stabellini wrote: From: Stefano Stabellini allocate_bank_memory can be called with a tot_size of zero. Please add some details how this can be called with tot_size == 0. AFAIU, this happens when creating the second bank. In that case, don't create

Re: [PATCH-4.16 v2] xen/efi: Fix Grub2 boot on arm64

Hi Stefano, On 09/11/2021 21:52, Stefano Stabellini wrote: On Tue, 9 Nov 2021, Jan Beulich wrote: On 09.11.2021 03:11, Stefano Stabellini wrote: On Mon, 8 Nov 2021, Jan Beulich wrote: On 05.11.2021 16:33, Stefano Stabellini wrote: My main concern is performance and resource utilization. With

[PATCH for-4.16] xen/arm: allocate_bank_memory: don't create memory banks of size zero

From: Stefano Stabellini allocate_bank_memory can be called with a tot_size of zero. In that case, don't create an empty memory bank, just return immediately without error. Otherwise a zero-sized memory bank will be added to the domain device tree. Fixes: f2931b4233ec "xen/arm: introduce allocat

Re: ASSERT in rangeset_remove_range

On Tue, 9 Nov 2021, Julien Grall wrote: > (+ Jan, Andrew, Wei for the common code) > > On 08/11/2021 22:45, Stefano Stabellini wrote: > > Hi Oleksandr, Julien, > > Hi, > > > I discovered a bug caused by the recent changes to introduce extended > > regions in make_hypervisor_node (more logs appen

Re: [PATCH-4.16 v2] xen/efi: Fix Grub2 boot on arm64

On Tue, 9 Nov 2021, Jan Beulich wrote: > On 09.11.2021 03:11, Stefano Stabellini wrote: > > On Mon, 8 Nov 2021, Jan Beulich wrote: > >> On 05.11.2021 16:33, Stefano Stabellini wrote: > >>> My main concern is performance and resource utilization. With v3 of the > >>> patch get_parent_handle will get

Re: [PATCH V2 3/4] xen/unpopulated-alloc: Add mechanism to use Xen resource

On 28.10.21 22:08, Boris Ostrovsky wrote: Hi Boris I am sorry for the late response. On 10/26/21 12:05 PM, Oleksandr Tyshchenko wrote:   +static void unpopulated_init(void) +{ +    static bool inited = false; +    int ret; + +    if (inited) +    return; + +    /* + * Try to initia

Re: [PATCH V2 3/4] xen/unpopulated-alloc: Add mechanism to use Xen resource

On 28.10.21 19:37, Stefano Stabellini wrote: Hi Stefano I am sorry for the late response. On Tue, 26 Oct 2021, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko The main reason of this change is that unpopulated-alloc code cannot be used in its current form on Arm, but there is a des

[xen-unstable test] 166094: tolerable FAIL

flight 166094 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/166094/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail in 166088 pass in 166094 test-amd64-amd64-libvirt-vhd

[ovmf test] 166097: all pass - PUSHED

flight 166097 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/166097/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf c974257821208fc6191779d1ddea918499f165b8 baseline version: ovmf d6e6337cd6ee0b7f06578

Re: [PATCH v5] tools/xl: fix autoballoon regex

Up15:24, 1 октября 2021 г., Dmitry Isaykin :This regex is used for auto-balloon mode detection based on Xen command line.The case of specifying a negative size was handled incorrectly.From misc/xen-command-line documentation:dom0_mem (x86)= List of ( min: | max: |

[libvirt test] 166091: regressions - FAIL

flight 166091 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/166091/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-arm64-libvirt

Re: [PATCH] x86/smp: Factor out parts of native_smp_prepare_cpus()

On 09/11/2021 15:10, Peter Zijlstra wrote: > On Mon, Nov 08, 2021 at 12:20:26PM -0500, Boris Ostrovsky wrote: >>> But looking at those functions; there seems to be more spurious >>> differences. For example, the whole sched_topology thing. >> >> I did look at that and thought this should be benign

Re: [PATCH for-4.16] Revert "domctl: improve locking during domain destruction"

Hi, On 09/11/2021 14:55, Roger Pau Monné wrote: On Tue, Nov 09, 2021 at 02:42:58PM +, Julien Grall wrote: Hi Roger, On 09/11/2021 14:31, Roger Pau Monne wrote: This reverts commit 228ab9992ffb1d8f9d2475f2581e68b2913acb88. Performance analysis has shown that dropping the domctl lock durin

Re: [PATCH] x86/smp: Factor out parts of native_smp_prepare_cpus()

On 09.11.21 16:10, Peter Zijlstra wrote: On Mon, Nov 08, 2021 at 12:20:26PM -0500, Boris Ostrovsky wrote: On 11/8/21 10:11 AM, Peter Zijlstra wrote: On Tue, Nov 02, 2021 at 07:36:36PM -0400, Boris Ostrovsky wrote: Commit 66558b730f25 ("sched: Add cluster scheduler level for x86") introduced c

Re: [PATCH for-4.16] Revert "domctl: improve locking during domain destruction"

On Tue, Nov 09, 2021 at 03:04:56PM +, Ian Jackson wrote: > Roger Pau Monne writes ("[PATCH for-4.16] Revert "domctl: improve locking > during domain destruction""): > > This reverts commit 228ab9992ffb1d8f9d2475f2581e68b2913acb88. > > > > Performance analysis has shown that dropping the domct

Re: [PATCH] x86/smp: Factor out parts of native_smp_prepare_cpus()

On Mon, Nov 08, 2021 at 12:20:26PM -0500, Boris Ostrovsky wrote: > > On 11/8/21 10:11 AM, Peter Zijlstra wrote: > > On Tue, Nov 02, 2021 at 07:36:36PM -0400, Boris Ostrovsky wrote: > > > Commit 66558b730f25 ("sched: Add cluster scheduler level for x86") > > > introduced cpu_l2c_shared_map mask whi

Re: [PATCH for-4.16] Revert "domctl: improve locking during domain destruction"

Roger Pau Monne writes ("[PATCH for-4.16] Revert "domctl: improve locking during domain destruction""): > This reverts commit 228ab9992ffb1d8f9d2475f2581e68b2913acb88. > > Performance analysis has shown that dropping the domctl lock during > domain destruction greatly increases the contention in

[PATCH 3/3][4.16?] VT-d: don't needlessly engage the untrusted-MSI workaround

The quarantine domain doesn't count as a DomU, as it won't itself trigger any bad behavior. The workaround only needs enabling when an actual DomU is about to gain control of a device. This then also means enabling of the workaround can be deferred until immediately ahead of the call to domain_cont

[PATCH 2/3][4.16?] VT-d: fix reduced page table levels support when sharing tables

domain_pgd_maddr() contains logic to adjust the root address to be put in the context entry in case 4-level page tables aren't supported by an IOMMU. This logic may not be bypassed when sharing page tables. Fixes: 25ccd093425c ("iommu: remove the share_p2m operation") Signed-off-by: Jan Beulich

[PATCH 1/3][4.16?] VT-d: per-domain IOMMU bitmap needs to have dynamic size

With no upper bound (anymore) on the number of IOMMUs, a fixed-size 64-bit map may be insufficient (systems with 40 IOMMUs have already been observed). Fixes: 27713fa2aa21 ("VT-d: improve save/restore of registers across S3") Signed-off-by: Jan Beulich --- a/xen/drivers/passthrough/vtd/iommu.c +

Re: [PATCH for-4.16] Revert "domctl: improve locking during domain destruction"

On Tue, Nov 09, 2021 at 02:42:58PM +, Julien Grall wrote: > Hi Roger, > > On 09/11/2021 14:31, Roger Pau Monne wrote: > > This reverts commit 228ab9992ffb1d8f9d2475f2581e68b2913acb88. > > > > Performance analysis has shown that dropping the domctl lock during > > domain destruction greatly in

[PATCH 0/3][4.16?] VT-d: misc (regression) fixes

1: per-domain IOMMU bitmap needs to have dynamic size 2: fix reduced page table levels support when sharing tables 3: don't needlessly engage the untrusted-MSI workaround As to 4.16 considerations: Only patch 1 addresses a regression introduced after 4.15, the others are older. Patch 3 additionall

Re: [PATCH v2] PCI/MSI: Move non-mask check back into low level accessors

On Thu, Nov 04 2021 at 00:27, Thomas Gleixner wrote: > > - if (!entry->msi_attrib.is_virtual) { > + if (!entry->msi_attrib.can_mask) { Groan. I'm a moron. This obviously needs to be if (entry->msi_attrib.can_mask) { > addr = pci_msi

Re: [PATCH for-4.16] Revert "domctl: improve locking during domain destruction"

Hi Roger, On 09/11/2021 14:31, Roger Pau Monne wrote: This reverts commit 228ab9992ffb1d8f9d2475f2581e68b2913acb88. Performance analysis has shown that dropping the domctl lock during domain destruction greatly increases the contention in the heap_lock, thus making parallel destruction of domai

Re: [PATCH for-4.16] Revert "domctl: improve locking during domain destruction"

On 09/11/2021 14:31, Roger Pau Monne wrote: > This reverts commit 228ab9992ffb1d8f9d2475f2581e68b2913acb88. > > Performance analysis has shown that dropping the domctl lock during > domain destruction greatly increases the contention in the heap_lock, > thus making parallel destruction of domains s

[PATCH for-4.16] Revert "domctl: improve locking during domain destruction"

This reverts commit 228ab9992ffb1d8f9d2475f2581e68b2913acb88. Performance analysis has shown that dropping the domctl lock during domain destruction greatly increases the contention in the heap_lock, thus making parallel destruction of domains slower. The following lockperf data shows the differe

[GIT PULL] xen: branch for v5.16-rc1

Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.16b-rc1-tag xen: branch for v5.16-rc1 It contains the following patches: - a series for speeding up the boot of Xen PV guests - some cleanups in Xen related code - replacement of

[xen-unstable-smoke test] 166095: tolerable all pass - PUSHED

flight 166095 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/166095/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: ASSERT in rangeset_remove_range

On 09.11.2021 12:58, Julien Grall wrote: > On 08/11/2021 22:45, Stefano Stabellini wrote: >> I discovered a bug caused by the recent changes to introduce extended >> regions in make_hypervisor_node (more logs appended): >> >> >> (XEN) d1 BANK[0] 0x004000-0x007e80 (1000MB) >> (XEN) d

Re: [PATCH] xen/balloon: fix unused-variable warning

On 11/8/21 6:14 AM, Arnd Bergmann wrote: From: Arnd Bergmann In configurations with CONFIG_XEN_BALLOON_MEMORY_HOTPLUG=n and CONFIG_XEN_BALLOON_MEMORY_HOTPLUG=y, gcc warns about an unused variable: drivers/xen/balloon.c:83:12: error: 'xen_hotplug_unpopulated' defined but not used [-Werror=un

[qemu-mainline test] 166089: tolerable FAIL - PUSHED

flight 166089 qemu-mainline real [real] flight 166096 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/166089/ http://logs.test-lab.xenproject.org/osstest/logs/166096/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-ar

Re: ASSERT in rangeset_remove_range

(+ Jan, Andrew, Wei for the common code) On 08/11/2021 22:45, Stefano Stabellini wrote: Hi Oleksandr, Julien, Hi, I discovered a bug caused by the recent changes to introduce extended regions in make_hypervisor_node (more logs appended): (XEN) d1 BANK[0] 0x004000-0x007e80 (

[ovmf test] 166093: all pass - PUSHED

flight 166093 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/166093/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d6e6337cd6ee0b7f06578693ea0cef8e428b93f9 baseline version: ovmf 8c1b1fe634a233ad7570f

Re: [XEN][RFC PATCH v2 09/12] xen/arm: Implement device tree node addition functionalities

On 09.11.2021 08:02, Vikram Garhwal wrote: > --- a/xen/common/sysctl.c > +++ b/xen/common/sysctl.c > @@ -331,6 +331,205 @@ out: > spin_unlock(&overlay_lock); > return rc; > } > + > +/* > + * Adds device tree nodes under target node. > + * We use dt_host_new to unflatten the updated devic

Re: [XEN][RFC PATCH v2 08/12] xen/arm: Implement device tree node removal functionalities

On 09.11.2021 08:02, Vikram Garhwal wrote: > Introduce sysctl XEN_SYSCTL_overlay to remove device-tree nodes added using > device tree overlay. XEN_SYSCTL_overlay is too generic a name imo. > @@ -476,6 +781,73 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) > u_sysctl) > copy

Re: [XEN][RFC PATCH v2 03/12] libfdt: Keep fdt functions after init for CONFIG_OVERLAY_DTB.

On 09.11.2021 08:02, Vikram Garhwal wrote: > This is done to access fdt library function which are required for adding > device > tree overlay nodes for dynamic programming of nodes. > > Signed-off-by: Vikram Garhwal > --- > xen/common/libfdt/Makefile | 3 +++ > 1 file changed, 3 insertions(+)

Re: [PATCH-4.16 v2] xen/efi: Fix Grub2 boot on arm64

On 09.11.2021 10:23, Luca Fancellu wrote: >> On 9 Nov 2021, at 02:11, Stefano Stabellini wrote: >> Should we have a global variable to keep the dir_handle open during >> dom0less module loading? > > I thought about a solution for that, here the changes, please not that I’ve > just built them, no

Re: [PATCH-4.16 v2] xen/efi: Fix Grub2 boot on arm64

On 09.11.2021 03:11, Stefano Stabellini wrote: > On Mon, 8 Nov 2021, Jan Beulich wrote: >> On 05.11.2021 16:33, Stefano Stabellini wrote: >>> My main concern is performance and resource utilization. With v3 of the >>> patch get_parent_handle will get called for every module to be loaded. >>> With d

[PATCH for-4.16] tools/configure: make iPXE dependent on QEMU traditional

Roger Pau Monne writes ("[PATCH for-4.16] tools/configure: make iPXE dependent on QEMU traditional"): > iPXE is only used by QEMU traditional, so make it off by default > unless QEMU traditional is enabled. > > Reported-by: Andrew Cooper > Fixes: bcf77ce510 ('configure: modify default of buildin

Re: [PATCH for-4.16] xen/arm: don't assign domU static-mem to dom0 as reserved-memory

Stefano Stabellini writes ("[PATCH for-4.16] xen/arm: don't assign domU static-mem to dom0 as reserved-memory"): > From: Stefano Stabellini > > DomUs static-mem ranges are added to the reserved_mem array for > accounting, but they shouldn't be assigned to dom0 as the other regular > reserved-mem

RE: [PATCH v2 1/6] xen: introduce XEN_DOMCTL_CDF_directmap

Hi Julien > -Original Message- > From: Julien Grall > Sent: Friday, October 15, 2021 4:57 PM > To: Penny Zheng ; xen-devel@lists.xenproject.org; > sstabell...@kernel.org > Cc: Wei Chen ; Bertrand Marquis > > Subject: Re: [PATCH v2 1/6] xen: introduce XEN_DOMCTL_CDF_directmap > > Hi Penn

[PATCH for-4.16] tools/configure: make iPXE dependent on QEMU traditional

iPXE is only used by QEMU traditional, so make it off by default unless QEMU traditional is enabled. Reported-by: Andrew Cooper Fixes: bcf77ce510 ('configure: modify default of building rombios') Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson Please run autoconf before commit. Without thi

Re: [PATCH 1/3] drm/exynox: Implement mmap as GEM object function

Hi Am 09.11.21 um 10:34 schrieb Inki Dae: Hi Thomas and Daniel, 21. 11. 9. 오전 12:29에 Daniel Vetter 이(가) 쓴 글: On Mon, Nov 08, 2021 at 11:28:44AM +0100, Thomas Zimmermann wrote: Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbac

Re: [PATCH for-4.16] xen/arm: don't assign domU static-mem to dom0 as reserved-memory

Hi Stefano, On 09/11/2021 00:48, Stefano Stabellini wrote: From: Stefano Stabellini DomUs static-mem ranges are added to the reserved_mem array for accounting, but they shouldn't be assigned to dom0 as the other regular reserved-memory ranges in device tree. In make_memory_nodes, fix the erro

Re: [PATCH 1/3] drm/exynox: Implement mmap as GEM object function

Hi Thomas and Daniel, 21. 11. 9. 오전 12:29에 Daniel Vetter 이(가) 쓴 글: > On Mon, Nov 08, 2021 at 11:28:44AM +0100, Thomas Zimmermann wrote: >> Moving the driver-specific mmap code into a GEM object function allows >> for using DRM helpers for various mmap callbacks. >> >> The respective exynos functio

Re: [PATCH-4.16 v2] xen/efi: Fix Grub2 boot on arm64

> On 9 Nov 2021, at 02:11, Stefano Stabellini wrote: > > On Mon, 8 Nov 2021, Jan Beulich wrote: >> On 05.11.2021 16:33, Stefano Stabellini wrote: >>> On Fri, 5 Nov 2021, Jan Beulich wrote: On 04.11.2021 22:50, Stefano Stabellini wrote: > On Thu, 4 Nov 2021, Luca Fancellu wrote: >>

Re: [PATCH v6 3/7] xen/arm: setup MMIO range trap handlers for hardware domain

On 05.11.21 08:33, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > [snip] > +int pci_host_iterate_bridges(struct domain *d, > + int (*cb)(struct domain *d, > + struct pci_host_bridge *bridge)) > +{ > +struct

[xen-unstable test] 166088: tolerable FAIL - PUSHED

flight 166088 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/166088/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 166080 Tests which did not succeed

Re: ASSERT in rangeset_remove_range

On Tue, Nov 9, 2021 at 12:45 AM Stefano Stabellini wrote: > Hi Oleksandr, Julien, > Hi Stefano, Julien. [Sorry for the possible format issues] > > I discovered a bug caused by the recent changes to introduce extended > regions in make_hypervisor_node (more logs appended): > > > (XEN) d1 BANK[