[linux-linus test] 167520: tolerable FAIL - PUSHED

2021-12-22 Thread osstest service owner
flight 167520 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/167520/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 167512 test-amd64-amd64-qemuu-nested-amd 20

[ovmf test] 167522: all pass - PUSHED

2021-12-22 Thread osstest service owner
flight 167522 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/167522/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf ae8272ef787d80950803c521a13a308651bdc62e baseline version: ovmf 9ec2cc1f3138ef9314314

[qemu-mainline test] 167519: tolerable FAIL - PUSHED

2021-12-22 Thread osstest service owner
flight 167519 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/167519/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 167515 test-armhf-armhf-libvirt 16 sav

Re: [RFC v1 4/5] tools/arm: add "scmi_smc" option to xl.cfg

2021-12-22 Thread Stefano Stabellini
On Wed, 22 Dec 2021, Oleksii Moisieiev wrote: > On Mon, Dec 20, 2021 at 04:54:25PM -0800, Stefano Stabellini wrote: > > On Tue, 14 Dec 2021, Oleksii Moisieiev wrote: > > > This enumeration sets SCI type for the domain. Currently there is > > > two possible options: either 'none' or 'scmi_smc'. > >

Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver

2021-12-22 Thread Stefano Stabellini
On Wed, 22 Dec 2021, Oleksii Moisieiev wrote: > On Tue, Dec 21, 2021 at 01:22:50PM -0800, Stefano Stabellini wrote: > > On Tue, 21 Dec 2021, Oleksii Moisieiev wrote: > > > Hi Stefano, > > > > > > On Mon, Dec 20, 2021 at 04:52:01PM -0800, Stefano Stabellini wrote: > > > > On Mon, 20 Dec 2021, Oleks

Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs

2021-12-22 Thread Stefano Stabellini
On Wed, 22 Dec 2021, Julien Grall wrote: > > > > > > To me dtdev and XEN_DOMCTL_assign_device are appropriate because > > > > > > they > > > > > > signify device assignment of one or more devices. We are not adding > > > > > > any > > > > > > additional "meaning" to them. It is just that we'll auto

[linux-5.4 test] 167516: tolerable FAIL - PUSHED

2021-12-22 Thread osstest service owner
flight 167516 linux-5.4 real [real] flight 167521 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/167516/ http://logs.test-lab.xenproject.org/osstest/logs/167521/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm6

[qemu-mainline test] 167515: tolerable FAIL - PUSHED

2021-12-22 Thread osstest service owner
flight 167515 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/167515/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 167509 test-armhf-armhf-libvirt 16 sav

[linux-linus test] 167512: tolerable FAIL - PUSHED

2021-12-22 Thread osstest service owner
flight 167512 linux-linus real [real] flight 167518 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/167512/ http://logs.test-lab.xenproject.org/osstest/logs/167518/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-

Re: [XEN][RFC PATCH v2 08/12] xen/arm: Implement device tree node removal functionalities

2021-12-22 Thread Julien Grall
Hi, On 09/11/2021 08:02, Vikram Garhwal wrote: Introduce sysctl XEN_SYSCTL_overlay to remove device-tree nodes added using I agree with Jan about the name being too generic. I will comment on this a bit further down. device tree overlay. xl overlay remove file.dtbo: Removes all the n

Re: [XEN][RFC PATCH v2 07/12] xen/smmu: Add remove_device callback for smmu_iommu ops

2021-12-22 Thread Julien Grall
Hi, On 09/11/2021 08:02, Vikram Garhwal wrote: Add remove_device callback for removing the device entry from smmu-master using following steps: 1. Find if SMMU master exists for the device node. 2. Remove the SMMU master The commit title and message doesn't match the code. Signe

Re: [XEN][RFC PATCH v2 06/12] xen/smmu: Add remove_device callback for smmu_iommu ops

2021-12-22 Thread Julien Grall
Hi, On 09/11/2021 08:02, Vikram Garhwal wrote: Add remove_device callback for removing the device entry from smmu-master using following steps: 1. Find if SMMU master exists for the device node. 2. Remove the SMMU master Signed-off-by: Vikram Garhwal --- xen/drivers/passthrough/arm/smmu.c |

Re: [XEN][RFC PATCH v2 04/12] libfdt: Add fdt_ prefix to overlay_get_target()

2021-12-22 Thread Julien Grall
Hi, On 09/11/2021 08:02, Vikram Garhwal wrote: Add fdt_ prefix to overlay_get_target() and remove static type. This is done to get the target path for all the overlay nodes. This is useful to find which nodes are to be added/removed in dt_host. Also, sending this patch to dtc mailing list to av

Re: [XEN][RFC PATCH v2 03/12] libfdt: Keep fdt functions after init for CONFIG_OVERLAY_DTB.

2021-12-22 Thread Julien Grall
Hi Vikram, On 09/11/2021 08:02, Vikram Garhwal wrote: This is done to access fdt library function which are required for adding device tree overlay nodes for dynamic programming of nodes. Signed-off-by: Vikram Garhwal --- xen/common/libfdt/Makefile | 3 +++ 1 file changed, 3 insertions(+)

Re: [XEN][RFC PATCH v2 02/12] xen: arm: Add CONFIG_OVERLAY_DTB

2021-12-22 Thread Julien Grall
Hi, Please add a short commit message explaning how this is going to be used. On 09/11/2021 08:02, Vikram Garhwal wrote: Signed-off-by: Vikram Garhwal --- xen/arch/arm/Kconfig | 8 1 file changed, 8 insertions(+) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index ecfa6

Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs

2021-12-22 Thread Julien Grall
Hi Volodymyr, On 22/12/2021 13:34, Volodymyr Babchuk wrote: Julien Grall writes: Hi, On 22/12/2021 12:17, Volodymyr Babchuk wrote: Julien Grall writes: On 21/12/2021 22:39, Stefano Stabellini wrote: On Tue, 21 Dec 2021, Anthony PERARD wrote: On Fri, Dec 17, 2021 at 12:15:25PM +, O

Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs

2021-12-22 Thread Oleksii Moisieiev
Hi Stefano, On Mon, Dec 20, 2021 at 05:37:50PM -0800, Stefano Stabellini wrote: > On Tue, 14 Dec 2021, Oleksii Moisieiev wrote: > > Integration of the SCMI mediator with xen libs: > > - add hypercalls to aquire SCI channel and set device permissions > > for DomUs; > > - add SCMI_SMC nodes to DomU

Re: [PATCH V4] xen/gnttab: Store frame GFN in struct page_info on Arm

2021-12-22 Thread Oleksandr
On 22.12.21 14:33, Julien Grall wrote: Hi Jan, Hi Julien, Jan On 22/12/2021 13:05, Jan Beulich wrote: On 22.12.2021 11:01, Julien Grall wrote: On 14/12/2021 17:45, Jan Beulich wrote: On 14.12.2021 17:26, Oleksandr wrote: On 14.12.21 15:37, Jan Beulich wrote: On 03.12.2021 21:33, Ol

Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs

2021-12-22 Thread Volodymyr Babchuk
Julien Grall writes: > Hi, > > On 22/12/2021 12:17, Volodymyr Babchuk wrote: >> Julien Grall writes: >>> On 21/12/2021 22:39, Stefano Stabellini wrote: On Tue, 21 Dec 2021, Anthony PERARD wrote: > On Fri, Dec 17, 2021 at 12:15:25PM +, Oleksii Moisieiev wrote: >>> On 14.12.21 1

Re: [PATCH V4] xen/gnttab: Store frame GFN in struct page_info on Arm

2021-12-22 Thread Julien Grall
Hi Jan, On 22/12/2021 13:05, Jan Beulich wrote: On 22.12.2021 11:01, Julien Grall wrote: On 14/12/2021 17:45, Jan Beulich wrote: On 14.12.2021 17:26, Oleksandr wrote: On 14.12.21 15:37, Jan Beulich wrote: On 03.12.2021 21:33, Oleksandr Tyshchenko wrote: @@ -2177,14 +2181,22 @@ void *alloc_x

Re: [RFC v1 4/5] tools/arm: add "scmi_smc" option to xl.cfg

2021-12-22 Thread Oleksii Moisieiev
On Tue, Dec 21, 2021 at 01:27:11PM +, Anthony PERARD wrote: > On Tue, Dec 14, 2021 at 09:34:28AM +, Oleksii Moisieiev wrote: > > This enumeration sets SCI type for the domain. Currently there is > > two possible options: either 'none' or 'scmi_smc'. > > > > 'none' is the default value an

Re: [PATCH V4] xen/gnttab: Store frame GFN in struct page_info on Arm

2021-12-22 Thread Jan Beulich
On 22.12.2021 11:01, Julien Grall wrote: > On 14/12/2021 17:45, Jan Beulich wrote: >> On 14.12.2021 17:26, Oleksandr wrote: >>> On 14.12.21 15:37, Jan Beulich wrote: On 03.12.2021 21:33, Oleksandr Tyshchenko wrote: > @@ -2177,14 +2181,22 @@ void *alloc_xenheap_pages(unsigned int order, >>

[xen-unstable test] 167510: tolerable FAIL

2021-12-22 Thread osstest service owner
flight 167510 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/167510/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail blocked in 167504 test-amd64-amd64-xl-qemut-win7-amd64

Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs

2021-12-22 Thread Julien Grall
Hi, On 22/12/2021 12:17, Volodymyr Babchuk wrote: Julien Grall writes: On 21/12/2021 22:39, Stefano Stabellini wrote: On Tue, 21 Dec 2021, Anthony PERARD wrote: On Fri, Dec 17, 2021 at 12:15:25PM +, Oleksii Moisieiev wrote: On 14.12.21 11:34, Oleksii Moisieiev wrote: @@ -1817,17 +1858,

Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs

2021-12-22 Thread Volodymyr Babchuk
Hi Julien, Julien Grall writes: > Hi Stefano, > > On 21/12/2021 22:39, Stefano Stabellini wrote: >> On Tue, 21 Dec 2021, Anthony PERARD wrote: >>> On Fri, Dec 17, 2021 at 12:15:25PM +, Oleksii Moisieiev wrote: > On 14.12.21 11:34, Oleksii Moisieiev wrote: >> @@ -1817,17 +1858,24 @@

Re: [BUG] Resource leaks in Xen

2021-12-22 Thread Ryan Cai
I have send a patch. Thank you for your reply. Best, Yuandao On 22/12/2021, 5:28 PM, "Jan Beulich" wrote: On 22.12.2021 09:05, Ryan Cai wrote: > I am writing you to report potential resource leak bugs. In the file /xen/tools/flask/utils/label-pci.c, the methods fopen and

Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver

2021-12-22 Thread Oleksii Moisieiev
On Tue, Dec 21, 2021 at 01:22:50PM -0800, Stefano Stabellini wrote: > On Tue, 21 Dec 2021, Oleksii Moisieiev wrote: > > Hi Stefano, > > > > On Mon, Dec 20, 2021 at 04:52:01PM -0800, Stefano Stabellini wrote: > > > On Mon, 20 Dec 2021, Oleksii Moisieiev wrote: > > > > Hi Stefano, > > > > > > > > O

Re: [PATCH V4] xen/gnttab: Store frame GFN in struct page_info on Arm

2021-12-22 Thread Oleksandr
On 22.12.21 12:01, Julien Grall wrote: Hi Julien Hi Jan, On 14/12/2021 17:45, Jan Beulich wrote: On 14.12.2021 17:26, Oleksandr wrote: On 14.12.21 15:37, Jan Beulich wrote: On 03.12.2021 21:33, Oleksandr Tyshchenko wrote: @@ -2177,14 +2181,22 @@ void *alloc_xenheap_pages(unsigned int ord

[libvirt test] 167511: regressions - FAIL

2021-12-22 Thread osstest service owner
flight 167511 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/167511/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

Re: [PATCH V4] xen/gnttab: Store frame GFN in struct page_info on Arm

2021-12-22 Thread Oleksandr
On 22.12.21 11:49, Julien Grall wrote: Hi Oleksandr, Hi Julien On 14/12/2021 17:26, Oleksandr wrote: @@ -1487,7 +1489,23 @@ int xenmem_add_to_physmap_one(   }   /* Map at new location. */ -    rc = guest_physmap_add_entry(d, gfn, mfn, 0, t); +    if ( !p2m_is_ram(t) || !is_xen_he

Re: [RFC v1 4/5] tools/arm: add "scmi_smc" option to xl.cfg

2021-12-22 Thread Oleksii Moisieiev
On Mon, Dec 20, 2021 at 04:54:25PM -0800, Stefano Stabellini wrote: > On Tue, 14 Dec 2021, Oleksii Moisieiev wrote: > > This enumeration sets SCI type for the domain. Currently there is > > two possible options: either 'none' or 'scmi_smc'. > > > > 'none' is the default value and it disables SCI s

[xen-unstable-coverity test] 167517: all pass - PUSHED

2021-12-22 Thread osstest service owner
flight 167517 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/167517/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen f1e268b9fd13647e1f69c8ce0ae7be401d319fc8 baseline version: xen 8e3e

[ovmf test] 167513: all pass - PUSHED

2021-12-22 Thread osstest service owner
flight 167513 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/167513/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 9ec2cc1f3138ef9314314df29fc6ce0aa5e120b9 baseline version: ovmf de9e5b7dc721d4ca319c0

Re: [PATCH V4] xen/gnttab: Store frame GFN in struct page_info on Arm

2021-12-22 Thread Julien Grall
Hi Jan, On 14/12/2021 17:45, Jan Beulich wrote: On 14.12.2021 17:26, Oleksandr wrote: On 14.12.21 15:37, Jan Beulich wrote: On 03.12.2021 21:33, Oleksandr Tyshchenko wrote: @@ -2177,14 +2181,22 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags) void free_xenheap_p

Re: [PATCH V4] xen/gnttab: Store frame GFN in struct page_info on Arm

2021-12-22 Thread Julien Grall
Hi Oleksandr, On 14/12/2021 17:26, Oleksandr wrote: @@ -1487,7 +1489,23 @@ int xenmem_add_to_physmap_one(   }   /* Map at new location. */ -    rc = guest_physmap_add_entry(d, gfn, mfn, 0, t); +    if ( !p2m_is_ram(t) || !is_xen_heap_mfn(mfn) ) +    rc = guest_physmap_add_entry(d, gf

Re: [PATCH V6 1/2] libxl: Add support for Virtio disk configuration

2021-12-22 Thread Oleksandr
On 21.12.21 18:46, Anthony PERARD wrote: Hi Anthony, Juergen On Fri, Dec 17, 2021 at 06:50:02PM +0200, Oleksandr wrote: On 17.12.21 17:26, Juergen Gross wrote: On 15.12.21 22:36, Oleksandr wrote: On 15.12.21 17:58, Juergen Gross wrote: In practice we are having something like the "protoc

Re: [BUG] Resource leaks in Xen

2021-12-22 Thread Jan Beulich
On 22.12.2021 09:05, Ryan Cai wrote: > I am writing you to report potential resource leak bugs. In the > file /xen/tools/flask/utils/label-pci.c, the methods fopen and fclose may not > matched when returning at Line 76, resulting in a resource leak. Looking > forward to your feedbac

Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs

2021-12-22 Thread Julien Grall
Hi Stefano, On 21/12/2021 22:39, Stefano Stabellini wrote: On Tue, 21 Dec 2021, Anthony PERARD wrote: On Fri, Dec 17, 2021 at 12:15:25PM +, Oleksii Moisieiev wrote: On 14.12.21 11:34, Oleksii Moisieiev wrote: @@ -1817,17 +1858,24 @@ static void libxl__add_dtdevs(libxl__egc *egc, libxl__a

Re: [PATCH] xen/arm: fix the build error for GIC

2021-12-22 Thread Julien Grall
Hello, On 22/12/2021 09:38, Dongjiu Geng wrote: when enable CONFIG_NEW_VGIC in ARM64 QEMU Platform, it will build failed. so fix it and make it can select GICV2. Last time I checked QEMU, it was only able to support GICv3 virtualization. Has it changed since? Signed-off-by: Dongjiu Geng

[PATCH] xen/arm: fix the build error for GIC

2021-12-22 Thread Dongjiu Geng
when enable CONFIG_NEW_VGIC in ARM64 QEMU Platform, it will build failed. so fix it and make it can select GICV2. Signed-off-by: Dongjiu Geng --- $ make dist-xen XEN_TARGET_ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j10 make -C xen install make[1]: Entering directory '/home/workspace/gengdongj

[BUG] Resource leaks in Xen

2021-12-22 Thread Ryan Cai
Dear maintainers for Xen Project, I am writing you to report potential resource leak bugs. In the file /xen/tools/flask/utils/label-pci.c, the methods fopen and fclose may not matched when returning at Line 76, resulting in a resource leak. Looking forward to your feedback. Than