[xen-4.16-testing test] 168136: tolerable FAIL - PUSHED

2022-02-16 Thread osstest service owner
flight 168136 xen-4.16-testing real [real] flight 168147 xen-4.16-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/168136/ http://logs.test-lab.xenproject.org/osstest/logs/168147/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): t

[linux-5.4 test] 168130: tolerable FAIL - PUSHED

2022-02-16 Thread osstest service owner
flight 168130 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/168130/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 168112 test-amd64-i386-xl-qemut-win7-amd64 19

Re: [PATCH v2 04/70] x86/pv-shim: Don't modify the hypercall table

2022-02-16 Thread Andrew Cooper
On 14/02/2022 13:56, Jan Beulich wrote: > On 14.02.2022 14:50, Andrew Cooper wrote: >> On 14/02/2022 13:33, Jan Beulich wrote: >>> On 14.02.2022 13:50, Andrew Cooper wrote: From: Juergen Gross When running as pv-shim the hypercall is modified today in order to replace the funct

Re: [PATCH v2 00/70] x86: Support for CET Indirect Branch Tracking

2022-02-16 Thread Andrew Cooper
On 14/02/2022 14:38, Jan Beulich wrote: > On 14.02.2022 15:15, Andrew Cooper wrote: >> On 14/02/2022 13:43, Jan Beulich wrote: >>> On 14.02.2022 14:10, Andrew Cooper wrote: On 14/02/2022 12:50, Andrew Cooper wrote: > CET Indirect Branch Tracking is a hardware feature designed to protect >

Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time

2022-02-16 Thread Stefano Stabellini
On Wed, 16 Feb 2022, Luca Fancellu wrote: > > On 16 Feb 2022, at 02:45, Stefano Stabellini wrote: > > > > On Tue, 15 Feb 2022, Luca Fancellu wrote: > >> Introduce an architecture specific way to create different cpupools > >> at boot time, this is particularly useful on ARM big.LITTLE system > >>

Re: [PATCH v2 06/70] x86: Introduce support for CET-IBT

2022-02-16 Thread Andrew Cooper
On 15/02/2022 14:01, Jan Beulich wrote: > On 14.02.2022 13:50, Andrew Cooper wrote: >> --- a/xen/arch/x86/Kconfig >> +++ b/xen/arch/x86/Kconfig >> @@ -39,6 +39,11 @@ config HAS_AS_CET_SS >> # binutils >= 2.29 or LLVM >= 6 >> def_bool $(as-instr,wrssq %rax$(comma)0;setssbsy) >> >> +confi

Re: Metadata and signalling channels for Zephyr virtio-backends on Xen

2022-02-16 Thread Stefano Stabellini
On Tue, 15 Feb 2022, Vincent Guittot wrote: > On Tue, 8 Feb 2022 at 01:16, Stefano Stabellini > wrote: > > > > On Mon, 7 Feb 2022, Alex Bennée wrote: > > > Hi Stefano, > > > > > > Vincent gave an update on his virtio-scmi work at the last Stratos sync > > > call and the discussion moved onto next

Re: [PATCH v2 34/70] x86/emul: CFI hardening

2022-02-16 Thread Andrew Cooper
On 15/02/2022 14:13, Jan Beulich wrote: > On 15.02.2022 14:43, Andrew Cooper wrote: >> On 14/02/2022 13:38, Jan Beulich wrote: >>> On 14.02.2022 13:50, Andrew Cooper wrote: Control Flow Integrity schemes use toolchain and optionally hardware support to help protect against call/jump

Re: [PATCH v6 00/21] Introduce power-off+restart call chain API

2022-02-16 Thread Helge Deller
On 2/16/22 13:25, Rafael J. Wysocki wrote: > On Tue, Feb 15, 2022 at 11:00 PM Dmitry Osipenko wrote: >> >> 31.01.2022 02:36, Dmitry Osipenko пишет: >>> Problem >>> --- >>> >>> SoC devices require power-off call chaining functionality from kernel. >>> We have a widely used restart chaining prov

[xen-unstable test] 168129: tolerable FAIL - PUSHED

2022-02-16 Thread osstest service owner
flight 168129 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/168129/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds18 guest-start/debian.repeat fail REGR. vs. 168124 Tests which did not succeed

[ovmf test] 168131: all pass - PUSHED

2022-02-16 Thread osstest service owner
flight 168131 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168131/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 8a576733162bb72afb4d1eb3012b0aef8d265018 baseline version: ovmf c28e376edc46e6db6e4a5

Re: [PATCH v2] lib: extend ASSERT()

2022-02-16 Thread Bertrand Marquis
Hi Jan, > On 16 Feb 2022, at 14:43, Jan Beulich wrote: > > On 16.02.2022 15:35, Bertrand Marquis wrote: >> Hi Jan, >> >>> On 16 Feb 2022, at 14:03, Jan Beulich wrote: >>> >>> On 16.02.2022 14:57, Bertrand Marquis wrote: > On 16 Feb 2022, at 12:23, George Dunlap wrote: >> On Feb 16, 2

Re: [PATCH v2 RFC 4/5] x86/ioreq: report extended destination ID support by emulators

2022-02-16 Thread Durrant, Paul
On 16/02/2022 11:32, Roger Pau Monné wrote: On Wed, Feb 16, 2022 at 10:53:58AM +, Durrant, Paul wrote: On 16/02/2022 10:30, Roger Pau Monne wrote: Introduce a new arch specific field to report whether an emulator supports the Extended Destination ID field, so that the hypervisor can refrain

Re: [RFC v2 5/8] xen/arm: introduce SCMI-SMC mediator driver

2022-02-16 Thread Oleksii Moisieiev
Hi Stefano, On Mon, Feb 14, 2022 at 02:05:18PM -0800, Stefano Stabellini wrote: > On Mon, 14 Feb 2022, Oleksii Moisieiev wrote: > > Hi Bertrand, > > > > On Mon, Feb 14, 2022 at 11:27:21AM +, Bertrand Marquis wrote: > > > Hi Oleksii, > > > > > > > On 14 Feb 2022, at 11:13, Oleksii Moisieiev

Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time

2022-02-16 Thread Luca Fancellu
> On 16 Feb 2022, at 16:32, Dario Faggioli wrote: > > On Wed, 2022-02-16 at 12:37 +, Luca Fancellu wrote: >>> On 16 Feb 2022, at 06:18, Juergen Gross wrote: >>> On 15.02.22 18:56, Luca Fancellu wrote: > Yes, however I think the parser to handle everything by command line wo

Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time

2022-02-16 Thread Dario Faggioli
On Wed, 2022-02-16 at 12:37 +, Luca Fancellu wrote: > > On 16 Feb 2022, at 06:18, Juergen Gross wrote: > > On 15.02.22 18:56, Luca Fancellu wrote: > > > > > > > Yes, however I think the parser to handle everything by command > > > line would > > > be huge due to input sanitisation and not eas

[PATCH v2 0/3] retpoline: add clang support + Kconfig selectable

2022-02-16 Thread Roger Pau Monne
Hello, The following series adds retpoline support for clang builds, and also allows the user to select whether to enable retpoline support at build time via a new Kconfig option. I've tried adding a suitable description to the Kconfig option, but I'm sure there's room for improvement. Thanks, R

[PATCH v2 3/3] x86/Kconfig: introduce option to select retpoline usage

2022-02-16 Thread Roger Pau Monne
Add a new Kconfig option under the "Speculative hardening" section that allows selecting whether to enable retpoline. This depends on the underlying compiler having retpoline support. Requested-by: Andrew Cooper Signed-off-by: Roger Pau Monné --- Changes since v1: - Fix description of option to

[PATCH v2 1/3] x86/retpoline: rename retpoline Kconfig check to include GCC prefix

2022-02-16 Thread Roger Pau Monne
Current retpoline checks apply to GCC only, so make it obvious by prefixing the Kconfig option with GCC. Keep the previous option as a way to signal generic retpoline support regardless of the underlying compiler. No functional change intended. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beu

[PATCH v2 2/3] x86/clang: add retpoline support

2022-02-16 Thread Roger Pau Monne
Detect whether the compiler supports clang retpoline option and enable by default if available, just like it's done for gcc. Note clang already disables jump tables when retpoline is enabled, so there's no need to also pass the fno-jump-tables parameter. Also clang already passes the return addres

Re: [PATCH v2 1/5] x86/cpuid: add CPUID flag for Extended Destination ID support

2022-02-16 Thread David Woodhouse
On Wed, 2022-02-16 at 16:43 +0100, Jan Beulich wrote: > On 16.02.2022 11:30, Roger Pau Monne wrote: > > --- a/xen/include/public/arch-x86/cpuid.h > > +++ b/xen/include/public/arch-x86/cpuid.h > > @@ -102,6 +102,12 @@ > > #define XEN_HVM_CPUID_IOMMU_MAPPINGS (1u << 2) > > #define XEN_HVM_CPUID_V

Re: [PATCH v2 3/5] x86/vmsi: add support for extended destination ID in address field

2022-02-16 Thread Jan Beulich
On 16.02.2022 11:30, Roger Pau Monne wrote: > --- a/xen/include/public/domctl.h > +++ b/xen/include/public/domctl.h > @@ -588,6 +588,7 @@ struct xen_domctl_bind_pt_irq { > #define XEN_DOMCTL_VMSI_X86_DELIV_MASK 0x007000 > #define XEN_DOMCTL_VMSI_X86_TRIG_MASK0x008000 > #define XEN_DOMCTL_V

Re: [PATCH v2 2/5] xen/vioapic: add support for the extended destination ID field

2022-02-16 Thread Jan Beulich
On 16.02.2022 11:30, Roger Pau Monne wrote: > Such field uses bits 55:48, but for the purposes the register will be > used use bits 55:49 instead. Bit 48 is used to signal an RTE entry is > in remappable format which is not supported by the vIO-APIC. Nit: The first sentence looks to have some stra

Re: [PATCH v2 1/5] x86/cpuid: add CPUID flag for Extended Destination ID support

2022-02-16 Thread Jan Beulich
On 16.02.2022 11:30, Roger Pau Monne wrote: > --- a/xen/include/public/arch-x86/cpuid.h > +++ b/xen/include/public/arch-x86/cpuid.h > @@ -102,6 +102,12 @@ > #define XEN_HVM_CPUID_IOMMU_MAPPINGS (1u << 2) > #define XEN_HVM_CPUID_VCPU_ID_PRESENT (1u << 3) /* vcpu id is present in > EBX */ > #d

[PATCH 3/4] vpci: use pcidevs locking to protect MMIO handlers

2022-02-16 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko vPCI MMIO handlers are accessing pdevs without protecting this access with pcidevs_{lock|unlock}. This is not a problem as of now as these are only used by Dom0. But, towards vPCI is used also for guests, we need to properly protect pdev and pdev->vpci from being rem

[PATCH 1/4] pci: add rwlock to pcidevs_lock machinery

2022-02-16 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Currently pcidevs lock is a global recursive spinlock which is fine for the existing use cases. It is used to both protect pdev instances themselves from being removed while in use and to make sure the update of the relevant pdev properties is synchronized. Moving t

[PATCH 4/4] vpci: resolve possible clash while removing BAR overlaps

2022-02-16 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko modify_bars checks if the mapping of the BAR memory has already been done when mapping other device's BARs or, while unmapping, are still in use by other devices. With the existing locking scheme it is possible that there are other devices trying to do the same in p

[PATCH 2/4] vpci: restrict unhandled read/write operations for guests

2022-02-16 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko A guest would be able to read and write those registers which are not emulated and have no respective vPCI handlers, so it will be possible for it to access the hardware directly. In order to prevent a guest from reads and writes from/to the unhandled registers make

[PATCH 0/4] Yet another pci/vpci locking re-work

2022-02-16 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Hello, all! This is a yet another attempt to re-work the existing pci/vpci locking scheme towards vPCI is going to be used for guests. For more details on the previous attempts and their flaws please see [1], [2]. This work is based on the idea that it is possible

[linux-linus test] 168126: tolerable FAIL - PUSHED

2022-02-16 Thread osstest service owner
flight 168126 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/168126/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail like 168121 test-amd64-amd64-xl-qemut-win7-amd64

Re: [PATCH v2] lib: extend ASSERT()

2022-02-16 Thread Jan Beulich
On 16.02.2022 15:35, Bertrand Marquis wrote: > Hi Jan, > >> On 16 Feb 2022, at 14:03, Jan Beulich wrote: >> >> On 16.02.2022 14:57, Bertrand Marquis wrote: On 16 Feb 2022, at 12:23, George Dunlap wrote: > On Feb 16, 2022, at 11:42 AM, Jan Beulich wrote: > On 16.02.2022 12:34, Georg

Re: [PATCH v2] lib: extend ASSERT()

2022-02-16 Thread Bertrand Marquis
Hi Jan, > On 16 Feb 2022, at 14:03, Jan Beulich wrote: > > On 16.02.2022 14:57, Bertrand Marquis wrote: >>> On 16 Feb 2022, at 12:23, George Dunlap wrote: On Feb 16, 2022, at 11:42 AM, Jan Beulich wrote: On 16.02.2022 12:34, George Dunlap wrote: > I am opposed to overloading “ASS

Re: [PATCH v2] tools: remove xenstore entries on vchan server closure

2022-02-16 Thread Jason Andryuk
On Wed, Feb 16, 2022 at 1:33 AM Oleksandr Andrushchenko wrote: > > From: Oleksandr Andrushchenko > > vchan server creates XenStore entries to advertise its event channel and > ring, but those are not removed after the server quits. > Add additional cleanup step, so those are removed, so clients d

Re: [PATCH 2/3] x86/clang: add retpoline support

2022-02-16 Thread Jan Beulich
On 16.02.2022 12:26, Roger Pau Monné wrote: > On Wed, Feb 16, 2022 at 10:47:52AM +0100, Jan Beulich wrote: >> On 16.02.2022 10:02, Roger Pau Monne wrote: >>> Detect whether the compiler supports clang retpoline option and enable >>> by default if available, just like it's done for gcc. >>> >>> Note

Re: [PATCH v2] lib: extend ASSERT()

2022-02-16 Thread Jan Beulich
On 16.02.2022 14:57, Bertrand Marquis wrote: >> On 16 Feb 2022, at 12:23, George Dunlap wrote: >>> On Feb 16, 2022, at 11:42 AM, Jan Beulich wrote: >>> On 16.02.2022 12:34, George Dunlap wrote: I am opposed to overloading “ASSERT” for this new kind of macro; I think it would not only b

Re: [PATCH v2] lib: extend ASSERT()

2022-02-16 Thread Bertrand Marquis
Hi, > On 16 Feb 2022, at 12:23, George Dunlap wrote: > > > >> On Feb 16, 2022, at 11:42 AM, Jan Beulich wrote: >> >> On 16.02.2022 12:34, George Dunlap wrote: >> >>> I am opposed to overloading “ASSERT” for this new kind of macro; I think it >>> would not only be unnecessarily confusing to

Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time

2022-02-16 Thread Juergen Gross
On 16.02.22 14:01, Luca Fancellu wrote: On 16 Feb 2022, at 12:55, Juergen Gross wrote: On 16.02.22 13:10, Luca Fancellu wrote: On 16 Feb 2022, at 02:45, Stefano Stabellini wrote: On Tue, 15 Feb 2022, Luca Fancellu wrote: Introduce an architecture specific way to create different cpupools

Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time

2022-02-16 Thread Luca Fancellu
> On 16 Feb 2022, at 12:55, Juergen Gross wrote: > > On 16.02.22 13:10, Luca Fancellu wrote: >>> On 16 Feb 2022, at 02:45, Stefano Stabellini wrote: >>> >>> On Tue, 15 Feb 2022, Luca Fancellu wrote: Introduce an architecture specific way to create different cpupools at boot time, t

Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time

2022-02-16 Thread Juergen Gross
On 16.02.22 13:10, Luca Fancellu wrote: On 16 Feb 2022, at 02:45, Stefano Stabellini wrote: On Tue, 15 Feb 2022, Luca Fancellu wrote: Introduce an architecture specific way to create different cpupools at boot time, this is particularly useful on ARM big.LITTLE system where there might be t

Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time

2022-02-16 Thread Luca Fancellu
> On 16 Feb 2022, at 06:18, Juergen Gross wrote: > > On 15.02.22 18:56, Luca Fancellu wrote: >>> On 15 Feb 2022, at 10:48, Juergen Gross wrote: >>> >>> On 15.02.22 11:15, Luca Fancellu wrote: Introduce an architecture specific way to create different cpupools at boot time, this is

Re: [PATCH v6 00/21] Introduce power-off+restart call chain API

2022-02-16 Thread Rafael J. Wysocki
On Tue, Feb 15, 2022 at 11:00 PM Dmitry Osipenko wrote: > > 31.01.2022 02:36, Dmitry Osipenko пишет: > > Problem > > --- > > > > SoC devices require power-off call chaining functionality from kernel. > > We have a widely used restart chaining provided by restart notifier API, > > but nothing f

Re: [PATCH v2] lib: extend ASSERT()

2022-02-16 Thread George Dunlap
> On Feb 16, 2022, at 11:42 AM, Jan Beulich wrote: > > On 16.02.2022 12:34, George Dunlap wrote: > >> I am opposed to overloading “ASSERT” for this new kind of macro; I think it >> would not only be unnecessarily confusing to people not familiar with our >> codebase, but it would be too easy

Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time

2022-02-16 Thread Luca Fancellu
> On 16 Feb 2022, at 02:45, Stefano Stabellini wrote: > > On Tue, 15 Feb 2022, Luca Fancellu wrote: >> Introduce an architecture specific way to create different cpupools >> at boot time, this is particularly useful on ARM big.LITTLE system >> where there might be the need to have different cp

Re: [PATCH v2 02/70] xen/sort: Switch to an extern inline implementation

2022-02-16 Thread Bertrand Marquis
Hi, > On 16 Feb 2022, at 11:46, Julien Grall wrote: > > Hi, > > On 16/02/2022 10:44, Andrew Cooper wrote: >> On 16/02/2022 03:46, Stefano Stabellini wrote: >>> On Mon, 14 Feb 2022, Julien Grall wrote: On 14/02/2022 12:50, Andrew Cooper wrote: > There are exactly 3 callers of sort() in

Re: [PATCH v2 07/70] x86: Build check for embedded endbr64 instructions

2022-02-16 Thread Andrew Cooper
On 16/02/2022 08:41, Jan Beulich wrote: >>> Any zero-padding inserted anywhere by the linker can >>> result in an immediately following ENDBR to be missed (because >>> sequences of zeros resemble 2-byte insns). >> I'm not sure this is a problem.  This pass is looking for everything >> that objdump

[ovmf test] 168127: all pass - PUSHED

2022-02-16 Thread osstest service owner
flight 168127 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168127/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf c28e376edc46e6db6e4a551c94b6ac90df0d8d6e baseline version: ovmf 85589ddbf6f8c6dc75f73

Re: [PATCH v2 02/70] xen/sort: Switch to an extern inline implementation

2022-02-16 Thread Julien Grall
Hi, On 16/02/2022 10:44, Andrew Cooper wrote: On 16/02/2022 03:46, Stefano Stabellini wrote: On Mon, 14 Feb 2022, Julien Grall wrote: On 14/02/2022 12:50, Andrew Cooper wrote: There are exactly 3 callers of sort() in the hypervisor. Callbacks in a tight loop like this are problematic for per

Re: [PATCH v2] lib: extend ASSERT()

2022-02-16 Thread Jan Beulich
On 16.02.2022 12:34, George Dunlap wrote: >> On Feb 16, 2022, at 9:31 AM, Jan Beulich wrote: >> On 16.02.2022 10:25, Bertrand Marquis wrote: On 15 Feb 2022, at 21:00, Julien Grall wrote: On 27/01/2022 14:34, Jan Beulich wrote: > The increasing amount of constructs along the lines of

Re: [PATCH v2] lib: extend ASSERT()

2022-02-16 Thread George Dunlap
> On Feb 16, 2022, at 9:31 AM, Jan Beulich wrote: > > On 16.02.2022 10:25, Bertrand Marquis wrote: >> Hi Jan, Julien, >> >>> On 15 Feb 2022, at 21:00, Julien Grall wrote: >>> >>> (+ Bertrand) >>> >>> Hi Jan, >>> >>> On 27/01/2022 14:34, Jan Beulich wrote: The increasing amount of cons

Re: [PATCH v2 RFC 4/5] x86/ioreq: report extended destination ID support by emulators

2022-02-16 Thread Roger Pau Monné
On Wed, Feb 16, 2022 at 10:53:58AM +, Durrant, Paul wrote: > On 16/02/2022 10:30, Roger Pau Monne wrote: > > Introduce a new arch specific field to report whether an emulator > > supports the Extended Destination ID field, so that the hypervisor can > > refrain from exposing the feature if one

Re: [PATCH 2/3] x86/clang: add retpoline support

2022-02-16 Thread Roger Pau Monné
On Wed, Feb 16, 2022 at 10:47:52AM +0100, Jan Beulich wrote: > On 16.02.2022 10:02, Roger Pau Monne wrote: > > Detect whether the compiler supports clang retpoline option and enable > > by default if available, just like it's done for gcc. > > > > Note clang already disables jump tables when retpo

[xen-unstable test] 168124: tolerable FAIL

2022-02-16 Thread osstest service owner
flight 168124 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/168124/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-thunderx 8 xen-boot fail in 168118 pass in 168124 test-amd64-i386-qemuu-rhel6hvm-a

Re: [PATCH v2 RFC 4/5] x86/ioreq: report extended destination ID support by emulators

2022-02-16 Thread Durrant, Paul
On 16/02/2022 10:30, Roger Pau Monne wrote: Introduce a new arch specific field to report whether an emulator supports the Extended Destination ID field, so that the hypervisor can refrain from exposing the feature if one of the emulators doesn't support it. Signed-off-by: Roger Pau Monné --- C

Re: [PATCH v2 02/70] xen/sort: Switch to an extern inline implementation

2022-02-16 Thread Andrew Cooper
On 16/02/2022 03:46, Stefano Stabellini wrote: > On Mon, 14 Feb 2022, Julien Grall wrote: >> On 14/02/2022 12:50, Andrew Cooper wrote: >>> There are exactly 3 callers of sort() in the hypervisor. Callbacks in a >>> tight >>> loop like this are problematic for performance, especially with Spectre v

[PATCH v2 1/5] x86/cpuid: add CPUID flag for Extended Destination ID support

2022-02-16 Thread Roger Pau Monne
Introduce the CPUID flag to be used in order to signal the support for using an extended destination ID in IO-APIC RTEs and MSI address fields. Such format expands the maximum target APIC ID from 255 to 32768 without requiring the usage of interrupt remapping. The design document describing the fe

[PATCH v2 RFC 4/5] x86/ioreq: report extended destination ID support by emulators

2022-02-16 Thread Roger Pau Monne
Introduce a new arch specific field to report whether an emulator supports the Extended Destination ID field, so that the hypervisor can refrain from exposing the feature if one of the emulators doesn't support it. Signed-off-by: Roger Pau Monné --- Changes since v1: - New in this version. --- R

[PATCH v2 5/5] x86/cpuid: expose EXT_DEST_ID feature if supported

2022-02-16 Thread Roger Pau Monne
Expose the feature if available for the domain. Signed-off-by: Roger Pau Monné --- Note: con not be committed ahead of the rest of the series. --- Changes since v1: - New in this version (split from previous patch). --- xen/arch/x86/traps.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a

[PATCH v2 3/5] x86/vmsi: add support for extended destination ID in address field

2022-02-16 Thread Roger Pau Monne
Both QEMU/KVM and HyperV support using bits 11:5 from the MSI address field in order to store the high part of the target APIC ID. This allows expanding the maximum APIC ID usable without interrupt remapping support from 255 to 32768. Note the interface used by QEMU for emulated devices (via the X

[PATCH v2 2/5] xen/vioapic: add support for the extended destination ID field

2022-02-16 Thread Roger Pau Monne
Such field uses bits 55:48, but for the purposes the register will be used use bits 55:49 instead. Bit 48 is used to signal an RTE entry is in remappable format which is not supported by the vIO-APIC. Use the extended destination ID to store the high bits from the destination ID, thus expanding th

[PATCH v2 0/5] x86: extended destination ID support

2022-02-16 Thread Roger Pau Monne
Hello, The following series provide a tentative implementation of extended destination ID support for HVM/PVH guests. A specification for the feature can be found at: http://david.woodhou.se/15-bit-msi.pdf Patch 4 is the one I'm having more doubts about: it's the best thing I could come up in or

[xen-unstable-coverity test] 168128: all pass - PUSHED

2022-02-16 Thread osstest service owner
flight 168128 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/168128/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen e7c2017cf4a91ab6a0fea6adca2d9dd2ab1603b0 baseline version: xen 8731

Re: [PATCH 2/3] x86/clang: add retpoline support

2022-02-16 Thread Jan Beulich
On 16.02.2022 10:02, Roger Pau Monne wrote: > Detect whether the compiler supports clang retpoline option and enable > by default if available, just like it's done for gcc. > > Note clang already disables jump tables when retpoline is enabled, so > there's no need to also pass the fno-jump-tables

Re: [PATCH v2] lib: extend ASSERT()

2022-02-16 Thread Bertrand Marquis
Hi Jan, > On 16 Feb 2022, at 09:31, Jan Beulich wrote: > > On 16.02.2022 10:25, Bertrand Marquis wrote: >> Hi Jan, Julien, >> >>> On 15 Feb 2022, at 21:00, Julien Grall wrote: >>> >>> (+ Bertrand) >>> >>> Hi Jan, >>> >>> On 27/01/2022 14:34, Jan Beulich wrote: The increasing amount of

Re: [PATCH 1/3] x86/retpoline: rename retpoline Kconfig check to include GCC prefix

2022-02-16 Thread Jan Beulich
On 16.02.2022 10:02, Roger Pau Monne wrote: > Current retpoline checks apply to GCC only, so make it obvious by > prefixing the Kconfig option with GCC. Keep the previous option as a > way to signal generic retpoline support regardless of the underlying > compiler. > > No functional change intende

[libvirt test] 168125: regressions - FAIL

2022-02-16 Thread osstest service owner
flight 168125 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/168125/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

Re: [PATCH v6 02/11] xen: introduce CDF_directmap

2022-02-16 Thread Jan Beulich
On 15.02.2022 21:26, Julien Grall wrote: > (+ Jan) > > Hi Penny, > > I am CCing Jan to give him a chance to... Thanks, but ... > On 14/02/2022 03:19, Penny Zheng wrote: >> diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h >> index cfb0b47f13..24eb4cc7d3 100644 >> --- a/xen/includ

Re: [PATCH v2] lib: extend ASSERT()

2022-02-16 Thread Jan Beulich
On 16.02.2022 10:25, Bertrand Marquis wrote: > Hi Jan, Julien, > >> On 15 Feb 2022, at 21:00, Julien Grall wrote: >> >> (+ Bertrand) >> >> Hi Jan, >> >> On 27/01/2022 14:34, Jan Beulich wrote: >>> The increasing amount of constructs along the lines of >>> if ( !condition ) >>> { >>>

Re: [PATCH v2 2/2] xen/include/public: deprecate GNTTABOP_transfer

2022-02-16 Thread Jan Beulich
On 16.02.2022 08:20, Juergen Gross wrote: > On 15.02.22 22:13, Julien Grall wrote: >> As a side note, should we also update SUPPORT.md? > > Good question. I'm not sure here either - talking about individual hypercall sub-ops seems overly small granularity to me for this kind of doc. Plus I don't

Re: [PATCH v2 02/70] xen/sort: Switch to an extern inline implementation

2022-02-16 Thread Bertrand Marquis
Hi Stefano, > On 16 Feb 2022, at 03:46, Stefano Stabellini wrote: > > On Mon, 14 Feb 2022, Julien Grall wrote: >> On 14/02/2022 12:50, Andrew Cooper wrote: >>> There are exactly 3 callers of sort() in the hypervisor. Callbacks in a >>> tight >>> loop like this are problematic for performance, e

Re: [PATCH v2] lib: extend ASSERT()

2022-02-16 Thread Bertrand Marquis
Hi Jan, Julien, > On 15 Feb 2022, at 21:00, Julien Grall wrote: > > (+ Bertrand) > > Hi Jan, > > On 27/01/2022 14:34, Jan Beulich wrote: >> The increasing amount of constructs along the lines of >> if ( !condition ) >> { >> ASSERT_UNREACHABLE(); >> return; >> } >> i

Re: [PATCH v2 69/70] x86/efi: Disable CET-IBT around Runtime Services calls

2022-02-16 Thread Jan Beulich
On 16.02.2022 00:00, Andrew Cooper wrote: > On 15/02/2022 16:53, Jan Beulich wrote: >> On 14.02.2022 13:51, Andrew Cooper wrote: >>> --- a/xen/common/efi/runtime.c >>> +++ b/xen/common/efi/runtime.c >>> @@ -21,6 +21,7 @@ struct efi_rs_state { >>>* don't strictly need that. >>>*/ >>> unsig

Re: [PATCH v2] tools/libxl: don't allow IOMMU usage with PoD

2022-02-16 Thread Roger Pau Monné
On Tue, Feb 15, 2022 at 03:08:21PM +, Anthony PERARD wrote: > On Thu, Feb 03, 2022 at 03:32:11PM +0100, Roger Pau Monne wrote: > > if (d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV && > > -d_config->num_pcidevs && pod_enabled) { > > +d_config->c_info.passthrough != LIBXL_PA

[PATCH 0/3] retpoline: add clang support + Kconfig selectable

2022-02-16 Thread Roger Pau Monne
Hello, The following series adds retpoline support for clang builds, and also allows the user to select whether to enable retpoline support at build time via a new Kconfig option. I've tried adding a suitable description to the Kconfig option, but I'm sure there's room for improvement. Thanks, R

[PATCH 3/3] x86/Kconfig: introduce option to select retpoline usage

2022-02-16 Thread Roger Pau Monne
Add a new Kconfig option under the "Speculative hardening" section that allows selecting whether to enable retpoline. This depends on the underlying compiler having retpoline support. Requested-by: Andrew Cooper Signed-off-by: Roger Pau Monné --- xen/arch/x86/Kconfig | 4 xen/arch/x86/arc

[PATCH 2/3] x86/clang: add retpoline support

2022-02-16 Thread Roger Pau Monne
Detect whether the compiler supports clang retpoline option and enable by default if available, just like it's done for gcc. Note clang already disables jump tables when retpoline is enabled, so there's no need to also pass the fno-jump-tables parameter. Reported-by: Jan Beulich Signed-off-by: R

[PATCH 1/3] x86/retpoline: rename retpoline Kconfig check to include GCC prefix

2022-02-16 Thread Roger Pau Monne
Current retpoline checks apply to GCC only, so make it obvious by prefixing the Kconfig option with GCC. Keep the previous option as a way to signal generic retpoline support regardless of the underlying compiler. No functional change intended. Signed-off-by: Roger Pau Monné --- xen/arch/x86/Kc

Re: [PATCH v2 68/70] x86/setup: Rework MSR_S_CET handling for CET-IBT

2022-02-16 Thread Jan Beulich
On 15.02.2022 21:58, Andrew Cooper wrote: > On 15/02/2022 16:46, Jan Beulich wrote: >> On 14.02.2022 13:51, Andrew Cooper wrote: >>> CET-SS and CET-IBT can be independently controlled, so the configuration of >>> MSR_S_CET can't be constant any more. >>> >>> Introduce xen_msr_s_cet_value(), mostly

Re: [PATCH v2 07/70] x86: Build check for embedded endbr64 instructions

2022-02-16 Thread Jan Beulich
On 15.02.2022 18:52, Andrew Cooper wrote: > On 15/02/2022 15:12, Jan Beulich wrote: >> On 14.02.2022 13:50, Andrew Cooper wrote: >>> --- /dev/null >>> +++ b/xen/tools/check-endbr.sh >>> @@ -0,0 +1,76 @@ >>> +#!/bin/sh >>> + >>> +# >>> +# Usage ./$0 xen-syms >>> +# >>> + >>> +set -e >>> + >>> +OBJCO

Re: [PATCH 1/5] tools/cpupools: Give a name to unnamed cpupools

2022-02-16 Thread Luca Fancellu
> On 16 Feb 2022, at 06:13, Juergen Gross wrote: > > On 15.02.22 18:48, Luca Fancellu wrote: >>> On 15 Feb 2022, at 10:33, Juergen Gross wrote: >>> >>> On 15.02.22 11:15, Luca Fancellu wrote: With the introduction of boot time cpupools, Xen can create many different cpupools at boo