Re: IGD pass-through failures since 4.10.

2022-02-17 Thread Jan Beulich
On 17.02.2022 21:15, Dr. Greg wrote: > On Mon, Feb 14, 2022 at 09:56:34AM +0100, Jan Beulich wrote: >> On 14.02.2022 07:00, Dr. Greg wrote: >>> It appears to be a problem with mapping interrupts back to dom0 given >>> that we see the following: >>> >>> Feb 10 08:16:05 hostname kernel: xhci_hcd

RE: [PATCH v2 4/4] IOMMU/PCI: propagate get_device_group_id() failure

2022-02-17 Thread Tian, Kevin
> From: Jan Beulich > Sent: Thursday, January 27, 2022 10:50 PM > > The VT-d hook can indicate an error, which shouldn't be ignored. Convert > the hook's return value to a proper error code, and let that bubble up. > > Signed-off-by: Jan Beulich > --- > I'm not convinced of the XSM related beha

RE: [PATCH v2 3/4] VT-d: replace flush_all_cache()

2022-02-17 Thread Tian, Kevin
> From: Jan Beulich > Sent: Thursday, January 27, 2022 10:49 PM > > Let's use infrastructure we have available instead of an open-coded > wbinvd() invocation. > > Signed-off-by: Jan Beulich Reviewed-by: Kevin Tian > > --- a/xen/drivers/passthrough/vtd/extern.h > +++ b/xen/drivers/passthrough

RE: [PATCH v2 2/4] VT-d / x86: re-arrange cache syncing

2022-02-17 Thread Tian, Kevin
> From: Jan Beulich > Sent: Thursday, January 27, 2022 10:48 PM > > The actual function should always have lived in core x86 code; move it > there, replacing get_cache_line_size() by readily available (except very > early during boot; see the code comment) data. Also rename the function. > > Dro

RE: [PATCH] x86/hvm: Drop get_shadow_gs_base() hook and use hvm_get_reg()

2022-02-17 Thread Tian, Kevin
> From: Andrew Cooper > Sent: Friday, January 21, 2022 7:23 PM > > This is a trivial accessor for an MSR, so use hvm_get_reg() rather than a > dedicated hook. In arch_get_info_guest(), rework the logic to read > GS_SHADOW > only once. > > get_hvm_registers() is called on current, meaning that d

RE: [PATCH v3 23/23] IOMMU/x86: add perf counters for page table splitting / coalescing

2022-02-17 Thread Tian, Kevin
> From: Jan Beulich > Sent: Tuesday, January 11, 2022 12:39 AM > > Signed-off-by: Jan Beulich Reviewed-by: Kevin tian > --- > v3: New. > > --- a/xen/drivers/passthrough/amd/iommu_map.c > +++ b/xen/drivers/passthrough/amd/iommu_map.c > @@ -283,6 +283,8 @@ static int iommu_pde_from_dfn(struct

RE: [PATCH v3 22/23] VT-d: replace all-contiguous page tables by superpage mappings

2022-02-17 Thread Tian, Kevin
> From: Jan Beulich > Sent: Tuesday, January 11, 2022 12:38 AM > > When a page table ends up with all contiguous entries (including all > identical attributes), it can be replaced by a superpage entry at the > next higher level. The page table itself can then be scheduled for > freeing. > > The

RE: [PATCH v3 20/23] VT-d: free all-empty page tables

2022-02-17 Thread Tian, Kevin
> From: Jan Beulich > Sent: Tuesday, January 11, 2022 12:36 AM > > When a page table ends up with no present entries left, it can be > replaced by a non-present entry at the next higher level. The page table > itself can then be scheduled for freeing. > > Note that while its output isn't used th

Re: [PATCH v2 2/2] xen/include/public: deprecate GNTTABOP_transfer

2022-02-17 Thread Juergen Gross
On 17.02.22 20:55, Julien Grall wrote: Hi, On 16/02/2022 07:20, Juergen Gross wrote: On 15.02.22 22:13, Julien Grall wrote: Hi Juergen, On 03/02/2022 13:14, Juergen Gross wrote: Add a comment to include/public/grant_table.h that GNTTABOP_transfer is deprecated, in order to discourage new use

RE: [PATCH v3 17/23] IOMMU/x86: prefill newly allocate page tables

2022-02-17 Thread Tian, Kevin
> From: Jan Beulich > Sent: Tuesday, January 11, 2022 12:35 AM > > Page tables are used for two purposes after allocation: They either > start out all empty, or they get filled to replace a superpage. > Subsequently, to replace all empty or fully contiguous page tables, > contiguous sub-regions w

[linux-linus test] 168156: tolerable FAIL - PUSHED

2022-02-17 Thread osstest service owner
flight 168156 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/168156/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 168154 test-amd64-amd64-qemuu-nested-amd 20

[xen-unstable-smoke test] 168155: tolerable all pass - PUSHED

2022-02-17 Thread osstest service owner
flight 168155 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/168155/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: Metadata and signalling channels for Zephyr virtio-backends on Xen

2022-02-17 Thread Stefano Stabellini
Hi Vincent, I am replying to this thread to follow-up on this morning's discussion. I am attaching the simple patch that I mentioned during the call to add event channels support to guest kernels, see xen.h. I am also attaching a toy example application that makes use of it, just to give you an

[linux-linus test] 168154: tolerable FAIL - PUSHED

2022-02-17 Thread osstest service owner
flight 168154 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/168154/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail like 168144 test-amd64-amd64-xl-qemut-win7-amd64

Re: IGD pass-through failures since 4.10.

2022-02-17 Thread Dr. Greg
On Mon, Feb 14, 2022 at 09:56:34AM +0100, Jan Beulich wrote: Good morning, I hope the day is starting well for everyone, Jan thanks for taking the time to reply. > On 14.02.2022 07:00, Dr. Greg wrote: > > It appears to be a problem with mapping interrupts back to dom0 given > > that we see the f

Re: [PATCH v2 2/2] xen/include/public: deprecate GNTTABOP_transfer

2022-02-17 Thread Julien Grall
Hi, On 16/02/2022 07:20, Juergen Gross wrote: On 15.02.22 22:13, Julien Grall wrote: Hi Juergen, On 03/02/2022 13:14, Juergen Gross wrote: Add a comment to include/public/grant_table.h that GNTTABOP_transfer is deprecated, in order to discourage new use cases.  From the commit message, it i

Re: [PATCH v6 02/11] xen: introduce CDF_directmap

2022-02-17 Thread Julien Grall
Hi, On 17/02/2022 11:01, Julien Grall wrote: On 16/02/2022 09:34, Jan Beulich wrote: On 15.02.2022 21:26, Julien Grall wrote: (+ Jan) Hi Penny, I am CCing Jan to give him a chance to... Thanks, but ... On 14/02/2022 03:19, Penny Zheng wrote: diff --git a/xen/include/xen/domain.h b/xen/i

Re: [PATCH v2] docs: add some clarification to xenstore-migration.md

2022-02-17 Thread Julien Grall
Hi Juergen, On 17/02/2022 11:47, Juergen Gross wrote: The Xenstore migration document is missing the specification that a node record must be preceded by the record of its parent node in case of live update. The patch also cover normal migration. So I think you want to drop " in case of live up

Re: [XEN PATCH v9 30/30] build: adding out-of-tree support to the xen build

2022-02-17 Thread Julien Grall
Hi Anthony, On 25/01/2022 11:37, Anthony PERARD wrote: On Tue, Jan 25, 2022 at 11:01:03AM +, Anthony PERARD wrote: This implement out-of-tree support, there's two ways to create an out-of-tree build tree (after that, `make` in that new directory works): make O=build mkdir build; c

Re: [XEN PATCH v9 20/30] build: rework "clean" to clean from the root dir

2022-02-17 Thread Julien Grall
Hi Anthony, On 25/01/2022 11:00, Anthony PERARD wrote: This will allow "clean" to work from an out-of-tree build when it will be available. Some of the file been removed in current "clean" target aren't added to $(clean-files) because they are already listed in $(extra-) or $(extra-y). Also st

Re: [XEN PATCH v9 04/30] build: set ALL_OBJS in main Makefile; move prelink.o to main Makefile

2022-02-17 Thread Julien Grall
Hi Anthony, On 25/01/2022 11:00, Anthony PERARD wrote: This is to avoid arch/$arch/Makefile having to recurse into parents directories. This avoid duplication of the logic to build prelink.o between arches. In order to do that, we cut the $(TARGET) target in the main Makefile in two, there is

Re: [XEN PATCH v9 04/30] build: set ALL_OBJS in main Makefile; move prelink.o to main Makefile

2022-02-17 Thread Julien Grall
Hi, On 17/02/2022 16:29, Julien Grall wrote: On 28/01/2022 11:41, Jan Beulich wrote: On 28.01.2022 12:32, Anthony PERARD wrote: On Thu, Jan 27, 2022 at 04:50:32PM +0100, Jan Beulich wrote: On 25.01.2022 12:00, Anthony PERARD wrote: --- a/xen/Makefile +++ b/xen/Makefile @@ -285,6 +285,16 @@ C

[xen-unstable test] 168145: tolerable FAIL

2022-02-17 Thread osstest service owner
flight 168145 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/168145/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 168129 pass in 168145 test-arm64-arm64-examine

[PATCH v2] MAINTAINERS: update TXT section

2022-02-17 Thread Jan Beulich
Since Lukasz has left Intel, they have suggested a replacement contact. Signed-off-by: Jan Beulich --- v2: Only add Mateusz, and only as reviewer. --- a/MAINTAINERS +++ b/MAINTAINERS @@ -318,6 +318,7 @@ F: xen/common/hypfs.c INTEL(R) TRUSTED EXECUTION TECHNOLOGY (TXT) R: Lukasz Hawrylko

Re: [XEN PATCH v9 04/30] build: set ALL_OBJS in main Makefile; move prelink.o to main Makefile

2022-02-17 Thread Julien Grall
Hi, On 28/01/2022 11:41, Jan Beulich wrote: On 28.01.2022 12:32, Anthony PERARD wrote: On Thu, Jan 27, 2022 at 04:50:32PM +0100, Jan Beulich wrote: On 25.01.2022 12:00, Anthony PERARD wrote: --- a/xen/Makefile +++ b/xen/Makefile @@ -285,6 +285,16 @@ CFLAGS += -flto LDFLAGS-$(CONFIG_CC_IS_CL

Re: [PATCH v2.1 6.5/70] x86/kexec: Annotate embedded data with ELF metadata

2022-02-17 Thread Jan Beulich
On 17.02.2022 17:06, Andrew Cooper wrote: > On 17/02/2022 14:48, Jan Beulich wrote: >> On 17.02.2022 13:06, Andrew Cooper wrote: >>> On 17/02/2022 10:42, Jan Beulich wrote: On 17.02.2022 11:01, Andrew Cooper wrote: > --- a/xen/arch/x86/xen.lds.S > +++ b/xen/arch/x86/xen.lds.S > @@

Potential dates for XenSummit

2022-02-17 Thread George Dunlap
I’m looking for input for dates of the XenSummit. At the moment, we’re looking at three options: 1. The week of 25 July. This conflicts with SCALE. 2. The week of 1 August. There are a handful of minor public holidays; but worse this is in August, when much of Europe is on holiday. 3. The w

Outreachy, and the Outreach Program Projects wiki page

2022-02-17 Thread George Dunlap
Hey all, Sorry this is a bit late; the deadline for organizations to sign up for the upcoming Outreachy round is 25 February; and the deadline for mentors to submit projects is 4 March. It’s not 100% clear, but it looks like prospective mentors will need to individually submit their projects.

Re: [PATCH v2.1 6.5/70] x86/kexec: Annotate embedded data with ELF metadata

2022-02-17 Thread Andrew Cooper
On 17/02/2022 14:48, Jan Beulich wrote: > On 17.02.2022 13:06, Andrew Cooper wrote: >> On 17/02/2022 10:42, Jan Beulich wrote: >>> On 17.02.2022 11:01, Andrew Cooper wrote: Scanning for embedded endbranch instructions involves parsing the .text disassembly. Data in the kexec trampoline h

Ping: [XEN PATCH v9 04/30] build: set ALL_OBJS in main Makefile; move prelink.o to main Makefile

2022-02-17 Thread Anthony PERARD
Hi Julien, Stefano, This patch has some changes to the Arm makefiles. Could you have a quick look or ack the changes? They are some other patches in the series which might want a Arm ack: - 20/30 build: rework "clean" to clean from the root dir - 24/30 build: grab common EFI source files in arch

Re: [PATCH RESEND v2] x86: introduce ioremap_wc()

2022-02-17 Thread Jan Beulich
On 17.02.2022 16:50, Roger Pau Monné wrote: > On Thu, Feb 17, 2022 at 04:02:39PM +0100, Jan Beulich wrote: >> On 17.02.2022 15:47, Roger Pau Monné wrote: >>> On Thu, Feb 17, 2022 at 12:01:08PM +0100, Jan Beulich wrote: --- a/xen/drivers/video/vga.c +++ b/xen/drivers/video/vga.c @@ -7

Re: [PATCH RESEND v2] x86: introduce ioremap_wc()

2022-02-17 Thread Roger Pau Monné
On Thu, Feb 17, 2022 at 04:02:39PM +0100, Jan Beulich wrote: > On 17.02.2022 15:47, Roger Pau Monné wrote: > > On Thu, Feb 17, 2022 at 12:01:08PM +0100, Jan Beulich wrote: > >> @@ -179,8 +179,7 @@ void __init vesa_mtrr_init(void) > >> > >> static void lfb_flush(void) > >> { > >> -if ( vesa_

Ping: [XEN PATCH v9 06/30] build: rework test/livepatch/Makefile

2022-02-17 Thread Anthony PERARD
Hi Ross, Konrad, Could you ack or review this patch? There is also a few other patches in this series that make some changes to "xen/test/livepatch/Makefile", an ack for those would be nice as well: - 09/30 build: build everything from the root dir, use obj=$subdir - 19/30 build: clean-up "clean

Re: [RFC v2 6/8] tools/arm: Introduce force_assign_without_iommu option to xl.cfg

2022-02-17 Thread Julien Grall
Hi, On 08/02/2022 18:00, Oleksii Moisieiev wrote: If set, Xen is allowed to assign the devices even if they are not under IOMMU. I think you mean "not protected by an IOMMU". Can be confugired from dom.cfg in the following format: s/confugired/configured/ force_assign_without_iommu = 1

Re: [PATCH RESEND v2] x86: introduce ioremap_wc()

2022-02-17 Thread Jan Beulich
On 17.02.2022 15:47, Roger Pau Monné wrote: > On Thu, Feb 17, 2022 at 12:01:08PM +0100, Jan Beulich wrote: >> @@ -179,8 +179,7 @@ void __init vesa_mtrr_init(void) >> >> static void lfb_flush(void) >> { >> -if ( vesa_mtrr == 3 ) >> -__asm__ __volatile__ ("sfence" : : : "memory"); >>

Re: [RFC v2 6/8] tools/arm: Introduce force_assign_without_iommu option to xl.cfg

2022-02-17 Thread Anthony PERARD
On Tue, Feb 08, 2022 at 06:00:12PM +, Oleksii Moisieiev wrote: > If set, Xen is allowed to assign the devices even if they are not under > IOMMU. > Can be confugired from dom.cfg in the following format: > force_assign_without_iommu = 1 > > This parameter has the same purpose as xen,force-assi

Re: [PATCH v2.1 6.5/70] x86/kexec: Annotate embedded data with ELF metadata

2022-02-17 Thread Jan Beulich
On 17.02.2022 13:06, Andrew Cooper wrote: > On 17/02/2022 10:42, Jan Beulich wrote: >> On 17.02.2022 11:01, Andrew Cooper wrote: >>> Scanning for embedded endbranch instructions involves parsing the .text >>> disassembly. Data in the kexec trampoline has no ELF metadata, so objdump >>> treats it a

Re: [PATCH RESEND v2] x86: introduce ioremap_wc()

2022-02-17 Thread Roger Pau Monné
On Thu, Feb 17, 2022 at 12:01:08PM +0100, Jan Beulich wrote: > In order for a to-be-introduced ERMS form of memcpy() to not regress > boot performance on certain systems when video output is active, we > first need to arrange for avoiding further dependency on firmware > setting up MTRRs in a way w

Re: [PATCH] x86/console: process softirqs between warning prints

2022-02-17 Thread Jan Beulich
On 17.02.2022 13:07, Roger Pau Monné wrote: > On Thu, Feb 17, 2022 at 12:54:57PM +0100, Jan Beulich wrote: >> On 17.02.2022 09:28, Roger Pau Monne wrote: >>> Process softirqs while printing end of boot warnings. Each warning can >>> be several lines long, and on slow consoles printing multiple ones

[PATCH v3] tools/libxl: don't allow IOMMU usage with PoD

2022-02-17 Thread Roger Pau Monne
Prevent libxl from creating guests that attempts to use PoD together with an IOMMU, even if no devices are actually assigned. While the hypervisor could support using PoD together with an IOMMU as long as no devices are assigned, such usage seems doubtful. There's no guarantee the guest has PoD no

[linux-linus test] 168144: tolerable FAIL - PUSHED

2022-02-17 Thread osstest service owner
flight 168144 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/168144/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail like 168126 test-amd64-amd64-xl-qemut-win7-amd64

Re: Metadata and signalling channels for Zephyr virtio-backends on Xen

2022-02-17 Thread Vincent Guittot
On Wed, 16 Feb 2022 at 22:45, Stefano Stabellini wrote: > > On Tue, 15 Feb 2022, Vincent Guittot wrote: > > On Tue, 8 Feb 2022 at 01:16, Stefano Stabellini > > wrote: > > > > > > On Mon, 7 Feb 2022, Alex Bennée wrote: > > > > Hi Stefano, > > > > > > > > Vincent gave an update on his virtio-scmi w

[libvirt test] 168146: regressions - FAIL

2022-02-17 Thread osstest service owner
flight 168146 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/168146/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

[qemu-mainline test] 168139: tolerable FAIL - PUSHED

2022-02-17 Thread osstest service owner
flight 168139 qemu-mainline real [real] flight 168153 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/168139/ http://logs.test-lab.xenproject.org/osstest/logs/168153/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-ar

Re: [PATCH] x86/console: process softirqs between warning prints

2022-02-17 Thread Roger Pau Monné
On Thu, Feb 17, 2022 at 12:54:57PM +0100, Jan Beulich wrote: > On 17.02.2022 09:28, Roger Pau Monne wrote: > > Process softirqs while printing end of boot warnings. Each warning can > > be several lines long, and on slow consoles printing multiple ones > > without processing softirqs can result in

Re: [PATCH v2.1 6.5/70] x86/kexec: Annotate embedded data with ELF metadata

2022-02-17 Thread Andrew Cooper
On 17/02/2022 10:42, Jan Beulich wrote: > On 17.02.2022 11:01, Andrew Cooper wrote: >> Scanning for embedded endbranch instructions involves parsing the .text >> disassembly. Data in the kexec trampoline has no ELF metadata, so objdump >> treats it as instructions and tries to disassemble. Conver

Re: [PATCH v2] tools/xenstore: add error indicator to ring page

2022-02-17 Thread Anthony PERARD
On Thu, Feb 17, 2022 at 12:30:16PM +0100, Juergen Gross wrote: > In case Xenstore is detecting a malicious ring page modification (e.g. > an invalid producer or consumer index set by a guest) it will ignore > the connection of that guest in future. > > Add a new error field to the ring page indica

Re: [PATCH v2] tools: remove xenstore entries on vchan server closure

2022-02-17 Thread Anthony PERARD
Hi Oleksandr, On Wed, Feb 16, 2022 at 08:33:25AM +0200, Oleksandr Andrushchenko wrote: > diff --git a/tools/libs/vchan/init.c b/tools/libs/vchan/init.c > index c8510e6ce98a..ae9a6b579753 100644 > --- a/tools/libs/vchan/init.c > +++ b/tools/libs/vchan/init.c > @@ -251,6 +253,12 @@ static int init_x

Re: [PATCH] x86/console: process softirqs between warning prints

2022-02-17 Thread Jan Beulich
On 17.02.2022 09:28, Roger Pau Monne wrote: > Process softirqs while printing end of boot warnings. Each warning can > be several lines long, and on slow consoles printing multiple ones > without processing softirqs can result in the watchdog triggering: > > (XEN) [ 22.277806] **

Re: [PATCH v2 34/70] x86/emul: CFI hardening

2022-02-17 Thread Jan Beulich
On 16.02.2022 22:34, Andrew Cooper wrote: > On 15/02/2022 14:13, Jan Beulich wrote: >> On 15.02.2022 14:43, Andrew Cooper wrote: >>> On 14/02/2022 13:38, Jan Beulich wrote: On 14.02.2022 13:50, Andrew Cooper wrote: > Control Flow Integrity schemes use toolchain and optionally hardware >>>

[PATCH v2] docs: add some clarification to xenstore-migration.md

2022-02-17 Thread Juergen Gross
The Xenstore migration document is missing the specification that a node record must be preceded by the record of its parent node in case of live update. Add that missing part. Signed-off-by: Juergen Gross --- V2: - rephrase to cover non-LU case, too (Julien Grall) --- docs/designs/xenstore-mig

Re: [PATCH v2 06/70] x86: Introduce support for CET-IBT

2022-02-17 Thread Jan Beulich
On 16.02.2022 22:54, Andrew Cooper wrote: > On 15/02/2022 14:01, Jan Beulich wrote: >> On 14.02.2022 13:50, Andrew Cooper wrote: >>> --- a/xen/arch/x86/Kconfig >>> +++ b/xen/arch/x86/Kconfig >>> @@ -39,6 +39,11 @@ config HAS_AS_CET_SS >>> # binutils >= 2.29 or LLVM >= 6 >>> def_bool $(as-in

[PATCH v2] tools/xenstore: add error indicator to ring page

2022-02-17 Thread Juergen Gross
In case Xenstore is detecting a malicious ring page modification (e.g. an invalid producer or consumer index set by a guest) it will ignore the connection of that guest in future. Add a new error field to the ring page indicating that case. Add a new feature bit in order to signal the presence of

Re: [PATCH v2 3/3] x86/Kconfig: introduce option to select retpoline usage

2022-02-17 Thread Jan Beulich
On 17.02.2022 11:34, Roger Pau Monné wrote: > On Thu, Feb 17, 2022 at 10:07:32AM +0100, Jan Beulich wrote: >> On 16.02.2022 17:21, Roger Pau Monne wrote: >>> Add a new Kconfig option under the "Speculative hardening" section >>> that allows selecting whether to enable retpoline. This depends on the

Re: [PATCH v2 1/3] x86/retpoline: rename retpoline Kconfig check to include GCC prefix

2022-02-17 Thread Jan Beulich
On 17.02.2022 11:37, Roger Pau Monné wrote: > On Thu, Feb 17, 2022 at 10:04:01AM +0100, Jan Beulich wrote: >> On 17.02.2022 09:59, Jan Beulich wrote: >>> On 16.02.2022 17:21, Roger Pau Monne wrote: Current retpoline checks apply to GCC only, so make it obvious by prefixing the Kconfig opt

Re: [PATCH v6 02/11] xen: introduce CDF_directmap

2022-02-17 Thread Julien Grall
Hi Jan, On 16/02/2022 09:34, Jan Beulich wrote: On 15.02.2022 21:26, Julien Grall wrote: (+ Jan) Hi Penny, I am CCing Jan to give him a chance to... Thanks, but ... On 14/02/2022 03:19, Penny Zheng wrote: diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h index cfb0b47f13..

[PATCH RESEND v2] x86: introduce ioremap_wc()

2022-02-17 Thread Jan Beulich
In order for a to-be-introduced ERMS form of memcpy() to not regress boot performance on certain systems when video output is active, we first need to arrange for avoiding further dependency on firmware setting up MTRRs in a way we can actually further modify. On many systems, due to the continuous

Re: [PATCH] tools/xenstore: add error indicator to ring page

2022-02-17 Thread Juergen Gross
On 17.02.22 11:56, Anthony PERARD wrote: On Tue, Feb 15, 2022 at 04:45:28PM +0100, Juergen Gross wrote: On 15.02.22 16:42, Anthony PERARD wrote: On Thu, Feb 10, 2022 at 12:16:20PM +0100, Juergen Gross wrote: +The "Connection error indicator" is used to let the server indicate it has +detected

Re: [PATCH v2] tools/libxl: don't allow IOMMU usage with PoD

2022-02-17 Thread Anthony PERARD
On Wed, Feb 16, 2022 at 10:12:03AM +0100, Roger Pau Monné wrote: > On Tue, Feb 15, 2022 at 03:08:21PM +, Anthony PERARD wrote: > > On Thu, Feb 03, 2022 at 03:32:11PM +0100, Roger Pau Monne wrote: > > > if (d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV && > > > -d_config->num_pcidev

Re: [PATCH] tools/xenstore: add error indicator to ring page

2022-02-17 Thread Anthony PERARD
On Tue, Feb 15, 2022 at 04:45:28PM +0100, Juergen Gross wrote: > On 15.02.22 16:42, Anthony PERARD wrote: > > On Thu, Feb 10, 2022 at 12:16:20PM +0100, Juergen Gross wrote: > > > +The "Connection error indicator" is used to let the server indicate it > > > has > > > +detected some error that led t

Re: [PATCH v2.1 6.5/70] x86/kexec: Annotate embedded data with ELF metadata

2022-02-17 Thread Jan Beulich
On 17.02.2022 11:01, Andrew Cooper wrote: > Scanning for embedded endbranch instructions involves parsing the .text > disassembly. Data in the kexec trampoline has no ELF metadata, so objdump > treats it as instructions and tries to disassemble. Convert: > > 82d040396108 : What about the

Re: [PATCH v2 1/3] x86/retpoline: rename retpoline Kconfig check to include GCC prefix

2022-02-17 Thread Roger Pau Monné
On Thu, Feb 17, 2022 at 10:04:01AM +0100, Jan Beulich wrote: > On 17.02.2022 09:59, Jan Beulich wrote: > > On 16.02.2022 17:21, Roger Pau Monne wrote: > >> Current retpoline checks apply to GCC only, so make it obvious by > >> prefixing the Kconfig option with GCC. Keep the previous option as a > >

Re: [PATCH v2 3/3] x86/Kconfig: introduce option to select retpoline usage

2022-02-17 Thread Roger Pau Monné
On Thu, Feb 17, 2022 at 10:07:32AM +0100, Jan Beulich wrote: > On 16.02.2022 17:21, Roger Pau Monne wrote: > > Add a new Kconfig option under the "Speculative hardening" section > > that allows selecting whether to enable retpoline. This depends on the > > underlying compiler having retpoline suppo

Re: [PATCH v2 04/70] x86/pv-shim: Don't modify the hypercall table

2022-02-17 Thread Juergen Gross
On 17.02.22 11:20, Jan Beulich wrote: On 16.02.2022 23:17, Andrew Cooper wrote: On 14/02/2022 13:56, Jan Beulich wrote: On 14.02.2022 14:50, Andrew Cooper wrote: On 14/02/2022 13:33, Jan Beulich wrote: On 14.02.2022 13:50, Andrew Cooper wrote: From: Juergen Gross When running as pv-shim th

Re: [PATCH v2 04/70] x86/pv-shim: Don't modify the hypercall table

2022-02-17 Thread Jan Beulich
On 16.02.2022 23:17, Andrew Cooper wrote: > On 14/02/2022 13:56, Jan Beulich wrote: >> On 14.02.2022 14:50, Andrew Cooper wrote: >>> On 14/02/2022 13:33, Jan Beulich wrote: On 14.02.2022 13:50, Andrew Cooper wrote: > From: Juergen Gross > > When running as pv-shim the hypercall is

Re: [PATCH v6 00/21] Introduce power-off+restart call chain API

2022-02-17 Thread Dmitry Osipenko
16.02.2022 23:30, Helge Deller пишет: > On 2/16/22 13:25, Rafael J. Wysocki wrote: >> On Tue, Feb 15, 2022 at 11:00 PM Dmitry Osipenko wrote: >>> >>> 31.01.2022 02:36, Dmitry Osipenko пишет: Problem --- SoC devices require power-off call chaining functionality from kernel.

[PATCH v2.1 6.5/70] x86/kexec: Annotate embedded data with ELF metadata

2022-02-17 Thread Andrew Cooper
Scanning for embedded endbranch instructions involves parsing the .text disassembly. Data in the kexec trampoline has no ELF metadata, so objdump treats it as instructions and tries to disassemble. Convert: 82d040396108 : 82d040396108: 00 00 add%al,(%rax)

Re: [PATCH v2 00/70] x86: Support for CET Indirect Branch Tracking

2022-02-17 Thread Jan Beulich
On 16.02.2022 22:59, Andrew Cooper wrote: > On 14/02/2022 14:38, Jan Beulich wrote: >> On 14.02.2022 15:15, Andrew Cooper wrote: >>> On 14/02/2022 13:43, Jan Beulich wrote: On 14.02.2022 14:10, Andrew Cooper wrote: > On 14/02/2022 12:50, Andrew Cooper wrote: >> CET Indirect Branch Trac

Re: [PATCH v2 1/5] x86/cpuid: add CPUID flag for Extended Destination ID support

2022-02-17 Thread Jan Beulich
On 17.02.2022 10:24, Roger Pau Monné wrote: > On Thu, Feb 17, 2022 at 09:52:51AM +0100, Jan Beulich wrote: >> On 16.02.2022 17:08, David Woodhouse wrote: >>> On Wed, 2022-02-16 at 16:43 +0100, Jan Beulich wrote: On 16.02.2022 11:30, Roger Pau Monne wrote: > --- a/xen/include/public/arch-x8

Re: [PATCH v2 1/5] x86/cpuid: add CPUID flag for Extended Destination ID support

2022-02-17 Thread Roger Pau Monné
On Thu, Feb 17, 2022 at 09:52:51AM +0100, Jan Beulich wrote: > On 16.02.2022 17:08, David Woodhouse wrote: > > On Wed, 2022-02-16 at 16:43 +0100, Jan Beulich wrote: > >> On 16.02.2022 11:30, Roger Pau Monne wrote: > >>> --- a/xen/include/public/arch-x86/cpuid.h > >>> +++ b/xen/include/public/arch-x

Re: [PATCH v2 3/3] x86/Kconfig: introduce option to select retpoline usage

2022-02-17 Thread Jan Beulich
On 16.02.2022 17:21, Roger Pau Monne wrote: > Add a new Kconfig option under the "Speculative hardening" section > that allows selecting whether to enable retpoline. This depends on the > underlying compiler having retpoline support. > > Requested-by: Andrew Cooper > Signed-off-by: Roger Pau Monn

[xen-4.15-testing test] 168135: tolerable FAIL - PUSHED

2022-02-17 Thread osstest service owner
flight 168135 xen-4.15-testing real [real] flight 168148 xen-4.15-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/168135/ http://logs.test-lab.xenproject.org/osstest/logs/168148/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): t

Re: [PATCH v2 1/3] x86/retpoline: rename retpoline Kconfig check to include GCC prefix

2022-02-17 Thread Jan Beulich
On 17.02.2022 09:59, Jan Beulich wrote: > On 16.02.2022 17:21, Roger Pau Monne wrote: >> Current retpoline checks apply to GCC only, so make it obvious by >> prefixing the Kconfig option with GCC. Keep the previous option as a >> way to signal generic retpoline support regardless of the underlying

Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time

2022-02-17 Thread Luca Fancellu
> On 16 Feb 2022, at 13:07, Juergen Gross wrote: > > On 16.02.22 14:01, Luca Fancellu wrote: >>> On 16 Feb 2022, at 12:55, Juergen Gross wrote: >>> >>> On 16.02.22 13:10, Luca Fancellu wrote: > On 16 Feb 2022, at 02:45, Stefano Stabellini > wrote: > > On Tue, 15 Feb 2022,

Re: [PATCH v2 1/3] x86/retpoline: rename retpoline Kconfig check to include GCC prefix

2022-02-17 Thread Jan Beulich
On 16.02.2022 17:21, Roger Pau Monne wrote: > Current retpoline checks apply to GCC only, so make it obvious by > prefixing the Kconfig option with GCC. Keep the previous option as a > way to signal generic retpoline support regardless of the underlying > compiler. > > No functional change intende

Re: [PATCH v2 1/5] x86/cpuid: add CPUID flag for Extended Destination ID support

2022-02-17 Thread Jan Beulich
On 16.02.2022 17:08, David Woodhouse wrote: > On Wed, 2022-02-16 at 16:43 +0100, Jan Beulich wrote: >> On 16.02.2022 11:30, Roger Pau Monne wrote: >>> --- a/xen/include/public/arch-x86/cpuid.h >>> +++ b/xen/include/public/arch-x86/cpuid.h >>> @@ -102,6 +102,12 @@ >>> #define XEN_HVM_CPUID_IOMMU_MA

[PATCH] x86/console: process softirqs between warning prints

2022-02-17 Thread Roger Pau Monne
Process softirqs while printing end of boot warnings. Each warning can be several lines long, and on slow consoles printing multiple ones without processing softirqs can result in the watchdog triggering: (XEN) [ 22.277806] *** (XEN) [ 22.417802]