Re: [PATCH v3 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC

2022-02-28 Thread Jan Beulich
On 28.02.2022 16:48, Roger Pau Monné wrote: > On Mon, Feb 28, 2022 at 02:14:26PM +0100, Jan Beulich wrote: >> On 28.02.2022 12:20, Roger Pau Monné wrote: >>> On Thu, Feb 24, 2022 at 03:16:08PM +0100, Jan Beulich wrote: On 18.02.2022 18:29, Jane Malalane wrote: > --- a/xen/arch/x86/hvm/vmx/

RE: Proposal for Porting Xen to Armv8-R64 - DraftA

2022-02-28 Thread Wei Chen
Hi Julien, > -Original Message- > From: Julien Grall > Sent: 2022年2月26日 4:55 > To: Wei Chen ; xen-devel@lists.xenproject.org; Stefano > Stabellini > Cc: Bertrand Marquis ; Penny Zheng > ; Henry Wang ; nd > Subject: Re: Proposal for Porting Xen to Armv8-R64 - DraftA > > Hi Wei, > > Tha

Re: [PATCH v3 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86

2022-02-28 Thread Jan Beulich
On 28.02.2022 17:31, Roger Pau Monné wrote: > On Mon, Feb 28, 2022 at 05:14:26PM +0100, Jan Beulich wrote: >> On 28.02.2022 16:36, Roger Pau Monné wrote: >>> On Mon, Feb 28, 2022 at 02:11:04PM +0100, Jan Beulich wrote: On 28.02.2022 11:59, Roger Pau Monné wrote: > On Thu, Feb 24, 2022 at 0

Re: [PATCH v2 2/2] vpci/msix: fix PBA accesses

2022-02-28 Thread Jan Beulich
On 28.02.2022 19:19, Alex Olson wrote: > FYI, with this patch, I was seeing msix_read() and msix_write() being called > during the driver's self-test on physical address 0xfbc01800, corresponding to > the beginning of the PBA (lspci excerpt below): > > > 02:00.0 System peripheral: Intel Corpora

[ovmf bisection] complete build-amd64-xsm

2022-02-28 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job build-amd64-xsm testid xen-build Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xe

RE: Proposal for Porting Xen to Armv8-R64 - DraftA

2022-02-28 Thread Wei Chen
Hi Julien, > -Original Message- > From: Julien Grall > Sent: 2022年2月26日 4:12 > To: Wei Chen ; Stefano Stabellini > > Cc: xen-devel@lists.xenproject.org; Bertrand Marquis > ; Penny Zheng ; Henry Wang > ; nd > Subject: Re: Proposal for Porting Xen to Armv8-R64 - DraftA > > Hi Wei, > > O

[ovmf test] 168267: regressions - FAIL

2022-02-28 Thread osstest service owner
flight 168267 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168267/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

[linux-linus test] 168256: tolerable FAIL - PUSHED

2022-02-28 Thread osstest service owner
flight 168256 linux-linus real [real] flight 168261 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/168256/ http://logs.test-lab.xenproject.org/osstest/logs/168261/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-

[ovmf test] 168262: regressions - FAIL

2022-02-28 Thread osstest service owner
flight 168262 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168262/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH v3 0/1] xen: fix HVM kexec kernel panic

2022-02-28 Thread Dongli Zhang
Hi Boris, On 2/28/22 5:18 PM, Dongli Zhang wrote: > Hi Boris, > > On 2/28/22 12:45 PM, Boris Ostrovsky wrote: >> >> >> On 2/25/22 8:17 PM, Dongli Zhang wrote: >>> Hi Boris, >>> >>> On 2/25/22 2:39 PM, Boris Ostrovsky wrote: On 2/24/22 4:50 PM, Dongli Zhang wrote: > This is the v3 of

[ovmf test] 168258: regressions - FAIL

2022-02-28 Thread osstest service owner
flight 168258 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168258/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

RE: [RFC PATCH 0/2] Introduce reserved Xenheap

2022-02-28 Thread Wei Chen
Hi Julien, > -Original Message- > From: Henry Wang > Sent: 2022年3月1日 10:11 > To: Julien Grall ; xen-devel@lists.xenproject.org; > sstabell...@kernel.org > Cc: Bertrand Marquis ; Wei Chen > ; Penny Zheng > Subject: RE: [RFC PATCH 0/2] Introduce reserved Xenheap > > Hi Julien, > > >

RE: [RFC PATCH 0/2] Introduce reserved Xenheap

2022-02-28 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > On 28/02/2022 07:12, Henry Wang wrote: > > Hi Julien, > > Hi Henry, > > >> -Original Message- > >> From: Julien Grall > >> Hi Henry, > >> > >> On 24/02/2022 01:30, Henry Wang wrote: > >>> The reserved Xenheap, or statically

Re: [PATCH v3 0/1] xen: fix HVM kexec kernel panic

2022-02-28 Thread Dongli Zhang
Hi Boris, On 2/28/22 12:45 PM, Boris Ostrovsky wrote: > > > On 2/25/22 8:17 PM, Dongli Zhang wrote: >> Hi Boris, >> >> On 2/25/22 2:39 PM, Boris Ostrovsky wrote: >>> >>> On 2/24/22 4:50 PM, Dongli Zhang wrote: This is the v3 of the patch to fix xen kexec kernel panic issue when the kex

[qemu-mainline test] 168255: tolerable FAIL - PUSHED

2022-02-28 Thread osstest service owner
flight 168255 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/168255/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 168230 test-armhf-armhf-libvirt 16 sav

[PATCH] x86/spec-ctrl: Disable retpolines with CET-IBT

2022-02-28 Thread Andrew Cooper
CET-IBT depend on executing indirect branches for protections to apply. Extend the clobber for CET-SS to all of CET. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu I can't decide if this wants a fixes tag or not. If I'd remembered during the CET series, it w

Re: [PATCH v3 0/1] xen: fix HVM kexec kernel panic

2022-02-28 Thread Boris Ostrovsky
On 2/25/22 8:17 PM, Dongli Zhang wrote: Hi Boris, On 2/25/22 2:39 PM, Boris Ostrovsky wrote: On 2/24/22 4:50 PM, Dongli Zhang wrote: This is the v3 of the patch to fix xen kexec kernel panic issue when the kexec is triggered on VCPU >= 32. PANIC: early exception 0x0e IP 10:a96679b

Re: [PATCH v2] lib: extend ASSERT()

2022-02-28 Thread Julien Grall
Hi George, Sorry for the late answer. On 16/02/2022 12:23, George Dunlap wrote: On Feb 16, 2022, at 11:42 AM, Jan Beulich wrote: On 16.02.2022 12:34, George Dunlap wrote: I am opposed to overloading “ASSERT” for this new kind of macro; I think it would not only be unnecessarily confusin

Re: [RFC PATCH 0/2] Introduce reserved Xenheap

2022-02-28 Thread Julien Grall
On 28/02/2022 07:12, Henry Wang wrote: Hi Julien, Hi Henry, -Original Message- From: Julien Grall Sent: Saturday, February 26, 2022 4:09 AM To: Henry Wang ; xen-devel@lists.xenproject.org; sstabell...@kernel.org Cc: Bertrand Marquis ; Wei Chen ; Penny Zheng Subject: Re: [RFC PATC

Re: [PATCH v2 2/2] vpci/msix: fix PBA accesses

2022-02-28 Thread Alex Olson
Hi Roger, The revised patch looks good. The PBA writes seen during ioatdma driver initialization (self-test) complete successfully and the driver doesn't complain (I see two interrupts per ioatdma device). The driver has a self-test feature which appears to exercise MSIX interrupts and has code

RE: [PATCH 08/11] swiotlb: make the swiotlb_init interface more useful

2022-02-28 Thread Michael Kelley (LINUX)
From: Christoph Hellwig Sent: Monday, February 28, 2022 3:31 AM > > On Mon, Feb 28, 2022 at 02:53:39AM +, Michael Kelley (LINUX) wrote: > > From: Christoph Hellwig Sent: Sunday, February 27, 2022 6:31 > > AM > > > > > > Pass a bool to pass if swiotlb needs to be enabled based on the > > > a

[xen-unstable test] 168253: tolerable FAIL

2022-02-28 Thread osstest service owner
flight 168253 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/168253/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 168248 pass in 168253 test-armhf-arm

Re: [PATCH v3 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86

2022-02-28 Thread Roger Pau Monné
On Mon, Feb 28, 2022 at 05:14:26PM +0100, Jan Beulich wrote: > On 28.02.2022 16:36, Roger Pau Monné wrote: > > On Mon, Feb 28, 2022 at 02:11:04PM +0100, Jan Beulich wrote: > >> On 28.02.2022 11:59, Roger Pau Monné wrote: > >>> On Thu, Feb 24, 2022 at 03:08:41PM +0100, Jan Beulich wrote: > On 1

Re: [PATCH v3 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86

2022-02-28 Thread Jan Beulich
On 28.02.2022 16:36, Roger Pau Monné wrote: > On Mon, Feb 28, 2022 at 02:11:04PM +0100, Jan Beulich wrote: >> On 28.02.2022 11:59, Roger Pau Monné wrote: >>> On Thu, Feb 24, 2022 at 03:08:41PM +0100, Jan Beulich wrote: On 18.02.2022 18:29, Jane Malalane wrote: > Add XEN_SYSCTL_PHYSCAP_ARCH

[PATCH] build: export potentially overridden tool chain components

2022-02-28 Thread Jan Beulich
When overriding the tool chain via CROSS_COMPILE, the resulting components need to be made available to, in particular (but not limited to) the check-endbr.sh script. Note that we don't allow overriding ADDR2LINE yet; this would first require additions to some config/*.mk before it would make sense

Re: [PATCH v3 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC

2022-02-28 Thread Roger Pau Monné
On Mon, Feb 28, 2022 at 02:14:26PM +0100, Jan Beulich wrote: > On 28.02.2022 12:20, Roger Pau Monné wrote: > > On Thu, Feb 24, 2022 at 03:16:08PM +0100, Jan Beulich wrote: > >> On 18.02.2022 18:29, Jane Malalane wrote: > >>> --- a/xen/arch/x86/hvm/vmx/vmx.c > >>> +++ b/xen/arch/x86/hvm/vmx/vmx.c >

Re: [PATCH v3 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86

2022-02-28 Thread Roger Pau Monné
On Mon, Feb 28, 2022 at 02:11:04PM +0100, Jan Beulich wrote: > On 28.02.2022 11:59, Roger Pau Monné wrote: > > On Thu, Feb 24, 2022 at 03:08:41PM +0100, Jan Beulich wrote: > >> On 18.02.2022 18:29, Jane Malalane wrote: > >>> Add XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_xapic and > >>> XEN_SYSCTL_PHYSCAP_AR

[XEN PATCH 4/4] automation: use "needs" instead of "dependencies" for test jobs

2022-02-28 Thread Anthony PERARD
Like with "dependencies", the jobs will get artifacts from the jobs listed in "needs". But the test jobs can run as soon as the build jobs listed have finished. Signed-off-by: Anthony PERARD --- automation/gitlab-ci/test.yaml | 16 1 file changed, 8 insertions(+), 8 deletions(-)

[XEN PATCH 1/4] automation: fix typo in .gcc-tmpl

2022-02-28 Thread Anthony PERARD
The name of the field doesn't matter because it's use as a YAML achor, but it's nicer to have the proper spelling. Signed-off-by: Anthony PERARD --- automation/gitlab-ci/build.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/automation/gitlab-ci/build.yaml b/automation/gi

[XEN PATCH 0/4] Some improvement for gitlab CI jobs

2022-02-28 Thread Anthony PERARD
Patch series available in this git branch: https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.gitlab-ci-improvement-v1 Allow build and test jobs to run concurently. Avoid running "test artifact" jobs on branch "master" and other, when test jobs aren't runned. Anthony PERARD (4)

[XEN PATCH 3/4] automation: only run test artifact jobs when needed

2022-02-28 Thread Anthony PERARD
Share the same "except" as the one used for tests. Signed-off-by: Anthony PERARD --- automation/gitlab-ci/build.yaml | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index 26dcfb1c25..cbbe0b834

[XEN PATCH 2/4] automation: add a templates for test jobs

2022-02-28 Thread Anthony PERARD
Allow to set common configuration from a single place for all tests jobs. Signed-off-by: Anthony PERARD --- automation/gitlab-ci/test.yaml | 73 -- 1 file changed, 17 insertions(+), 56 deletions(-) diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-c

Re: [PATCH] RFC: Version support policy

2022-02-28 Thread George Dunlap
> On Feb 15, 2022, at 8:20 AM, Jan Beulich wrote: > > On 14.02.2022 22:50, George Dunlap wrote: >>> On Aug 19, 2021, at 10:18 AM, Jan Beulich wrote: >>> On 13.08.2021 13:37, Ian Jackson wrote: The current policy for minimum supported versions of tools, compilers, etc. is unsatisfacto

Re: [PATCH] docs: correct "gnttab=" documented default

2022-02-28 Thread Julien Grall
Hi Jan, On 28/02/2022 14:32, Jan Beulich wrote: On 28.02.2022 15:02, Julien Grall wrote: On 28/02/2022 10:19, Jan Beulich wrote: Defaults differ for Arm and x86, not the least because of v2 not even being security supported on Arm. Also drop a bogus sentence from gnttab_max_maptrack_frames, w

Re: [PATCH] docs: correct x86 MCE command line option info

2022-02-28 Thread Jan Beulich
On 28.02.2022 14:19, Andrew Cooper wrote: > On 28/02/2022 10:20, Jan Beulich wrote: >> Not even the types were correct, > > Huh yes.  c/s 97638f08f4 was plain wrong. > >> let alone defaults being spelled out or >> the purpose of the options actually mentioned in any way. >> >> Signed-off-by: Jan

Re: [PATCH] docs: correct "gnttab=" documented default

2022-02-28 Thread Jan Beulich
On 28.02.2022 15:02, Julien Grall wrote: > On 28/02/2022 10:19, Jan Beulich wrote: >> Defaults differ for Arm and x86, not the least because of v2 not even >> being security supported on Arm. >> >> Also drop a bogus sentence from gnttab_max_maptrack_frames, which was >> presumably mistakenly cloned

Re: [PATCH] docs: correct "gnttab=" documented default

2022-02-28 Thread Julien Grall
Hi Jan, On 28/02/2022 10:19, Jan Beulich wrote: Defaults differ for Arm and x86, not the least because of v2 not even being security supported on Arm. Also drop a bogus sentence from gnttab_max_maptrack_frames, which was presumably mistakenly cloned from gnttab_max_frames (albeit even there wha

[ovmf test] 168254: all pass - PUSHED

2022-02-28 Thread osstest service owner
flight 168254 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168254/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 baseline version: ovmf f1d1c337e7c0575da7fd2

Re: [PATCH v2] xen/arm32: head: Don't set r12 and update the documentation

2022-02-28 Thread Michal Orzel
Hi Julien, On 28.02.2022 14:35, Julien Grall wrote: > From: Julien Grall > > Since commit 54c4ae18d158 ("xen/arm32: head: Rework and document > launch()"), the boot code is setting r12 but not read it. > > So remove the two instructions setting r12 and update the documentation > to show r12 has

[PATCH v2] xen/arm32: head: Don't set r12 and update the documentation

2022-02-28 Thread Julien Grall
From: Julien Grall Since commit 54c4ae18d158 ("xen/arm32: head: Rework and document launch()"), the boot code is setting r12 but not read it. So remove the two instructions setting r12 and update the documentation to show r12 has no specific purpose. Signed-off-by: Julien Grall --- Change

Re: [PATCH] xen/arm32: head: Update the documentation for register r12

2022-02-28 Thread Julien Grall
On 28/02/2022 13:04, Michal Orzel wrote: Hi Julien, Hi Michal, Thank you for the review. On 28.02.2022 11:11, Julien Grall wrote: From: Julien Grall Since commit 54c4ae18d158 ("xen/arm32: head: Rework and document launch()"), the boot code is not using the register r12. So update the

Re: [PATCH] docs: correct x86 MCE command line option info

2022-02-28 Thread Andrew Cooper
On 28/02/2022 10:20, Jan Beulich wrote: > Not even the types were correct, Huh yes.  c/s 97638f08f4 was plain wrong. > let alone defaults being spelled out or > the purpose of the options actually mentioned in any way. > > Signed-off-by: Jan Beulich > > --- a/docs/misc/xen-command-line.pandoc >

Re: [PATCH v3 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC

2022-02-28 Thread Jan Beulich
On 28.02.2022 12:20, Roger Pau Monné wrote: > On Thu, Feb 24, 2022 at 03:16:08PM +0100, Jan Beulich wrote: >> On 18.02.2022 18:29, Jane Malalane wrote: >>> --- a/xen/arch/x86/hvm/vmx/vmx.c >>> +++ b/xen/arch/x86/hvm/vmx/vmx.c >>> @@ -,15 +,15 @@ static void vmx_install_vlapic_mapping(struct

Re: [PATCH v3 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86

2022-02-28 Thread Jan Beulich
On 28.02.2022 11:59, Roger Pau Monné wrote: > On Thu, Feb 24, 2022 at 03:08:41PM +0100, Jan Beulich wrote: >> On 18.02.2022 18:29, Jane Malalane wrote: >>> Add XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_xapic and >>> XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_x2apic to report accelerated xapic >>> and x2apic, on x86 h

Re: [PATCH v3 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86

2022-02-28 Thread Jan Beulich
On 28.02.2022 13:09, Jane Malalane wrote: > On 28/02/2022 07:32, Jan Beulich wrote: >> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments >> unless you have verified the sender and know the content is safe. >> >> On 25.02.2022 17:02, Jane Malalane wrote: >>> On 24/02/2022 14

Re: [PATCH] xen/arm32: head: Update the documentation for register r12

2022-02-28 Thread Michal Orzel
Hi Julien, On 28.02.2022 11:11, Julien Grall wrote: > From: Julien Grall > > Since commit 54c4ae18d158 ("xen/arm32: head: Rework and document > launch()"), the boot code is not using the register r12. > > So update the documentation to show r12 has no specific purpose. > > Signed-off-by: Julie

Re: [PATCH v3 06/70] x86: Introduce support for CET-IBT

2022-02-28 Thread Jan Beulich
On 22.02.2022 16:26, Andrew Cooper wrote: > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -40,6 +40,11 @@ config HAS_AS_CET_SS > # binutils >= 2.29 or LLVM >= 6 > def_bool $(as-instr,wrssq %rax$(comma)0;setssbsy) > > +config HAS_CC_CET_IBT > + # GCC >= 9 and binutil

Re: [PATCH] xen/arm64: head: Mark the end of subroutines with ENDPROC (take two)

2022-02-28 Thread Michal Orzel
Hi Julien, On 28.02.2022 11:08, Julien Grall wrote: > From: Julien Grall > > Commit 13c03002c5df ("xen/arm64: head: Mark the end of subroutines > with ENDPROC") intended to mark all the subroutines with ENDPROC. > > Unfortunately, I missed fail(), switch_ttbr() and init_uart(). Add > ENDPROC fo

Re: [PATCH] xen/arm32: head: Mark the end of subroutines with ENDPROC (take two)

2022-02-28 Thread Michal Orzel
Hi Julien, On 28.02.2022 11:07, Julien Grall wrote: > From: Julien Grall > > Commit 2ac705a59ef5 ("xen/arm32: head: Mark the end of subroutines > with ENDPROC") intended to mark all the subroutines with ENDPROC. > > Unfortunately, I missed fail(), switch_ttbr(), init_uart() and > __lookup_proce

Re: [PATCH v2 3/3] xen/vpci: msix: move read/write call to MSI-X PBA entry to arch file

2022-02-28 Thread Rahul Singh
Hi Roger, > On 25 Feb 2022, at 8:20 am, Roger Pau Monné wrote: > > On Tue, Feb 15, 2022 at 03:25:18PM +, Rahul Singh wrote: >> {read,write}{l,q} function argument is different for ARM and x86. >> ARM {read,wrie}(l,q} function argument is pointer whereas X86 >> {read,wrie}(l,q} function argum

Re: [PATCH v3 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86

2022-02-28 Thread Jane Malalane
On 28/02/2022 07:32, Jan Beulich wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > On 25.02.2022 17:02, Jane Malalane wrote: >> On 24/02/2022 14:08, Jan Beulich wrote: >>> On 18.02.2022 18:29,

Re: [PATCH v3 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86

2022-02-28 Thread Jane Malalane
On 28/02/2022 07:32, Jan Beulich wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > On 25.02.2022 17:02, Jane Malalane wrote: >> On 24/02/2022 14:08, Jan Beulich wrote: >>> On 18.02.2022 18:29,

Re: [PATCH 08/11] swiotlb: make the swiotlb_init interface more useful

2022-02-28 Thread Christoph Hellwig
On Mon, Feb 28, 2022 at 02:53:39AM +, Michael Kelley (LINUX) wrote: > From: Christoph Hellwig Sent: Sunday, February 27, 2022 6:31 AM > > > > Pass a bool to pass if swiotlb needs to be enabled based on the > > addressing needs and replace the verbose argument with a set of > > flags, includin

[linux-linus test] 168250: tolerable FAIL - PUSHED

2022-02-28 Thread osstest service owner
flight 168250 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/168250/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 168247 test-amd64-amd64-xl-qemuu-ws16-amd64

[PATCH] include/public: add command result definitions to vscsiif.h

2022-02-28 Thread Juergen Gross
The result field of struct vscsiif_response is lacking a detailed definition. Today the Linux kernel internal scsi definitions are being used, which is not a sane interface for a PV device driver. Add macros to change that by using today's values in the XEN namespace. Signed-off-by: Juergen Gross

Re: [PATCH v3 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC

2022-02-28 Thread Roger Pau Monné
On Thu, Feb 24, 2022 at 03:16:08PM +0100, Jan Beulich wrote: > On 18.02.2022 18:29, Jane Malalane wrote: > > --- a/xen/arch/x86/hvm/vmx/vmx.c > > +++ b/xen/arch/x86/hvm/vmx/vmx.c > > @@ -,15 +,15 @@ static void vmx_install_vlapic_mapping(struct vcpu > > *v) > > > > void vmx_vlapic_msr_c

[libvirt test] 168251: regressions - FAIL

2022-02-28 Thread osstest service owner
flight 168251 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/168251/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

Re: [PATCH v3 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86

2022-02-28 Thread Roger Pau Monné
On Thu, Feb 24, 2022 at 03:08:41PM +0100, Jan Beulich wrote: > On 18.02.2022 18:29, Jane Malalane wrote: > > Add XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_xapic and > > XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_x2apic to report accelerated xapic > > and x2apic, on x86 hardware. > > No such features are currently imp

Re: [PATCH v2] xen/arm: vpci: remove PCI I/O ranges property value

2022-02-28 Thread Rahul Singh
Hi Julien, Thanks for reviewing the code. > On 25 Feb 2022, at 7:46 pm, Julien Grall wrote: > > Hi Rahul, > > On 15/02/2022 15:36, Rahul Singh wrote: >> PCI I/O space are not mapped to dom0 when PCI passthrough is enabled, >> also there is no vpci trap handler register for IO bar. >> Remove PC

Re: [PATCH] x86/CPUID: correct FEATURESET_7d2 comment

2022-02-28 Thread Andrew Cooper
On 28/02/2022 10:55, Jan Beulich wrote: > Signed-off-by: Jan Beulich > > --- a/xen/include/xen/lib/x86/cpuid.h > +++ b/xen/include/xen/lib/x86/cpuid.h > @@ -17,7 +17,7 @@ > #define FEATURESET_7a1 10 /* 0x0007:1.eax*/ > #define FEATURESET_e21a 11 /* 0x8021.eax */ > #define FE

[PATCH] x86/CPUID: correct FEATURESET_7d2 comment

2022-02-28 Thread Jan Beulich
Signed-off-by: Jan Beulich --- a/xen/include/xen/lib/x86/cpuid.h +++ b/xen/include/xen/lib/x86/cpuid.h @@ -17,7 +17,7 @@ #define FEATURESET_7a1 10 /* 0x0007:1.eax*/ #define FEATURESET_e21a 11 /* 0x8021.eax */ #define FEATURESET_7b1 12 /* 0x0007:1.ebx*/ -#define FE

Re: [PATCH v3 14/19] xen/arm: add Persistent Map (PMAP) infrastructure

2022-02-28 Thread Julien Grall
Hi Jan, On 28/02/2022 10:30, Jan Beulich wrote: On 28.02.2022 11:20, Julien Grall wrote: On 28/02/2022 10:10, Jan Beulich wrote: On 28.02.2022 10:55, Julien Grall wrote: On 22/02/2022 15:22, Jan Beulich wrote: On 21.02.2022 11:22, Julien Grall wrote: +/* + * We cannot use set_fixmap

Re: [PATCH v3 14/19] xen/arm: add Persistent Map (PMAP) infrastructure

2022-02-28 Thread Jan Beulich
On 28.02.2022 11:20, Julien Grall wrote: > On 28/02/2022 10:10, Jan Beulich wrote: >> On 28.02.2022 10:55, Julien Grall wrote: >>> On 22/02/2022 15:22, Jan Beulich wrote: On 21.02.2022 11:22, Julien Grall wrote: > +/* > + * We cannot use set_fixmap() here. We use PMAP when ther

Re: [PATCH v3 14/19] xen/arm: add Persistent Map (PMAP) infrastructure

2022-02-28 Thread Julien Grall
Hi Jan, On 28/02/2022 10:10, Jan Beulich wrote: On 28.02.2022 10:55, Julien Grall wrote: On 22/02/2022 15:22, Jan Beulich wrote: On 21.02.2022 11:22, Julien Grall wrote: +/* + * We cannot use set_fixmap() here. We use PMAP when there is no direct map, + * so map_pages_to_xen() ca

[PATCH] docs: correct x86 MCE command line option info

2022-02-28 Thread Jan Beulich
Not even the types were correct, let alone defaults being spelled out or the purpose of the options actually mentioned in any way. Signed-off-by: Jan Beulich --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -1681,10 +1681,21 @@ one pending bit to be allocated.

[PATCH] docs: correct "gnttab=" documented default

2022-02-28 Thread Jan Beulich
Defaults differ for Arm and x86, not the least because of v2 not even being security supported on Arm. Also drop a bogus sentence from gnttab_max_maptrack_frames, which was presumably mistakenly cloned from gnttab_max_frames (albeit even there what is being said is neither very precise nor very us

[PATCH] xen/arm32: head: Update the documentation for register r12

2022-02-28 Thread Julien Grall
From: Julien Grall Since commit 54c4ae18d158 ("xen/arm32: head: Rework and document launch()"), the boot code is not using the register r12. So update the documentation to show r12 has no specific purpose. Signed-off-by: Julien Grall --- xen/arch/arm/arm32/head.S | 2 +- 1 file changed, 1 ins

Re: [PATCH v3 14/19] xen/arm: add Persistent Map (PMAP) infrastructure

2022-02-28 Thread Jan Beulich
On 28.02.2022 10:55, Julien Grall wrote: > On 22/02/2022 15:22, Jan Beulich wrote: >> On 21.02.2022 11:22, Julien Grall wrote: >>> +/* >>> + * We cannot use set_fixmap() here. We use PMAP when there is no >>> direct map, >>> + * so map_pages_to_xen() called by set_fixmap() needs to map

Re: [PATCH] xen/arm64: head: Mark the end of subroutines with ENDPROC (take two)

2022-02-28 Thread Julien Grall
On 28/02/2022 10:08, Julien Grall wrote: From: Julien Grall Commit 13c03002c5df ("xen/arm64: head: Mark the end of subroutines with ENDPROC") intended to mark all the subroutines with ENDPROC. Unfortunately, I missed fail(), switch_ttbr() and init_uart(). Add ENDPROC for the benefits of static

[PATCH] xen/arm64: head: Mark the end of subroutines with ENDPROC (take two)

2022-02-28 Thread Julien Grall
From: Julien Grall Commit 13c03002c5df ("xen/arm64: head: Mark the end of subroutines with ENDPROC") intended to mark all the subroutines with ENDPROC. Unfortunately, I missed fail(), switch_ttbr() and init_uart(). Add ENDPROC for the benefits of static analysis tools and the reader. Signed-off

[PATCH] xen/arm64: head: Mark the end of subroutines with ENDPROC (take two)

2022-02-28 Thread Julien Grall
From: Julien Grall Commit 13c03002c5df ("xen/arm64: head: Mark the end of subroutines with ENDPROC") intended to mark all the subroutines with ENDPROC. Unfortunately, I missed fail(), switch_ttbr() and init_uart(). Add ENDPROC for the benefits of static analysis tools and the reader. Signed-off

[PATCH] xen/arm32: head: Mark the end of subroutines with ENDPROC (take two)

2022-02-28 Thread Julien Grall
From: Julien Grall Commit 2ac705a59ef5 ("xen/arm32: head: Mark the end of subroutines with ENDPROC") intended to mark all the subroutines with ENDPROC. Unfortunately, I missed fail(), switch_ttbr(), init_uart() and __lookup_processor_type(). Add ENDPROC for the benefits of static analysis tools

[PATCH] xen/arm: mm: Encode existing constraints of the memory layout

2022-02-28 Thread Julien Grall
From: Julien Grall The boot code expects the regions XEN_VIRT_START, FIXMAP_ADDR(0), BOOT_FDT_VIRT_START to use the same 0th (arm64 only) and 1st slot. Add some BUILD_BUG_ON() to confirm that. This is helpful if one wants to re-order the memory layout. Signed-off-by: Julien Grall --- xen/arch

[PATCH] xen/arm: Remove unused BOOT_RELOC_VIRT_START

2022-02-28 Thread Julien Grall
From: Julien Grall We stopped relocating Xen since commit f60658c6ae "xen/arm: Stop relocating Xen". At the same time, update the memory layout description. Signed-off-by: Julien Grall Signed-off-by: Julien Grall --- xen/arch/arm/include/asm/config.h | 4 +--- xen/arch/arm/mm.c

Re: [PATCH v3 14/19] xen/arm: add Persistent Map (PMAP) infrastructure

2022-02-28 Thread Julien Grall
Hi Jan, On 22/02/2022 15:22, Jan Beulich wrote: On 21.02.2022 11:22, Julien Grall wrote: --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -28,6 +28,7 @@ obj-y += multicall.o obj-y += notifier.o obj-y += page_alloc.o obj-$(CONFIG_HAS_PDX) += pdx.o +obj-bin-$(CONFIG_HAS_PMAP) += pmap.

Re: [PATCH 3/3] xen/arm: Add i.MX8QM platform support

2022-02-28 Thread Julien Grall
Hi Peng, On 28/02/2022 01:07, Peng Fan (OSS) wrote: From: Peng Fan Signed-off-by: Peng Fan --- xen/arch/arm/Kconfig.debug | 3 +++ xen/arch/arm/platforms/Makefile | 1 + xen/arch/arm/platforms/imx8qm.c | 44 + 3 files changed, 48 insertions(+) cre

RE: [PATCH 1/3] xen/arm: Add i.MX lpuart driver

2022-02-28 Thread Peng Fan
Hi Julien, > Subject: Re: [PATCH 1/3] xen/arm: Add i.MX lpuart driver > > Hi Peng, > > On 28/02/2022 01:07, Peng Fan (OSS) wrote: > > From: Peng Fan > > Can you give me a link to the specification and/or a similar driver in Linux? https://www.nxp.com/webapp/Download?colCode=IMX8QMIEC Chatper

Re: [PATCH 2/3] xen/arm: Add i.MX lpuart early printk support

2022-02-28 Thread Julien Grall
Hi Peng, On 28/02/2022 01:07, Peng Fan (OSS) wrote: From: Peng Fan Signed-off-by: Peng Fan --- xen/arch/arm/Kconfig.debug | 18 ++ xen/arch/arm/arm64/debug-imx-lpuart.inc | 48 + 2 files changed, 66 insertions(+) create mode 100644 xen/arch/a

Re: [PATCH 1/3] xen/arm: Add i.MX lpuart driver

2022-02-28 Thread Julien Grall
Hi Peng, On 28/02/2022 01:07, Peng Fan (OSS) wrote: From: Peng Fan Can you give me a link to the specification and/or a similar driver in Linux? This would help to review this patch. Cheers, -- Julien Grall

Re: [PATCH 2/2] codeql: ignore Kconfig

2022-02-28 Thread Roger Pau Monné
On Fri, Feb 25, 2022 at 03:39:22PM +, Andrew Cooper wrote: > On 25/02/2022 15:19, Roger Pau Monne wrote: > > Signed-off-by: Roger Pau Monné > > I agree with this, but it looks like it wants to be folded into the > previous patch. Can do. We also need to add tools/firmware/xen-dir/xen-root/xe

Re: [PATCH 1/2] codeql: add support for analyzing C, Python and Go

2022-02-28 Thread Roger Pau Monné
On Fri, Feb 25, 2022 at 03:38:42PM +, Andrew Cooper wrote: > On 25/02/2022 15:19, Roger Pau Monne wrote: > > Introduce CodeQL support for Xen and analyze the C, Python and Go > > files. > > > > Note than when analyzing Python or Go we avoid building the hypervisor > > and only build the tools.

RE: [PATCH 0/3] xen/arm: add i.MX lpuart and i.MX8QM initial support

2022-02-28 Thread Peng Fan
> Subject: Re: [PATCH 0/3] xen/arm: add i.MX lpuart and i.MX8QM initial > support > > On 28.02.2022 02:07, Peng Fan (OSS) wrote: > > From: Peng Fan > > > > Add i.MX lpuart driver and i.MX8QM platform support. > > - lpuart is the uart IP used in i.MX8QM/QXP/93. > > - Very basic i.MX8QM platform

Re: [PATCH 0/3] xen/arm: add i.MX lpuart and i.MX8QM initial support

2022-02-28 Thread Jan Beulich
On 28.02.2022 02:07, Peng Fan (OSS) wrote: > From: Peng Fan > > Add i.MX lpuart driver and i.MX8QM platform support. > - lpuart is the uart IP used in i.MX8QM/QXP/93. > - Very basic i.MX8QM platform support. > > Peng Fan (3): > xen/arm: Add i.MX lpuart driver > xen/arm: Add i.MX lpuart ear

Re: [PATCH v2 1/2] vpci/msix: reduce indentation in msix_write PBA handling

2022-02-28 Thread Jan Beulich
On 25.02.2022 16:39, Roger Pau Monne wrote: > No functional change. > > Signed-off-by: Roger Pau Monné Acked-by: Jan Beulich