Re: alternatives+livepatch testing

2022-03-10 Thread Doebel, Bjoern
Hi, Hello, The recent hiccup with CET-IBT, and discovery that livepatch-build-tools have been broken for several releases, demonstrates that we do not have remotely adequate testing in place. We need to address, and ensure we don't end up in the same position again. Alternatives and Livepatch

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-10 Thread Jan Beulich
On 10.03.2022 18:10, Luca Fancellu wrote: > +chosen { > + > +sched: sched_a { > +compatible = "xen,scheduler"; > +sched-name = "null"; > +}; > +cpupool_a { > +compatible = "xen,cpupool"; > +cpupool-cpus = <&a53_1 &a53_2>; > +}; > +cpupool_b { > +

Re: [PATCH 3/3] livepatch: correctly handle altinstruction sections

2022-03-10 Thread Jan Beulich
On 10.03.2022 16:08, Roger Pau Monne wrote: > --- a/common.c > +++ b/common.c > @@ -249,19 +249,22 @@ int is_text_section(struct section *sec) > (sec->sh.sh_flags & SHF_EXECINSTR)); > } > > +#define SEC_MATCH(n) !strncmp(sec->name, n, strlen(n) - 1) > int is_rodata_section(struct

Re: [PATCH 2/3] amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests

2022-03-10 Thread Jan Beulich
On 10.03.2022 17:41, Roger Pau Monné wrote: > On Mon, Feb 14, 2022 at 05:02:52PM +0100, Jan Beulich wrote: >> On 01.02.2022 17:46, Roger Pau Monne wrote: >>> --- a/xen/arch/x86/hvm/svm/entry.S >>> +++ b/xen/arch/x86/hvm/svm/entry.S >>> @@ -71,7 +71,9 @@ __UNLIKELY_END(nsvm_hap) >>> mov

Re: [PATCH] x86/cet: Use dedicated NOP4 for cf_clobber

2022-03-10 Thread Jan Beulich
On 10.03.2022 19:42, Andrew Cooper wrote: > On 08/03/2022 16:03, Andrew Cooper wrote: >> --- a/xen/arch/x86/include/asm/endbr.h >> +++ b/xen/arch/x86/include/asm/endbr.h >> @@ -52,4 +52,16 @@ static inline void place_endbr64(void *ptr) >> *(uint32_t *)ptr = gen_endbr64(); >

[PATCH v1 12/13] xen/arm: defer foreign memory map in shm_init_late

2022-03-10 Thread Penny Zheng
From: Penny Zheng This commit introduces a new helper shm_init_late to implement deferred foreign memory mapping of static shared memory. Signed-off-by: Penny Zheng --- xen/arch/arm/domain_build.c | 51 +++ xen/arch/arm/include/asm/domain.h | 1 + xen/arch/ar

[PATCH v1 11/13] xen/arm: store shm-info for deferred foreign memory map

2022-03-10 Thread Penny Zheng
From: Penny Zheng In a few scenarios where owner domain, is defined after borrower domain in device tree configuration, then statically shared pages haven't been properly allocated if borrower domain tries to do foreign memory map during domain construction. In order to cover such scenario, we d

[PATCH v1 13/13] xen/arm: unmap foreign memory mapping when destroyed domain is owner domain

2022-03-10 Thread Penny Zheng
From: Penny Zheng When destroyed domain is an owner domain of a static shared memory region, then we need to ensure that all according borrower domains shall not have the access to this static shared memory region too. This commit covers above scenario through unmapping all borrowers' according

[PATCH v1 10/13] xen/arm: allocate static shared memory to a specific owner domain

2022-03-10 Thread Penny Zheng
From: Penny Zheng If owner property is defined, then owner domain of a static shared memory region is not the default dom_shared anymore, but a specific domain. This commit implements allocating static shared memory to a specific domain when owner property is defined. Signed-off-by: Penny Zheng

[PATCH v1 09/13] xen/arm: enable statically shared memory on Dom0

2022-03-10 Thread Penny Zheng
From: Penny Zheng To add statically shared memory nodes in Dom0, user shall put according static shared memory configuration under /chosen node. This commit adds shm-processing function process_shm in construct_dom0 to enable statically shared memory on Dom0. Signed-off-by: Penny Zheng --- xe

[PATCH v1 07/13] xen/arm: create shared memory nodes in guest device tree

2022-03-10 Thread Penny Zheng
From: Penny Zheng We expose the shared memory to the domU using the "xen,shared-memory-v1" reserved-memory binding. See Documentation/devicetree/bindings/reserved-memory/xen,shared-memory.txt in Linux for the corresponding device tree binding. To save the cost of re-parsing shared memory device

[PATCH v1 01/13] xen/arm: introduce static shared memory

2022-03-10 Thread Penny Zheng
From: Penny Zheng This patch serie introduces a new feature: setting up static shared memory on a dom0less system, through device tree configuration. This commit parses shared memory node at boot-time, and reserve it in bootinfo.reserved_mem to avoid other use. Signed-off-by: Penny Zheng ---

[PATCH v1 08/13] xen/arm: destroy static shared memory when de-construct domain

2022-03-10 Thread Penny Zheng
From: Penny Zheng This commit introduces a new helper destroy_domain_shm to destroy static shared memory at domain de-construction. This patch only considers the scenario where the owner domain is the default dom_shared, for user-defined owner domain, it will be covered in the following patches.

[PATCH v1 06/13] xen/arm: set up shared memory foreign mapping for borrower domain

2022-03-10 Thread Penny Zheng
From: Penny Zheng This commits introduces a new helper guest_physmap_add_shm to set up shared memory foreign mapping for borrower domain. Firstly it should get and take reference of statically shared pages from owner dom_shared. Then it will setup P2M foreign memory map of these statically share

[PATCH v1 03/13] xen/arm: allocate static shared memory to dom_shared

2022-03-10 Thread Penny Zheng
From: Penny Zheng This commit introduces process_shm to cope with static shared memory in domain construction. This commit only considers allocating static shared memory to dom_shared when owner domain is not explicitly defined in device tree, the other scenario will be covered in the following

[PATCH v1 04/13] xen/arm: add P2M type parameter in guest_physmap_add_pages

2022-03-10 Thread Penny Zheng
From: Penny Zheng In order to cover the scenario where users intend to set up guest p2m foreign mapping with nr_pages, this commit adds a new P2M type parameter in guest_physmap_add_pages. Signed-off-by: Penny Zheng --- xen/arch/arm/domain_build.c| 5 +++-- xen/arch/arm/include/asm/p2m.h |

[PATCH v1 05/13] xen/arm: introduce get_pages_from_gfn

2022-03-10 Thread Penny Zheng
From: Penny Zheng In order to getting statically shared pages based on gfn with nr_pages, this commit introduces a new helper get_pages_from_gfn to acquire a set of pages based on [gfn, gfn + nr_gfns), with the same P2M type. Signed-off-by: Penny Zheng --- xen/arch/arm/include/asm/p2m.h | 37 +

[PATCH v1 02/13] xen/arm: introduce a special domain DOMID_SHARED

2022-03-10 Thread Penny Zheng
From: Penny Zheng In case to own statically shared pages when owner domain is not explicitly defined, this commits propose a special domain DOMID_SHARED, and we assign it 0x7FF5, as one of the system domains. Statically shared memory reuses the same way of initialization with static memory, henc

[PATCH v1 00/13] Static shared memory on dom0less system

2022-03-10 Thread Penny Zheng
The static shared memory device tree nodes allow users to statically set up shared memory on dom0less system, enabling domains to do shm-based communication. The new feature is driven by the need of finding a way to build up communication channels on dom0less system, since the legacy ways includin

RE: [PATCH] design: design doc for shared memory on a dom0less system

2022-03-10 Thread Penny Zheng
Hi Julien Sorry for the late response, Since I'm considering sending the code together for better understanding. > -Original Message- > From: Julien Grall > Sent: Wednesday, January 26, 2022 6:58 PM > To: Penny Zheng ; xen-devel@lists.xenproject.org; > sstabell...@kernel.org > Cc: Bertr

BUG: libxenlight fails to grant permission to access Intel IGD Opregion

2022-03-10 Thread Chuck Zmudzinski
Hello, Below is a proposed patch for a bug that I have noticed on Debian versions of Xen going back to at least Xen 4.8, which shipped with Debian 9 in 2017. In fact, the last Debian version of Xen that did not have the bug was Xen 4.4 that shipped with Debian 8 back in 2015. The bug causes passt

[xen-4.16-testing test] 168503: tolerable FAIL - PUSHED

2022-03-10 Thread osstest service owner
flight 168503 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/168503/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 168484 test-amd64-amd64-xl-qemuu-win7-a

[ovmf test] 168508: regressions - FAIL

2022-03-10 Thread osstest service owner
flight 168508 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168508/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-10 Thread Stefano Stabellini
On Thu, 10 Mar 2022, Luca Fancellu wrote: > Introduce a way to create different cpupools at boot time, this is > particularly useful on ARM big.LITTLE system where there might be the > need to have different cpupools for each type of core, but also > systems using NUMA can have different cpu pools

Re: [PATCH v2 5/6] arm/dom0less: assign dom0less guests to cpupools

2022-03-10 Thread Stefano Stabellini
On Thu, 10 Mar 2022, Luca Fancellu wrote: > Introduce domain-cpupool property of a xen,domain device tree node, > that specifies the cpupool device tree handle of a xen,cpupool node > that identifies a cpupool created at boot time where the guest will > be assigned on creation. > > Add member to t

[xen-4.15-testing test] 168502: tolerable FAIL - PUSHED

2022-03-10 Thread osstest service owner
flight 168502 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/168502/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 19 guest-start.2fail REGR. vs. 168483 Tests which did not suc

Re: [XEN v10 4/4] xen/arm64: io: Handle data abort due to cache maintenance instructions

2022-03-10 Thread Stefano Stabellini
On Thu, 10 Mar 2022, Ayan Kumar Halder wrote: > When the data abort is caused due to cache maintenance for an address, > there are three scenarios:- > > 1. Address belonging to a non emulated region - For this, Xen should > set the corresponding bit in the translation table entry to valid and > re

Re: [XEN v10 3/4] xen/arm64: io: Handle the abort due to access to stage1 translation table

2022-03-10 Thread Stefano Stabellini
On Thu, 10 Mar 2022, Ayan Kumar Halder wrote: > If the abort was caused due to access to stage1 translation table, Xen > will try to set the p2m entry (assuming that the Stage 1 translation > table is in the non MMIO region). > If there is no such entry found, then Xen will try to map the address a

Re: [XEN v10 2/4] xen/arm64: io: Support instructions (for which ISS is not valid) on emulated MMIO region using MMIO/ioreq handler

2022-03-10 Thread Stefano Stabellini
On Thu, 10 Mar 2022, Ayan Kumar Halder wrote: > When an instruction is trapped in Xen due to translation fault, Xen > checks if the ISS is invalid (for data abort) or it is an instruction > abort. If so, Xen tries to resolve the translation fault using p2m page > tables. In case of data abort, Xen

Re: [XEN v10 1/4] xen/arm64: Decode ldr/str post increment operations

2022-03-10 Thread Stefano Stabellini
On Thu, 10 Mar 2022, Ayan Kumar Halder wrote: > At the moment, Xen does not decode any of the arm64 instructions. This > means that when hsr_dabt.isv == 0, Xen cannot handle those instructions. > This will lead to Xen to abort the guests (from which those instructions > originate). > > With this p

[xen-unstable-smoke test] 168509: tolerable all pass - PUSHED

2022-03-10 Thread osstest service owner
flight 168509 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/168509/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[PATCH] MAINTAINERS: Propose Henry Wang as the new release manager

2022-03-10 Thread George Dunlap
ARM has proposed Henry Wang as a release manager for 4.17. Signify this by giving him maintainership over CHANGELOG.md. Below is an introduction given by Bertrand Marquis: Henry Wang is an open-source software engineer at Arm focusing on the hypervisor and virtualization technology. Before joini

[qemu-mainline test] 168501: tolerable FAIL - PUSHED

2022-03-10 Thread osstest service owner
flight 168501 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/168501/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 168488 test-amd64-amd64-qemuu-nested-amd 2

[PATCH] x86/hvm: Include interruptibility state in hvm_hw_cpu

2022-03-10 Thread Tamas K Lengyel
During VM fork resetting a failed vmentry has been observed when the reset is performed immediately after a STI instruction executed. This is due to the guest interruptibility state in the VMCS being modified by STI but the subsequent reset removes the IF bit from FLAGS, causing the failed vmentry.

Re: [PATCH] x86/cet: Use dedicated NOP4 for cf_clobber

2022-03-10 Thread Andrew Cooper
On 08/03/2022 16:03, Andrew Cooper wrote: > --- a/xen/arch/x86/include/asm/endbr.h > +++ b/xen/arch/x86/include/asm/endbr.h > @@ -52,4 +52,16 @@ static inline void place_endbr64(void *ptr) > *(uint32_t *)ptr = gen_endbr64(); > } > > +/* > + * After clobbering

Re: [PATCH 4/4] livepatch: differentiate between old and new build systems

2022-03-10 Thread Andrew Cooper
On 08/03/2022 14:52, Roger Pau Monne wrote: > On Tue, Mar 08, 2022 at 02:38:47PM +, Andrew Cooper wrote: >> On 02/03/2022 14:27, Roger Pau Monne wrote: >>> diff --git a/livepatch-build b/livepatch-build >>> index 38a92be..656cdac 100755 >>> --- a/livepatch-build >>> +++ b/livepatch-build >>> @@

Re: preparations for 4.16.1

2022-03-10 Thread Stefano Stabellini
On Thu, 10 Mar 2022, Julien Grall wrote: > On 10/03/2022 10:02, Bertrand Marquis wrote: > > Hi, > > > On 10 Mar 2022, at 09:04, Julien Grall wrote: > > > On 10/03/2022 08:57, Jan Beulich wrote: > > > > the release is due in a few weeks time. > > > > Please point out backports you find missing from

[XEN v10 3/4] xen/arm64: io: Handle the abort due to access to stage1 translation table

2022-03-10 Thread Ayan Kumar Halder
If the abort was caused due to access to stage1 translation table, Xen will try to set the p2m entry (assuming that the Stage 1 translation table is in the non MMIO region). If there is no such entry found, then Xen will try to map the address as a MMIO region (assuming that the Stage 1 translation

[XEN v10 4/4] xen/arm64: io: Handle data abort due to cache maintenance instructions

2022-03-10 Thread Ayan Kumar Halder
When the data abort is caused due to cache maintenance for an address, there are three scenarios:- 1. Address belonging to a non emulated region - For this, Xen should set the corresponding bit in the translation table entry to valid and return to the guest to retry the instruction. This can happe

[XEN v10 2/4] xen/arm64: io: Support instructions (for which ISS is not valid) on emulated MMIO region using MMIO/ioreq handler

2022-03-10 Thread Ayan Kumar Halder
When an instruction is trapped in Xen due to translation fault, Xen checks if the ISS is invalid (for data abort) or it is an instruction abort. If so, Xen tries to resolve the translation fault using p2m page tables. In case of data abort, Xen will try to map the mmio region to the guest (ie tries

[XEN v10 1/4] xen/arm64: Decode ldr/str post increment operations

2022-03-10 Thread Ayan Kumar Halder
At the moment, Xen does not decode any of the arm64 instructions. This means that when hsr_dabt.isv == 0, Xen cannot handle those instructions. This will lead to Xen to abort the guests (from which those instructions originate). With this patch, Xen is able to decode ldr/str post indexing instruct

[XEN v10 0/4] xen/arm64: io: Decode ldr/str post-indexing instruction

2022-03-10 Thread Ayan Kumar Halder
Hi All, The patch series introduces support to decode instructions by Xen when ISS is invalid. Currently, when the guest executes post indexing ldr/str instructions on emulated MMIO, these instructions are trapped into Xen as a data abort. Xen reads hsr_dabt.isv == 0, so ISS is invalid. Therefore,

[ovmf test] 168504: regressions - FAIL

2022-03-10 Thread osstest service owner
flight 168504 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168504/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

Re: [PATCH 3/3] livepatch: correctly handle altinstruction sections

2022-03-10 Thread Doebel, Bjoern
On 10.03.22 16:08, Roger Pau Monne wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. The current handling of altinstructions sections by the livepatch tools is incor

Re: [PATCH 2/3] livepatch: add extra efi/ objects to be ignored

2022-03-10 Thread Doebel, Bjoern
On 10.03.22 16:08, Roger Pau Monne wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. The contents of this objects is init only, and cannot be patched. Signed-off-by

Re: [PATCH 1/3] livepatch: use basename to perform object file matching

2022-03-10 Thread Doebel, Bjoern
On 10.03.22 16:08, Roger Pau Monne wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. The changes in the Xen build logic has resulted in the compiler and objcopy bein

[PATCH v2 5/6] arm/dom0less: assign dom0less guests to cpupools

2022-03-10 Thread Luca Fancellu
Introduce domain-cpupool property of a xen,domain device tree node, that specifies the cpupool device tree handle of a xen,cpupool node that identifies a cpupool created at boot time where the guest will be assigned on creation. Add member to the xen_domctl_createdomain public interface so the XEN

[PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-10 Thread Luca Fancellu
Introduce a way to create different cpupools at boot time, this is particularly useful on ARM big.LITTLE system where there might be the need to have different cpupools for each type of core, but also systems using NUMA can have different cpu pools for each node. The feature on arm relies on a spe

[PATCH v2 6/6] xen/cpupool: Allow cpupool0 to use different scheduler

2022-03-10 Thread Luca Fancellu
Currently cpupool0 can use only the default scheduler, and cpupool_create has an harcoded behavior when creating the pool 0 that doesn't allocate new memory for the scheduler, but uses the default scheduler structure in memory. With this commit it is possible to allocate a different scheduler for

[PATCH v2 3/6] xen/sched: retrieve scheduler id by name

2022-03-10 Thread Luca Fancellu
Add a static function to retrieve the scheduler pointer using the scheduler name. Add a public function to retrieve the scheduler id by the scheduler name that makes use of the new static function. Take the occasion to replace open coded scheduler search with the new static function in scheduler_

[PATCH v2 0/6] Boot time cpupools

2022-03-10 Thread Luca Fancellu
This serie introduces a feature for Xen to create cpu pools at boot time, the feature is enabled using a configurable that is disabled by default. The boot time cpupool feature relies on the device tree to describe the cpu pools. Another feature is introduced by the serie, the possibility to assign

[PATCH v2 1/6] tools/cpupools: Give a name to unnamed cpupools

2022-03-10 Thread Luca Fancellu
With the introduction of boot time cpupools, Xen can create many different cpupools at boot time other than cpupool with id 0. Since these newly created cpupools can't have an entry in Xenstore, create the entry using xen-init-dom0 helper with the usual convention: Pool-. Given the change, remove

[PATCH v2 2/6] xen/sched: create public function for cpupools creation

2022-03-10 Thread Luca Fancellu
Create new public function to create cpupools, can take as parameter the scheduler id or a negative value that means the default Xen scheduler will be used. Signed-off-by: Luca Fancellu --- Changes in v2: - cpupool_create_pool doesn't check anymore for pool id uniqueness before calling cpupool_

Re: [PATCH 2/3] amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests

2022-03-10 Thread Roger Pau Monné
On Mon, Feb 14, 2022 at 05:02:52PM +0100, Jan Beulich wrote: > On 01.02.2022 17:46, Roger Pau Monne wrote: > > --- a/xen/arch/x86/hvm/svm/entry.S > > +++ b/xen/arch/x86/hvm/svm/entry.S > > @@ -71,7 +71,9 @@ __UNLIKELY_END(nsvm_hap) > > mov%al, CPUINFO_last_spec_ctrl(%rsp) > > 1:

Re: [PATCH 1/2] ns16550: reject IRQ above nr_irqs

2022-03-10 Thread Marek Marczykowski-Górecki
On Thu, Mar 10, 2022 at 04:21:50PM +, Julien Grall wrote: > Hi, > > On 10/03/2022 16:12, Roger Pau Monné wrote: > > On Thu, Mar 10, 2022 at 05:08:07PM +0100, Jan Beulich wrote: > > > On 10.03.2022 16:47, Roger Pau Monné wrote: > > > > On Thu, Mar 10, 2022 at 04:23:00PM +0100, Jan Beulich wrote

Re: [PATCH 1/2] ns16550: reject IRQ above nr_irqs

2022-03-10 Thread Jan Beulich
On 10.03.2022 17:21, Julien Grall wrote: > On 10/03/2022 16:12, Roger Pau Monné wrote: >> On Thu, Mar 10, 2022 at 05:08:07PM +0100, Jan Beulich wrote: >>> On 10.03.2022 16:47, Roger Pau Monné wrote: On Thu, Mar 10, 2022 at 04:23:00PM +0100, Jan Beulich wrote: > On 10.03.2022 15:34, Marek M

Re: [PATCH] x86/vmx: remove dead code to create domains without a vLAPIC

2022-03-10 Thread Jan Beulich
On 15.02.2022 14:27, Jan Beulich wrote: > On 15.02.2022 12:28, Roger Pau Monne wrote: >> After the removal of PVHv1 it's no longer supported to create a domain >> using hardware virtualization extensions and without a local APIC: >> PVHv2 mandates domains to always have a LAPIC. Remove some stale c

Re: [PATCH 1/2] ns16550: reject IRQ above nr_irqs

2022-03-10 Thread Julien Grall
Hi, On 10/03/2022 16:12, Roger Pau Monné wrote: On Thu, Mar 10, 2022 at 05:08:07PM +0100, Jan Beulich wrote: On 10.03.2022 16:47, Roger Pau Monné wrote: On Thu, Mar 10, 2022 at 04:23:00PM +0100, Jan Beulich wrote: On 10.03.2022 15:34, Marek Marczykowski-Górecki wrote: --- a/xen/drivers/char/

Re: [PATCH 1/2] ns16550: reject IRQ above nr_irqs

2022-03-10 Thread Roger Pau Monné
On Thu, Mar 10, 2022 at 05:08:07PM +0100, Jan Beulich wrote: > On 10.03.2022 16:47, Roger Pau Monné wrote: > > On Thu, Mar 10, 2022 at 04:23:00PM +0100, Jan Beulich wrote: > >> On 10.03.2022 15:34, Marek Marczykowski-Górecki wrote: > >>> --- a/xen/drivers/char/ns16550.c > >>> +++ b/xen/drivers/char

Re: [PATCH 1/2] ns16550: reject IRQ above nr_irqs

2022-03-10 Thread Jan Beulich
On 10.03.2022 16:47, Roger Pau Monné wrote: > On Thu, Mar 10, 2022 at 04:23:00PM +0100, Jan Beulich wrote: >> On 10.03.2022 15:34, Marek Marczykowski-Górecki wrote: >>> --- a/xen/drivers/char/ns16550.c >>> +++ b/xen/drivers/char/ns16550.c >>> @@ -1221,6 +1221,9 @@ pci_uart_config(struct ns16550 *ua

Re: [PATCH v2 1/3] xen/vpci: msix: move x86 specific code to x86 file

2022-03-10 Thread Roger Pau Monné
On Thu, Mar 10, 2022 at 11:48:15AM +, Rahul Singh wrote: > Hello Roger, > > > On 9 Mar 2022, at 4:06 pm, Roger Pau Monné wrote: > > > > On Wed, Mar 09, 2022 at 03:50:12PM +, Rahul Singh wrote: > >> Hi Jan, > >> > >>> On 9 Mar 2022, at 10:17 am, Jan Beulich wrote: > >>> > >>> On 09.03.

Re: [PATCH 1/2] ns16550: reject IRQ above nr_irqs

2022-03-10 Thread Roger Pau Monné
On Thu, Mar 10, 2022 at 04:23:00PM +0100, Jan Beulich wrote: > On 10.03.2022 15:34, Marek Marczykowski-Górecki wrote: > > --- a/xen/drivers/char/ns16550.c > > +++ b/xen/drivers/char/ns16550.c > > @@ -1221,6 +1221,9 @@ pci_uart_config(struct ns16550 *uart, bool_t > > skip_amt, unsigned int idx) > >

[linux-linus test] 168498: tolerable FAIL - PUSHED

2022-03-10 Thread osstest service owner
flight 168498 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/168498/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds18 guest-start/debian.repeat fail REGR. vs. 168466 Tests which did not succeed,

Re: [PATCH 1/2] ns16550: reject IRQ above nr_irqs

2022-03-10 Thread Jan Beulich
On 10.03.2022 15:34, Marek Marczykowski-Górecki wrote: > --- a/xen/drivers/char/ns16550.c > +++ b/xen/drivers/char/ns16550.c > @@ -1221,6 +1221,9 @@ pci_uart_config(struct ns16550 *uart, bool_t skip_amt, > unsigned int idx) > pci_conf_read8(PCI_SBDF(0, b, d, f), >

[PATCH 0/3] livepatch: further fixes

2022-03-10 Thread Roger Pau Monne
Hello, The following series does some more cleanup after the Xen hypervisor build changes (patches 1 and 2). Patch 3 fixes handling of .altinstr* sections. Thanks, Roger. Roger Pau Monne (3): livepatch: use basename to perform object file matching livepatch: add extra efi/ objects to be igno

[PATCH 2/3] livepatch: add extra efi/ objects to be ignored

2022-03-10 Thread Roger Pau Monne
The contents of this objects is init only, and cannot be patched. Signed-off-by: Roger Pau Monné --- livepatch-gcc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/livepatch-gcc b/livepatch-gcc index fe782e0..b0b9ce4 100755 --- a/livepatch-gcc +++ b/livepatch-gcc @@ -66,6 +66,8 @@ elif [[ "

[PATCH 1/3] livepatch: use basename to perform object file matching

2022-03-10 Thread Roger Pau Monne
The changes in the Xen build logic has resulted in the compiler and objcopy being called from xen/ instead of relative to each object directory. This requires using basename so that the directory is not taken into account when checking against the list of files to be explicitly ignored. Also adjus

[PATCH 3/3] livepatch: correctly handle altinstruction sections

2022-03-10 Thread Roger Pau Monne
The current handling of altinstructions sections by the livepatch tools is incorrect, as on Xen those sections are part of .init and thus discarded after load. Correctly handle them by just ignoring, as it's done with other .init related sections. While there also add .data.ro_after_init section a

[PATCH 2/2] ns16550: Add support for Intel LPSS UART

2022-03-10 Thread Marek Marczykowski-Górecki
This adds support for serial console as found in a laptop with TGL-LP (StarBook MkV). Since the device is on the bus 0, it needs to be enabled via "com1=...,amt", not just "...,pci". Device specification is in Intel docs 631119-007 and 631120-001. Signed-off-by: Marek Marczykowski-Górecki --- Th

[PATCH 1/2] ns16550: reject IRQ above nr_irqs

2022-03-10 Thread Marek Marczykowski-Górecki
Intel LPSS has INTERRUPT_LINE set to 0xff by default, that can't possibly work. While a proper IRQ configuration may be useful, validating value retrieved from the hardware is still necessary. If it fails, use the device in poll mode. Signed-off-by: Marek Marczykowski-Górecki --- xen/drivers/cha

[xen-4.14-testing test] 168493: FAIL

2022-03-10 Thread osstest service owner
flight 168493 xen-4.14-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/168493/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-vhd broken in 168482 Tests

[libvirt test] 168500: regressions - FAIL

2022-03-10 Thread osstest service owner
flight 168500 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/168500/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

alternatives+livepatch testing

2022-03-10 Thread Andrew Cooper
Hello, The recent hiccup with CET-IBT, and discovery that livepatch-build-tools have been broken for several releases, demonstrates that we do not have remotely adequate testing in place.  We need to address, and ensure we don't end up in the same position again. Alternatives and Livepatching hav

Xen Security Advisory 396 v3 (CVE-2022-23036,CVE-2022-23037,CVE-2022-23038,CVE-2022-23039,CVE-2022-23040,CVE-2022-23041,CVE-2022-23042) - Linux PV device frontends vulnerable to attacks by backends

2022-03-10 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2022-23036,CVE-2022-23037,CVE-2022-23038,CVE-2022-23039,CVE-2022-23040,CVE-2022-23041,CVE-2022-23042 / XSA-396 version 3 Linux PV device frontends vu

Re: preparations for 4.16.1

2022-03-10 Thread Jan Beulich
On 10.03.2022 12:14, Andrew Cooper wrote: > On 10/03/2022 10:35, Jan Beulich wrote: >> On 10.03.2022 11:20, Andrew Cooper wrote: >>> On 10/03/2022 09:01, Jan Beulich wrote: On 10.03.2022 09:57, Jan Beulich wrote: > Please point out backports you find missing from the respective staging >>>

Re: [PATCH v2 1/3] xen/vpci: msix: move x86 specific code to x86 file

2022-03-10 Thread Rahul Singh
Hello Roger, > On 9 Mar 2022, at 4:06 pm, Roger Pau Monné wrote: > > On Wed, Mar 09, 2022 at 03:50:12PM +, Rahul Singh wrote: >> Hi Jan, >> >>> On 9 Mar 2022, at 10:17 am, Jan Beulich wrote: >>> >>> On 09.03.2022 11:08, Rahul Singh wrote: Hi Jan, > On 4 Mar 2022, at 7:23 am

Re: preparations for 4.16.1

2022-03-10 Thread Andrew Cooper
On 10/03/2022 10:35, Jan Beulich wrote: > On 10.03.2022 11:20, Andrew Cooper wrote: >> On 10/03/2022 09:01, Jan Beulich wrote: >>> On 10.03.2022 09:57, Jan Beulich wrote: Please point out backports you find missing from the respective staging branch, but which you consider relevant. One I

Re: preparations for 4.16.1

2022-03-10 Thread Julien Grall
On 10/03/2022 10:02, Bertrand Marquis wrote: Hi, Hi Bertrand, On 10 Mar 2022, at 09:04, Julien Grall wrote: On 10/03/2022 08:57, Jan Beulich wrote: the release is due in a few weeks time. Please point out backports you find missing from the respective staging branch, but which you consid

[xen-unstable test] 168491: tolerable FAIL - PUSHED

2022-03-10 Thread osstest service owner
flight 168491 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/168491/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 15 saverestore-support-checkfail like 168470 test-amd64-amd64-xl-qemut-win7-amd64

Re: preparations for 4.16.1

2022-03-10 Thread Jan Beulich
On 10.03.2022 11:20, Andrew Cooper wrote: > On 10/03/2022 09:01, Jan Beulich wrote: >> On 10.03.2022 09:57, Jan Beulich wrote: >>> Please point out backports you find missing from the respective staging >>> branch, but which you consider relevant. One I have queued already, but >>> which I'd like t

[ovmf test] 168496: regressions - FAIL

2022-03-10 Thread osstest service owner
flight 168496 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168496/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

Re: preparations for 4.16.1

2022-03-10 Thread Andrew Cooper
On 10/03/2022 09:01, Jan Beulich wrote: > On 10.03.2022 09:57, Jan Beulich wrote: >> Please point out backports you find missing from the respective staging >> branch, but which you consider relevant. One I have queued already, but >> which I'd like to put in only once the pending fix to it ("x86:

Re: preparations for 4.16.1

2022-03-10 Thread Bertrand Marquis
> On 10 Mar 2022, at 10:02, Bertrand Marquis wrote: > > Hi, > > >> On 10 Mar 2022, at 09:04, Julien Grall wrote: >> >> On 10/03/2022 08:57, Jan Beulich wrote: >>> All, >> >> Hi, >> >>> the release is due in a few weeks time. >>> Please point out backports you find missing from the respec

Re: preparations for 4.16.1

2022-03-10 Thread Bertrand Marquis
Hi, > On 10 Mar 2022, at 09:04, Julien Grall wrote: > > On 10/03/2022 08:57, Jan Beulich wrote: >> All, > > Hi, > >> the release is due in a few weeks time. >> Please point out backports you find missing from the respective staging >> branch, but which you consider relevant. One I have queued

Re: preparations for 4.16.1

2022-03-10 Thread Julien Grall
On 10/03/2022 08:57, Jan Beulich wrote: All, Hi, the release is due in a few weeks time. Please point out backports you find missing from the respective staging branch, but which you consider relevant. One I have queued already, but which I'd like to put in only once the pending fix to it ("

Re: preparations for 4.16.1

2022-03-10 Thread Jan Beulich
On 10.03.2022 09:57, Jan Beulich wrote: > Please point out backports you find missing from the respective staging > branch, but which you consider relevant. One I have queued already, but > which I'd like to put in only once the pending fix to it ("x86: avoid > SORT_BY_INIT_PRIORITY with old GNU ld

preparations for 4.16.1

2022-03-10 Thread Jan Beulich
All, the release is due in a few weeks time. Please point out backports you find missing from the respective staging branch, but which you consider relevant. One I have queued already, but which I'd like to put in only once the pending fix to it ("x86: avoid SORT_BY_INIT_PRIORITY with old GNU ld"