[libvirt test] 168522: regressions - FAIL

2022-03-11 Thread osstest service owner
flight 168522 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/168522/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

[ovmf test] 168521: regressions - FAIL

2022-03-11 Thread osstest service owner
flight 168521 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168521/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

[ovmf test] 168519: regressions - FAIL

2022-03-11 Thread osstest service owner
flight 168519 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168519/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

Re: statistical time calibration

2022-03-11 Thread Colin Percival
Hi everyone, On 3/11/22 07:29, Roger Pau Monné wrote: On Tue, Jan 18, 2022 at 04:03:56PM +0100, Jan Beulich wrote: 1) When deciding whether to increment "passes", both variance values have an arbitrary value of 4 added to them. There's a sentence about this in the earlier (big) comment, but it

[linux-5.4 test] 168515: tolerable FAIL - PUSHED

2022-03-11 Thread osstest service owner
flight 168515 linux-5.4 real [real] flight 168520 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/168515/ http://logs.test-lab.xenproject.org/osstest/logs/168520/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd6

Re: [PATCH] arm/xen: Fix refcount leak in xen_dt_guest_init

2022-03-11 Thread Stefano Stabellini
On Wed, 9 Mar 2022, Miaoqian Lin wrote: > The of_find_compatible_node() function returns a node pointer with > refcount incremented, We should use of_node_put() on it when done > Add the missing of_node_put() to release the refcount. > > Fixes: 9b08aaa3199a ("ARM: XEN: Move xen_early_init() before

Re: [PATCH early-RFC 4/5] xen/arm: mm: Rework switch_ttbr()

2022-03-11 Thread Stefano Stabellini
On Wed, 9 Mar 2022, Julien Grall wrote: > From: Julien Grall > > At the moment, switch_ttbr() is switching the TTBR whilst the MMU is > still on. > > Switching TTBR is like replacing existing mappings with new ones. So > we need to follow the break-before-make sequence. > > In this case, it mea

Re: [PATCH early-RFC 4/5] xen/arm: mm: Rework switch_ttbr()

2022-03-11 Thread Stefano Stabellini
On Wed, 9 Mar 2022, Julien Grall wrote: > From: Julien Grall > > At the moment, switch_ttbr() is switching the TTBR whilst the MMU is > still on. > > Switching TTBR is like replacing existing mappings with new ones. So > we need to follow the break-before-make sequence. > > In this case, it mea

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-11 Thread Stefano Stabellini
On Fri, 11 Mar 2022, Luca Fancellu wrote: > > On Thu, 10 Mar 2022, Luca Fancellu wrote: > >> Introduce a way to create different cpupools at boot time, this is > >> particularly useful on ARM big.LITTLE system where there might be the > >> need to have different cpupools for each type of core, but

[xen-4.16-testing test] 168513: tolerable FAIL - PUSHED

2022-03-11 Thread osstest service owner
flight 168513 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/168513/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 168503 test-amd64-amd64-xl-qemuu-win7-a

Re: [PATCH 28/36] xen/arm: introduce xen_map_text_rw

2022-03-11 Thread Julien Grall
Hi, On 07/03/2022 07:39, Jan Beulich wrote: On 04.03.2022 18:46, Marco Solieri wrote: From: Luca Miccio Introduce two new arm specific functions to temporarily map/unmap the Xen text read-write (the Xen text is mapped read-only by default by setup_pagetables): xen_map_text_rw and xen_unmap_te

Re: BUG: libxenlight fails to grant permission to access Intel IGD Opregion

2022-03-11 Thread Chuck Zmudzinski
On 3/11/22 8:47 AM, Chuck Zmudzinski wrote: > On 3/11/2022 3:09 AM, Jan Beulich wrote: >> >> Thanks for this analysis. It looks quite plausible (but the question >> of 2 vs 3 pages of course needs resolving). >> >> >> > > After resolving the question of two vs. three pages, I will follow > the pro

[PATCH] Livepatch: fix typos

2022-03-11 Thread Bjoern Doebel
Fix a couple of typos in livepatch code. Signed-off-by: Bjoern Doebel CC: Konrad Rzeszutek Wilk CC: Ross Lagerwall --- xen/arch/x86/livepatch.c | 2 +- xen/common/livepatch.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/xen/arch/x86/livepatch.c b/xen/arch/

Re: [PATCH 17/36] xen/arm: add get_max_color function

2022-03-11 Thread Julien Grall
Hi Marco, On 04/03/2022 17:46, Marco Solieri wrote: From: Luca Miccio In order to initialize the colored allocator data structure, the maximum amount of colors defined by the hardware has to be know. Add a helper function that returns this information. Signed-off-by: Luca Miccio --- xen/ar

Re: [PATCH 12/36] xen/arm: initialize cache coloring data for Dom0/U

2022-03-11 Thread Julien Grall
Hi, On 04/03/2022 17:46, Marco Solieri wrote: From: Luca Miccio Initialize cache coloring configuration during domain creation. If no colors assignment is provided by the user, use the default one. The default configuration is the one assigned to Dom0. The latter is configured as a standard do

Re: [XEN v10 4/4] xen/arm64: io: Handle data abort due to cache maintenance instructions

2022-03-11 Thread Julien Grall
Hi, On 11/03/2022 13:21, Ayan Kumar Halder wrote: enum io_state try_handle_mmio(struct cpu_user_regs *regs,   mmio_info_t *info) {     struct vcpu *v = current;     const struct mmio_handler *handler = NULL;     int rc;     ASSERT(info->dabt.ec == HSR_EC_DATA_AB

Re: [XEN v10 4/4] xen/arm64: io: Handle data abort due to cache maintenance instructions

2022-03-11 Thread Julien Grall
Hi, On 10/03/2022 17:45, Ayan Kumar Halder wrote: When the data abort is caused due to cache maintenance for an address, there are three scenarios:- 1. Address belonging to a non emulated region - For this, Xen should set the corresponding bit in the translation table entry to valid and return

Re: [XEN v10 3/4] xen/arm64: io: Handle the abort due to access to stage1 translation table

2022-03-11 Thread Julien Grall
Hi, On 10/03/2022 17:45, Ayan Kumar Halder wrote: If the abort was caused due to access to stage1 translation table, Xen will try to set the p2m entry (assuming that the Stage 1 translation table is in the non MMIO region). If there is no such entry found, then Xen will try to map the address as

Re: [XEN v10 2/4] xen/arm64: io: Support instructions (for which ISS is not valid) on emulated MMIO region using MMIO/ioreq handler

2022-03-11 Thread Julien Grall
Hi, On 10/03/2022 17:44, Ayan Kumar Halder wrote: When an instruction is trapped in Xen due to translation fault, Xen checks if the ISS is invalid (for data abort) or it is an instruction abort. If so, Xen tries to resolve the translation fault using p2m page tables. In case of data abort, Xen w

Re: [PATCH 16/36] xen/color alloc: implement color_from_page for ARM64

2022-03-11 Thread Julien Grall
Hi Marco, On 11/03/2022 17:39, Marco Solieri wrote: On Fri, Mar 04, 2022 at 08:54:35PM +, Julien Grall wrote: On 04/03/2022 17:46, Marco Solieri wrote: The colored allocator should not make any assumptions on how a color is defined, since the definition may change depending on the architec

Re: [PATCH 16/36] xen/color alloc: implement color_from_page for ARM64

2022-03-11 Thread Marco Solieri
On Fri, Mar 04, 2022 at 08:54:35PM +, Julien Grall wrote: > On 04/03/2022 17:46, Marco Solieri wrote: > > The colored allocator should not make any assumptions on how a color > > is defined, since the definition may change depending on the > > architecture. > IIUC, you are saying that the mappi

[qemu-mainline test] 168510: tolerable FAIL - PUSHED

2022-03-11 Thread osstest service owner
flight 168510 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/168510/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 168501 test-amd64-amd64-qemuu-nested-amd 2

[ovmf test] 168512: regressions - FAIL

2022-03-11 Thread osstest service owner
flight 168512 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168512/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

Re: [PATCH 1/2] ns16550: reject IRQ above nr_irqs

2022-03-11 Thread Marek Marczykowski-Górecki
On Fri, Mar 11, 2022 at 04:43:22PM +0100, Roger Pau Monné wrote: > Sorry, maybe this wasn't clear. My suggestion was not to just do this > fix and call it done, but rather to add this check for sanity and then > figure out how to properly handle this specific device. Yes, I agree. Having it proper

Re: [PATCH 1/2] ns16550: reject IRQ above nr_irqs

2022-03-11 Thread Roger Pau Monné
On Fri, Mar 11, 2022 at 03:19:22PM +, Julien Grall wrote: > Hi Roger, > > On 11/03/2022 15:04, Roger Pau Monné wrote: > > On Fri, Mar 11, 2022 at 11:15:13AM +, Julien Grall wrote: > > > Hi, > > > > > > On 11/03/2022 10:52, Marek Marczykowski-Górecki wrote: > > > > On Fri, Mar 11, 2022 at

Re: statistical time calibration

2022-03-11 Thread Roger Pau Monné
On Tue, Jan 18, 2022 at 04:03:56PM +0100, Jan Beulich wrote: > Hello, > > Roger pointer me to a FreeBSD commit [1] introducing such there. While > we don't start at 2000ms (but rather at 50), this still looked interesting > enough to take a closer look. I think I've mostly understood the idea and

[PATCH v7 0/2] xen: Report and use hardware APIC virtualization capabilities

2022-03-11 Thread Jane Malalane
Jane Malalane (2): xen+tools: Report Interrupt Controller Virtualization capabilities on x86 x86/xen: Allow per-domain usage of hardware virtualized APIC docs/man/xl.cfg.5.pod.in | 15 ++ docs/man/xl.conf.5.pod.in | 12 +++ tools/golang/xenligh

[PATCH v7 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC

2022-03-11 Thread Jane Malalane
Introduce a new per-domain creation x86 specific flag to select whether hardware assisted virtualization should be used for x{2}APIC. A per-domain option is added to xl in order to select the usage of x{2}APIC hardware assisted virtualization, as well as a global configuration option. Having all

[PATCH v7 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86

2022-03-11 Thread Jane Malalane
Add XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC and XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC to report accelerated xapic and x2apic, on x86 hardware. No such features are currently implemented on AMD hardware. HW assisted xAPIC virtualization will be reported if HW, at the minimum, supports virtualize_api

Re: [PATCH 1/2] ns16550: reject IRQ above nr_irqs

2022-03-11 Thread Julien Grall
Hi Roger, On 11/03/2022 15:04, Roger Pau Monné wrote: On Fri, Mar 11, 2022 at 11:15:13AM +, Julien Grall wrote: Hi, On 11/03/2022 10:52, Marek Marczykowski-Górecki wrote: On Fri, Mar 11, 2022 at 10:23:03AM +, Julien Grall wrote: Hi Marek, On 10/03/2022 16:37, Marek Marczykowski-Góre

Re: [PATCH v6 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86

2022-03-11 Thread Jane Malalane
On 09/03/2022 10:36, Roger Pau Monné wrote: > On Tue, Mar 08, 2022 at 05:31:17PM +, Jane Malalane wrote: >> Add XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC and >> XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC to report accelerated xapic >> and x2apic, on x86 hardware. >> No such features are currently imple

[PATCH v7 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC

2022-03-11 Thread Jane Malalane
Introduce a new per-domain creation x86 specific flag to select whether hardware assisted virtualization should be used for x{2}APIC. A per-domain option is added to xl in order to select the usage of x{2}APIC hardware assisted virtualization, as well as a global configuration option. Having all

Re: [PATCH v2] x86: avoid SORT_BY_INIT_PRIORITY with old GNU ld

2022-03-11 Thread Roger Pau Monné
On Fri, Mar 11, 2022 at 03:55:57PM +0100, Jan Beulich wrote: > On 11.03.2022 15:34, Roger Pau Monné wrote: > > On Fri, Mar 11, 2022 at 02:28:40PM +0100, Jan Beulich wrote: > >> Support for this construct was added in 2.22 only. Avoid the need to > >> introduce logic to probe for linker script capab

[PATCH v7 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86

2022-03-11 Thread Jane Malalane
Add XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC and XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC to report accelerated xapic and x2apic, on x86 hardware. No such features are currently implemented on AMD hardware. HW assisted xAPIC virtualization will be reported if HW, at the minimum, supports virtualize_api

Re: [PATCH 1/2] ns16550: reject IRQ above nr_irqs

2022-03-11 Thread Roger Pau Monné
On Fri, Mar 11, 2022 at 11:15:13AM +, Julien Grall wrote: > Hi, > > On 11/03/2022 10:52, Marek Marczykowski-Górecki wrote: > > On Fri, Mar 11, 2022 at 10:23:03AM +, Julien Grall wrote: > > > Hi Marek, > > > > > > On 10/03/2022 16:37, Marek Marczykowski-Górecki wrote: > > > > On Thu, Mar 1

Re: [PATCH v3] x86/build: use --orphan-handling linker option if available

2022-03-11 Thread Roger Pau Monné
On Fri, Mar 11, 2022 at 01:37:54PM +0100, Jan Beulich wrote: > As was e.g. making necessary 4b7fd8153ddf ("x86: fold sections in final > binaries"), arbitrary sections appearing without our linker script > placing them explicitly can be a problem. Have the linker make us aware > of such sections, s

Re: [PATCH v2] x86: avoid SORT_BY_INIT_PRIORITY with old GNU ld

2022-03-11 Thread Jan Beulich
On 11.03.2022 15:34, Roger Pau Monné wrote: > On Fri, Mar 11, 2022 at 02:28:40PM +0100, Jan Beulich wrote: >> Support for this construct was added in 2.22 only. Avoid the need to >> introduce logic to probe for linker script capabilities by (ab)using the >> probe for a command line option having ap

[linux-linus test] 168507: tolerable FAIL - PUSHED

2022-03-11 Thread osstest service owner
flight 168507 linux-linus real [real] flight 168517 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/168507/ http://logs.test-lab.xenproject.org/osstest/logs/168517/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-

Re: [PATCH v2] x86: avoid SORT_BY_INIT_PRIORITY with old GNU ld

2022-03-11 Thread Roger Pau Monné
On Fri, Mar 11, 2022 at 02:28:40PM +0100, Jan Beulich wrote: > Support for this construct was added in 2.22 only. Avoid the need to > introduce logic to probe for linker script capabilities by (ab)using the > probe for a command line option having appeared at about the same time. > > Fixes: 4b7fd8

Re: [PATCH v3 4/4] x86/APIC: make connections between seemingly arbitrary numbers

2022-03-11 Thread Roger Pau Monné
On Mon, Feb 14, 2022 at 10:25:57AM +0100, Jan Beulich wrote: > Making adjustments to arbitrarily chosen values shouldn't require > auditing the code for possible derived numbers - such a change should > be doable in a single place, having an effect on all code depending on > that choice. > > For o

Re: [PATCH] x86/xen: Fix kerneldoc warning

2022-03-11 Thread Boris Ostrovsky
On 3/7/22 1:25 AM, Jiapeng Chong wrote: Fix the following W=1 kernel warnings: arch/x86/xen/setup.c:725: warning: expecting prototype for machine_specific_memory_setup(). Prototype was for xen_memory_setup() instead. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Reviewed-by: Bori

Re: [PATCH] drivers/xen: use helper macro __ATTR_RW

2022-03-11 Thread Boris Ostrovsky
On 3/5/22 8:38 AM, zhanglianjie wrote: Use helper macro __ATTR_RW to define HYPERVISOR_ATTR_RW to make code more clear. Minor readability improvement. Signed-off-by: zhanglianjie Reviewed-by: Boris Ostrovsky Applied to for-linus-5.18 (with whitespace change noted in commit message)

Re: [PATCH v4 2/2] xen: delay xen_hvm_init_time_ops() if kdump is boot on vcpu>=32

2022-03-11 Thread Boris Ostrovsky
On 3/2/22 11:40 AM, Dongli Zhang wrote: The sched_clock() can be used very early since commit 857baa87b642 ("sched/clock: Enable sched clock early"). In addition, with commit 38669ba205d1 ("x86/xen/time: Output xen sched_clock time from 0"), kdump kernel in Xen HVM guest may panic at very early

Re: [PATCH] xen: use time_is_before_eq_jiffies() instead of open coding it

2022-03-11 Thread Boris Ostrovsky
On 2/27/22 10:15 PM, Qing Wang wrote: From: Wang Qing Use the helper function time_is_{before,after}_jiffies() to improve code readability. Signed-off-by: Wang Qing Reviewed-by: Boris Ostrovsky Applied to for-linus-5.18

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-11 Thread Luca Fancellu
> On 11 Mar 2022, at 14:11, Luca Fancellu wrote: > > Hi Stefano, > >> On 11 Mar 2022, at 03:57, Stefano Stabellini wrote: >> >> On Thu, 10 Mar 2022, Luca Fancellu wrote: >>> Introduce a way to create different cpupools at boot time, this is >>> particularly useful on ARM big.LITTLE system wh

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-11 Thread Luca Fancellu
Hi Stefano, > On 11 Mar 2022, at 03:57, Stefano Stabellini wrote: > > On Thu, 10 Mar 2022, Luca Fancellu wrote: >> Introduce a way to create different cpupools at boot time, this is >> particularly useful on ARM big.LITTLE system where there might be the >> need to have different cpupools for ea

Re: [PATCH v3 3/4] x86/APIC: skip unnecessary parts of __setup_APIC_LVTT()

2022-03-11 Thread Roger Pau Monné
On Mon, Feb 14, 2022 at 10:25:31AM +0100, Jan Beulich wrote: > In TDT mode there's no point writing TDCR or TMICT, while outside of > that mode there's no need for the MFENCE. > > No change intended to overall functioning. > > Signed-off-by: Jan Beulich I've got some comments below, now that th

[libvirt test] 168511: regressions - FAIL

2022-03-11 Thread osstest service owner
flight 168511 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/168511/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

Re: BUG: libxenlight fails to grant permission to access Intel IGD Opregion

2022-03-11 Thread Chuck Zmudzinski
On 3/11/2022 3:09 AM, Jan Beulich wrote: On 11.03.2022 06:01, Chuck Zmudzinski wrote: Further research showed that these two pages at 0xcc490 are for the Intel IGD opregion, and because this memory is not permitted to be accessed by the domain, the passthrough of an Intel IGD to a Linux HVM doma

Re: [PATCH v3 2/4] x86/APIC: calibrate against platform timer when possible

2022-03-11 Thread Roger Pau Monné
On Mon, Feb 14, 2022 at 10:25:11AM +0100, Jan Beulich wrote: > Use the original calibration against PIT only when the platform timer > is PIT. This implicitly excludes the "xen_guest" case from using the PIT > logic (init_pit() fails there, and as of 5e73b2594c54 ["x86/time: minor > adjustments to

[PATCH v2] x86: avoid SORT_BY_INIT_PRIORITY with old GNU ld

2022-03-11 Thread Jan Beulich
Support for this construct was added in 2.22 only. Avoid the need to introduce logic to probe for linker script capabilities by (ab)using the probe for a command line option having appeared at about the same time. Fixes: 4b7fd8153ddf ("x86: fold sections in final binaries") Signed-off-by: Jan Beul

Re: [XEN v10 4/4] xen/arm64: io: Handle data abort due to cache maintenance instructions

2022-03-11 Thread Ayan Kumar Halder
Hi Stefano, On 11/03/2022 02:25, Stefano Stabellini wrote: On Thu, 10 Mar 2022, Ayan Kumar Halder wrote: When the data abort is caused due to cache maintenance for an address, there are three scenarios:- 1. Address belonging to a non emulated region - For this, Xen should set the corresponding

[PATCH v3] x86/build: use --orphan-handling linker option if available

2022-03-11 Thread Jan Beulich
As was e.g. making necessary 4b7fd8153ddf ("x86: fold sections in final binaries"), arbitrary sections appearing without our linker script placing them explicitly can be a problem. Have the linker make us aware of such sections, so we would know that the script needs adjusting. To deal with the re

Re: [PATCH v3 1/4] x86/time: further improve TSC / CPU freq calibration accuracy

2022-03-11 Thread Jan Beulich
On 11.03.2022 13:03, Roger Pau Monné wrote: > On Mon, Feb 14, 2022 at 10:24:49AM +0100, Jan Beulich wrote: >> Calibration logic assumes that the platform timer (HPET or ACPI PM >> timer) and the TSC are read at about the same time. This assumption may >> not hold when a long latency event (e.g. SMI

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-11 Thread Jan Beulich
On 11.03.2022 12:29, Luca Fancellu wrote: >> On 11 Mar 2022, at 10:18, Juergen Gross wrote: >> On 11.03.22 10:46, Jan Beulich wrote: >>> On 11.03.2022 10:29, Juergen Gross wrote: On 11.03.22 09:56, Luca Fancellu wrote: >> On 11 Mar 2022, at 08:09, Juergen Gross wrote: >> On 10.03.22

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-11 Thread Juergen Gross
On 11.03.22 12:29, Luca Fancellu wrote: On 11 Mar 2022, at 10:18, Juergen Gross wrote: On 11.03.22 10:46, Jan Beulich wrote: On 11.03.2022 10:29, Juergen Gross wrote: On 11.03.22 09:56, Luca Fancellu wrote: On 11 Mar 2022, at 08:09, Juergen Gross wrote: On 10.03.22 18:10, Luca Fancellu w

Re: [PATCH] xen/blkfront: speed up purge_persistent_grants()

2022-03-11 Thread Jens Axboe
On Fri, 11 Mar 2022 11:35:27 +0100, Juergen Gross wrote: > purge_persistent_grants() is scanning the grants list for persistent > grants being no longer in use by the backend. When having found such a > grant, it will be set to "invalid" and pushed to the tail of the list. > > Instead of pushing i

Re: [PATCH v3 1/4] x86/time: further improve TSC / CPU freq calibration accuracy

2022-03-11 Thread Roger Pau Monné
On Mon, Feb 14, 2022 at 10:24:49AM +0100, Jan Beulich wrote: > Calibration logic assumes that the platform timer (HPET or ACPI PM > timer) and the TSC are read at about the same time. This assumption may > not hold when a long latency event (e.g. SMI or NMI) occurs between the > two reads. Reduce t

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-11 Thread Luca Fancellu
> On 11 Mar 2022, at 10:18, Juergen Gross wrote: > > On 11.03.22 10:46, Jan Beulich wrote: >> On 11.03.2022 10:29, Juergen Gross wrote: >>> On 11.03.22 09:56, Luca Fancellu wrote: > On 11 Mar 2022, at 08:09, Juergen Gross wrote: > On 10.03.22 18:10, Luca Fancellu wrote: >> --- /dev

Re: [PATCH 1/2] ns16550: reject IRQ above nr_irqs

2022-03-11 Thread Julien Grall
Hi, On 11/03/2022 10:52, Marek Marczykowski-Górecki wrote: On Fri, Mar 11, 2022 at 10:23:03AM +, Julien Grall wrote: Hi Marek, On 10/03/2022 16:37, Marek Marczykowski-Górecki wrote: On Thu, Mar 10, 2022 at 04:21:50PM +, Julien Grall wrote: Hi, On 10/03/2022 16:12, Roger Pau Monné wr

Re: [PATCH] xen/blkfront: speed up purge_persistent_grants()

2022-03-11 Thread Roger Pau Monné
On Fri, Mar 11, 2022 at 11:35:27AM +0100, Juergen Gross wrote: > purge_persistent_grants() is scanning the grants list for persistent > grants being no longer in use by the backend. When having found such a > grant, it will be set to "invalid" and pushed to the tail of the list. > > Instead of pus

Re: [PATCH 1/2] ns16550: reject IRQ above nr_irqs

2022-03-11 Thread Marek Marczykowski-Górecki
On Fri, Mar 11, 2022 at 10:23:03AM +, Julien Grall wrote: > Hi Marek, > > On 10/03/2022 16:37, Marek Marczykowski-Górecki wrote: > > On Thu, Mar 10, 2022 at 04:21:50PM +, Julien Grall wrote: > > > Hi, > > > > > > On 10/03/2022 16:12, Roger Pau Monné wrote: > > > > On Thu, Mar 10, 2022 at

[xen-unstable test] 168505: tolerable FAIL - PUSHED

2022-03-11 Thread osstest service owner
flight 168505 xen-unstable real [real] flight 168514 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/168505/ http://logs.test-lab.xenproject.org/osstest/logs/168514/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6

Re: [PATCH] xen/blkfront: speed up purge_persistent_grants()

2022-03-11 Thread Jan Beulich
On 11.03.2022 11:35, Juergen Gross wrote: > purge_persistent_grants() is scanning the grants list for persistent > grants being no longer in use by the backend. When having found such a > grant, it will be set to "invalid" and pushed to the tail of the list. > > Instead of pushing it directly to t

Re: [PATCH 2/2] xen/grant-table: remove readonly parameter from functions

2022-03-11 Thread Jan Beulich
On 11.03.2022 11:34, Juergen Gross wrote: > The gnttab_end_foreign_access() family of functions is taking a > "readonly" parameter, which isn't used. Remove it from the function > parameters. > > Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich

Re: [PATCH v6 2/2] xen/x86: Livepatch: support patching CET-enhanced functions

2022-03-11 Thread Julien Grall
Hi Bjoern, On 10/03/2022 07:35, Bjoern Doebel wrote: Xen enabled CET for supporting architectures. The control flow aspect of CET expects functions that can be called indirectly (i.e., via function pointers) to start with an ENDBR64 instruction. Otherwise a control flow exception is raised. Thi

[PATCH] xen/blkfront: speed up purge_persistent_grants()

2022-03-11 Thread Juergen Gross
purge_persistent_grants() is scanning the grants list for persistent grants being no longer in use by the backend. When having found such a grant, it will be set to "invalid" and pushed to the tail of the list. Instead of pushing it directly to the end of the list, add it first to a temporary list

[PATCH] xen/usb: harden xen_hcd against malicious backends

2022-03-11 Thread Juergen Gross
Make sure a malicious backend can't cause any harm other than wrong I/O data. Missing are verification of the request id in a response, sanitizing the reported actual I/O length, and protection against interrupt storms from the backend. Signed-off-by: Juergen Gross --- drivers/usb/host/xen-hcd.

[PATCH] xen/usb: don't use arbitrary_virt_to_machine()

2022-03-11 Thread Juergen Gross
arbitrary_virt_to_machine() is meant to be used in PV guests only. Replace its usage with virt_to_gfn(). Signed-off-by: Juergen Gross --- drivers/usb/host/xen-hcd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/host/xen-hcd.c b/drivers/usb/host/xen-hcd.c inde

[PATCH 1/2] xen/grant-table: remove gnttab_*transfer*() functions

2022-03-11 Thread Juergen Gross
All grant table operations related to the "transfer" functionality are unused currently. There have been users in the old days of the "Xen-o-Linux" kernel, but those didn't make it upstream. So remove the "transfer" related functions. Signed-off-by: Juergen Gross --- drivers/xen/grant-table.c |

[PATCH 2/2] xen/grant-table: remove readonly parameter from functions

2022-03-11 Thread Juergen Gross
The gnttab_end_foreign_access() family of functions is taking a "readonly" parameter, which isn't used. Remove it from the function parameters. Signed-off-by: Juergen Gross --- drivers/block/xen-blkfront.c| 8 ++--- drivers/char/tpm/xen-tpmfront.c | 2 +- drivers/gp

[PATCH 0/2] xen/grant-table: do some cleanup

2022-03-11 Thread Juergen Gross
Cleanup grant table code by removing unused functionality. Juergen Gross (2): xen/grant-table: remove gnttab_*transfer*() functions xen/grant-table: remove readonly parameter from functions drivers/block/xen-blkfront.c| 8 +- drivers/char/tpm/xen-tpmfront.c |

Re: [PATCH 1/2] ns16550: reject IRQ above nr_irqs

2022-03-11 Thread Julien Grall
Hi Marek, On 10/03/2022 16:37, Marek Marczykowski-Górecki wrote: On Thu, Mar 10, 2022 at 04:21:50PM +, Julien Grall wrote: Hi, On 10/03/2022 16:12, Roger Pau Monné wrote: On Thu, Mar 10, 2022 at 05:08:07PM +0100, Jan Beulich wrote: On 10.03.2022 16:47, Roger Pau Monné wrote: On Thu, Mar

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-11 Thread Juergen Gross
On 11.03.22 10:46, Jan Beulich wrote: On 11.03.2022 10:29, Juergen Gross wrote: On 11.03.22 09:56, Luca Fancellu wrote: On 11 Mar 2022, at 08:09, Juergen Gross wrote: On 10.03.22 18:10, Luca Fancellu wrote: --- /dev/null +++ b/xen/common/boot_cpupools.c @@ -0,0 +1,212 @@ +/* SPDX-License-Iden

[xen-4.14-testing test] 168506: tolerable FAIL - PUSHED

2022-03-11 Thread osstest service owner
flight 168506 xen-4.14-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/168506/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-xl 8 xen-boot fail in 168493 pass in 168506 test-armhf-armhf-xl-arndale

Re: alternatives+livepatch testing

2022-03-11 Thread Roger Pau Monné
On Thu, Mar 10, 2022 at 12:27:34PM +, Andrew Cooper wrote: > Hello, > > The recent hiccup with CET-IBT, and discovery that livepatch-build-tools > have been broken for several releases, demonstrates that we do not have > remotely adequate testing in place.  We need to address, and ensure we >

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-11 Thread Jan Beulich
On 11.03.2022 10:29, Juergen Gross wrote: > On 11.03.22 09:56, Luca Fancellu wrote: >>> On 11 Mar 2022, at 08:09, Juergen Gross wrote: >>> On 10.03.22 18:10, Luca Fancellu wrote: --- /dev/null +++ b/xen/common/boot_cpupools.c @@ -0,0 +1,212 @@ +/* SPDX-License-Identifier: GPL-2

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-11 Thread Juergen Gross
On 11.03.22 09:56, Luca Fancellu wrote: Hi Juergen, Thanks for your review On 11 Mar 2022, at 08:09, Juergen Gross wrote: On 10.03.22 18:10, Luca Fancellu wrote: Introduce a way to create different cpupools at boot time, this is particularly useful on ARM big.LITTLE system where there might

RE: [PATCH] MAINTAINERS: Propose Henry Wang as the new release manager

2022-03-11 Thread Henry Wang
Hi George, > -Original Message- > From: George Dunlap > Sent: Friday, March 11, 2022 5:47 AM > To: xen-de...@lists.xen.org > Cc: George Dunlap ; Henry Wang > ; Wei Liu ; Andrew Cooper > ; Jan Beulich ; Roger Pau > Monne ; Stefano Stabellini ; > Julien Grall > Subject: [PATCH] MAINTAINERS

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-11 Thread Luca Fancellu
Hi Juergen, Thanks for your review > On 11 Mar 2022, at 08:09, Juergen Gross wrote: > > On 10.03.22 18:10, Luca Fancellu wrote: >> Introduce a way to create different cpupools at boot time, this is >> particularly useful on ARM big.LITTLE system where there might be the >> need to have differen

Re: [PATCH 4/4] livepatch: differentiate between old and new build systems

2022-03-11 Thread Roger Pau Monné
On Thu, Mar 10, 2022 at 06:01:48PM +, Andrew Cooper wrote: > On 08/03/2022 14:52, Roger Pau Monne wrote: > > On Tue, Mar 08, 2022 at 02:38:47PM +, Andrew Cooper wrote: > >> On 02/03/2022 14:27, Roger Pau Monne wrote: > >>> diff --git a/livepatch-build b/livepatch-build > >>> index 38a92be..

Re: [PATCH v2 6/6] xen/cpupool: Allow cpupool0 to use different scheduler

2022-03-11 Thread Juergen Gross
On 10.03.22 18:10, Luca Fancellu wrote: Currently cpupool0 can use only the default scheduler, and cpupool_create has an harcoded behavior when creating the pool 0 Nit: s/harcoded/hardcoded/ that doesn't allocate new memory for the scheduler, but uses the default scheduler structure in memory

Re: [PATCH v2 2/6] xen/sched: create public function for cpupools creation

2022-03-11 Thread Juergen Gross
On 10.03.22 18:10, Luca Fancellu wrote: Create new public function to create cpupools, can take as parameter the scheduler id or a negative value that means the default Xen scheduler will be used. Signed-off-by: Luca Fancellu --- Changes in v2: - cpupool_create_pool doesn't check anymore for po

Re: [PATCH 3/3] livepatch: correctly handle altinstruction sections

2022-03-11 Thread Jan Beulich
On 11.03.2022 09:12, Roger Pau Monné wrote: > On Fri, Mar 11, 2022 at 08:35:18AM +0100, Jan Beulich wrote: >> On 10.03.2022 16:08, Roger Pau Monne wrote: >>> --- a/common.c >>> +++ b/common.c >>> @@ -249,19 +249,22 @@ int is_text_section(struct section *sec) >>> (sec->sh.sh_flags & SHF_

Re: [PATCH v2 1/6] tools/cpupools: Give a name to unnamed cpupools

2022-03-11 Thread Juergen Gross
On 10.03.22 18:10, Luca Fancellu wrote: With the introduction of boot time cpupools, Xen can create many different cpupools at boot time other than cpupool with id 0. Since these newly created cpupools can't have an entry in Xenstore, create the entry using xen-init-dom0 helper with the usual co

Re: [PATCH v2 3/6] xen/sched: retrieve scheduler id by name

2022-03-11 Thread Juergen Gross
On 10.03.22 18:10, Luca Fancellu wrote: Add a static function to retrieve the scheduler pointer using the scheduler name. Add a public function to retrieve the scheduler id by the scheduler name that makes use of the new static function. Take the occasion to replace open coded scheduler search

Re: [PATCH 3/3] livepatch: correctly handle altinstruction sections

2022-03-11 Thread Roger Pau Monné
On Fri, Mar 11, 2022 at 08:35:18AM +0100, Jan Beulich wrote: > On 10.03.2022 16:08, Roger Pau Monne wrote: > > --- a/common.c > > +++ b/common.c > > @@ -249,19 +249,22 @@ int is_text_section(struct section *sec) > > (sec->sh.sh_flags & SHF_EXECINSTR)); > > } > > > > +#define SEC_MATC

Re: BUG: libxenlight fails to grant permission to access Intel IGD Opregion

2022-03-11 Thread Jan Beulich
On 11.03.2022 06:01, Chuck Zmudzinski wrote: > Further research showed that these two pages at 0xcc490 are for the > Intel IGD opregion, and because this memory is not permitted to be > accessed by the domain, the passthrough of an Intel IGD to a Linux > HVM domain fails, causing a crash of the Lin

Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-11 Thread Juergen Gross
On 10.03.22 18:10, Luca Fancellu wrote: Introduce a way to create different cpupools at boot time, this is particularly useful on ARM big.LITTLE system where there might be the need to have different cpupools for each type of core, but also systems using NUMA can have different cpu pools for each