Re: [RFC PATCH 1/1] xsm: allows system domains to allocate evtchn

2022-03-28 Thread Jan Beulich
On 28.03.2022 22:36, Daniel P. Smith wrote: > During domain construction under dom0less and hyperlaunch it is necessary to > allocate at least the event channel for xenstore and potentially the event > channel for the core console. When dom0less and hyperlaunch are doing their > construction logic

Re: OS Headers hypercall.h/hypervisor.h

2022-03-28 Thread Jan Beulich
On 29.03.2022 00:25, Stefano Stabellini wrote: > On Sat, 26 Mar 2022, Elliott Mitchell wrote: >> The hypercalls implementation for Linux and FreeBSD have two key headers, >> hypercall.h and hypervisor.h. I'm curious why the implementations for >> x86 and ARM* are so distinct. >> >> I found it fair

[xen-unstable test] 168949: trouble: blocked/broken/pass

2022-03-28 Thread osstest service owner
flight 168949 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/168949/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-amd64-prev

[linux-linus test] 168943: trouble: blocked/broken/pass

2022-03-28 Thread osstest service owner
flight 168943 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/168943/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-amd64-pvops

[xen-4.15-testing test] 168936: trouble: blocked/broken/pass

2022-03-28 Thread osstest service owner
flight 168936 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/168936/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-amd64-prev

RE: [PATCH v1 06/13] xen/arm: set up shared memory foreign mapping for borrower domain

2022-03-28 Thread Penny Zheng
Hi Stefano Sorry for the late response, got sidetracked an emergency issue. ;/ > -Original Message- > From: Stefano Stabellini > Sent: Friday, March 18, 2022 10:00 AM > To: Penny Zheng > Cc: xen-devel@lists.xenproject.org; nd ; Stefano Stabellini > ; Julien Grall ; Bertrand Marquis > ;

[xen-4.16-testing test] 168933: trouble: blocked/broken/pass

2022-03-28 Thread osstest service owner
flight 168933 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/168933/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-amd64-prev

[qemu-mainline test] 168940: trouble: blocked/broken/pass

2022-03-28 Thread osstest service owner
flight 168940 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/168940/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-amd64-pvops

Re: Security support status of xnf(4) and xbf(4)

2022-03-28 Thread Theo de Raadt
And I simply why we don't simply delete all that code. Demi Marie Obenour wrote: > On 3/28/22 10:39, Mark Kettenis wrote: > >> Date: Mon, 28 Mar 2022 09:51:22 -0400 > >> From: Demi Marie Obenour > >> > >> On 3/27/22 21:45, Damien Miller wrote: > >>> On Fri, 25 Mar 2022, Demi Marie Obenour wrot

Re: [PATCH v3 2/5] xen: make evtchn_alloc_unbound public

2022-03-28 Thread Stefano Stabellini
On Mon, 28 Mar 2022, Daniel P. Smith wrote: > On 3/25/22 17:05, Stefano Stabellini wrote: > > On Fri, 25 Mar 2022, Julien Grall wrote: > >> So to me, the idea of switching to a "fake" domain or bypassing the check > >> is > >> more appealing. I have a preference for the "fake" domain here. > > >

Re: [RFC PATCH 1/1] xsm: allows system domains to allocate evtchn

2022-03-28 Thread Stefano Stabellini
On Mon, 28 Mar 2022, Daniel P. Smith wrote: > During domain construction under dom0less and hyperlaunch it is necessary to > allocate at least the event channel for xenstore and potentially the event > channel for the core console. When dom0less and hyperlaunch are doing their > construction logic

Re: OS Headers hypercall.h/hypervisor.h

2022-03-28 Thread Stefano Stabellini
On Sat, 26 Mar 2022, Elliott Mitchell wrote: > The hypercalls implementation for Linux and FreeBSD have two key headers, > hypercall.h and hypervisor.h. I'm curious why the implementations for > x86 and ARM* are so distinct. > > I found it fairly straightforward to implement ARM* versions of the

Re: [GIT PULL] xen: branch for v5.18-rc1

2022-03-28 Thread pr-tracker-bot
The pull request you sent on Mon, 28 Mar 2022 11:25:44 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git > for-linus-5.18-rc1-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a701f370b521b2ed0654a9da7cf424b3ff8fa73d Thank you! -- Deet-doot-dot, I

Re: [XEN PATCH] tools/libs/light/libxl_pci.c: explicitly grant access to Intel IGD opregion

2022-03-28 Thread Chuck Zmudzinski
On 3/15/22 7:38 AM, Jan Beulich wrote: On 14.03.2022 04:41, Chuck Zmudzinski wrote: +ret = xc_domain_iomem_permission(CTX->xch, stubdom_domid, + vga_iomem_start, + IGD_OPREGION_PAGES, 1); +if (ret

[xen-4.14-testing test] 168921: trouble: blocked/broken/pass

2022-03-28 Thread osstest service owner
flight 168921 xen-4.14-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/168921/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-amd64-prev

Re: Security support status of xnf(4) and xbf(4)

2022-03-28 Thread Demi Marie Obenour
On 3/28/22 10:39, Mark Kettenis wrote: >> Date: Mon, 28 Mar 2022 09:51:22 -0400 >> From: Demi Marie Obenour >> >> On 3/27/22 21:45, Damien Miller wrote: >>> On Fri, 25 Mar 2022, Demi Marie Obenour wrote: >>> Linux’s netfront and blkfront drivers recently had a security vulnerability (XSA

[libvirt test] 168920: regressions - trouble: blocked/broken/fail/pass

2022-03-28 Thread osstest service owner
flight 168920 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/168920/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-amd64-pvops

[ovmf test] 168926: trouble: blocked/broken

2022-03-28 Thread osstest service owner
flight 168926 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168926/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-amd64-pvops

[linux-5.4 test] 168925: trouble: blocked/broken/pass

2022-03-28 Thread osstest service owner
flight 168925 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/168925/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-amd64-pvops

Re: [PATCH v3 2/5] xen: make evtchn_alloc_unbound public

2022-03-28 Thread Daniel P. Smith
On 3/25/22 17:05, Stefano Stabellini wrote: > On Fri, 25 Mar 2022, Julien Grall wrote: >> So to me, the idea of switching to a "fake" domain or bypassing the check is >> more appealing. I have a preference for the "fake" domain here. > > As a maintainer, I am not opposed to the "fake"/"contructor"

[RFC PATCH 1/1] xsm: allows system domains to allocate evtchn

2022-03-28 Thread Daniel P. Smith
During domain construction under dom0less and hyperlaunch it is necessary to allocate at least the event channel for xenstore and potentially the event channel for the core console. When dom0less and hyperlaunch are doing their construction logic they are executing under the idle domain context. Th

[RFC PATCH 0/1] allow system domains to allocate event channels

2022-03-28 Thread Daniel P. Smith
In the discussion thread on patch `[PATCH v3 2/5] xen: make evtchn_alloc_unbound public` there were a few suggestions on the appropriate way to handle allowing the hypervisor to allocate event channels for domains being constructed by dom0less and hyerplaunch. After taking another look at how to ge

Re: [PATCH v3 5/5] tools: add example application to initialize dom0less PV drivers

2022-03-28 Thread Julien Grall
Hi Stefano, On 23/03/2022 02:50, Stefano Stabellini wrote: On Sat, 29 Jan 2022, Julien Grall wrote: On 28/01/2022 21:33, Stefano Stabellini wrote: +libxl_uuid uuid; +uint64_t v; +int rc; + +printf("Init dom0less domain: %d\n", info->domid); +dom.guest_domid = info->domid; +

Re: [PATCH v4 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-28 Thread Stefano Stabellini
On Mon, 28 Mar 2022, Luca Fancellu wrote: > >> + > >> +if ( !dt_property_read_string(phandle_node, "cpupool-sched", > > > > This should be "node", not phandle_node > > Hi Stefano, > > Yes sorry about that, I didn’t notice it because in my last test I was > creating pools > with default

[xen-unstable test] 168917: trouble: blocked/broken/pass

2022-03-28 Thread osstest service owner
flight 168917 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/168917/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-amd64-prev

Re: [PATCH 2/3] x86/mem_sharing: use dom_cow as placeholder parent until fork is complete

2022-03-28 Thread Tamas K Lengyel
On Mon, Mar 28, 2022 at 9:32 AM Jan Beulich wrote: > > On 22.03.2022 18:41, Tamas K Lengyel wrote: > > For the duration of the fork memop set dom_cow as a placeholder parent. This > > gets updated to the real parent when the fork operation completes, or to > > NULL > > in case the fork failed. >

Re: [PATCH] x86/physdev: Call xsm_unmap_domain_irq earlier

2022-03-28 Thread Daniel P. Smith
On 3/25/22 10:18, Jason Andryuk wrote: > Pull the XSM check up out of unmap_domain_pirq into physdev_map_pirq. > > xsm_unmap_domain_irq was seen denying unmap_domain_pirq when called from > complete_domain_destroy as an RCU callback. The source context was an > unexpected, random domain. Since t

Re: [PATCH v2 3/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD

2022-03-28 Thread Jan Beulich
On 28.03.2022 17:24, Roger Pau Monné wrote: > On Mon, Mar 28, 2022 at 04:21:02PM +0200, Jan Beulich wrote: >> On 15.03.2022 15:18, Roger Pau Monne wrote: >>> @@ -677,14 +680,17 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, >>> uint64_t val) >>> if ( !cp->extd.virt_ssbd ) >>>

Re: [PATCH v2 2/3] amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests

2022-03-28 Thread Jan Beulich
On 28.03.2022 17:19, Roger Pau Monné wrote: > On Mon, Mar 28, 2022 at 04:02:40PM +0200, Jan Beulich wrote: >> On 15.03.2022 15:18, Roger Pau Monne wrote: >>> Allow HVM guests untrapped access to MSR_VIRT_SPEC_CTRL if the >>> hardware has support for it. This requires adding logic in the >>> vm{entr

Re: [PATCH v2 3/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD

2022-03-28 Thread Roger Pau Monné
On Mon, Mar 28, 2022 at 04:21:02PM +0200, Jan Beulich wrote: > On 15.03.2022 15:18, Roger Pau Monne wrote: > > +void amd_init_ssbd(const struct cpuinfo_x86 *c) > > +{ > > + if (cpu_has_ssb_no) > > + return; > > + > > + if (cpu_has_amd_ssbd) { > > + /* Handled by common MSR_S

Re: [PATCH v2 2/3] amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests

2022-03-28 Thread Roger Pau Monné
On Mon, Mar 28, 2022 at 04:02:40PM +0200, Jan Beulich wrote: > On 15.03.2022 15:18, Roger Pau Monne wrote: > > Allow HVM guests untrapped access to MSR_VIRT_SPEC_CTRL if the > > hardware has support for it. This requires adding logic in the > > vm{entry,exit} paths for SVM in order to context switc

Re: [PATCH v3 2/5] xen: make evtchn_alloc_unbound public

2022-03-28 Thread Daniel P. Smith
On 3/25/22 17:05, Stefano Stabellini wrote: > On Fri, 25 Mar 2022, Julien Grall wrote: >> So to me, the idea of switching to a "fake" domain or bypassing the check is >> more appealing. I have a preference for the "fake" domain here. > > As a maintainer, I am not opposed to the "fake"/"contructor"

Re: [PATCH v3 2/5] xen: make evtchn_alloc_unbound public

2022-03-28 Thread Julien Grall
Hi Stefano, On 25/03/2022 21:05, Stefano Stabellini wrote: On Fri, 25 Mar 2022, Julien Grall wrote: > As a contributor, sadly I won't be able to spend a lot of time on this in the following months. If a significant rework is required, I don't think I'll be able to do it, at least not for this X

Re: [PATCH v3 2/5] xen: make evtchn_alloc_unbound public

2022-03-28 Thread Daniel P. Smith
On 3/25/22 12:52, Jason Andryuk wrote: > On Fri, Mar 25, 2022 at 11:46 AM Daniel P. Smith > wrote: >> >> On 3/24/22 20:30, Stefano Stabellini wrote: >>> On Wed, 23 Mar 2022, Jan Beulich wrote: On 23.03.2022 01:22, Stefano Stabellini wrote: > The existing XSM check in evtchn_alloc_unbound

Re: Security support status of xnf(4) and xbf(4)

2022-03-28 Thread Mark Kettenis
> Date: Mon, 28 Mar 2022 09:51:22 -0400 > From: Demi Marie Obenour > > On 3/27/22 21:45, Damien Miller wrote: > > On Fri, 25 Mar 2022, Demi Marie Obenour wrote: > > > >> Linux’s netfront and blkfront drivers recently had a security > >> vulnerability (XSA-396) that allowed a malicious backend to

Re: [PATCH v2 3/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD

2022-03-28 Thread Jan Beulich
On 15.03.2022 15:18, Roger Pau Monne wrote: > +void amd_init_ssbd(const struct cpuinfo_x86 *c) > +{ > + if (cpu_has_ssb_no) > + return; > + > + if (cpu_has_amd_ssbd) { > + /* Handled by common MSR_SPEC_CTRL logic */ > + return; > + } > + > + if (c

Re: [PATCH v2 2/3] amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests

2022-03-28 Thread Jan Beulich
On 15.03.2022 15:18, Roger Pau Monne wrote: > Allow HVM guests untrapped access to MSR_VIRT_SPEC_CTRL if the > hardware has support for it. This requires adding logic in the > vm{entry,exit} paths for SVM in order to context switch between the > hypervisor value and the guest one. The added handler

Re: Security support status of xnf(4) and xbf(4)

2022-03-28 Thread Demi Marie Obenour
On 3/27/22 21:45, Damien Miller wrote: > On Fri, 25 Mar 2022, Demi Marie Obenour wrote: > >> Linux’s netfront and blkfront drivers recently had a security >> vulnerability (XSA-396) that allowed a malicious backend to potentially >> compromise them. In follow-up audits, I found that OpenBSD’s xnf

Re: [PATCH v2 1/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests on top of SPEC_CTRL

2022-03-28 Thread Jan Beulich
On 15.03.2022 15:18, Roger Pau Monne wrote: > Use the logic to set shadow SPEC_CTRL values in order to implement > support for VIRT_SPEC_CTRL (signaled by VIRT_SSBD CPUID flag) for HVM > guests. This includes using the spec_ctrl vCPU MSR variable to store > the guest set value of VIRT_SPEC_CTRL.SSB

Re: [PATCH] osstest: update Debian installer version

2022-03-28 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH] osstest: update Debian installer version"): > Update the configuration file Debian version after having run > mg-debian-installer-update-all. Acked-by: Ian Jackson FTR, in future I think you should apply changes like this one without waiting for a review. It's n

Re: [PATCH 2/3] x86/mem_sharing: use dom_cow as placeholder parent until fork is complete

2022-03-28 Thread Jan Beulich
On 22.03.2022 18:41, Tamas K Lengyel wrote: > For the duration of the fork memop set dom_cow as a placeholder parent. This > gets updated to the real parent when the fork operation completes, or to NULL > in case the fork failed. I am concerned of this, in particular because the state may last acr

[linux-linus test] 168912: trouble: blocked/broken/pass

2022-03-28 Thread osstest service owner
flight 168912 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/168912/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-amd64-pvops

Re: [PATCH] x86/physdev: Call xsm_unmap_domain_irq earlier

2022-03-28 Thread Jan Beulich
On 28.03.2022 13:40, Roger Pau Monné wrote: > On Fri, Mar 25, 2022 at 10:18:26AM -0400, Jason Andryuk wrote: >> Pull the XSM check up out of unmap_domain_pirq into physdev_map_pirq. >> >> xsm_unmap_domain_irq was seen denying unmap_domain_pirq when called from >> complete_domain_destroy as an RCU c

Re: [PATCH] x86/physdev: Call xsm_unmap_domain_irq earlier

2022-03-28 Thread Roger Pau Monné
On Fri, Mar 25, 2022 at 10:18:26AM -0400, Jason Andryuk wrote: > Pull the XSM check up out of unmap_domain_pirq into physdev_map_pirq. > > xsm_unmap_domain_irq was seen denying unmap_domain_pirq when called from > complete_domain_destroy as an RCU callback. The source context was an > unexpected,

Re: [PATCH v2 0/2] xen: Linker scripts synchronization

2022-03-28 Thread Jan Beulich
On 28.03.2022 12:31, Michal Orzel wrote: > Could you please review this series as you did give some comments in v1? I have it on my list of things to look at, yes. Jan > On 22.03.2022 09:02, Michal Orzel wrote: >> This patch series aims to do the first step towards linker scripts >> synchronizat

[qemu-mainline test] 168911: trouble: blocked/broken/pass

2022-03-28 Thread osstest service owner
flight 168911 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/168911/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-amd64-pvops

Re: [PATCH v2 0/2] xen: Linker scripts synchronization

2022-03-28 Thread Michal Orzel
Hi Jan, Could you please review this series as you did give some comments in v1? On 22.03.2022 09:02, Michal Orzel wrote: > This patch series aims to do the first step towards linker scripts > synchronization. Linker scripts for arm and x86 share a lot of common > sections and in order to make th

Re: [PATCH v4 4/6] xen/cpupool: Create different cpupools at boot time

2022-03-28 Thread Luca Fancellu
>> + >> +if ( !dt_property_read_string(phandle_node, "cpupool-sched", > > This should be "node", not phandle_node Hi Stefano, Yes sorry about that, I didn’t notice it because in my last test I was creating pools with default scheduler, I will pay more attention next time, same applies

[xen-4.15-testing test] 168910: trouble: blocked/broken/pass

2022-03-28 Thread osstest service owner
flight 168910 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/168910/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-amd64-prev

[GIT PULL] xen: branch for v5.18-rc1

2022-03-28 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.18-rc1-tag xen: branch for v5.18-rc1 It contains the following patches: - A bunch of minor cleanups - A fix for kexec in Xen dom0 when executed on a high cpu number - A fix for res

[xen-4.16-testing test] 168909: trouble: blocked/broken/pass

2022-03-28 Thread osstest service owner
flight 168909 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/168909/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-amd64-prev

[PATCH] osstest: update Debian installer version

2022-03-28 Thread Roger Pau Monne
Update the configuration file Debian version after having run mg-debian-installer-update-all. Signed-off-by: Roger Pau Monné --- production-config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/production-config b/production-config index 023b8162..9d2e7e0e 100644 --- a/produ

Re: [PATCH 2/2] Changelog: Add __ro_after_init and CET

2022-03-28 Thread Jan Beulich
On 25.03.2022 17:39, Andrew Cooper wrote: > On 09/03/2022 13:03, Jan Beulich wrote: >> On 09.03.2022 13:39, Andrew Cooper wrote: >>> --- a/CHANGELOG.md >>> +++ b/CHANGELOG.md >>> @@ -6,6 +6,12 @@ The format is based on [Keep a >>> Changelog](https://keepachangelog.com/en/1.0.0/) >>> >>> ## [uns

Re: [PATCH 1/2] x86/CET: Remove XEN_SHSTK's dependency on EXPERT

2022-03-28 Thread Roger Pau Monné
On Wed, Mar 09, 2022 at 12:39:35PM +, Andrew Cooper wrote: > CET-SS hardware is now available from multiple vendors, and the feature has > downstream users. Enable it by default. > > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné CET-IBT is already available out of EXPERT, so a

[PATCH] build: generic top-level rule to build individual files

2022-03-28 Thread Jan Beulich
In particular when cross-compiling or having in place other tool chain overrides, invoking make to build individual files (e.g. object, preprocessed, or assembly ones) so far involves putting the various overrides on the command line instead of simply getting them from ./.config. Furthermore this

[ovmf test] 168905: trouble: blocked/broken

2022-03-28 Thread osstest service owner
flight 168905 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/168905/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-amd64-pvops

Re: [PATCH 2/2] Changelog: Add __ro_after_init and CET

2022-03-28 Thread Roger Pau Monné
On Fri, Mar 25, 2022 at 04:39:30PM +, Andrew Cooper wrote: > On 09/03/2022 13:03, Jan Beulich wrote: > > On 09.03.2022 13:39, Andrew Cooper wrote: > >> --- a/CHANGELOG.md > >> +++ b/CHANGELOG.md > >> @@ -6,6 +6,12 @@ The format is based on [Keep a > >> Changelog](https://keepachangelog.com/en/

Re: [PATCH 2/2] Changelog: Add __ro_after_init and CET

2022-03-28 Thread Roger Pau Monné
On Wed, Mar 09, 2022 at 12:39:36PM +, Andrew Cooper wrote: > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné Thanks.