[xen-4.12-testing test] 169239: tolerable FAIL - PUSHED

2022-04-08 Thread osstest service owner
flight 169239 xen-4.12-testing real [real] flight 169255 xen-4.12-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/169239/ http://logs.test-lab.xenproject.org/osstest/logs/169255/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): t

[PATCH 10/27] mm: use bdev_is_zoned in claim_swapfile

2022-04-08 Thread Christoph Hellwig
Use the bdev based helper instead of poking into the queue. Signed-off-by: Christoph Hellwig --- mm/swapfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/swapfile.c b/mm/swapfile.c index 63c61f8b26118..4c7537162af5e 100644 --- a/mm/swapfile.c +++ b/mm/swapfile.c @@ -2

[PATCH 20/27] block: use bdev_discard_alignment in part_discard_alignment_show

2022-04-08 Thread Christoph Hellwig
Use the bdev based alignment helper instead of open coding it. Signed-off-by: Christoph Hellwig Reviewed-by: Martin K. Petersen --- block/partitions/core.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/block/partitions/core.c b/block/partitions/core.c index 240b3fff52

[PATCH 14/27] block: add a bdev_stable_writes helper

2022-04-08 Thread Christoph Hellwig
Add a helper to check the stable writes flag based on the block_device instead of having to poke into the block layer internal request_queue. Signed-off-by: Christoph Hellwig Reviewed-by: Martin K. Petersen --- drivers/md/dm-table.c | 4 +--- fs/super.c | 2 +- include/linux/blkdev

[PATCH 27/27] direct-io: remove random prefetches

2022-04-08 Thread Christoph Hellwig
Randomly poking into block device internals for manual prefetches isn't exactly a very maintainable thing to do. And none of the performance criticil direct I/O implementations still use this library function anyway, so just drop it. Signed-off-by: Christoph Hellwig --- fs/direct-io.c | 32

[PATCH 11/27] block: add a bdev_nonrot helper

2022-04-08 Thread Christoph Hellwig
Add a helper to check the nonrot flag based on the block_device instead of having to poke into the block layer internal request_queue. Signed-off-by: Christoph Hellwig Reviewed-by: Martin K. Petersen Acked-by: David Sterba [btrfs] --- block/ioctl.c | 2 +- drivers/block/l

[PATCH 13/27] block: add a bdev_fua helper

2022-04-08 Thread Christoph Hellwig
Add a helper to check the FUA flag based on the block_device instead of having to poke into the block layer internal request_queue. Signed-off-by: Christoph Hellwig Reviewed-by: Martin K. Petersen --- drivers/block/rnbd/rnbd-srv.c | 3 +-- drivers/target/target_core_iblock.c | 3 +-- fs/i

[PATCH 16/27] block: use bdev_alignment_offset in part_alignment_offset_show

2022-04-08 Thread Christoph Hellwig
Replace the open coded offset calculation with the proper helper. This is an ABI change in that the -1 for a misaligned partition is properly propagated, which can be considered a bug fix and matches what is done on the whole device. Signed-off-by: Christoph Hellwig Reviewed-by: Martin K. Peterse

[PATCH 25/27] block: add a bdev_discard_granularity helper

2022-04-08 Thread Christoph Hellwig
Abstract away implementation details from file systems by providing a block_device based helper to retrieve the discard granularity. Signed-off-by: Christoph Hellwig Reviewed-by: Martin K. Petersen Acked-by: Christoph Böhmwalder [btrfs] Acked-by: Ryusuke Konishi Acked-by: David Sterba [btrfs]

[PATCH 24/27] block: remove QUEUE_FLAG_DISCARD

2022-04-08 Thread Christoph Hellwig
Just use a non-zero max_discard_sectors as an indicator for discard support, similar to what is done for write zeroes. The only places where needs special attention is the RAID5 driver, which must clear discard support for security reasons by default, even if the default stacking rules would allow

[PATCH 26/27] block: decouple REQ_OP_SECURE_ERASE from REQ_OP_DISCARD

2022-04-08 Thread Christoph Hellwig
Secure erase is a very different operation from discard in that it is a data integrity operation vs hint. Fully split the limits and helper infrastructure to make the separation more clear. Signed-off-by: Christoph Hellwig Reviewed-by: Martin K. Petersen Acked-by: Christoph Böhmwalder [drbd] A

[PATCH 22/27] block: refactor discard bio size limiting

2022-04-08 Thread Christoph Hellwig
Move all the logic to limit the discard bio size into a common helper so that it is better documented. Signed-off-by: Christoph Hellwig Reviewed-by: Martin K. Petersen Acked-by: Coly Li --- block/blk-lib.c | 59 - block/blk.h | 14 ---

[PATCH 15/27] block: add a bdev_max_zone_append_sectors helper

2022-04-08 Thread Christoph Hellwig
Add a helper to check the max supported sectors for zone append based on the block_device instead of having to poke into the block layer internal request_queue. Signed-off-by: Christoph Hellwig Acked-by: Damien Le Moal Reviewed-by: Martin K. Petersen Reviewed-by: Johannes Thumshirn --- driver

[PATCH 12/27] block: add a bdev_write_cache helper

2022-04-08 Thread Christoph Hellwig
Add a helper to check the write cache flag based on the block_device instead of having to poke into the block layer internal request_queue. Signed-off-by: Christoph Hellwig Reviewed-by: Martin K. Petersen Acked-by: David Sterba [btrfs] --- drivers/block/rnbd/rnbd-srv.c | 2 +- drivers/bl

[PATCH 17/27] block: use bdev_alignment_offset in disk_alignment_offset_show

2022-04-08 Thread Christoph Hellwig
This does the same as the open coded variant except for an extra branch, and allows to remove queue_alignment_offset entirely. Signed-off-by: Christoph Hellwig Reviewed-by: Martin K. Petersen --- block/genhd.c | 2 +- include/linux/blkdev.h | 8 2 files changed, 1 insertion(+)

[PATCH 19/27] block: remove queue_discard_alignment

2022-04-08 Thread Christoph Hellwig
Just use bdev_alignment_offset in disk_discard_alignment_show instead. That helpers is the same except for an always false branch that doesn't matter in this slow path. Signed-off-by: Christoph Hellwig Reviewed-by: Martin K. Petersen --- block/genhd.c | 2 +- include/linux/blkdev.h | 8

[PATCH 21/27] block: move {bdev,queue_limit}_discard_alignment out of line

2022-04-08 Thread Christoph Hellwig
No need to inline these fairly larger helpers. Also fix the return value to be unsigned, just like the field in struct queue_limits. Signed-off-by: Christoph Hellwig Reviewed-by: Martin K. Petersen --- block/blk-settings.c | 35 +++ include/linux/blkdev.h | 34

[PATCH 18/27] block: move bdev_alignment_offset and queue_limit_alignment_offset out of line

2022-04-08 Thread Christoph Hellwig
No need to inline these fairly larger helpers. Signed-off-by: Christoph Hellwig Reviewed-by: Martin K. Petersen --- block/blk-settings.c | 23 +++ include/linux/blkdev.h | 21 + 2 files changed, 24 insertions(+), 20 deletions(-) diff --git a/block/blk-

[PATCH 23/27] block: add a bdev_max_discard_sectors helper

2022-04-08 Thread Christoph Hellwig
Add a helper to query the number of sectors support per each discard bio based on the block device and use this helper to stop various places from poking into the request_queue to see if discard is supported and if so how much. This mirrors what is done e.g. for write zeroes as well. Signed-off-b

[PATCH 09/27] ntfs3: use bdev_logical_block_size instead of open coding it

2022-04-08 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- fs/ntfs3/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c index 278dcf5024102..cd30e81abbce0 100644 --- a/fs/ntfs3/super.c +++ b/fs/ntfs3/super.c @@ -920,7 +920,7 @

[PATCH 07/27] drbd: cleanup decide_on_discard_support

2022-04-08 Thread Christoph Hellwig
Sanitize the calling conventions and use a goto label to cleanup the code flow. Signed-off-by: Christoph Hellwig Acked-by: Christoph Böhmwalder --- drivers/block/drbd/drbd_nl.c | 68 +++- 1 file changed, 35 insertions(+), 33 deletions(-) diff --git a/drivers/blo

use block_device based APIs in block layer consumers v2

2022-04-08 Thread Christoph Hellwig
Hi Jens, this series cleanups up the block layer API so that APIs consumed by file systems are (almost) only struct block_devic based, so that file systems don't have to poke into block layer internals like the request_queue. I also found a bunch of existing bugs related to partition offsets and

[PATCH 08/27] btrfs: use bdev_max_active_zones instead of open coding it

2022-04-08 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- fs/btrfs/zoned.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c index 1b1b310c3c510..f72cad7391a11 100644 --- a/fs/btrfs/zoned.c +++ b/fs/btrfs/zoned.c @@ -350,7 +350,6

[PATCH 06/27] drbd: use bdev_alignment_offset instead of queue_alignment_offset

2022-04-08 Thread Christoph Hellwig
The bdev version does the right thing for partitions, so use that. Fixes: 9104d31a759f ("drbd: introduce WRITE_SAME support") Signed-off-by: Christoph Hellwig Acked-by: Christoph Böhmwalder --- drivers/block/drbd/drbd_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

[PATCH 05/27] drbd: use bdev based limit helpers in drbd_send_sizes

2022-04-08 Thread Christoph Hellwig
Use the bdev based limits helpers where they exist. Signed-off-by: Christoph Hellwig Acked-by: Christoph Böhmwalder --- drivers/block/drbd/drbd_main.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c

[PATCH 04/27] drbd: remove assign_p_sizes_qlim

2022-04-08 Thread Christoph Hellwig
Fold each branch into its only caller. Signed-off-by: Christoph Hellwig --- drivers/block/drbd/drbd_main.c | 47 +++--- 1 file changed, 20 insertions(+), 27 deletions(-) diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c index 9676a1d214bc5.

[PATCH 01/27] target: remove an incorrect unmap zeroes data deduction

2022-04-08 Thread Christoph Hellwig
For block devices, the SCSI target drivers implements UNMAP as calls to blkdev_issue_discard, which does not guarantee zeroing just because Write Zeroes is supported. Note that this does not affect the file backed path which uses fallocate to punch holes. Fixes: 2237498f0b5c ("target/iblock: Conv

[PATCH 03/27] target: fix discard alignment on partitions

2022-04-08 Thread Christoph Hellwig
Use the proper bdev_discard_alignment helper that accounts for partition offsets. Fixes: c66ac9db8d4a ("[SCSI] target: Add LIO target core v4.0.0-rc6") Signed-off-by: Christoph Hellwig Reviewed-by: Martin K. Petersen --- drivers/target/target_core_device.c | 4 ++-- 1 file changed, 2 insertions

[PATCH 02/27] target: pass a block_device to target_configure_unmap_from_queue

2022-04-08 Thread Christoph Hellwig
The SCSI target drivers is a consumer of the block layer and shoul d generally work on struct block_device. Signed-off-by: Christoph Hellwig Reviewed-by: Martin K. Petersen --- drivers/target/target_core_device.c | 5 +++-- drivers/target/target_core_file.c| 7 --- drivers/target/targe

[xen-4.16-testing test] 169238: regressions - FAIL

2022-04-08 Thread osstest service owner
flight 169238 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/169238/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 6 xen-buildfail REGR. vs. 169194 test-amd64-amd

Re: [PATCH] xen/evtchn: Add design for static event channel signaling for domUs..

2022-04-08 Thread Stefano Stabellini
On Fri, 8 Apr 2022, Stefano Stabellini wrote: > On Wed, 23 Mar 2022, Rahul Singh wrote: > > in dom0less system. This patch introduce the new feature to support the > > signaling between two domUs in dom0less system. > > > > Signed-off-by: Rahul Singh > > --- > > docs/designs/dom0less-evtchn.md |

Re: [PATCH] xen/evtchn: Add design for static event channel signaling for domUs..

2022-04-08 Thread Stefano Stabellini
On Wed, 23 Mar 2022, Rahul Singh wrote: > in dom0less system. This patch introduce the new feature to support the > signaling between two domUs in dom0less system. > > Signed-off-by: Rahul Singh > --- > docs/designs/dom0less-evtchn.md | 96 + > 1 file changed, 96

[xen-4.15-testing test] 169237: tolerable FAIL - PUSHED

2022-04-08 Thread osstest service owner
flight 169237 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/169237/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 169193 test-amd64-amd64-xl-qemut-win7-a

Re: [PATCH] mm, page_alloc: fix build_zonerefs_node()

2022-04-08 Thread Wei Yang
On Thu, Apr 07, 2022 at 11:46:13AM +0200, David Hildenbrand wrote: >On 07.04.22 11:32, Juergen Gross wrote: >> Since commit 9d3be21bf9c0 ("mm, page_alloc: simplify zonelist >> initialization") only zones with free memory are included in a built >> zonelist. This is problematic when e.g. all memory

Re: [PATCH v1 06/13] xen/arm: set up shared memory foreign mapping for borrower domain

2022-04-08 Thread Stefano Stabellini
On Fri, 8 Apr 2022, Julien Grall wrote: > On 08/04/2022 23:18, Stefano Stabellini wrote: > > On Tue, 29 Mar 2022, Penny Zheng wrote: > > > Right now, the memory attribute of static shared memory is RW as default, > > > What if we add memory attribute setting in device tree configuration, > > > some

Re: [PATCH] xen/balloon: fix page onlining when populating new zone

2022-04-08 Thread Wei Yang
On Thu, Apr 07, 2022 at 11:00:33AM +0200, David Hildenbrand wrote: >On 07.04.22 10:50, Juergen Gross wrote: >> On 07.04.22 10:23, David Hildenbrand wrote: >>> On 06.04.22 15:32, Juergen Gross wrote: When onlining a new memory page in a guest the Xen balloon driver is adding it to the ball

[xen-unstable-smoke test] 169250: tolerable all pass - PUSHED

2022-04-08 Thread osstest service owner
flight 169250 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/169250/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v1 06/13] xen/arm: set up shared memory foreign mapping for borrower domain

2022-04-08 Thread Julien Grall
Hi Penny, On 11/03/2022 06:11, Penny Zheng wrote: From: Penny Zheng This commits introduces a new helper guest_physmap_add_shm to set up shared memory foreign mapping for borrower domain. Firstly it should get and take reference of statically shared pages from owner dom_shared. Then it will s

Re: [PATCH v1 06/13] xen/arm: set up shared memory foreign mapping for borrower domain

2022-04-08 Thread Julien Grall
Hi Stefano, On 08/04/2022 23:18, Stefano Stabellini wrote: On Tue, 29 Mar 2022, Penny Zheng wrote: Right now, the memory attribute of static shared memory is RW as default, What if we add memory attribute setting in device tree configuration, sometimes, Users want to specify that borrower domai

RE: [PATCH v1 11/13] xen/arm: store shm-info for deferred foreign memory map

2022-04-08 Thread Stefano Stabellini
On Tue, 29 Mar 2022, Penny Zheng wrote: > > On Fri, 11 Mar 2022, Penny Zheng wrote: > > > From: Penny Zheng > > > > > > In a few scenarios where owner domain, is defined after borrower > > > domain in device tree configuration, then statically shared pages > > > haven't been properly allocated if

RE: [PATCH v1 06/13] xen/arm: set up shared memory foreign mapping for borrower domain

2022-04-08 Thread Stefano Stabellini
On Tue, 29 Mar 2022, Penny Zheng wrote: > Hi Stefano > > Sorry for the late response, got sidetracked an emergency issue. ;/ > > > -Original Message- > > From: Stefano Stabellini > > Sent: Friday, March 18, 2022 10:00 AM > > To: Penny Zheng > > Cc: xen-devel@lists.xenproject.org; nd ; S

Re: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot time

2022-04-08 Thread Stefano Stabellini
On Fri, 8 Apr 2022, Jan Beulich wrote: > On 08.04.2022 13:37, Luca Fancellu wrote: > > > > > >> On 8 Apr 2022, at 10:01, Jan Beulich wrote: > >> > >> On 08.04.2022 10:45, Luca Fancellu wrote: > >>> --- > >>> docs/misc/arm/device-tree/cpupools.txt | 140 + > >>> xen/arch/arm/includ

Re: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot time

2022-04-08 Thread Stefano Stabellini
On Fri, 8 Apr 2022, Luca Fancellu wrote: > Introduce a way to create different cpupools at boot time, this is > particularly useful on ARM big.LITTLE system where there might be the > need to have different cpupools for each type of core, but also > systems using NUMA can have different cpu pools f

[xen-unstable test] 169233: tolerable FAIL - PUSHED

2022-04-08 Thread osstest service owner
flight 169233 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/169233/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 169221 test-armhf-armhf-libvirt 16 save

Re: [PATCH] libxl: Retry QMP PCI device_add

2022-04-08 Thread Jason Andryuk
On Fri, Apr 8, 2022 at 10:56 AM Anthony PERARD wrote: > > On Wed, Mar 30, 2022 at 03:46:56PM -0400, Jason Andryuk wrote: > > PCI device assignment to an HVM with stubdom is potentially racy. First > > the PCI device is assigned to the stubdom via the PV PCI protocol. Then > > QEMU is sent a QMP

[PATCH V7 1/2] libxl: Add support for Virtio disk configuration

2022-04-08 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko This patch adds basic support for configuring and assisting virtio-mmio based virtio-disk backend (emualator) which is intended to run out of Qemu and could be run in any domain. Although the Virtio block device is quite different from traditional Xen PV block device (v

[PATCH V7 2/2] libxl: Introduce basic virtio-mmio support on Arm

2022-04-08 Thread Oleksandr Tyshchenko
From: Julien Grall This patch introduces helpers to allocate Virtio MMIO params (IRQ and memory region) and create specific device node in the Guest device-tree with allocated params. In order to deal with multiple Virtio devices, reserve corresponding ranges. For now, we reserve 1MB for memory r

[PATCH V7 0/2] Virtio support for toolstack on Arm (Was "IOREQ feature (+ virtio-mmio) on Arm")

2022-04-08 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko Hello all. The purpose of this patch series is to add missing virtio-mmio bits to Xen toolstack on Arm. The Virtio support for toolstack [1] was postponed as the main target was to upstream IOREQ/DM support on Arm in the first place. Now, we already have IOREQ suppor

Re: [PATCH v4 2/2] xen: Populate xen.lds.h and make use of its macros

2022-04-08 Thread Julien Grall
Hi Michal, On 05/04/2022 10:16, Michal Orzel wrote: #if defined(BUILD_ID) @@ -109,12 +104,7 @@ SECTIONS *(.data.schedulers) __end_schedulers_array = .; -#ifdef CONFIG_HYPFS - . = ALIGN(8); This will be replaced with POINTER_ALIGN which is 4-byte on Arm32. AFAICT,

Re: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot time

2022-04-08 Thread Julien Grall
Hi Luca, On 08/04/2022 09:45, Luca Fancellu wrote: Introduce a way to create different cpupools at boot time, this is particularly useful on ARM big.LITTLE system where there might be the need to have different cpupools for each type of core, but also systems using NUMA can have different cpu po

[linux-linus test] 169228: regressions - FAIL

2022-04-08 Thread osstest service owner
flight 169228 linux-linus real [real] flight 169246 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/169228/ http://logs.test-lab.xenproject.org/osstest/logs/169246/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run

Re: [PATCH v3] SUPPORT.md: add Dom0less as Supported

2022-04-08 Thread Julien Grall
Hi, On 08/04/2022 01:10, Stefano Stabellini wrote: Add Dom0less to SUPPORT.md to clarify its support status. The feature is mature enough and small enough to make it security supported. Clarify that dom0less DomUs memory is not scrubbed at boot when bootscrub=on or bootscrub=off are passed as X

Re: [PATCH v3] SUPPORT.md: add Dom0less as Supported

2022-04-08 Thread Julien Grall
Hi Henry, On 08/04/2022 01:50, Henry Wang wrote: -Original Message- From: Xen-devel On Behalf Of Stefano Stabellini Sent: Friday, April 8, 2022 8:11 AM To: xen-devel@lists.xenproject.org Cc: sstabell...@kernel.org; jul...@xen.org; andrew.coop...@citrix.com; george.dun...@citrix.com; jbe

Re: [PATCH RFC] evtchn: add early-out to evtchn_move_pirqs()

2022-04-08 Thread Julien Grall
Hi, On 08/04/2022 13:25, Jan Beulich wrote: On 08.04.2022 13:02, Julien Grall wrote: On 08/04/2022 08:16, Jan Beulich wrote: See the code comment. The higher the rate of vCPU-s migrating across pCPU-s, the less useful this attempted optimization actually is. With credit2 the migration rate loo

[ovmf test] 169247: regressions - FAIL

2022-04-08 Thread osstest service owner
flight 169247 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169247/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

Re: [xen-4.12-testing test] 169199: regressions - FAIL

2022-04-08 Thread Stefano Stabellini
On Fri, 8 Apr 2022, Andrew Cooper wrote: > On 08/04/2022 16:26, Roger Pau Monne wrote: > > On Fri, Apr 08, 2022 at 12:24:27PM +0100, Julien Grall wrote: > >> Hi Roger, > >> > >> On 08/04/2022 12:16, Roger Pau Monné wrote: > >>> On Fri, Apr 08, 2022 at 12:08:02PM +0100, Julien Grall wrote: > Hi

[xen-unstable-smoke test] 169236: tolerable all pass - PUSHED

2022-04-08 Thread osstest service owner
flight 169236 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/169236/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [xen-4.12-testing test] 169199: regressions - FAIL

2022-04-08 Thread Andrew Cooper
On 08/04/2022 16:26, Roger Pau Monne wrote: > On Fri, Apr 08, 2022 at 12:24:27PM +0100, Julien Grall wrote: >> Hi Roger, >> >> On 08/04/2022 12:16, Roger Pau Monné wrote: >>> On Fri, Apr 08, 2022 at 12:08:02PM +0100, Julien Grall wrote: Hi, On 08/04/2022 12:01, Roger Pau Monné wrote:

Re: [PATCH] tools/xl: fix vif and vcpupin parse tests

2022-04-08 Thread Anthony PERARD
On Fri, Apr 08, 2022 at 03:31:46PM +0200, Roger Pau Monne wrote: > Current vif and vcpupin parse tests are out of sync. First of all, xl > returns 1 on failure, so replace the expected error code. > > Secondly fix the expected output from some vif tests, as xl will no > longer print the unpopulat

Re: [PATCH v2] x86/irq: Skip unmap_domain_pirq XSM during destruction

2022-04-08 Thread Roger Pau Monné
On Fri, Apr 08, 2022 at 02:04:56PM +0200, Jan Beulich wrote: > On 08.04.2022 13:10, Roger Pau Monné wrote: > > On Thu, Apr 07, 2022 at 10:51:50AM -0400, Jason Andryuk wrote: > >> xsm_unmap_domain_irq was seen denying unmap_domain_pirq when called from > >> complete_domain_destroy as an RCU callback

[ovmf test] 169242: regressions - FAIL

2022-04-08 Thread osstest service owner
flight 169242 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169242/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

Re: [xen-4.12-testing test] 169199: regressions - FAIL

2022-04-08 Thread Roger Pau Monné
On Fri, Apr 08, 2022 at 12:24:27PM +0100, Julien Grall wrote: > Hi Roger, > > On 08/04/2022 12:16, Roger Pau Monné wrote: > > On Fri, Apr 08, 2022 at 12:08:02PM +0100, Julien Grall wrote: > > > Hi, > > > > > > On 08/04/2022 12:01, Roger Pau Monné wrote: > > > > > > I could add a suitable dom0_max

Re: [PATCH] libxl: Retry QMP PCI device_add

2022-04-08 Thread Anthony PERARD
On Wed, Mar 30, 2022 at 03:46:56PM -0400, Jason Andryuk wrote: > PCI device assignment to an HVM with stubdom is potentially racy. First > the PCI device is assigned to the stubdom via the PV PCI protocol. Then > QEMU is sent a QMP command to attach the PCI device to QEMU running > within the stu

[PATCH] tools/xl: fix vif and vcpupin parse tests

2022-04-08 Thread Roger Pau Monne
Current vif and vcpupin parse tests are out of sync. First of all, xl returns 1 on failure, so replace the expected error code. Secondly fix the expected output from some vif tests, as xl will no longer print the unpopulated fields. Signed-off-by: Roger Pau Monné --- We should find a way for th

RE: [PATCH V3 2/2] xen/arm: Add i.MX lpuart early printk support

2022-04-08 Thread Peng Fan
Hi Michal, > -Original Message- > From: Michal Orzel [mailto:michal.or...@arm.com] > Sent: 2022年4月8日 18:23 > To: Peng Fan (OSS) ; sstabell...@kernel.org; > jul...@xen.org; volodymyr_babc...@epam.com; > bertrand.marq...@arm.com > Cc: andrew.coop...@citrix.com; george.dun...@citrix.com; > jb

[PATCH V4 2/2] xen/arm: Add i.MX lpuart early printk support

2022-04-08 Thread Peng Fan (OSS)
From: Peng Fan Signed-off-by: Peng Fan --- xen/arch/arm/Kconfig.debug | 14 +++ xen/arch/arm/arm64/debug-imx-lpuart.inc | 52 + 2 files changed, 66 insertions(+) create mode 100644 xen/arch/arm/arm64/debug-imx-lpuart.inc diff --git a/xen/arch/arm/Kconf

[PATCH V4 1/2] xen/arm: Add i.MX lpuart driver

2022-04-08 Thread Peng Fan (OSS)
From: Peng Fan The i.MX LPUART Documentation: https://www.nxp.com/webapp/Download?colCode=IMX8QMIEC Chatper 13.6 Low Power Universal Asynchronous Receiver/ Transmitter (LPUART) Tested-by: Henry Wang Signed-off-by: Peng Fan --- xen/arch/arm/include/asm/imx-lpuart.h | 64 ++ xen/drivers/ch

[PATCH V4 0/2] xen/arm: add i.MX lpuart and i.MX8QM initial support

2022-04-08 Thread Peng Fan (OSS)
From: Peng Fan V4: Wrong v3 version, some BIT definition are mixed in patch 1,2. V3: Addressed Michal's comments. Add Henry's T-b V2: Per Julien's comments, fix coding style issue, drop unneeded code Add i.MX lpuart driver and i.MX8QM platform support. - lpuart is the uart IP used in i.M

[ovmf test] 169235: regressions - FAIL

2022-04-08 Thread osstest service owner
flight 169235 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169235/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

Re: [PATCH v3] livepatch: account for patch offset when applying NOP patch

2022-04-08 Thread Konrad Rzeszutek Wilk
On Fri, Apr 08, 2022 at 10:19:54AM +0200, Roger Pau Monné wrote: > On Thu, Apr 07, 2022 at 03:44:16PM +, Ross Lagerwall wrote: > > > From: Jan Beulich > > > Sent: Thursday, March 31, 2022 9:42 AM > > > To: Roger Pau Monne > > > Cc: xen-devel@lists.xenproject.org ; Ross > > > Lagerwall ; Konr

[xen-unstable-smoke test] 169231: tolerable all pass - PUSHED

2022-04-08 Thread osstest service owner
flight 169231 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/169231/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v5] x86/vmx: add hvm functions to get/set non-register state

2022-04-08 Thread Tamas K Lengyel
On Thu, Apr 7, 2022 at 11:49 PM Tian, Kevin wrote: > > > From: Lengyel, Tamas > > Sent: Friday, March 25, 2022 9:33 PM > > > > During VM forking and resetting a failed vmentry has been observed due > > to the guest non-register state going out-of-sync with the guest register > > state. For exampl

Re: [PATCH] x86: make "dom0_nodes=" work with credit2

2022-04-08 Thread Jan Beulich
On 08.04.2022 13:20, Dario Faggioli wrote: > On Thu, 2022-04-07 at 15:27 +0200, Jan Beulich wrote: >> --- >> The Fixes: tag isn't very precise - it's rather the commit exposing >> the >> issue by default. I haven't been able to identify the actual commit >> which did introduce the problem; it may w

Re: [PATCH RFC] evtchn: add early-out to evtchn_move_pirqs()

2022-04-08 Thread Jan Beulich
On 08.04.2022 13:02, Julien Grall wrote: > On 08/04/2022 08:16, Jan Beulich wrote: >> See the code comment. The higher the rate of vCPU-s migrating across >> pCPU-s, the less useful this attempted optimization actually is. With >> credit2 the migration rate looks to be unduly high even on mostly id

Re: [PATCH v2 04/14] x86/mm: split set_identity_p2m_entry() into PV and HVM parts

2022-04-08 Thread Jan Beulich
On 08.04.2022 12:55, Roger Pau Monné wrote: > On Wed, Feb 23, 2022 at 04:59:42PM +0100, Jan Beulich wrote: >> ..., moving the former into the new physmap.c. Also call the new >> functions directly from arch_iommu_hwdom_init() and >> vpci_make_msix_hole(), as the PV/HVM split is explicit there. >> >

Re: [PATCH v2 1/2] VT-d: avoid NULL deref on domain_context_mapping_one() error paths

2022-04-08 Thread Jason Andryuk
On Fri, Apr 8, 2022 at 2:03 AM Jan Beulich wrote: > > On 07.04.2022 18:31, Jason Andryuk wrote: > > As I understand it, an RMRR is common with USB controllers for > > implementing legacy mouse & keyboard support. The Cannon Point PCH is > > fairly modern, so I'd expect it to use PCI Express. Xen

Re: [PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools

2022-04-08 Thread Jan Beulich
On 08.04.2022 13:15, Luca Fancellu wrote: > > >> On 8 Apr 2022, at 11:24, Jan Beulich wrote: >> >> On 08.04.2022 11:39, Luca Fancellu wrote: >>> >>> On 8 Apr 2022, at 10:10, Jan Beulich wrote: On 08.04.2022 10:45, Luca Fancellu wrote: > @@ -106,6 +106,8 @@ struct xen_domctl_c

Re: [PATCH v2] x86/irq: Skip unmap_domain_pirq XSM during destruction

2022-04-08 Thread Jan Beulich
On 08.04.2022 13:10, Roger Pau Monné wrote: > On Thu, Apr 07, 2022 at 10:51:50AM -0400, Jason Andryuk wrote: >> xsm_unmap_domain_irq was seen denying unmap_domain_pirq when called from >> complete_domain_destroy as an RCU callback. The source context was an >> unexpected, random domain. Since thi

Re: [xen-4.12-testing test] 169199: regressions - FAIL

2022-04-08 Thread Jan Beulich
On 08.04.2022 13:16, Roger Pau Monné wrote: > On Fri, Apr 08, 2022 at 12:08:02PM +0100, Julien Grall wrote: >> On 08/04/2022 12:01, Roger Pau Monné wrote: > I could add a suitable dom0_max_vcpus parameter to osstest. XenServer > uses 16 for example. I'm afraid a fixed number won'

Re: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot time

2022-04-08 Thread Jan Beulich
On 08.04.2022 13:37, Luca Fancellu wrote: > > >> On 8 Apr 2022, at 10:01, Jan Beulich wrote: >> >> On 08.04.2022 10:45, Luca Fancellu wrote: >>> --- >>> docs/misc/arm/device-tree/cpupools.txt | 140 + >>> xen/arch/arm/include/asm/smp.h | 3 + >>> xen/common/Kconfig

Re: [xen-4.12-testing test] 169199: regressions - FAIL

2022-04-08 Thread Jan Beulich
On 08.04.2022 13:26, Andrew Cooper wrote: > On 08/04/2022 12:08, Julien Grall wrote: >> Hi, >> >> On 08/04/2022 12:01, Roger Pau Monné wrote: > I could add a suitable dom0_max_vcpus parameter to osstest.  XenServer > uses 16 for example. I'm afraid a fixed number won't do, the mor

[ovmf test] 169234: regressions - FAIL

2022-04-08 Thread osstest service owner
flight 169234 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169234/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 168254 build-amd64

Re: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot time

2022-04-08 Thread Luca Fancellu
> On 8 Apr 2022, at 10:01, Jan Beulich wrote: > > On 08.04.2022 10:45, Luca Fancellu wrote: >> --- >> docs/misc/arm/device-tree/cpupools.txt | 140 + >> xen/arch/arm/include/asm/smp.h | 3 + >> xen/common/Kconfig | 7 + >> xen/common/Makefile

Re: [xen-4.12-testing test] 169199: regressions - FAIL

2022-04-08 Thread Andrew Cooper
On 08/04/2022 12:08, Julien Grall wrote: > Hi, > > On 08/04/2022 12:01, Roger Pau Monné wrote: I could add a suitable dom0_max_vcpus parameter to osstest.  XenServer uses 16 for example. >>> >>> I'm afraid a fixed number won't do, the more that iirc there are >>> systems with just a few c

Re: [xen-4.12-testing test] 169199: regressions - FAIL

2022-04-08 Thread Julien Grall
Hi Roger, On 08/04/2022 12:16, Roger Pau Monné wrote: On Fri, Apr 08, 2022 at 12:08:02PM +0100, Julien Grall wrote: Hi, On 08/04/2022 12:01, Roger Pau Monné wrote: I could add a suitable dom0_max_vcpus parameter to osstest. XenServer uses 16 for example. I'm afraid a fixed number won't do,

Re: [PATCH] x86: make "dom0_nodes=" work with credit2

2022-04-08 Thread Dario Faggioli
On Thu, 2022-04-07 at 15:27 +0200, Jan Beulich wrote: > --- > The Fixes: tag isn't very precise - it's rather the commit exposing > the > issue by default. I haven't been able to identify the actual commit > which did introduce the problem; it may well be that it has always > been > there since the

Re: [xen-4.12-testing test] 169199: regressions - FAIL

2022-04-08 Thread Roger Pau Monné
On Fri, Apr 08, 2022 at 12:08:02PM +0100, Julien Grall wrote: > Hi, > > On 08/04/2022 12:01, Roger Pau Monné wrote: > > > > I could add a suitable dom0_max_vcpus parameter to osstest. XenServer > > > > uses 16 for example. > > > > > > I'm afraid a fixed number won't do, the more that iirc there

Re: [PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools

2022-04-08 Thread Luca Fancellu
> On 8 Apr 2022, at 11:24, Jan Beulich wrote: > > On 08.04.2022 11:39, Luca Fancellu wrote: >> >> >>> On 8 Apr 2022, at 10:10, Jan Beulich wrote: >>> >>> On 08.04.2022 10:45, Luca Fancellu wrote: @@ -106,6 +106,8 @@ struct xen_domctl_createdomain { /* Per-vCPU buffer size in bytes

Re: [PATCH v2] x86/irq: Skip unmap_domain_pirq XSM during destruction

2022-04-08 Thread Roger Pau Monné
On Thu, Apr 07, 2022 at 10:51:50AM -0400, Jason Andryuk wrote: > xsm_unmap_domain_irq was seen denying unmap_domain_pirq when called from > complete_domain_destroy as an RCU callback. The source context was an > unexpected, random domain. Since this is a xen-internal operation, > going through th

Re: [xen-4.12-testing test] 169199: regressions - FAIL

2022-04-08 Thread Julien Grall
Hi, On 08/04/2022 12:01, Roger Pau Monné wrote: I could add a suitable dom0_max_vcpus parameter to osstest. XenServer uses 16 for example. I'm afraid a fixed number won't do, the more that iirc there are systems with just a few cores in the pool (and you don't want to over-commit by default).

Re: [PATCH V3 1/2] xen/arm: Add i.MX lpuart driver

2022-04-08 Thread Michal Orzel
Hi Peng, On 07.04.2022 04:44, Peng Fan (OSS) wrote: > From: Peng Fan > > The i.MX LPUART Documentation: > https://www.nxp.com/webapp/Download?colCode=IMX8QMIEC > Chatper 13.6 Low Power Universal Asynchronous Receiver/ > Transmitter (LPUART) > > Tested-by: Henry Wang > Signed-off-by: Peng Fan

Re: [PATCH RFC] evtchn: add early-out to evtchn_move_pirqs()

2022-04-08 Thread Julien Grall
Hi Jan, On 08/04/2022 08:16, Jan Beulich wrote: See the code comment. The higher the rate of vCPU-s migrating across pCPU-s, the less useful this attempted optimization actually is. With credit2 the migration rate looks to be unduly high even on mostly idle systems, and hence on large systems lo

Re: [xen-4.12-testing test] 169199: regressions - FAIL

2022-04-08 Thread Roger Pau Monné
On Fri, Apr 08, 2022 at 11:25:28AM +0200, Jan Beulich wrote: > On 08.04.2022 10:09, Roger Pau Monné wrote: > > On Fri, Apr 08, 2022 at 09:01:11AM +0200, Jan Beulich wrote: > >> On 07.04.2022 10:45, osstest service owner wrote: > >>> flight 169199 xen-4.12-testing real [real] > >>> http://logs.test-

Re: [PATCH v2 04/14] x86/mm: split set_identity_p2m_entry() into PV and HVM parts

2022-04-08 Thread Roger Pau Monné
On Wed, Feb 23, 2022 at 04:59:42PM +0100, Jan Beulich wrote: > ..., moving the former into the new physmap.c. Also call the new > functions directly from arch_iommu_hwdom_init() and > vpci_make_msix_hole(), as the PV/HVM split is explicit there. > > Signed-off-by: Jan Beulich > Reviewed-by: Georg

Re: [PATCH RFC] evtchn: add early-out to evtchn_move_pirqs()

2022-04-08 Thread Julien Grall
Hi Luca, On 08/04/2022 11:41, Luca Fancellu wrote: On 8 Apr 2022, at 08:16, Jan Beulich wrote: See the code comment. The higher the rate of vCPU-s migrating across pCPU-s, the less useful this attempted optimization actually is. With credit2 the migration rate looks to be unduly high even o

Re: [PATCH RFC] evtchn: add early-out to evtchn_move_pirqs()

2022-04-08 Thread Luca Fancellu
> On 8 Apr 2022, at 08:16, Jan Beulich wrote: > > See the code comment. The higher the rate of vCPU-s migrating across > pCPU-s, the less useful this attempted optimization actually is. With > credit2 the migration rate looks to be unduly high even on mostly idle > systems, and hence on large s

Re: [PATCH v6 5/6] arm/dom0less: assign dom0less guests to cpupools

2022-04-08 Thread Juergen Gross
On 08.04.22 11:10, Jan Beulich wrote: On 08.04.2022 10:45, Luca Fancellu wrote: @@ -106,6 +106,8 @@ struct xen_domctl_createdomain { /* Per-vCPU buffer size in bytes. 0 to disable. */ uint32_t vmtrace_size; +uint32_t cpupool_id; This could do with a comment explaining defau

Re: [PATCH v2] x86/irq: Skip unmap_domain_pirq XSM during destruction

2022-04-08 Thread Jan Beulich
On 07.04.2022 16:51, Jason Andryuk wrote: > xsm_unmap_domain_irq was seen denying unmap_domain_pirq when called from > complete_domain_destroy as an RCU callback. The source context was an > unexpected, random domain. Since this is a xen-internal operation, > going through the XSM hook is inappro

Re: [PATCH v6 9/9] xen/x86: remove cf_check attribute from hypercall handlers

2022-04-08 Thread Dario Faggioli
On Thu, 2022-03-24 at 15:01 +0100, Juergen Gross wrote: > Now that the hypercall handlers are all being called directly instead > through a function vector, the "cf_check" attribute can be removed. > > Signed-off-by: Juergen Gross > Reviewed-by: Daniel P. Smith # xsm > parts > Acked-by: Jan Beul

[libvirt test] 169224: regressions - FAIL

2022-04-08 Thread osstest service owner
flight 169224 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/169224/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-arm64-libvirt

  1   2   >